Re: [git pull] mount API series

2018-11-10 Thread Steven Whitehouse
Hi, On 31/10/18 15:38, Eric W. Biederman wrote: Al Viro writes: mount API series from David Howells. Last cycle's objections had been of the "I'd do it differently" variety and with no such differently done variants having ever materialized over several cycles... Absolutely not.

Re: [git pull] mount API series

2018-11-01 Thread Steven Whitehouse
Hi, On 31/10/18 16:18, Linus Torvalds wrote: On Tue, Oct 30, 2018 at 10:34 PM Al Viro wrote: mount API series from David Howells. Last cycle's objections had been of the "I'd do it differently" variety and with no such differently done variants having ever materialized over several

Re: vmalloc with GFP_NOFS

2018-04-24 Thread Steven Whitehouse
Hi, On 24/04/18 17:27, Michal Hocko wrote: Hi, it seems that we still have few vmalloc users who perform GFP_NOFS allocation: drivers/mtd/ubi/io.c fs/ext4/xattr.c fs/gfs2/dir.c fs/gfs2/quota.c fs/nfs/blocklayout/extent_tree.c fs/ubifs/debug.c fs/ubifs/lprops.c fs/ubifs/lpt_commit.c

Re: WARNING: kobject bug in sysfs_warn_dup

2018-04-05 Thread Steven Whitehouse
Hi, On 05/04/18 14:34, Greg KH wrote: On Thu, Apr 05, 2018 at 10:00:04AM +0100, Steven Whitehouse wrote: Hi, On 05/04/18 09:52, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse <swhit...@redhat.com> wrote: Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Th

Re: WARNING: kobject bug in sysfs_warn_dup

2018-04-05 Thread Steven Whitehouse
Hi, On 05/04/18 09:52, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse <swhit...@redhat.com> wrote: Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 8:34 AM, Greg KH <gre...@linuxfoundation.org> wrote: On Wed, Apr 04, 2018 at 07:0

Re: WARNING: kobject bug in sysfs_warn_dup

2018-04-05 Thread Steven Whitehouse
Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 8:34 AM, Greg KH wrote: On Wed, Apr 04, 2018 at 07:02:01PM -0700, syzbot wrote: Hello, syzbot hit the following crash on upstream commit 3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4

Re: WARNING in account_page_dirtied

2018-04-04 Thread Steven Whitehouse
Hi, On 04/04/18 13:36, Jan Kara wrote: Hi, On Wed 04-04-18 10:24:48, Steven Whitehouse wrote: On 03/04/18 13:05, Jan Kara wrote: Hello, On Sun 01-04-18 10:01:02, syzbot wrote: syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00

Re: WARNING in account_page_dirtied

2018-04-04 Thread Steven Whitehouse
Hi, On 03/04/18 13:05, Jan Kara wrote: Hello, On Sun 01-04-18 10:01:02, syzbot wrote: syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Steven Whitehouse
Hi, Can we solve the problem another way, by not taking refs on the glocks when we are iterating over them for the debugfs files? I assume that is the main issue here. We didn't used to take refs since the rcu locking was enough during the walk itself. We used to only keep track of the hash

Re: [RFC PATCH v1 00/13] lru_lock scalability

2018-02-02 Thread Steven Whitehouse
Hi, On 02/02/18 04:18, Daniel Jordan wrote: On 02/01/2018 10:54 AM, Steven Whitehouse wrote: Hi, On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote: lru_lock, a per-node* spinlock that protects an LRU list, is one of the hottest locks in the kernel.  On some workloads on large machines

Re: [RFC PATCH v1 00/13] lru_lock scalability

2018-02-01 Thread Steven Whitehouse
Hi, On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote: lru_lock, a per-node* spinlock that protects an LRU list, is one of the hottest locks in the kernel. On some workloads on large machines, it shows up at the top of lock_stat. One way to improve lru_lock scalability is to introduce an

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

2018-01-17 Thread Steven Whitehouse
On 16/01/18 20:51, Stephen Rothwell wrote: Hi all, Commit 7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use") is missing a Signed-off-by from its author. Bob, can you add that? Steve.

Re: [PATCH 3/3] ima: use fs method to read integrity data (updated patch description)

2017-09-18 Thread Steven Whitehouse
Hi, On 17/09/17 17:38, Al Viro wrote: On Sun, Sep 17, 2017 at 09:34:01AM -0700, Linus Torvalds wrote: Now, I suspect most (all?) do, but that's a historical artifact rather than "design". In particular, the VFS layer used to do the locking for the filesystems, to guarantee the POSIX

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

2017-07-31 Thread Steven Whitehouse
Hi, On 31/07/17 13:22, Jeff Layton wrote: On Mon, 2017-07-31 at 13:05 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:44, Jeff Layton wrote: On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

2017-07-31 Thread Steven Whitehouse
Hi, On 31/07/17 12:44, Jeff Layton wrote: On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote: On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote: On Wed 26-07-17 13:55:36, Jeff Layton

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

2017-07-31 Thread Steven Whitehouse
Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote: On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote: On Wed 26-07-17 13:55:36, Jeff Layton wrote: +int file_write_and_wait(struct file *file) +{ + int err = 0, err2; + struct

Re: [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync

2017-07-28 Thread Steven Whitehouse
Hi, On 28/07/17 13:47, Jeff Layton wrote: On Fri, 2017-07-28 at 13:37 +0100, Steven Whitehouse wrote: Hi, On 27/07/17 13:47, Bob Peterson wrote: - Original Message - On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote: On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton

Re: [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync

2017-07-28 Thread Steven Whitehouse
Hi, On 27/07/17 13:47, Bob Peterson wrote: - Original Message - | On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote: | > On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton wrote: | > > @@ -668,12 +668,14 @@ static int gfs2_fsync(struct file *file, loff_t | > > start, loff_t

Re: Question about SOCK_SEQPACKET

2017-05-05 Thread Steven Whitehouse
Hi, On 05/05/17 11:09, Sowmini Varadhan wrote: On (05/05/17 10:45), Steven Whitehouse wrote: I do wonder if the man page for recvmsg is wrong, or at least a bit confusing. SOCK_SEQPACKET is stream based not message based - it just happens to have EOR markers in the stream. There is no reason

Re: Question about SOCK_SEQPACKET

2017-05-05 Thread Steven Whitehouse
Hi, On 05/05/17 06:18, Sam Kumar wrote: Hello, I have recently had occasion to use SOCK_SEQPACKET sockets on Linux, and noticed some odd behavior. When using sendmsg and recvmsg with these sockets, it seems that the "end-of-record" flag (MSG_EOR) is not being propagated correctly. It depends

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

2016-06-28 Thread Steven Whitehouse
Hi, On 28/06/16 03:08, Dave Chinner wrote: On Fri, Jun 24, 2016 at 02:50:11PM -0500, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls into

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

2016-06-26 Thread Steven Whitehouse
Hi, I think the idea looks good. A couple of comments below though... On 24/06/16 20:50, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls

Re: [Cluster-devel] [PATCH 0/2] scop GFP_NOFS api

2016-04-29 Thread Steven Whitehouse
Hi, On 29/04/16 06:35, NeilBrown wrote: On Tue, Apr 26 2016, Michal Hocko wrote: Hi, we have discussed this topic at LSF/MM this year. There was a general interest in the scope GFP_NOFS allocation context among some FS developers. For those who are not aware of the discussion or the issue I

Re: [PATCH v5 10/11] block: remove bio_get_nr_vecs()

2015-07-07 Thread Steven Whitehouse
Hi, On 06/07/15 18:21, Ming Lin wrote: On Mon, Jul 6, 2015 at 3:58 AM, Steven Whitehouse swhit...@redhat.com wrote: Hi, On 06/07/15 08:44, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com We can always fill up the bio now, no need to estimate the possible size based on queue

Re: [PATCH v5 10/11] block: remove bio_get_nr_vecs()

2015-07-06 Thread Steven Whitehouse
Hi, On 06/07/15 08:44, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com We can always fill up the bio now, no need to estimate the possible size based on queue parameters. [snip] diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 2c1ae86..64d3116 100644 --- a/fs/gfs2/lops.c

Re: [RFC 1/1 linux-next] gfs2: convert simple_str to kstr

2015-04-30 Thread Steven Whitehouse
anyway. Acked-by: Steven Whitehouse swhit...@redhat.com Steve. --- fs/gfs2/sys.c | 56 1 file changed, 44 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index ae8e881..436bdeb 100644 --- a/fs/gfs2/sys.c +++ b

Re: linux-next: Tree for Apr 20 (gfs2)

2015-04-20 Thread Steven Whitehouse
Hi, On 20/04/15 16:40, Randy Dunlap wrote: On 04/19/15 22:45, Stephen Rothwell wrote: Hi all, Please do not add any v4.2 material to your linux-next included trees until after v4.1-rc1 is released. Changes since 20150415: on i386: ERROR: __divdi3 [fs/gfs2/gfs2.ko] undefined! These

Re: GFS2: Pull request (merge window)

2015-04-15 Thread Steven Whitehouse
Hi, On 15/04/15 00:16, Linus Torvalds wrote: On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson rpete...@redhat.com wrote: There's another that adds me as a GFS2 co-maintainer [...] So generally, when I start getting pull requests from different people, I'd like to see a previous separate

Re: [Cluster-devel] [PATCH 08/16] gfs2: use is_xxx_kiocb instead of filp-fl_flags

2015-04-07 Thread Steven Whitehouse
Hi, On 04/04/15 20:13, Dmitry Monakhov wrote: Cc: cluster-de...@redhat.com Signed-off-by: Dmitry Monakhov dmonak...@openvz.org Acked-by: Steven Whitehouse swhit...@redhat.com Steve. --- fs/gfs2/file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2

Re: [PATCH 1/1] gfs2: incorrect check for debugfs returns

2015-03-24 Thread Steven Whitehouse
reasonable to me: Acked-by: Steven Whitehouse swhit...@redhat.com Steve. Signed-off-by: Chengyu Song cson...@gatech.edu --- fs/gfs2/glock.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index

Re: [PATCH] fs: record task name which froze superblock

2015-02-18 Thread Steven Whitehouse
Hi, On 18/02/15 09:13, Jan Kara wrote: On Wed 18-02-15 10:34:55, Alexey Dobriyan wrote: On Mon, Feb 16, 2015 at 10:38:52AM +0100, Jan Kara wrote: On Sat 14-02-15 21:55:24, Alexey Dobriyan wrote: Freezing and thawing are separate system calls, task which is supposed to thaw

[PATCH 2/5] GFS2: fix sprintf format specifier

2015-02-10 Thread Steven Whitehouse
From: alex chen alex.c...@huawei.com Sprintf format specifier %d and %u are mixed up in gfs2_recovery_done() and freeze_show(). So correct them. Signed-off-by: Alex Chen alex.c...@huawei.com Reviewed-by: Joseph Qi joseph...@huawei.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

[PATCH 4/5] GFS2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-10 Thread Steven Whitehouse
...@linuxhacker.ru Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index c5a34f0..6371192 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -1896,7 +1896,8 @@ static int leaf_dealloc(struct gfs2_inode *dip, u32 index, u32 len, ht = kzalloc(size

[PATCH 1/5] GFS2: Eliminate __gfs2_glock_remove_from_lru

2015-02-10 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com Since the only caller of function __gfs2_glock_remove_from_lru locks the same spin_lock as gfs2_glock_remove_from_lru, the functions can be combined. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

[PATCH 3/5] GFS2: Eliminate a nonsense goto

2015-02-10 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch just removes a goto that did nothing. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9054002..73c72253 100644 --- a/fs/gfs2/inode.c +++ b

[PATCH 5/5] GFS2: Fix crash during ACL deletion in acl max entry check in gfs2_set_acl()

2015-02-10 Thread Steven Whitehouse
From: Andrew Elble awe...@rit.edu Fixes: e01580bf9e (gfs2: use generic posix ACL infrastructure) Reported-by: Eric Meddaugh etm...@rit.edu Tested-by: Eric Meddaugh etm...@rit.edu Signed-off-by: Andrew Elble awe...@rit.edu Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2

GFS2: Pre-pull patch posting

2015-02-10 Thread Steven Whitehouse
This time we have mostly clean ups. There is a bug fix for a NULL dereference relating to ACLs, and another which improves (but does not fix entirely) an allocation fall-back code path. The other three patches are small clean ups. Steve. -- To unsubscribe from this list: send the line

GFS2: Pull request (merge window)

2015-02-10 Thread Steven Whitehouse
Hi, Please consider pulling the following changes, Steve. -- This time we have mostly clean ups. There is a bug fix for a NULL dereference relating to ACLs, and another which improves (but does not fix entirely) an

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-04 Thread Steven Whitehouse
Hi, On 04/02/15 07:13, Oleg Drokin wrote: Hello! On Feb 3, 2015, at 5:33 PM, Dave Chinner wrote: I also wonder if vmalloc is still very slow? That was the case some time ago when I noticed a problem in directory access times in gfs2, which made us change to use kmalloc with a vmalloc fallback

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-02 Thread Steven Whitehouse
Hi, On 02/02/15 08:11, Dave Chinner wrote: On Mon, Feb 02, 2015 at 01:57:23AM -0500, Oleg Drokin wrote: Hello! On Feb 2, 2015, at 12:37 AM, Dave Chinner wrote: On Sun, Feb 01, 2015 at 10:59:54PM -0500, gr...@linuxhacker.ru wrote: From: Oleg Drokin gr...@linuxhacker.ru leaf_dealloc uses

GFS2: Pull request (merge window)

2014-12-08 Thread Steven Whitehouse
Hi, Please consider pulling the following changes, Steve. -- The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4: Linux 3.18-rc3 (2014-11-02 15:01:51 -0800) are available in the git

Re: [Cluster-devel] gfs2: gfs2_dir_get_hash_table(): avoiding deferred vfree() is easy here...

2014-11-20 Thread Steven Whitehouse
Hi, All five patches now in the GFS2 -nmw tree. Thanks, Steve. On 20/11/14 05:19, Al Viro wrote: vfree() is allowed under spinlock these days, but it's cheaper when it doesn't step into deferred case and here it's very easy to avoid. Signed-off-by: Al Viro v...@zeniv.linux.org.uk ---

Re: [PATCH 1/1] GFS2: Deletion of unnecessary checks before two function calls

2014-11-18 Thread Steven Whitehouse
Hi, Now in the GFS2 -nmw git tree. Thanks, Steve. On 18/11/14 10:35, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Tue, 18 Nov 2014 11:31:23 +0100 The functions iput() and put_pid() test whether their argument is NULL and then return immediately. Thus the

Re: [Cluster-devel] [PATCH v5 6/7] fs: pass iocb to generic_write_sync

2014-11-06 Thread Steven Whitehouse
also used generic_write_sync to implement a crude version of fallocate. It has been switched to use an open coded variant instead. Signed-off-by: Christoph Hellwig h...@lst.de GFS2 bits: Acked-by: Steven Whitehouse swhit...@redhat.com I know that Andy Price has some work in this area

Re: [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()

2014-10-10 Thread Steven Whitehouse
Hi, On 09/10/14 21:49, Fabian Frederick wrote: No need to store gfs2_dir_check result and test it before returning. Signed-off-by: Fabian Frederick f...@skynet.be Since I've already sent a pull request for this merge window, and this is not urgent, I'll keep this one and use it to start off

Re: [PATCH 1/1] GFS2: use _RET_IP_ instead of (unsigned long)__builtin_return_address(0)

2014-10-08 Thread Steven Whitehouse
Hi, Apologies for taking so long - I've added this into the -nmw tree now. Thanks, Steve. On 03/10/14 19:15, Fabian Frederick wrote: use macro definition Signed-off-by: Fabian Frederick f...@skynet.be --- fs/gfs2/glock.c | 4 ++-- fs/gfs2/glops.c | 2 +- fs/gfs2/trans.c | 2 +- 3

[PATCH 1/4] GFS2: fix bad inode i_goal values during block allocation

2014-10-08 Thread Steven Whitehouse
-i_no_addr field is invalid and so, the fix in gfs2_inplace_reserve() as per 1) won't work in this scenario. We need to catch and fix it sooner in the parent dir itself (gfs2_create_inode()), before it is copied to the new inode. Signed-off-by: Abhi Das a...@redhat.com Signed-off-by: Steven

GFS2: Pre-pull patch posting (merge window)

2014-10-08 Thread Steven Whitehouse
Hi, Not a huge amount this time... just four patches. This time we have a couple of bug fixes, one relating to bad i_goal values which are now ignored (i_goal is basically a hint so it is safe to so this) and another relating to the saving of the dirent location during rename. There is one

[PATCH 3/4] GFS2: Use gfs2_rbm_incr in rgblk_free

2014-10-08 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch speeds up GFS2 unlink operations by using function gfs2_rbm_incr rather than continuously calculating the rbm. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/rgrp.c b/fs

[PATCH 2/4] GFS2: Make rename not save dirent location

2014-10-08 Thread Steven Whitehouse
is not saved and the buffer_head is released as per previous behavior. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 1a349f9..5d4261f 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -2100,8

[PATCH 4/4] GFS2: use _RET_IP_ instead of (unsigned long)__builtin_return_address(0)

2014-10-08 Thread Steven Whitehouse
From: Fabian Frederick f...@skynet.be use macro definition Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 7f513b1..8f0c19d 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -811,7

GFS2: Pull request (merge window)

2014-10-08 Thread Steven Whitehouse
Hi, Please consider pulling the following changes, Steve. - The following changes since commit 37504a3be90b69438426d74ccf467a9fe192932b: Merge tag 'gfs2-fixes' of

GFS2: Pull request (fixes)

2014-09-16 Thread Steven Whitehouse
Hi, Please consider pulling the following fixes for GFS2, Steve. The following changes since commit 372b1dbdd1fb5697890b937228d93cfd9c734c90: Merge branch 'for-linus' of git://git.samba.org/sfrench/cifs-2.6

GFS2: Pre-pull patch posting (fixes)

2014-09-15 Thread Steven Whitehouse
Hi, Here are a number of small fixes for GFS2. There is a fix for FIEMAP on large sparse files, a negative dentry hashing fix, a fix for flock, and a bug fix relating to d_splice_alias usage. There are also (patches 1 and 5) a couple of updates which are less critical, but small and low risk.

[PATCH 1/6] GFS2: fs/gfs2/super.c: replace seq_printf by seq_puts

2014-09-15 Thread Steven Whitehouse
From: Fabian Frederick f...@skynet.be fix checkpatch warnings: WARNING: Prefer seq_puts to seq_printf Cc: cluster-de...@redhat.com Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 2607ff1

[PATCH 2/6] GFS2: Change maxlen variables to size_t

2014-09-15 Thread Steven Whitehouse
...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index e6ee5b6..f0b945a 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -359,7 +359,7 @@ static inline void release_metapath(struct metapath *mp) * Returns: The length of the extent

[PATCH 4/6] GFS2: Hash the negative dentry during inode lookup

2014-09-15 Thread Steven Whitehouse
Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index e62e594..9317ddc 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -840,8 +840,10 @@ static struct dentry *__gfs2_lookup(struct inode *dir, struct dentry *dentry

[PATCH 5/6] GFS2: Don't use MAXQUOTAS value

2014-09-15 Thread Steven Whitehouse
Signed-off-by: Jan Kara j...@suse.cz Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index 67d310c..39e7e99 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h @@ -262,6 +262,9 @@ struct gfs2_holder { unsigned long gh_ip; }; +/* Number

[PATCH 3/6] GFS2: Request demote when a try flock fails

2014-09-15 Thread Steven Whitehouse
of time for the demote to occur. Then it tries again, for an increasing amount of time. Subsequent attempts to gain the try lock don't use _1CB so that only one callback is issued. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs

[PATCH 6/6] GFS2: fix d_splice_alias() misuses

2014-09-15 Thread Steven Whitehouse
Viro v...@zeniv.linux.org.uk Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9317ddc..fc8ac2e 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -626,8 +626,10 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry

Re: [PATCH V3] seq_file: Document seq_open_private(), seq_release_private()

2014-08-18 Thread Steven Whitehouse
they will become more widely used. Signed-off-by: Rob Jones rob.jo...@codethink.co.uk Acked-by: Steven Whitehouse swhit...@redhat.com Steve. --- Documentation/filesystems/seq_file.txt | 33 1 file changed, 33 insertions(+) diff --git a/Documentation/filesystems

Re: [PATCH] seq_file: Allow private data to be supplied on seq_open

2014-08-07 Thread Steven Whitehouse
Hi, On 07/08/14 13:58, Rob Jones wrote: [snip] On a related subject, Having looked at a few uses of seq_file, I must say that some users seem to make assumptions about the internal workings of the module. Dangerous behaviour as only some behaviours are documented. e.g. The behaviour that

Re: [Linux-kernel] [PATCH] seq_file: Allow private data to be supplied on seq_open

2014-08-07 Thread Steven Whitehouse
Hi, On 07/08/14 15:16, Rob Jones wrote: On 07/08/14 15:09, Rob Jones wrote: Hi Steve, On 07/08/14 14:32, Steven Whitehouse wrote: Hi, On 07/08/14 13:58, Rob Jones wrote: [snip] On a related subject, Having looked at a few uses of seq_file, I must say that some users seem to make

Re: [Cluster-devel] [RFC PATCH 0/2] dirreadahead system call

2014-07-29 Thread Steven Whitehouse
Hi, On 28/07/14 22:19, Andreas Dilger wrote: On Jul 28, 2014, at 6:52 AM, Abhijith Das a...@redhat.com wrote: OnJuly 26, 2014 12:27:19 AM Andreas Dilger adil...@dilger.ca wrote: Is there a time when this doesn't get called to prefetch entries in readdir() order? It isn't clear to me what

Re: [Cluster-devel] [RFC] readdirplus implementations: xgetdents vs dirreadahead syscalls

2014-07-25 Thread Steven Whitehouse
Hi, On 25/07/14 18:52, Zach Brown wrote: On Fri, Jul 25, 2014 at 01:37:19PM -0400, Abhijith Das wrote: Hi all, The topic of a readdirplus-like syscall had come up for discussion at last year's LSF/MM collab summit. I wrote a couple of syscalls with their GFS2 implementations to get at a

Re: [Cluster-devel] [RFC] readdirplus implementations: xgetdents vs dirreadahead syscalls

2014-07-25 Thread Steven Whitehouse
Hi, On 25/07/14 19:28, Zach Brown wrote: On Fri, Jul 25, 2014 at 07:08:12PM +0100, Steven Whitehouse wrote: Hi, On 25/07/14 18:52, Zach Brown wrote: [snip] Hmm. Have you tried plumbing these read-ahead calls in under the normal getdents() syscalls? We don't have a filereadahead() syscall

[PATCH 2/8] GFS2: Fix race in glock lru glock disposal

2014-07-18 Thread Steven Whitehouse
iteration. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 278fae5..c1e5b12 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -1406,12 +1406,16 @@ __acquires(lru_lock) gl = list_entry(list-next, struct gfs2_glock, gl_lru

[PATCH 8/8] GFS2: fs/gfs2/rgrp.c: kernel-doc warning fixes

2014-07-18 Thread Steven Whitehouse
From: Fabian Frederick f...@skynet.be Cc: cluster-de...@redhat.com Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index db629d1..f4cb9c0 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -337,7

[PATCH 5/8] GFS2: Allow flocks to use normal glock dq rather than dq_wait

2014-07-18 Thread Steven Whitehouse
, and was therefore safer. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 4fc3a30..491e8e0 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -991,7 +991,7 @@ static int do_flock(struct file *file

[PATCH 7/8] GFS2: memcontrol: Spelling s/invlidate/invalidate/

2014-07-18 Thread Steven Whitehouse
From: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: cluster-de...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index fc11007..2ffc67d 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2

[PATCH 6/8] GFS2: Allow caching of glocks for flock

2014-07-18 Thread Steven Whitehouse
cause glock hangs, especially in cases where the flocks are held in Shared (SH) mode. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 491e8e0..26b3f95 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2

[PATCH 3/8] GFS2: Use GFP_NOFS when allocating glocks

2014-07-18 Thread Steven Whitehouse
so that it is no longer called while another glock is held, but that doesn't look at all easy, so GFP_NOFS is the best solution for the time being. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index c1e5b12..b703dcc 100644 --- a/fs/gfs2

[PATCH 4/8] GFS2: replace count*size kzalloc by kcalloc

2014-07-18 Thread Steven Whitehouse
From: Fabian Frederick f...@skynet.be kcalloc manages count*sizeof overflow. Cc: cluster-de...@redhat.com Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c index 91f274d..4fafea1 100644

GFS2: Pre-pull patch posting (fixes)

2014-07-18 Thread Steven Whitehouse
Hi, Here are the current set of small fixes relating to GFS2. This patch set contains two minor docs/spelling fixes, some fixes for flock, a change to use GFP_NOFS to avoid recursion on a rarely used code path and a fix for a race relating to the glock lru, Steve. -- To unsubscribe from this

[PATCH 1/8] GFS2: Only wait for demote when last holder is dequeued

2014-07-18 Thread Steven Whitehouse
is blocked. This problem is especially apparent when dealing with nested flocks. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index c355f73..278fae5 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2

GFS2: Pull request (fixes)

2014-07-18 Thread Steven Whitehouse
/invlidate/invalidate/ Steven Whitehouse (2): GFS2: Fix race in glock lru glock disposal GFS2: Use GFP_NOFS when allocating glocks fs/gfs2/file.c | 4 ++-- fs/gfs2/glock.c| 14 +- fs/gfs2/glops.c| 4 ++-- fs/gfs2/lock_dlm.c | 4 ++-- fs/gfs2/rgrp.c | 4

Re: [PATCH -trivial 4/4] GFS2: memcontrol: Spelling s/invlidate/invalidate/

2014-07-03 Thread Steven Whitehouse
Hi, Now in the -nmw tree. Thanks, Steve. On 29/06/14 11:21, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Steven Whitehouse swhit...@redhat.com Cc: cluster-de...@redhat.com --- fs/gfs2/glops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 1/1] fs/gfs2/rgrp.c: kernel-doc warning fixes

2014-07-03 Thread Steven Whitehouse
Hi, This and the seq_puts patch are now both in the -nmw tree. Thanks, Steve. On 02/07/14 21:05, Fabian Frederick wrote: Cc: Steven Whitehouse swhit...@redhat.com Cc: cluster-de...@redhat.com Signed-off-by: Fabian Frederick f...@skynet.be --- fs/gfs2/rgrp.c | 4 ++-- 1 file changed, 2

Re: [PATCH 1/1] fs/gfs2/lock_dlm.c: replace count*size kzalloc by kcalloc

2014-06-26 Thread Steven Whitehouse
Hi, Now in the -nmw git tree. Thanks, Steve. On 25/06/14 19:40, Fabian Frederick wrote: kcalloc manages count*sizeof overflow. Cc: Steven Whitehouse swhit...@redhat.com Cc: cluster-de...@redhat.com Signed-off-by: Fabian Frederick f...@skynet.be --- fs/gfs2/lock_dlm.c | 4 ++-- 1 file

Re: [PATCH 0/2] Update wait_on_bit functions

2014-06-23 Thread Steven Whitehouse
to submit this in the rc1 - rc2 window, but that happened while I was on leave...) Thanks, NeilBrown Acked-by: Steven Whitehouse swhit...@redhat.com Steve. --- NeilBrown (2): SCHED: remove proliferation of wait_on_bit action functions. SCHED: allow wait_on_bit_action functions

GFS2: Pull request (merge window)

2014-06-04 Thread Steven Whitehouse
Hi, Please consider pulling the following changes, Steve. - The following changes since commit 6ca2a88ad820af56535ed1e6936e0490cb6ec6dc: Merge branch 'x86-urgent-for-linus' of

[PATCH 1/6] GFS2: quotas not being refreshed in gfs2_adjust_quota

2014-06-03 Thread Steven Whitehouse
-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index c4e..6193896 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -778,6 +778,7 @@ get_a_page: i_size_write(inode, size); inode-i_mtime = inode-i_atime = CURRENT_TIME

[PATCH 5/6] GFS2: fs/gfs2/file.c: kernel-doc warning fixes

2014-06-03 Thread Steven Whitehouse
From: Fabian Frederick f...@skynet.be Related function is not gfs2_set_flags but do_gfs2_set_flags Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index

[PATCH 2/6] GFS2: lops.c: replace 0 by NULL for pointers

2014-06-03 Thread Steven Whitehouse
From: Fabian Frederick f...@skynet.be Sparse warning: fs/gfs2/lops.c:78:29: warning: Using plain integer as NULL pointer Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/lops.c b

[PATCH 3/6] GFS2: remove transaction glock

2014-06-03 Thread Steven Whitehouse
...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index ce62dca..5a49b03 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -431,7 +431,7 @@ static int gfs2_jdata_writepages(struct address_space *mapping, ret = gfs2_write_cache_jdata

[PATCH 4/6] GFS2: fs/gfs2/bmap.c: kernel-doc warning fixes

2014-06-03 Thread Steven Whitehouse
From: Fabian Frederick f...@skynet.be Fix 2 typos and move one definition which was between function comments and function definition (yet another kernel-doc warning) Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Steven Whitehouse swhit

[PATCH 6/6] GFS2: Prevent recovery before the local journal is set

2014-06-03 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch uses a completion to prevent dlm's recovery process from referencing and trying to recover a journal before a journal has been opened. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

GFS2: Pre-pull patch posting (merge window)

2014-06-03 Thread Steven Whitehouse
Hi, This must be about the smallest merge window patch set ever for GFS2. It is probably also the first one without a single patch from me. That is down to a combination of factors, and I have some things in the works that are not quite ready yet, that I hope to put in next time around.

Re: [RFC 25/32] gfs2: convert to struct inode_time

2014-06-02 Thread Steven Whitehouse
struct inode_time in gfs2. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Steven Whitehouse swhit...@redhat.com Cc: cluster-de...@redhat.com --- fs/gfs2/dir.c | 6 +++--- fs/gfs2/glops.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) Subject to deciding the internal representation

Re: [PATCH 1/1] fs/gfs2/file.c: kernel-doc warning fixes

2014-05-16 Thread Steven Whitehouse
Hi, I've added this patch, plus the one you sent yesterday to the GFS2 -nmw tree. Thanks, Steve. On 15/05/14 17:57, Fabian Frederick wrote: Related function is not gfs2_set_flags but do_gfs2_set_flags Cc: Steven Whitehouse swhit...@redhat.com Cc: Andrew Morton a...@linux-foundation.org

Re: [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers

2014-04-28 Thread Steven Whitehouse
Hi, On 26/04/14 19:57, Fabian Frederick wrote: Sparse warning: fs/gfs2/lops.c:78:29: warning: Using plain integer as NULL pointer Cc: Steven Whitehouse swhit...@redhat.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/gfs2/lops.c | 2 +- 1

Re: GFS2: Pull request (merge window)

2014-04-07 Thread Steven Whitehouse
Hi, On Fri, 2014-04-04 at 14:52 -0700, Linus Torvalds wrote: On Tue, Apr 1, 2014 at 4:15 PM, Steven Whitehouse swhit...@redhat.com wrote: Please consider pulling the following changes This pull request is also missing shortlog and diffstat, like Jeff Layton's did. Did we have some

Re: [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC

2014-04-02 Thread Steven Whitehouse
Hi, On Wed, 2014-04-02 at 04:10 -0700, Christoph Hellwig wrote: On Tue, Apr 01, 2014 at 02:25:45PM -0400, Richard Hansen wrote: For the flags parameter, POSIX says Either MS_ASYNC or MS_SYNC shall be specified, but not both. [1] There was already a test for the both condition. Add a test

GFS2: Pre-pull patch posting (merge window)

2014-04-01 Thread Steven Whitehouse
Hi, Here is the current content of the GFS2 -nmw tree for the current merge window. One of the main highlights this time, is not the patches themselves but instead the widening contributor base. It is good to see that interest is increasing in GFS2, and I'd like to thank all the contributors to

[PATCH 27/29] GFS2: Fix return value in slot_get()

2014-04-01 Thread Steven Whitehouse
From: Abhi Das a...@redhat.com ENOSPC was being returned in slot_get inspite of successful execution of the function. This patch fixes this return code. Signed-off-by: Abhi Das a...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c

[PATCH 28/29] GFS2: Fix uninitialized VFS inode in gfs2_create_inode

2014-04-01 Thread Steven Whitehouse
: rhbz#1059808 Signed-off-by: Abhi Das a...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index ef26ed9..bdf70c1 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h @@ -371,6 +371,7 @@ enum { GIF_ALLOC_FAILED= 2

[PATCH 29/29] GFS2: Fix address space from page function

2014-04-01 Thread Steven Whitehouse
a...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index 005e468..2cf09b6 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c @@ -97,6 +97,11 @@ const struct address_space_operations gfs2_meta_aops = { .releasepage

[PATCH 26/29] GFS2: inline function gfs2_set_mode

2014-04-01 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com Here is a revised patch based on Steve's feedback: This patch eliminates function gfs2_set_mode which was only called in one place, and always returned 0. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com

[PATCH 18/29] GFS2: Use pr_level more consistently

2014-04-01 Thread Steven Whitehouse
Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 39c7081..1a349f9 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -53,6 +53,8 @@ * but never before the maximum hash table size has been reached. */ +#define pr_fmt(fmt) KBUILD_MODNAME : fmt

[PATCH 25/29] GFS2: Remove extraneous function gfs2_security_init

2014-04-01 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch eliminates function gfs2_security_init in favor of just calling security_inode_init_security directly. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/inode.c b/fs/gfs2

  1   2   3   4   5   6   7   >