and leverage the Hyper-V cold memory
discard hint hypercall to report/free these pages back to the host.
Signed-off-by: Sunil Muthuswamy
Tested-by: Matheus Castello
---
In V2:
- Addressed feedback comments
- Added page reporting config option tied to hyper-v balloon config
In V3:
- Addressed
> What's the strategy for this flag in the unlikely event that the hypercall
> fails?
> It doesn't seem right to have hv_query_ext_cap() fail, but leave the
> static flag set to true. Just move that line down to after the status check
> has succeeded?
That call should not fail in any normal
and leverage the Hyper-V cold memory
discard hint hypercall to report/free these pages back to the host.
Signed-off-by: Sunil Muthuswamy
Tested-by: Matheus Castello
---
In V2:
- Addressed feedback comments
- Added page reporting config option tied to hyper-v balloon config
In V3:
- Addressed
> > + if (!(ms_hyperv.priv_high & HV_ENABLE_EXTENDED_HYPERCALLS))
> > + return 0;
>
> Return 'false' since the function is declared as bool?
Will fix this in the next iteration.
> > + if (hv_do_hypercall(HV_EXT_CALL_QUERY_CAPABILITIES, NULL, cap) ==
> > + HV_STATUS_SUCCESS)
>
ARM_SMCCC_STD_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_VENDOR_HYP, \
> + HV_SMCCC_FUNC_NUMBER)
> +
> +#include
> +
> +#endif
> --
> 1.8.3.1
Reviewed-by: Sunil Muthuswamy
+ hyperv_early_init();
> +
> bootmem_init();
>
> kasan_init();
> --
> 1.8.3.1
Reviewed-by: Sunil Muthuswamy
> +EXPORT_SYMBOL_GPL(hv_setup_crash_handler);
> +
> +void hv_remove_crash_handler(void)
> +{
> +}
> +EXPORT_SYMBOL_GPL(hv_remove_crash_handler);
> --
> 1.8.3.1
Reviewed-by: Sunil Muthuswamy
+
> + return 0;
> +}
> +TIMER_ACPI_DECLARE(hyperv, ACPI_SIG_GTDT, hyperv_timer_init);
> --
> 1.8.3.1
Reviewed-by: Sunil Muthuswamy
> +static u64 hypercall_output __initdata;
> +
> +static int __init hyperv_init(void)
> +{
> + struct hv_get_vpindex_from_apicid_input *input;
> + u64 status;
> + int i;
nit: both, tabs & spaces are being used to indent variable names. Can we stick
to one?
> +
> + /*
> +
> - depends on X86 && ACPI && X86_LOCAL_APIC && HYPERVISOR_GUEST
> + depends on ACPI && ((X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \
> + || (ARM64 && !CPU_BIG_ENDIAN))
> select PARAVIRT
> select X86_HV_CALLBACK_VECTOR
> help
> --
> 1.8.3.1
Reviewed-by: Sunil Muthuswamy
> > +
> > + /*
> > +* Allocate a power of 2 size so alignment to that size is
> > +* guaranteed, since the hypercall input and output areas
> > +* must not cross a page boundary.
> > +*/
> > + input = kzalloc(roundup_pow_of_two(sizeof(input->header) +
> > +
> +}
> +EXPORT_SYMBOL_GPL(hv_do_fast_hypercall8);
> +
> +
nit: Extra line, here and few other places
> +u64 hv_get_vpreg(u32 msr)
> +{
> + struct hv_get_vp_registers_input*input;
> + struct hv_get_vp_registers_output *output;
> + u64
> Hi Christoph:
> Thanks a lot for your review. There are some reasons.
> 1) Vmbus drivers don't use DMA API now.
What is blocking us from making the Hyper-V drivers use the DMA API's? They
will be a null-op generally, when there is no bounce buffer support needed.
> 2) Hyper-V
> At the very least you could pick one of the subject line prefixes that
> has been used before for either mshyperv.h or pci-hyperv.c instead of
> making up something completely new and different.
>
Will keep that in mind going forward.
The Hyper-V MSI entry is architecture specific. Currently, it is
defined in an arch neutral location. This patch moves it to an
arch specific location.
Signed-off-by: Sunil Muthuswamy
---
arch/x86/include/asm/hyperv-tlfs.h | 7 +++
include/asm-generic/hyperv-tlfs.h | 8
2 files
)
Signed-off-by: Boqun Feng (Microsoft)
Signed-off-by: Sunil Muthuswamy
---
In V2:
- Addressed feedback on SoB tab.
- Added a second patch to move the MSI entry definition.
---
arch/x86/include/asm/mshyperv.h | 24 +
drivers/pci/controller/pci-hyperv.c | 33
> Do you see "Co-developed-by" in the title of that section? This is how
> you express co-authorship.
Yes, I do now.
>
> As it is now:
>
> Signed-off-by: Sunil Muthuswamy
> Signed-off-by: Boqun Feng (Microsoft)
>
> it says that you authored the pa
er-V patches. Wei and other maintainers of the Hyper-V branch; do
you have any suggestions? If we have already defined a format and it is me
who is not following it, please forward the document my way.
> On Thu, Jan 07, 2021 at 05:05:36AM +, Sunil Muthuswamy wrote:
> > Currently, operatio
> What is this SoB chain supposed to say?
Quoting from the link you shared:
"The Signed-off-by: tag indicates that the signer was involved in the
development of
the patch, or that he/she was in the patch's delivery path."
My intent to include Boqun in the Signed-off by tag was to indicate that
Currently, operations related to irq/msi in Hyper-V vPCI are
x86-specific code. In order to support virtual PCI on Hyper-V for
other architectures, introduce generic interfaces to replace the
x86-specific ones. There are no functional changes in this patch.
Signed-off-by: Sunil Muthuswamy
Signed
and leverage the Hyper-V cold memory
discard hint hypercall to report/free these pages back to the host.
Signed-off-by: Sunil Muthuswamy
Tested-by: Matheus Castello
---
In V2:
- Addressed feedback comments
- Added page reporting config option tied to hyper-v balloon config
In V3:
- Addressed
> > +// Bit mask of the extended capability to query: see HV_EXT_CAPABILITY_xxx
>
> Please don't use '//' comments in Linux (here and below)
Will fix in v3.
> > + /*
> > +* Repurpose the input page arg to accept output from Hyper-V for
> > +* now because this is the only call that
and leverage the Hyper-V cold memory
discard hint hypercall to report/free these pages back to the host.
Signed-off-by: Sunil Muthuswamy
Tested-by: Matheus Castello
---
In V2:
- Addressed feedback comments
- Added page reporting config option tied to hyper-v balloon config
---
arch/x86/hyperv
>
> On Tue, Sep 15, 2020 at 12:32:29PM +0200, Vitaly Kuznetsov wrote:
> > Wei Liu writes:
> >
> > > When Linux is running as the root partition, the hypercall page will
> > > have already been setup by Hyper-V. Copy the content over to the
> > > allocated page.
> >
> > And we can't setup a new
> As the only usage of this function looks like
> if (!(hv_query_ext_cap() & HV_EXT_CAPABILITY_MEMORY_COLD_DISCARD_HINT))
>
> I would've change the interface to
>
> bool hv_query_ext_cap(u64 cap)
>
> so the usage would look like
>
> if
> > + if (hv_do_hypercall(HV_EXT_CALL_QUERY_CAPABILITIES, NULL, cap) ==
> > + HV_STATUS_SUCCESS)
>
> You're using the input page as the output parameter. Ideally we should
> introduce hyperv_pcpu_output_arg page, but that would waste one page per
> cpu just for this one call.
>
> So for
and leverage the Hyper-V cold memory
discard hint hypercall to report/free these pages back to the host.
Signed-off-by: Sunil Muthuswamy
---
First patch mail bounced backed. Sending it again with the email
addresses fixed.
---
arch/x86/hyperv/hv_init.c | 24
arch/x86/kernel/cpu
> -Original Message-
> From: Dexuan Cui
> Sent: Tuesday, July 30, 2019 6:26 PM
> To: Sunil Muthuswamy ; David Miller
> ; net...@vger.kernel.org
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; sas...@kernel.org; Michael Kelley
> ; linux-hyp...@vg
> -Original Message-
> From: Dexuan Cui
> Sent: Sunday, July 28, 2019 11:32 AM
> To: Sunil Muthuswamy ; David Miller
> ; net...@vger.kernel.org
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; sas...@kernel.org; Michael Kelley
> ; linux-hy
> -Original Message-
> From: David Miller
> Sent: Monday, June 17, 2019 11:56 AM
> To: Sunil Muthuswamy
> Cc: Dexuan Cui ; KY Srinivasan ;
> Haiyang Zhang ; Stephen
> Hemminger ; sas...@kernel.org; Michael Kelley
> ; net...@vger.kernel.org;
> linux-hy
ary is crossed and
not everytime.
This change also reduces the cpu usage somewhat since hv_stream_has_space()
is in the hotpath of send:
vsock_stream_sendmsg()->hv_stream_has_space()
Earlier hv_stream_has_space was setting/clearing the pending size on every
call.
Signed-off-by: Sunil Muthuswamy
Re
> -Original Message-
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of David Miller
> Sent: Sunday, June 16, 2019 1:55 PM
> To: Dexuan Cui
> Cc: Sunil Muthuswamy ; KY Srinivasan
> ; Haiyang Zhang ;
> Stephen Hemminger ; sas...@kernel.org; M
> -Original Message-
> From: Dexuan Cui
> Sent: Friday, June 14, 2019 10:04 PM
> To: David Miller ; Sunil Muthuswamy
>
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; sas...@kernel.org; Michael Kelley
> ; net...@vger.kernel.org; linux-
>
> -Original Message-
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Dexuan Cui
> Sent: Friday, June 14, 2019 10:01 PM
> To: net...@vger.kernel.org; da...@davemloft.net; Michael Kelley
>
> Cc: linux-hyp...@vger.kernel.org; linux-kernel@vger.kernel.org; KY Srinivasan
> ;
ary is crossed and
not everytime.
This change also reduces the cpu usage somewhat since hv_stream_has_space()
is in the hotpath of send:
vsock_stream_sendmsg()->hv_stream_has_space()
Earlier hv_stream_has_space was setting/clearing the pending size on every
call.
Signed-off-by: Sunil Muthuswamy
--
.
Signed-off-by: Sunil Muthuswamy
---
- The patch has been previously submitted to net and reviewed. The
feedback was to submit it to net-next.
net/vmw_vsock/hyperv_transport.c | 45 +++-
1 file changed, 31 insertions(+), 14 deletions(-)
diff --git a/net
96/494 | 830/1046/935/939 |
944/1180/1070/1100 |
| 64KB | 64/70/68/69 | 467/533/501/497 | 1260/1590/1430/1431 |
1605/1819/1670/1660 |
|-|
Signed-off-by: Sunil Muthuswamy
---
- The table above e
> -Original Message-
> From: Dexuan Cui
> Sent: Friday, May 10, 2019 8:57 PM
> To: Sunil Muthuswamy ; KY Srinivasan
> ; Haiyang Zhang ;
> Stephen Hemminger ; Sasha Levin ;
> David S. Miller ;
> Michael Kelley
> Cc: net...@vger.kernel.org; linux-hyp..
> -Original Message-
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of David Miller
> Sent: Thursday, May 9, 2019 1:58 PM
> To: Sunil Muthuswamy
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; sas...@kernel.org; Dexuan Cui
&g
n.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com; Stephen Hemminger
> ; vkuzn...@redhat.com
> Cc: Sunil Muthuswamy
> Subject: RE: [PATCH 1/1] Drivers: HV: Send one page worth of kmsg dump
> over Hy
n.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com; Stephen Hemminger
> ; vkuzn...@redhat.com
> Cc: Sunil Muthuswamy
> Subject: RE: [PATCH 1/1] Drivers: HV: Send one page worth of kmsg dump
> over Hy
41 matches
Mail list logo
