Re: [PATCH] mutliple root devs (take II)

2000-12-01 Thread T. Camp
> Hmmm, I don't like your array thing (also in v.I of the patch), > limiting us to possible root devices, where n==8. A better > approach might be to iterate over the root= arguments when mounting. I > know why you used the array -- easier to code. I was unsure if it was okay to be using

Re: [PATCH] mutliple root devs (take II)

2000-12-01 Thread T. Camp
> indeed, much cleaner. But still not perfect. > > > + int root_device_index = 0; > > this initialisation is not needed. Just make it 'int root_device_index;' > The kernel will do the right thing for you on boot, trust me. > > > +int number_root_devs = 0; > > this is not needed either. Hmm

[PATCH] mutliple root devs (take II)

2000-12-01 Thread T. Camp
,/dev/hdc,/dev/hda7 will try each device in order. You can also split these up into separate root= statements just fine. please be sure to directly address me with any feedback as I'm not on the list. (I miss linux-kernel-digest). t. camp --snip-- diff --recursive --unified --ignore-all-space

[PATCH] mutliple root devs (take II)

2000-12-01 Thread T. Camp
,/dev/hdc,/dev/hda7 will try each device in order. You can also split these up into separate root= statements just fine. please be sure to directly address me with any feedback as I'm not on the list. (I miss linux-kernel-digest). t. camp --snip-- diff --recursive --unified --ignore-all-space

Re: [PATCH] mutliple root devs (take II)

2000-12-01 Thread T. Camp
indeed, much cleaner. But still not perfect. + int root_device_index = 0; this initialisation is not needed. Just make it 'int root_device_index;' The kernel will do the right thing for you on boot, trust me. +int number_root_devs = 0; this is not needed either. Hmm didn't know

Re: [PATCH] mutliple root devs (take II)

2000-12-01 Thread T. Camp
Hmmm, I don't like your array thing (also in v.I of the patch), limiting us to n possible root devices, where n==8. A better approach might be to iterate over the root= arguments when mounting. I know why you used the array -- easier to code. I was unsure if it was okay to be using kmalloc

Patch against 2.4-pre-8 for multiple boot-time root= root devices

2000-11-27 Thread T. Camp
have replies of any nature be sure to cc me directly. thanks, t. camp --cut here-- diff --recursive --unified --ignore-all-space linux/Documentation/kernel-parameters.txt linux-2.4.0.8/Documentation/kernel-parameters.txt --- linux/Documentation/kernel-parameters.txt Tue Sep 5 13:51:14 2000

Patch against 2.4-pre-8 for multiple boot-time root= root devices

2000-11-27 Thread T. Camp
have replies of any nature be sure to cc me directly. thanks, t. camp --cut here-- diff --recursive --unified --ignore-all-space linux/Documentation/kernel-parameters.txt linux-2.4.0.8/Documentation/kernel-parameters.txt --- linux/Documentation/kernel-parameters.txt Tue Sep 5 13:51:14 2000