Re: [PATCH] perf: xgene: Include module.h

Hi Stephen, On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd wrote: > I ran into a build error when I disabled CONFIG_ACPI and tried to > compile this driver: > > drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or > storage class >

Re: [PATCH] perf: xgene: Include module.h

Hi Stephen, On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd wrote: > I ran into a build error when I disabled CONFIG_ACPI and tried to > compile this driver: > > drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or > storage class > MODULE_DEVICE_TABLE(of,

Re: [PATCH] perf: xgene: Include module.h

My bad, I can reproduce the issue now. Thanks Tai On Wed, Jan 25, 2017 at 6:13 PM, Tai Tri Nguyen <ttngu...@apm.com> wrote: > Hi Stephen, > > On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sb...@codeaurora.org> wrote: >> I ran into a build error when I dis

Re: [PATCH] perf: xgene: Include module.h

My bad, I can reproduce the issue now. Thanks Tai On Wed, Jan 25, 2017 at 6:13 PM, Tai Tri Nguyen wrote: > Hi Stephen, > > On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd wrote: >> I ran into a build error when I disabled CONFIG_ACPI and tried to >> compile this driver: &

Re: [PATCH] perf: xgene: Include module.h

Hi Stephen, On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd wrote: > I ran into a build error when I disabled CONFIG_ACPI and tried to > compile this driver: I tried kernel 4.9 and couldn't reproduce the issue. What is the kernel version you are seeing the compilation issue?

Re: [PATCH] perf: xgene: Include module.h

Hi Stephen, On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd wrote: > I ran into a build error when I disabled CONFIG_ACPI and tried to > compile this driver: I tried kernel 4.9 and couldn't reproduce the issue. What is the kernel version you are seeing the compilation issue? Regards Tai > >

Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark and Joe, On Fri, Jul 15, 2016 at 2:45 AM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Thu, Jul 14, 2016 at 11:05:48AM -0700, Tai Tri Nguyen wrote: >> Hi Joe, >> >> On Thu, Jul 14, 2016 at 10:54 AM, Tai Tri Nguyen <ttngu...@apm.com> wrote: >> &

Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark and Joe, On Fri, Jul 15, 2016 at 2:45 AM, Mark Rutland wrote: > On Thu, Jul 14, 2016 at 11:05:48AM -0700, Tai Tri Nguyen wrote: >> Hi Joe, >> >> On Thu, Jul 14, 2016 at 10:54 AM, Tai Tri Nguyen wrote: >> > Hi Joe, >> > >> > On T

Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Joe, On Thu, Jul 14, 2016 at 10:54 AM, Tai Tri Nguyen <ttngu...@apm.com> wrote: > Hi Joe, > > On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches <j...@perches.com> wrote: >> On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote: >>> This patch adds a driver for th

Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Joe, On Thu, Jul 14, 2016 at 10:54 AM, Tai Tri Nguyen wrote: > Hi Joe, > > On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches wrote: >> On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote: >>> This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware >

Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Joe, On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches wrote: > On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote: >> This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware >> found in APM X-Gene SoCs. > > trivia: > >> diff --git a/drivers/perf/xgene_pmu.c

Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Joe, On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches wrote: > On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote: >> This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware >> found in APM X-Gene SoCs. > > trivia: > >> diff --git a/drivers/perf/xgene_pmu.c

Re: [PATCH v8 0/4] perf: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Will, On Thu, Jul 14, 2016 at 6:16 AM, Will Deacon wrote: > On Mon, Jul 11, 2016 at 12:05:40PM -0700, Tai Nguyen wrote: >> In addition to the X-Gene ARM CPU performance monitoring unit (PMU), there >> are PMU for the SoC system devices such as L3 cache(s), I/O bridge(s),

Re: [PATCH v8 0/4] perf: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Will, On Thu, Jul 14, 2016 at 6:16 AM, Will Deacon wrote: > On Mon, Jul 11, 2016 at 12:05:40PM -0700, Tai Nguyen wrote: >> In addition to the X-Gene ARM CPU performance monitoring unit (PMU), there >> are PMU for the SoC system devices such as L3 cache(s), I/O bridge(s), >> memory controller

Re: [PATCH v7 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Paul, Thanks for your comments. On Sat, Jul 9, 2016 at 5:00 PM, Paul Gortmaker wrote: > On Wed, Jul 6, 2016 at 8:07 PM, Tai Nguyen wrote: >> Signed-off-by: Tai Nguyen >> --- >> Documentation/perf/xgene-pmu.txt | 48 ++ >>

Re: [PATCH v7 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Paul, Thanks for your comments. On Sat, Jul 9, 2016 at 5:00 PM, Paul Gortmaker wrote: > On Wed, Jul 6, 2016 at 8:07 PM, Tai Nguyen wrote: >> Signed-off-by: Tai Nguyen >> --- >> Documentation/perf/xgene-pmu.txt | 48 ++ >> drivers/perf/Kconfig |7 + >>

Re: [PATCH v7 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Mon, Jul 11, 2016 at 4:39 AM, Mark Rutland wrote: > Please add some commit messge text, e.g. > > This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware > found in APM X-Gene SoCs. > > On Wed, Jul 06, 2016 at 05:07:24PM -0700, Tai Nguyen wrote: >>

Re: [PATCH v7 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Mon, Jul 11, 2016 at 4:39 AM, Mark Rutland wrote: > Please add some commit messge text, e.g. > > This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware > found in APM X-Gene SoCs. > > On Wed, Jul 06, 2016 at 05:07:24PM -0700, Tai Nguyen wrote: >> Signed-off-by: Tai

Re: [PATCH v7 1/4] MAINTAINERS: Add entry for APM X-Gene SoC PMU driver

Hi Joe, On Wed, Jul 6, 2016 at 5:43 PM, Joe Perches <j...@perches.com> wrote: > On Wed, 2016-07-06 at 17:35 -0700, Tai Tri Nguyen wrote: >> Hi Joe, > > Chào Tai. > Thanks for the greeting! >> On Wed, Jul 6, 2016 at 5:19 PM, Joe Perches <j...@perches.com> wro

Re: [PATCH v7 1/4] MAINTAINERS: Add entry for APM X-Gene SoC PMU driver

Hi Joe, On Wed, Jul 6, 2016 at 5:43 PM, Joe Perches wrote: > On Wed, 2016-07-06 at 17:35 -0700, Tai Tri Nguyen wrote: >> Hi Joe, > > Chào Tai. > Thanks for the greeting! >> On Wed, Jul 6, 2016 at 5:19 PM, Joe Perches wrote: >> > On Wed, 2016-07-06

Re: [PATCH v7 1/4] MAINTAINERS: Add entry for APM X-Gene SoC PMU driver

Hi Joe, Thanks. On Wed, Jul 6, 2016 at 5:19 PM, Joe Perches wrote: > On Wed, 2016-07-06 at 17:07 -0700, Tai Nguyen wrote: >> Signed-off-by: Tai Nguyen >> --- >> MAINTAINERS | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/MAINTAINERS

Re: [PATCH v7 1/4] MAINTAINERS: Add entry for APM X-Gene SoC PMU driver

Hi Joe, Thanks. On Wed, Jul 6, 2016 at 5:19 PM, Joe Perches wrote: > On Wed, 2016-07-06 at 17:07 -0700, Tai Nguyen wrote: >> Signed-off-by: Tai Nguyen >> --- >> MAINTAINERS | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> @@ -8593,6

Re: [PATCH v6 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, Thanks. On Wed, Jul 6, 2016 at 10:49 AM, Mark Rutland wrote: > Hi, > > This looks mostly good now, though there are some remaining issues that > I've commented on below. > > On Tue, Jun 28, 2016 at 11:50:44AM -0700, Tai Nguyen wrote: >> Signed-off-by: Tai Nguyen

Re: [PATCH v6 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, Thanks. On Wed, Jul 6, 2016 at 10:49 AM, Mark Rutland wrote: > Hi, > > This looks mostly good now, though there are some remaining issues that > I've commented on below. > > On Tue, Jun 28, 2016 at 11:50:44AM -0700, Tai Nguyen wrote: >> Signed-off-by: Tai Nguyen >> --- >>

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Tue, Jun 28, 2016 at 9:59 AM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Tue, Jun 28, 2016 at 09:39:36AM -0700, Tai Tri Nguyen wrote: >> Hi Mark, >> >> On Tue, Jun 28, 2016 at 7:14 AM, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On T

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Tue, Jun 28, 2016 at 9:59 AM, Mark Rutland wrote: > On Tue, Jun 28, 2016 at 09:39:36AM -0700, Tai Tri Nguyen wrote: >> Hi Mark, >> >> On Tue, Jun 28, 2016 at 7:14 AM, Mark Rutland wrote: >> > On Tue, Jun 28, 2016 at 02:21:38PM +0100, Marc Zyngier wrote:

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Tue, Jun 28, 2016 at 7:14 AM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Tue, Jun 28, 2016 at 02:21:38PM +0100, Marc Zyngier wrote: >> On 28/06/16 12:13, Mark Rutland wrote: >> > On Mon, Jun 27, 2016 at 10:54:07AM -0700, Tai Tri Nguyen wrote: >> >

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Tue, Jun 28, 2016 at 7:14 AM, Mark Rutland wrote: > On Tue, Jun 28, 2016 at 02:21:38PM +0100, Marc Zyngier wrote: >> On 28/06/16 12:13, Mark Rutland wrote: >> > On Mon, Jun 27, 2016 at 10:54:07AM -0700, Tai Tri Nguyen wrote: >> >> On Mon, Jun 27,

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Mon, Jun 27, 2016 at 9:00 AM, Mark Rutland <mark.rutl...@arm.com> wrote: > Hi, > > On Sat, Jun 25, 2016 at 10:54:20AM -0700, Tai Tri Nguyen wrote: >> On Thu, Jun 23, 2016 at 7:32 AM, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On Wed, Jun 22,

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Mon, Jun 27, 2016 at 9:00 AM, Mark Rutland wrote: > Hi, > > On Sat, Jun 25, 2016 at 10:54:20AM -0700, Tai Tri Nguyen wrote: >> On Thu, Jun 23, 2016 at 7:32 AM, Mark Rutland wrote: >> > On Wed, Jun 22, 2016 at 11:06:58AM -0700, Tai Nguyen wrote: >> >

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Thu, Jun 23, 2016 at 7:32 AM, Mark Rutland wrote: > > Hi, > > On Wed, Jun 22, 2016 at 11:06:58AM -0700, Tai Nguyen wrote: > > diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig > > index 04e2653..be597dd 100644 > > --- a/drivers/perf/Kconfig > > +++

Re: [PATCH v4 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Thu, Jun 23, 2016 at 7:32 AM, Mark Rutland wrote: > > Hi, > > On Wed, Jun 22, 2016 at 11:06:58AM -0700, Tai Nguyen wrote: > > diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig > > index 04e2653..be597dd 100644 > > --- a/drivers/perf/Kconfig > > +++ b/drivers/perf/Kconfig > >

Re: [PATCH v3 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, Thanks for the comments. On Thu, Jun 16, 2016 at 8:39 AM, Mark Rutland wrote: > > Hi, > > On Thu, Jun 09, 2016 at 06:24:51PM -0700, Tai Nguyen wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > >

Re: [PATCH v3 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, Thanks for the comments. On Thu, Jun 16, 2016 at 8:39 AM, Mark Rutland wrote: > > Hi, > > On Thu, Jun 09, 2016 at 06:24:51PM -0700, Tai Nguyen wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include >

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Mon, Jun 6, 2016 at 10:29 AM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Tue, May 31, 2016 at 06:25:56PM -0700, Tai Tri Nguyen wrote: >> Hi Mark, > > [...] > >> I'm facing a problem after removing the index for MCU and MC sub-nodes. >> Th

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Mon, Jun 6, 2016 at 10:29 AM, Mark Rutland wrote: > On Tue, May 31, 2016 at 06:25:56PM -0700, Tai Tri Nguyen wrote: >> Hi Mark, > > [...] > >> I'm facing a problem after removing the index for MCU and MC sub-nodes. >> The MCUs and MCs aren't always enabl

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Tue, May 31, 2016 at 10:17 AM, Tai Tri Nguyen <ttngu...@apm.com> wrote: > Hi Mark, > > On Tue, May 31, 2016 at 9:56 AM, Mark Rutland <mark.rutl...@arm.com> wrote: >> On Mon, May 02, 2016 at 02:46:05PM -0700, Tai Tri Nguyen wrote: >>> Hi Rob, >>

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Tue, May 31, 2016 at 10:17 AM, Tai Tri Nguyen wrote: > Hi Mark, > > On Tue, May 31, 2016 at 9:56 AM, Mark Rutland wrote: >> On Mon, May 02, 2016 at 02:46:05PM -0700, Tai Tri Nguyen wrote: >>> Hi Rob, >>> >>> On Mon, May 2, 2016 at 1:56 PM

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Will, On Tue, May 31, 2016 at 9:25 AM, Will Deacon <will.dea...@arm.com> wrote: > On Tue, May 24, 2016 at 02:12:19PM -0700, Tai Tri Nguyen wrote: >> It's been weeks. >> I just want to ping again if you have any more comments on this patch set? > > We seem to have

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Will, On Tue, May 31, 2016 at 9:25 AM, Will Deacon wrote: > On Tue, May 24, 2016 at 02:12:19PM -0700, Tai Tri Nguyen wrote: >> It's been weeks. >> I just want to ping again if you have any more comments on this patch set? > > We seem to have reached a stalemate whereby: &

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Tue, May 31, 2016 at 9:56 AM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Mon, May 02, 2016 at 02:46:05PM -0700, Tai Tri Nguyen wrote: >> Hi Rob, >> >> On Mon, May 2, 2016 at 1:56 PM, Rob Herring <r...@kernel.org> wrote: >> > On Wed, Apr

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Tue, May 31, 2016 at 9:56 AM, Mark Rutland wrote: > On Mon, May 02, 2016 at 02:46:05PM -0700, Tai Tri Nguyen wrote: >> Hi Rob, >> >> On Mon, May 2, 2016 at 1:56 PM, Rob Herring wrote: >> > On Wed, Apr 20, 2016 at 12:31:22PM +0100, Will Deacon wrote: &g

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi all, It's been weeks. I just want to ping again if you have any more comments on this patch set? Thanks, Tai On Tue, May 10, 2016 at 4:43 PM, Tai Tri Nguyen <ttngu...@apm.com> wrote: > Hi Rob/Mark, > > Do you have any more comments, please? > > Thanks, > Tai > &g

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi all, It's been weeks. I just want to ping again if you have any more comments on this patch set? Thanks, Tai On Tue, May 10, 2016 at 4:43 PM, Tai Tri Nguyen wrote: > Hi Rob/Mark, > > Do you have any more comments, please? > > Thanks, > Tai > > On Mon, May 2, 2016 at

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Rob/Mark, Do you have any more comments, please? Thanks, Tai On Mon, May 2, 2016 at 2:46 PM, Tai Tri Nguyen <ttngu...@apm.com> wrote: > Hi Rob, > > On Mon, May 2, 2016 at 1:56 PM, Rob Herring <r...@kernel.org> wrote: >> On Wed, Apr 20, 2016 at 12:31:22PM +0100, Wi

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Rob/Mark, Do you have any more comments, please? Thanks, Tai On Mon, May 2, 2016 at 2:46 PM, Tai Tri Nguyen wrote: > Hi Rob, > > On Mon, May 2, 2016 at 1:56 PM, Rob Herring wrote: >> On Wed, Apr 20, 2016 at 12:31:22PM +0100, Will Deacon wrote: >>> On Mon, Apr 18,

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Rob, On Mon, May 2, 2016 at 1:56 PM, Rob Herring <r...@kernel.org> wrote: > On Wed, Apr 20, 2016 at 12:31:22PM +0100, Will Deacon wrote: >> On Mon, Apr 18, 2016 at 01:04:53PM -0700, Tai Tri Nguyen wrote: >> > >> +Required properties for MCB subnode: >>

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Rob, On Mon, May 2, 2016 at 1:56 PM, Rob Herring wrote: > On Wed, Apr 20, 2016 at 12:31:22PM +0100, Will Deacon wrote: >> On Mon, Apr 18, 2016 at 01:04:53PM -0700, Tai Tri Nguyen wrote: >> > >> +Required properties for MCB subnode: >> > >> +- compatibl

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark and Rob, [...] > > Regardless, I'll need an ack from Rob or Mark before I can merge this. > > Will Do you have any more comments, please? Thanks, -- Tai

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark and Rob, [...] > > Regardless, I'll need an ack from Rob or Mark before I can merge this. > > Will Do you have any more comments, please? Thanks, -- Tai

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Rob, [...] >> +Required properties for MCB subnode: >> +- compatible : Shall be "apm,xgene-pmu-mcb". >> +- reg: First resource shall be the MCB PMU resource. >> +- index : Instance number of the MCB PMU. >> + >> +Required properties for MC

Re: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Rob, [...] >> +Required properties for MCB subnode: >> +- compatible : Shall be "apm,xgene-pmu-mcb". >> +- reg: First resource shall be the MCB PMU resource. >> +- index : Instance number of the MCB PMU. >> + >> +Required properties for MC

Re: [PATCH 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Tue, Apr 5, 2016 at 12:21 PM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Tue, Apr 05, 2016 at 11:50:10AM -0700, Tai Tri Nguyen wrote: >> On Mon, Apr 4, 2016 at 4:33 PM, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On Mon, Apr 04, 2016 at 04:42:11

Re: [PATCH 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Tue, Apr 5, 2016 at 12:21 PM, Mark Rutland wrote: > On Tue, Apr 05, 2016 at 11:50:10AM -0700, Tai Tri Nguyen wrote: >> On Mon, Apr 4, 2016 at 4:33 PM, Mark Rutland wrote: >> > On Mon, Apr 04, 2016 at 04:42:11PM -0700, Tai Tri Nguyen wrote: >> >> On Fri

Re: [PATCH 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Tue, Apr 5, 2016 at 12:31 PM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Tue, Apr 05, 2016 at 11:51:02AM -0700, Tai Tri Nguyen wrote: >> Hi Mark, >> >> On Mon, Apr 4, 2016 at 4:38 PM, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On

Re: [PATCH 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Tue, Apr 5, 2016 at 12:31 PM, Mark Rutland wrote: > On Tue, Apr 05, 2016 at 11:51:02AM -0700, Tai Tri Nguyen wrote: >> Hi Mark, >> >> On Mon, Apr 4, 2016 at 4:38 PM, Mark Rutland wrote: >> > On Mon, Apr 04, 2016 at 04:40:33PM -0700, Tai Tri Nguyen wr

Re: [PATCH 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Mon, Apr 4, 2016 at 4:38 PM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Mon, Apr 04, 2016 at 04:40:33PM -0700, Tai Tri Nguyen wrote: >> On Fri, Apr 1, 2016 at 5:30 AM, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On Thu, Mar 31, 2016 at 04:3

Re: [PATCH 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Mon, Apr 4, 2016 at 4:38 PM, Mark Rutland wrote: > On Mon, Apr 04, 2016 at 04:40:33PM -0700, Tai Tri Nguyen wrote: >> On Fri, Apr 1, 2016 at 5:30 AM, Mark Rutland wrote: >> > On Thu, Mar 31, 2016 at 04:37:50PM -0700, Tai Nguyen wrote: >> >> +This is A

Re: [PATCH 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Mon, Apr 4, 2016 at 4:33 PM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Mon, Apr 04, 2016 at 04:42:11PM -0700, Tai Tri Nguyen wrote: >> On Fri, Apr 1, 2016 at 5:18 AM, Mark Rutland <mark.rutl...@arm.com> wrote: >> >> +static int get_next_avail_c

Re: [PATCH 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, On Mon, Apr 4, 2016 at 4:33 PM, Mark Rutland wrote: > On Mon, Apr 04, 2016 at 04:42:11PM -0700, Tai Tri Nguyen wrote: >> On Fri, Apr 1, 2016 at 5:18 AM, Mark Rutland wrote: >> >> +static int get_next_avail_cntr(struct xgene_pmu_dev *pmu_dev) >> >> +{ &g

Re: [PATCH 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, First of all, thanks for your comments. On Fri, Apr 1, 2016 at 5:18 AM, Mark Rutland wrote: > Hi, > > I haven't reviewed this in great detail, but I spotted a few issues. > >> +static int get_next_avail_cntr(struct xgene_pmu_dev *pmu_dev) >> +{ >> + int shift,

Re: [PATCH 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver

Hi Mark, First of all, thanks for your comments. On Fri, Apr 1, 2016 at 5:18 AM, Mark Rutland wrote: > Hi, > > I haven't reviewed this in great detail, but I spotted a few issues. > >> +static int get_next_avail_cntr(struct xgene_pmu_dev *pmu_dev) >> +{ >> + int shift, cntr, retval; >> +

Re: [PATCH 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Fri, Apr 1, 2016 at 5:30 AM, Mark Rutland wrote: > Hi, > > As per Documentation/devicetree/bindings/submitting-patches.txt, please > put binding patches earlier in a series than the code using them. > > On Thu, Mar 31, 2016 at 04:37:50PM -0700, Tai Nguyen wrote:

Re: [PATCH 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding

Hi Mark, On Fri, Apr 1, 2016 at 5:30 AM, Mark Rutland wrote: > Hi, > > As per Documentation/devicetree/bindings/submitting-patches.txt, please > put binding patches earlier in a series than the code using them. > > On Thu, Mar 31, 2016 at 04:37:50PM -0700, Tai Nguyen wrote: >> Documentation: Add

Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform

Hi Dann, On Tue, Jun 9, 2015 at 8:31 AM, Dann Frazier wrote: > On Mon, Jun 8, 2015 at 10:34 PM, Tai Tri Nguyen wrote: >> Hi Dann, >> >> On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier >> wrote: >>> On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen wrote: >>

Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform

Hi Dann, On Tue, Jun 9, 2015 at 8:31 AM, Dann Frazier dann.fraz...@canonical.com wrote: On Mon, Jun 8, 2015 at 10:34 PM, Tai Tri Nguyen ttngu...@apm.com wrote: Hi Dann, On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier dann.fraz...@canonical.com wrote: On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen

Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform

Hi Dann, On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier wrote: > On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen wrote: >> This patch adds syscon poweroff device node to support poweroff feature >> on APM X-Gene Mustang platform > > hey Tai, > The reboot changes work just fine for me, but poweroff

Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform

Hi Dann, On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier dann.fraz...@canonical.com wrote: On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen ttngu...@apm.com wrote: This patch adds syscon poweroff device node to support poweroff feature on APM X-Gene Mustang platform hey Tai, The reboot changes work

Re: [PATCH 0/2] power: reset: Add syscon reboot/poweroff device nodes for APM X-Gene platform

Hello, Any comment on these patches, please? Thanks, Tai On Fri, May 1, 2015 at 1:11 PM, Tai Nguyen wrote: > This patch set adds syscon reboot/poweroff device nodes to support reboot and > poweroff features on X-Gene platform. > > Tai Nguyen (2): > power: reset: Add syscon reboot device

Re: [PATCH 0/2] power: reset: Add syscon reboot/poweroff device nodes for APM X-Gene platform

Hello, Any comment on these patches, please? Thanks, Tai On Fri, May 1, 2015 at 1:11 PM, Tai Nguyen ttngu...@apm.com wrote: This patch set adds syscon reboot/poweroff device nodes to support reboot and poweroff features on X-Gene platform. Tai Nguyen (2): power: reset: Add syscon reboot