[GIT PULL] sound fixes for 4.20-rc6

2018-12-06 Thread Takashi Iwai
: Add support for AMD Stoney Ridge Takashi Iwai (3): ALSA: pcm: Call snd_pcm_unlink() conditionally at closing ALSA: pcm: Fix interval evaluation with openmin/max ALSA: hda/realtek - Fix speaker output regression on Thinkpad T570 Tony Das (1): ALSA: usb-audio: Add SMSL D1

Re: [PATCH] ALSA: Use of_node_name_eq for node name comparisons

2018-12-06 Thread Takashi Iwai
verted > to use for_each_child_of_node() instead. > > Cc: Johannes Berg > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: linuxppc-...@lists.ozlabs.org > Cc: alsa-de...@alsa-project.org > Signed-off-by: Rob Herring Applied, thanks. Takashi

Re: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

2018-12-05 Thread Takashi Iwai
or the test result. thanks, Takashi > > BR, > Kailang > ____ > 從: Takashi Iwai [ti...@suse.de] > 寄件日期: 2018年12月5日 下午 05:32 > 至: Kailang > 副本: Jian-Hong Pan; Jaroslav Kysela; alsa-de...@alsa-project.org; Hui Wang; > Chris Chiu; D

Re: [snd_hda_intel] snd_hda_intel causes high CPU lockup and system instability if mic disabled in BIOS on Lenovo P50

2018-12-05 Thread Takashi Iwai
On Sat, 01 Dec 2018 20:33:16 +0100, Alexander Kappner wrote: > > On Tue, 27 Nov 2018, Takashi Iwai wrote: > > > On Tue, 27 Nov 2018 06:34:02 +0100, > > Alexander Kappner wrote: > >> > >> > >> > >> > >> On Mon, 26 Nov 2018,

Re: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

2018-12-05 Thread Takashi Iwai
On Wed, 05 Dec 2018 10:06:14 +0100, Kailang wrote: > > Sorry!! > Don't change this. Hm, should I apply these series or not? thanks, Takashi > > -Original Message- > From: Kailang > Sent: Wednesday, December 5, 2018 4:52 PM > To: 'Jian-Hong Pan' ; Jaroslav

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
> ); I guess you need to pass handle here? In the earlier version, you passed \\WMI0.WQ00, so it worked with NULL handle. But now it's no longer so... Other than that, it looks OK to me. Reviewed-by: Takashi Iwai But, you don't need to rush too much. Instead, better to test your own patches and make sure that they really work before submitting the final version. thanks, Takashi

Re: [PATCH 2/2] ALSA: hda/hdmi - Add Tegra186 and Tegra194 support

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 16:53:17 +0100, Thierry Reding wrote: > > From: Thierry Reding > > Tegra186 and Tegra194 contain the same codecs as earlier chips and can > be supported using the same patch function. > > Signed-off-by: Thierry Reding Applied now, thanks. Takashi

Re: [PATCH 1/2] ALSA: hda/tegra - Probe up to 8 codecs

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 16:53:16 +0100, Thierry Reding wrote: > > From: Thierry Reding > > Recent devices support more than the 4 codecs that the AZX core will > probe by default. Probe up to 8 codecs to make sure all of them are > enumerated. > > Suggested-by: Sameer Pujar > Signed-off-by:

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 16:46:01 +0100, ayman.baga...@gmail.com wrote: > > > > + priv->cdev.name = "platform::micmute"; > > > + priv->cdev.max_brightness = 1; > > > + priv->cdev.brightness_set_blocking = > > > huawei_wmi_micmute_led_set; > > > + priv->cdev.default_trigger = "audio-micmute"; > > > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 15:18:54 +0100, Andy Shevchenko wrote: > > On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > > On Fri, 30 Nov 2018 00:57:37 +0100, > > Ayman Bagabas wrote: > > > > +struct huawei_wmi_priv { > > > + struct input_dev *ide

Re: [PATCH v8 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-12-03 Thread Takashi Iwai
Ayman Bagabas Feel free to take my ack Reviewed-by: Takashi Iwai thanks, Takashi

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Fri, 30 Nov 2018 00:57:37 +0100, Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei laptops. > Laptops such as the Matebook X have non functioning hotkeys. Whereas > newer laptops such as the Matebook X Pro come with working hotkeys out > of the box. > > Old

Re: Regression: very quiet speakers on Thinkpad T570s

2018-12-03 Thread Takashi Iwai
On Sun, 02 Dec 2018 17:57:06 +0100, Jeremy Cline wrote: > > On 12/1/18 9:44 AM, Takashi Iwai wrote: > > On Fri, 30 Nov 2018 17:51:33 +0100, > > Jeremy Cline wrote: > >> > >> On 11/30/18 11:00 AM, Takashi Iwai wrote: > >>> On Fri, 30 N

Re: Regression: very quiet speakers on Thinkpad T570s

2018-12-01 Thread Takashi Iwai
On Fri, 30 Nov 2018 17:51:33 +0100, Jeremy Cline wrote: > > On 11/30/18 11:00 AM, Takashi Iwai wrote: > > On Fri, 30 Nov 2018 15:49:17 +0100, > > Jeremy Cline wrote: > >> > >> Hi, > >> > >> Some folks have reported on the Fedora bug trac

Re: Regression: very quiet speakers on Thinkpad T570s

2018-11-30 Thread Takashi Iwai
On Fri, 30 Nov 2018 15:49:17 +0100, Jeremy Cline wrote: > > Hi, > > Some folks have reported on the Fedora bug tracker[0] that the laptop > speaker volume is very low on the Thinkpad T570 when running a kernel > that includes commit 61fcf8ece9b6 ("ALSA: hda/realtek - Enable Thinkpad > Dock

[GIT PULL] sound fixes for 4.20-rc5

2018-11-29 Thread Takashi Iwai
): ASoC: qdsp6: q6asm-dai: Only add routing once. ASoC: qdsp6: q6afe-dai: Fix the dai widgets Takashi Iwai (4): ALSA: ac97: Fix incorrect bit shift at AC97-SPSA control write ALSA: wss: Fix invalid snd_free_pages() at error path ALSA: sparc: Fix invalid snd_free_pages

Re: [PATCH] ALSA: hda: Add support for AMD Stoney Ridge

2018-11-29 Thread Takashi Iwai
On Thu, 29 Nov 2018 09:57:37 +0100, Kai-Heng Feng wrote: > > It's similar to other AMD audio devices, it also supports D3, which can > save some power drain. > > Signed-off-by: Kai-Heng Feng Thanks, applied now (also Cc to stable). Takashi

Re: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-28 Thread Takashi Iwai
rare occasion, and it didn't > > consider that it were called for regular use cases. So the fix to make > > things just works for regular use cases without any artifact must be > > implemented in the first place. The fix for the linked streams comes at > > next. It might

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-28 Thread Takashi Iwai
On Wed, 28 Nov 2018 01:49:48 +0100, ayman.baga...@gmail.com wrote: > > On Tue, 2018-11-27 at 17:52 +0200, Andy Shevchenko wrote: > > On Tue, Nov 27, 2018 at 1:02 PM Takashi Iwai wrote: > > > On Tue, 27 Nov 2018 03:57:48 +0100, > > > Ayman Bagabas wrote: > >

Re: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-28 Thread Takashi Iwai
On Wed, 28 Nov 2018 00:47:03 +0100, Chanho Min wrote: > > > On Mon, 26 Nov 2018 06:36:37 +0100, > > Chanho Min wrote: > > > > > > Commit 67ec1072b053 ("ALSA: pcm: Fix rwsem deadlock for non-atomic PCM > > > stream") fixes deadlock for non-atomic PCM stream. But, This patch > > causes antother

Re: [snd_hda_intel] snd_hda_intel causes high CPU lockup and system instability if mic disabled in BIOS on Lenovo P50

2018-11-27 Thread Takashi Iwai
On Tue, 27 Nov 2018 06:34:02 +0100, Alexander Kappner wrote: > > > > > On Mon, 26 Nov 2018, Takashi Iwai wrote: > > > On Mon, 26 Nov 2018 00:17:15 +0100, > > Alexander Kappner wrote: > >> > >> My Lenovo P50 laptop has a BIOS option to disable t

Re: [PATCH v3] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop

2018-11-27 Thread Takashi Iwai
On Mon, 26 Nov 2018 19:40:46 +0100, Girija Kumar Kasinadhuni wrote: > > This device makes a loud buzzing sound when a headphone is inserted while > playing audio at full volume through the speaker. > > Signed-off-by: Girija Kumar Kasinadhuni > --- > Apologies for the earlier patch not being

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread Takashi Iwai
Some more forgotten bits... On Tue, 27 Nov 2018 03:57:48 +0100, Ayman Bagabas wrote: > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > +config HUAWEI_WMI > + tristate "Huawei WMI hotkeys driver" > + depends on ACPI_WMI > + depends on INPUT > + select

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread Takashi Iwai
On Tue, 27 Nov 2018 03:57:48 +0100, Ayman Bagabas wrote: > > +static const struct key_entry huawei_wmi_keymap[] __initconst = { > + { KE_KEY,0x281, { KEY_BRIGHTNESSDOWN } }, > + { KE_KEY,0x282, { KEY_BRIGHTNESSUP } }, > + { KE_KEY,0x284, { KEY_MUTE

Re: [PATCH] sh: Always enable CONFIG_GENERIC_PCI_IOMAP

2018-11-26 Thread Takashi Iwai
On Mon, 19 Nov 2018 12:59:10 +0100, Takashi Iwai wrote: > > CONFIG_GENERIC_PCI_IOMAP is supposed to be set no matter whether > CONFIG_PCI is present or not. Otherwise the generic header > (asm-generic/pci_iomap.h) won't create dummy functions, and the code > using pci_iomap()

Re: Build regressions/improvements in v4.20-rc4

2018-11-26 Thread Takashi Iwai
On Mon, 26 Nov 2018 13:04:47 +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 26, 2018 at 12:59 PM Geert Uytterhoeven > wrote: > > JFYI, when comparing v4.20-rc4[1] to v4.20-rc3[3], the summaries are: > > - build errors: +1/-0 > > + /kisskb/src/sound/pci/hda/patch_ca0132.c: error: implicit

Re: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-26 Thread Takashi Iwai
On Mon, 26 Nov 2018 06:36:37 +0100, Chanho Min wrote: > > Commit 67ec1072b053 ("ALSA: pcm: Fix rwsem deadlock for non-atomic PCM > stream") > fixes deadlock for non-atomic PCM stream. But, This patch causes antother > stuck. > If writer is RT thread and reader is a normal thread, the reader

Re: [PATCH] ALSA: usb-audio: fix spelling mistake "Frequence" -> "Frequency"

2018-11-26 Thread Takashi Iwai
On Mon, 26 Nov 2018 00:12:08 +0100, Colin King wrote: > > From: Colin Ian King > > There are spelling mistakes in equalizer name fields, fix them. > > Signed-off-by: Colin Ian King In general, it's not good to rename the control names even if they are fixes. But these are rather

Re: [snd_hda_intel] snd_hda_intel causes high CPU lockup and system instability if mic disabled in BIOS on Lenovo P50

2018-11-26 Thread Takashi Iwai
On Mon, 26 Nov 2018 00:17:15 +0100, Alexander Kappner wrote: > > My Lenovo P50 laptop has a BIOS option to disable the microphone. When > this option gets chosen, the snd_hda_intel driver causes high CPU load > on a single kworker thread, spinning on "process_unsol_events", and > system >

Re: [LKP] [ALSA] 3a6d1980fe: kernel_BUG_at_mm/page_alloc.c

2018-11-26 Thread Takashi Iwai
On Mon, 26 Nov 2018 01:28:05 +0100, kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-7): > > commit: 3a6d1980fe96dbbfe3ae58db0048867f5319cdbf ("ALSA: Replace > snd_malloc_pages() and snd_free_pages() with standard helpers") >

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-24 Thread Takashi Iwai
On Sat, 24 Nov 2018 00:33:09 +0100, Pavel Machek wrote: > > Hi! > > > > > > > > > You have general-purpose LED, yet you are treating it as > > > > > > > > "something > > > > > > > > special". That means ugly code (quoted above) and lack of > > > > > > > > flexibility. > > > > > > > > > > > >

Re: [PATCH] ASoC: sunxi: rename SND_SUN8I_ADDA_PR_REGMAP

2018-11-22 Thread Takashi Iwai
On Thu, 22 Nov 2018 22:29:05 +0100, Borislav Petkov wrote: > > On Fri, Nov 02, 2018 at 03:06:59PM -0700, Vasily Khoruzhick wrote: > > On Fri, Nov 2, 2018 at 3:04 PM Arnd Bergmann wrote: > > > > > > On 11/2/18, Vasily Khoruzhick wrote: > > > > On Friday, November 2, 2018 8:33:40 AM PDT Arnd

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-22 Thread Takashi Iwai
On Thu, 22 Nov 2018 14:18:02 +0100, Pavel Machek wrote: > > On Thu 2018-11-22 13:36:43, Andy Shevchenko wrote: > > On Tue, Nov 20, 2018 at 2:19 PM Takashi Iwai wrote: > > > > > > On Tue, 20 Nov 2018 12:51:59 +0100, > > > Pavel Machek wrote: > >

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-22 Thread Takashi Iwai
On Thu, 22 Nov 2018 14:12:16 +0100, Pavel Machek wrote: > > On Tue 2018-11-20 13:19:26, Takashi Iwai wrote: > > On Tue, 20 Nov 2018 12:51:59 +0100, > > Pavel Machek wrote: > > > > > > Hi! > > > > > > > > You have general-purpose

[GIT PULL] sound fixes for 4.20-rc4

2018-11-22 Thread Takashi Iwai
. Connor McAdams (2): ALSA: hda/ca0132 - Add new ZxR quirk ALSA: hda/ca0132 - fix AE-5 pincfg Takashi Iwai (3): ALSA: oss: Use kvzalloc() for local buffer allocations ALSA: hda/realtek - Add quirk entry for HP Pavilion 15 ALSA: hda/ca0132 - Call

Re: [PATCH v2] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop

2018-11-21 Thread Takashi Iwai
On Wed, 21 Nov 2018 18:49:11 +0100, Girija Kumar Kasinadhuni wrote: > > @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x82c0, "HP",

Re: [RFC PATCH 6/6] ALSA: hda: add fallback capabilities for SKL+ platforms

2018-11-21 Thread Takashi Iwai
On Wed, 21 Nov 2018 15:39:39 +0100, Andy Shevchenko wrote: > > On Tue, Nov 20, 2018 at 03:36:44PM -0600, Pierre-Louis Bossart wrote: > > Enable fallback for select PCI IDs > > > > Signed-off-by: Pierre-Louis Bossart > > --- > > sound/pci/hda/Kconfig | 40

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Takashi Iwai
On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote: > > On Wed, Nov 21, 2018 at 11:16:50AM -0600, Pierre-Louis Bossart wrote: > > On 11/21/18 8:27 AM, Andy Shevchenko wrote: > > > > May you consider to switch to PCI_DEVICE_DATA() first? > > > > Is this really the recommended path? > > >

Re: [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop

2018-11-21 Thread Takashi Iwai
On Wed, 21 Nov 2018 15:11:31 +0100, Girija Kumar Kasinadhuni wrote: > > This device makes a loud buzzing sound when a headphone is inserted while > playing audio at full volume through the speaker. > > Signed-off-by: Girija Kumar Kasinadhuni The fixup entry you added won't "disable" but it

Re: [RFC PATCH 0/6] ASoC:Intel:Skylake: Enable HDaudio legacy fallback

2018-11-21 Thread Takashi Iwai
> Pierre-Louis Bossart (4): > ASoC: Intel: Skylake: stop init/probe if DSP is not present > ASoC: Intel: Skylake: remove useless tests on DSP presence > ASoC: Intel: Skylake: Add more platform granularity > ALSA: hda: add fallback capabilities for SKL+ platforms > > T

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-20 Thread Takashi Iwai
On Tue, 20 Nov 2018 12:51:59 +0100, Pavel Machek wrote: > > Hi! > > > > You have general-purpose LED, yet you are treating it as "something > > > special". That means ugly code (quoted above) and lack of flexibility. > > > > > > For example, if my notebook lacks HDD LED, I can use scrollock LED

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-20 Thread Takashi Iwai
On Tue, 20 Nov 2018 10:36:10 +0100, Pavel Machek wrote: > > On Tue 2018-11-20 10:23:25, Takashi Iwai wrote: > > On Tue, 20 Nov 2018 10:10:39 +0100, > > Pavel Machek wrote: > > > > > > On Tue 2018-11-20 08:07:09, Takashi Iwai wrote: > > > > On Tue,

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-20 Thread Takashi Iwai
On Tue, 20 Nov 2018 10:10:39 +0100, Pavel Machek wrote: > > On Tue 2018-11-20 08:07:09, Takashi Iwai wrote: > > On Tue, 20 Nov 2018 00:57:13 +0100, > > Pavel Machek wrote: > > > > > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > >

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-19 Thread Takashi Iwai
On Tue, 20 Nov 2018 00:57:13 +0100, Pavel Machek wrote: > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > > +#include > > + > > +static int (*huawei_wmi_micmute_led_set_func)(bool); > > + > > So we should not be doing this. > > Thinkpad ACPI module exports its LEDs there, for example. Both

DVB-S PCI card regression on 4.19 / 4.20

2018-11-19 Thread Takashi Iwai
Hi, we've got a regression report on openSUSE Bugzilla regarding DVB-S PCI card: https://bugzilla.opensuse.org/show_bug.cgi?id=1116374 According to the reporter (Stakanov, Cc'ed), the card worked fine on 4.18.15, but since 4.19, it doesn't give any channels, sound nor picture, but only EPG is

[PATCH] sh: Always enable CONFIG_GENERIC_PCI_IOMAP

2018-11-19 Thread Takashi Iwai
. Cc: Geert Uytterhoeven Signed-off-by: Takashi Iwai --- arch/sh/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index f82a4da7adf3..3d5220ad9e46 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -36,6 +36,8 @@ config SUPERH

Re: [PATCH] ALSA: aoa: Use device_type helpers to access the node type

2018-11-19 Thread Takashi Iwai
node() while we're here. > > Cc: Johannes Berg > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: linuxppc-...@lists.ozlabs.org > Cc: alsa-de...@alsa-project.org > Signed-off-by: Rob Herring Applied, thanks. Takashi

Re: [PATCH 2/2] ALSA: hda/ca0132 - fix AE-5 pincfg

2018-11-19 Thread Takashi Iwai
On Fri, 16 Nov 2018 20:24:56 +0100, Connor McAdams wrote: > > This patch fixes the pincfg assignment for the AE-5, which was > previously using the Recon3D pincfg's by mistake. > > Signed-off-by: Connor McAdams Applied, thanks. Takashi

Re: [PATCH 1/2] ALSA: hda/ca0132 - Add new ZxR quirk

2018-11-19 Thread Takashi Iwai
On Fri, 16 Nov 2018 20:24:55 +0100, Connor McAdams wrote: > > This patch adds a new PCI subsys ID for the ZxR, as found and tested by > other users. Without a way to know if any Z's use it as well, it keeps > the quirk of QUIRK_SBZ and goes through the HDA subsys test function. > >

Re: [PATCH 1/5] ALSA: asihpi: clean up indentation, replace spaces with tab

2018-11-19 Thread Takashi Iwai
On Fri, 16 Nov 2018 16:06:32 +0100, Colin King wrote: > > From: Colin Ian King > > The struct declaration is not indented correctly. Fix this by replacing > spaces with a tab. > > Signed-off-by: Colin Ian King Applied, thanks. Takashi

[PATCH] ata: Fix racy link clearance

2018-11-14 Thread Takashi Iwai
off-by: Takashi Iwai --- drivers/ata/libata-sff.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index c5ea0fc635e5..28ef46ef656d 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -1271,9 +1271,8 @@ v

Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-13 Thread Takashi Iwai
t; /* for alc295_fixup_hp_top_speakers */ > #include "hp_x360_helper.c" > > +/* for alc_fixup_huawei_micmute_led */ This should be alc_fixup_huawei_wmi */ With that fix, Reviewed-by: Takashi Iwai thanks, Takashi

Re: [PATCH v5 2/3] ALSA: hda: fix front speakers on Huawei MBXP.

2018-11-13 Thread Takashi Iwai
os sound system and these pins > configuration enables the front speakers. > > Signed-off-by: Ayman Bagabas Reviewed-by: Takashi Iwai Feel free to take it via platform tree. thanks, Takashi

Re: [PATCH v2] ARM: staging: bcm2835-audio: interpolate audio delay

2018-11-13 Thread Takashi Iwai
On Sun, 11 Nov 2018 19:21:29 +0100, Mike Brady wrote: > > /* hardware definition */ > static const struct snd_pcm_hardware snd_bcm2835_playback_hw = { > .info = (SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER | >SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |

Re: [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-11 Thread Takashi Iwai
On Sat, 10 Nov 2018 15:26:55 +0100, Andy Shevchenko wrote: > > On Sat, Nov 10, 2018 at 1:46 AM Ayman Bagabas wrote: > > > > Some of Huawei laptops come with a LED in the micmute key. This patch > > enables and disable this LED accordingly. > > This enables micmute LED for: > > 1. Matebook X

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-09 Thread Takashi Iwai
On Fri, 09 Nov 2018 14:20:47 +0100, Ayman Bagabas wrote: > > [1 ] > > On Fri, Nov 9, 2018, 4:01 AM Takashi Iwai > On Thu, 08 Nov 2018 18:16:55 +0100, > Ayman Bagabas wrote: > > > > diff --git a/drivers/platform/x86/huawei_wmi.c b/drivers/pl

Re: KMSAN: uninit-value in linear_transfer (2)

2018-11-09 Thread Takashi Iwai
On Fri, 09 Nov 2018 13:17:25 +0100, Alexander Potapenko wrote: > > > It's still strange that the conversion function gets called for the > > uninitialized source. But we should clear the vmalloc page in anyway > > for avoiding such a problem. And even better would be to use > > kvzalloc() for a

Re: KMSAN: uninit-value in linear_transfer (2)

2018-11-09 Thread Takashi Iwai
buffer is initialized (any help finding > this out is welcome!), so we mark |size| bytes starting from > plugin->buf as initialized: > https://github.com/google/kmsan/blob/master/sound/core/oss/pcm_plugin.c#L78 > But when |size| is not page-aligned vmalloc() still allocates whole >

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-09 Thread Takashi Iwai
On Thu, 08 Nov 2018 18:16:55 +0100, Ayman Bagabas wrote: > > diff --git a/drivers/platform/x86/huawei_wmi.c > b/drivers/platform/x86/huawei_wmi.c > index 658c44ab2126..f06aa967c311 100644 > --- a/drivers/platform/x86/huawei_wmi.c > +++ b/drivers/platform/x86/huawei_wmi.c > @@ -23,6 +23,7 @@ >

Re: [PATCH v3 2/3] ALSA: hda: fix front speakers on Huawei MBXP.

2018-11-09 Thread Takashi Iwai
On Thu, 08 Nov 2018 18:16:54 +0100, Ayman Bagabas wrote: > > @@ -6592,6 +6609,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", > ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad",

Re: [PATCH v3 0/3] Huawei laptops

2018-11-08 Thread Takashi Iwai
On Thu, 08 Nov 2018 20:59:45 +0100, Andy Shevchenko wrote: > > On Thu, Nov 8, 2018 at 7:17 PM Ayman Bagabas wrote: > > Is it supposed to go via PDx86 or ALSA tree? I don't mind either way. The addition in platform is more significant, so I suppose you can take it more easily. thanks,

[GIT PULL] sound fixes for 4.20-rc2

2018-11-08 Thread Takashi Iwai
small regression fixes for HD-audio: one about vga_switcheroo and runtime PM, and another about Oops on some Thinkpads. Takashi Iwai (2): vga_switcheroo: Fix missing gpu_bound call at audio client registration ALSA: hda

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-11-06 Thread Takashi Iwai
On Tue, 06 Nov 2018 22:05:11 +0100, Mike Brady wrote: > > > > On 5 Nov 2018, at 16:11, Takashi Iwai wrote: > > > > On Mon, 05 Nov 2018 16:57:07 +0100, > > Mike Brady wrote: > >> > >>> One another thing I'd like to point out is

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-11-05 Thread Takashi Iwai
On Mon, 05 Nov 2018 16:57:07 +0100, Mike Brady wrote: > > > One another thing I'd like to point out is that the value given in the > > patch is nothing but an estimated position, optimistically calculated > > via the system timer. Mike and I had already discussion in another > > thread, and

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Takashi Iwai
On Mon, 05 Nov 2018 16:07:50 +0100, Arnd Bergmann wrote: > > On 11/5/18, Andy Shevchenko wrote: > > On Sun, Nov 04, 2018 at 10:45:17AM -0600, Pierre-Louis Bossart wrote: > > > >> So yes indeed we have to add a select HDAC_HDA statement under the > >> SKYLAKE > >> config - i just don't know of

Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-05 Thread Takashi Iwai
On Sat, 03 Nov 2018 00:10:18 +0100, wrote: > > On Fri, 2018-11-02 at 20:20 +0200, Andy Shevchenko wrote: > > > +#include > > > +#include > > > +#include > > > +#include > > > > Please, keep in order. > > What order do I have to follow? Does this look right? > module.h > init.h > apci.h >

Re: [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED

2018-11-02 Thread Takashi Iwai
On Fri, 02 Nov 2018 19:12:44 +0100, Andy Shevchenko wrote: > > > + if (action == HDA_FIXUP_ACT_PROBE) { > > + if (!huawei_wmi_micmute_led_set_func) > > + huawei_wmi_micmute_led_set_func = > > symbol_request(huawei_wmi_micmute_led_set); > > +

[GIT PULL] sound fixes for 4.20-rc1

2018-11-02 Thread Takashi Iwai
Linus, please pull sound fixes for v4.20-rc1 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-fix-4.20-rc1 The topmost commit is 826b5de90c0bca4e9de6231da9e1730480621588 sound fixes for 4.20-rc1

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-02 Thread Takashi Iwai
On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: > > Remove no_pcm check to invoke pcm_new() for backend dai-links > too. This fixes crash in hdmi codec driver during hdmi_codec_startup() > while accessing chmap_info struct. chmap_info struct memory is > allocated in pcm_new() of hdmi codec

Re: [PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED

2018-11-01 Thread Takashi Iwai
On Thu, 01 Nov 2018 08:37:47 +0100, Takashi Iwai wrote: > > At the next submission, could you give a proper cover letter (PATCH > 0/3) and submit together with other patches? git-format-patch will > give you a nice template with --cover-letter option. ... and don't forget to put &qu

Re: [PATCH 2/3] ALSA:hda: fix front speakers on Huawei MBXP.

2018-11-01 Thread Takashi Iwai
On Wed, 31 Oct 2018 21:08:18 +0100, wrote: > > This patch solves bug 200501 'Only 2 of 4 speakers playing sound.' > https://bugzilla.kernel.org/show_bug.cgi?id=200501 The information should be put in the patch description. thanks, Takashi > > On Wed, 2018-10-31 at 15:20 -0400, Ayman

Re: [PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED

2018-11-01 Thread Takashi Iwai
On Wed, 31 Oct 2018 20:20:38 +0100, Ayman Bagabas wrote: > > Some of Huawei laptops come with a LED in the mic mute key. This patch > enables and disable this LED when the internal microphone status is > changed. > > Signed-off-by: Ayman Bagabas > --- > include/linux/huawei_wmi.h| 7

Re: [PATCH 17/28] tools include uapi: Update asound.h copy

2018-10-31 Thread Takashi Iwai
On Wed, 31 Oct 2018 18:27:02 +0100, Joe Perches wrote: > > On Wed, 2018-10-31 at 18:00 +0100, Takashi Iwai wrote: > > On Wed, 31 Oct 2018 17:44:57 +0100, > > Arnaldo Carvalho de Melo wrote: > > > From: Arnaldo Carvalho de Melo > > > >

Re: [PATCH 17/28] tools include uapi: Update asound.h copy

2018-10-31 Thread Takashi Iwai
asound.h' > diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h > > Due to this cset: > > a98401518def ("ALSA: timer: fix wrong comment to refer to > 'SNDRV_TIMER_PSFLG_*'") > > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Takashi Sakamo

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-25 Thread Takashi Iwai
On Thu, 25 Oct 2018 00:02:34 +0200, Kirill Marinushkin wrote: > > >> When you play sound - the pointer increments. > > > > Unfortunately, when you play sound, the pointer does not actually > > increment, for up to about 10 milliseconds. I know of no way to actually > > access the true “live”

[GIT PULL] sound updates for 4.20

2018-10-25 Thread Takashi Iwai
(1): ASoC: core: add support to card rebind Takashi Iwai (32): ALSA: seq: Do error checks at creating system ports ALSA: memalloc: Don't align the size to power-of-two ALSA: memalloc: Simplify snd_malloc_dev_pages() calls ALSA: memalloc: Add non-cached buffer type

Re: [GIT PULL] Additional firmware files for CA0132 HD-audio codec

2018-10-24 Thread Takashi Iwai
On Wed, 10 Oct 2018 19:49:23 +0200, Connor McAdams wrote: > > The following changes since commit c6b6265d718d118e28e1ce8f91769aa886b54c94: > > Merge tag 'iwlwifi-fw-2018-10-03' of > git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware > (2018-10-08 09:23:53 -0400) > > are

Re: Git pull ack emails..

2018-10-23 Thread Takashi Iwai
On Tue, 23 Oct 2018 11:02:45 +0200, Willy Tarreau wrote: > > On Tue, Oct 23, 2018 at 09:41:32AM +0100, Linus Torvalds wrote: > > Because yes, the second option likely works fine in most cases, but my > > pull might not actually be final *if* something goes bad (where bad > > might be just "oops,

Re: [PATCH] ALSA: hda/ca0132 - Actually fix microphone issue

2018-10-21 Thread Takashi Iwai
On Sun, 21 Oct 2018 19:53:03 +0200, Connor McAdams wrote: > > This patch fixes the microphone issue for all cards. The previous fix > worked on the ZxR, but not on the AE-5 or Z. This patch has been tested > to work for all cards. > > Signed-off-by: Connor McAdams Thanks, that's a good news.

Re: [PATCH] [sound/i2c/cs8427] Fix int to char conversion

2018-10-18 Thread Takashi Iwai
On Thu, 18 Oct 2018 15:47:55 +0200, Philipp K wrote: > > [1 ] > > On Thu, Oct 18, 2018, 15:46 Takashi Iwai wrote: > > On Thu, 18 Oct 2018 12:33:02 +0200, > Philipp Klocke wrote: > > > > Compiling with clang yields the following warning: >

Re: [PATCH] [sound/i2c/cs8427] Fix int to char conversion

2018-10-18 Thread Takashi Iwai
On Thu, 18 Oct 2018 12:33:02 +0200, Philipp Klocke wrote: > > Compiling with clang yields the following warning: > > sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int' > to 'char' changes value from 160 to -96 [-Wconstant-conversion] > data[0] = CS8427_REG_AUTOINC |

Re: [PATCH] staging: bcm2835-audio: interpolate audio delay

2018-10-18 Thread Takashi Iwai
On Thu, 18 Oct 2018 12:57:15 +0200, Mike Brady wrote: > > When the BCM2835 audio output is used, userspace sees a jitter up to 10ms > in the audio position, aka "delay" -- the number of frames that must > be output before a new frame would be played. > Make this a bit nicer for userspace by

Re: [PATCH 5/9] staging: bcm2835-audio: more generic probe function name

2018-10-16 Thread Takashi Iwai
On Tue, 16 Oct 2018 17:02:24 +0200, Nicolas Saenz Julienne wrote: > > There will only be one probe function, there is no use for appendig > "_dt" the end of the name. > > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 4 ++-- > 1 file

Re: [PATCH 0/9] staging: bcm2835-audio: Cleanups and upgrades

2018-10-16 Thread Takashi Iwai
so I only tested > the mini jack output. All patches look good to me: Reviewed-by: Takashi Iwai thanks, Takashi > > Thanks, > Nicolas > > === > > Nicolas Saenz Julienne (9): > staging: bcm2835-audio: unify FOURCC command definitions > staging: bcm28

Re: [PATCH 17/29] staging: bcm2835-audio: Add 10ms period constraint [Resend in plain text...]

2018-10-13 Thread Takashi Iwai
> Mike > > > > > >> On 9 Oct 2018, at 16:28, Mike Brady wrote: > >> > >> Hi Takashi. > >> > >>> On 9 Oct 2018, at 14:44, Takashi Iwai wrote: > >>> > >>> On Tue, 09 Oct 2018 15:18:15 +0200, > >>> Mike Br

Re: [PATCH] ALSA: hda - Add mic quirk for the Lenovo G50-30 (17aa:3905)

2018-10-12 Thread Takashi Iwai
On Thu, 11 Oct 2018 21:49:17 +0200, Jeremy Cline wrote: > > The Lenovo G50-30, like other G50 models, has a Conexant codec that > requires a quirk for its inverted stereo dmic. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1249364 > Reported-by: Alexander Ploumistos > Tested-by:

Re: [PATCH] ALSA: cs4236: fix return check from call to pnp_port_start

2018-10-11 Thread Takashi Iwai
On Wed, 10 Oct 2018 16:15:42 +0200, Colin King wrote: > > From: Colin Ian King > > Currently the return from pnp_port_start is being checked for validity > by checking if it is greater or equal to zero, however, the return > is unsigned and hence this check is always true. An 0 return from >

Re: [PATCH 17/29] staging: bcm2835-audio: Add 10ms period constraint [Resend in plain text...]

2018-10-09 Thread Takashi Iwai
On Tue, 09 Oct 2018 17:28:36 +0200, Mike Brady wrote: > > Hi Takashi. > > > On 9 Oct 2018, at 14:44, Takashi Iwai wrote: > > > > On Tue, 09 Oct 2018 15:18:15 +0200, > > Mike Brady wrote: > >> > >>>> @Mike: Do you want to write a pa

Re: [PATCH] ALSA: intel8x0: fix a redundant check bug

2018-10-09 Thread Takashi Iwai
On Tue, 09 Oct 2018 16:35:52 +0200, Wenwen Wang wrote: > > In snd_intel8x0_codec_semaphore(), the parameter 'codec' is firstly > checked to see whether it is greater than 2. If yes, an error code EIO is > returned. Otherwise, 'chip->in_sdin_init' is further checked. If > 'chip->in_sdin_init' is

Re: [PATCH 0/4] Various cleanup + Mic Fix

2018-10-09 Thread Takashi Iwai
On Mon, 08 Oct 2018 21:39:56 +0200, Connor McAdams wrote: > > This patch set fixes the microphone inconsistency issue, which means > the microphone now works all the time on all of the cards I've tested > (ZxR, Z, AE-5), along with the input effects. > > It also includes changes suggested by

Re: [PATCH 17/29] staging: bcm2835-audio: Add 10ms period constraint [Resend in plain text...]

2018-10-09 Thread Takashi Iwai
any application using the ALSA system for > synchronisation will rely on this being an accurate reflection of > the situation. AFAIK there is really no workaround it if the > application is confined to “safe” ALSA > (http://0pointer.de/blog/projects/guide-to-sound-apis). > On LMKL.org, Takashi wro

Re: [PATCH 00/11] Add ZxR support + bugfixes

2018-10-08 Thread Takashi Iwai
hot if they are relevant, or merge each of them gradually if they are irrelevant with each other. thanks, Takashi > > Let me know. > > Thanks, > Connor. > On Tue, Oct 2, 2018 at 11:23 AM Takashi Iwai wrote: > > > > On Sun, 30 Sep 2018 05:03:15 +0200, > &

Re: [PATCH AUTOSEL 4.18 28/48] sound: don't call skl_init_chip() to reset intel skl soc

2018-10-08 Thread Takashi Iwai
eset > > device properly. > > > > Fixes: 60767abcea3d ("ASoC: Intel: Skylake: Reset the controller in probe") > > Reviewed-by: Takashi Iwai > > Signed-off-by: Yu Zhao > > Signed-off-by: Mark Brown > > Signed-off-by: Sasha Levin > > --- > &g

Re: [PATCH AUTOSEL 4.18 27/48] sound: enable interrupt after dma buffer initialization

2018-10-08 Thread Takashi Iwai
shouldn't break, at least. thanks, Takashi > > > > Fix the problem by postponing enabling irq after dma buffer > > initialization. And warn once on null dma buffer pointer during the > > initialization. > > > > Reviewed-by: Takashi Iwai > > Signed-

[GIT PULL] sound fixes for 4.19-rc7

2018-10-05 Thread Takashi Iwai
two small fixes for HD-audio: one is for a typo in completion timeout, and another a fixup for Dell machines as usual Kai-Heng Feng (1): ALSA: hda/realtek - Cannot adjust speaker's volume on Dell XPS 27 7760 Takashi Iwai (1

Re: [PATCH] ALSA: usb-audio: update quirk for B PX to remove microphone

2018-10-05 Thread Takashi Iwai
On Fri, 05 Oct 2018 00:31:47 +0200, Nicolas Herochao wrote: > > Hey, Thanks for the quick response > > Am 04.10.18 um 22:55 CEST schrieb Takashi Iwai: > > > On Thu, 04 Oct 2018 16:42:05 +0200, > > Nicolas Huaman wrote: > >> A quirk in snd-usb-audio was a

Re: [PATCH] ALSA: usb-audio: update quirk for B PX to remove microphone

2018-10-04 Thread Takashi Iwai
On Thu, 04 Oct 2018 16:42:05 +0200, Nicolas Huaman wrote: > > A quirk in snd-usb-audio was added to automate setting sample rate to > 4800k and remove the previously exposed nonfunctional microphone for > the Bowers & Wilkins PX: > commit 240a8af929c7c57dcde28682725b29cf8474e8e5 >

Re: [PATCH] ALSA: hda/sigmatel - Disable automute for Elo VuPoint

2018-10-04 Thread Takashi Iwai
On Thu, 04 Oct 2018 20:58:21 +0200, Michael Pobega wrote: > > The Elo VuPoint 15MX has two headphone jacks of which neither work by > default. Disabling automute allows ALSA to work normally with the > speakers & left headphone jack. > > Future pin configuration changes may be required in the

Re: [PATCH] ALSA: hda/realtek - Cannot adjust speaker's volume on Dell XPS 27 7760

2018-10-03 Thread Takashi Iwai
On Thu, 04 Oct 2018 05:39:42 +0200, Kai-Heng Feng wrote: > > The issue is the same as commit dd9aa335c880 ("ALSA: hda/realtek - Can't > adjust speaker's volume on a Dell AIO"), the output requires to connect > to a node with Amp-out capability. > > Applying the same fixup ALC298_FIXUP_SPK_VOLUME

Re: [BUG] sound: pci: trident: a possible data race

2018-10-03 Thread Takashi Iwai
On Thu, 04 Oct 2018 05:08:45 +0200, Jia-Ju Bai wrote: > > Thanks for the reply :) > > > On 2018/10/3 23:54, Takashi Iwai wrote: > > On Wed, 03 Oct 2018 14:50:25 +0200, > > Jia-Ju Bai wrote: > >> CPU0: > >> snd_trident_hw_free > >>

  1   2   3   4   5   6   7   8   9   10   >