"uart_add_one_port" function call may fail and return
some error code, so adding a check for return value.
If it is returning some error code, then displaying the
result and returning back from there.
Signed-off-by: Tamseel Shams
---
drivers/tty/serial/samsung_tty.c | 6 +-
1 fi
wing false-positive error:
"IRQ index 1 not found" on newer SoC's.
This patch adds the condition to check for Tx interrupt
only for the those SoC's which have 2 interrupt lines.
Signed-off-by: Tamseel Shams
---
Commit message is changed.
Added RFT, for older platform.
Addresse
This patch fixes the following checkpatch error and warning:
1. space required after ','
2. Missing a blank line after declarations
Signed-off-by: Tamseel Shams
---
drivers/tty/serial/serial_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial
platdev, 1)"
> > call in the driver gives the following warning:
> > "IRQ index 1 not found" on recent platforms.
> >
> > This patch re-factors the IRQ resources handling for each platform and
> > hence fixing the above warnings seen on some platforms
wing false-positive error:
"IRQ index 1 not found" on recent platforms.
This patch replaces the platform_get_irq() call with
platform_get_irq_optional() and hence avoiding the
false-positive error.
Signed-off-by: Tamseel Shams
---
Commit message is changed.
Addressed Krzysztof's previous
following warning:
"IRQ index 1 not found" on recent platforms.
This patch re-factors the IRQ resources handling for
each platform and hence fixing the above warnings seen
on some platforms.
Signed-off-by: Tamseel Shams
---
Removed the logic of irq_cnt and directly using
s3c24xx_seria
> On Sun, Jun 28, 2020 at 12:30:07PM +0530, Tamseel Shams wrote:
> > In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP
> > is having 2 interrupt lines.
> > However, in other SoCs like s3c6400, s5pv210, exynos5433, and
> > exynos4210 UART is having
following warning:
"IRQ index 1 not found" on recent platforms.
This patch re-factors the IRQ resources handling for
each platform and hence fixing the above warnings seen
on some platforms.
Signed-off-by: Tamseel Shams
---
Removed the RFC tag and using 'platform_get_irq_optional'
instead
Hi Robin,
> -Original Message-
> From: Robin Murphy
> Sent: Monday, June 15, 2020 6:43 PM
> To: Tamseel Shams ; kg...@kernel.org;
> k...@kernel.org; gre...@linuxfoundation.org; jsl...@suse.com
> Cc: linux-samsung-...@vger.kernel.org; linux-ser...@vger.kernel
Hi Greg,
I will post the patch without RFC tag.
Thanks & Regards
Tamseel
> -Original Message-
> From: Greg KH
> Sent: Monday, June 15, 2020 6:21 PM
> To: Tamseel Shams
> Cc: kg...@kernel.org; k...@kernel.org; jsl...@suse.com; linux-arm-
> ker...@lists.infrad
There is a spelling mistake in a comment. Fix it.
Signed-off-by: Tamseel Shams
---
drivers/tty/serial/samsung_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 6ef614d8648c..050a47fecdef 100644
following warning:
"IRQ index 1 not found" on recent platforms.
This patch re-factors the IRQ resources handling for
each platform and hence fixing the above warnings seen
on some platforms.
Signed-off-by: Tamseel Shams
---
drivers/tty/serial/samsung_tty.c | 20
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: Tamseel Shams
---
- Changes since v2:
* Addressed Inki Dae comments
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
1 file changed, 1
> -Original Message-
> From: Inki Dae
> Sent: Wednesday, May 20, 2020 11:08 AM
> To: Tamseel Shams ; jy0922.s...@samsung.com;
> sw0312@samsung.com; kyungmin.p...@samsung.com; airl...@linux.ie;
> dan...@ffwll.ch
> Cc: dri-de...@lists.freedeskt
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Also removing unnecessary curly braces around if () statement.
Signed-off-by: Tamseel Shams
---
Fixed review comment by j...@perches.com
drivers/gpu
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: Tamseel Shams
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
drivers/gpu/drm
16 matches
Mail list logo
