Re: [RFC PATCH 13/13] m68k: mvme16x: Convert to clocksource APIy

2018-11-13 Thread Thomas Gleixner
On Wed, 14 Nov 2018, Finn Thain wrote: > On Tue, 13 Nov 2018, I wrote: > > > On Mon, 12 Nov 2018, Thomas Gleixner wrote: > > > > > > +static u32 clk_total; > > > > + > > > > +#define PCC_TIMER_CLOCK_FREQ 100 > >

Re: [PATCH 1/3] dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller

2018-11-12 Thread Thomas Gleixner
Yixun, On Fri, 10 Nov 2017, Yixun Lan wrote: > +/* > + * > + * Copyright (c) 2016 BayLibre, SAS. > + * Author: Neil Armstrong > + * > + * Copyright (c) 2017 Amlogic, inc. > + * Author: Yixun Lan > + * > + * SPDX-License-Identifier: (GPL-2.0+ OR BSD) There are two things wrong: 1) The

[PATCH] selftests/ftrace: Fix invalid SPDX identifiers

2018-11-12 Thread Thomas Gleixner
While GPL2.0 looks about right, the correct and valid identifiers for GPL v2 only code are 'GPL-2.0' or 'GPL-2.0-only'. Signed-off-by: Thomas Gleixner Cc: Masami Hiramatsu Cc: Shuah Khan (Samsung OSG) --- P.S.: checkpatch.pl emits a warning when crappy license ids are used tools/testing

Re: [RFC PATCH 13/13] m68k: mvme16x: Convert to clocksource API

2018-11-12 Thread Thomas Gleixner
Finn, On Mon, 12 Nov 2018, Finn Thain wrote: First of all, thanks for tackling this! > +static u32 clk_total; > + > +#define PCC_TIMER_CLOCK_FREQ 100 > +#define PCC_TIMER_CYCLES (PCC_TIMER_CLOCK_FREQ / HZ) > + > static irqreturn_t mvme16x_timer_int (int irq, void *dev_id) > { > +

Re: [GIT pull] scheduler fixes for 4.20

2018-11-11 Thread Thomas Gleixner
Linus, On Sun, 11 Nov 2018, Linus Torvalds wrote: > On Sun, Nov 11, 2018 at 2:11 AM Thomas Gleixner wrote: > > > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > > sched-urgent-for-linus > > Hmm. I get > >Already up to date. > > wit

[GIT pull] perf fixes for 4.20

2018-11-11 Thread Thomas Gleixner
Linus, please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus A bunch of perf tooling fixes: - Make the Intel PT SQL viewer more robust - Make the Intel PT debug log more useful - Support weak

[GIT pull] locking fixes for 4.20

2018-11-11 Thread Thomas Gleixner
Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus A single fix for a build fail with CONFIG_PROFILE_ALL_BRANCHES=y in the qspinlock code. Thanks, tglx --> Peter

[GIT pull] core fixes for 4.20

2018-11-11 Thread Thomas Gleixner
Linus, please pull the latest core-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-for-linus A couple of fixlets for the core: - Kernel doc function documentation fixes - Missing prototypes for weak watchdog functions Thanks,

[GIT pull] timer fixes for 4.20

2018-11-11 Thread Thomas Gleixner
Linus, please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus Just the removal of a redundant call into the sched deadline overrun check. Thanks, tglx --> Juri Lelli (1):

[GIT pull] x86 fixes for 4.20

2018-11-11 Thread Thomas Gleixner
Linus, please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus A set of x86 fixes: - Cure the LDT remapping to user space on 5 level paging which ended up in the KASLR space - Remove LDT mapping

[GIT pull] scheduler fixes for 4.20

2018-11-11 Thread Thomas Gleixner
Linus, please pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus Two small scheduler fixes: - Take hotplug lock in sched_init_smp(). Technically not really required, but lockdep will complain other.

Re: [PATCH] x86/mkpiggy: Drop endianness transforming

2018-11-09 Thread Thomas Gleixner
Cao, On Fri, 9 Nov 2018, Cao jin wrote: > gzip file has 4-byte little-endian file size encoded at the end of file, > while all the other compressed kernel file has size_append operation in > the Makefile which also append the 4-byte little-endian file size. There > is no need to do endianness

Re: [RFC PATCH v2 1/2] x86/fpu: detect AVX task

2018-11-09 Thread Thomas Gleixner
Aubrey, On Thu, 8 Nov 2018, Aubrey Li wrote: > Subject: x86/fpu: detect AVX task What is an AVX task? I know what you mean, but for the casual reader this is not very informative. So something like: x86/fpu: Track AVX usage of tasks would be more informative and precise. The mechanism

Re: [PATCH] irq/irq_sim: add locking

2018-11-09 Thread Thomas Gleixner
On Thu, 8 Nov 2018, Uwe Kleine-König wrote: > On Thu, Nov 08, 2018 at 05:47:48PM +0100, Bartosz Golaszewski wrote: > > @@ -74,6 +74,7 @@ int irq_sim_init(struct irq_sim *sim, unsigned int > > num_irqs) > > } > > > > init_irq_work(>work_ctx.work, irq_sim_handle_irq); > > +

Re: [PATCH] posix-timers: Use array safe helper when fetching notification symbolic name

2018-11-09 Thread Thomas Gleixner
to make sure we won't hit it again in furher modifications. > > Cc: Andrey Vagin > Cc: Thomas Gleixner > Signed-off-by: Cyrill Gorcunov > --- > fs/proc/base.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [patch 2/2] Documentation/process: Add tip tree handbook

2018-11-08 Thread Thomas Gleixner
On Thu, 8 Nov 2018, Greg KH wrote: > On Thu, Nov 08, 2018 at 08:58:32PM +0100, Thomas Gleixner wrote: > > Fixes: 1234567890AB ("subsys/comp: Short summary") > > Backport-to: 4.14 > > Ick, no. Just stick to the "Fixes:" tag. My scripts c

Re: [patch 2/2] Documentation/process: Add tip tree handbook

2018-11-08 Thread Thomas Gleixner
On Thu, 8 Nov 2018, Theodore Y. Ts'o wrote: > On Thu, Nov 08, 2018 at 09:19:33AM -0800, Dan Williams wrote: > > > > I know at least StGit mail does not grok that "#"notation. I've > > stopped using it in favor of a "Fixes:" tag. I would think "Fixes:" is > > preferred over "# " if only because

Re: [patch 2/2] Documentation/process: Add tip tree handbook

2018-11-08 Thread Thomas Gleixner
On Thu, 8 Nov 2018, Paul E. McKenney wrote: > On Thu, Nov 08, 2018 at 09:19:33AM -0800, Dan Williams wrote: > > On Thu, Nov 8, 2018 at 1:13 AM Peter Zijlstra wrote: > > > > > > On Thu, Nov 08, 2018 at 08:40:12AM +0100, Ingo Molnar wrote: > > > > > + - Cc: ``cc-ed-person `` > > > > > + > > > > > +

Re: [patch 0/2] Documentation/process: Add subsystem/tree handbook

2018-11-08 Thread Thomas Gleixner
Jon, On Thu, 8 Nov 2018, Jonathan Corbet wrote: > On Wed, 7 Nov 2018 21:51:38 +0100 (CET) > Thomas Gleixner wrote: > > + SOB chains should reflect the *real* route a patch took as it was > > + propagated to us, with the first SOB entry signalling primary > > +

Re: [PATCH v2] x86/cpu: fix prototype warning

2018-11-08 Thread Thomas Gleixner
Borislav, On Thu, 8 Nov 2018, Borislav Petkov wrote: > And frankly, I don't see why we should be fixing all those. So what if a > global function does't have a previous prototype declaration?! Global function declarations must have a prototype definition, really. Otherwise you can change the

Re: [Patch v4 07/18] x86/smt: Convert cpu_smt_control check to cpu_smt_enabled static key

2018-11-08 Thread Thomas Gleixner
Tim, On Wed, 7 Nov 2018, Tim Chen wrote: > On 11/03/2018 11:29 AM, Thomas Gleixner wrote: > > Tim, > > > > On Tue, 30 Oct 2018, Tim Chen wrote: > > > >> Change the SMT code paths check from using cpu_smt_control to > >> cpu_smt_enab

Re: [PATCH stable 4.9] posix-timers: Sanitize overrun handling

2018-11-07 Thread Thomas Gleixner
Florian, On Wed, 7 Nov 2018, Florian Fainelli wrote: > On 11/1/18 1:02 PM, Florian Fainelli wrote: > > From: Thomas Gleixner > > > > [ Upstream commit 78c9c4dfbf8c04883941445a195276bb4bb92c76 ] > > > > The posix timer overrun handling is broken because the fo

Re: [Patch v4 17/18] x86/speculation: Update SPEC_CTRL MSRs of remote CPUs

2018-11-07 Thread Thomas Gleixner
Tim, On Tue, 6 Nov 2018, Tim Chen wrote: > >>> 2) Add _TIF_UPDATE_SPEC_CTRL to the SYSCALL_EXIT_WORK_FLAGS and handle it > >>>in the slow work path. > >> > >> There can be tasks that don't do any syscalls, and it seems like we can > >> have MSRs getting out of sync? > > > > Setting the TIF

Re: [PATCH 2/2] mm/sparse: add common helper to mark all memblocks present

2018-11-07 Thread Thomas Gleixner
On Wed, 7 Nov 2018, Andrew Morton wrote: > On Wed, 7 Nov 2018 13:36:34 -0700 Logan Gunthorpe wrote: > > > > Actually if both names suck, then there also is the option to rename both > > > instead of adding a comment to explain the suckage. > > > > Ok, well, I wasn't expecting to take on a big

Re: [patch 0/2] Documentation/process: Add subsystem/tree handbook

2018-11-07 Thread Thomas Gleixner
Dan, On Wed, 7 Nov 2018, Dan Williams wrote: > On Wed, Nov 7, 2018 at 11:49 AM Jonathan Corbet wrote: > > The stuff that is truly specific to tip seems fairly minimal: > > > > - what goes into tip > > - the reverse fir tree thing > > - tail comments, or the distaste thereabouts > > -

Re: [PATCH 2/2] mm/sparse: add common helper to mark all memblocks present

2018-11-07 Thread Thomas Gleixner
Logan, On Wed, 7 Nov 2018, Logan Gunthorpe wrote: > On 2018-11-07 1:12 p.m., Andrew Morton wrote: > >> +void __init memblocks_present(void) > >> +{ > >> + struct memblock_region *reg; > >> + > >> + for_each_memblock(memory, reg) { > >> + memory_present(memblock_get_region_node(reg), >

RE: [tip:irq/core] genirq/matrix: Improve target CPU selection for managed interrupts.

2018-11-07 Thread Thomas Gleixner
Michael, On Wed, 7 Nov 2018, Michael Kelley wrote: > > 2) Managed interrupts: > > > > Managed interrupts guarantee vector reservation when the MSI/MSI-X > > functionality of a device is enabled, which is achieved by reserving > > vectors in the bitmaps of the possible target CPUs.

Re: [patch 2/2] Documentation/process: Add tip tree handbook

2018-11-07 Thread Thomas Gleixner
On Wed, 7 Nov 2018, Thomas Gleixner wrote: > Add a document to the subsystem/maintainer handbook section, which explains > what the tip tree is, how it operates and what rules and expectations it > has. Peter asked me to add a section about locking comments. I added it and forgot t

[patch 2/2] Documentation/process: Add tip tree handbook

2018-11-07 Thread Thomas Gleixner
Add a document to the subsystem/maintainer handbook section, which explains what the tip tree is, how it operates and what rules and expectations it has. Signed-off-by: Thomas Gleixner --- Documentation/process/maintainer-handbooks.rst |2 Documentation/process/maintainer-tip.rst

[patch 1/2] Documentation/process: Add maintainer handbooks section

2018-11-07 Thread Thomas Gleixner
their specific quirks. Add the section and link to it from the submitting-patches document. Suggested-by: Mark Brown Signed-off-by: Thomas Gleixner --- Documentation/process/index.rst|1 + Documentation/process/maintainer-handbooks.rst | 14 ++ Documentation

[patch 0/2] Documentation/process: Add subsystem/tree handbook

2018-11-07 Thread Thomas Gleixner
Mark recently suggested in one of the ksummit discussions to add subsystem or tree specific maintainer handbooks to document subsystem/tree specific development process information. The following series adds the general section and the tip tree specific handbook. Thanks, tglx

Re: [Patch v4] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated

2018-11-06 Thread Thomas Gleixner
Long, On Tue, 6 Nov 2018, Long Li wrote: > From: Long Li > > On a large system with multiple devices of the same class (e.g. NVMe disks, > using managed IRQs), the kernel tends to concentrate their IRQs on several > CPUs. Thanks for addressing the comments. Well done. I've merged it, but

Re: [Patch v4 17/18] x86/speculation: Update SPEC_CTRL MSRs of remote CPUs

2018-11-05 Thread Thomas Gleixner
Tim, On Mon, 5 Nov 2018, Tim Chen wrote: > > Aside of the condition being pointless in that case, that issues an IPI > > whether the task is running or not. So this allows a task to issue tons of > > async IPIs disturbing others by toggling the control. > > I'm not crazy about sending IPIs too.

Re: [Patch v4 17/18] x86/speculation: Update SPEC_CTRL MSRs of remote CPUs

2018-11-05 Thread Thomas Gleixner
Tim, On Mon, 5 Nov 2018, Tim Chen wrote: > How about sending an IPI if a remote CPU needs to have its SPEC_CTRL MSR > updated? > > Something like the following to replace this patch? ... > +static void spec_ctrl_update_func(void *info) > +{ > +

Re: [PATCH] fls: Change parameter to unsigned int

2018-11-05 Thread Thomas Gleixner
t. > > Some architectures (eg ppc) already had it declared as an unsigned int, > so I don't expect too many problems. > > Signed-off-by: Matthew Wilcox Acked-by: Thomas Gleixner

Re: [PATCH] x86/pci: Annotate 'pci_root_ops' with __ro_after_init

2018-11-05 Thread Thomas Gleixner
is confusing. What about CONFIG_X86_INTEL_MID=n? What you want to say is: pci_root_ops is only modified from intel_mid_pci_init() which is a init function, so it can be made __ro_after_init. or something like this. Hmm? Other than the nitpick above: Reviewed-by: Thomas Gleixner > Signe

Re: linux-4.20-rc1/arch/x86/mm/pageattr.c:366: logical error ?

2018-11-05 Thread Thomas Gleixner
David, On Mon, 5 Nov 2018, David Binderman wrote: > > linux-4.20-rc1/arch/x86/mm/pageattr.c:366]: (style) Same expression on both > sides of '||' because 'r1_start<=r2_end&_end>=r2_start' and > 'r2_start<=r1_end&_end>=r1_start' represent the same value. > The compiler is actually right. The

Re: [PATCH v3 2/7] x86/jump_label: Use text_poke_early() during early_init

2018-11-05 Thread Thomas Gleixner
On Mon, 5 Nov 2018, Andy Lutomirski wrote: > On Mon, Nov 5, 2018 at 11:25 AM Nadav Amit wrote: > Linus, hpa, or Dave, a question for you: suppose I map some page > writably, write to it, then upgrade permissions to allow execute. > Must I force all CPUs that might execute from it without first >

Re: [Patch v4 03/18] x86/speculation: Reorganize cpu_show_common()

2018-11-05 Thread Thomas Gleixner
Tim, On Mon, 5 Nov 2018, Tim Chen wrote: > On 11/03/2018 11:07 AM, Thomas Gleixner wrote: > >>case X86_BUG_SPECTRE_V2: > >>return sprintf(buf, "%s%s%s%s%s%s\n", > >> spectre_v2_strings[spectre_v2_enabled], > >> -

Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq_ops

2018-11-05 Thread Thomas Gleixner
gt; > AuthorDate: Mon, 5 Nov 2018 10:01:04 +0200 > > Committer: Thomas Gleixner > > CommitDate: Mon, 5 Nov 2018 12:33:47 +0100 > > > > x86/vsmp: Remove dependency on pv_irq_ops > > > > vsmp dependency on pv_irq_ops has been removed some ye

Re: [PATCH] x86: vsmp: avoid link error with gcc -Og

2018-11-05 Thread Thomas Gleixner
Arnd, On Fri, 2 Nov 2018, Arnd Bergmann wrote: > When the compiler skips optimizations for ease of debugging, > teh vsmp_cap_cpus() function is not eliminated from the build > with CONFIG_PCI=n: thanks for that, but the code has other issues, which are addressed with this:

Re: [PATCH v2] x86/build: Build VSMP support only if CONFIG_PCI is selected

2018-11-04 Thread Thomas Gleixner
Eial, On Thu, 1 Nov 2018, Eial Czerwacki wrote: > Subject: x86/build: Build VSMP support only if CONFIG_PCI is selected That's not what the patch does, right? > vsmp dependency on pv_irq_ops removed some years ago, so now let's clean > it up from vsmp_64.c. > > In short, "cap & ctl & (1 <<

Re: [PATCH v3 1/7] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-11-04 Thread Thomas Gleixner
On Fri, 2 Nov 2018, Nadav Amit wrote: > text_mutex is expected to be held before text_poke() is called, but we > cannot add a lockdep assertion since kgdb does not take it, and instead > *supposedly* ensures the lock is not taken and will not be acquired by > any other core while text_poke() is

Re: [Patch v4 17/18] x86/speculation: Update SPEC_CTRL MSRs of remote CPUs

2018-11-04 Thread Thomas Gleixner
Tim, On Tue, 30 Oct 2018, Tim Chen wrote: > void arch_set_security(struct task_struct *tsk, unsigned int value) > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > index 943e90d..048b7f4b 100644 > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -426,7

Re: BUG: "do_IRQ: 0.39 No irq handler for vector" from a 16550 port

2018-11-04 Thread Thomas Gleixner
On Fri, 2 Nov 2018, Holger Schurig wrote: > I said that kernel 4.9 doesn't show the issue. The same was for later > kernels up to 4.13. > > I had a compilation issue with 4.14 (which I later solved, something > unrelated with tools/objcopy when compiling for a different > architecture), so I did

[GIT pull] timer updates for 4.20-rc1

2018-11-04 Thread Thomas Gleixner
Linus, please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus A set of commits for the new C-SKY architecture timers. Thanks, tglx --> Guo Ren (4):

Re: [Patch v4 07/18] x86/smt: Convert cpu_smt_control check to cpu_smt_enabled static key

2018-11-03 Thread Thomas Gleixner
Tim, On Tue, 30 Oct 2018, Tim Chen wrote: > Change the SMT code paths check from using cpu_smt_control to > cpu_smt_enabled static key. This saves a branching check. and adds extra size to the kernel for the patching. The only reason why it would make sense for kvm is that then the EXPORT of

Re: [Patch v4 08/18] sched: Deprecate sched_smt_present and use cpu_smt_enabled static key

2018-11-03 Thread Thomas Gleixner
Tim, On Tue, 30 Oct 2018, Tim Chen wrote: > The cpu_smt_enabled static key serves identical purpose as cpu_smt_enabled That doesn't make any sense. > to enable SMT specific code. > > This patch replaces sched_smt_present in the scheduler with > cpu_smt_enabled and deprecate sched_smt_present.

Re: [Patch v4 03/18] x86/speculation: Reorganize cpu_show_common()

2018-11-03 Thread Thomas Gleixner
Tim, On Tue, 30 Oct 2018, Tim Chen wrote: > Extract the logic to show IBPB, STIBP usages in cpu_show_common() > into helper functions. > > Later patches will add other userspace Spectre v2 mitigation modes. > This patch makes it easy to show IBPB and STIBP > usage scenario according to the

Re: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated

2018-11-03 Thread Thomas Gleixner
On Sat, 3 Nov 2018, Thomas Gleixner wrote: > On Fri, 2 Nov 2018, Long Li wrote: > > /** > > * irq_matrix_assign_system - Assign system wide entry in the matrix > > * @m: Matrix pointer > > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_m

Re: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated

2018-11-03 Thread Thomas Gleixner
Long, On Fri, 2 Nov 2018, Long Li wrote: > /** > * irq_matrix_assign_system - Assign system wide entry in the matrix > * @m: Matrix pointer > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_matrix *m, const > struct cpumask *msk, > if (cpumask_empty(msk)) >

Re: [PATCH] tsc: make calibration refinement more robust

2018-11-03 Thread Thomas Gleixner
Daniel, On Fri, 2 Nov 2018, Daniel Vacek wrote: > On Thu, Nov 1, 2018 at 4:34 PM, Thomas Gleixner wrote: > >> -#define MAX_RETRIES 5 > >> -#define SMI_TRESHOLD5 > >> +#define MAX_RETRIES 5 > >> +#define TSC_THRESHOLD

Re: [GIT PULL] timer for tip/urgent

2018-11-02 Thread Thomas Gleixner
Daniel, On Fri, 2 Nov 2018, Daniel Lezcano wrote: > this is a late pull request for the c-sky clocksource and clockevent. > These are new drivers, they passed the review process several times for > the c-sky architecture. > > - Add the per cpu timer for the c-sky architecture (Guo Ren) > > -

Re: TSC to Mono-raw Drift

2018-11-02 Thread Thomas Gleixner
Miroslav, On Fri, 2 Nov 2018, Miroslav Lichvar wrote: > On Thu, Nov 01, 2018 at 06:41:00PM +0100, Thomas Gleixner wrote: > > On Wed, 24 Oct 2018, Miroslav Lichvar wrote: > > > The error is too large to be corrected by stepping on clock updates. > > > For a typical TSC f

Re: TSC to Mono-raw Drift

2018-11-02 Thread Thomas Gleixner
On Fri, 2 Nov 2018, Miroslav Lichvar wrote: > On Thu, Nov 01, 2018 at 07:03:37PM +0100, Thomas Gleixner wrote: > > On Thu, 1 Nov 2018, John Stultz wrote: > > > On Thu, Nov 1, 2018 at 10:44 AM, Thomas Gleixner > > > wrote: > > > > On Tue, 23 Oct 20

Re: TSC to Mono-raw Drift

2018-11-01 Thread Thomas Gleixner
On Thu, 1 Nov 2018, John Stultz wrote: > On Thu, Nov 1, 2018 at 10:44 AM, Thomas Gleixner wrote: > > On Tue, 23 Oct 2018, John Stultz wrote: > >> On Fri, Oct 19, 2018 at 3:36 PM, John Stultz > >> wrote: > >> I spent a little bit of time thinking this out.

Re: TSC to Mono-raw Drift

2018-11-01 Thread Thomas Gleixner
On Tue, 23 Oct 2018, John Stultz wrote: > On Fri, Oct 19, 2018 at 3:36 PM, John Stultz wrote: > I spent a little bit of time thinking this out. Unfortunately I don't > think its a simple matter of calculating the granularity error on the > raw clock and adding it in each interval. The other

Re: TSC to Mono-raw Drift

2018-11-01 Thread Thomas Gleixner
Miroslav, On Wed, 24 Oct 2018, Miroslav Lichvar wrote: > On Tue, Oct 23, 2018 at 11:31:00AM -0700, John Stultz wrote: > > On Fri, Oct 19, 2018 at 3:36 PM, John Stultz wrote: > > > On Fri, Oct 19, 2018 at 1:50 PM, Thomas Gleixner > > > wrote: > > >>

Re: [PATCH] x86/gart: Rewrite early_gart_iommu_check() comment

2018-11-01 Thread Thomas Gleixner
On Thu, 1 Nov 2018, Borislav Petkov wrote: > From: Borislav Petkov > > ... to actually explain what the function is trying to do. > > Reported-by: Mike Rapoport > Signed-off-by: Borislav Petkov Reviewed-by: Thomas Gleixner

Re: [PATCH] tsc: make calibration refinement more robust

2018-11-01 Thread Thomas Gleixner
Daniel, On Thu, 1 Nov 2018, Daniel Vacek wrote: Please use 'x86/tsc:' as prefix. git log path/to/file usually gives you a reasonable hint about prefixes. > -#define MAX_RETRIES 5 > -#define SMI_TRESHOLD5 > +#define MAX_RETRIES 5 > +#define TSC_THRESHOLD(tsc_khz >> 5) This

Re: [PATCH v2] x86/kvmclock : convert to SPDX identifiers

2018-11-01 Thread Thomas Gleixner
Peng, On Thu, 1 Nov 2018, Peng Hao wrote: > This patch updates license to use SPDX-License-Identifier > instead of verbose license text Again: git grep 'This patch' Documentation/process/ This leads you to: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of

Re: [PATCH] x86/build: Build VSMP support only if selected

2018-11-01 Thread Thomas Gleixner
On Thu, 1 Nov 2018, Eial Czerwacki wrote: > Greetings, > > On 11/01/2018 12:39 PM, Shai Fultheim (s...@scalemp.com) wrote: > > On 01/11/18 11:37, Thomas Gleixner wrote: > > > >> VSMP support is built even if CONFIG_X86_VSMP is not set. This leads to a > >&

Re: [RFC PATCH for 4.21 03/16] mm: Replace BUG_ON() by WARN_ON() in vm_unmap_ram()

2018-11-01 Thread Thomas Gleixner
Mathieu, On Thu, 1 Nov 2018, Mathieu Desnoyers wrote: > It is encouraged to warn and return rather than use BUG_ON() when > the condition can be recovered from in ways that are more graceful than > halting the whole system. You're failing to desribe how that graceful recovery works. Thanks,

Re: [PATCH v2 1/2] retpolines: Only enable retpoline support when compiler support it

2018-11-01 Thread Thomas Gleixner
; > > > The check of RETPOLINE is changed to CONFIG_RETPOLINE. > > > > > > This change is based on suggestion in https://lkml.org/lkml/2018/9/18/1016 > > > > > > Signed-off-by: Zhenzhong Duan > > > Cc: Thomas Gleixner > > > Cc: Peter Zijl

Re: [PATCH] [PATCH V7] watchdog/core: Add watchdog_thresh command line parameter

2018-11-01 Thread Thomas Gleixner
Laurence, On Tue, 30 Oct 2018, Laurence Oberman wrote: This looks much better. But please send your patches first to yourself. Your subject ended up with '[PATCH] [PATCH V7]' instead of just '[PATCH V7]' > Both graphics and serial consoles are exposed to hard lockups > when handling a large

Re: Tested-by test

2018-11-01 Thread Thomas Gleixner
Sherry, On Wed, 31 Oct 2018, Hurwitz, Sherry wrote: please do not rewrite the subject when replying to a patch. Thanks, tglx

Re: [PATCH] kvmclock : convert to SPDX identifiers

2018-11-01 Thread Thomas Gleixner
Peng, On Wed, 31 Oct 2018, Peng Hao wrote: a few nitpicks upfront. The proper prefix for this is: x86/kvmclock Most of the time, you can deduce the prefix from running 'git log path/to/file'. > This patch updates license to use SPDX-License-Identifier > instead of verbose license text git

[PATCH] x86/build: Build VSMP support only if selected

2018-11-01 Thread Thomas Gleixner
VSMP support is built even if CONFIG_X86_VSMP is not set. This leads to a build breakage when CONFIG_PCI is disabled as well. Build VSMP code only when selected. Reported-by: Randy Dunlap Signed-off-by: Thomas Gleixner --- diff --git a/arch/x86/include/asm/setup.h b/arch/x86/include/asm

Re: [PATCH v4.4] x86/kconfig: Fall back to ticket spinlocks

2018-11-01 Thread Thomas Gleixner
ml.kernel.org/r/20180921120226.6xjgr4oiho22e...@linutronix.de > Link: https://lkml.kernel.org/r/20180926110117.405325...@infradead.org > Cc: Sebastian Andrzej Siewior > Cc: Peter Zijlstra > Cc: Thomas Gleixner Acked-by: Thomas Gleixner > Signed-off-by: Daniel Wagner > --- > > Thomas sugge

Re: [Patch v2] genirq/matrix: Choose CPU for assigning interrupts based on allocated IRQs

2018-11-01 Thread Thomas Gleixner
Long, On Thu, 1 Nov 2018, Long Li wrote: > On a large system with multiple devices of the same class (e.g. NVMe disks, > using managed IRQs), the kernel tends to concentrate their IRQs on several > CPUs. > > The issue is that when NVMe calls irq_matrix_alloc_managed(), the assigned > CPU tends

[patch 5/9] time: Remove license boilerplate

2018-10-31 Thread Thomas Gleixner
The SPDX identifier defines the license of the files already. No need for the boilerplates. Signed-off-by: Thomas Gleixner Cc: John Stultz Cc: Paul E. McKenney --- kernel/time/alarmtimer.c |4 kernel/time/clocksource.c | 14 -- kernel/time/jiffies.c | 25

[patch 3/9] hrtimers/tick/clockevents: Remove sloppy license references

2018-10-31 Thread Thomas Gleixner
"For licencing details see kernel-base/COPYING" and similar license references have no value over the SPDX identifier. Remove them. Signed-off-by: Thomas Gleixner Cc: Ingo Molnar --- include/linux/hrtimer.h |2 -- kernel/time/clockevents.c|3 --- kernel/time

[patch 6/9] posix-timers/stubs: Remove license boilerplate

2018-10-31 Thread Thomas Gleixner
The SPDX identifier defines the license of the file already. No need for the boilerplate. Signed-off-by: Thomas Gleixner Cc: Nicolas Pitre Cc: Mark Brown Cc: Arnd Bergmann --- kernel/time/posix-stubs.c |4 1 file changed, 4 deletions(-) --- a/kernel/time/posix-stubs.c +++ b/kernel

[patch 9/9] posix-timers: Remove license boilerplate

2018-10-31 Thread Thomas Gleixner
The SPDX identifier defines the license of the file already. No need for the boilerplate. Remove also the completely outdated Montavista snail mail address. Signed-off-by: Thomas Gleixner Cc: Corey Minyard --- kernel/time/posix-timers.c | 20 +--- 1 file changed, 1 insertion

[patch 1/9] time: Remove useless filenames in top level comments

2018-10-31 Thread Thomas Gleixner
Remove the pointless filenames in the top level comments. They have no value at all and just occupy space. While at it tidy up some of the comments and remove a stale one. Signed-off-by: Thomas Gleixner --- include/linux/hrtimer.h |2 -- kernel/time/clockevents.c

[patch 0/9] time: Add SPDX identifiers and cleanup boilerplates

2018-10-31 Thread Thomas Gleixner
Add SPDX identifiers to all files in kernel/time and remove the license boiler plates. Aside of that use the chance to get rid of (stale) file references and tidy up the top of file comments as they are touched anyway by this work. This work is based on a script and data from Philippe

[patch 4/9] time/debug: Remove license boilerplate

2018-10-31 Thread Thomas Gleixner
The SPDX identifier is enough. Remove the license boilerplate. Signed-off-by: Thomas Gleixner Cc: Kees Cook Cc: David Riley Cc: Colin Cross --- kernel/time/test_udelay.c |9 - kernel/time/timekeeping_debug.c | 10 -- 2 files changed, 19 deletions(-) --- a/kernel

[patch 7/9] sched/clock: Remove license boilerplate

2018-10-31 Thread Thomas Gleixner
The SPDX identifier defines the license of the file already. No need for the boilerplate. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: John Stultz --- kernel/time/sched_clock.c |4 1 file changed, 4 deletions(-) --- a/kernel/time/sched_clock.c +++ b/kernel/time/sched_clock.c

[patch 2/9] time: Add SPDX license identifiers

2018-10-31 Thread Thomas Gleixner
, timer.c, timekeeping.c: Licence was deduced from EXPORT_SYMBOL_GPL As those files do not contain direct license references they fall under the project license, i.e. GPL V2 only. Signed-off-by: Thomas Gleixner Cc: John Stultz Cc: Ingo Molnar Cc: H. Peter Anvin Cc: Kees Cook Cc: Richard Cochran Cc

[patch 8/9] posix-clocks: Remove license boiler plate

2018-10-31 Thread Thomas Gleixner
The SPDX identifier defines the license of the file already. No need for the boilerplate. Signed-off-by: Thomas Gleixner Cc: Richard Cochran --- @Richard: This file is (C) OMICRON, but I don't have a contact anymore. That Cochran dude is not longer working there :) Do you have a contact

RE: [PATCH v13 06/12] KVM: x86: Add Intel PT virtualization work mode

2018-10-30 Thread Thomas Gleixner
On Tue, 30 Oct 2018, Kang, Luwei wrote: > > >> This part is in the " Intel® Architecture Instruction Set Extensions and > > >> Future Features Programming Reference" > > >> https://software.intel.com/sites/default/files/managed/c5/15/architec > > >>

Re: [PATCH v13 08/12] KVM: x86: Add Intel PT context switch for each vcpu

2018-10-30 Thread Thomas Gleixner
On Mon, 29 Oct 2018, Paolo Bonzini wrote: > On 24/10/2018 12:13, Alexander Shishkin wrote: > > Luwei Kang writes: > >> + /* > >> + * Set guest state of MSR_IA32_RTIT_CTL MSR (PT will be disabled > >> + * on VM entry when it has been disabled in guest before). > >> + */ > >> +

Re: [PATCH v13 05/12] perf/x86/intel/pt: add new capability for Intel PT

2018-10-30 Thread Thomas Gleixner
Luwei Kang For patches 1-5: Reviewed-by: Thomas Gleixner

RE: [PATCH v13 06/12] KVM: x86: Add Intel PT virtualization work mode

2018-10-30 Thread Thomas Gleixner
Kang, On Thu, 25 Oct 2018, Kang, Luwei wrote: > > > +#define SECONDARY_EXEC_PT_USE_GPA 0x0100 > > > +#define VM_EXIT_CLEAR_IA32_RTIT_CTL0x0200 > > > +#define VM_ENTRY_LOAD_IA32_RTIT_CTL0x0004 > > > > Where are all of these bits documented? I'm

Re: [PATCH v2 char-misc 1/1] x86/hyperv: Fix PIT shutdown quirk

2018-10-30 Thread Thomas Gleixner
Michael, On Mon, 22 Oct 2018, Michael Kelley wrote: > pit_shutdown() doesn't work on Hyper-V because of a quirk in the > PIT emulation. After shutdown the emulated PIT continues to interrupt > @18.2 HZ. This problem exists in all versions of Hyper-V and just > had not previously been noticed. So

Re: [PATCH] V6 init/main.c Enable watchdog_thresh control from kernel line To: lober...@redhat.com

2018-10-30 Thread Thomas Gleixner
Laurence, On Wed, 24 Oct 2018, Laurence Oberman wrote: your subject line reads a bit strange: Subject: [PATCH] V6 init/main.c Enable watchdog_thresh control from kernel line To: lober...@redhat.com Aside of that extra 'To:...', please move the V6 inside the square brackets together with PATCH

Re: [PATCH RFC v1 3/8] timer: Export next wakeup time of a CPU

2018-10-29 Thread Thomas Gleixner
Raju, On Thu, 11 Oct 2018, Raju P.L.S.S.S.N wrote: > > +/** > + * tick_nohz_get_next_wakeup - return the next wake up of the CPU Lacks documentation of @cpu. Please include kernel docs into your test builds. > + */ > +ktime_t tick_nohz_get_next_wakeup(int cpu) > +{ > + struct

Re: [RFC 00/20] ns: Introduce Time Namespace

2018-10-29 Thread Thomas Gleixner
Eric, On Mon, 29 Oct 2018, Eric W. Biederman wrote: > Thomas Gleixner writes: > > > > I'll try to find some time in the next weeks to look deeper into that, but > > I can't promise anything before returning from LPC. Btw, LPC would be a > > great opportuni

Re: [PATCH] Choose CPU based on allocated IRQs

2018-10-29 Thread Thomas Gleixner
Long, On Tue, 23 Oct 2018, Long Li wrote: thanks for this patch. A trivial formal thing ahead. The subject line [PATCH] Choose CPU based on allocated IRQs is lacking a proper subsystem prefix. In most cases you can figure the prefix out by running 'git log path/to/file' which in this case

Re: [RFC 00/20] ns: Introduce Time Namespace

2018-10-29 Thread Thomas Gleixner
Andrei, On Sat, 20 Oct 2018, Andrei Vagin wrote: > When a container is migrated to another host, we have to restore its > monotonic and boottime clocks, but we still expect that the container > will continue using the host real-time clock. > > Before stating this series, I was thinking about

Re: [PATCH] x86/ioremap: tighten integer overflow checking

2018-10-29 Thread Thomas Gleixner
Dan, On Thu, 25 Oct 2018, Dan Carpenter wrote: > The current check is a bit off in the case where "phys_addr + size" > wraps to zero because then "last_addr" is set to ULONG_MAX which is >= > phys_addr. > > Signed-off-by: Dan Carpenter > --- > arch/x86/mm/ioremap.c | 4 ++-- > 1 file changed,

Re: [PATCH V2 2/2] x86/efi: Move efi__boot_services() to arch/x86

2018-10-29 Thread Thomas Gleixner
dn't be part of init/main.c > > Signed-off-by: Sai Praneeth Prakhya Acked-by: Thomas Gleixner

Re: [Patch v3 03/13] x86/speculation: Add static key for Enhanced IBRS

2018-10-28 Thread Thomas Gleixner
On Fri, 26 Oct 2018, Tim Chen wrote: > On 10/26/2018 09:58 AM, Waiman Long wrote: > >> @@ -386,6 +389,7 @@ static void __init spectre_v2_select_mitigation(void) > >>/* Force it so VMEXIT will restore correctly */ > >>x86_spec_ctrl_base |= SPEC_CTRL_IBRS; >

[GIT pull] irq updates for 4.20

2018-10-24 Thread Thomas Gleixner
Linus, please pull the latest irq-core-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-core-for-linus The interrupt brigade came up with the following updates: - Driver for the Marvell System Error Interrupt machinery - Overhaul of the GIC-V3 ITS

[GIT pull] timekeeping upates for 4.20

2018-10-24 Thread Thomas Gleixner
Linus, please pull the latest timers-core-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-core-for-linus The timers and timekeeping departement provides: - Another large y2038 update with further preparations for providing the y2038 safe

Re: [PATCH v2 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-21 Thread Thomas Gleixner
Andi, On Sat, 20 Oct 2018, Andi Kleen wrote: > On Sat, Oct 20, 2018 at 10:19:37AM +0200, Thomas Gleixner wrote: > > On Fri, 19 Oct 2018, Andi Kleen wrote: > > There is no point to return the pointer because it's not a compound > > structure. If you want to provide the possibi

Re: [Ksummit-discuss] [PATCH 6/7] Code of Conduct: Change the contact email address

2018-10-21 Thread Thomas Gleixner
On Sun, 21 Oct 2018, Alan Cox wrote: > > I don't see it specifically stating that 'If someone is offensive at a > kernel summit we are going to refuse to listen' Kernel summit or Maintainer summit is covered by the CoC of the conference it is attached to. Thanks, tglx

Re: [PATCH v1] x86/microcode: Handle negative microcode revisions

2018-10-20 Thread Thomas Gleixner
Andi, On Fri, 19 Oct 2018, Andi Kleen wrote: > Change the comparison to unsigned. With that the loading works > as expected. > I assume that wants a fixes tag and needs to be backported to stable, right? Thanks, tglx

Re: [PATCH v2 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-20 Thread Thomas Gleixner
On Fri, 19 Oct 2018, Andi Kleen wrote: > > > + u32 min_ucode; > > > +}; > > > + > > > +const struct x86_ucode_id *x86_match_ucode(const struct x86_ucode_id > > > *match) > > > > What's the point of returning the struct pointer? Shouldn't it be enough to > > make it return bool? Also the

Re: TSC to Mono-raw Drift

2018-10-19 Thread Thomas Gleixner
John, On Fri, 19 Oct 2018, John Stultz wrote: > On Fri, Oct 19, 2018 at 11:57 AM, Thomas Gleixner wrote: > > I don't think you need complex oscillation for that. The error is constant > > and small enough that it is a fractional nanoseconds thing with an interval > > <=

  1   2   3   4   5   6   7   8   9   10   >