Re: [tip:x86/pti] module: Add retpoline tag to VERMAGIC

2018-01-18 Thread Thomas Gleixner
> Author: Andi Kleen <a...@linux.intel.com> > > AuthorDate: Tue, 16 Jan 2018 12:52:28 -0800 > > Committer: Thomas Gleixner <t...@linutronix.de> > > CommitDate: Wed, 17 Jan 2018 11:35:14 +0100 > > > > module: Add retpoline tag to VERMAGIC > > &

[PATCH] x86/mce: Make machine check speculation protected

2018-01-18 Thread Thomas Gleixner
The machine check idtentry uses an indirect branch directly from the low level code. This evades the speculation protection. Replace it by a direct call into C code and issue the indirect call there so the compiler can apply the proper speculation protection. Signed-off-by: Thomas Gleixner &l

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Thomas Gleixner
On Thu, 18 Jan 2018, Peter Zijlstra wrote: > On Thu, Jan 18, 2018 at 10:02:25AM +0100, Thomas Gleixner wrote: > > > > 2) We can do a cond_resched() if not in atomic context and interrupts > > > > are > > > > enabled. > > > > > &

Re: [PATCH v1] timer: Forward timer base before migrating timers

2018-01-18 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Lingutla Chandrasekhar wrote: > In case when timers are migrated to a CPU, after it exits > idle, but before timer base is forwarded, either from > run_timer_softirq()/mod_timer()/add_timer_on(), it's > possible that migrated timers are queued, based on older > clock value.

[tip:irq/urgent] irq/matrix: Spread interrupts on allocation

2018-01-18 Thread tip-bot for Thomas Gleixner
Commit-ID: a0c9259dc4e1923a98356967ce8b732da1979df8 Gitweb: https://git.kernel.org/tip/a0c9259dc4e1923a98356967ce8b732da1979df8 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Wed, 17 Jan 2018 16:01:47 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate:

Re: [PATCH V5 1/8] perf/x86/intel/uncore: customized event_read for client IMC uncore

2018-01-18 Thread Thomas Gleixner
_read function for client IMC uncore. > The customized function is exactly copied from previous generic > uncore_pmu_event_read. > The 'UNCORE_PMC_IDX_FIXED + 1' case will be isolated for client IMC > uncore only. > > Signed-off-by: Kan Liang <kan.li...@intel.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-18 Thread Thomas Gleixner
On Thu, 18 Jan 2018, Keith Busch wrote: > On Thu, Jan 18, 2018 at 09:10:43AM +0100, Thomas Gleixner wrote: > > Can you please provide the output of > > > > # cat /sys/kernel/debug/irq/irqs/$ONE_I40_IRQ > > # cat /sys/kernel/debug/irq/irqs/48 > handler: handle_edg

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Thomas Gleixner
On Thu, 18 Jan 2018, Yang Shi wrote: > On 1/17/18 4:21 AM, Thomas Gleixner wrote: > > There are two things which can be done here: > > > > 1) The collected objects can be put on a global free list and work > > scheduled to free them piecewise. > > I don't

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-18 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Keith Busch wrote: > On Wed, Jan 17, 2018 at 04:01:47PM +0100, Thomas Gleixner wrote: > > Which device is allocating gazillions of non-managed interrupts? > > I believe that would be the i40e. :) So enterprise grade insanity was spot on. Can you please pro

Re: [REGRESSION][v4.14.y][v4.15] x86/intel_rdt/cqm: Improve limbo list processing

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Joseph Salisbury wrote: > On 01/16/2018 01:59 PM, Thomas Gleixner wrote: > > Testing of your patch shows that your patch resolves the bug.  Thanks > for the assistance!  Is this something you could submit to mainline? Already there :) https://git.kernel.org/p

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, David Miller wrote: > From: Eric Dumazet <eduma...@google.com> > Date: Wed, 17 Jan 2018 14:02:43 -0800 > > > On Wed, Jan 17, 2018 at 2:00 PM, Thomas Gleixner <t...@linutronix.de> wrote: > >> On Wed, 17 Jan 2018, Linus Torvalds wrote: > &

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Linus Torvalds wrote: > On Wed, Jan 17, 2018 at 1:54 PM, Thomas Gleixner <t...@linutronix.de> wrote: > > raise_softirq() -> raise_softirq_irqoff() > > > > set_softirq_bit(); > > > > if (!in_interrupt()) >

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Linus Torvalds wrote: > On Wed, Jan 17, 2018 at 1:49 PM, David Miller wrote: > > > >> That said, this made me wonder a bit. I wonder how bounded the latency > >> is for raising a softirq from process context. We only _check_ the > >> softirq on the last

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, David Miller wrote: > From: Linus Torvalds > Date: Wed, 17 Jan 2018 13:06:58 -0800 > > > It was in some way always a "poor mans interrupt thread" (with no > > blocking like a real thread context, but at least not impacting actual > > interrupt

[GIT pull] x86/pti - The final bits and fixes

2018-01-17 Thread Thomas Gleixner
Linus, please pull the latest x86-pti-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-pti-for-linus This last update contains: - An objtool fix to prevent a segfault with the gold linker by changing the invocation order. That's not just for gold,

[GIT pull] timer fix for 4.15

2018-01-17 Thread Thomas Gleixner
--> Thomas Gleixner (1): timers: Unconditionally check deferrable base kernel/time/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 89a9e1b4264a..0bcf00e3ce48 100644 --- a/kernel/time/timer.c +++ b/ker

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Keith Busch wrote: > On Wed, Jan 17, 2018 at 10:32:12AM +0100, Thomas Gleixner wrote: > > On Wed, 17 Jan 2018, Thomas Gleixner wrote: > > > That doesn't sound right. The vectors should be spread evenly accross the > > > CPUs. So ENOSPC should nev

Re: linux-next: manual merge of the kvm tree with Linus' tree

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Stephen Rothwell wrote: > On Wed, 17 Jan 2018 13:23:17 +0100 (CET) Thomas Gleixner <t...@linutronix.de> > wrote: > > No. Keep it and lets next time coordinate the relevant bits and pieces > > better. I reserve that bit 20 and let Linus sort out the t

Re: linux-next: manual merge of the kvm tree with Linus' tree

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Paolo Bonzini wrote: > On 17/01/2018 13:23, Thomas Gleixner wrote: > > No. Keep it and lets next time coordinate the relevant bits and pieces > > better. I reserve that bit 20 and let Linus sort out the trivial conflict > > when merging the

Re: linux-next: manual merge of the kvm tree with Linus' tree

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Paolo Bonzini wrote: > On 17/01/2018 12:45, Thomas Gleixner wrote: > > On Wed, 17 Jan 2018, Stephen Rothwell wrote: > >> [This is the same conflict I reported the day before yesterday, but one > >> of the commits has moved and another that c

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-17 Thread Thomas Gleixner
On Thu, 4 Jan 2018, Yang Shi wrote: > There are nested loops on debug objects free path, sometimes it may take > over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT > occasionally, like below: Please trim back traces. The whole module info and whatever is completely

Re: [PATCH] kernel: time: forward timer base before migrating timers

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Thomas Gleixner wrote: > On Wed, 17 Jan 2018, Lingutla Chandrasekhar wrote: And please fix the subject line: kernel: time: is not the proper subsystem prefix. git log should give you a hint. Aside of that the text after the prefix starts with an uppercase let

Re: [PATCH] kernel: time: forward timer base before migrating timers

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Lingutla Chandrasekhar wrote: > In case when timers are migrated to a CPU, after it exits > idle, but before timer base is forwarded, either from > run_timer_softirq()/mod_timer()/add_timer_on(), it's > possible that migrated timers are queued, based on older > clock value.

Re: linux-next: manual merge of the kvm tree with Linus' tree

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Stephen Rothwell wrote: > [This is the same conflict I reported the day before yesterday, but one > of the commits has moved and another that contributed has been dropped.] > diff --cc arch/x86/include/asm/cpufeatures.h > index aa09559b2c0b,19f35be95f16.. > ---

[tip:x86/urgent] x86/apic/vector: Fix off by one in error path

2018-01-17 Thread tip-bot for Thomas Gleixner
Commit-ID: 45d55e7bac4028af93f5fa324e69958a0b868e96 Gitweb: https://git.kernel.org/tip/45d55e7bac4028af93f5fa324e69958a0b868e96 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Tue, 16 Jan 2018 12:20:18 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate:

Re: [PATCH 4/5] Expand the INIT_SIGNALS and INIT_SIGHAND macros and remove

2018-01-17 Thread Thomas Gleixner
On Tue, 2 Jan 2018, David Howells wrote: > Thomas Gleixner <t...@linutronix.de> wrote: > > > > #define INIT_CPU_TIMERS(s) > > > \ > > ... > > That macro is only used in init_task.c Why not moving it the

[tip:x86/urgent] x86/intel_rdt/cqm: Prevent use after free

2018-01-17 Thread tip-bot for Thomas Gleixner
Commit-ID: d47924417319e3b6a728c0b690f183e75bc2a702 Gitweb: https://git.kernel.org/tip/d47924417319e3b6a728c0b690f183e75bc2a702 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Tue, 16 Jan 2018 19:59:59 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate:

Re: Re: Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Yang, Shunyong wrote: > On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: > > You can retrieve the same information from the irq/irqs files. All it > > takes > > is a shell script. > > > > Aside of that with hierarchical irq domains

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Yang, Shunyong wrote: > Hi, Marc and Thomas, > > Thanks for your feedback. > > On Wed, 2018-01-17 at 10:18 +0100, Thomas Gleixner wrote: > > On Wed, 17 Jan 2018, Marc Zyngier wrote: > > > > > > In all honesty, I'd be mor

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Thomas Gleixner wrote: > On Wed, 17 Jan 2018, Keith Busch wrote: > > On Wed, Jan 17, 2018 at 08:34:22AM +0100, Thomas Gleixner wrote: > > > Can you trace the matrix allocations from the very beginning or tell me > > > how > > > to r

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Keith Busch wrote: > On Wed, Jan 17, 2018 at 08:34:22AM +0100, Thomas Gleixner wrote: > > Can you trace the matrix allocations from the very beginning or tell me how > > to reproduce. I'd like to figure out why this is happening. > > Sure, I'll get

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Marc Zyngier wrote: > In all honesty, I'd be more inclined to remove this debug feature > altogether, as CONFIG_GENERIC_IRQ_DEBUGFS is more complete and more > useful. Is there any feature missing from that infrastructure that > prevents you from using it instead? > > If the

Re: [PATCH v3] retpoline: Add retpoline tag to VERMAGIC

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Andi Kleen wrote: > On Tue, Jan 16, 2018 at 10:24:53PM +0100, Thomas Gleixner wrote: > > On Tue, 16 Jan 2018, Andi Kleen wrote: > > > > > From: Andi Kleen <a...@linux.intel.com> > > > > > > Add a marker for retpoline to the m

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Keith Busch wrote: > On Tue, Jan 16, 2018 at 12:20:18PM +0100, Thomas Gleixner wrote: > > 8<-- > > diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c > > index f8b03bb8e725..3cc471beb50b 100644 > > --- a

Re: [PATCH v3] retpoline: Add retpoline tag to VERMAGIC

2018-01-16 Thread Thomas Gleixner
the same checking using > a new module tag (so it's really a v3) > > Signed-off-by: Andi Kleen <a...@linux.intel.com> Acked-by: Thomas Gleixner <t...@linutronix.de> > --- > include/linux/vermagic.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) >

Re: [PATCH v2] retpoline/module: Warn for missing retpoline in module

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Andi Kleen wrote: > Thanks. > > I just sent a v3 that changes the VERMAGIC only, based on Greg's > earlier feedback. > > It has the drawbacks that it: > - refuses loading instead of warns > - doesn't stop refusing when the feature is runtime disabled > > But it's much

Re: [RFC PATCH 00/16] PTI support for x86-32

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joerg Roedel wrote: > here is my current WIP code to enable PTI on x86-32. It is > still in a pretty early state, but it successfully boots my > KVM guest with PAE and with legacy paging. The existing PTI > code for x86-64 already prepares a lot of the stuff needed > for 32

Re: [PATCH 12/16] x86/mm/pae: Populate the user page-table with user pgd's

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joerg Roedel wrote: > > +#ifdef CONFIG_X86_64 > /* >* If this is normal user memory, make it NX in the kernel >* pagetables so that, if we somehow screw up and return to > @@ -134,10 +135,16 @@ pgd_t __pti_set_user_pgd(pgd_t *pgdp, pgd_t pgd) >*

Re: [PATCH 10/16] x86/mm/pti: Populate valid user pud entries

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joerg Roedel wrote: > From: Joerg Roedel > > With PAE paging we don't have PGD and P4D levels in the > page-table, instead the PUD level is the highest one. > > In PAE page-tables at the top-level most bits we usually set > with _KERNPG_TABLE are reserved,

Re: [PATCH 09/16] x86/mm/pti: Clone CPU_ENTRY_AREA on PMD level on x86_32

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joerg Roedel wrote: > +#ifdef CONFIG_X86_64 > /* > * Clone a single p4d (i.e. a top-level entry on 4-level systems and a > * next-level entry on 5-level systems. > @@ -322,13 +323,29 @@ static void __init pti_clone_p4d(unsigned long addr) > kernel_p4d =

Re: [PATCH v2] retpoline/module: Warn for missing retpoline in module

2018-01-16 Thread Thomas Gleixner
On Fri, 12 Jan 2018, Andi Kleen wrote: > From: Andi Kleen > void stop_this_cpu(void *dummy); > void df_debug(struct pt_regs *regs, long error_code); > + > +void disable_retpoline(void); > +bool retpoline_enabled(void); Can you please use a consistent name space?

Re: [PATCH 02/16] x86/entry/32: Enter the kernel via trampoline stack

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joerg Roedel wrote: > @@ -89,13 +89,9 @@ static inline void refresh_sysenter_cs(struct > thread_struct *thread) > /* This is used when switching tasks or entering/exiting vm86 mode. */ > static inline void update_sp0(struct task_struct *task) > { > - /* On x86_64, sp0

Re: [PATCH 07/16] x86/mm: Move two more functions from pgtable_64.h to pgtable.h

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joerg Roedel wrote: > On Tue, Jan 16, 2018 at 10:03:09AM -0800, Dave Hansen wrote: > > On 01/16/2018 08:36 AM, Joerg Roedel wrote: > > > + return (((ptr & ~PAGE_MASK) / sizeof(pgd_t)) < KERNEL_PGD_BOUNDARY); > > > +} > > > > One of the reasons to implement it the other way:

Re: [PATCH for 4.16 04/10] membarrier: provide SHARED_EXPEDITED command (v2)

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Mathieu Desnoyers wrote: > - On Jan 16, 2018, at 1:20 PM, Thomas Gleixner t...@linutronix.de wrote: > > And I really have to ask whether this should be named _GLOBAL_ instead of > > _SHARED_. > > > > Hmm? > > I agree with you that th

RE: [REGRESSION][v4.14.y][v4.15] x86/intel_rdt/cqm: Improve limbo list processing

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Yu, Fenghua wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > Is this a Haswell specific issue? > > I run the following test forever without issue on Broadwell and 4.15.0-rc6 > with rdt mounted: > for ((;;)) do >

Re: [PATCH 01/16] x86/entry/32: Rename TSS_sysenter_sp0 to TSS_sysenter_stack

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joerg Roedel wrote: > From: Joerg Roedel > > The stack addresss doesn't need to be stored in tss.sp0 if > we switch manually like on sysenter. Rename the offset so > that it still makes sense when we its location. -ENOSENTENCE Other than that. Makes

Re: [PATCH v3 3/7] x86/hyper-v: reenlightenment notifications support

2018-01-16 Thread Thomas Gleixner
the fix in on the way. > > Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH v3 4/7] x86/hyper-v: redirect reenlightment notifications on CPU offlining

2018-01-16 Thread Thomas Gleixner
ff-by: Vitaly Kuznetsov <vkuzn...@redhat.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH v3 5/7] x86/irq: Count Hyper-V reenlightenment interrupts

2018-01-16 Thread Thomas Gleixner
italy Kuznetsov <vkuzn...@redhat.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH for 4.16 08/10] membarrier: x86: Provide core serializing command (v3)

2018-01-16 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Mathieu Desnoyers wrote: > There are two places where core serialization is needed by membarrier: > > 1) When returning from the membarrier IPI, > 2) After scheduler updates curr to a thread with a different mm, before >going back to user-space, since the curr->mm is

Re: [PATCH for 4.16 07/10] x86: Introduce sync_core_before_usermode (v2)

2018-01-16 Thread Thomas Gleixner
> Architectures defining the sync_core_before_usermode() static inline > need to select ARCH_HAS_SYNC_CORE_BEFORE_USERMODE. Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH for 4.16 04/10] membarrier: provide SHARED_EXPEDITED command (v2)

2018-01-16 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Mathieu Desnoyers wrote: > +static int membarrier_shared_expedited(void) > +{ > + int cpu; > + bool fallback = false; > + cpumask_var_t tmpmask; > + > + if (num_online_cpus() == 1) > + return 0; > + > + /* > + * Matches memory barriers

Re: [REGRESSION][v4.14.y][v4.15] x86/intel_rdt/cqm: Improve limbo list processing

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Joseph Salisbury wrote: > On 01/16/2018 08:32 AM, Shankar, Ravi V wrote: > > Vikas on vacation until end of the month. Fenghua will look into this > > issue. > > > > On Jan 16, 2018, at 5:09 AM, Thomas Gleixner <t...@linutronix.de > >

Re: linux-next: manual merge of the kvm tree with Linus' and the tip trees

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Paolo Bonzini wrote: > On 16/01/2018 01:55, Ingo Molnar wrote: > > > > * Paolo Bonzini <pbonz...@redhat.com> wrote: > > > >> On 15/01/2018 19:36, Thomas Gleixner wrote: > >>>> Can KVM folks please stop doing random cha

Re: lapic-related boot crash in 4.15-rc1

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Meelis Roos wrote: > > I've reverted the commit which Dou pointed out in rc8. Can you please > > confirm that > > this fixes the issue for you? > > I am compiling the x86/urgent pull that you suggested. > > Meanwhile the bisect finished and it came to the exact same commit

Re: [REGRESSION][v4.14.y][v4.15] x86/intel_rdt/cqm: Improve limbo list processing

2018-01-16 Thread Thomas Gleixner
Vikas, Fenghua can you please look at that ASAP? On Sun, 14 Jan 2018, Thomas Gleixner wrote: > On Fri, 12 Jan 2018, Joseph Salisbury wrote: > > > Hi Vikas, > > > > A kernel bug report was opened against Ubuntu [0].  After a kernel > > bisect, it was found that

RE: [RFC PATCH 00/20] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-01-16 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Hindman, Gavin wrote: > > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > > ow...@vger.kernel.org] On Behalf Of Thomas Gleixner > > On Fri, 17 Nov 2017, Reinette Chatre wrote: > > > > > > 1) PALLOC is not upstream

Re: [PATCH 0/2] genirq/affinity: try to make sure online CPU is assgined to irq vector

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Ming Lei wrote: > On Mon, Jan 15, 2018 at 09:40:36AM -0800, Christoph Hellwig wrote: > > On Tue, Jan 16, 2018 at 12:03:43AM +0800, Ming Lei wrote: > > > Hi, > > > > > > These two patches fixes IO hang issue reported by Laurence. > > > > > > 84676c1f21 ("genirq/affinity:

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Thomas Gleixner wrote: > On Tue, 16 Jan 2018, Keith Busch wrote: > > > This is all way over my head, but the part that obviously shows > > something's gone wrong: > > > > kworker/u674:3-1421 [028] d... 335.307051: irq_matrix_reserve_manag

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Keith Busch wrote: > This is all way over my head, but the part that obviously shows > something's gone wrong: > > kworker/u674:3-1421 [028] d... 335.307051: irq_matrix_reserve_managed: > bit=56 cpu=0 online=1 avl=86 alloc=116 managed=3 online_maps=112 >

[tip:timers/core] ALSA/dummy: Replace tasklet with softirq hrtimer

2018-01-16 Thread tip-bot for Thomas Gleixner
Commit-ID: b03bbbe08ff04d80136b6aac152954ef308a4909 Gitweb: https://git.kernel.org/tip/b03bbbe08ff04d80136b6aac152954ef308a4909 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Thu, 21 Dec 2017 11:42:03 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Tue,

[tip:timers/core] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2018-01-16 Thread tip-bot for Thomas Gleixner
Commit-ID: b1a31a5f5f27ff8aba42b545a1c721941f735107 Gitweb: https://git.kernel.org/tip/b1a31a5f5f27ff8aba42b545a1c721941f735107 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Thu, 21 Dec 2017 11:42:04 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Tue,

Re: [tip:timers/urgent] timers: Unconditionally check deferrable base

2018-01-16 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Paul E. McKenney wrote: > On Sun, Jan 14, 2018 at 02:44:15PM -0800, Paul E. McKenney wrote: > > On Sun, Jan 14, 2018 at 02:31:07PM -0800, tip-bot for Thomas Gleixner wrote: > > > Commit-ID: ed4bbf7910b28ce3c691aef28d245585eaabda06 > > &g

Re: lapic-related boot crash in 4.15-rc1

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Meelis Roos wrote: > > I've reverted the commit which Dou pointed out in rc8. Can you please > > confirm that > > this fixes the issue for you? > > Tried rc8 on the P3, it still hangs. Bah. I'm an idiot. I queued the revert in

[tip:timers/core] hrtimer: Optimize the hrtimer code by using static keys for migration_enable/nohz_active

2018-01-15 Thread tip-bot for Thomas Gleixner
Commit-ID: ae67badaa1643253998cb21d5782e4ea7c231a29 Gitweb: https://git.kernel.org/tip/ae67badaa1643253998cb21d5782e4ea7c231a29 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Sun, 14 Jan 2018 23:30:51 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Tue,

[tip:timers/core] hrtimer: Correct blatantly incorrect comment

2018-01-15 Thread tip-bot for Thomas Gleixner
Commit-ID: d05ca13b8d3f685667b3b1748fa89285466270c5 Gitweb: https://git.kernel.org/tip/d05ca13b8d3f685667b3b1748fa89285466270c5 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Thu, 21 Dec 2017 11:41:31 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Tue,

Re: linux-next: manual merge of the kvm tree with Linus' and the tip trees

2018-01-15 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Thomas Gleixner wrote: > On Mon, 15 Jan 2018, Stephen Rothwell wrote: > > Hi all, > > --- a/arch/x86/include/asm/cpufeatures.h > > +++ b/arch/x86/include/asm/cpufeatures.h > > @@@ -202,11 -201,9 +202,11 @@@ > > #define X86_FEATURE_HW_PSTATE

Re: [PATCH v6 01/24] x86/mm: Define CONFIG_SPF

2018-01-15 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Laurent Dufour wrote: > On 12/01/2018 19:57, Thomas Gleixner wrote: > > On Fri, 12 Jan 2018, Laurent Dufour wrote: > > > >> Introduce CONFIG_SPF which turns on the Speculative Page Fault handler when > >> building for 64bits with SMP. > &

Re: [PATCH 0/2] genirq/affinity: try to make sure online CPU is assgined to irq vector

2018-01-15 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Ming Lei wrote: > These two patches fixes IO hang issue reported by Laurence. > > 84676c1f21 ("genirq/affinity: assign vectors to all possible CPUs") > may cause one irq vector assigned to all offline CPUs, then this vector > can't handle irq any more. > > The 1st patch

Re: lapic-related boot crash in 4.15-rc1

2018-01-15 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Meelis Roos wrote: > On Wed, 10 Jan 2018, Thomas Gleixner wrote: > > > On Wed, 10 Jan 2018, Meelis Roos wrote: > > > > > > > On 3 of my test computers, boot hangs with 4.15 git kernels. So far I > > > > > have traced it

Re: linux-next: manual merge of the kvm tree with Linus' and the tip trees

2018-01-15 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Stephen Rothwell wrote: > Hi all, > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@@ -202,11 -201,9 +202,11 @@@ > #define X86_FEATURE_HW_PSTATE ( 7*32+ 8) /* AMD HW-PState */ > #define X86_FEATURE_PROC_FEEDBACK (

Re: Improve retpoline for Skylake

2018-01-15 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Jon Masters wrote: > On 01/12/2018 05:03 PM, Henrique de Moraes Holschuh wrote: > > On Fri, 12 Jan 2018, Andi Kleen wrote: > >>> Skylake still loses if it takes an SMI, right? > >> > >> SMMs are usually rare, especially on servers, and are usually > >> not very predictible,

Re: [PATCH] x86/centaur: Mark TSC invariant

2018-01-15 Thread Thomas Gleixner
On Mon, 15 Jan 2018, TimGuo wrote: > Centaur CPU has a constant frequency TSC and that TSC does not stop in > C-States. > But because the flags are not set for that CPU, the TSC is treated as non > constant > frequency and assumed to stop in C-States, which makes it an unreliable and >

Re: [PATCH 3/8] kvm: vmx: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to the guest

2018-01-15 Thread Thomas Gleixner
On Mon, 15 Jan 2018, Paolo Bonzini wrote: > On 13/01/2018 11:16, Longpeng (Mike) wrote: > >> + /* > >> + * FIXME: this is only needed until SPEC_CTRL is supported > >> + * by upstream Linux in cpufeatures, then it can be replaced > >> + * with static_cpu_has. > >> + */ > >> +

Re: [BUG 4.15-rc7] IRQ matrix management errors

2018-01-15 Thread Thomas Gleixner
On Sun, 14 Jan 2018, Keith Busch wrote: > I hoped to have a better report before the weekend, but I've run out of > time and without my machine till next week, so sending what I have and > praying someone more in the know will have a better clue. > > I've a few NVMe drives and occasionally the

Re: [GIT pull] x86/pti updates for 4.15

2018-01-14 Thread Thomas Gleixner
On Sun, 14 Jan 2018, Linus Torvalds wrote: > On Sun, Jan 14, 2018 at 1:01 PM, Thomas Gleixner <t...@linutronix.de> wrote: > > > > Good point. I'll queue a patch to that effect or do you just want to do > > that yourself? > > I don't think it's critical,

Re: [RFC PATCH 00/20] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-01-14 Thread Thomas Gleixner
On Fri, 17 Nov 2017, Reinette Chatre wrote: Sorry for the delay. You know why :) > On 11/17/2017 4:48 PM, Thomas Gleixner wrote: > > On Mon, 13 Nov 2017, Reinette Chatre wrote: > > Did you compare that against the good old cache coloring mechanism, > > e.g. palloc ? > &

[PATCH v6 01/36] timers: Use static keys for migrate_enable/nohz_active

2018-01-14 Thread Thomas Gleixner
From: Thomas Gleixner <t...@linutronix.de> The members migrate_enable and nohz_active in the timer/hrtimer per CPU bases have been introduced to avoid accessing global variables for these decisions. Still that results in a (cache hot) load and conditional branch, which can be avoided by

Re: [PATCH v5 01/36] timers: Use static keys for migrate_enable/nohz_active

2018-01-14 Thread Thomas Gleixner
On Fri, 22 Dec 2017, Sebastian Andrzej Siewior wrote: > - if (!IS_ENABLED(CONFIG_NO_HZ_COMMON) || !base->nohz_active) > + if (!is_timers_nohz_active()) That's wrong. You are undoing the mainline changes. I'll send an updated one. Thanks, tglx

[tip:x86/pti] x86/retpoline: Remove compile time warning

2018-01-14 Thread tip-bot for Thomas Gleixner
Commit-ID: b8b9ce4b5aec8de9e23cabb0a26b78641f9ab1d6 Gitweb: https://git.kernel.org/tip/b8b9ce4b5aec8de9e23cabb0a26b78641f9ab1d6 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Sun, 14 Jan 2018 22:13:29 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate:

Re: [GIT pull] x86/pti updates for 4.15

2018-01-14 Thread Thomas Gleixner
On Sun, 14 Jan 2018, Linus Torvalds wrote: > On Sun, Jan 14, 2018 at 7:27 AM, Thomas Gleixner <t...@linutronix.de> wrote: > > > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > > x86-pti-for-linus > > So I do think this: > &g

Re: [PATCH V4 6/8] perf/x86/intel/uncore: SKX support for IIO free running counters

2018-01-14 Thread Thomas Gleixner
..@intel.com> Assumed that all the magic numbers are correct: Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH V4 8/8] perf/x86/intel/uncore: clean up client IMC uncore

2018-01-14 Thread Thomas Gleixner
> Introduce free running counter type SNB_PCI_UNCORE_IMC_DATA for data > read and data write counters. > > Keep the custom event_init() function compatible with old event > encoding. > > Clean up other custom event_* functions. > > Signed-off-by: Kan Liang <

Re: [PATCH V4 7/8] perf/x86/intel/uncore: expose uncore_pmu_event functions

2018-01-14 Thread Thomas Gleixner
ions like > add()/del()/start()/stop()/read() can use generic code. > > Expose the uncore_pmu_event_add/del/start/stop functions. > > Signed-off-by: Kan Liang <kan.li...@intel.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH V4 4/8] perf/x86/intel/uncore: add new data structures for free running counters

2018-01-14 Thread Thomas Gleixner
On Sun, 14 Jan 2018, Thomas Gleixner wrote: > On Thu, 2 Nov 2017, kan.li...@intel.com wrote: > > +/* > > + * Free running counter is similar as fixed counter, except it is read-only > > + * and always active when the uncore box is powered up. > > + * > > + *

Re: [PATCH V4 5/8] perf/x86/intel/uncore: add infrastructure for free running counter

2018-01-14 Thread Thomas Gleixner
ility. > > Use inline helpers to check fixed counter index and free running counter > index. > That changelog is horrible to read. Other than that: Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH V4 4/8] perf/x86/intel/uncore: add new data structures for free running counters

2018-01-14 Thread Thomas Gleixner
On Thu, 2 Nov 2017, kan.li...@intel.com wrote: > +/* > + * Free running counter is similar as fixed counter, except it is read-only > + * and always active when the uncore box is powered up. > + * > + * Here are the rules which are used to encode the event for free running > + * counter. > + * -

Re: [PATCH V4 3/8] perf/x86/intel/uncore: correct fixed counter index check in generic code

2018-01-14 Thread Thomas Gleixner
se. It does not touch the generic code. > For generic code, it is not correct to use >= to check fixed counter. > The code quality issue will bring problem when new counter index is > introduced. > > Signed-off-by: Kan Liang <kan.li...@intel.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH V4 2/8] perf/x86/intel/uncore: correct fixed counter index check for NHM

2018-01-14 Thread Thomas Gleixner
nter. > The code quality issue will bring problem when new counter index is > introduced. > > Signed-off-by: Kan Liang <kan.li...@intel.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de>

Re: [PATCH v2 4/7] x86/hyper-v: redirect reenlightment notifications on CPU offlining

2018-01-14 Thread Thomas Gleixner
On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote: > +static int hv_cpu_die(unsigned int cpu) > +{ > + struct hv_reenlightenment_control re_ctrl; > + int i; > + static DEFINE_SPINLOCK(lock); > + > + if (hv_reenlightenment_cb == NULL) > + return 0; > + > + /* Make sure the

Re: [PATCH v2 3/7] x86/hyper-v: reenlightenment notifications support

2018-01-14 Thread Thomas Gleixner
On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote: > +void hyperv_reenlightenment_intr(struct pt_regs *regs) Lacks __visible and __irq_entry annotations. Thanks, tglx

Re: [PATCH v2 2/7] x86/hyper-v: add a function to read both TSC and TSC page value simulateneously

2018-01-14 Thread Thomas Gleixner
On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote: > This is going to be used from KVM code where we need to get both > TSC and TSC page value. > > When Hyper-V code is compiled out just return rdtsc(), this will allow us > to avoid ugly ifdefs in non-Hyper-V code. That's not what the patch

Re: [PATCH v2 1/7] x86/hyper-v: check for required priviliges in hyperv_init()

2018-01-14 Thread Thomas Gleixner
italy Kuznetsov <vkuzn...@redhat.com> Reviewed-by: Thomas Gleixner <t...@linutronix.de> > --- > arch/x86/hyperv/hv_init.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > index 1

Re: [PATCH] time: POSIX CPU timers: Ensure that variable is initialized

2018-01-14 Thread Thomas Gleixner
On Mon, 8 Jan 2018, Max R. P. Grossmann wrote: > If cpu_timer_sample_group returns -EINVAL, it will not have written into > *sample. Checking for cpu_timer_sample_group's return value precludes the > potential use of an uninitialized value of now in the following block. > Given an invalid

Re: [PATCH 4/6] x86/kvm: Make steal_time visible

2018-01-14 Thread Thomas Gleixner
On Thu, 21 Dec 2017, Andi Kleen wrote: > From: Andi Kleen > > This per cpu variable is accessed from assembler code, so needs > to be visible. > > Signed-off-by: Andi Kleen > --- > arch/x86/kernel/kvm.c | 2 +- KVM has maintainers ... > 1 file

Re: [PATCH 3/6] locking/spinlocks: Mark spinlocks noinline when inline spinlocks are disabled

2018-01-14 Thread Thomas Gleixner
On Thu, 21 Dec 2017, Andi Kleen wrote: > From: Andi Kleen > > Otherwise LTO will inline them anyways and cause a large > kernel text increase. > > Since the explicit intention here is to not inline them marking > them noinline is good documentation even for the non LTO

Re: [PATCH 2/6] x86/xen: Mark pv stub assembler symbol visible

2018-01-14 Thread Thomas Gleixner
On Thu, 21 Dec 2017, Andi Kleen wrote: > From: Andi Kleen > > With LTO any external assembler symbol has to be marked __visible. > Mark the generated asm PV stubs __visible to prevent a linker error. > > Signed-off-by: Andi Kleen Lacks cc of the

Re: [tip:x86/pti] x86/retpoline: Fill return stack buffer on vmexit

2018-01-14 Thread Thomas Gleixner
> > Author: David Woodhouse <d...@amazon.co.uk> > > AuthorDate: Fri, 12 Jan 2018 11:11:27 + > > Committer: Thomas Gleixner <t...@linutronix.de> > > CommitDate: Fri, 12 Jan 2018 12:33:37 +0100 > > > > x86/retpoline: Fill return stack buffer on vm

[GIT pull] x86/pti updates for 4.15

2018-01-14 Thread Thomas Gleixner
PTI Thomas Gleixner (3): sysfs/cpu: Add vulnerability folder x86/cpu: Implement CPU vulnerabilites sysfs functions x86/pti: Fix !PCID and sanitize defines Tom Lendacky (2): x86/cpu/AMD: Make LFENCE a serializing instruction x86/cpu/AMD: Use LFENCE_RDTSC in prefere

Re: [tip:x86/mm] x86/kasan: Panic if there is not enough memory to boot

2018-01-14 Thread Thomas Gleixner
gt; Author: Andrey Ryabinin <aryabi...@virtuozzo.com> > > AuthorDate: Wed, 10 Jan 2018 18:36:02 +0300 > > Committer: Thomas Gleixner <t...@linutronix.de> > > CommitDate: Sun, 14 Jan 2018 12:59:51 +0100 > > > > x86/kasan: Panic if there is not enough memory t

  1   2   3   4   5   6   7   8   9   10   >