n 2016 05:34:50 -0400 (EDT)
>
> > From: <th...@altera.com>
> > Date: Fri, 24 Jun 2016 02:13:23 -0700
> >
> >> From: Tien Hock Loh <th...@altera.com>
> >>
> >> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
>
0 (EDT)
>
> > From:
> > Date: Fri, 24 Jun 2016 02:13:23 -0700
> >
> >> From: Tien Hock Loh
> >>
> >> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> >> the dwmac is set to sgmii.
> >>
> >> Si
Hi Arnd,
On Tue, 2016-06-21 at 11:34 +0200, Arnd Bergmann wrote:
> On Tuesday, June 21, 2016 1:46:11 AM CEST th...@altera.com wrote:
> > diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> > b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> > index 72d82d6..dd10f2f
Hi Arnd,
On Tue, 2016-06-21 at 11:34 +0200, Arnd Bergmann wrote:
> On Tuesday, June 21, 2016 1:46:11 AM CEST th...@altera.com wrote:
> > diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> > b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> > index 72d82d6..dd10f2f
Hi Peppe,
On Wed, 2016-06-22 at 11:00 +0200, Giuseppe CAVALLARO wrote:
> Hello Tien Hock
>
> On 6/21/2016 10:46 AM, th...@altera.com wrote:
> > From: Tien Hock Loh <th...@altera.com>
> >
> > This adds support for TSE PCS that uses SGMII adapter when the phy-mode
Hi Peppe,
On Wed, 2016-06-22 at 11:00 +0200, Giuseppe CAVALLARO wrote:
> Hello Tien Hock
>
> On 6/21/2016 10:46 AM, th...@altera.com wrote:
> > From: Tien Hock Loh
> >
> > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> > the dwm
Hi Peppe,
On Wed, 2016-06-08 at 23:20 +, Giuseppe CAVALLARO wrote:
> Hello Tien Hock
>
> On 6/9/2016 7:48 AM, Tien Hock Loh wrote:
>
> [snip]
>
> >>> .../devicetree/bindings/net/socfpga-dwmac.txt | 4 +
> >>> drivers/net/et
Hi Peppe,
On Wed, 2016-06-08 at 23:20 +, Giuseppe CAVALLARO wrote:
> Hello Tien Hock
>
> On 6/9/2016 7:48 AM, Tien Hock Loh wrote:
>
> [snip]
>
> >>> .../devicetree/bindings/net/socfpga-dwmac.txt | 4 +
> >>> drivers/net/et
Hi Peppe,
On Tue, 2016-06-07 at 10:30 +0200, Giuseppe CAVALLARO wrote:
> Hello
>
> On 6/7/2016 5:01 AM, th...@altera.com wrote:
> > From: Tien Hock Loh <th...@altera.com>
> >
> > This adds support for TSE PCS that uses SGMII adapter when the phy-mode
Hi Peppe,
On Tue, 2016-06-07 at 10:30 +0200, Giuseppe CAVALLARO wrote:
> Hello
>
> On 6/7/2016 5:01 AM, th...@altera.com wrote:
> > From: Tien Hock Loh
> >
> > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> > the dwmac is set to
Acked-by: Tien Hock Loh
On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote:
> This driver calls of_mm_gpiochip_add() to add a memory mapped gpio
> chip. So, of_mm_gpiochip_remove() should be used when removing it.
>
> The direct call of gpiochip_remove() misses unmapping
Acked-by: Tien Hock Loh
On Sun, 2015-06-21 at 08:48 +0900, Masahiro Yamada wrote:
> Adding Tien.
>
>
> 2015-06-19 20:31 GMT+09:00 Masahiro Yamada :
> > The driver gpio-altera.c does not depend on gpio-generic.c at all.
> > Drop unneeded "select GPIO_GENERIC"
Acked-by: Tien Hock Loh
On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote:
> The remove callback never succeeds, which seems odd.
>
> Signed-off-by: Masahiro Yamada
> ---
>
> I wonder why nobody has pointed this out before me.
> I am suspecting -EIO might be inten
Acked-by: Tien Hock Loh th...@altera.com
On Sun, 2015-06-21 at 08:48 +0900, Masahiro Yamada wrote:
Adding Tien.
2015-06-19 20:31 GMT+09:00 Masahiro Yamada yamada.masah...@socionext.com:
The driver gpio-altera.c does not depend on gpio-generic.c at all.
Drop unneeded select GPIO_GENERIC
Acked-by: Tien Hock Loh th...@altera.com
On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote:
The remove callback never succeeds, which seems odd.
Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com
---
I wonder why nobody has pointed this out before me.
I am suspecting
Acked-by: Tien Hock Loh th...@altera.com
On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote:
This driver calls of_mm_gpiochip_add() to add a memory mapped gpio
chip. So, of_mm_gpiochip_remove() should be used when removing it.
The direct call of gpiochip_remove() misses unmapping
Sorry I was away from my mail for the past few weeks.
This isn't intentional, should be a bug I overlook. The fix is correct.
On Sun, 2015-06-21 at 16:25 +0900, Alexandre Courbot wrote:
> On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada
> wrote:
> > The remove callback never succeeds, which
Sorry I was away from my mail for the past few weeks.
This isn't intentional, should be a bug I overlook. The fix is correct.
On Sun, 2015-06-21 at 16:25 +0900, Alexandre Courbot wrote:
On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada
yamada.masah...@socionext.com wrote:
The remove callback
On Thu, 2015-02-05 at 18:54 -0800, Tien Hock Loh wrote:
> On Wed, 2015-01-14 at 10:58 +0100, Linus Walleij wrote:
> > On Wed, Dec 24, 2014 at 9:22 AM, wrote:
> >
> > > From: Tien Hock Loh
> > >
> > > Adds a new driver for Altera soft GPIO IP.
On Thu, 2015-02-05 at 18:54 -0800, Tien Hock Loh wrote:
On Wed, 2015-01-14 at 10:58 +0100, Linus Walleij wrote:
On Wed, Dec 24, 2014 at 9:22 AM, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Adds a new driver for Altera soft GPIO IP. The driver is able to
do read
On Wed, 2015-01-14 at 10:58 +0100, Linus Walleij wrote:
> On Wed, Dec 24, 2014 at 9:22 AM, wrote:
>
> > From: Tien Hock Loh
> >
> > Adds a new driver for Altera soft GPIO IP. The driver is able to
> > do read/write and allows GPIO to be a interrupt controller.
);
> > + } else {
> > + gpiochip_set_chained_irqchip(_gc->mmchip.gc,
> > + _irq_chip,
> > + altera_gc->mapped_irq,
> > + altera_gpio_irq_edge_handler);
> > + }
>
> Sometimes using a ?: te
On Wed, 2015-01-14 at 11:01 +0100, Linus Walleij wrote:
> On Wed, Dec 24, 2014 at 9:22 AM, wrote:
>
> > From: Tien Hock Loh
> >
> > Adds a new driver device tree binding for Altera soft GPIO IP
> >
> > Signed-off-by: Tien Hock Loh
> > ---
> &g
mmchip.gc);
>> +
>> + irq_set_handler_data(altera_gc->mapped_irq, NULL);
>> + irq_set_chained_handler(altera_gc->mapped_irq, NULL);
>> + return -EIO;
>> +}
>> +
>> +static const struct of_device_id altera_gpio_of_match[] = {
>> + { .compa
);
Yup I'll fix it.
Regards,
Tien Hock Loh
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
)
+{
+ return platform_driver_register(altera_gpio_driver);
+}
+subsys_initcall(altera_gpio_init);
+
+static void __exit altera_gpio_exit(void)
+{
+ platform_driver_unregister(altera_gpio_driver);
+}
+module_exit(altera_gpio_exit);
+
+MODULE_AUTHOR(Tien Hock Loh th...@altera.com
On Wed, 2015-01-14 at 11:01 +0100, Linus Walleij wrote:
On Wed, Dec 24, 2014 at 9:22 AM, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Adds a new driver device tree binding for Altera soft GPIO IP
Signed-off-by: Tien Hock Loh th...@altera.com
---
.../devicetree
On Wed, 2015-01-14 at 10:58 +0100, Linus Walleij wrote:
On Wed, Dec 24, 2014 at 9:22 AM, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Adds a new driver for Altera soft GPIO IP. The driver is able to
do read/write and allows GPIO to be a interrupt controller.
Tested
On Wed, Apr 23, 2014 at 9:32 PM, Linus Walleij wrote:
> On Mon, Mar 3, 2014 at 11:27 AM, wrote:
>
>> From: Tien Hock Loh
>>
>> Add driver support for Altera GPIO soft IP, including interrupts and I/O.
>> Tested on Altera CV SoC board using dipsw and LED using L
On Wed, Apr 23, 2014 at 9:32 PM, Linus Walleij linus.wall...@linaro.org wrote:
On Mon, Mar 3, 2014 at 11:27 AM, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Add driver support for Altera GPIO soft IP, including interrupts and I/O.
Tested on Altera CV SoC board using dipsw
On Isn, 2014-04-07 at 12:11 -0500, Josh Cartwright wrote:
> On Mon, Apr 07, 2014 at 04:00:43PM +0800, Tien Hock Loh wrote:
> > On Wed, Mar 19, 2014 at 6:09 PM, Tien Hock Loh wrote:
> > > On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright
> > > wrote:
> > >
On Isn, 2014-04-07 at 12:11 -0500, Josh Cartwright wrote:
On Mon, Apr 07, 2014 at 04:00:43PM +0800, Tien Hock Loh wrote:
On Wed, Mar 19, 2014 at 6:09 PM, Tien Hock Loh th...@altera.com wrote:
On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright jo...@codeaurora.org
wrote:
On Mon, Mar 03
>>>>> Add driver support for Altera GPIO soft IP, including interrupts and I/O.
>>>>> Tested on Altera CV SoC board using dipsw and LED using LED framework.
>>>>>
>>>>> Signed-off-by: Tien Hock Loh
>>>>> ---
>>>&
Add driver support for Altera GPIO soft IP, including interrupts and I/O.
Tested on Altera CV SoC board using dipsw and LED using LED framework.
Signed-off-by: Tien Hock Loh th...@altera.com
---
+ return -ENOMEM;
+ }
+ altera_gc-domain = 0;
+
+ spin_lock_init
On Wed, Mar 19, 2014 at 6:09 PM, Tien Hock Loh wrote:
> On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright wrote:
>> On Mon, Mar 03, 2014 at 06:27:43PM +0800, th...@altera.com wrote:
>>> From: Tien Hock Loh
>>>
>>> Add driver support for Altera GPIO s
On Wed, Mar 19, 2014 at 6:09 PM, Tien Hock Loh th...@altera.com wrote:
On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright jo...@codeaurora.org wrote:
On Mon, Mar 03, 2014 at 06:27:43PM +0800, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Add driver support for Altera GPIO soft IP
On Sat, Mar 8, 2014 at 7:44 PM, Gerhard Sittig wrote:
> On Mon, Mar 03, 2014 at 18:27 +0800, th...@altera.com wrote:
>>
>> From: Tien Hock Loh
>>
>> Add driver support for Altera GPIO soft IP, including interrupts and I/O.
>> Tested on Altera CV SoC board using
On Sat, Mar 8, 2014 at 7:44 PM, Gerhard Sittig g...@denx.de wrote:
On Mon, Mar 03, 2014 at 18:27 +0800, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Add driver support for Altera GPIO soft IP, including interrupts and I/O.
Tested on Altera CV SoC board using dipsw and LED
On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright wrote:
> On Mon, Mar 03, 2014 at 06:27:43PM +0800, th...@altera.com wrote:
>> From: Tien Hock Loh
>>
>> Add driver support for Altera GPIO soft IP, including interrupts and I/O.
>> Tested on Altera CV SoC board us
On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright jo...@codeaurora.org wrote:
On Mon, Mar 03, 2014 at 06:27:43PM +0800, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Add driver support for Altera GPIO soft IP, including interrupts and I/O.
Tested on Altera CV SoC board using
On Wed, 2013-03-27 at 12:58 +0100, Linus Walleij wrote:
> On Tue, Mar 12, 2013 at 6:37 AM, wrote:
>
> > From: Tien Hock Loh
> >
> > Adds a new driver for Altera soft GPIO IP. The driver is able to
> > do read/write and allows GPIO to be a interrupt controller.
On Wed, 2013-03-27 at 12:58 +0100, Linus Walleij wrote:
On Tue, Mar 12, 2013 at 6:37 AM, th...@altera.com wrote:
From: Tien Hock Loh th...@altera.com
Adds a new driver for Altera soft GPIO IP. The driver is able to
do read/write and allows GPIO to be a interrupt controller.
Tested
Hi,
Are the codes good for upstream?
Thanks.
-Original Message-
From: Tien Hock Loh
Sent: Tuesday, March 12, 2013 1:38 PM
To: Linus Walleij; Rob Landley
Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Tien Hock Loh
Subject: [PATCH 1/1] drivers/gpio: Altera soft IP GPIO
Hi,
Are the codes good for upstream?
Thanks.
-Original Message-
From: Tien Hock Loh
Sent: Tuesday, March 12, 2013 1:38 PM
To: Linus Walleij; Rob Landley
Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Tien Hock Loh
Subject: [PATCH 1/1] drivers/gpio: Altera soft IP GPIO
44 matches
Mail list logo
