Re: [RFC PATCH] powerpc: fsl_pci: fix inbound ATMU entries for systems with >4G RAM

2016-08-25 Thread Tillmann Heidsieck
mapping for it". According to the radeon driver it did put one of the rings to this address (viewed from the CPU). Signed-off-by: Tillmann Heidsieck <theidsi...@leenox.de> --- arch/powerpc/sysdev/fsl_pci.c | 40 1 file changed, 20 insertions

Re: [RFC PATCH] powerpc: fsl_pci: fix inbound ATMU entries for systems with >4G RAM

2016-08-25 Thread Tillmann Heidsieck
mapping for it". According to the radeon driver it did put one of the rings to this address (viewed from the CPU). Signed-off-by: Tillmann Heidsieck --- arch/powerpc/sysdev/fsl_pci.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) d

[RFC PATCH] powerpc: fsl_pci: fix inbound ATMU entries for systems with >4G RAM

2016-08-24 Thread Tillmann Heidsieck
our by adding the second window starting at 4G. The current implementation still leaves memory beyond 68G unmapped as this would require yet another ATMU entry. Tested on a T4240 with 12G of RAM and an AMD E6760 PCIe card working with the in-tree radeon driver. Signed-off-by: Tillmann Heidsi

[RFC PATCH] powerpc: fsl_pci: fix inbound ATMU entries for systems with >4G RAM

2016-08-24 Thread Tillmann Heidsieck
our by adding the second window starting at 4G. The current implementation still leaves memory beyond 68G unmapped as this would require yet another ATMU entry. Tested on a T4240 with 12G of RAM and an AMD E6760 PCIe card working with the in-tree radeon driver. Signed-off-by: Tillmann Heidsi

[PATCH] EDAC, mpc85xx: Fix PCIe error capture

2016-08-15 Thread Tillmann Heidsieck
According to the reference manual of MPC8572 and T4240, bit 31 of PEX_ERR_CAP_STAT is W1C (write 1 to clear). This patch adds the corresponding write to PEX_ERR_CAP_STAT in order to fix the PCIe error capture. Tested on a T4240 processor. Signed-off-by: Tillmann Heidsieck <theidsi...@leenox

[PATCH] EDAC, mpc85xx: Fix PCIe error capture

2016-08-15 Thread Tillmann Heidsieck
According to the reference manual of MPC8572 and T4240, bit 31 of PEX_ERR_CAP_STAT is W1C (write 1 to clear). This patch adds the corresponding write to PEX_ERR_CAP_STAT in order to fix the PCIe error capture. Tested on a T4240 processor. Signed-off-by: Tillmann Heidsieck --- drivers/edac

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-18 Thread Tillmann Heidsieck
On Sun, Oct 18, 2015 at 08:54:57PM +0200, Tillmann Heidsieck wrote: > Hi, [...] > Greg is probably trying to apply this series to the staging-next branch of > his staging tree[0] > so you need to clone that one, or add it as an additional remote[1] to your > clone of the kernel tr

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-18 Thread Tillmann Heidsieck
Hi, On 2015-10-18 08:32, punit vara wrote: On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the constant on the right side

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-18 Thread Tillmann Heidsieck
Hi, On 2015-10-18 08:32, punit vara wrote: On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-18 Thread Tillmann Heidsieck
On Sun, Oct 18, 2015 at 08:54:57PM +0200, Tillmann Heidsieck wrote: > Hi, [...] > Greg is probably trying to apply this series to the staging-next branch of > his staging tree[0] > so you need to clone that one, or add it as an additional remote[1] to your > clone of the kernel tr

[PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()

2015-10-10 Thread Tillmann Heidsieck
Smatch complains about returning hard coded error codes, silence this warning. drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Tillmann Heidsieck --- drivers/atm/iphase.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error

2015-10-10 Thread Tillmann Heidsieck
ome or not. Regards, Tillmann Heidsieck Tillmann Heidsieck (2): atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc() atm: iphase: fix misleading indention drivers/atm/iphase.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.6.1 -- To unsubscribe from this list: s

[PATCH 2/2] atm: iphase: fix misleading indention

2015-10-10 Thread Tillmann Heidsieck
Fix a smatch warning: drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended? The code is correct, the indention is misleading. In case the allocation of skb fails, we want to skip to the end. Signed-off-by: Tillmann Heidsieck --- drivers/atm/iphase.c | 2 +- 1 file changed, 1

[PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()

2015-10-10 Thread Tillmann Heidsieck
Smatch complains about returning hard coded error codes, silence this warning. drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Tillmann Heidsieck <theidsi...@leenox.de> --- drivers/atm/iphase.c | 3 ++- 1 file changed, 2 insertions

[PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error

2015-10-10 Thread Tillmann Heidsieck
ome or not. Regards, Tillmann Heidsieck Tillmann Heidsieck (2): atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc() atm: iphase: fix misleading indention drivers/atm/iphase.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.6.1 -- To unsubscribe from this list: s

[PATCH 2/2] atm: iphase: fix misleading indention

2015-10-10 Thread Tillmann Heidsieck
Fix a smatch warning: drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended? The code is correct, the indention is misleading. In case the allocation of skb fails, we want to skip to the end. Signed-off-by: Tillmann Heidsieck <theidsi...@leenox.de> --- drivers/atm/iphase.c | 2

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-29 Thread Tillmann Heidsieck
On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > The primary requirement for moving a driver out of staging is that it use > mac80211. No amount of cosmetic fixing will ever make that change for > rtl8712u! As I am pretty sure someone has done something like this before, is there a

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-29 Thread Tillmann Heidsieck
On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > The primary requirement for moving a driver out of staging is that it use > mac80211. No amount of cosmetic fixing will ever make that change for > rtl8712u! As I am pretty sure someone has done something like this before, is there a

Re: [PATCH] s390/jump_label: Use %*ph to print small buffers

2015-08-26 Thread Tillmann Heidsieck
Hi Alexander, On 2015-08-26 20:49, Alexander Kuleshov wrote: printk() supports %*ph format specifier for printing a small buffers, let's use it intead of %02x %02x... noble effort ... pr_emerg("Jump label code mismatch at %pS [%p]\n", ipc, ipc); - pr_emerg("Found:%02x %02x

Re: [PATCH] s390/jump_label: Use %*ph to print small buffers

2015-08-26 Thread Tillmann Heidsieck
Hi Alexander, On 2015-08-26 20:49, Alexander Kuleshov wrote: printk() supports %*ph format specifier for printing a small buffers, let's use it intead of %02x %02x... noble effort ... pr_emerg(Jump label code mismatch at %pS [%p]\n, ipc, ipc); - pr_emerg(Found:%02x %02x

Re: [PATCH v2] staging: fsl-mc: add DPAA2 overview readme

2015-08-11 Thread Tillmann Heidsieck
Hi Stuart, I am by no means a native speaker, but I have proof-read my fair share of articles and theses, so here are a bunch of suggestions which might or might not help improve you document. On 07.08.2015 03:09, Stuart Yoder wrote: > add README file providing an overview of the DPAA2

Re: [PATCH v2] staging: fsl-mc: add DPAA2 overview readme

2015-08-11 Thread Tillmann Heidsieck
Hi Stuart, I am by no means a native speaker, but I have proof-read my fair share of articles and theses, so here are a bunch of suggestions which might or might not help improve you document. On 07.08.2015 03:09, Stuart Yoder wrote: add README file providing an overview of the DPAA2