Re: [Xen-devel] "tcp: refine TSO autosizing" causes performance regression on Xen

2015-04-16 Thread Tim Deegan
At 12:39 +0100 on 16 Apr (1429187952), George Dunlap wrote: > Your comment lists three benefits: > 1. better RTT estimation > 2. faster recovery > 3. high rates > > #3 is just marketing fluff; it's also contradicted by the statement that > immediately follows it -- i.e., there are drivers for

Re: [Xen-devel] tcp: refine TSO autosizing causes performance regression on Xen

2015-04-16 Thread Tim Deegan
At 12:39 +0100 on 16 Apr (1429187952), George Dunlap wrote: Your comment lists three benefits: 1. better RTT estimation 2. faster recovery 3. high rates #3 is just marketing fluff; it's also contradicted by the statement that immediately follows it -- i.e., there are drivers for which the

[PATCH] ehci-dbgp: drop dead code.

2013-09-12 Thread Tim Deegan
We can only reach this spot by breaking out of the scan loop, so by construction ret > 0. Found by Coverity, in a copy of this file in the Xen sources. Signed-off-by: Tim Deegan Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/usb/early/e

[PATCH] ehci-dbgp: drop dead code.

2013-09-12 Thread Tim Deegan
We can only reach this spot by breaking out of the scan loop, so by construction ret 0. Found by Coverity, in a copy of this file in the Xen sources. Signed-off-by: Tim Deegan t...@xen.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org Cc: linux-kernel

Re: [PATCH LINUX] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-02-19 Thread Tim Deegan
At 17:17 + on 19 Feb (1361294248), Ian Campbell wrote: > On Tue, 2013-02-19 at 17:11 +, Stefano Stabellini wrote: > > On Tue, 19 Feb 2013, Ian Campbell wrote: > > > +/* > > > + * We cannot use xchg because it does not support 8-byte > > > + * values. However it is safe to use {ldr,dtd}exd

Re: [PATCH LINUX] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-02-19 Thread Tim Deegan
At 17:17 + on 19 Feb (1361294248), Ian Campbell wrote: On Tue, 2013-02-19 at 17:11 +, Stefano Stabellini wrote: On Tue, 19 Feb 2013, Ian Campbell wrote: +/* + * We cannot use xchg because it does not support 8-byte + * values. However it is safe to use {ldr,dtd}exd directly