Re: [PATCH] staging/media: Use dev_ printks in go7007/s2250-loader.c

On Tue, Nov 6, 2012 at 12:25 AM, Joe Perches wrote: > On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote: >> On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote: >> > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote: >> > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMA

Re: [PATCH] staging/media: Use dev_ printks in go7007/s2250-loader.c

On Mon, Nov 5, 2012 at 10:11 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: >> fixed below checkpatch warnings. >> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then >> pr_err(... to printk(KERN_ERR ... >> - WARNING: Prefer netde

Re: [PATCH] staging/comedi: Use pr_ or dev_ printks in drivers/gsc_hdpi.c

On Tue, Oct 23, 2012 at 4:52 AM, Greg Kroah-Hartman wrote: > On Wed, Oct 10, 2012 at 09:20:59PM +0900, YAMANE Toshiaki wrote: >> fixed below checkpatch warning. >> - WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then >> pr_warn(... to printk(KERN_WARNING ... >> >> and added pr_f

Re: [PATCH v2] staging/comedi: Use pr_ or dev_ printks in drivers/gsc_hdpi.c

On Thu, Oct 25, 2012 at 11:43 AM, Greg Kroah-Hartman wrote: > On Thu, Oct 25, 2012 at 11:23:13AM +0900, YAMANE Toshiaki wrote: >> fixed below checkpatch warning. >> - WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then >> pr_warn(... to printk(KERN_WARNING ... >> >> some of them

Re: [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c

On Wed, Oct 24, 2012 at 1:15 PM, Greg Kroah-Hartman wrote: > On Wed, Oct 24, 2012 at 12:05:28PM +0900, YAMANE Toshiaki wrote: >> fixed below checkpatch warning. >> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then >> pr_err(... to printk(KERN_ERR ... >> >> Signed-off-by: YAMANE

Re: [PATCH] staging/comedi: Use dev_ printks in drivers/vmk80xx.c

On Tue, Oct 23, 2012 at 4:45 AM, Greg Kroah-Hartman wrote: > Note, when you resend please enumerate what version of the patch this > is, otherwise I can get very confused. Sorry, I am going to watch out for it from the next. -- Regards, YAMANE Toshiaki -- To unsubscribe from this list: send

Re: [PATCH] staging/comedi: Use dev_ printks in drivers/usbdux.c

On Sun, Oct 14, 2012 at 10:38 PM, YAMANE Toshiaki wrote: > fixed below checkpatch warning. > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then > pr_err(... to printk(KERN_ERR ... > > Signed-off-by: YAMANE Toshiaki > --- > drivers/staging/comedi/drivers/usbdux.c | 10 ---

Re: [PATCH] staging/comedi: Use dev_ printks in drivers/adl_pci8164.c

On Fri, Oct 5, 2012 at 6:15 PM, Ian Abbott wrote: > On 2012-10-05 01:07, YAMANE Toshiaki wrote: >> >> fixed below checkpatch warning. >> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then >> pr_err(... to printk(KERN_ERR ... >> >> Signed-off-by: YAMANE Toshiaki >> --- >> drive

Re: [PATCH] staging/comedi: Use dev_ printks in drivers/me_daq.c

On Fri, Oct 5, 2012 at 6:08 PM, Ian Abbott wrote: > On 2012-10-05 01:07, YAMANE Toshiaki wrote: >> >> fixed below checkpatch warnings. >> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then >> pr_err(... to printk(KERN_ERR ... >> - WARNING: quoted string split across lines >> >> S

Re: [PATCH 3/3] Fix line over 80 character issue and space before tabs issue in trace.h

On Tue, Oct 2, 2012 at 9:23 PM, Dan Carpenter wrote: > On Tue, Oct 02, 2012 at 08:54:48PM +0900, YAMANE Toshiaki wrote: >> fixed some checkpatch warnings. >> >> -WARNING: line over 80 characters >> -WARNING: please, no space before tabs >> > > These looked nicer in the original, sorry. I will des

Re: [PATCH 2/3] Add parenthesis to macros with complex values in trace.h

On Tue, Oct 2, 2012 at 9:21 PM, Dan Carpenter wrote: > On Tue, Oct 02, 2012 at 08:54:28PM +0900, YAMANE Toshiaki wrote: >> fixed some checkpatch below error. >> -ERROR: Macros with complex values should be enclosed in parenthesis >> >> Signed-off-by: Toshiaki Yamane

Re: [PATCH 1/3] Fix trailing whitespace in trace.h

On Tue, Oct 2, 2012 at 9:12 PM, Andy Shevchenko wrote: > On Tue, 2012-10-02 at 20:53 +0900, YAMANE Toshiaki wrote: >> fixed below checkpatch error. >> >> -ERROR: trailing whitespace >> >> Signed-off-by: Toshiaki Yamane >> --- >> drivers/staging/rts_

[PATCH] staging/rts_pstor: Use pr_ or dev_ printks in rtsx.c

fixed some checkpatch warnings. -WARNING: Prefer pr_info(... to printk(KERN_INFO, ... -WARNING: Prefer pr_err(... to printk(KERN_ERR, ... -WARNING: quoted string split across lines And added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/rtsx.c | 106

Re: [PATCH 1/2] staging/vme: Use pr_ printks in vme_user.c

On Wed, Sep 12, 2012 at 4:08 AM, Greg Kroah-Hartman wrote: > On Tue, Sep 11, 2012 at 04:16:14PM +0900, Toshiaki Yamane wrote: >> The below checkpatch warnings was fixed, >> >> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ... >> -WARNING: Prefer pr_warn

[PATCH 2/2] staging/vme: Use dev_ printks in vme_user.c

The below checkpatch warnings was fixed, -WARNING: Prefer pr_info(... to printk(KERN_INFO, ... -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... -WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... -WARNING: Prefer pr_err(... to printk(KERN_ERR, ... Signed-off-by: Toshiaki Yamane

[PATCH 1/2] staging/vme: Use pr_ printks in vme_user.c

The below checkpatch warnings was fixed, -WARNING: Prefer pr_info(... to printk(KERN_INFO, ... -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... -WARNING: Prefer pr_err(... to printk(KERN_ERR, ... and added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices

[PATCH] staging/rts_pstor: remove braces {} in rtsx_scsi.c

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/rtsx_scsi.c | 403 ++--- 1 file

[PATCH 57/57] staging/rts_pstor: remove braces {} in sd.c (release_sd_card)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 56/57] staging/rts_pstor: remove braces {} in sd.c (sd_power_off_card3v3)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 55/57] staging/rts_pstor: remove braces {} in sd.c (sd_hw_rst)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 54/57] staging/rts_pstor: remove braces {} in sd.c (sd_execute_write_data)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 90 1 file

[PATCH 53/57] staging/rts_pstor: remove braces {} in sd.c (sd_execute_read_data)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 71 +++- 1 file

[PATCH 52/57] staging/rts_pstor: remove braces {} in sd.c (sd_execute_no_data)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 41 +++- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/drivers/staging

[PATCH 51/57] staging/rts_pstor: remove braces {} in sd.c (get_rsp_type)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 50/57] staging/rts_pstor: remove braces {} in sd.c (sd_pass_thru_mode)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 49/57] staging/rts_pstor: remove braces {} in sd.c (ext_sd_get_rsp)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers

[PATCH 48/57] staging/rts_pstor: remove braces {} in sd.c (ext_sd_send_cmd_get_rsp)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/staging

[PATCH 47/57] staging/rts_pstor: remove braces {} in sd.c (sd_rw)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 26 ++ 1 file changed, 10

[PATCH 46/57] staging/rts_pstor: remove braces {} in sd.c (sd_auto_tune_clock)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 45/57] staging/rts_pstor: remove braces {} in sd.c (sd_stop_seq_mode)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 44/57] staging/rts_pstor: remove braces {} in sd.c (wait_data_buf_ready)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 43/57] staging/rts_pstor: remove braces {} in sd.c (reset_mmc_only)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers

[PATCH 42/57] staging/rts_pstor: remove braces {} in sd.c (reset_sd_card)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b

[PATCH 41/57] staging/rts_pstor: remove braces {} in sd.c (reset_mmc)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 52 +++- 1 file

[PATCH 40/57] staging/rts_pstor: remove braces {} in sd.c (mmc_switch_timing_bus)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 16 ++-- 1 file changed, 6 insertions(+), 10

[PATCH 39/57] staging/rts_pstor: remove braces {} in sd.c (mmc_test_switch_bus)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 32 +--- 1 file changed, 13

[PATCH 38/57] staging/rts_pstor: remove braces {} in sd.c (reset_sd)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 114 1 file

[PATCH 37/57] staging/rts_pstor: remove braces {} in sd.c (sd_check_wp_state)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 36/57] staging/rts_pstor: remove braces {} in sd.c (sd_read_lba0)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 35/57] staging/rts_pstor: remove braces {} in sd.c (sd_init_power)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b

[PATCH 34/57] staging/rts_pstor: remove braces {} in sd.c (sd_pull_ctl_enable)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 33/57] staging/rts_pstor: remove braces {} in sd.c (sd_prepare_reset)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 11 --- 1 file changed, 4 insertions(+), 7

[PATCH 32/57] staging/rts_pstor: remove braces {} in sd.c (sd_switch_clock)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 17 ++--- 1 file changed, 6 insertions(+), 11

[PATCH 31/57] staging/rts_pstor: remove braces {} in sd.c (mmc_ddr_tuning)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers

[PATCH 30/57] staging/rts_pstor: remove braces {} in sd.c (sd_ddr_tuning)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers

[PATCH 29/57] staging/rts_pstor: remove braces {} in sd.c (sd_sdr_tuning)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 28/57] staging/rts_pstor: remove braces {} in sd.c (sd_tuning_tx)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 24 ++-- 1 file changed, 10 insertions

[PATCH 27/57] staging/rts_pstor: remove braces {} in sd.c (sd_ddr_pre_tuning_tx)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers

[PATCH 26/57] staging/rts_pstor: remove braces {} in sd.c (sd_tuning_rx)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 24 ++-- 1 file changed, 10 insertions

[PATCH 25/57] staging/rts_pstor: remove braces {} in sd.c (sd_search_final_phase)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 19 --- 1 file changed, 8 insertions

[PATCH 24/57] staging/rts_pstor: remove braces {} in sd.c (sd_ddr_tuning_tx_cmd)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 13 + 1 file changed, 5 insertions(+), 8

[PATCH 23/57] staging/rts_pstor: remove braces {} in sd.c (sd_sdr_tuning_tx_cmd)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 22/57] staging/rts_pstor: remove braces {} in sd.c (mmc_ddr_tunning_rx_cmd)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 10 -- 1 file changed, 4 insertions(+), 6

[PATCH 21/57] staging/rts_pstor: remove braces {} in sd.c (sd_ddr_tuning_rx_cmd)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 20/57] staging/rts_pstor: remove braces {} in sd.c (sd_sdr_tuning_rx_cmd)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 19/57] staging/rts_pstor: remove braces {} in sd.c (sd_switch_function)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 48 ++-- 1 file

[PATCH 18/57] staging/rts_pstor: remove braces {} in sd.c (sd_check_switch)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 17/57] staging/rts_pstor: remove braces {} in sd.c (downgrade_switch_mode)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 16/57] staging/rts_pstor: remove braces {} in sd.c (sd_check_switch_mode)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 15/57] staging/rts_pstor: remove braces {} in sd.c (sd_check_spec)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 13/57] staging/rts_pstor: remove braces {} in sd.c (sd_voltage_switch)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 14/57] staging/rts_pstor: remove braces {} in sd.c (sd_change_phase)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 20 +--- 1 file changed, 9 insertions

[PATCH 12/57] staging/rts_pstor: remove braces {} in sd.c (sd_change_bank_voltage)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 11/57] staging/rts_pstor: remove braces {} in sd.c (sd_wait_state_data_ready)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 10/57] staging/rts_pstor: remove braces {} in sd.c (sd_update_lock_status)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 11 --- 1 file changed, 4 insertions(+), 7

[PATCH 09/57] staging/rts_pstor: remove braces {} in sd.c (sd_select_card)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 08/57] staging/rts_pstor: remove braces {} in sd.c (sd_set_init_para)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 07/57] staging/rts_pstor: remove braces {} in sd.c (sd_set_clock_divider)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 06/57] staging/rts_pstor: remove braces {} in sd.c (sd_choose_proper_clock)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/staging

[PATCH 05/57] staging/rts_pstor: remove braces {} in sd.c (sd_set_sample_push_timing)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 31 +-- 1 file changed, 13

[PATCH 04/57] staging/rts_pstor: remove braces {} in sd.c (sd_check_csd)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 39 ++- 1 file changed

[PATCH 03/57] staging/rts_pstor: remove braces {} in sd.c (sd_write_data)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging

[PATCH 02/57] staging/rts_pstor: remove braces {} in sd.c (sd_read_data)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rts_pstor/sd.c b/drivers

[PATCH 01/57] staging/rts_pstor: remove braces {} in sd.c (sd_send_cmd_get_rsp)

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/sd.c | 12 +--- 1 file changed, 5 insertions(+), 7

Re: [PATCH] staging/rts_pstor: remove braces {} in sd.c

On Wed, Sep 5, 2012 at 4:30 AM, Greg Kroah-Hartman wrote: > On Sat, Sep 01, 2012 at 10:43:00PM +0900, Toshiaki Yamane wrote: >> fixed below checkpatch warnings. >> -WARNING: braces {} are not necessary for single statement blocks >> -WARNING: braces {} are not necessar

Re: [PATCH] staging/rts_pstor: remove braces {} in sd.c

On Wed, Sep 5, 2012 at 4:30 AM, Greg Kroah-Hartman wrote: > On Sat, Sep 01, 2012 at 10:43:00PM +0900, Toshiaki Yamane wrote: >> fixed below checkpatch warnings. >> -WARNING: braces {} are not necessary for single statement blocks >> -WARNING: braces {} are not necessar

Re: [PATCH] staging/rts_pstor: remove braces {} in sd.c

On Sun, Sep 2, 2012 at 12:05 AM, devendra.aaru wrote: > Hello, > > This is a very big patch. It will be difficult for reviewers to review. > > i think it will be good if you can split into multiple patches. Thanks for your reply. Should I do that ? I have a similar patch some more. -- To unsubsc

[PATCH] staging/rts_pstor: remove braces {} in rtsx_card.c

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/rtsx_card.c | 186 ++--- 1 file

[PATCH] staging/rts_pstor: remove braces {} in rtsx_transport.c

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/rtsx_transport.c | 100 +--- 1 file

[PATCH] staging/rts_pstor: remove braces {} in rtsx_chip.c

fixed below checkpatch warnings. -WARNING: braces {} are not necessary for single statement blocks -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/rtsx_chip.c | 563 ++--- 1 file

[PATCH 2/2] staging/rts_pstor: Use pr_ printks in debug.h

fixed below checkpatch warnings. -WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... And added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/debug.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts_pstor/debug.h b

[PATCH 1/2] staging/rts_pstor: Use pr_ printks in rtsx.c

fixed some checkpatch warnings. -WARNING: Prefer pr_info(... to printk(KERN_INFO, ... -WARNING: Prefer pr_err(... to printk(KERN_ERR, ... -WARNING: quoted string split across lines And added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/rts_pstor/rtsx.c | 107

[PATCH 3/3] staging/vme: Use pr_ printks in vme_pio2_core.c

The below checkpatch warnings was fixed, -WARNING: Prefer pr_err(... to printk(KERN_ERR, ... and added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices/vme_pio2_core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vme

[PATCH 2/3] staging/vme: Use pr_ printks in vme_user.c

: Toshiaki Yamane --- drivers/staging/vme/devices/vme_user.c | 69 ++-- 1 file changed, 30 insertions(+), 39 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e39d273..7d28086 100644 --- a/drivers/staging/vme

[PATCH 1/3] Staging: vme: Fix a white space issue

The below checkpatch error was fixed. -ERROR: trailing whitespace Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices/vme_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c

Re: [PATCH 2/5] staging/vme: fix checkpatch warning

On Fri, Aug 17, 2012 at 11:30 PM, Toshiaki Yamane wrote: > On Fri, Aug 17, 2012 at 10:19 PM, Greg Kroah-Hartman > wrote: >> On Fri, Aug 17, 2012 at 05:27:53PM +0900, Toshiaki Yamane wrote: >>> On Fri, Aug 17, 2012 at 4:46 PM, Dan Carpenter >>> wrote: >>>

Re: [PATCH 2/5] staging/vme: fix checkpatch warning

On Fri, Aug 17, 2012 at 10:19 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 17, 2012 at 05:27:53PM +0900, Toshiaki Yamane wrote: >> On Fri, Aug 17, 2012 at 4:46 PM, Dan Carpenter >> wrote: >> > You've got the same subject repeated 5 times. >> > >> >

Re: [PATCH 2/5] staging/vme: fix checkpatch warning

On Fri, Aug 17, 2012 at 4:46 PM, Dan Carpenter wrote: > You've got the same subject repeated 5 times. > > It would be better to merge all the vme_user.c printk fixes into > one patch. > [patch 1/3] Staging: vme: Fix a white space issue > [patch 2/3] Staging: vme: Use pr_ printks in vme_user.c > [p

[PATCH] staging/olpc_dcon: fix checkpatch warnings

-off-by: Toshiaki Yamane --- drivers/staging/olpc_dcon/olpc_dcon.c| 53 -- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 15 --- drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c |6 ++- 3 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers

[PATCH 5/5] staging/vme: fix checkpatch warning

The below checkpatch warnings was fixed, -WARNING: Prefer pr_err(... to printk(KERN_ERR, ... and added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices/vme_pio2_core.c | 10 +- drivers/staging/vme/devices/vme_user.c | 14 ++ 2 files changed

[PATCH 4/5] staging/vme: fix checkpatch warning

The below checkpatch warnings was fixed. -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices/vme_user.c | 36 +--- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/staging

[PATCH 3/5] staging/vme: fix checkpatch warning

The below checkpatch warnings was fixed. -WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices/vme_user.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b

[PATCH 2/5] staging/vme: fix checkpatch warning

The below checkpatch warnings was fixed, -WARNING: Prefer pr_info(... to printk(KERN_INFO, ... and added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices/vme_user.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme

[PATCH 1/5] staging/vme: fix checkpatch error

The below checkpatch error was fixed. -ERROR: trailing whitespace Signed-off-by: Toshiaki Yamane --- drivers/staging/vme/devices/vme_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c

[PATCH] staging/olpc_dcon: fix checkpatch warnings

k(KERN_ERR, ... And added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/olpc_dcon/olpc_dcon.c| 53 -- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 15 --- drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c |6 ++- 3 files changed, 37 i

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

On Fri, Jul 27, 2012 at 2:03 PM, Joe Perches wrote: > On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote: >> fixed some checkpatch warnings. >> (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) > [] >> diff --git a/drivers/staging/olpc_dcon/olpc_d

[PATCH] staging/olpc_dcon: fix checkpatch warnings

k(KERN_ERR, ... And added pr_fmt. Signed-off-by: Toshiaki Yamane --- drivers/staging/olpc_dcon/olpc_dcon.c| 52 +- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 15 --- drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c |6 ++- 3 files changed, 39 i

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

On Fri, Jul 27, 2012 at 11:28 AM, Andres Salomon wrote: > On Fri, 27 Jul 2012 08:49:19 +0900 > Toshiaki Yamane wrote: > >> Now checkpatch clean. >> >> $ find drivers/staging/olpc_dcon/ -name >> "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nos

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

On Fri, Jul 27, 2012 at 10:40 AM, Joe Perches wrote: > On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote: >> Now checkpatch clean. > [] >> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c >> b/drivers/staging/olpc_dcon/olpc_dcon.c > [] >> @@ -11,6 +11

[PATCH] staging/olpc_dcon: fix checkpatch warnings

ARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... 3 WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... 6 WARNING: Prefer pr_info(... to printk(KERN_INFO, ... 19 WARNING: Prefer pr_err(... to printk(KERN_ERR, ... And added pr_fmt. Signed-off-by: Toshiaki Yamane --- dr

  1   2   >