Re: [PATCH v2 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
On 08/11/2015 08:13 AM, sdliy...@gmail.com wrote: From: Yong Li When the device tree support is disabled, the fifo_pin is uninitialized, this patch will set the fifo_pin value based on platform data Signed-off-by: Yong Li Acked-by: Varka Bhadram --- drivers/net/ieee802154/cc2520.c | 1

Re: [PATCHv1 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
-patch --subject-prefix="PATCH v2 bluetooth-next" -1 git send-email 0001- -- Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

Re: [PATCHv1 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
-patch --subject-prefix=PATCH v2 bluetooth-next -1 git send-email 0001- -- Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH v2 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
On 08/11/2015 08:13 AM, sdliy...@gmail.com wrote: From: Yong Li sdliy...@gmail.com When the device tree support is disabled, the fifo_pin is uninitialized, this patch will set the fifo_pin value based on platform data Signed-off-by: Yong Li sdliy...@gmail.com Acked-by: Varka Bhadram

Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-26 Thread Varka Bhadram
/pwm-crc.c | 143 ++ 3 files changed, 151 insertions(+) create mode 100644 drivers/pwm/pwm-crc.c Reviewed-by: Varka Bhadram -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-26 Thread Varka Bhadram
100644 drivers/pwm/pwm-crc.c Reviewed-by: Varka Bhadram varkabhad...@gmail.com -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-06-23 Thread Varka Bhadram
Borneo To: Alan Ott To: Alexander Aring To: Varka Bhadram To: linux-w...@vger.kernel.org To: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ieee802154/cc2520.c | 1 - drivers/net/ieee802154/mrf24j40.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-06-23 Thread Varka Bhadram
Borneo borneo.anto...@gmail.com To: Alan Ott a...@signal11.us To: Alexander Aring alex.ar...@gmail.com To: Varka Bhadram varkabhad...@gmail.com To: linux-w...@vger.kernel.org To: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ieee802154/cc2520.c | 1 - drivers/net

Re: [v2 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-22 Thread Varka Bhadram
}, +}; + +builtin_platform_driver(crystalcove_pwm_driver); -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-06-22 Thread Varka Bhadram
--- Here you add this change history so that after applying this will not be the part of your commit description. This comment is applicable for all of your patches. -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please re

Re: [v2 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-22 Thread Varka Bhadram
= { + .probe = crystalcove_pwm_probe, + .remove = crystalcove_pwm_remove, + .driver = { + .name = crystal_cove_pwm, + }, +}; + +builtin_platform_driver(crystalcove_pwm_driver); -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line

Re: [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-06-22 Thread Varka Bhadram
. -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] usb: image: mdc800: fixed various style issues

2015-04-24 Thread Varka Bhadram
} > + mdc800->state = READY; > + break; > } > } > i++; > @@ -956,8 +865,7 @@ static ssize_t mdc800_device_write (struct file *file, > const char __user *buf

Re: [PATCH v7 0/3] Add ktd2692 Flash LED driver using LED Flash class

2015-04-24 Thread Varka Bhadram
| 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-ktd2692.c| 435 > + > 5 files changed, 493 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2

Re: [PATCH v7 0/3] Add ktd2692 Flash LED driver using LED Flash class

2015-04-24 Thread Varka Bhadram
+ 5 files changed, 493 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt create mode 100644 drivers/leds/leds-ktd2692.c Reviewed-by: Varka Bhadram varkabhad...@gmail.com Thanks -- Varka Bhadram -- To unsubscribe from this list: send the line

Re: [PATCH] usb: image: mdc800: fixed various style issues

2015-04-24 Thread Varka Bhadram
); +MODULE_DESCRIPTION(DRIVER_DESC); MODULE_LICENSE(GPL); - Ran checkpatch on this. Result: total: 0 errors, 28 warnings, 1231 lines checked 0001-usb-image-mdc800-fixed-various-style-issues.patch has style problems, please review. Thanks -- Varka Bhadram -- To unsubscribe from this list

Re: [PATCH v4 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-03-24 Thread Varka Bhadram
timeout ranges from 0 to 1835000us and + default is 1049000us. + +Example: + +flash-led { + compatible = "kinetic,ktd2692"; + ctrl-gpio = < 1 0>; + aux-gpio = < 2 0>; + flash-timeout-us = <1835000>; + vin-supply = <

Re: [PATCH v4 3/3] leds: Add ktd2692 flash LED driver

2015-03-24 Thread Varka Bhadram
d2692", }, + { /* sentinel */ }, +}; + +static struct platform_driver ktd2692_driver = { + .driver = { + .name = "leds-ktd2692", + .of_match_table = ktd2692_match, + }, + .probe = ktd2692_probe, + .remove = ktd2692_remove

Re: [PATCH v4 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-03-24 Thread Varka Bhadram
timeout ranges from 0 to 1835000us and + default is 1049000us. + +Example: + +flash-led { + compatible = kinetic,ktd2692; + ctrl-gpio = gpc0 1 0; + aux-gpio = gpc0 2 0; + flash-timeout-us = 1835000; + vin-supply = vbat; +}; -- Varka Bhadram

Re: [PATCH v4 3/3] leds: Add ktd2692 flash LED driver

2015-03-24 Thread Varka Bhadram
= ktd2692_match, + }, + .probe = ktd2692_probe, + .remove = ktd2692_remove, +}; + +module_platform_driver(ktd2692_driver); + +MODULE_AUTHOR(Ingi Kim ingi2@samsung.com); +MODULE_DESCRIPTION(Kinetic KTD2692 LED driver); +MODULE_LICENSE(GPL v2); -- Varka Bhadram -- To unsubscribe from

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Varka Bhadram
ov2659_get_pdata: DT Node *not* found...? -- Varka Bhadram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-20 Thread Varka Bhadram
evice for driver\n"); + goto err_free_irq; + } + dev_info(>dev, +"accelerometer driver loaded. device id %x\n", byte); + + return 0; + + err_free_irq: + if (mma->irq) + free_irq(mma->irq, mma); + err_free_mem

Re: [PATCH v4] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-20 Thread Varka Bhadram
, mma); + dev_dbg(client-dev, unregistered accelerometer\n); + kfree(mma); same as above.. -- Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Varka Bhadram
) { + dev_err(client-dev, ov2659_get_pdata: DT Node found\n); ov2659_get_pdata: DT Node *not* found...? -- Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 3/3] leds: Add ktd2692 flash LED driver

2015-02-26 Thread Varka Bhadram
n't register LED %s\n", led->cdev.name); > + return ret; > + } > + > + ret = ktd2692_brightness_set_gpio(led); > + if (ret) { > + led_classdev_unregister(>cdev); > + return ret; > + } > + > + ktd2692_expresswire_reset(led); > + > + return ret

Re: [PATCH 3/3] leds: Add ktd2692 flash LED driver

2015-02-26 Thread Varka Bhadram
, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] drivers: isdn: icn: icn.h Clean up trivial checkpatch errors.

2015-02-07 Thread Varka Bhadram
Hi, On Saturday 07 February 2015 09:26 PM, Bas Peters wrote: Missed Signed-off-by line... --- drivers/isdn/icn/icn.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH 1/2] drivers: isdn: icn: icn.c: clean up all checkpatch errors

2015-02-07 Thread Varka Bhadram
++ 1 file changed, 31 insertions(+), 21 deletions(-) -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH 1/2] drivers: isdn: icn: icn.c: clean up all checkpatch errors

2015-02-07 Thread Varka Bhadram
++ 1 file changed, 31 insertions(+), 21 deletions(-) -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/2] drivers: isdn: icn: icn.h Clean up trivial checkpatch errors.

2015-02-07 Thread Varka Bhadram
Hi, On Saturday 07 February 2015 09:26 PM, Bas Peters wrote: Missed Signed-off-by line... --- drivers/isdn/icn/icn.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
On Thursday 29 January 2015 08:56 PM, Varka Bhadram wrote: Hi, On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Originally-by: Lanqing Liu Signed-off

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
= devm_ioremap_resource(>dev, res); + if (IS_ERR(up->membase)) + return PTR_ERR(up->membase); + -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Varka Bhadram
ed-off-by: Javier Martinez Canillas > --- > > Changes since v3: > - Rename MYNAME to DRV_NAME > - Use devm_request_region() instead of request_region. >Suggested by Varka Bhadram. > - Remove release_region from cleanup handle logic by using devres API. >Sugge

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
() + up-mapbase = res-start; + up-membase = devm_ioremap_resource(pdev-dev, res); + if (IS_ERR(up-membase)) + return PTR_ERR(up-membase); + -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
On Thursday 29 January 2015 08:56 PM, Varka Bhadram wrote: Hi, On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Originally-by: Lanqing Liu lanqing

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Varka Bhadram
Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v3: - Rename MYNAME to DRV_NAME - Use devm_request_region() instead of request_region. Suggested by Varka Bhadram. - Remove release_region from cleanup handle logic by using devres API. Suggested by Varka Bhadram

Re: [PATCH] gpio: mmp: add GPIO driver for Marvell MMP series

2015-01-27 Thread Varka Bhadram
} > + ret = clk_prepare_enable(clk); > + if (ret) { > + dev_err(dev, "Fail to enable gpio clock, error %d.\n", ret); > + return ret; > + } > + > + domain = irq_domain_add_linear(np, mmp_chip->ngpio, > +

Re: [PATCH] gpio: mmp: add GPIO driver for Marvell MMP series

2015-01-27 Thread Varka Bhadram
, + mmp_gpio_irq_domain_ops, mmp_chip); + if (domain == NULL) Using ! operator preferred instead of comparing with NULL. -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH bluetooth-next] ieee802154: cc2520: Fix space before , coding style issue

2015-01-26 Thread Varka Bhadram
Hi Jamal, On Friday 23 January 2015 07:25 PM, Mohammad Jamal wrote: This patch removes the warnings (space before , ) shown by checkpatch.pl Thanks for the patch. Acked-by: Varka Bhadram Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |4 ++-- 1 file changed, 2

Re: [PATCH bluetooth-next] ieee802154: cc2520: Replace shift operations by BIT macro

2015-01-26 Thread Varka Bhadram
Hi Jamal, On Friday 23 January 2015 07:28 PM, Mohammad Jamal wrote: This patch replaces the shifting operations by BIT macro Thanks for the patch. Acked-by: Varka Bhadram Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions

Re: [PATCH bluetooth-next] ieee802154: cc2520: Replace shift operations by BIT macro

2015-01-26 Thread Varka Bhadram
Hi Jamal, On Friday 23 January 2015 07:28 PM, Mohammad Jamal wrote: This patch replaces the shifting operations by BIT macro Thanks for the patch. Acked-by: Varka Bhadram varkabhad...@gmail.com Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/net/ieee802154/cc2520.c

Re: [PATCH bluetooth-next] ieee802154: cc2520: Fix space before , coding style issue

2015-01-26 Thread Varka Bhadram
Hi Jamal, On Friday 23 January 2015 07:25 PM, Mohammad Jamal wrote: This patch removes the warnings (space before , ) shown by checkpatch.pl Thanks for the patch. Acked-by: Varka Bhadram varkabhad...@gmail.com Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/net

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Varka Bhadram
5 > Please work on bluetooth-next[1] tree and also include 'bluetooth-next' tag for the patch. [1]: http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/ -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Varka Bhadram
goto err_hw_init; > > - > gpio_set_value(pdata->vreg, HIGH); > usleep_range(100, 150); > > -- > 1.7.9.5 > -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Varka Bhadram
, 150); -- 1.7.9.5 -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Varka Bhadram
for the patch. [1]: http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/ -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Varka Bhadram
map: > + return err; > +} > + > +static int cros_ec_lpc_remove(struct platform_device *pdev) > +{ > + struct cros_ec_device *ec_dev; > + > + ec_dev = platform_get_drvdata(pdev); > + cros_ec_remove(ec_dev); > + > + release_region(EC_HO

Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Varka Bhadram
, EC_HOST_CMD_REGION_SIZE); + release_region(EC_LPC_ADDR_MEMMAP, EC_MEMMAP_SIZE); + These also will be gone -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v6 5/7] power: Add support for DA9150 Charger

2015-01-21 Thread Varka Bhadram
ger = devm_kzalloc(dev, sizeof(struct da9150_charger), GFP_KERNEL); + if (charger == NULL) + return -ENOMEM; sizeof(struct da9150_charger) can be replaced with sizeof(*charger)... *!* operator can be used in comparison with NULL... (...) -- Thanks and Regards, Varka Bhadr

Re: [PATCH v6 3/7] iio: Add support for DA9150 GPADC

2015-01-21 Thread Varka Bhadram
tead of *>dev* -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v6 5/7] power: Add support for DA9150 Charger

2015-01-21 Thread Varka Bhadram
= devm_kzalloc(dev, sizeof(struct da9150_charger), GFP_KERNEL); + if (charger == NULL) + return -ENOMEM; sizeof(struct da9150_charger) can be replaced with sizeof(*charger)... *!* operator can be used in comparison with NULL... (...) -- Thanks and Regards, Varka Bhadram

Re: [PATCH v6 3/7] iio: Add support for DA9150 GPADC

2015-01-21 Thread Varka Bhadram
-dev, sizeof(*gpadc)); You can directly use *dev* instead of *pdev-dev* -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Varka Bhadram
ilink", > + .owner = THIS_MODULE, No need to update this field. It will be updated by driver core. > + .of_match_table = of_match_ptr(btwilink_of_match), > }, > }; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the

Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Varka Bhadram
-info.html -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv5 3/9] devfreq: event: Add exynos-ppmu devfreq-event driver

2014-12-22 Thread Varka Bhadram
platform_driver exynos_ppmu_driver = { > + .probe = exynos_ppmu_probe, > + .remove = exynos_ppmu_remove, > + .driver = { > + .name = "exynos-ppmu", > + .owner = THIS_MODULE, remove owner field. It will be populate by driver core. > +

Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default() in probe

2014-12-22 Thread Varka Bhadram
Thanks for the patch. Acked-by: Varka Bhadram On Tue, Dec 23, 2014 at 5:40 AM, Varka Bhadram wrote: > > Thanks for the patch. > > Acked-by: Varka Bhadram > > On Tue, Dec 23, 2014 at 3:46 AM, Wolfram Sang wrote: >> >> Since commit ab78029ecc34 (drivers/pinc

Re: [PATCHv5 3/9] devfreq: event: Add exynos-ppmu devfreq-event driver

2014-12-22 Thread Varka Bhadram
the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default() in probe

2014-12-22 Thread Varka Bhadram
Thanks for the patch. Acked-by: Varka Bhadram varkabhad...@gmail.com On Tue, Dec 23, 2014 at 5:40 AM, Varka Bhadram varkabhad...@gmail.com wrote: Thanks for the patch. Acked-by: Varka Bhadram varkabhad...@gmail.com On Tue, Dec 23, 2014 at 3:46 AM, Wolfram Sang w...@the-dreams.de wrote

Re: [PATCH v5 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-12-13 Thread Varka Bhadram
I2C_FUNC_I2C; +} + +static const struct i2c_algorithm i2c_cyusbs23x_algorithm = { + .master_xfer= cy_i2c_xfer, + .functionality = cy_i2c_func, +}; + +static int cyusbs23x_i2c_probe(struct platform_device *pdev) +{ + struct cyusbs23x *cyusbs; + struct cyusbs_i2c *cy_i2c; + int ret = 0; + +

Re: [PATCH v5 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-12-13 Thread Varka Bhadram
+ cy_gpio->gpio.base = -1; + cy_gpio->gpio.ngpio = CYUSBS234_GPIO_NUM; + cy_gpio->gpio.can_sleep = true; + cy_gpio->gpio.request = cy_gpio_request; + cy_gpio->gpio.set = cy_gpio_set; + cy_gpio->gpio.get = cy_gpio_get; + cy_gpio->gpio.get_directi

Re: [PATCH v5 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-12-13 Thread Varka Bhadram
= cy_gpio_get; + cy_gpio-gpio.get_direction = cy_gpio_get_direction; One line space... -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v5 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-12-13 Thread Varka Bhadram
cyusbs_i2c_config), + GFP_KERNEL); + if (cy_i2c-i2c_config == NULL) + return -ENOMEM; + dto... -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/4] i2c: iproc: Add Broadcom iProc I2C Driver

2014-12-09 Thread Varka Bhadram
gt;device, "device registered successfully\n"); + + return 0; +} + +static int bcm_iproc_i2c_remove(struct platform_device *pdev) +{ + struct bcm_iproc_i2c_dev *dev = platform_get_drvdata(pdev); + + i2c_del_adapter(>adapter); + bcm_iproc_i2c_disable(dev); + + return 0; +} + +static const s

Re: [PATCH 1/4] i2c: iProc: define Broadcom iProc I2C binding

2014-12-09 Thread Varka Bhadram
ith single line statement, like: compatible: Must be "brcm,iproc-i2c" reg:Define the base and range of the I/O address space that contain the iProc I2C controller registers -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send t

Re: [PATCH 1/4] i2c: iProc: define Broadcom iProc I2C binding

2014-12-09 Thread Varka Bhadram
of statements. Why cant they be with single line statement, like: compatible: Must be brcm,iproc-i2c reg:Define the base and range of the I/O address space that contain the iProc I2C controller registers -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH 2/4] i2c: iproc: Add Broadcom iProc I2C Driver

2014-12-09 Thread Varka Bhadram
, + }, + .probe = bcm_iproc_i2c_probe, + .remove = bcm_iproc_i2c_remove, +}; +module_platform_driver(bcm_iproc_i2c_driver); + +MODULE_AUTHOR(Ray Jui r...@broadcom.com); +MODULE_DESCRIPTION(Broadcom iProc I2C Driver); +MODULE_LICENSE(GPL v2); -- Thanks and Regards, Varka Bhadram

Re: [PATCH] mtd: remove .owner field for driver using module_platform_driver

2014-11-11 Thread Varka Bhadram
/remove_owner -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] mtd: remove .owner field for driver using module_platform_driver

2014-11-11 Thread Varka Bhadram
/kernel/git/wsa/linux.git/log/?h=platform/remove_owner -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-27 Thread Varka Bhadram
+ +#ifdef CONFIG_OF +static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( + struct device *dev) +{ + struct device_node *np = of_node_get(dev->of_node); + struct sky81452_bl_platform_data *pdata; + int ret; +

Re: [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-27 Thread Varka Bhadram
sky81452_bl_platform_data *pdata; + int ret; + + if (!np) { + dev_err(dev, backlight node not found); Missed terminating new line all over the driver for debug error messages.. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-21 Thread Varka Bhadram
On 10/21/2014 11:46 AM, Ankit Jindal wrote: On 21 October 2014 11:34, Varka Bhadram wrote: On 10/21/2014 11:26 AM, Ankit Jindal wrote: The Applied Micro X-Gene SOC has on-chip QMTM (Queue manager and Traffic manager) which is hardware based Queue or Ring manager. This QMTM device can be used

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-21 Thread Varka Bhadram
et = qmtm_reset(qmtm_dev); + if (ret < 0) { + dev_err(>dev, "Failed to reset QMTM\n"); + goto out_clk; + } + + /* register with uio framework */ + ret = uio_register_device(>dev, info); + if (ret < 0) + goto out_clk; + + p

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-21 Thread Varka Bhadram
; + + platform_set_drvdata(pdev, qmtm_dev); + return 0; + +out_clk: + clk_disable_unprepare(qmtm_dev-qmtm_clk); + +out_err: + return ret; +} -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-21 Thread Varka Bhadram
On 10/21/2014 11:46 AM, Ankit Jindal wrote: On 21 October 2014 11:34, Varka Bhadram varkabhad...@gmail.com wrote: On 10/21/2014 11:26 AM, Ankit Jindal wrote: The Applied Micro X-Gene SOC has on-chip QMTM (Queue manager and Traffic manager) which is hardware based Queue or Ring manager

Re: [PATCH v6 1/2] mtd: nand: add sunxi NAND flash controller support

2014-10-20 Thread Varka Bhadram
emove, +}; +module_platform_driver(sunxi_nfc_driver); + +MODULE_LICENSE("GPL v2"); +MODULE_AUTHOR("Boris BREZILLON"); +MODULE_DESCRIPTION("Allwinner NAND Flash Controller driver"); +MODULE_ALIAS("platform:sunxi_nand"); -- Regards, Varka Bhadram. -- To unsubscribe from t

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Varka Bhadram
pmu_lock); + spin_lock_init(>dev_lock); + + pm_genpd_init(>base, NULL, false); + + return of_genpd_add_provider_simple(pdev->dev.of_node, >base); +} + -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Varka Bhadram
); + spin_lock_init(pd-dev_lock); + + pm_genpd_init(pd-base, NULL, false); + + return of_genpd_add_provider_simple(pdev-dev.of_node, pd-base); +} + -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v6 1/2] mtd: nand: add sunxi NAND flash controller support

2014-10-20 Thread Varka Bhadram
); +MODULE_DESCRIPTION(Allwinner NAND Flash Controller driver); +MODULE_ALIAS(platform:sunxi_nand); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCHv3 3/3] gpio: sch: Enable IRQ support for Quark X1000

2014-10-15 Thread Varka Bhadram
e() return 'void' [0]. + dev_err(>dev, + "%s gpiochip_remove() failed\n", __func__); + +err_sch_gpio: + release_region(res->start, resource_size(res)); + + return err; } [0]:https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/

Re: [PATCHv3 3/3] gpio: sch: Enable IRQ support for Quark X1000

2014-10-15 Thread Varka Bhadram
); + +err_sch_gpio: + release_region(res-start, resource_size(res)); + + return err; } [0]:https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/tree/drivers/gpio/gpiolib.c#n311 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM

2014-10-04 Thread Varka Bhadram
"Bosch M_CAN devices" + depends on HAS_IOMEM ---help--- Say Y here if you want to support for Bosch M_CAN controller. -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM

2014-10-04 Thread Varka Bhadram
Bosch M_CAN devices + depends on HAS_IOMEM ---help--- Say Y here if you want to support for Bosch M_CAN controller. -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v2 4/6] drivers: uio: Add X-Gene QMTM UIO driver

2014-09-30 Thread Varka Bhadram
v = platform_get_drvdata(pdev); + + qmtm_cleanup(pdev, qmtm_dev); + return 0; +} + +static struct of_device_id qmtm_match[] = { + {.compatible = "apm,xgene-qmtm",}, + {}, +}; + +MODULE_DEVICE_TABLE(of, qmtm_match); + +static struct platform_driver qmtm_driver = { + .

Re: [PATCH v2 4/6] drivers: uio: Add X-Gene QMTM UIO driver

2014-09-30 Thread Varka Bhadram
, + }, + .probe = qmtm_probe, + .remove = qmtm_remove, +}; + +module_platform_driver(qmtm_driver); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
On 09/29/2014 04:43 PM, Anders Berg wrote: On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram wrote: On 09/29/2014 03:02 PM, Anders Berg wrote: Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The driver implements 10-bit addressing and SMBus transfer modes via emulation

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
Yes it will [1]. Thanks for the clarification. [1]:http://lxr.free-electrons.com/source/lib/devres.c#L117 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
idev->adapter.dev.parent = >dev; + idev->adapter.dev.of_node = pdev->dev.of_node; + + platform_set_drvdata(pdev, idev); + + ret = i2c_add_adapter(>adapter); + if (ret) { + dev_err(>dev, "failed to add adapter\n"); + retu

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
it will [1]. Thanks for the clarification. [1]:http://lxr.free-electrons.com/source/lib/devres.c#L117 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
On 09/29/2014 04:43 PM, Anders Berg wrote: On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram varkabhad...@gmail.com wrote: On 09/29/2014 03:02 PM, Anders Berg wrote: Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The driver implements 10-bit addressing and SMBus

Re: [PATCH v5] spi: spi-imx: add DMA support

2014-09-09 Thread Varka Bhadram
h = DMA_SLAVE_BUSWIDTH_1_BYTE; + slave_config.dst_maxburst = spi_imx_get_fifosize(spi_imx) / 2; + ret = dmaengine_slave_config(master->dma_tx, _config); + if (ret) { + dev_err(dev, "error in TX dma configuration."); + Missed termina

Re: [PATCH v5] spi: spi-imx: add DMA support

2014-09-09 Thread Varka Bhadram
; + slave_config.dst_maxburst = spi_imx_get_fifosize(spi_imx) / 2; + ret = dmaengine_slave_config(master-dma_tx, slave_config); + if (ret) { + dev_err(dev, error in TX dma configuration.); + Missed terminating new line.. -- Regards, Varka Bhadram

[PATCH net-next] ethernet: ti: remove unwanted THIS_MODULE macro

2014-09-07 Thread Varka Bhadram
It removes the owner field updation of driver structure. It will be automatically updated by module_platform_driver() Signed-off-by: Varka Bhadram --- drivers/net/ethernet/ti/cpmac.c|1 - drivers/net/ethernet/ti/cpsw-phy-sel.c |1 - drivers/net/ethernet/ti/cpsw.c |1

[PATCH net-next] ethernet: ti: remove unwanted THIS_MODULE macro

2014-09-07 Thread Varka Bhadram
It removes the owner field updation of driver structure. It will be automatically updated by module_platform_driver() Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/net/ethernet/ti/cpmac.c|1 - drivers/net/ethernet/ti/cpsw-phy-sel.c |1 - drivers/net/ethernet/ti/cpsw.c

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram wrote: + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: +

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
name)... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
name)... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram varkabhad...@gmail.com wrote: + switch (((np == bitclkmaster) 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10

Re: [PATCH v2 1/7] mfd: Add support for DA9150 combined charger & fuel-gauge device

2014-08-28 Thread Varka Bhadram
e_i2c_driver(da9150_driver); + +MODULE_DESCRIPTION("I2C Driver for DA9150"); +MODULE_AUTHOR("Adam Thomson -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH v2 1/7] mfd: Add support for DA9150 combined charger fuel-gauge device

2014-08-28 Thread Varka Bhadram
for DA9150); +MODULE_AUTHOR(Adam Thomson adam.thomson.opensou...@diasemi.com); +MODULE_LICENSE(GPL); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

  1   2   3   4   >