Re: [RFC PATCH 5/7] sched/fair: Enable CFS periodic tick to update thermal pressure

2018-12-04 Thread Vincent Guittot
Hi Thara, On Tue, 9 Oct 2018 at 18:25, Thara Gopinath wrote: > > Introduce support in CFS periodic tick to trigger the process of > computing average thermal pressure for a cpu. > > Signed-off-by: Thara Gopinath > --- > kernel/sched/fair.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Vincent Guittot
On Thu, 29 Nov 2018 at 16:00, Patrick Bellasi wrote: > > On 29-Nov 11:43, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi > > wrote: > > > On 28-Nov 16:42, Vincent Guittot wrote: > > > > On Wed, 28 Nov 2018 at 16:21, Patrick Bella

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi wrote: > > On 28-Nov 16:42, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 15:55, Vincent Guittot wrote: > > > > On Wed, 28 No

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi wrote: > > On 28-Nov 15:55, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 14:33, Vincent Guittot wrote: > > > > On Wed, 28 No

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi wrote: > > On 28-Nov 14:33, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > > On Wed, Nov 28,

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 14:33, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > &

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > On 28-Nov 11:02, Peter Zijlstra wrote: > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > Is there anything else that I should do for these patches ? > > > > IIRC, Mort

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
Hi, On Tue, 20 Nov 2018 at 11:55, Vincent Guittot wrote: > > The current implementation of load tracking invariance scales the > contribution with current frequency and uarch performance (only for > utilization) of the CPU. One main result of this formula is that the > fig

Re: [PATCH] sched/fair: Clean up comment in nohz_idle_balance()

2018-11-27 Thread Vincent Guittot
with misleading/out-of-date comments. > > [1] > http://lkml.kernel.org/r/cakftptbja-ocbrko6__npqwl3+hljzk7riccpu1r7ydo-ep...@mail.gmail.com > > Suggested-by: Vincent Guittot > Signed-off-by: Andrea Parri > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Vincent Guittot Loo

Re: [Question] atomic_fetch_andnot() in nohz_idle_balance()

2018-11-27 Thread Vincent Guittot
On Mon, 26 Nov 2018 at 21:44, Andrea Parri wrote: > > On Mon, Nov 26, 2018 at 12:37:00PM +0100, Vincent Guittot wrote: > > On Mon, 26 Nov 2018 at 10:30, Peter Zijlstra wrote: > > > > > > On Wed, Nov 21, 2018 at 11:34:53PM +0100, Andrea Parri wrote: > >

Re: [Question] atomic_fetch_andnot() in nohz_idle_balance()

2018-11-26 Thread Vincent Guittot
On Mon, 26 Nov 2018 at 10:30, Peter Zijlstra wrote: > > On Wed, Nov 21, 2018 at 11:34:53PM +0100, Andrea Parri wrote: > > Hi, > > > > The comment for the atomic_fetch_andnot() in nohz_idle_balance() says: > > > > "barrier, pairs with nohz_balance_enter_idle(), ensures ..." > > > > which, well,

[PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-20 Thread Vincent Guittot
26ms On my hikey (octo Arm64 platform) with schedutil governor, the time to reach max OPP when starting from a null utilization, decreases from 223ms with current scale invariance down to 121ms with the new algorithm. Signed-off-by: Vincent Guittot --- include/linux/sched.h | 23

[PATCH v7 1/2] sched/fair: move rq_of helper function

2018-11-20 Thread Vincent Guittot
Move rq_of() helper function so it can be used in pelt.c Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 13 - kernel/sched/sched.h | 16 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

[PATCH v7 0/2] sched/fair: update scale invariance of PELT

2018-11-20 Thread Vincent Guittot
scaling algorithm Changes since v5: - Fix niptick raised by Dietmar - Upodated some comments - Remove some unused variables - No functional change Vincent Guittot (2): sched/fair: move rq_of helper function sched/fair: update scale invariance of PELT include/linux/sched.h | 23

Re: [PATCH v6 2/2] sched/fair: update scale invariance of PELT

2018-11-14 Thread Vincent Guittot
On Mon, 12 Nov 2018 at 18:53, Dietmar Eggemann wrote: > > On 11/9/18 8:20 AM, Vincent Guittot wrote: > > [...] > > > In order to achieve this time scaling, a new clock_pelt is created per rq. > > The increase of this clock scales with current capacity when som

[PATCH v6 2/2] sched/fair: update scale invariance of PELT

2018-11-09 Thread Vincent Guittot
26ms On my hikey (octo Arm64 platform) with schedutil governor, the time to reach max OPP when starting from a null utilization, decreases from 223ms with current scale invariance down to 121ms with the new algorithm. Signed-off-by: Vincent Guittot --- kernel/sched/core.c | 1 + kernel/sc

[PATCH v6 1/2] sched/fair: move rq_of helper function

2018-11-09 Thread Vincent Guittot
Move rq_of() helper function so it can be used in pelt.c Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 13 - kernel/sched/sched.h | 16 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

[PATCH v6 0/2] sched/fair: update scale invariance of PELT

2018-11-09 Thread Vincent Guittot
scaling algorithm Changes since v5: - Fix running_sum scaling in update_tg_cfs_runnable() raised by Dietmar - Remove unused cpu parameters raised by Dietmar Vincent Guittot (2): sched/fair: move rq_of helper function sched/fair: update scale invariance of PELT kernel/sched/core.c | 1

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-11-08 Thread Vincent Guittot
On Thu, 8 Nov 2018 at 12:35, Quentin Perret wrote: > > On Wednesday 07 Nov 2018 at 11:47:09 (+0100), Dietmar Eggemann wrote: > > The important bit for EAS is that it only uses utilization in the > > non-overutilized case. Here, utilization signals should look the same > > between the two

Re: [PATCH v8 03/15] PM: Introduce an Energy Model management framework

2018-11-07 Thread Vincent Guittot
On Wed, 7 Nov 2018 at 18:02, Quentin Perret wrote: > > Hi Vincent, > > On Wednesday 07 Nov 2018 at 17:32:32 (+0100), Vincent Guittot wrote: > > Hi Quentin, > > > > On Tue, 16 Oct 2018 at 12:15, Quentin Perret wrote: > > > > > > > > + >

Re: [PATCH v8 03/15] PM: Introduce an Energy Model management framework

2018-11-07 Thread Vincent Guittot
Hi Quentin, On Tue, 16 Oct 2018 at 12:15, Quentin Perret wrote: > > + > +/** > + * em_pd_energy() - Estimates the energy consumed by the CPUs of a perf. > domain > + * @pd : performance domain for which energy has to be estimated > + * @max_util : highest utilization among CPUs of

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-11-07 Thread Vincent Guittot
On Wed, 7 Nov 2018 at 11:47, Dietmar Eggemann wrote: > > On 11/5/18 10:10 AM, Vincent Guittot wrote: > > On Fri, 2 Nov 2018 at 16:36, Dietmar Eggemann > > wrote: > >> > >> On 10/26/18 6:11 PM, Vincent Guittot wrote: > > [...] > > >> Thi

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-11-06 Thread Vincent Guittot
On Mon, 5 Nov 2018 at 15:59, Morten Rasmussen wrote: > > On Mon, Nov 05, 2018 at 10:10:34AM +0100, Vincent Guittot wrote: > > On Fri, 2 Nov 2018 at 16:36, Dietmar Eggemann > > wrote: > > > ... > > > > > > > > In order to achieve this time s

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-11-05 Thread Vincent Guittot
On Fri, 2 Nov 2018 at 16:36, Dietmar Eggemann wrote: > > On 10/26/18 6:11 PM, Vincent Guittot wrote: > > The current implementation of load tracking invariance scales the > > contribution with current frequency and uarch performance (only for > > utilization) of

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-11-05 Thread Vincent Guittot
On Thu, 1 Nov 2018 at 10:38, Dietmar Eggemann wrote: > > On 10/31/18 10:18 AM, Vincent Guittot wrote: > > Hi Dietmar, > > > > On Wed, 31 Oct 2018 at 08:20, Dietmar Eggemann > > wrote: > >> > >> On 10/26/18 6:11 PM, Vincent Guittot

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-10-31 Thread Vincent Guittot
Hi Dietmar, On Wed, 31 Oct 2018 at 08:20, Dietmar Eggemann wrote: > > On 10/26/18 6:11 PM, Vincent Guittot wrote: > > [...] > > > static int select_idle_sibling(struct task_struct *p, int prev_cpu, int > > cpu); > > static unsigned long task_h_load(stru

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-10-30 Thread Vincent Guittot
Hi Pavan, On Tue, 30 Oct 2018 at 10:19, Pavan Kondeti wrote: > > Hi Vincent, > > On Fri, Oct 26, 2018 at 06:11:43PM +0200, Vincent Guittot wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 6806c27..7a69673 100644 > > --- a/kernel/sched

[PATCH v5 1/2] sched/fair: move rq_of helper function

2018-10-26 Thread Vincent Guittot
Move rq_of() helper function so it can be used in pelt.c Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 13 - kernel/sched/sched.h | 16 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

[PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-10-26 Thread Vincent Guittot
26ms On my hikey (octo ARM platform) with schedutil governor, the time to reach max OPP when starting from a null utilization, decreases from 223ms with current scale invariance down to 121ms with the new algorithm. Signed-off-by: Vincent Guittot --- kernel/sched/core.c | 1 + kernel/sc

[PATCH v5 0/2] sched/fair: update scale invariance of PELT

2018-10-26 Thread Vincent Guittot
algorithm Changes since v4: - Fix compile issue for !SMP raised by kbuild test robot - Fix lost_idle_time update raised by Pavan Vincent Guittot (2): sched/fair: move rq_of helper function sched/fair: update scale invariance of PELT kernel/sched/core.c | 1 + kernel/sched/deadline.c

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Vincent Guittot
On Thu, 25 Oct 2018 at 13:29, Steven Sistare wrote: > > On 10/25/2018 3:50 AM, Vincent Guittot wrote: > > Hi Steve, > > > > On Mon, 22 Oct 2018 at 17:10, Steve Sistare > > wrote: > >> > >> When a CPU has no more CFS tasks to run, and idle_b

Re: [PATCH v4 2/2] sched/fair: update scale invariance of PELT

2018-10-25 Thread Vincent Guittot
On Thu, 25 Oct 2018 at 12:36, Dietmar Eggemann wrote: > > Hi Vincent, > > On 10/19/18 6:17 PM, Vincent Guittot wrote: > > The current implementation of load tracking invariance scales the > > contribution with current frequency and uarch performance (only for > > uti

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Vincent Guittot
Hi Steve, On Mon, 22 Oct 2018 at 17:10, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify

Re: [PATCH v4 2/2] sched/fair: update scale invariance of PELT

2018-10-24 Thread Vincent Guittot
Hi Pavan, On Wed, 24 Oct 2018 at 06:53, Pavan Kondeti wrote: > > Hi Vincent, > > Thanks for the detailed explanation. > > On Tue, Oct 23, 2018 at 02:15:08PM +0200, Vincent Guittot wrote: > > Hi Pavan, > > > > On Tue, 23 Oct 2018 at 07:59, Pavan Ko

Re: [PATCH v4 2/2] sched/fair: update scale invariance of PELT

2018-10-23 Thread Vincent Guittot
Hi Pavan, On Tue, 23 Oct 2018 at 07:59, Pavan Kondeti wrote: > > Hi Vincent, > > On Fri, Oct 19, 2018 at 06:17:51PM +0200, Vincent Guittot wrote: > > > > /* > > + * The clock_pelt scales the time to reflect the effective amount of > > + * computatio

Re: [PATCH v4 2/2] sched/fair: update scale invariance of PELT

2018-10-23 Thread Vincent Guittot
On Tue, 23 Oct 2018 at 12:01, Peter Zijlstra wrote: > > On Fri, Oct 19, 2018 at 06:17:51PM +0200, Vincent Guittot wrote: > > In order to achieve this time scaling, a new clock_pelt is created per rq. > > > > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h &g

[PATCH v4 2/2] sched/fair: update scale invariance of PELT

2018-10-19 Thread Vincent Guittot
ax OPP when starting from a null utilization, decreases from 223ms with current scale invariance down to 121ms with the new algorithm. For this test, I have enable arch_scale_freq for arm64. Signed-off-by: Vincent Guittot --- kernel/sched/core.c | 2 +- kernel/sched/deadline.c | 6 ++

[PATCH 1/2] sched/fair: move rq_of helper function

2018-10-19 Thread Vincent Guittot
Move rq_of() helper function so it can be used in pelt.c Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 13 - kernel/sched/sched.h | 16 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

[PATCH v4 0/2] sched/fair: update scale invariance of PELT

2018-10-19 Thread Vincent Guittot
scaling algorithm Vincent Guittot (2): sched/fair: move rq_of helper function sched/fair: update scale invariance of PELT kernel/sched/core.c | 2 +- kernel/sched/deadline.c | 6 ++-- kernel/sched/fair.c | 29 +--- kernel/sched/pelt.c | 88

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-16 Thread Vincent Guittot
Hi Lukasz, On Thu, 11 Oct 2018 at 13:10, Lukasz Luba wrote: > > > > On 10/10/2018 07:30 PM, Thara Gopinath wrote: > > Hello Lukasz, > > > > On 10/10/2018 11:35 AM, Lukasz Luba wrote: > >> Hi Thara, > >> > >> I have run it on Exynos5433 mainline. > >> When it is enabled with step_wise thermal

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
On Wed, 10 Oct 2018 at 15:48, Quentin Perret wrote: > > On Wednesday 10 Oct 2018 at 15:27:57 (+0200), Vincent Guittot wrote: > > On Wed, 10 Oct 2018 at 15:05, Quentin Perret wrote: > > > > > > On Wednesday 10 Oct 2018 at 14:04:40 (+0200), Vincent Guittot wrote:

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
On Wed, 10 Oct 2018 at 15:35, Juri Lelli wrote: > > On 10/10/18 15:08, Vincent Guittot wrote: > > On Wed, 10 Oct 2018 at 14:50, Juri Lelli wrote: > > > > > > On 10/10/18 14:34, Vincent Guittot wrote: > > > > Hi Juri, > > > > &

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
On Wed, 10 Oct 2018 at 15:05, Quentin Perret wrote: > > On Wednesday 10 Oct 2018 at 14:04:40 (+0200), Vincent Guittot wrote: > > This patchset doesn't touch cpu_capacity_orig and doesn't need to as > > it assume that the max capacity is unchanged but some capacity is &g

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
On Wed, 10 Oct 2018 at 14:50, Juri Lelli wrote: > > On 10/10/18 14:34, Vincent Guittot wrote: > > Hi Juri, > > > > On Wed, 10 Oct 2018 at 14:23, Juri Lelli wrote: > > > > > > On 10/10/18 14:04, Vincent Guittot wrote: > > > > > > [

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
Hi Juri, On Wed, 10 Oct 2018 at 14:23, Juri Lelli wrote: > > On 10/10/18 14:04, Vincent Guittot wrote: > > [...] > > > The problem was the same with RT, the cfs utilization was lower than > > reality because RT steals soem cycle to CFS > > So schedutil was sel

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
On Wed, 10 Oct 2018 at 12:36, Quentin Perret wrote: > > On Wednesday 10 Oct 2018 at 12:14:32 (+0200), Vincent Guittot wrote: > > On Wed, 10 Oct 2018 at 11:55, Quentin Perret wrote: > > > > > > Hi Vincent, > > > > > > On Wednesday 10 Oct

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
On Wed, 10 Oct 2018 at 11:55, Quentin Perret wrote: > > Hi Vincent, > > On Wednesday 10 Oct 2018 at 10:50:05 (+0200), Vincent Guittot wrote: > > The problem with reflecting directly the capping is that it happens > > far more often than the pace at which cpu_

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-10 Thread Vincent Guittot
On Wed, 10 Oct 2018 at 10:29, Quentin Perret wrote: > > Hi Thara, > > On Wednesday 10 Oct 2018 at 08:17:51 (+0200), Ingo Molnar wrote: > > > > * Thara Gopinath wrote: > > > > > Thermal governors can respond to an overheat event for a cpu by > > > capping the cpu's maximum possible frequency.

[tip:sched/core] sched/pelt: Fix warning and clean up IRQ PELT config

2018-10-02 Thread tip-bot for Vincent Guittot
Commit-ID: 11d4afd4ff667f9b6178ee8c142c36cb78bd84db Gitweb: https://git.kernel.org/tip/11d4afd4ff667f9b6178ee8c142c36cb78bd84db Author: Vincent Guittot AuthorDate: Tue, 25 Sep 2018 11:17:42 +0200 Committer: Ingo Molnar CommitDate: Tue, 2 Oct 2018 09:45:00 +0200 sched/pelt: Fix warning

[PATCH v2] sched/schedutil : optimize computation of utilization in schedutil

2018-10-02 Thread Vincent Guittot
Scaling the utilization of CPUs with irq util_avg in schedutil doesn't give any benefit and just waste CPU cycles when irq time is not accounted but only steal time. Skip the irq scaling when irq time is not accounted Suggested-by: Wanpeng Li Signed-off-by: Vincent Guittot --- kernel/sched

[RESEND PATCH 3/3] sched/fair: fix unnecessary increase of balance interval

2018-10-02 Thread Vincent Guittot
for asym_packing can be easily delayed for hundreds of ms because of this all_pinned detection mecanism. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c

[RESEND PATCH 0/3] sched/fair: some fixes for asym_packing

2018-10-02 Thread Vincent Guittot
patches fixes the problems raised for lmbench and the rt-app UC that creates 2 tasks that start as small tasks and then become suddenly always running tasks. (I can provide the rt-app json is needed) - Rebase on latest tip/sched/core Vincent Guittot (3): sched/fair: fix rounding issue for asym

[RESEND PATCH 1/3] sched/fair: fix rounding issue for asym packing

2018-10-02 Thread Vincent Guittot
. But this is enough to skip the rq in find_busiest_queue and prevents asym migration to happen. Add 1 to the avg_load to make sure that the targeted cpu will not be skipped unexpectidly. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/kernel

[RESEND PATCH 2/3] sched/fair: trigger asym_packing during idle load balance

2018-10-02 Thread Vincent Guittot
newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1

Re: [PATCH] sched/pelt: fix warning and cleanup irq pelt config

2018-10-02 Thread Vincent Guittot
On Tue, 25 Sep 2018 at 11:17, Vincent Guittot wrote: > > Create a config for enabling irq load tracking in the scheduler. > irq load tracking is useful only when irq or paravirtual time is > accounted but it's only possible with SMP for now. > > Also use __maybe_unused to remo

Re: [PATCH] sched/fair: Don't increase sd->balance_interval on newidle balance

2018-09-26 Thread Vincent Guittot
On Wed, 26 Sep 2018 at 15:17, Peter Zijlstra wrote: > > On Wed, Sep 26, 2018 at 12:33:25PM +0200, Vincent Guittot wrote: > > On Wed, 26 Sep 2018 at 11:35, Valentin Schneider > > > > library I use) has some phase where it spawns at lot of tasks at once to > >

Re: [PATCH] sched/fair: Don't increase sd->balance_interval on newidle balance

2018-09-26 Thread Vincent Guittot
On Wed, 26 Sep 2018 at 15:16, Valentin Schneider wrote: > > On 26/09/18 11:33, Vincent Guittot wrote: > > On Wed, 26 Sep 2018 at 11:35, Valentin Schneider > > [...] > >>> Can you give us details about the use case that you care about ? > >>> > &

Re: [PATCH] sched/fair: Don't increase sd->balance_interval on newidle balance

2018-09-26 Thread Vincent Guittot
On Wed, 26 Sep 2018 at 11:35, Valentin Schneider wrote: > > Hi, > > On 26/09/18 09:13, Vincent Guittot wrote: > > On Tue, 25 Sep 2018 at 19:38, Valentin Schneider > > wrote: > >> > >> When load_balance() fails to move some load because of t

Re: [PATCH] sched/fair: Don't increase sd->balance_interval on newidle balance

2018-09-26 Thread Vincent Guittot
On Tue, 25 Sep 2018 at 19:38, Valentin Schneider wrote: > > When load_balance() fails to move some load because of task affinity, > we end up increasing sd->balance_interval to delay the next periodic > balance in the hopes that next time we look, that annoying pinned > task(s) will be gone.

[PATCH] sched/pelt: fix warning and cleanup irq pelt config

2018-09-25 Thread Vincent Guittot
by: commit 2e62c4743adc ("sched/fair: Remove #ifdefs from scale_rt_capacity()") Reported-by: Dou Liyang Reported-by: Miguel Ojeda Suggested-by: Ingo Molnar Fixes: 2e62c4743adc ("sched/fair: Remove #ifdefs from scale_rt_capacity()") Signed-off-by: Vincent Guittot --- init

Re: [tip:sched/core] sched/fair: Remove #ifdefs from scale_rt_capacity()

2018-09-15 Thread Vincent Guittot
On Sat, 15 Sep 2018 at 14:30, Ingo Molnar wrote: > > > * Vincent Guittot wrote: > > > Hi Ingo, > > > > On Sat, 15 Sep 2018 at 13:47, Ingo Molnar wrote: > > > > > > > > > * tip-bot for Vincent Guittot wrote: > > > > >

Re: [tip:sched/core] sched/fair: Remove #ifdefs from scale_rt_capacity()

2018-09-15 Thread Vincent Guittot
Hi Ingo, On Sat, 15 Sep 2018 at 13:47, Ingo Molnar wrote: > > > * tip-bot for Vincent Guittot wrote: > > > Commit-ID: 2e62c4743adc4c7bfcbc1f45118fc7bec58cf30a > > Gitweb: > > https://git.kernel.org/tip/2e62c4743adc4c7bfcbc1f45118fc7bec58cf30a &

Re: [PATCH v2] sched/fair: fix 1 task per CPU

2018-09-14 Thread Vincent Guittot
On Fri, 14 Sep 2018 at 05:22, Valentin Schneider wrote: > > Hi, > > On 10/09/18 07:43, Vincent Guittot wrote: > > When CPUs have different capacity because of RT/DL tasks or > > micro-architecture or max frequency differences, there are situation where > > the

Re: [PATCH v7 02/14] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-09-12 Thread Vincent Guittot
Hi Quentin, On Wed, 12 Sep 2018 at 11:13, Quentin Perret wrote: > > Schedutil requests frequency by aggregating utilization signals from > the scheduler (CFS, RT, DL, IRQ) and applying and 25% margin on top of quite a minor thing but s/and 25%/a 25%/ > them. Since Energy Aware Scheduling (EAS)

[PATCH v2] sched/fair: fix 1 task per CPU

2018-09-10 Thread Vincent Guittot
gt;avg_load >= sds->avg_load) Add in fix_small_imbalance, this special case that triggered the force balance in order to make sure that the amount of load to migrate will be enough. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 14 ++ 1 file changed, 14 insertions(+) d

Re: [PATCH] sched/fair: fix 1 task per CPU

2018-09-10 Thread Vincent Guittot
On Sat, 8 Sep 2018 at 22:17, Valentin Schneider wrote: > > Hi Vincent, > > On 07/09/18 08:40, Vincent Guittot wrote: > > When CPUs have different capacity because of RT/DL tasks or > > micro-architecture or max frequency differences, there are situation where > >

Re: [PATCH 0/3] sched/fair: some fixes for asym_packing

2018-09-10 Thread Vincent Guittot
Hi, On Tue, 7 Aug 2018 at 17:56, Vincent Guittot wrote: > > During the review of misfit task patchset, Morten and Valentin raised some > problems with the use of SD_ASYM_PACKING flag on asymetric system like > hikey960 arm64 big/LITTLE platform. The study of the use cases has

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

2018-09-10 Thread Vincent Guittot
On Mon, 10 Sep 2018 at 12:32, Miguel Ojeda wrote: > > Hi Vincent, > > On Mon, Sep 10, 2018 at 9:00 AM, Vincent Guittot > wrote: > > On Sun, 9 Sep 2018 at 19:00, Miguel Ojeda > > wrote: > >> > >> On Sun, Sep 9, 2018 at 6:45 PM, Borislav Petkov wro

[tip:sched/core] sched/numa: Remove unused numa_stats::nr_running field

2018-09-10 Thread tip-bot for Vincent Guittot
Commit-ID: 7477a3504e619768c9e972dafe2907e6b8ed9823 Gitweb: https://git.kernel.org/tip/7477a3504e619768c9e972dafe2907e6b8ed9823 Author: Vincent Guittot AuthorDate: Wed, 29 Aug 2018 15:19:10 +0200 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:56 +0200 sched/numa: Remove

[tip:sched/core] sched/numa: Remove unused code from update_numa_stats()

2018-09-10 Thread tip-bot for Vincent Guittot
Commit-ID: d90707ebebe03596e19de3abbf79b766e72a3465 Gitweb: https://git.kernel.org/tip/d90707ebebe03596e19de3abbf79b766e72a3465 Author: Vincent Guittot AuthorDate: Wed, 29 Aug 2018 15:19:09 +0200 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:55 +0200 sched/numa: Remove

[tip:sched/core] sched/fair: Fix load_balance redo for !imbalance

2018-09-10 Thread tip-bot for Vincent Guittot
Commit-ID: bb3485c8ace6475c269b1aa2da674490f455f412 Gitweb: https://git.kernel.org/tip/bb3485c8ace6475c269b1aa2da674490f455f412 Author: Vincent Guittot AuthorDate: Fri, 7 Sep 2018 09:51:04 +0200 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 10:13:49 +0200 sched/fair: Fix

[tip:sched/core] sched/fair: Fix scale_rt_capacity() for SMT

2018-09-10 Thread tip-bot for Vincent Guittot
Commit-ID: 287cdaac5700c5b8970d739f73d742d863d3e2ca Gitweb: https://git.kernel.org/tip/287cdaac5700c5b8970d739f73d742d863d3e2ca Author: Vincent Guittot AuthorDate: Tue, 4 Sep 2018 11:36:26 +0200 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 10:13:47 +0200 sched/fair: Fix

[tip:sched/core] sched/pelt: Fix update_blocked_averages() for RT and DL classes

2018-09-10 Thread tip-bot for Vincent Guittot
Commit-ID: 12b04875d666e83d27511df25580de84505bc758 Gitweb: https://git.kernel.org/tip/12b04875d666e83d27511df25580de84505bc758 Author: Vincent Guittot AuthorDate: Fri, 31 Aug 2018 17:22:55 +0200 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 10:13:46 +0200 sched/pelt: Fix

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

2018-09-10 Thread Vincent Guittot
On Sun, 9 Sep 2018 at 19:00, Miguel Ojeda wrote: > > On Sun, Sep 9, 2018 at 6:45 PM, Borislav Petkov wrote: > > On Sun, Sep 09, 2018 at 06:36:01PM +0200, Miguel Ojeda wrote: > >> No, you get a different warning depending on whether you have enabled > >> CONFIG_PARAVIRT_TIME_ACCOUNTING or

[PATCH] sched/fair: fix 1 task per CPU

2018-09-07 Thread Vincent Guittot
gt;avg_load >= sds->avg_load) Add in fix_small_imbalance, this special case that triggered the force balance in order to make sure that the amount of load to migrate will be enough. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 14 ++ 1 file changed, 14 insertions(+) d

Re: [PATCH] sched/fair: fix load_balance redo for null imbalance

2018-09-07 Thread Vincent Guittot
On Fri, 7 Sep 2018 at 14:56, Peter Zijlstra wrote: > > On Fri, Sep 07, 2018 at 02:35:51PM +0200, Vincent Guittot wrote: > > Le Friday 07 Sep 2018 à 13:37:49 (+0200), Peter Zijlstra a écrit : > > > On Fri, Sep 07, 2018 at 09:51:04AM +0200, Vincent Guittot wrote:

Re: [PATCH] sched/fair: fix load_balance redo for null imbalance

2018-09-07 Thread Vincent Guittot
On Fri, 7 Sep 2018 at 14:35, Vincent Guittot wrote: > > Le Friday 07 Sep 2018 à 13:37:49 (+0200), Peter Zijlstra a écrit : > > On Fri, Sep 07, 2018 at 09:51:04AM +0200, Vincent Guittot wrote: > > > It can happen that load_balance finds a busiest group and the

Re: [PATCH] sched/fair: fix load_balance redo for null imbalance

2018-09-07 Thread Vincent Guittot
Le Friday 07 Sep 2018 à 13:37:49 (+0200), Peter Zijlstra a écrit : > On Fri, Sep 07, 2018 at 09:51:04AM +0200, Vincent Guittot wrote: > > It can happen that load_balance finds a busiest group and then a busiest rq > > but the calculated imbalance is in fact null. > > Cute. D

Re: [PATCH] sched/fair: vruntime should normalize when switching from fair

2018-09-07 Thread Vincent Guittot
On Fri, 7 Sep 2018 at 09:16, Juri Lelli wrote: > > On 06/09/18 16:25, Dietmar Eggemann wrote: > > Hi Juri, > > > > On 08/23/2018 11:54 PM, Juri Lelli wrote: > > > On 23/08/18 18:52, Dietmar Eggemann wrote: > > > > Hi, > > > > > > > > On 08/21/2018 01:54 AM, Miguel de Dios wrote: > > > > > On

[PATCH] sched/fair: fix load_balance redo for null imbalance

2018-09-07 Thread Vincent Guittot
. This situation can happen with heterogeneous system or smp system when RT tasks are decreasing the capacity of some CPUs. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 309c93f..224bfae

Re: [RFC PATCH 3/4] sched/topology: remove smt_gain

2018-09-06 Thread Vincent Guittot
On Wed, 5 Sep 2018 at 13:14, Srikar Dronamraju wrote: > > * Vincent Guittot [2018-09-05 11:11:35]: > > > On Wed, 5 Sep 2018 at 10:50, Srikar Dronamraju > > wrote: > > > > > > * Vincent Guittot [2018-09-05 09:36:42]: > > > > > >

Re: [RFC PATCH 3/4] sched/topology: remove smt_gain

2018-09-05 Thread Vincent Guittot
On Wed, 5 Sep 2018 at 10:50, Srikar Dronamraju wrote: > > * Vincent Guittot [2018-09-05 09:36:42]: > > > > > > > I dont know of any systems that have come with single threaded and > > > multithreaded. However some user can still offline few threads in a

Re: [RFC PATCH 3/4] sched/topology: remove smt_gain

2018-09-05 Thread Vincent Guittot
On Tue, 4 Sep 2018 at 12:37, Srikar Dronamraju wrote: > > * Vincent Guittot [2018-09-04 11:36:26]: > > > Hi Srikar, > > > > Le Tuesday 04 Sep 2018 à 01:24:24 (-0700), Srikar Dronamraju a écrit : > > > However after this change, capacity_orig of each SMT thr

Re: [RFC PATCH 3/4] sched/topology: remove smt_gain

2018-09-04 Thread Vincent Guittot
Hi Srikar, Le Tuesday 04 Sep 2018 à 01:24:24 (-0700), Srikar Dronamraju a écrit : > > Cc: Peter Zijlstra > > Cc: Ingo Molnar > > Cc: linux-kernel@vger.kernel.org (open list) > > Signed-off-by: Vincent Guittot > > diff --git a/kernel/sched/sched.h b/kernel/s

[PATCH v3] sched/pelt: fix update_blocked_averages() for dl and rt

2018-08-31 Thread Vincent Guittot
and dl utilization instead of simply skipping them to make sure that all metrics are synced when used during load balance. Fixes: 371bf4273269 ("sched/rt: Add rt_rq utilization tracking") Fixes: 3727e0e16340 ("sched/dl: Add dl_rq utilization tracking") Signed-off-by: Vince

Re: [PATCH v2] sched/pelt: fix update_blocked_averages() for dl and rt

2018-08-31 Thread Vincent Guittot
On Fri, 31 Aug 2018 at 17:07, Peter Zijlstra wrote: > > On Fri, Aug 31, 2018 at 04:56:19PM +0200, Vincent Guittot wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 309c93f..bc1de21 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched

[PATCH v2] sched/pelt: fix update_blocked_averages() for dl and rt

2018-08-31 Thread Vincent Guittot
and dl utilization instead of simply skipping them to make sure that all metrics are synced when used during load balance. Fixes: 371bf4273269 ("sched/rt: Add rt_rq utilization tracking") Fixes: 3727e0e16340 ("sched/dl: Add dl_rq utilization tracking") Signed-off-by: Vince

Re: [PATCH] sched/pelt: fix update_blocked_averages() for dl and rt

2018-08-31 Thread Vincent Guittot
On Fri, 31 Aug 2018 at 16:41, Peter Zijlstra wrote: > > On Fri, Aug 31, 2018 at 03:58:28PM +0200, Vincent Guittot wrote: > > update_blocked_averages() is called to periodiccally decay the stalled load > > of idle CPUs and to sync all loads before running load balance. > >

[PATCH] sched/pelt: fix update_blocked_averages() for dl and rt

2018-08-31 Thread Vincent Guittot
and dl utilization instead of simply skipping them to make sure that all metrics are synced when used during load balance. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

Re: [RFC PATCH 3/4] sched/topology: remove smt_gain

2018-08-29 Thread Vincent Guittot
On Wed, 29 Aug 2018 at 16:08, Qais Yousef wrote: > > You beat me to it, I got confused by smt_gain recently when I stumbled > on it as I found out on ARM it's not used and had to spend sometime to > convince myself it's not really necessary to use it. > > It was hard to track the history of this

Re: [PATCH] sched/schedutil : optimize utilization scaling for guest kernel

2018-08-29 Thread Vincent Guittot
Le Wednesday 29 Aug 2018 à 14:45:03 (+0200), Peter Zijlstra a écrit : > On Wed, Aug 29, 2018 at 10:51:42AM +0200, Vincent Guittot wrote: > > Scaling the utilization of CPUs with irq util_avg in schedutil doesn't give > > any benefit and just waste CPU cycles when irq time i

[RFC PATCH 3/4] sched/topology: remove smt_gain

2018-08-29 Thread Vincent Guittot
the value returned is not the capacity of SMT CPUs but default SCHED_CAPACITY_SCALE. Remove the smt_gain field from sched_domain struct Cc: Peter Zijlstra Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org (open list) Signed-off-by: Vincent Guittot --- include/linux/sched/topology.h | 1 - k

[PATCH 0/4] sched/numa: remove unused code

2018-08-29 Thread Vincent Guittot
e the last user has been removed by patch 3 Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Srikar Dronamraju Cc: Rik van Riel Cc: linux-kernel@vger.kernel.org (open list) Vincent Guittot (4): sched/numa: remove unused code from update_numa_stats() sched/numa: remove unused nr_running field sched/nu

[PATCH 1/4] sched/numa: remove unused code from update_numa_stats()

2018-08-29 Thread Vincent Guittot
nux-kernel@vger.kernel.org (open list) Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 309c93f..c2b8bf4 100644 --- a/kernel/sched/fair.c +++ b/kernel/sc

[PATCH 2/4] sched/numa: remove unused nr_running field

2018-08-29 Thread Vincent Guittot
nr_running in struct numa_stats is not used anywhere in the code. Remove it. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Srikar Dronamraju Cc: Rik van Riel Cc: linux-kernel@vger.kernel.org (open list) Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 3 --- 1 file changed, 3 deletions

[RFC PATCH 4/4] sched/topology: remove unused sd param from arch_scale_cpu_capacity()

2018-08-29 Thread Vincent Guittot
Signed-off-by: Vincent Guittot --- arch/arm/kernel/topology.c | 2 +- drivers/base/arch_topology.c | 6 +++--- include/linux/arch_topology.h| 2 +- kernel/sched/cpufreq_schedutil.c | 2 +- kernel/sched/deadline.c | 2 +- kernel/sched/fair.c | 8 kernel/sc

[PATCH] sched/schedutil : optimize utilization scaling for guest kernel

2018-08-29 Thread Vincent Guittot
time. Suggested-by: Wanpeng Li Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- kernel/sched/sched.h | 22 -- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 309c93f..c1334be 100644 --- a/kernel

[PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-08-29 Thread Vincent Guittot
realistic Signed-off-by: Vincent Guittot --- Documentation/devicetree/bindings/arm/cpus.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt index 29e1dc5..71d8cd0 100644

Re: [PATCH] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-08-29 Thread Vincent Guittot
On Tue, 28 Aug 2018 at 16:42, Punit Agrawal wrote: > > Vincent Guittot writes: > > > Hi Amit, > > > > On Wed, 22 Aug 2018 at 12:11, Punit Agrawal wrote: > >> > >> Hi Vincent, > >> > >> Thanks for the patch. One comment abo

Re: [PATCH] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-08-22 Thread Vincent Guittot
Hi Amit, On Wed, 22 Aug 2018 at 12:11, Punit Agrawal wrote: > > Hi Vincent, > > Thanks for the patch. One comment about the choice of units below. > > Vincent Guittot writes: > > > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > &

  1   2   3   4   5   6   7   8   9   10   >