Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support

2021-04-20 Thread Vinod Koul
On 03-04-21, 11:45, Tom Zanussi wrote: > +config INTEL_IDXD_PERFMON > + bool "Intel Data Accelerators performance monitor support" > + depends on INTEL_IDXD > + default y default y..? > /* IDXD software descriptor */ > @@ -369,4 +399,19 @@ int idxd_cdev_get_major(struct idxd_device

Re: [PATCH v2 -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()

2021-04-20 Thread Vinod Koul
On 07-04-21, 21:25, YueHaibing wrote: > commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part") > left behind this, so can remove it. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: idxd: Fix potential null dereference on pointer status

2021-04-20 Thread Vinod Koul
On 15-04-21, 12:06, Colin King wrote: > From: Colin Ian King > > There are calls to idxd_cmd_exec that pass a null status pointer however > a recent commit has added an assignment to *status that can end up > with a null pointer dereference. The function expects a null status > pointer

[GIT PULL]: dmaengine fixes for 5.12

2021-04-14 Thread Vinod Koul
Hi Linus, Please pull to receive the fixes for dmaengine for v5.12. Mostly bunch of driver fixes. The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at:

[GIT PULL]: Generic phy updates for v5.13 -second round

2021-04-14 Thread Vinod Koul
phy: ti: j721e-wiz: Add missing include linux/slab.h Vinod Koul (1): phy: Revert "phy: ti: j721e-wiz: add missing of_node_put" Yang Yingliang (1): phy: phy-twl4030-usb: Fix possible use-after-free in twl4030_usb_remove() drivers/phy/ti/phy-j721e-wiz.c | 2 +- driver

Re: [PATCH v2 2/3] soundwire: Intel: introduce DMI quirks for HP Spectre x360 Convertible

2021-04-13 Thread Vinod Koul
On 12-04-21, 14:37, Dave Hansen wrote: > On 3/1/21 11:51 PM, Bard Liao wrote: > > +++ b/drivers/soundwire/dmi-quirks.c > > @@ -0,0 +1,66 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > > +// Copyright(c) 2021 Intel Corporation. > > It looks like this is already in intel-next, so

Re: [PATCH v2] dmaengine: k3dma: use the correct HiSilicon copyright

2021-04-12 Thread Vinod Koul
On 01-04-21, 19:50, Hao Fang wrote: > s/Hisilicon/HiSilicon/g. > It should use capital S, according to the official website. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: qcom_hidma: remove unused code

2021-04-12 Thread Vinod Koul
On 01-04-21, 17:53, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/dma/qcom/hidma.c:94:20: warning: unused function 'to_hidma_desc' > [-Wunused-function]. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: plx_dma: add a missing put_device() on error path

2021-04-12 Thread Vinod Koul
On 23-03-21, 16:19, Dan Carpenter wrote: > Add a missing put_device(>dev) if the call to > dma_async_device_register(dma); fails. Applied, thanks -- ~Vinod

Re: [PATCH v14 12/12] dmaengine: imx-sdma: add terminated list for freed descriptor in worker

2021-04-12 Thread Vinod Koul
On 07-04-21, 23:30, Robin Gong wrote: > Add terminated list for keeping descriptor so that it could be freed in > worker without any potential involving next descriptor raised up before > this descriptor freed, because vchan_get_all_descriptors get all > descriptors including the last terminated

Re: [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error

2021-04-12 Thread Vinod Koul
On 09-04-21, 16:28, Dinghao Liu wrote: > pm_runtime_get_sync() will increase the runtime PM counter > even it returns an error. Thus a pairing decrement is needed > to prevent refcount leak. Fix this by replacing this API with > pm_runtime_resume_and_get(), which will not change the runtime > PM

Re: [PATCH v2] dma: Fix a double free in dma_async_device_register

2021-04-12 Thread Vinod Koul
On 30-03-21, 18:44, Lv Yunlong wrote: > In the first list_for_each_entry() macro of dma_async_device_register, > it gets the chan from list and calls __dma_async_device_channel_register > (..,chan). We can see that chan->local is allocated by alloc_percpu() and > it is freed chan->local by

Re: [PATCH v2 1/1] dmaengine: dw: Make it dependent to HAS_IOMEM

2021-04-12 Thread Vinod Koul
On 24-03-21, 16:17, Andy Shevchenko wrote: > Some architectures do not provide devm_*() APIs. Hence make the driver > dependent on HAVE_IOMEM. Applied, thanks -- ~Vinod

Re: [PATCH -next] phy: ti: j721e-wiz: Add missing include linux/slab.h

2021-04-11 Thread Vinod Koul
On 08-04-21, 09:28, Shixin Liu wrote: > When compiling with CONFIG_PHY_J721E_WIZ, Hulk Robot reported: > > drivers/phy/ti/phy-j721e-wiz.c: In function ‘wiz_mux_clk_register’: > drivers/phy/ti/phy-j721e-wiz.c:659:17: error: implicit declaration of > function ‘kzalloc’; did you mean ‘vzalloc’? >

Re: [PATCH -next] phy: phy-twl4030-usb: Fix possible use-after-free in twl4030_usb_remove()

2021-04-11 Thread Vinod Koul
On 07-04-21, 17:27, Yang Yingliang wrote: > This driver's remove path calls cancel_delayed_work(). However, that > function does not wait until the work function finishes. This means > that the callback function may still be running after the driver's > remove function has finished, which would

[GIT PULL]: Generic phy updates for v5.13-rc1

2021-04-07 Thread Vinod Koul
phy: Add Sparx5 ethernet serdes PHY driver phy: Sparx5 Eth SerDes: Use direct register operations Swapnil Jakhade (2): phy: cadence-torrent: Update PCIe + QSGMII config for correct PLL1 clock phy: cadence-torrent: Update PCIe + USB config for correct PLL1 clock Vinod Koul (2

[GIT PULL]: soundwire updates for v5.13-rc1

2021-04-07 Thread Vinod Koul
rectly in qcom_swrm_transport_params Vinod Koul (2): soundwire: add override addr ops soundwire: qcom: use signed variable for error return .../devicetree/bindings/soundwire/qcom,sdw.txt | 20 + drivers/soundwire/Makefile | 2 +- drivers/soundwire

Re: [PATCH linux-next v2 1/1] phy: Sparx5 Eth SerDes: Use direct register operations

2021-04-05 Thread Vinod Koul
On 29-03-21, 16:13, Steen Hegelund wrote: > Use direct register operations instead of a table of register > information to lower the stack usage. Applied, thanks -- ~Vinod

Re: [PATCH v2] phy: hisilicon: Use the correct HiSilicon copyright

2021-04-05 Thread Vinod Koul
On 01-04-21, 20:02, Hao Fang wrote: > s/Hisilicon/HiSilicon/g. > It should use capital S, according to the official website. Applied, thanks -- ~Vinod

Re: [PATCH -next] phy: marvell: phy-mvebu-cp11i-utmi needs USB_COMMON

2021-04-05 Thread Vinod Koul
On 01-04-21, 14:00, Randy Dunlap wrote: > When USB and USB_COMMON are not enabled, phy-mvebu-cp110-utmi > suffers a build error due to a missing interface that is provided > by CONFIG_USB_COMMON, so make the driver depend on USB_COMMON. > > ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in

Re: [PATCH v2] soundwire: intel_init: test link->cdns

2021-04-05 Thread Vinod Koul
On 06-04-21, 09:01, Bard Liao wrote: > intel_link_probe() could return error and dev_get_drvdata() will return > null in such case. So we have to test link->cdns after > link->cdns = dev_get_drvdata(>auxdev.dev); > Otherwise, we will meet the "kernel NULL pointer dereference" error. Applied,

Re: [PATCH] soundwire: qcom: handle return correctly in qcom_swrm_transport_params

2021-04-05 Thread Vinod Koul
On 01-04-21, 10:15, Srinivas Kandagatla wrote: > Looks like return from reg_write is set but not checked. > Fix this by adding error return path. Applied, thanks -- ~Vinod

Re: [PATCH v2] soundwire: qcom: wait for fifo space to be available before read/write

2021-04-05 Thread Vinod Koul
On 01-04-21, 10:00, Srinivas Kandagatla wrote: > If we write registers very fast we can endup in a situation where some > of the writes will be dropped without any notice. > > So wait for the fifo space to be available before reading/writing the > soundwire registers. Applied, thanks -- ~Vinod

Re: [PATCH] soundwire: qcom: cleanup internal port config indexing

2021-04-05 Thread Vinod Koul
On 01-04-21, 10:24, Srinivas Kandagatla wrote: > Internally used portconfig array for storing port bandwidth > params starts from offset zero. However port zero is not really > used and we also copy the bus parameters to offset zero. > So basically we endup with a code which has to subtract 1 from

Re: [PATCH v1] arm64: dts: qcom: sm8350: Add support for PRNG EE

2021-04-01 Thread Vinod Koul
On 01-04-21, 12:15, Robert Foss wrote: > RNG (Random Number Generator) in SM8350 features PRNG EE (Execution > Environment), hence add devicetree support for it. Reviewed-by: Vinod Koul -- ~Vinod

[PATCH] arm64: dts: qcom: sm8350: Add interconnects

2021-04-01 Thread Vinod Koul
Add interconnect nodes and add them for modem and cdsp nodes Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index

Re: [PATCH 1/2] soundwire: add macro to selectively change error levels

2021-04-01 Thread Vinod Koul
On 31-03-21, 09:13, Bard Liao wrote: > From: Pierre-Louis Bossart > > We sometimes discard -ENODATA when reporting errors and lose all > traces of issues in the console log, add a macro to add use dev_dbg() > in such cases. > > Signed-off-by: Pierre-Louis Bossart > Reviewed-by: Rander Wang >

Re: [PATCH v4 0/5] soundwire: add static port map support

2021-04-01 Thread Vinod Koul
On 15-03-21, 16:56, Srinivas Kandagatla wrote: > In some cases, SoundWire device ports are statically mapped to Controller > ports during design, however there is no way to expose this information > to the controller. Controllers like Qualcomm ones use this info to setup > static bandwidth

Re: [PATCH] soundwire: intel_init: test link->cdns

2021-04-01 Thread Vinod Koul
On 31-03-21, 09:02, Bard Liao wrote: > intel_link_probe() could return error and dev_get_drvdata() will return > null in such case. So we have to test link->cdns after > link->cdns = dev_get_drvdata(>auxdev.dev); > Otherwise, we will meet the "kernel NULL pointer dereference" error. This fails to

Re: [PATCH] soundwire: stream: fix memory leak in stream config error path

2021-04-01 Thread Vinod Koul
On 31-03-21, 08:46, Bard Liao wrote: > From: Rander Wang > > When stream config is failed, master runtime will release all > slave runtime in the slave_rt_list, but slave runtime is not > added to the list at this time. This patch frees slave runtime > in the config error path to fix the memory

Re: [PATCH] soundwire: qcom: wait for fifo space to be available before read/write

2021-04-01 Thread Vinod Koul
On 31-03-21, 18:00, Srinivas Kandagatla wrote: > If we write registers very fast we can endup in a situation where some > of the writes will be dropped without any notice. > > So wait for the fifo space to be available before reading/writing the > soundwire registers. > > Signed-off-by: Srinivas

Re: [PATCH v6 0/7] phy: qcom-qmp: provide DP phy support for sm8250

2021-03-31 Thread Vinod Koul
On 31-03-21, 18:16, Dmitry Baryshkov wrote: > Changes since v5: > - Rebase on top of phy-next > - Rework 'move DP functions to callbacks' patch to leave most of the >code in place, using function prototypes. Applied 1 thru 5, thanks Bjorn you can pick the dts bits. -- ~Vinod

[PATCH V2] soundwire: qcom: use signed variable for error return

2021-03-31 Thread Vinod Koul
/soundwire/qcom.c: qcom_swrm_irq_handler() warn: impossible condition '(devnum < 0) => (0-255 < 0)' Reported-by: kernel test robot Signed-off-by: Vinod Koul --- drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/qcom.c b/drivers/

Re: [PATCH] soundwire: qcom: use signed variable for error return

2021-03-31 Thread Vinod Koul
On 31-03-21, 09:41, Pierre-Louis Bossart wrote: > > > On 3/31/21 2:21 AM, Vinod Koul wrote: > > We get warning for using a unsigned variable being compared to less than > > zero. The comparison is correct as it checks for errors from previous > > call to qcom_swrm_ge

Re: [PATCH] phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII

2021-03-31 Thread Vinod Koul
On 31-03-21, 18:44, Kishon Vijay Abraham I wrote: > Configure 'p_standard_mode' only for DP/QSGMII as for other modes > it's not used as per the programming sequence. Add "continue" in the > else to prevent random value from being written to p_standard_mode. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: k3dma: use the correct HiSilicon copyright

2021-03-31 Thread Vinod Koul
On 30-03-21, 14:44, Hao Fang wrote: > s/Hisilicon/HiSilicon/g. > It should use capital S, according to > https://www.hisilicon.com/en/terms-of-use. Again, dont agree to terms of use. Pls drop that > > Signed-off-by: Hao Fang > --- > drivers/dma/k3dma.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 00/16] CSI2RX support on J721E

2021-03-31 Thread Vinod Koul
On 31-03-21, 17:10, Pratyush Yadav wrote: > On 31/03/21 03:03PM, Vinod Koul wrote: > > On 30-03-21, 23:03, Pratyush Yadav wrote: > > > Hi, > > > > > > This series adds support for CSI2 capture on J721E. It includes some > > > fixes to the Cadence C

Re: [PATCH v2 7/8] dt-bindings: phy: fix dt_binding_check warning in mediatek,ufs-phy.yaml

2021-03-31 Thread Vinod Koul
On 19-03-21, 10:34, Seiya Wang wrote: > This commit fixes the warning messages of make dt_binding_check from > newly added mediatek,mt8195-ufsphy in mediatek,ufs-phy.yaml Applied, thanks -- ~Vinod

Re: [PATCH v4] phy: zynqmp: Handle the clock enable/disable properly

2021-03-31 Thread Vinod Koul
On 24-03-21, 17:48, Manish Narani wrote: > The current driver is not handling the clock enable/disable operations > properly. The clocks need to be handled correctly by enabling or > disabling at appropriate places. This patch adds code to handle the > same. Applied, thanks -- ~Vinod

Re: [PATCH v5 (RESEND) 1/7] phy: phy-hi3670-usb3: move driver from staging into phy

2021-03-31 Thread Vinod Koul
On 25-03-21, 19:05, Mauro Carvalho Chehab wrote: > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > for mainstream. Mode it from staging into the main driver's > phy/ directory. Overall lgtm, some nits below. With those fixed: Acked-By: Vinod Koul > +static int hi367

Re: [PATCH] phy: hisilicon: Use the correct HiSilicon copyright

2021-03-31 Thread Vinod Koul
On 30-03-21, 14:47, Hao Fang wrote: > s/Hisilicon/HiSilicon/g. > It should use capital S, > according to https://www.hisilicon.com/en/terms-of-use. And I have not agreed to those terms of use! If you wish to change the name, please do send the patch dropping this terms of use link. I dont mind

Re: [PATCH v5 0/7] phy: qcom-qmp: provide DP phy support for sm8250

2021-03-31 Thread Vinod Koul
On 28-03-21, 23:52, Dmitry Baryshkov wrote: > Changes since v4: > - Fix typo in the qcom,sc7180-qmp-usb3-phy name in the first patch > > Changes since v3: > - Move qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy from >qcom,qmp-usb3-dp.yaml to qcom,qmp-phy.yaml > - Do not touch

Re: [PATCH] phy: microchip: PHY_SPARX5_SERDES should depend on ARCH_SPARX5

2021-03-31 Thread Vinod Koul
On 31-03-21, 10:19, Geert Uytterhoeven wrote: > The Microchip Sparx5 SerDes PHY is present only Microchip Sparx5 SoCs. > Hence add a dependency on ARCH_SPARX5, to prevent asking the user about > this driver when configuring a kernel without support for Sparx5 SoCs. Applied, thanks -- ~Vinod

Re: [PATCH v2 0/5] j721e-wiz/cadence-torrent: Support to skip SERDES configuration

2021-03-31 Thread Vinod Koul
On 30-03-21, 16:31, Kishon Vijay Abraham I wrote: > Add support to skip SERDES configuration if it's already configured in > bootloader. > > The wiz part was initially sent in [1] but that was sent more in the > context of Sierra but this is in context of Torrent. The Sierra part > would be sent

Re: [PATCH v7 00/13] PHY: Add support in Sierra to use external clock

2021-03-31 Thread Vinod Koul
On 19-03-21, 18:11, Kishon Vijay Abraham I wrote: > Patch series adds support in Sierra driver to use external clock. > > v1 of the patch series can be found @ [1] > v2 of the patch series can be found @ [2] > v3 of the patch series can be found @ [3] > v4 of the patch series can be found @ [5] >

Re: [PATCH 00/16] CSI2RX support on J721E

2021-03-31 Thread Vinod Koul
On 30-03-21, 23:03, Pratyush Yadav wrote: > Hi, > > This series adds support for CSI2 capture on J721E. It includes some > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY > driver, and finally adds the TI CSI2RX wrapper driver. > > Tested on TI's J721E with OV5640 sensor. >

[PATCH] soundwire: qcom: use signed variable for error return

2021-03-31 Thread Vinod Koul
: impossible condition '(devnum < 0) => (0-255 < 0)' Reported-by: kernel test robot Signed-off-by: Vinod Koul --- drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index b08ecb9b418c..55ed133c67

Re: [PATCH 0/4] PHY: Update Cadence Torrent PHY multilink configurations specific to TI

2021-03-30 Thread Vinod Koul
On 04-03-21, 07:08, Swapnil Jakhade wrote: > This patch series updates Torrent PHY driver for multilink configurations > specific to TI platform. It also adds support for configuring QSGMII in > TI Wiz driver. > > This patch series is dependent on [1] and should be applied on > top of this.

Re: [PATCH v3 0/6] AM64: Add SERDES driver support

2021-03-30 Thread Vinod Koul
On 10-03-21, 17:38, Kishon Vijay Abraham I wrote: > AM64 uses the same SERDES as in J7200, however AM642 EVM doesn't > have a clock generator (unlike J7200 base board). Here the clock from > the SERDES has to be routed to the PCIE connector. This series adds > support to drive reference clock

Re: [PATCH v3 0/5] Add support for CP110 UTMI PHY

2021-03-30 Thread Vinod Koul
On 07-03-21, 18:33, kos...@marvell.com wrote: > From: Konstantin Porotchkin > > This series of patches adds a new PHY driver for supporting CP110 UTMI > PHY in Linux. Currently the functionality of USB ports connected to > this PHY depends on boot loader setup. > The new driver eliminates kernel

Re: [PATCH 14/30] Revert "s3c24xx-dma.c: Fix a typo"

2021-03-30 Thread Vinod Koul
On 29-03-21, 05:23, Bhaskar Chowdhury wrote: > s/transferred/transfered/ > > This reverts commit a2ddb8aea8106bd5552f8516ad7a8a26b9282a8f. This is not upstream, why not squash in. Also would make sense to write sensible changelog and not phrases and use the right subsystem conventions! Droped

Re: [PATCH v6 0/9] soundwire: qcom: various improvements

2021-03-30 Thread Vinod Koul
On 30-03-21, 15:47, Srinivas Kandagatla wrote: > Thanks for reviewing v5 of this patchset! > > During testing SoundWire controller on SM8250 MTP, we found > few issues like all the interrupts are not handled, > all transport parameters are not read from device tree. > Patch to add Auto

Re: [PATCH] soundwire: cadence: only prepare attached devices on clock stop

2021-03-30 Thread Vinod Koul
On 23-03-21, 09:37, Bard Liao wrote: > From: Pierre-Louis Bossart > > We sometimes see COMMAND_IGNORED responses during the clock stop > sequence. It turns out we already have information if devices are > present on a link, so we should only prepare those when they > are attached. > > In

Re: [PATCH v4 4/5] ASoC: dt-bindings: wsa881x: add bindings for port mapping

2021-03-30 Thread Vinod Koul
On 15-03-21, 16:56, Srinivas Kandagatla wrote: > WSA881x SoundWire device ports are statically assigned to master ports > at design time. So add bindings required to specify these mappings! Mark, are you okay for 4, 5 to go thru sdw tree with your ack? The patches lgtm -- ~Vinod

Re: [PATCH v5 6/9] soundwire: qcom: add support to new interrupts

2021-03-30 Thread Vinod Koul
On 26-03-21, 06:39, Srinivas Kandagatla wrote: > - ctrl->reg_write(ctrl, SWRM_INTERRUPT_CLEAR, sts); > + do { > + for (i = 0; i < SWRM_INTERRUPT_MAX; i++) { > + value = intr_sts_masked & (1 << i); BIT(i) istead of shifiting? > + if

Re: [PATCH v5 5/9] soundwire: qcom: update register read/write routine

2021-03-30 Thread Vinod Koul
On 26-03-21, 06:39, Srinivas Kandagatla wrote: > + swrm->reg_write(swrm, SWRM_CMD_FIFO_WR_CMD, val); > + > + /* version 1.3 or less */ > + if (swrm->version <= 0x0103) > + usleep_range(150, 155); > + > + if (cmd_id == SWR_BROADCAST_CMD_ID) { > + /* > +

[PATCH] MAINTAINERS: icc: add interconnect tree

2021-03-28 Thread Vinod Koul
MAINTAINERS entry for ICC is missing the tree details, so add it Signed-off-by: Vinod Koul --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6de606aeb9b1..e3f37d0b6de9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9290,6 +9290,7 @@ INTERCONNECT

Re: [PATCH v7 00/14] Tegra XHCI controller ELPG support

2021-03-25 Thread Vinod Koul
On 25-03-21, 15:00, Thierry Reding wrote: > On Thu, Mar 25, 2021 at 11:45:16AM +0530, Vinod Koul wrote: > > On 24-03-21, 14:32, Thierry Reding wrote: > > > Also adding Vinod for visibility and in case Kishon's too busy. > > > > Yes please CC me on all things phy (MA

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Vinod Koul
On 18-03-21, 10:22, Liu Ying wrote: > > Can we have these in kernel-doc style please, similar to style in > > linux/phy/phy.h > > I take this way of in-line member documentation comment for the below 3 > reasons: > > 1) Members of struct phy_configure_opts_mipi_dphy and > struct

Re: [PATCH] phy:qualcomm: remove duplicate argument

2021-03-25 Thread Vinod Koul
On 19-03-21, 04:36, menglong8.d...@gmail.com wrote: > From: Zhang Yunkai > > 'HSUSB_CTRL_DPSEHV_CLAMP' in 'val' is duplicated. Applied, thanks -- ~Vinod

Re: [PATCH] phy: intel: Fix a typo

2021-03-25 Thread Vinod Koul
On 21-03-21, 02:10, Bhaskar Chowdhury wrote: > > s/subsytem/subsystem/ Applied, thanks -- ~Vinod

Re: [PATCH 2/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for SC7280

2021-03-25 Thread Vinod Koul
On 17-03-21, 16:31, Sandeep Maheswaram wrote: > Add the compatible string for sc7280 SoC from Qualcomm Applied, thanks -- ~Vinod

Re: [PATCH v5 04/13] dt-bindings: phy: mediatek: tphy: change patternProperties

2021-03-25 Thread Vinod Koul
On 16-03-21, 17:22, Chunfeng Yun wrote: > The phy may be named as pcie-phy when the T-PHY only supports > PCIe mode, it's also the similar case for SATA, named as > sata-phy. Applied, thanks -- ~Vinod

Re: [PATCH v5 03/13] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items

2021-03-25 Thread Vinod Koul
On 16-03-21, 17:22, Chunfeng Yun wrote: > mt7623-hdmi-tx is compatible to mt2701-hdmi-tx, and the compatible > "mediatek,mt7623-hdmi-tx" is not supported in driver, in fact uses > "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes the > compatible items to make dependence clear. Applied,

Re: [PATCH v5 02/13] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

2021-03-25 Thread Vinod Koul
On 16-03-21, 17:22, Chunfeng Yun wrote: > mt7623-mipi-tx is compatible to mt2701-mipi-tx, and use > "mediatek,mt2701-mipi-tx" instead on MT7623, so modify > the compatible items to make dependence clear. Applied, thanks -- ~Vinod

Re: [PATCH v7 00/14] Tegra XHCI controller ELPG support

2021-03-25 Thread Vinod Koul
On 24-03-21, 14:32, Thierry Reding wrote: > On Wed, Mar 24, 2021 at 01:39:32PM +0100, Thierry Reding wrote: > > On Fri, Feb 05, 2021 at 05:22:29PM +0100, Greg KH wrote: > > > On Fri, Feb 05, 2021 at 05:15:21PM +0100, Thierry Reding wrote: > > > > On Wed, Jan 20, 2021 at 03:34:00PM +0800, JC Kuo

Re: [PATCH] dt-bindings: mailbox: Add compatible for SM8350 IPCC

2021-03-25 Thread Vinod Koul
On 12-03-21, 11:28, Bjorn Andersson wrote: > On Thu 11 Mar 23:12 CST 2021, Vinod Koul wrote: > > Adding Jassi as recipient. Please let Vinod know if you want him to > resend this patch to you. (I send a patch for MAINTAINERS yesterday) Jassi, should I resend or you can pick from lore

Re: [PATCH] soundwire: intel: move to auxiliary bus

2021-03-24 Thread Vinod Koul
On 23-03-21, 12:29, Pierre-Louis Bossart wrote: > Thanks Greg and Vinod for the reviews > > > > > -static int intel_master_probe(struct platform_device *pdev) > > > > +static int intel_link_probe(struct auxiliary_device *auxdev, const > > > > struct auxiliary_device_id *id) > > > > { > > > > -

Re: [PATCH] soundwire: add slave device to linked list after device_register()

2021-03-23 Thread Vinod Koul
On 23-03-21, 10:25, Bard Liao wrote: > From: Pierre-Louis Bossart > > We currently add the slave device to a linked list before > device_register(), and then remove it if device_register() fails. > > It's not clear why this sequence was necessary, this patch moves the > linked list management

Re: [PATCH 0/5] soundwire: add missing \n in dev_err()

2021-03-23 Thread Vinod Koul
On 23-03-21, 08:58, Bard Liao wrote: > We fixed a lot of warnings in 2019 but the magic of copy-paste keeps > adding new ones... Applied, thanks -- ~Vinod

Re: [PATCH] soundwire: intel: move to auxiliary bus

2021-03-23 Thread Vinod Koul
On 23-03-21, 08:43, Bard Liao wrote: > From: Pierre-Louis Bossart > > Now that the auxiliary_bus exists, there's no reason to use platform > devices as children of a PCI device any longer. > > This patch refactors the code by extending a basic auxiliary device > with Intel link-specific

Re: [PATCH v2 1/2] dt-bindings: thermal: qcom-tsens: Add compatible for sm8350

2021-03-22 Thread Vinod Koul
On 22-03-21, 11:04, Robert Foss wrote: > Add tsens bindings for sm8350. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support

2021-03-22 Thread Vinod Koul
On 22-03-21, 11:04, Robert Foss wrote: > sm8350 has 29 thermal sensors split across two tsens controllers. Add > the thermal zones to expose them and wireup the cpus to throttle their > frequencies on crossing passive temperature thresholds. Reviewed-by: Vinod Koul -- ~Vinod

Re: [RESEND PATCH v2] soundwire: bus: Fix device found flag correctly

2021-03-22 Thread Vinod Koul
On 09-03-21, 10:48, Srinivas Kandagatla wrote: > found flag is used to indicate SoundWire devices that are > both enumerated on the bus and available in the device list. > However this flag is not reset correctly after one iteration, > This could miss some of the devices that are enumerated on the

Re: [PATCH v2 0/3] soundwire: clear bus clash/parity interrupt before the mask is enabled

2021-03-22 Thread Vinod Koul
On 02-03-21, 16:27, Bard Liao wrote: > The SoundWire specification allows a Slave device to report a bus clash > or parity error with the in-band interrupt mechanism. > Unfortunately, on some platforms, these errors are randomly reported and > don't seem to be valid. > This series suggests the

Re: [PATCH v2 1/3] soundwire: add master quirks for bus clash and parity

2021-03-22 Thread Vinod Koul
On 02-03-21, 16:27, Bard Liao wrote: > Currently quirks are only allowed for Slave devices. This patch > describes the need for two quirks at the Master level. > > a) bus clash > The SoundWire specification allows a Slave device to report a bus clash > with the in-band interrupt mechanism when it

Re: [PATCH v2 0/3] soundwire: add DMI quirks for overridind addr

2021-03-22 Thread Vinod Koul
On 02-03-21, 15:51, Bard Liao wrote: > Platform firmware may have incorrect _ADR values causing the driver > probes to fail. Adding the override_ops allows people to override the > addr values. Applied, thanks -- ~Vinod

Re: [PATCH v7 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2021-03-22 Thread Vinod Koul
On 18-03-21, 16:16, Sanjay R Mehta wrote: > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > > > > why do you need sched.h here? > > > >> + > >> +#include "ptdma.h" > >> + > >> +/* Ever-increasing

Re: [PATCH 2/3] arm64: dts: qcom: sm8150: add iommus to qups

2021-03-22 Thread Vinod Koul
On 20-03-21, 17:16, Caleb Connolly wrote: > Hi Vinod, > > On 16/03/2021 6:15 am, Vinod Koul wrote: > > On 10-03-21, 16:31, Caleb Connolly wrote: > >> Hook up the SMMU for doing DMA over i2c. Some peripherals like > >> touchscreens easily exceed 32-b

Re: [PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT

2021-03-18 Thread Vinod Koul
On 11-03-21, 16:33, Bjorn Andersson wrote: > The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others > needs > platform-, and perhaps even board-, specific firmware. Add support for > providing this in devicetree. Reviewed-by: Vinod Koul -- ~Vinod

[PATCH v3 2/2] interconnect: qcom: Add SM8350 interconnect provider driver

2021-03-18 Thread Vinod Koul
Signed-off-by: Vinod Koul --- drivers/interconnect/qcom/Kconfig | 9 + drivers/interconnect/qcom/Makefile | 2 + drivers/interconnect/qcom/sm8350.c | 633 + drivers/interconnect/qcom/sm8350.h | 168 4 files changed, 812 insertions(+) create mode 100644

[PATCH v3 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings

2021-03-18 Thread Vinod Koul
The Qualcomm SM8350 platform has several bus fabrics that could be controlled and tuned dynamically according to the bandwidth demand. Signed-off-by: Vinod Koul --- .../bindings/interconnect/qcom,rpmh.yaml | 10 + .../dt-bindings/interconnect/qcom,sm8350.h| 172 ++ 2

[PATCH v3 0/2] interconnect: qcom: Add SM8350 support

2021-03-18 Thread Vinod Koul
This adds support for interconnect support for SM8350 SoC Changes since v2: - Plug gaps in indexes - fix typo in commit log for patch2 and kconfig depends (for real this time) Changes since v1: - Fix comments by Georgi, split the header - Fix the macro for qns_llcc Vinod Koul (2): dt

Re: [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect provider driver

2021-03-18 Thread Vinod Koul
On 18-03-21, 09:08, Georgi Djakov wrote: > Hi Vinod, > > On 3/2/21 15:43, Vinod Koul wrote: > > Add driver for the Qualcomm interconnect buses found in SM8i350 based > > Still SM8i350? Have you checked my comments on v1? Oops missed to fix the commit

Re: [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings

2021-03-18 Thread Vinod Koul
Hello Georgi, On 18-03-21, 09:08, Georgi Djakov wrote: > Hi Vinod, > > +#define MASTER_GEM_NOC_CNOC1 > > Maybe start from zero? Yeah not sure how that got missed > > +#define MASTER_CAMNOC_HF 0 > > +#define MASTER_CAMNOC_ICP 2 > > Why jump from 0 to 2?

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-17 Thread Vinod Koul
arameters > should cover all potential users. > > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: NXP Linux Team > Reviewed-by: Robert Foss > Signed-off-by: Liu Ying > --- > v3->v4: > * Add Robert's R-b tag. > > v2->v3: > * No change. >

Re: [PATCH 2/2] phy/rockchip: add Innosilicon-based CSI dphy

2021-03-17 Thread Vinod Koul
On 10-02-21, 22:42, Heiko Stuebner wrote: > From: Heiko Stuebner > > The CSI dphy found for example on the rk3326/px30 and rk3368 is based > on an IP design from Innosilicon. Add a driver for it. > > Signed-off-by: Heiko Stuebner > --- > drivers/phy/rockchip/Kconfig | 9 + >

Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings

2021-03-17 Thread Vinod Koul
i.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- ... > .../bindings/phy/ti,phy-j721e-wiz.yaml | 2 +- Acked-By: Vinod Koul -- ~Vinod

Re: [PATCH v15 0/4] Adding the Sparx5 Serdes driver

2021-03-17 Thread Vinod Koul
On 18-02-21, 17:14, Steen Hegelund wrote: > Adding the Sparx5 Serdes driver > > This series of patches provides the serdes driver for the Microchip Sparx5 > ethernet switch. > > The serdes driver supports the 10G and 25G serdes instances available in the > Sparx5. > > The Sparx5 serdes support

Re: [PATCH 08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-17 Thread Vinod Koul
On 16-03-21, 19:14, Seiya Wang wrote: > This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC > Platform. Applied, thanks -- ~Vinod

Re: [PATCH 07/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-17 Thread Vinod Koul
On 16-03-21, 19:14, Seiya Wang wrote: > This commit adds dt-binding documentation of T-Phy for Mediatek MT8195 SoC > Platform. Applied, thanks -- ~Vinod

Re: [PATCH v3] phy: qcom-qmp: add hbr3_hbr2 voltage and premphasis swing table

2021-03-17 Thread Vinod Koul
On 16-03-21, 10:12, Kuogee Hsieh wrote: > Add hbr3_hbr2 voltage and premphasis swing table to support > HBR3 link rate. > > Changes in V2: > -- replaced upper case with lower case at hbr3_hbr2 table > > Changes in v3: > -- replace space with tab at hbr3_hbr2 table This should be after the ---

Re: [PATCH 0/3] AM64: Add SERDES DT bindings

2021-03-17 Thread Vinod Koul
On 10-03-21, 16:57, Kishon Vijay Abraham I wrote: > Patch series adds device tree bindings to support SERDES in AM64 > platform. > > This is split from [1] since this binding is also required for AM64 > USB DT patches to be merged. > > Vinod, > > Once the 1st patch of the series is reviewed by

Re: [PATCH v2] scsi: dt-bindings: ufs: Add sm8250, sm8350 compatible strings

2021-03-16 Thread Vinod Koul
Hello Martin, On 16-03-21, 21:21, Martin K. Petersen wrote: > > Vinod, > > >> Document "qcom,sm8250-ufshc" and "qcom,sm8350-ufshc" compatible string. > >> Use of "qcom,sm8250-ufshc" is already present upstream, so add misiing > >> documentation. "qcom,sm8350-ufshc" is for UFS HC found in SM8350

Re: [PATCH v7 00/15] dmaengine: dw-edma: HDMA support

2021-03-16 Thread Vinod Koul
On 18-02-21, 20:03, Gustavo Pimentel wrote: > This patch series adds the HDMA support, as long the IP design has set > the compatible register map parameter, which allows compatibility at > some degree for the existing Synopsys DesignWare eDMA driver that is > already available on the Kernel. > >

Re: [PATCH 3/3] arm64: dts: qcom: sm8150: add i2c nodes

2021-03-16 Thread Vinod Koul
On 10-03-21, 16:31, Caleb Connolly wrote: > Tested on the OnePlus 7 Pro (including DMA). Lgtm: Reviewed-by: Vinod Koul But missing enabling nodes in board dts ..? > > Signed-off-by: Caleb Connolly > --- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 521 ++

Re: [PATCH 2/3] arm64: dts: qcom: sm8150: add iommus to qups

2021-03-16 Thread Vinod Koul
On 10-03-21, 16:31, Caleb Connolly wrote: > Hook up the SMMU for doing DMA over i2c. Some peripherals like > touchscreens easily exceed 32-bytes per transfer, causing errors and > lockups without this. Why not squash this to patch 1..? > > Signed-off-by: Caleb Connolly > --- > Fixes i2c on the

Re: [PATCH v15 0/4] Adding the Sparx5 Serdes driver

2021-03-15 Thread Vinod Koul
Hello Steen, On 15-03-21, 16:04, Steen Hegelund wrote: > Hi Kishon, Vinod, Andrew, Jacub, and David, > > I just wanted to know if you think that the Generic PHY subsystem might > not be the right place for this Ethernet SerDes PHY driver after all. > > Originally I chose this subsystem for

Re: [PATCH] dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml

2021-03-15 Thread Vinod Koul
On 11-03-21, 21:31, Rafał Miłecki wrote: > Hi, > > On 16.11.2020 08:46, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > 1. Change syntax from txt to yaml > > 2. Drop "Driver for" from the title > > 3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check) > > 4. Specify license > >

Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

2021-03-15 Thread Vinod Koul
On 05-03-21, 03:49, 'Wei Yongjun wrote: > From: Wei Yongjun > > Fix the return value check typo which testing the wrong variable > in ingenic_usb_phy_probe(). Applied, thanks -- ~Vinod

  1   2   3   4   5   6   7   8   9   10   >