Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-10 Thread Vishal Annapurve
primary command set (INQUIRY, TEST UNIT READY, etc.) but any command accessing the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-10 Thread Vishal Annapurve
primary command set (INQUIRY, TEST UNIT READY, etc.) but any command accessing the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Vishal Annapurve
-off-by: Vishal Annapurve --- drivers/usb/storage/cypress_atacb.c | 1 + drivers/usb/storage/isd200.c| 2 +- drivers/usb/storage/transport.c | 8 drivers/usb/storage/usb.c | 10 ++ 4 files changed, 12 insertions(+), 9 deletions(-) --- diff --git a/drivers

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Vishal Annapurve
Hi Greg, Attached are the patches. Regards, Vishal On Monday 09 December 2013 07:29 AM, Greg KH wrote: On Sat, Nov 16, 2013 at 12:23:50PM +0530, Vishal Annapurve wrote: Hi, Here are the updated patches: Can you please resend these in a format which I can apply them in without having

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Vishal Annapurve
Hi Greg, Attached are the patches. Regards, Vishal On Monday 09 December 2013 07:29 AM, Greg KH wrote: On Sat, Nov 16, 2013 at 12:23:50PM +0530, Vishal Annapurve wrote: Hi, Here are the updated patches: Can you please resend these in a format which I can apply them in without having

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Vishal Annapurve
-off-by: Vishal Annapurve vannapu...@nvidia.com --- drivers/usb/storage/cypress_atacb.c | 1 + drivers/usb/storage/isd200.c| 2 +- drivers/usb/storage/transport.c | 8 drivers/usb/storage/usb.c | 10 ++ 4 files changed, 12 insertions(+), 9 deletions

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
command accessing the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve --- drivers/usb/storage/uas.c | 5 - 1 file changed, 4 insertions

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve --- drivers/staging/keucr/transport.c | 6 +++--- drivers/staging/keucr/usb.c

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
UNIT READY, etc.) but any command accessing the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve --- drivers/usb/storage/cypress_atacb.c

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
UNIT READY, etc.) but any command accessing the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve vannapu...@nvidia.com --- drivers/usb

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve vannapu...@nvidia.com --- drivers/staging/keucr/transport.c | 6 +++--- drivers

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
command accessing the storage medium will time out. As the USB storage was setting command result as aborted rather than timed out, SCSI layer was not recognizing the above mentioned failure pattern. Signed-off-by: Vishal Annapurve vannapu...@nvidia.com --- drivers/usb/storage/uas.c | 5 - 1 file

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-26 Thread Vishal Annapurve
Hi Alan, Here is the new patch: From: Vishal Annapurve Date: Sat, 26 Oct 2013 21:10:11 +0530 Subject: [PATCH] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change is made to bring USB

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-26 Thread Vishal Annapurve
Hi Alan, Here is the new patch: From: Vishal Annapurve vannapu...@nvidia.com Date: Sat, 26 Oct 2013 21:10:11 +0530 Subject: [PATCH] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-19 Thread Vishal Annapurve
To: Vishal Annapurve Cc: Ming Lei; Linux Kernel Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result On Fri, 18 Oct 2013, Vishal Annapurve wrote: > Hi Alan, > > What I wanted to say was If the bit US_FLIDX_TIMED_OUT can have more > meaning

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-19 Thread Vishal Annapurve
To: Vishal Annapurve Cc: Ming Lei; Linux Kernel Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result On Fri, 18 Oct 2013, Vishal Annapurve wrote: Hi Alan, What I wanted to say was If the bit US_FLIDX_TIMED_OUT can have more meanings than timed out

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-17 Thread Vishal Annapurve
? Regards, Vishal -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 10:22 PM To: Vishal Annapurve Cc: Ming Lei; Linux Kernel Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result On Tue, 15 Oct 2013

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-17 Thread Vishal Annapurve
? Regards, Vishal -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 10:22 PM To: Vishal Annapurve Cc: Ming Lei; Linux Kernel Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result On Tue, 15 Oct 2013

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Vishal Annapurve
storage bridge or for entire usb storage Or maybe scsi has decided to abort so it should override the result. Regards, Vishal -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 7:03 PM To: Vishal Annapurve Cc: Ming Lei; Linux Kernel

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Vishal Annapurve
-Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 5:55 PM To: Ming Lei Cc: Vishal Annapurve; Linux Kernel Mailing List; linux-usb Subject: Re: [PATCH] usb-storage: scsiglue: Changing the command result On Tue, 15 Oct 2013, Ming Lei wrote

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Vishal Annapurve
-Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 5:55 PM To: Ming Lei Cc: Vishal Annapurve; Linux Kernel Mailing List; linux-usb Subject: Re: [PATCH] usb-storage: scsiglue: Changing the command result On Tue, 15 Oct 2013, Ming Lei wrote

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Vishal Annapurve
storage bridge or for entire usb storage Or maybe scsi has decided to abort so it should override the result. Regards, Vishal -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 7:03 PM To: Vishal Annapurve Cc: Ming Lei; Linux Kernel

[PATCH] usb-storage: scsiglue: Changing the command result

2013-09-26 Thread Vishal Annapurve
same? Regards, Vishal Annapurve From: Vishal Annapurve Subject: [PATCH] usb-storage: Changing the command result This change updates the returned result to scsi layer to use DID_TIMEOUT flag as a result status rather than DID_ABORT for commands aborted due to timeout. Signed-off-by: V

[PATCH] mmc: Reducing cache operations in the host driver

2013-09-26 Thread Vishal Annapurve
ould like to understand if this patch can cause any regressions for any of the architectures or with the MMC functionality. Thanks & Regards, Vishal Annapurve Author: Vishal Annapurve MMC: Remove unnecessary cache operations 1) This change removes unnecessary cache operati

[PATCH] mmc: Reducing cache operations in the host driver

2013-09-26 Thread Vishal Annapurve
to understand if this patch can cause any regressions for any of the architectures or with the MMC functionality. Thanks Regards, Vishal Annapurve Author: Vishal Annapurve vannapu...@nvidia.com MMC: Remove unnecessary cache operations 1) This change removes unnecessary cache

[PATCH] usb-storage: scsiglue: Changing the command result

2013-09-26 Thread Vishal Annapurve
Annapurve From: Vishal Annapurve vannapu...@nvidia.com Subject: [PATCH] usb-storage: Changing the command result This change updates the returned result to scsi layer to use DID_TIMEOUT flag as a result status rather than DID_ABORT for commands aborted due to timeout. Signed-off-by: Vishal