Re: [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon

On 2/3/21 4:50 AM, Yang Li wrote: Eliminate the following coccicheck warning: ./drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH] pwm: fix semicolon.cocci warnings

On 1/28/21 10:57 PM, Uwe Kleine-König wrote: Hello, On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote: From: kernel test robot drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci

Re: [PATCH] pwm: fix semicolon.cocci warnings

") CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH v3 4/5] amba: Make the remove callback return void

-by: Dmitry Torokhov Acked-by: Linus Walleij Signed-off-by: Uwe Kleine-König For drivers/memory/pl172.c: Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH] MAINTAINERS: crypto: s5p-sss: drop Kamil Konieczny

for S5P Security Subsystem crypto accelerator. Signed-off-by: Krzysztof Kozlowski Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH 13/32] pwm: lpc32xx: convert to devm_platform_ioremap_resource

On 12/29/19 10:05 AM, Yangtao Li wrote: Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH 29/32] pwm: lpc18xx-sct: convert to devm_platform_ioremap_resource

On 12/29/19 10:06 AM, Yangtao Li wrote: Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH 19/36] tty: serial: lpc32xx_hs: Remove unused variable 'tmp'

-Hartman Cc: Jiri Slaby Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Kevin Wells Cc: Roland Stigge Cc: linux-ser...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/lpc32xx_hs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

Hi Gao Xiang, On 10/30/20 2:47 PM, Gao Xiang wrote: Hi Vladimir, On Fri, Oct 30, 2020 at 02:20:31PM +0200, Vladimir Zapolskiy wrote: Hello Gao Xiang, On 10/22/20 5:57 PM, Gao Xiang via Linux-erofs wrote: From: Gao Xiang pcluster should be only set up for all managed pages instead

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

get rid of __stagingpage_alloc helper") Cc: # 5.5+ Signed-off-by: Gao Xiang I was looking exactly at this problem recently, my change is one-to-one to your fix, thus I can provide a tag: Tested-by: Vladimir Zapolskiy The fixed problem is minor, but the kernel log becomes polluted, if a pa

Re: [PATCH 10/29] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name

ot;generic-ehci" and "generic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin --- arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH -next v2] usb: gadget: lpc32xx_udc: Convert to DEFINE_SHOW_ATTRIBUTE

On 9/19/20 5:52 AM, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH v2 5/7] regulator: plug of_node leak in regulator_register()'s error path

On 8/12/20 5:09 PM, Michał Mirosław wrote: > On Wed, Aug 12, 2020 at 09:29:12AM +0300, Vladimir Zapolskiy wrote: >> On 8/12/20 4:31 AM, Michał Mirosław wrote: > [...] >>> config = kmemdup(cfg, sizeof(*cfg), GFP_KERNEL); >>> if (config == NULL

Re: [PATCH v2 5/7] regulator: plug of_node leak in regulator_register()'s error path

ixes: 9177514ce349 ("regulator: fix memory leak on error path of > regulator_register()") > Signed-off-by: Michał Mirosław > Acked-by: Vladimir Zapolskiy > --- > drivers/regulator/core.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) >

Re: [PATCH 5/7] regulator: plug of_node leak in regulator_register()'s error path

e fuzzing. The change looks valid and it's a nice simplification. Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

[PATCH] regulator: fix memory leak on error path of regulator_register()

all be removed to exclude a double free condition. Fixes: a3cde9534ebd ("regulator: core: fix regulator_register() error paths to properly release rdev") Cc: Wen Yang Signed-off-by: Vladimir Zapolskiy --- drivers/regulator/core.c | 18 +++--- 1 file changed, 7 insertions(+

Re: [PATCH 12/32] usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions

x_udc *udc, struct lpc32xx_ep *ep) > | ^~~~~~ > > Cc: Felipe Balbi > Cc: Vladimir Zapolskiy > Cc: Sylvain Lemieux > Cc: Kevin Wells > Cc: Roland Stigge > Signed-off-by: Lee Jones Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH] udc: lpc32xx: mark local function static

32xx_udc *udc, struct lpc32xx_ep *ep) > > This showed up after my commit 792e559e94bc ("udc: lpc32xx: fix 64-bit > compiler warning") made it possible to build the driver on x86-64. > > Fix the warning as suggested. > > Reported-by: kernel test robot > Signed-off-by: Arnd Bergmann Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [RFC,v2 2/6] i2c: add I2C Address Translator (ATR) support

Hi Wolfram, On 09/09/2019 10:22 AM, Wolfram Sang wrote: > Hi Vladimir, > >> I won't attend the LPC, however I would appreciate if you book some > > A pity. I would have liked to have you in the room. Let's see if we can > get enough input from you via mail here. > if it might help, I'll

Re: [RFC,v2 2/6] i2c: add I2C Address Translator (ATR) support

Hi Luca, Jacopo, Wolfram, Peter, On 09/08/2019 11:45 PM, Vladimir Zapolskiy wrote: > Hi Luca, Jacopo, Wolfram, Peter, > > On 09/01/2019 05:31 PM, jacopo mondi wrote: >> Hi Luca, >>thanks for keep pushing this series! I hope we can use part of this >> for the (lo

Re: [RFC,v2 2/6] i2c: add I2C Address Translator (ATR) support

Hi Luca, Jacopo, Wolfram, Peter, On 09/01/2019 05:31 PM, jacopo mondi wrote: > Hi Luca, >thanks for keep pushing this series! I hope we can use part of this > for the (long time) on-going GMSL work... > > I hope you will be patient enough to provide (another :) overview > of this work during

Re: [PATCH] ARM: lpc32xx: stop overwriting TEST_CLK_SEL

Hi Alexandre, Gregory, On 04/15/2019 10:59 AM, gregory.clem...@bootlin.com wrote: > On 2019-04-11 16:12, Alexandre Belloni wrote: >> While the UDA1380 is described in some lpc3250 device trees, there is >> currently no real user of that codec. Anyway, if the codec needs a >> clock, >> it should

Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource

_resource(>dev, res); > + a = devm_platform_ioremap_resource(pdev, index); > > Cc: Joel Stanley > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Florian Fainelli > Cc: Linus Walleij > Cc: Baruch Siach > Cc: Keguang Zhang > Cc: Vladimir Zapolskiy > Cc: Kevi

Re: [PATCH 18/42] drivers: gpio: lpc18xx: use devm_platform_ioremap_resource()

ce *res; > - > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - gc->base = devm_ioremap_resource(dev, res); > + gc->base = devm_platform_ioremap_resource(pdev, 0); > } else { > struct resource res; > > Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH serial] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()

; } > #endif > return ret; > + > +err_spi: > +#ifdef CONFIG_SERIAL_SC16IS7XX_I2C > + i2c_del_driver(_i2c_uart_driver); > +#endif > +err_i2c: > + uart_unregister_driver(_uart); > + return ret; > } > module_init(sc16is7xx_init); > > Nice catch, thank you! Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH] pinctrl: remove unused 'pinconf-config' debugfs interface

Hi Linus, On 01/28/2019 02:36 PM, Linus Walleij wrote: > On Sun, Jan 20, 2019 at 4:14 PM Vladimir Zapolskiy wrote: > >> The main goal of the change is to remove .pin_config_dbg_parse_modify >> callback before a driver with its support appears. So far the in-kernel >> i

Re: [PATCH] tty: serial: lpc32xx_hs: fix missing console boot messages

ate > to get the kernel boot messages before userspace opens the device. > > Also get out of loopback mode in lpc32xx_hsuart_console_setup(). > > Signed-off-by: Alexandre Belloni the change looks good, thank you. Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

[PATCH v2 2/2] pinctrl: remove unused 'pinconf-config' debugfs interface

g_dbg_parse_modify callbacks to the drivers, but the whole idea of such a limited debug option looks inviable. A more flexible way to functionally substitute the original approach is to implicitly or explicitly use pinctrl_select_state() function whenever needed. Signed-off-by: Vladimir Zapols

[PATCH v2 1/2] pinctrl: remove pinctrl/machine.h inclusion from pinctrl/pinconf.h

nctrl/pinconfig: add debug interface"). Signed-off-by: Vladimir Zapolskiy Cc: Charles Keepax Cc: Richard Fitzgerald --- Changes from v1 to v2: * new change to mitigate a compile time warning caused by a removal of implicit header inclusion, the issue was reported against v1 change. This ch

[PATCH v2 0/2] pinctrl: remove unused 'pinconf-config' debugfs interface

file is plainly unusable on vanilla, I won't expect any user reports or asks to restore it back, this my assumption nudges me not to add an RFC tag to the published change. Changes from v1 to v2: * added one patch against cirrus/pinctrl-madera-core.c to avoid a compile time warning due to a removed h

[PATCH] pinctrl: remove unused 'pinconf-config' debugfs interface

g_dbg_parse_modify callbacks to the drivers, but the whole idea of such a limited debug option looks inviable. A more flexible way to functionally substitute the original approach is to implicitly or explicitly use pinctrl_select_state() function whenever needed. Signed-off-by: Vladimir Zapols

Re: RFC: gpio: mmio: add support for 3 direction regs

On 01/03/2019 10:51 AM, Fried, Ramon wrote: > > On 1/3/2019 10:07, Vladimir Zapolskiy wrote: >> Hi Ramon, >> >> On 01/03/2019 09:36 AM, Fried, Ramon wrote: >>> Hi. >>> >>> I'm working on a driver for STA2X11 GPIO controller who seems to fit >

Re: RFC: gpio: mmio: add support for 3 direction regs

Hi Ramon, On 01/03/2019 09:36 AM, Fried, Ramon wrote: > Hi. > > I'm working on a driver for STA2X11 GPIO controller who seems to fit > best to the generic mmio driver, I hope you have seen the existing driver drivers/gpio/gpio-sta2x11.c > the only problem I have is with the dir register case.

Re: [PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support

On 12/10/2018 10:14 AM, Matti Vaittinen wrote: > Add level active IRQ support to regmap-irq irqchip. Change breaks > existing regmap-irq type setting. Convert the existing drivers which > use regmap-irq with trigger type setting (gpio-max77620) to work > with this new approach. So we do not

Re: [PATCH linux-next v2 6/6] ASoC: rsnd: add avb clocks

Hi Jiada, On 12/03/2018 01:24 PM, jiada_w...@mentor.com wrote: > From: Jiada Wang > > There are AVB Counter Clocks in ADG, each clock has 12bits integral > and 8 bits fractional dividers which operates with S0D1ϕ clock. > > This patch registers 8 AVB Counter Clocks when clock-cells of >

Re: [PATCH linux-next v2 6/6] ASoC: rsnd: add avb clocks

Hi Jiada, On 12/03/2018 01:24 PM, jiada_w...@mentor.com wrote: > From: Jiada Wang > > There are AVB Counter Clocks in ADG, each clock has 12bits integral > and 8 bits fractional dividers which operates with S0D1ϕ clock. > > This patch registers 8 AVB Counter Clocks when clock-cells of >

Re: [PATCH linux-next v2 5/6] dt-bindings: clock: add clock id for renesas adg clocks

Hi Jiada, On 12/03/2018 01:24 PM, jiada_w...@mentor.com wrote: > From: Jiada Wang > > This patch adds clock ID for renesas adg clocks > > Signed-off-by: Jiada Wang > --- > include/dt-bindings/clock/renesas-adg.h | 11 +++ > 1 file changed, 11 insertions(+) > create mode 100644

Re: [PATCH linux-next v2 5/6] dt-bindings: clock: add clock id for renesas adg clocks

Hi Jiada, On 12/03/2018 01:24 PM, jiada_w...@mentor.com wrote: > From: Jiada Wang > > This patch adds clock ID for renesas adg clocks > > Signed-off-by: Jiada Wang > --- > include/dt-bindings/clock/renesas-adg.h | 11 +++ > 1 file changed, 11 insertions(+) > create mode 100644

Re: [PATCH linux-next v2 0/6] clk: renesas: adg: add AVB Clock

Hi Jiada, On 12/03/2018 01:21 PM, jiada_w...@mentor.com wrote: > From: Jiada Wang > > on R-Car SoCs there are AVB Counter Clocks, each clock has 12bits integral > and 8 bits fractional dividers which operates with S0D1ϕ clock. > > This patch-set adds 'adg' clock to R-Car Soc, and changes adg

Re: [PATCH linux-next v2 0/6] clk: renesas: adg: add AVB Clock

Hi Jiada, On 12/03/2018 01:21 PM, jiada_w...@mentor.com wrote: > From: Jiada Wang > > on R-Car SoCs there are AVB Counter Clocks, each clock has 12bits integral > and 8 bits fractional dividers which operates with S0D1ϕ clock. > > This patch-set adds 'adg' clock to R-Car Soc, and changes adg

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

eral Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > */ > > #include For lpc18xx/lpc32xx: Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

eral Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > */ > > #include For lpc18xx/lpc32xx: Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir

[PATCH] gpio: restore original GPLv2+ license of gpiolib-of.c sources

It's easy to verify that the change of drivers/gpio/gpiolib-of.c license header to SPDX standard changes the license from GPLv2+ to GPLv2, and this change corrects it. Fixes: dae5f0afcfc3 ("gpio: Use SPDX header for core library") Signed-off-by: Vladimir Zapolskiy --- drivers/gpio/gp

[PATCH] gpio: restore original GPLv2+ license of gpiolib-of.c sources

It's easy to verify that the change of drivers/gpio/gpiolib-of.c license header to SPDX standard changes the license from GPLv2+ to GPLv2, and this change corrects it. Fixes: dae5f0afcfc3 ("gpio: Use SPDX header for core library") Signed-off-by: Vladimir Zapolskiy --- drivers/gpio/gp

Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Adding Clément. On 11/04/2018 04:46 PM, Shawn Guo wrote: > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: >> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) >> function blocks. Add their ipg and per clocks to the device tree. >> >> Signed-off-by: Martin Kaiser >

Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Adding Clément. On 11/04/2018 04:46 PM, Shawn Guo wrote: > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: >> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) >> function blocks. Add their ipg and per clocks to the device tree. >> >> Signed-off-by: Martin Kaiser >

Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Hi Martin, On 11/01/2018 07:32 PM, Martin Kaiser wrote: > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > function blocks. Add their ipg and per clocks to the device tree. > > Signed-off-by: Martin Kaiser the change is obviously correct. Reviewed-by: Vladim

Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Hi Martin, On 11/01/2018 07:32 PM, Martin Kaiser wrote: > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > function blocks. Add their ipg and per clocks to the device tree. > > Signed-off-by: Martin Kaiser the change is obviously correct. Reviewed-by: Vladim

Re: [PATCH] pinctrl: lpc18xx: Use define directive for PIN_CONFIG_GPIO_PIN_INT

Hi Nathan, thank you for your patch. On 11/01/2018 02:52 AM, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/pinctrl/pinctrl-lpc18xx.c:643:29: warning: implicit conversion > from enumeration type 'enum lpc18xx_pin_config_param' to

Re: [PATCH] pinctrl: lpc18xx: Use define directive for PIN_CONFIG_GPIO_PIN_INT

Hi Nathan, thank you for your patch. On 11/01/2018 02:52 AM, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/pinctrl/pinctrl-lpc18xx.c:643:29: warning: implicit conversion > from enumeration type 'enum lpc18xx_pin_config_param' to

Re: [PATCH 3/7] dt-bindings: pinctrl: ds90ux9xx: add description of TI DS90Ux9xx pinmux

Hi Luca, On 10/30/2018 06:44 PM, Luca Ceresoli wrote: > Hi Vladimir, > > On 16/10/18 14:48, Laurent Pinchart wrote: >> Hi Vladimir, >> >> On Saturday, 13 October 2018 16:47:48 EEST Vladimir Zapolskiy wrote: >>> On 10/12/2018 03:01 PM, Laurent Pinchart wrote: &

Re: [PATCH 3/7] dt-bindings: pinctrl: ds90ux9xx: add description of TI DS90Ux9xx pinmux

Hi Luca, On 10/30/2018 06:44 PM, Luca Ceresoli wrote: > Hi Vladimir, > > On 16/10/18 14:48, Laurent Pinchart wrote: >> Hi Vladimir, >> >> On Saturday, 13 October 2018 16:47:48 EEST Vladimir Zapolskiy wrote: >>> On 10/12/2018 03:01 PM, Laurent Pinchart wrote: &

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

Hi Laurent, On 10/12/2018 02:59 PM, Vladimir Zapolskiy wrote: > Hello Laurent. > > On 10/12/2018 04:01 PM, Laurent Pinchart wrote: >> Hello Vladimir, >> ... >> then move to the driver side. In that area I would like to have a full >> example >> of a sy

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

Hi Laurent, On 10/12/2018 02:59 PM, Vladimir Zapolskiy wrote: > Hello Laurent. > > On 10/12/2018 04:01 PM, Laurent Pinchart wrote: >> Hello Vladimir, >> ... >> then move to the driver side. In that area I would like to have a full >> example >> of a sy

Re: [PATCH 3/7] dt-bindings: pinctrl: ds90ux9xx: add description of TI DS90Ux9xx pinmux

Hi Laurent, thank you for review, please find my comments below. On 10/12/2018 03:01 PM, Laurent Pinchart wrote: > Hi Vladimir, > > Thank you for the patch. > > On Tuesday, 9 October 2018 00:12:01 EEST Vladimir Zapolskiy wrote: >> From: Vladimir Zapolskiy >> >

Re: [PATCH 3/7] dt-bindings: pinctrl: ds90ux9xx: add description of TI DS90Ux9xx pinmux

Hi Laurent, thank you for review, please find my comments below. On 10/12/2018 03:01 PM, Laurent Pinchart wrote: > Hi Vladimir, > > Thank you for the patch. > > On Tuesday, 9 October 2018 00:12:01 EEST Vladimir Zapolskiy wrote: >> From: Vladimir Zapolskiy >> >

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

On 10/12/2018 02:43 PM, Lee Jones wrote: > On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > >> On 10/12/2018 11:39 AM, Lee Jones wrote: >>> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: >>>> On 10/12/2018 09:03 AM, Lee Jones wrote: >>>>&g

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

On 10/12/2018 02:43 PM, Lee Jones wrote: > On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > >> On 10/12/2018 11:39 AM, Lee Jones wrote: >>> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: >>>> On 10/12/2018 09:03 AM, Lee Jones wrote: >>>>&g

[PATCH] MAINTAINERS: Assign myself as a maintainer of ARM/LPC18XX architecture

ich is also under my wing, in other words LPC18xx/LPC43xx clocksource and CCF drivers will remain maintained. Signed-off-by: Vladimir Zapolskiy Cc: Joachim Eastwood --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 57e78e400fd3.

[PATCH] MAINTAINERS: Assign myself as a maintainer of ARM/LPC18XX architecture

ich is also under my wing, in other words LPC18xx/LPC43xx clocksource and CCF drivers will remain maintained. Signed-off-by: Vladimir Zapolskiy Cc: Joachim Eastwood --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 57e78e400fd3.

Re: [PATCH] MAINTAINERS: Set ARM/LPC18XX architecture orphan

Hi Arnd, Joachim, On 09/24/2018 04:19 PM, Arnd Bergmann wrote: > On Mon, Sep 24, 2018 at 6:43 AM Daniel Lezcano > wrote: >> >> While sending patches around, Joachim Eastwood was Cc'ed but I got an error >> its mailbox was full and the mail can not be delivered which makes me think >> there is

Re: [PATCH] MAINTAINERS: Set ARM/LPC18XX architecture orphan

Hi Arnd, Joachim, On 09/24/2018 04:19 PM, Arnd Bergmann wrote: > On Mon, Sep 24, 2018 at 6:43 AM Daniel Lezcano > wrote: >> >> While sending patches around, Joachim Eastwood was Cc'ed but I got an error >> its mailbox was full and the mail can not be delivered which makes me think >> there is

Re: [PATCH] mmc: mxcmmc: replace spin_lock_irqsave with spin_lock in ISR

On 09/11/2018 05:47 PM, jun qian wrote: > As you are already in ISR, it is unnecessary to call spin_lock_irqsave. > > Signed-off-by: jun qian Reviewed-by: Vladimir Zapolskiy --- Best wishes, Vladimir

Re: [PATCH] mmc: mxcmmc: replace spin_lock_irqsave with spin_lock in ISR

On 09/11/2018 05:47 PM, jun qian wrote: > As you are already in ISR, it is unnecessary to call spin_lock_irqsave. > > Signed-off-by: jun qian Reviewed-by: Vladimir Zapolskiy --- Best wishes, Vladimir

Re: [PATCH] pinctrl: lpc18xx: mark expected switch fall-throughs

al -= 5; > + /* fall through */ > case 8: param_val -= 3; > + /* fall through */ > case 4: param_val -= 4; >break; > default: > The code snippets are about a mind-blowing hyper-optimization, but I took it as a chance to verify the correctness, and there are no issues found. Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH] pinctrl: lpc18xx: mark expected switch fall-throughs

al -= 5; > + /* fall through */ > case 8: param_val -= 3; > + /* fall through */ > case 4: param_val -= 4; >break; > default: > The code snippets are about a mind-blowing hyper-optimization, but I took it as a chance to verify the correctness, and there are no issues found. Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

Hi zhong jiang, On 08/10/2018 05:40 AM, zhong jiang wrote: > kmemdup is better than kmalloc() + memcpy(), and we do not like > open code. So just use kmemdup instead. > > Signed-off-by: zhong jiang > --- > arch/arm/mach-lpc32xx/pm.c | 7 ++- > 1 file changed, 2 insertions(+), 5

Re: [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

Hi zhong jiang, On 08/10/2018 05:40 AM, zhong jiang wrote: > kmemdup is better than kmalloc() + memcpy(), and we do not like > open code. So just use kmemdup instead. > > Signed-off-by: zhong jiang > --- > arch/arm/mach-lpc32xx/pm.c | 7 ++- > 1 file changed, 2 insertions(+), 5

Re: [PATCH] dt-bindings: remove 'interrupt-parent' from bindings

Hi Rob, On 07/24/2018 01:13 AM, Rob Herring wrote: > 'interrupt-parent' is often documented as part of define bindings, but > it is really outside the scope of a device binding. It's never required > in a given node as it is often inherited from a parent node. Or it can > be implicit if a parent

Re: [PATCH] dt-bindings: remove 'interrupt-parent' from bindings

Hi Rob, On 07/24/2018 01:13 AM, Rob Herring wrote: > 'interrupt-parent' is often documented as part of define bindings, but > it is really outside the scope of a device binding. It's never required > in a given node as it is often inherited from a parent node. Or it can > be implicit if a parent

[PATCH] block: remove blkdev_entry_to_request() macro

Remove blkdev_entry_to_request() macro, which remained unused through the observable history, also note that it repeats list_entry_rq() macro verbatim. Signed-off-by: Vladimir Zapolskiy --- include/linux/blkdev.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/blkdev.h b

[PATCH] block: remove blkdev_entry_to_request() macro

Remove blkdev_entry_to_request() macro, which remained unused through the observable history, also note that it repeats list_entry_rq() macro verbatim. Signed-off-by: Vladimir Zapolskiy --- include/linux/blkdev.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/blkdev.h b

Re: [PATCH 2/2] misc: sram: enable clock before registering regions

On 07/03/2018 02:47 PM, Johan Hovold wrote: > On Tue, Jul 03, 2018 at 01:23:30PM +0300, Vladimir Zapolskiy wrote: >> Hi Johan, >> >> On 07/03/2018 01:05 PM, Johan Hovold wrote: >>> Make sure to enable the clock before registering regions and exporting >>> par

Re: [PATCH 2/2] misc: sram: enable clock before registering regions

On 07/03/2018 02:47 PM, Johan Hovold wrote: > On Tue, Jul 03, 2018 at 01:23:30PM +0300, Vladimir Zapolskiy wrote: >> Hi Johan, >> >> On 07/03/2018 01:05 PM, Johan Hovold wrote: >>> Make sure to enable the clock before registering regions and exporting >>> par

Re: [PATCH 2/2] misc: sram: enable clock before registering regions

Hi Johan, On 07/03/2018 01:05 PM, Johan Hovold wrote: > Make sure to enable the clock before registering regions and exporting > partitions to user space at which point we must be prepared for I/O. > > Fixes: ee895ccdf776 ("misc: sram: fix enabled clock leak on error path

Re: [PATCH 2/2] misc: sram: enable clock before registering regions

Hi Johan, On 07/03/2018 01:05 PM, Johan Hovold wrote: > Make sure to enable the clock before registering regions and exporting > partitions to user space at which point we must be prepared for I/O. > > Fixes: ee895ccdf776 ("misc: sram: fix enabled clock leak on error path

Re: [PATCH v6 4/5] clocksource: add driver for i.MX EPIT timer

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Colin Didier > > Add driver for NXP's EPIT timer used in i.MX SoC. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron Reviewed-by: Vladimir Zapolskiy Tested-by: Vladimir Zapolskiy I tested the driver on

Re: [PATCH v6 4/5] clocksource: add driver for i.MX EPIT timer

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Colin Didier > > Add driver for NXP's EPIT timer used in i.MX SoC. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron Reviewed-by: Vladimir Zapolskiy Tested-by: Vladimir Zapolskiy I tested the driver on

Re: [PATCH v6 5/5] ARM: dts: imx: add missing compatible and clock properties for EPIT

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Colin Didier > > Add missing compatible and clock properties for EPIT node. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v6 5/5] ARM: dts: imx: add missing compatible and clock properties for EPIT

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Colin Didier > > Add missing compatible and clock properties for EPIT node. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v6 0/5] Reintroduce i.MX EPIT Timer

Hi Clément, On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Clément Peron > > As suggested in the commit message we have added the device tree support, > proper bindings and we moved the driver into the correct folder. > > Moreover we made some changes like use of relaxed IO accesor, >

Re: [PATCH v6 2/5] ARM: imx: remove inexistant EPIT timer init

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Clément Peron > > i.MX EPIT timer has been removed but not the init function declaration. > > Signed-off-by: Clément Peron > Reviewed-by: Fabio Estevam Reviewed-by: Vladimir Zapolskiy Tested-by: Vladimir Zapolskiy -

Re: [PATCH v6 0/5] Reintroduce i.MX EPIT Timer

Hi Clément, On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Clément Peron > > As suggested in the commit message we have added the device tree support, > proper bindings and we moved the driver into the correct folder. > > Moreover we made some changes like use of relaxed IO accesor, >

Re: [PATCH v6 2/5] ARM: imx: remove inexistant EPIT timer init

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Clément Peron > > i.MX EPIT timer has been removed but not the init function declaration. > > Signed-off-by: Clément Peron > Reviewed-by: Fabio Estevam Reviewed-by: Vladimir Zapolskiy Tested-by: Vladimir Zapolskiy -

Re: [PATCH v6 3/5] dt-bindings: timer: add i.MX EPIT timer binding

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Clément Peron > > Add devicetree binding document for NXP's i.MX SoC specific > EPIT timer driver. > > Signed-off-by: Clément Peron Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v6 3/5] dt-bindings: timer: add i.MX EPIT timer binding

On 06/07/2018 05:05 PM, Clément Péron wrote: > From: Clément Peron > > Add devicetree binding document for NXP's i.MX SoC specific > EPIT timer driver. > > Signed-off-by: Clément Peron Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT

Hi Clément, On 05/31/2018 11:41 AM, Clément Péron wrote: > Hi Vladimir, > > On Thu, 31 May 2018 at 10:33, Vladimir Zapolskiy > wrote: >> >> On 05/30/2018 03:03 PM, Clément Péron wrote: >>> From: Colin Didier >>> >>> Add missing compatible and

Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT

Hi Clément, On 05/31/2018 11:41 AM, Clément Péron wrote: > Hi Vladimir, > > On Thu, 31 May 2018 at 10:33, Vladimir Zapolskiy > wrote: >> >> On 05/30/2018 03:03 PM, Clément Péron wrote: >>> From: Colin Didier >>> >>> Add missing compatible and

Re: [PATCH v4 4/5] clocksource: add driver for i.MX EPIT timer

Hi Clément, On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Colin Didier > > Add driver for NXP's EPIT timer used in i.MX 6 family of SoC. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron > --- [snip] > +++ b/drivers/clocksource/timer-imx-epit.c > @@ -0,0 +1,281 @@ > +//

Re: [PATCH v4 4/5] clocksource: add driver for i.MX EPIT timer

Hi Clément, On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Colin Didier > > Add driver for NXP's EPIT timer used in i.MX 6 family of SoC. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron > --- [snip] > +++ b/drivers/clocksource/timer-imx-epit.c > @@ -0,0 +1,281 @@ > +//

Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT

On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Colin Didier > > Add missing compatible and clock properties for EPIT node. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron > Reviewed-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6qdl.dtsi | 10 ++ > 1 file

Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT

On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Colin Didier > > Add missing compatible and clock properties for EPIT node. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron > Reviewed-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6qdl.dtsi | 10 ++ > 1 file

Re: [PATCH v4 3/5] Documentation: DT: add i.MX EPIT timer binding

Hi Clément, On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Clément Peron > > Add devicetree binding document for NXP's i.MX SoC specific > EPIT timer driver. > > Signed-off-by: Clément Peron > --- > .../devicetree/bindings/timer/fsl,imxepit.txt | 24 +++ > 1 file

Re: [PATCH v4 3/5] Documentation: DT: add i.MX EPIT timer binding

Hi Clément, On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Clément Peron > > Add devicetree binding document for NXP's i.MX SoC specific > EPIT timer driver. > > Signed-off-by: Clément Peron > --- > .../devicetree/bindings/timer/fsl,imxepit.txt | 24 +++ > 1 file

Re: [PATCH 4/5] clocksource: add driver for i.MX EPIT timer

Hi Clément, please find basic review comments below. On 05/28/2018 08:34 PM, Clément Péron wrote: > From: Colin Didier > > Add driver for NXP's EPIT timer used in i.MX 6 family of SoC. > The first author's signed-off-by tag is missing. > Signed-off-by: Clément Peron > --- >

Re: [PATCH 4/5] clocksource: add driver for i.MX EPIT timer

Hi Clément, please find basic review comments below. On 05/28/2018 08:34 PM, Clément Péron wrote: > From: Colin Didier > > Add driver for NXP's EPIT timer used in i.MX 6 family of SoC. > The first author's signed-off-by tag is missing. > Signed-off-by: Clément Peron > --- >

Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device

Hi Jan, Bjorn, On 05/15/2018 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Another step towards a managed version of > of_pci_get_host_bridge_resources(): Feed in the underlying device, > rather than just the OF node. This will allow to use managed resource >

Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device

Hi Jan, Bjorn, On 05/15/2018 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Another step towards a managed version of > of_pci_get_host_bridge_resources(): Feed in the underlying device, > rather than just the OF node. This will allow to use managed resource > allocation internally later

Re: [PATCH] PCI: Clean up resource allocation in devm_of_pci_get_host_bridge_resources()

> + continue; > + > + res = devm_kmemdup(dev, _res, sizeof(tmp_res), GFP_KERNEL); The change looks okay, apparently probable garbage in tmp_res.desc has no impact. Reviewed-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> -- With best wishes, Vladimir

Re: [PATCH] PCI: Clean up resource allocation in devm_of_pci_get_host_bridge_resources()

res = devm_kmemdup(dev, _res, sizeof(tmp_res), GFP_KERNEL); The change looks okay, apparently probable garbage in tmp_res.desc has no impact. Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

  1   2   3   4   5   6   7   8   9   >