Re: [PATCH] memory tier: rename destroy_memory_type() to put_memory_type()

2023-07-06 Thread Xiao Yang
he, I didn't find that destroy_memory_type(memtype) is called here on mainline kernel. Did I miss something? Other than that, it looks good to me. Reviewed-by: Xiao Yang Best Regards, Xiao Yang } mutex_unlock(_tier_lock); }

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-19 Thread Yang , Xiao/杨 晓
. https://lore.kernel.org/linux-xfs/20211129102203.2243509-1-...@lst.de/ 2) I can reproduce the failure of generic/482 without thin-volume. 3) Is it necessary to make thin-volume support DAX. Is there any use case for the requirement? Best Regards, Xiao Yang On 2022/9/16 10:04, Yang, Xiao/杨 晓

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-15 Thread Yang , Xiao/杨 晓
On 2022/9/15 18:14, Yang, Xiao/杨 晓 wrote: On 2022/9/15 0:28, Darrick J. Wong wrote: On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote: On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: On 2022/9/9 21:01, Brian Foster wrote

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-15 Thread Yang , Xiao/杨 晓
On 2022/9/15 0:28, Darrick J. Wong wrote: On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote: On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: On 2022/9/9 21:01, Brian Foster wrote: Yes.. I don't recall all the internals

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Yang , Xiao/杨 晓
On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: On 2022/9/9 21:01, Brian Foster wrote: Yes.. I don't recall all the internals of the tools and test, but IIRC it relied on discard to perform zeroing between checkpoints or some such and avoid spurious failures. The purpose of running on dm-thin

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Yang , Xiao/杨 晓
PMEM0(DAX) --- We think dm-thin device is not a good solution for generic/470, is there any other solution to support both discard zero and DAX? BTW, only log-writes, stripe and linear support DAX for now. Best Regards, Xiao Yang

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2021-02-02 Thread Xiao Ni
On 02/02/2021 11:42 AM, Matthew Ruffell wrote: Hi Xiao, On 24/12/20 11:18 pm, Xiao Ni wrote:> The root cause is found. Now we use a similar way with raid0 to handle discard request for raid10. Because the discard region is very big, we can calculate the start/end address for each d

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-24 Thread Xiao Ni
disks md/raid10: pull codes that wait for blocked dev into one function md/raid10: improve raid10 discard request md/raid10: improve discard request for far layout dm raid: fix discard limits for raid1 and raid10 dm raid: remove unnecessary discard limits for raid10 Thanks for the report! Hi Xiao

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-09 Thread Xiao Ni
disks md/raid10: pull codes that wait for blocked dev into one function md/raid10: improve raid10 discard request md/raid10: improve discard request for far layout dm raid: fix discard limits for raid1 and raid10 dm raid: remove unnecessary discard limits for raid10 Thanks for the report! Hi Xiao

Re: [PATCH v2 0/3] md superblock write alignment on 512e devices

2020-11-04 Thread Xiao Ni
On 11/04/2020 04:12 AM, Chris Unkel wrote: Hi Xiao, Thanks for the excellent feedback. Since bitmap_offset appears to be a free-form field, it wasn't apparent to me that the bitmap never starts within 4K of the bitmap. I don't think it's worth worrying about a logical block size that's

Re: [PATCH 0/3] mdraid sb and bitmap write alignment on 512e drives

2020-11-03 Thread Xiao Ni
On 11/03/2020 02:59 AM, Chris Unkel wrote: Hi Xiao, That particular array is super1.2. The block trace was captured on the disk underlying the partition device on which the md array member resides, not on the partition device itself. The partition starts 2048 sectors into the disk (1MB

Re: [PATCH 2/3] md: align superblock writes to physical blocks

2020-11-02 Thread Xiao Ni
e data and bitmap is before superblock. For super1.1 and 1.2 it only needs to check whether it runs into bitmap. The data is behind the bitmap. Regards Xiao /* * set rdev->sb_size to that required for number of devices in array * with appropriate padding to underlying sectors */

Re: [PATCH v2 0/3] md superblock write alignment on 512e devices

2020-11-01 Thread Xiao Ni
On 10/30/2020 04:13 AM, Christopher Unkel wrote: Hello, Thanks for the feedback on the previous patch series. A updated patch series with the same function as the first patch (https://lkml.org/lkml/2020/10/22/1058 "md: align superblock writes to physical blocks") follows. As suggested, it

Re: [PATCH 0/3] mdraid sb and bitmap write alignment on 512e drives

2020-11-01 Thread Xiao Ni
superblock? Regards Xiao Note that in some arrays the last page of the bitmap may be sufficiently full that they are not affected by the issue with the bitmap write. As there can be a substantial penalty to using the 512-byte sector emulation (turning writes into read-modify writes if the relev

Re: [PATCH] clk: rockchip: Fix overflow rate during fractional approximation

2020-09-14 Thread Finley Xiao
mation") commit <4186a0e4239b> ("clk: rockchip: Add supprot to limit input rate for fractional divider") Signed-off-by: Jagan Teki Signed-off-by: Finley Xiao --- drivers/clk/rockchip/clk-px30.c | 12 ++-- drivers/clk/rockchip/clk.c | 9 + 2 files changed, 1

[PATCH v1] thermal/of: Introduce k-po, k-pu and k-i for a thermal zone

2020-08-11 Thread Finley Xiao
, they will be parsed and associated with the thermal zone via the thermal zone parameters. Signed-off-by: Finley Xiao --- Documentation/devicetree/bindings/thermal/thermal.txt | 14 ++ drivers/thermal/thermal_of.c | 7 +++ 2 files changed, 21 insertions

[PATCH] thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power

2020-06-19 Thread Finley Xiao
}, { 120, 49, 0 }, { 1296000, 59, 0 }, { 1416000, 72, 0 }, { 1512000, 86, 0 }, }; The target frequency should be 1416000KHz, not 1512000KHz. Fixes: 349d39dc5739 ("thermal: cpu_cooling: merge frequency and power tables") Cc: # v4.13+ Signed-off-by: F

[PATCH] thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power

2020-06-18 Thread Finley Xiao
}, { 120, 49, 0 }, { 1296000, 59, 0 }, { 1416000, 72, 0 }, { 1512000, 86, 0 }, }; The target frequency should be 1416000KHz, not 1512000KHz. Fixes: 349d39dc5739 ("thermal: cpu_cooling: merge frequency and power tables") Signed-off-by: Finley Xiao --

Re: [PATCH] xfs/XXX: Add xfs/XXX

2020-06-02 Thread Xiao Yang
On 2020/6/3 2:14, Darrick J. Wong wrote: On Tue, Jun 02, 2020 at 04:51:48PM +0800, Xiao Yang wrote: On 2020/4/14 0:30, Darrick J. Wong wrote: This might be a good time to introduce a few new helpers: _require_scratch_dax ("Does $SCRATCH_DEV support DAX?") _require_scratch_dax_mount

Re: [PATCH] xfs/XXX: Add xfs/XXX

2020-06-02 Thread Xiao Yang
x implementation? 2) I think _require_xfs_io_command "chattr" "x" is enough to check if fs supports FS_XFLAG_DAX. Is it necessary to add _require_scratch_dax_iflag()? like this: _require_scratch_dax_iflag() { _require_xfs_io_command "chattr" "x" } Best Regards, Xiao Yang

Re: [PATCH V4 6/8] fs/ext4: Make DAX mount option a tri-state

2020-06-01 Thread Xiao Yang
On 2020/5/28 17:41, Jan Kara wrote: On Thu 28-05-20 16:56:51, Xiao Yang wrote: On 2020/5/28 7:50, Ira Weiny wrote: On Wed, May 27, 2020 at 01:54:54PM +0800, Xiao Yang wrote: On 2020/5/22 3:13, ira.we...@intel.com wrote: From: Ira Weiny We add 'always', 'never', and 'inode' (default). '-o

Re: [PATCH V4 6/8] fs/ext4: Make DAX mount option a tri-state

2020-05-28 Thread Xiao Yang
On 2020/5/28 7:50, Ira Weiny wrote: On Wed, May 27, 2020 at 01:54:54PM +0800, Xiao Yang wrote: On 2020/5/22 3:13, ira.we...@intel.com wrote: From: Ira Weiny We add 'always', 'never', and 'inode' (default). '-o dax' continues to operate the same which is equivalent to 'always'. This new

Re: [PATCH V4 6/8] fs/ext4: Make DAX mount option a tri-state

2020-05-26 Thread Xiao Yang
break; > + case Opt_dax_inode: > + sbi->s_mount_opt&= ~EXT4_MOUNT_DAX_ALWAYS; > + sbi->s_mount_opt2&= ~EXT4_MOUNT2_DAX_NEVER; > + /* Strictly for printing options */ > + sbi->s_mount_op

Re: [PATCH v2] tools/perf/util/*.c: Use "%zu" output format for size_t type

2020-05-11 Thread Xiao Yang
Hi, Ping! Thanks, Xiao Yang On 2020/2/26 9:08, Xiao Yang wrote: > Avoid the following errors when building perf on i386: > --- > util/session.c: In function 'perf_session__process_compressed_event': > util/session.c:91:11: error: format '

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-11 Thread Xiao Yang
On 2020/5/7 17:15, Masami Hiramatsu wrote: On Thu, 7 May 2020 14:45:16 +0800 Xiao Yang wrote: On 2020/5/1 21:38, Masami Hiramatsu wrote: Since the built-in echo has different behavior in POSIX shell (dash) and bash, we forcibly use /bin/echo -E (not interpret backslash escapes) by default

Re: [PATCH] tracing: Wait for preempt irq delay thread to finish

2020-05-07 Thread Xiao Yang
preemptirq_delay_test in loops. 3) Ran irqsoff_tracer.tc in loops. BTW: For irqsoff_tracer.tc, should we extend code to test the burst feature and the sysfs trigger? Reviewed-by: Xiao Yang Thanks, Xiao Yang On 2020/5/6 22:30, Steven Rostedt wrote: From: "Steven Rostedt (VMware)"

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Xiao Yang
currently. Is it necessary for all tests to use /bin/echo and could we just make kprobe_syntax_errors.tc use /bin/echo? Best Regards, Xiao Yang clear_trace() { # reset trace output echo> trace diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-hist.tc b/

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-29 Thread Xiao Yang
est; done for i in $(seq 1 100); do modprobe preemptirq_delay_test test_mode=preempt delay=50; rmmod preemptirq_delay_test; done - But I am not sure which fix(from you and Joel) is better. Thanks, Xiao Yang

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-29 Thread Xiao Yang
one --- Thanks, Xiao Yang

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-29 Thread Xiao Yang
[ 178.658903] Memory Limit: none [ 178.659263] ---[ end Kernel panic - not syncing: Fatal exception ]--- --- Thanks, Xiao Yang On 2020/4/28 18:19, Xiao Yang wrote: > Hi Joel, > > Thanks for your quick fix. > > Unfortunately, it fi

Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-29 Thread Xiao Yang
Hi Lin, It looks fine to me. Reviewed-by: Xiao Yang Thanks, Xiao Yang On 2020/4/29 17:50, Po-Hsu Lin wrote: > When the required module for the test does not exist, use > exit_unsupported instead of exit_unresolved to indicate this test is > not supported. > > By doing this w

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-28 Thread Xiao Yang
[ 3465.524939] Memory Limit: none [ 3465.525534] ---[ end Kernel panic - not syncing: Fatal exception ]--- I am looking into these issues. Thanks, Xiao Yang On 2020/4/25 6:36, Joel Fernandes (Google) wrote: > Kthread runn

[PATCH v1 3/3] clk: rockchip: Add clock controller for the RK3308

2019-09-03 Thread Finley Xiao
Add the clock tree definition for the new RK3308 SoC. Signed-off-by: Finley Xiao --- drivers/clk/rockchip/Makefile | 1 + drivers/clk/rockchip/clk-rk3308.c | 955 ++ drivers/clk/rockchip/clk.h| 13 + 3 files changed, 969 insertions(+) create

[PATCH v1 1/3] dt-bindings: Add bindings for rk3308 clock controller

2019-09-03 Thread Finley Xiao
Add devicetree bindings for Rockchip cru which found on Rockchip SoCs. Signed-off-by: Finley Xiao --- .../devicetree/bindings/clock/rockchip,rk3308.txt | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3308.txt

[PATCH v1 0/3] clk: rockchip: support clock controller for rk3308 SoC

2019-09-03 Thread Finley Xiao
Finley Xiao (3): dt-bindings: Add bindings for rk3308 clock controller clk: rockchip: Add dt-binding header for rk3308 clk: rockchip: Add clock controller for the RK3308 .../devicetree/bindings/clock/rockchip,rk3308.txt | 58 ++ drivers/clk/rockchip/Makefile | 1

[PATCH v1 2/3] clk: rockchip: Add dt-binding header for rk3308

2019-09-03 Thread Finley Xiao
Add the dt-bindings header for the rk3308, that gets shared between the clock controller and the clock references in the dts. Signed-off-by: Finley Xiao --- include/dt-bindings/clock/rk3308-cru.h | 387 + 1 file changed, 387 insertions(+) create mode 100644

[PATCH] kbuild: Remove unused variable TMPO of ld-option

2019-08-06 Thread Xiao Yang
ld-option implementation has been simplified so variable TMPO is no longer needed. Fixes: Commit 0294e6f4a000 ("kbuild: simplify ld-option implementation") Signed-off-by: Xiao Yang --- scripts/Kbuild.include | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH v1 1/3] net: hisilicon: make hip04_tx_reclaim non-reentrant

2019-08-05 Thread Jiangfeng Xiao
On 2019/8/6 8:46, Jakub Kicinski wrote: > On Sat, 3 Aug 2019 20:31:39 +0800, Jiangfeng Xiao wrote: >> If hip04_tx_reclaim is interrupted while it is running >> and then __napi_schedule continues to execute >> hip04_rx_poll->hip04_tx_reclaim, reentrancy occurs >>

[PATCH v1 0/3] net: hisilicon: Fix a few problems with hip04_eth

2019-08-03 Thread Jiangfeng Xiao
During the use of the hip04_eth driver, several problems were found, which solved the hip04_tx_reclaim reentry problem, fixed the problem that hip04_mac_start_xmit never returns NETDEV_TX_BUSY and the dma_map_single failed on the arm64 platform. Jiangfeng Xiao (3): net: hisilicon: make

[PATCH v1 2/3] net: hisilicon: fix hip04-xmit never return TX_BUSY

2019-08-03 Thread Jiangfeng Xiao
imum value of tx_count can reach (TX_DESC_NUM - 1), then hip04_mac_start_xmit can reurn NETDEV_TX_BUSY. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/d

[PATCH v1 3/3] net: hisilicon: Fix dma_map_single failed on arm64

2019-08-03 Thread Jiangfeng Xiao
we use dma_map_single, the first parameter is to use the device of platform_device. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c

[PATCH v1 1/3] net: hisilicon: make hip04_tx_reclaim non-reentrant

2019-08-03 Thread Jiangfeng Xiao
nic - not syncing: Fatal exception in interrupt CPU3: stopping CPU: 3 PID: 0 Comm: swapper/3 Tainted: G DO4.4.185 #1 Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ether

[PATCH] net: hisilicon: Use devm_platform_ioremap_resource

2019-07-12 Thread Jiangfeng Xiao
Use devm_platform_ioremap_resource instead of devm_ioremap_resource. Make the code simpler. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c| 7 ++- drivers/net/ethernet/hisilicon/hisi_femac.c | 7 ++- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 7

Re: [PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-09 Thread Jiangfeng Xiao
On 2019/7/9 21:48, Jiangfeng Xiao wrote: > > > On 2019/7/9 17:35, Sergei Shtylyov wrote: >> Hello! >> >> On 09.07.2019 6:31, Jiangfeng Xiao wrote: >> [...] >>> @@ -853,6 +867,15 @@ static int hip04_mac_probe(struct platform_devic

Re: [PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-09 Thread Jiangfeng Xiao
On 2019/7/9 17:35, Sergei Shtylyov wrote: > Hello! > > On 09.07.2019 6:31, Jiangfeng Xiao wrote: > >> HI13X1_GMAC delete request for soft reset at first, >> otherwise, the subsequent initialization will not >> take effect. >> >> Signed-off-by: Jiangf

[PATCH v2 00/10] net: hisilicon: Add support for HI13X1 to hip04_eth

2019-07-08 Thread Jiangfeng Xiao
soc. So the macro of the register offset is redefined to adapt the HI13X1_GMAC. Clean up the sparse warning by the way. Change since v1: * Add a cover letter. Jiangfeng Xiao (10): net: hisilicon: Add support for HI13X1 to hip04_eth net: hisilicon: Cleanup for got restricted __be32 net

[PATCH v2 10/10] net: hisilicon: Add an tx_desc to adapt HI13X1_GMAC

2019-07-08 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for tx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions

[PATCH v2 04/10] net: hisilicon: HI13X1_GMAX skip write LOCAL_PAGE_REG

2019-07-08 Thread Jiangfeng Xiao
HI13X1_GMAC changed the offsets and bitmaps for GE_TX_LOCAL_PAGE_REG registers in the same peripheral device on different models of the hip04_eth. With the default configuration, HI13X1_GMAC can also work without any writes to the GE_TX_LOCAL_PAGE_REG register. Signed-off-by: Jiangfeng Xiao

[PATCH v2 07/10] net: hisilicon: Add group field to adapt HI13X1_GMAC

2019-07-08 Thread Jiangfeng Xiao
In general, group is the same as the port, but some boards specify a special group for better load balancing of each processing unit. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 09/10] net: hisilicon: Add an rx_desc to adapt HI13X1_GMAC

2019-07-08 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for rx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet

[PATCH v2 01/10] net: hisilicon: Add support for HI13X1 to hip04_eth

2019-07-08 Thread Jiangfeng Xiao
Extend the hip04_eth driver to support HI13X1_GMAC. Enable it with CONFIG_HI13X1_GMAC option. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/Kconfig | 10 drivers/net/ethernet/hisilicon/hip04_eth.c | 37 -- 2 files changed, 40

[PATCH v2 08/10] net: hisilicon: Offset buf address to adapt HI13X1_GMAC

2019-07-08 Thread Jiangfeng Xiao
that it is valid. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index 5328219..c578934 100644

[PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-08 Thread Jiangfeng Xiao
HI13X1_GMAC delete request for soft reset at first, otherwise, the subsequent initialization will not take effect. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/ethernet

[PATCH v2 06/10] net: hisilicon: dt-bindings: Add an field of port-handle

2019-07-08 Thread Jiangfeng Xiao
In general, group is the same as the port, but some boards specify a special group for better load balancing of each processing unit. Signed-off-by: Jiangfeng Xiao --- Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH v2 03/10] net: hisilicon: Cleanup for cast to restricted __be32

2019-07-08 Thread Jiangfeng Xiao
__be32 Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index 31f13cf..d8f0619 100644 --- a/drivers/net

[PATCH v2 02/10] net: hisilicon: Cleanup for got restricted __be32

2019-07-08 Thread Jiangfeng Xiao
:472:23: warning: incorrect type in assignment hip04_eth.c:472:23:expected unsigned int [usertype] wb_addr hip04_eth.c:472:23:got restricted __be32 [usertype] Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH] net: hisilicon: Add an tx_desc to adapt HI13X1_GMAC

2019-07-08 Thread Jiangfeng Xiao
On 2019/7/9 2:18, David Miller wrote: > From: David Miller > Date: Sun, 07 Jul 2019 22:18:05 -0700 (PDT) > >> From: Jiangfeng Xiao >> Date: Fri, 5 Jul 2019 14:10:03 +0800 >> >>> HI13X1 changed the offsets and bitmaps for tx_desc >>> registe

[PATCH 09/10] net: hisilicon: Add an rx_desc to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for rx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet

[PATCH 10/10] net: hisilicon: Add an tx_desc to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for tx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions

[PATCH 08/10] net: hisilicon: Offset buf address to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
that it is valid. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index 5328219..c578934 100644

[PATCH 06/10] net: hisilicon: dt-bindings: Add an field of port-handle

2019-07-05 Thread Jiangfeng Xiao
In general, group is the same as the port, but some boards specify a special group for better load balancing of each processing unit. Signed-off-by: Jiangfeng Xiao --- Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH 07/10] net: hisilicon: Add group field to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
In general, group is the same as the port, but some boards specify a special group for better load balancing of each processing unit. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-05 Thread Jiangfeng Xiao
HI13X1_GMAC delete request for soft reset at first, otherwise, the subsequent initialization will not take effect. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/ethernet

[PATCH 04/10] net: hisilicon: HI13X1_GMAX skip write LOCAL_PAGE_REG

2019-07-05 Thread Jiangfeng Xiao
HI13X1_GMAC changed the offsets and bitmaps for GE_TX_LOCAL_PAGE_REG registers in the same peripheral device on different models of the hip04_eth. With the default configuration, HI13X1_GMAC can also work without any writes to the GE_TX_LOCAL_PAGE_REG register. Signed-off-by: Jiangfeng Xiao

[PATCH 01/10] net: hisilicon: Add support for HI13X1 to hip04_eth

2019-07-05 Thread Jiangfeng Xiao
Extend the hip04_eth driver to support HI13X1_GMAC. Enable it with CONFIG_HI13X1_GMAC option. HI13X1 changed the offsets and bitmaps for registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/Kconfig

[PATCH 02/10] net: hisilicon: Cleanup for got restricted __be32

2019-07-05 Thread Jiangfeng Xiao
:472:23: warning: incorrect type in assignment hip04_eth.c:472:23:expected unsigned int [usertype] wb_addr hip04_eth.c:472:23:got restricted __be32 [usertype] Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 03/10] net: hisilicon: Cleanup for cast to restricted __be32

2019-07-05 Thread Jiangfeng Xiao
__be32 Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index 31f13cf..d8f0619 100644 --- a/drivers/net

[PATCH] net: hisilicon: Add an tx_desc to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for tx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions

Re: [PATCH] irqchip/gic: Add dependency for ARM_GIC

2019-06-27 Thread Jiangfeng Xiao
On 2019/6/27 22:20, Marc Zyngier wrote: > On 27/06/2019 15:11, Jiangfeng Xiao wrote: >> Not every arch has ARM_GIC, it is strange >> to see ARM_GIC_MAX_NR in the .config file >> of the x86 and IA-64 architecture. so fix >> build by adding necessary dependency. >

[PATCH] irqchip/gic: Add dependency for ARM_GIC

2019-06-27 Thread Jiangfeng Xiao
Not every arch has ARM_GIC, it is strange to see ARM_GIC_MAX_NR in the .config file of the x86 and IA-64 architecture. so fix build by adding necessary dependency. Signed-off-by: Jiangfeng Xiao --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip

[PATCH] irqchip/gic: Add dependency for ARM_GIC_MAX_NR

2019-06-14 Thread Jiangfeng Xiao
CONFIG_ARM_GIC_MAX_NR is enabled by default. It is redundant in x86 and IA-64 where is without GIC. Signed-off-by: Jiangfeng Xiao --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 659c5e0..e338b471 100644

[PATCH] PCI/hotplug: fix potential null pointer deference

2019-06-14 Thread Young Xiao
There is otherwise a risk of a null pointer dereference. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/pci/hotplug/cpqphp_ctrl.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pci/hotplug/cpqphp_ctrl.c b/drivers/pci/hotplug/cpqphp_

[PATCH] drm/amd: fix hotplug race at startup

2019-06-14 Thread Young Xiao
We should check mode_config_initialized flag in amdgpu_hotplug_work_func. See commit 7f98ca454ad3 ("drm/radeon: fix hotplug race at startup") for details. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 +++ 1 file changed, 3 ins

[PATCH] scsi: bnx2fc: Check if sense buffer has been allocated during completion

2019-06-14 Thread Young Xiao
sc_cmd->sense_buffer is not guaranteed to be allocated so we need to sc_cmd->check if the pointer is NULL before trying to copy anything into it. See commit 16a611154dc1 ("scsi: qedf: Check if sense buffer has been allocated during completion") for details. Signed-off-by: Yo

[PATCH] af_key: Fix memory leak in key_notify_policy.

2019-06-14 Thread Young Xiao
We leak the allocated out_skb in case pfkey_xfrm_policy2msg() fails. Fix this by freeing it on error. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- net/key/af_key.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/key/af_key.c b/net/key/af_key.c index 4af1e1d..ec414f6

[PATCH] nfc: Ensure presence of required attributes in the deactivate_target handler

2019-06-14 Thread Young Xiao
of these attributes. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- net/nfc/netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index 04a8e47..89d885d 100644 --- a/net/nfc/netlink.c +++ b/net/nfc/netlink.c @@ -923,7

Re: [PATCH v3 1/9] Documentation: Introduce EPT based Subpage Protection

2019-06-09 Thread Jidong Xiao
On Fri, Jun 7, 2019 at 7:12 AM Yang Weijiang wrote: > > On Thu, Jun 06, 2019 at 09:57:00PM -0600, Jidong Xiao wrote: > > Hi, Weijiang, > > > > Does this require some specific Intel processors or is it supported by > > older processors as well? > > > >

Re: [PATCH v3 1/9] Documentation: Introduce EPT based Subpage Protection

2019-06-06 Thread Jidong Xiao
Hi, Weijiang, Does this require some specific Intel processors or is it supported by older processors as well? -Jidong On Thu, Jun 6, 2019 at 9:33 AM Yang Weijiang wrote: > > Signed-off-by: Yang Weijiang > --- > Documentation/virtual/kvm/spp_kvm.txt | 216 ++ > 1 file

Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-06-05 Thread xiang xiao
On Wed, Jun 5, 2019 at 4:02 PM Arnaud Pouliquen wrote: > > > > On 6/5/19 4:40 AM, xiang xiao wrote: > > On Tue, Jun 4, 2019 at 10:25 PM Arnaud Pouliquen > > wrote: > >> > >> Hello Xiang, > >> > >> On 5/9/19 3:00 PM, xiang xiao

Re: [PATCH 0/3] Enhance virtio rpmsg bus driver buffer allocation

2019-06-05 Thread xiang xiao
On Wed, Jun 5, 2019 at 3:33 PM Arnaud Pouliquen wrote: > > Hi Bjorn, > > On 6/5/19 6:34 AM, Bjorn Andersson wrote: > > On Thu 31 Jan 07:41 PST 2019, Xiang Xiao wrote: > > > >> Hi, > >> This series enhance the buffer allocation by: > >> 1.Sup

Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-06-04 Thread xiang xiao
On Tue, Jun 4, 2019 at 10:25 PM Arnaud Pouliquen wrote: > > Hello Xiang, > > On 5/9/19 3:00 PM, xiang xiao wrote: > > On Thu, May 9, 2019 at 8:36 PM Arnaud Pouliquen > > wrote: > >> > >> Hello Xiang, > >> > >> Similar mechanism has bee

Re: [PATCH] net: compat: fix msg_controllen overflow in scm_detach_fds_compat()

2019-06-04 Thread Yang Xiao
On Tue, Jun 4, 2019 at 8:46 PM Daniel Borkmann wrote: > > On 06/04/2019 02:31 PM, Young Xiao wrote: > > There is a missing check between kmsg->msg_controllen and cmlen, > > which can possibly lead to overflow. > > > > This bug is similar to vulnerability that

[PATCH] iio:core: Fix bug in length of event info_mask and catch unhandled bits set in masks.

2019-06-04 Thread Young Xiao
ef4b4856593f ("iio:core: Fix bug in length of event info_mask and catch unhandled bits set in masks.") for details. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/iio/industrialio-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/industrialio-core

[PATCH] net: compat: fix msg_controllen overflow in scm_detach_fds_compat()

2019-06-04 Thread Young Xiao
There is a missing check between kmsg->msg_controllen and cmlen, which can possibly lead to overflow. This bug is similar to vulnerability that was fixed in commit 6900317f5eff ("net, scm: fix PaX detected msg_controllen overflow in scm_detach_fds"). Signed-off-by: Young

[PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-06-04 Thread Young Xiao
If vpif_probe() fails on v4l2_device_register() and vpif_probe_complete(), then memory allocated at initialize_vpif() for global vpif_obj.dev[i] become unreleased. The patch adds deallocation of vpif_obj.dev[i] on the error path. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers

Re: [PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-06-04 Thread Yang Xiao
On Tue, Jun 4, 2019 at 4:15 PM Lad, Prabhakar wrote: > > Hi Young, > > Thanks for the patch. > > On Tue, Jun 4, 2019 at 8:49 AM Young Xiao <92siuy...@gmail.com> wrote: > > > > If vpif_probe() fails on v4l2_device_register() and vpif_probe_complete(), > >

[PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-06-04 Thread Young Xiao
If vpif_probe() fails on v4l2_device_register() and vpif_probe_complete(), then memory allocated at initialize_vpif() for global vpif_obj.dev[i] become unreleased. The patch adds deallocation of vpif_obj.dev[i] on the error path. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers

Re: [PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-06-04 Thread Yang Xiao
Yes, you are correct. I will fix the issue and resubmit the patch again. On Mon, Jun 3, 2019 at 7:55 PM Hans Verkuil wrote: > > On 5/29/19 3:09 PM, Young Xiao wrote: > > If vpif_probe() fails on vpif_probe_complete(), then memory > > allocated at initialize_vpif() for glo

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2019-06-04 Thread Yang Xiao
the same time, there are bugs in mip6_destopt_offset() and mip6_destopt_offset(), which is similar to CVE-2017-7542. On Sat, Jun 1, 2019 at 1:35 AM Eric Dumazet wrote: > > > > On 5/30/19 8:04 PM, Yang Xiao wrote: > > On Fri, May 31, 2019 at 1:17 AM Eric Dumazet wrote: > >> >

Re: [PATCH] ipvlan: Don't propagate IFF_ALLMULTI changes on down interfaces.

2019-06-03 Thread Yang Xiao
Based on your explanation, I found that the patch I submitted is useless. Great thanks and sorry for the trouble. On Mon, Jun 3, 2019 at 3:54 PM Xin Long wrote: > > On Mon, Jun 3, 2019 at 11:22 AM Young Xiao <92siuy...@gmail.com> wrote: > > > > Clearing the IFF_ALLMULTI

[PATCH] ipvlan: Don't propagate IFF_ALLMULTI changes on down interfaces.

2019-06-02 Thread Young Xiao
Clearing the IFF_ALLMULTI flag on a down interface could cause an allmulti overflow on the underlying interface. Attempting the set IFF_ALLMULTI on the underlying interface would cause an error and the log message: "allmulti touches root, set allmulti failed." Signed-off-by: Young Xi

[PATCH] unicore32: check stack pointer in get_wchan

2019-06-02 Thread Young Xiao
frame pointer. See commit 1b15ec7a7427 ("ARM: 7912/1: check stack pointer in get_wchan") for details. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- arch/unicore32/kernel/process.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/unicore32/kernel/

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2019-05-31 Thread Yang Xiao
ently already linearized before the function is called, > >> or is it missing and a bug needs to be fixed ? > > > > AFAICS this is the code-path for locally generated outbound packets. > > Under what circumstances can the IPv6 header be not in the head? > > > > > > I gu

[PATCH] pinctrl: pinctrl-mtk-common: fix a possible NULL pointer deference

2019-05-31 Thread Young Xiao
fig. To fix it, check pctl->eint before accessing the member. See commit 5f591543a937 ("pinctrl: mt7622: fix a kernel panic when pio don't work as EINT controller") for details. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/pinctrl/mediatek/pinctrl-mtk-commo

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2019-05-30 Thread Yang Xiao
On Fri, May 31, 2019 at 1:17 AM Eric Dumazet wrote: > > > > On 5/30/19 8:28 AM, Young Xiao wrote: > > The fragmentation code tries to parse the header options in order > > to figure out where to insert the fragment option. Since nexthdr points > > to an i

[PATCH] ipv6: Prevent overrun when parsing v6 header options

2019-05-30 Thread Young Xiao
of it. This vulnerability is similar to CVE-2017-9074. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- net/ipv6/mip6.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/net/ipv6/mip6.c b/net/ipv6/mip6.c index 64f0f7b..30ed1c5 100644 --- a/ne

Re: [PATCH] amd64-agp: fix arbitrary kernel memory writes

2019-05-29 Thread Yang Xiao
I am not so sure about taking off the cast, just to be in line with patch in 194b3da873fd. The comment can be deleted. On Wed, May 29, 2019 at 4:35 PM Greg KH wrote: > > On Wed, May 29, 2019 at 12:52:01PM +0800, Young Xiao wrote: > > pg_start is copied from userspace on

Re: [PATCH] ipv4: tcp_input: fix stack out of bounds when parsing TCP options.

2019-05-29 Thread Yang Xiao
; > On Wed, May 29, 2019 at 1:10 AM Young Xiao <92siuy...@gmail.com> wrote: > > > > The TCP option parsing routines in tcp_parse_options function could > > read one byte out of the buffer of the TCP options. > > > > 1 while (length > 0) { > > 2

[PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-05-29 Thread Young Xiao
If vpif_probe() fails on vpif_probe_complete(), then memory allocated at initialize_vpif() for global vpif_obj.dev[i] become unreleased. The patch adds deallocation of vpif_obj.dev[i] on the error path. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/media/platform/d

[PATCH] isdn: hisax: hfc_2bds0: Fix a possible concurrency use-after-free bug in HFCD_l1hw()

2019-05-29 Thread Young Xiao
igned-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/isdn/hisax/hfc_2bds0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/isdn/hisax/hfc_2bds0.c b/drivers/isdn/hisax/hfc_2bds0.c index 3715fa0..ade12c0 100644 --- a/drivers/isdn/hisax/hfc_2bds0.c +++ b/drivers/isdn/hisax/hfc_2

  1   2   3   4   5   6   7   8   9   10   >