Hi
On 3/8/2019 12:09 AM, Mark Brown wrote:
On Thu, Mar 07, 2019 at 05:26:53PM +0200, Jarkko Nikula wrote:
On 3/7/19 9:24 AM, xiao jin wrote:
The patch is to do cs again if spi-pxa2xx restar the SSP during
pxa2xx_spi_transfer_one()
Hmm.. please correct me if I'm wrong
as the SSE
bit is cleared. The cs_assert before the SSP restart can't ensure
spi-pxa2xx work well.
The patch is to do cs again if spi-pxa2xx restar the SSP during
pxa2xx_spi_transfer_one()
Signed-off-by: xiao jin
Signed-off-by: he, bo
---
drivers/spi/spi-pxa2xx.c | 8
1 file changed, 8
Hi Jarkko,
On 3/6/2019 3:52 PM, Jarkko Nikula wrote:
Hi
On 3/6/19 5:05 AM, xiao jin wrote:
From: "he, bo"
We find spi can't work on board. More debug shows it's related
to the following patch that changed the chip selection assert and
deassert timing.
^^ timing caught my atten
selection timeing action back to before the patch.
The spi on the board works.
Signed-off-by: xiao jin
Signed-off-by: he, bo
---
drivers/spi/spi-pxa2xx.c | 41 ++--
1 file changed, 14 insertions(+), 27 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drive
Hi tglx,
On 7/2/2015 8:50 PM, Thomas Gleixner wrote:
The whole vector stuff is racy versus cpu hotplug and Jins patch
merily addresses a small part of it and by doing that it breaks stuff
as well.
With that patch we move the vector setup after marking the cpu online,
which is wrong because
Hi Joerg,
On 7/2/2015 2:52 PM, Joerg Roedel wrote:
Hi Jin,
On Thu, Jul 02, 2015 at 12:24:34PM +0800, xiao jin wrote:
[ 106.107851] BUG: unable to handle kernel NULL pointer dereference at
0040
[ 106.116702] IP:
[ 106.118490] []
check_irq_vectors_for_cpu_disable+0x76/0x180
Hi Joerg,
On 7/2/2015 2:52 PM, Joerg Roedel wrote:
Hi Jin,
On Thu, Jul 02, 2015 at 12:24:34PM +0800, xiao jin wrote:
[ 106.107851] BUG: unable to handle kernel NULL pointer dereference at
0040
[ 106.116702] IP:
[ 106.118490] [810044f6
Hi tglx,
On 7/2/2015 8:50 PM, Thomas Gleixner wrote:
The whole vector stuff is racy versus cpu hotplug and Jins patch
merily addresses a small part of it and by doing that it breaks stuff
as well.
With that patch we move the vector setup after marking the cpu online,
which is wrong because
online when clear irq vector, it makes the irq number
remain
in irq vector after free_msi_irqs. Next native_cpu_disable() will hit NULL
pointer
when check irq vector.
The patch move setup_vector_irq after set_cpu_online.
Signed-off-by: xiao jin
---
arch/x86/kernel/smpboot.c | 10 +--
irq vector.
The patch move setup_vector_irq after set_cpu_online.
Signed-off-by: xiao jin jin.x...@intel.com
---
arch/x86/kernel/smpboot.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 50e547e..f7d5d79
On 05/04/2014 08:26 AM, Peter Chen wrote:
On Sat, May 03, 2014 at 11:52:25AM +0800, xiao jin wrote:
We use usb ehci to connect with modem and run stress test on ehci
remote wake. Sometimes usb disconnect. We add more debug ftrace
(Kernel version: 3.10) and list the key log to show how problem
On 05/03/2014 11:20 PM, Alan Stern wrote:
On Sat, 3 May 2014, xiao jin wrote:
We use usb ehci to connect with modem and run stress test on ehci
remote wake. Sometimes usb disconnect. We add more debug ftrace
(Kernel version: 3.10) and list the key log to show how problem
happened.
-0
On 05/03/2014 11:20 PM, Alan Stern wrote:
On Sat, 3 May 2014, xiao jin wrote:
We use usb ehci to connect with modem and run stress test on ehci
remote wake. Sometimes usb disconnect. We add more debug ftrace
(Kernel version: 3.10) and list the key log to show how problem
happened.
idle-0
On 05/04/2014 08:26 AM, Peter Chen wrote:
On Sat, May 03, 2014 at 11:52:25AM +0800, xiao jin wrote:
We use usb ehci to connect with modem and run stress test on ehci
remote wake. Sometimes usb disconnect. We add more debug ftrace
(Kernel version: 3.10) and list the key log to show how problem
wait for
the wakeup finished, then judge what should do next step.
We have some thought and give a patch. This patch is to wait for controller
RESUME finished when hub try to clear port SUSPEND feature.
Signed-off-by: xiao jin
Reviewed-by: David Cohen
---
drivers/usb/host/ehci-hub.c |7 +
thought and give a patch. This patch is to wait for controller
RESUME finished when hub try to clear port SUSPEND feature.
Signed-off-by: xiao jin jin.x...@intel.com
Reviewed-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/host/ehci-hub.c |7 +++
include/linux/usb/ehci_def.h
ext resume. If the time of next resume is far
away, tty will be blocked in tty_wait_until_sent during time. The
race also can lead to writes being reordered.
This patch put play_Delayed and intfdata->suspended together in the
spinlock, it's to avoid the write race during resume.
Signed-off-by
They are however two distinct bugs and should be fixed separately. Could
you split the fixes into two patches and resubmit?
Please also include a more descriptive subject line for each patch, for
example:
"USB: usb_wwan: fix urb leak in write error path"
"USB: usb_wwan: fix
They are however two distinct bugs and should be fixed separately. Could
you split the fixes into two patches and resubmit?
Please also include a more descriptive subject line for each patch, for
example:
USB: usb_wwan: fix urb leak in write error path
USB: usb_wwan: fix race
resume. If the time of next resume is far
away, tty will be blocked in tty_wait_until_sent during time. The
race also can lead to writes being reordered.
This patch put play_Delayed and intfdata-suspended together in the
spinlock, it's to avoid the write race during resume.
Signed-off-by: xiao jin
e try autopm async with
error.
2. put play_Delayed and intfdata->suspended together in the spinlock,
it's to avoid the write race during resume.
Signed-off-by: xiao jin
Signed-off-by: Zhang, Qi1
Reviewed-by: David Cohen
---
drivers/usb/serial/usb_wwan.c | 12 +---
1 file change
Do not initialize list twice.
list_replace_init() already takes care of initializing list.
We don't need to initialize it with LIST_HEAD() beforehand.
Signed-off-by: xiao jin
Reviewed-by: David Cohen
---
net/ipv4/inetpeer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Do not initialize net_kill_list twice.
list_replace_init() already takes care of initializing net_kill_list.
We don't need to initialize it with LIST_HEAD() beforehand.
Signed-off-by: xiao jin
Reviewed-by: David Cohen
---
net/core/net_namespace.c |2 +-
1 file changed, 1 insertion(+), 1
Do not initialize net_kill_list twice.
list_replace_init() already takes care of initializing net_kill_list.
We don't need to initialize it with LIST_HEAD() beforehand.
Signed-off-by: xiao jin jin.x...@intel.com
Reviewed-by: David Cohen david.a.co...@linux.intel.com
---
net/core/net_namespace.c
Do not initialize list twice.
list_replace_init() already takes care of initializing list.
We don't need to initialize it with LIST_HEAD() beforehand.
Signed-off-by: xiao jin jin.x...@intel.com
Reviewed-by: David Cohen david.a.co...@linux.intel.com
---
net/ipv4/inetpeer.c |2 +-
1 file
with
error.
2. put play_Delayed and intfdata-suspended together in the spinlock,
it's to avoid the write race during resume.
Signed-off-by: xiao jin jin.x...@intel.com
Signed-off-by: Zhang, Qi1 qi1.zh...@intel.com
Reviewed-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/serial/usb_wwan.c
-write queue using urb anchors and
making sure to discard the queue properly at shutdown.
Reported-by: Xiao Jin
Signed-off-by: Johan Hovold
---
Let's fix the current runtime-suspend implementation before considering
adding a write fifo.
Since this has never really worked, I'll let someone else
-write queue using urb anchors and
making sure to discard the queue properly at shutdown.
Reported-by: Xiao Jin jin.x...@intel.com
Signed-off-by: Johan Hovold jhov...@gmail.com
---
Let's fix the current runtime-suspend implementation before considering
adding a write fifo.
Since this has never
Hi, Oliver,
On 04/10/2014 04:02 PM, Oliver Neukum wrote:
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems
Hi, Oliver,
On 04/10/2014 04:02 PM, Oliver Neukum wrote:
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write
From: xiao jin
Date: Tue, 25 Mar 2014 15:54:36 +0800
Subject: [PATCH] cdc-acm: some enhancement on acm delayed write
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write can be saved during acm suspend. More acm
From: xiao jin jin.x...@intel.com
Date: Tue, 25 Mar 2014 15:54:36 +0800
Subject: [PATCH] cdc-acm: some enhancement on acm delayed write
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write can be saved during acm
upper layer process wrong
buffer.
This patch is to set actual_length as transfer_buffer_length
only if trb_comp_code is not COMP_STOP_INVAL when
process_bulk_intr_td.
Signed-off-by: xiao jin
---
drivers/usb/host/xhci-ring.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff
upper layer process wrong
buffer.
This patch is to set actual_length as transfer_buffer_length
only if trb_comp_code is not COMP_STOP_INVAL when
process_bulk_intr_td.
Signed-off-by: xiao jin jin.x...@intel.com
---
drivers/usb/host/xhci-ring.c |7 +--
1 files changed, 5 insertions(+), 2
Hi, Greg,
I am sorry for the inconvenience again. I will do as what you point to
make sure the thing won't happen again in future.
On Wed, 2013-10-16 at 13:44 -0700, Greg KH wrote:
> On Tue, Oct 15, 2013 at 09:01:35AM +0800, xiao jin wrote:
> > If acm_write_start during acm suspend, wri
Hi, Greg,
I am sorry for the inconvenience again. I will do as what you point to
make sure the thing won't happen again in future.
On Wed, 2013-10-16 at 13:44 -0700, Greg KH wrote:
On Tue, Oct 15, 2013 at 09:01:35AM +0800, xiao jin wrote:
If acm_write_start during acm suspend, write acm_wb
suspend. It can ensure no acm write abandoned.
Signed-off-by: xiao jin
---
drivers/usb/class/cdc-acm.c | 30 --
drivers/usb/class/cdc-acm.h |7 ++-
2 files changed, 26 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc
Hi, Greg,
I am sorry for the inconvenience. I will the patch format with the title
v2. Thanks for the review.
On Mon, 2013-10-14 at 11:10 -0700, Greg KH wrote:
> On Tue, Oct 08, 2013 at 05:08:48PM +0800, Xiao Jin wrote:
> >
> > From: xiao jin
> >
> > If acm_wri
Hi, Greg,
I am sorry for the inconvenience. I will the patch format with the title
v2. Thanks for the review.
On Mon, 2013-10-14 at 11:10 -0700, Greg KH wrote:
On Tue, Oct 08, 2013 at 05:08:48PM +0800, Xiao Jin wrote:
From: xiao jin jin.x...@intel.com
If acm_write_start during acm
suspend. It can ensure no acm write abandoned.
Signed-off-by: xiao jin jin.x...@intel.com
---
drivers/usb/class/cdc-acm.c | 30 --
drivers/usb/class/cdc-acm.h |7 ++-
2 files changed, 26 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b
t later.
>
> Sarah
>
> > On Fri, Oct 11, 2013 at 08:47:54AM +0800, xiao jin wrote:
> > > From: Mathias Nyman
> > >
> > > If a command on the command ring needs to be cancelled before it is
> > > handled
> > > it can be turned
patch xhci: correct the usage of
USB_CTRL_SET_TIMEOUT. You sent this patch instead. On the plus side,
it looks like git-send-email works.
Can you try again?
Ah, nevermind, I saw the v2 patch you sent later.
Sarah
On Fri, Oct 11, 2013 at 08:47:54AM +0800, xiao jin wrote:
From
XHCI_CMD_DEFAULT_TIMEOUT instead of
USB_CTRL_SET_TIMEOUT as command completion event timeout.
Signed-off-by: xiao jin
---
drivers/usb/host/xhci-hub.c |2 +-
drivers/usb/host/xhci.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host
From: Mathias Nyman
If a command on the command ring needs to be cancelled before it is handled
it can be turned to a no-op operation when the ring is stopped.
We want to store the command ring enqueue pointer in the command structure
when the command in enqueued for the cancellation case.
Some
From: Mathias Nyman mathias.ny...@linux.intel.com
If a command on the command ring needs to be cancelled before it is handled
it can be turned to a no-op operation when the ring is stopped.
We want to store the command ring enqueue pointer in the command structure
when the command in enqueued for
XHCI_CMD_DEFAULT_TIMEOUT instead of
USB_CTRL_SET_TIMEOUT as command completion event timeout.
Signed-off-by: xiao jin jin.x...@intel.com
---
drivers/usb/host/xhci-hub.c |2 +-
drivers/usb/host/xhci.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b
are what the patch aimed to solve. FYI.
On Wed, 2013-10-09 at 13:18 -0700, Sarah Sharp wrote:
> Hi Xiao,
>
> Thanks for taking the time to submit this patch. Comments below.
>
> On Wed, Oct 09, 2013 at 09:42:36AM +0800, Xiao Jin wrote:
> > From: xiao jin
> > Date: Wed
are what the patch aimed to solve. FYI.
On Wed, 2013-10-09 at 13:18 -0700, Sarah Sharp wrote:
Hi Xiao,
Thanks for taking the time to submit this patch. Comments below.
On Wed, Oct 09, 2013 at 09:42:36AM +0800, Xiao Jin wrote:
From: xiao jin jin.x...@intel.com
Date: Wed, 9 Oct 2013 09:38
From: xiao jin
Date: Wed, 9 Oct 2013 09:38:45 +0800
Subject: [PATCH] xhci-hub.c: handle command_trb that may be link TRB
When xhci stop device, it's possible cmd_ring enqueue point to
link TRB after queue the last but one stop endpoint. We must
handle the command_trb point to the next segment
From: xiao jin
Date: Wed, 9 Oct 2013 09:09:46 +0800
Subject: [PATCH] xhci: correct the usage of USB_CTRL_SET_TIMEOUT
The usage of USB_CTRL_SET_TIMEOUT is incorrect. The
definition of USB_CTRL_SET_TIMEOUT is 5000ms. The
input timeout to wait_for_completion_interruptible_timeout
is jiffies
From: xiao jin
Date: Tue, 8 Oct 2013 16:57:29 +0800
Subject: [PATCH] cdc-acm: put delayed_wb to list
If acm_write_start during acm suspend, write acm_wb is backuped
to delayed_wb. When acm resume, the delayed_wb will be started.
This mechanism can only record one write during acm suspend. More
From: xiao jin jin.x...@intel.com
Date: Tue, 8 Oct 2013 16:57:29 +0800
Subject: [PATCH] cdc-acm: put delayed_wb to list
If acm_write_start during acm suspend, write acm_wb is backuped
to delayed_wb. When acm resume, the delayed_wb will be started.
This mechanism can only record one write during
From: xiao jin jin.x...@intel.com
Date: Wed, 9 Oct 2013 09:09:46 +0800
Subject: [PATCH] xhci: correct the usage of USB_CTRL_SET_TIMEOUT
The usage of USB_CTRL_SET_TIMEOUT is incorrect. The
definition of USB_CTRL_SET_TIMEOUT is 5000ms. The
input timeout to wait_for_completion_interruptible_timeout
From: xiao jin jin.x...@intel.com
Date: Wed, 9 Oct 2013 09:38:45 +0800
Subject: [PATCH] xhci-hub.c: handle command_trb that may be link TRB
When xhci stop device, it's possible cmd_ring enqueue point to
link TRB after queue the last but one stop endpoint. We must
handle the command_trb point
Alan,
Thanks. But the comment makes me confused. As we see, gsm->output is called by
gsm_data_kick too, and it's in the tx_lock...
Best regards,
Jin Xiao
> From: xiaojin
> Date: Wed, 19 Dec 2012 11:53:43 +0800
> Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
>
> All the call to
Alan,
Thanks. But the comment makes me confused. As we see, gsm-output is called by
gsm_data_kick too, and it's in the tx_lock...
Best regards,
Jin Xiao
From: xiaojin jin.x...@intel.com
Date: Wed, 19 Dec 2012 11:53:43 +0800
Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
All the call
From: xiaojin
Date: Wed, 19 Dec 2012 11:53:43 +0800
Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
All the call to gsm->output should be in the tx_lock,
that could avoid potential race from MUX level. But
we have no tx_lock in gsm_send.
This patch is to add tx_lock in gsm_send.
From: xiaojin
Date: Wed, 19 Dec 2012 11:53:43 +0800
Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
All the call to gsm->output should be in the tx_lock,
that could avoid potential race from MUX level. But
we have no tx_lock in gsm_send.
This patch is to add tx_lock in gsm_send.
From: xiaojin jin.x...@intel.com
Date: Wed, 19 Dec 2012 11:53:43 +0800
Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
All the call to gsm-output should be in the tx_lock,
that could avoid potential race from MUX level. But
we have no tx_lock in gsm_send.
This patch is to add tx_lock in
From: xiaojin jin.x...@intel.com
Date: Wed, 19 Dec 2012 11:53:43 +0800
Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
All the call to gsm-output should be in the tx_lock,
that could avoid potential race from MUX level. But
we have no tx_lock in gsm_send.
This patch is to add tx_lock in
From: xiao jin
Date: Tue, 20 Nov 2012 13:45:47 +0800
Subject: [PATCH] spi-dw: delete cur_msg when pump message and transfer
has finished
We see DPM device timeout happened in spi_max3111 when system suspend.
The root cause is related to the time we delete msg from dw_spi queue.
Below
From: xiao jin jin.x...@intel.com
Date: Tue, 20 Nov 2012 13:45:47 +0800
Subject: [PATCH] spi-dw: delete cur_msg when pump message and transfer
has finished
We see DPM device timeout happened in spi_max3111 when system suspend.
The root cause is related to the time we delete msg from dw_spi queue
From: xiao jin
Date: Tue, 20 Nov 2012 13:45:47 +0800
Subject: [PATCH] spi-dw: delete cur_msg when pump message and transfer has
finished
We see DPM device timeout happened in spi_max3111 when system suspend.
The root cause is related to the time we delete msg from dw_spi queue.
Below
From: xiao jin jin.x...@intel.com
Date: Tue, 20 Nov 2012 13:45:47 +0800
Subject: [PATCH] spi-dw: delete cur_msg when pump message and transfer has
finished
We see DPM device timeout happened in spi_max3111 when system suspend.
The root cause is related to the time we delete msg from dw_spi
66 matches
Mail list logo
