Re: [PATCH] drm/hisilicon/hibmc: Move drm_fbdev_generic_setup() down to avoid the splat

2020-07-08 Thread Xinliang Liu
Hi Zenghui, Thanks for fixing this. Applied to drm-misc-fixes. Best, -Xinliang On Mon, 6 Jul 2020 at 22:53, Zenghui Yu wrote: > > The HiSilicon hibmc driver triggers a splat at boot time as below > > [ 14.137806] [ cut here ] > [ 14.142405] hibmc-drm :0a:00.0: Dev

Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

2017-08-28 Thread Xinliang Liu
Hi Daniel, On 28 August 2017 at 16:51, Daniel Vetter wrote: > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote: >> Hi, >> >> On 15 August 2017 at 22:14, Peter Griffin wrote: >> >> > This patch fixes the following soft lockup: >> > BU

Re: [PATCH] reset: hi6220: Set module license so that it can be loaded

2017-04-09 Thread Xinliang Liu
starts working. > > Signed-off-by: Jeremy Linton reviewed-by: Xinliang Liu Thanks, -xinliang > --- > drivers/reset/hisilicon/hi6220_reset.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/reset/hisilicon/hi6220_reset.c > b/drivers/reset/hisilicon/hi6220_

Re: [PATCH -next] drm/hisilicon: Fix error handling of ade_power_up()

2016-07-25 Thread Xinliang Liu
On 19 July 2016 at 19:30, Wei Yongjun wrote: > From: Wei Yongjun > > Fix the reset_control_deassert() fail and clk_prepare_enable() fail > error handling of ade_power_up(). > > Signed-off-by: Wei Yongjun Applied, thanks. -xinliang > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 10

Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

2016-07-17 Thread Xinliang Liu
On 13 July 2016 at 20:43, wrote: > From: Wei Yongjun > > In case of error, the function devm_clk_get() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Hi, thanks. This patch had already appli

Re: [PATCH -next] drm/hisilicon: Remove redundant dev_err call in ade_dts_parse()

2016-07-17 Thread Xinliang Liu
Hi, thanks. This patch had already applied to drm-hisilicon-next. On 13 July 2016 at 20:44, wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun > --- > dr

Re: [PATCH -next] drm/hisilicon: Fix non static symbol warning

2016-07-17 Thread Xinliang Liu
On 13 July 2016 at 20:43, wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c:107:5: warning: > symbol 'ade_get_channel_formats' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Thanks, applied to drm-hisi

Re: [PATCH v3 1/4] reset: hisilicon: Add media reset controller binding

2016-06-20 Thread Xinliang Liu
On 20 June 2016 at 20:07, Philipp Zabel wrote: > Am Montag, den 20.06.2016, 11:50 +0800 schrieb Xinliang Liu: >> >> Required properties: >> -- compatible: may be "hisilicon,hi6220-sysctrl" >> +- compatible: should be one of the following: >> + -

[PATCH v3 2/4] arm64: dts: hi6220: Add media subsystem reset dts

2016-06-19 Thread Xinliang Liu
Add media subsystem reset dts support. Signed-off-by: Chen Feng Signed-off-by: Xinliang Liu --- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 ++ include/dt-bindings/reset/hisi,hi6220-resets.h | 8 2 files changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon

[PATCH v3 1/4] reset: hisilicon: Add media reset controller binding

2016-06-19 Thread Xinliang Liu
; for both peripheral and media reset controller. Signed-off-by: Xinliang Liu --- Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt b/Doc

[PATCH v3 3/4] reset: hisilicon: Change to syscon register access

2016-06-19 Thread Xinliang Liu
. Signed-off-by: Chen Feng Signed-off-by: Xia Qing Signed-off-by: Xinliang Liu --- drivers/reset/hisilicon/hi6220_reset.c | 85 ++ 1 file changed, 45 insertions(+), 40 deletions(-) diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon

[PATCH v3 0/4] Add hi6220 media subsystem reset controller driver

2016-06-19 Thread Xinliang Liu
): reset: hisilicon: Change to syscon register access Xinliang Liu (3): reset: hisilicon: Add media reset controller binding arm64: dts: hi6220: Add media subsystem reset dts reset: hisilicon: Add hi6220 media subsystem reset support .../bindings/reset/hisilicon,hi6220-reset.txt | 4

[PATCH v3 4/4] reset: hisilicon: Add hi6220 media subsystem reset support

2016-06-19 Thread Xinliang Liu
Add hi6220 media subsystem reset controller. Signed-off-by: Chen Feng Signed-off-by: Xia Qing Signed-off-by: Xinliang Liu --- drivers/reset/hisilicon/hi6220_reset.c | 49 -- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/drivers/reset/hisilicon

Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

2016-06-19 Thread Xinliang Liu
Hi, On 18 June 2016 at 02:29, wrote: > From: Wei Yongjun > > In case of error, the function devm_clk_get() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Applied to drm-hisilicon-next. Than

Re: [PATCH v2 3/3] reset: hisilicon: Add hi6220 media subsystem reset support

2016-06-16 Thread Xinliang Liu
Hi, On 16 June 2016 at 18:52, Philipp Zabel wrote: > Am Donnerstag, den 16.06.2016, 18:30 +0800 schrieb Xinliang Liu: >> From: Chen Feng >> >> Add media subsystem reset support for hi6220. > > Please split the regmap register access change and the addition of > m

Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

2016-06-16 Thread Xinliang Liu
Hi, On 16 June 2016 at 18:46, Philipp Zabel wrote: > Am Donnerstag, den 16.06.2016, 18:29 +0800 schrieb Xinliang Liu: >> Add compatible for media reset controller. >> >> Signed-off-by: Xinliang Liu >> --- >> Documentation/devicetree/bindings/reset/hisilicon,hi6

[PATCH v2 2/3] arm64: dts: hi6220: Add media subsystem reset dts

2016-06-16 Thread Xinliang Liu
Add media subsystem reset support. Signed-off-by: Chen Feng Signed-off-by: Xinliang Liu --- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 ++ include/dt-bindings/reset/hisi,hi6220-resets.h | 8 2 files changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220

[PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

2016-06-16 Thread Xinliang Liu
Add compatible for media reset controller. Signed-off-by: Xinliang Liu --- Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt b

[PATCH v2 0/3] Add hi6220 media subsystem reset controller driver

2016-06-16 Thread Xinliang Liu
controller ops. Chen Feng (1): reset: hisilicon: Add hi6220 media subsystem reset support Xinliang Liu (2): reset: hisilicon: Add media reset controller binding arm64: dts: hi6220: Add media subsystem reset dts .../bindings/reset/hisilicon,hi6220-reset.txt | 4 +- arch/arm64/boot/dts

[PATCH v2 3/3] reset: hisilicon: Add hi6220 media subsystem reset support

2016-06-16 Thread Xinliang Liu
From: Chen Feng Add media subsystem reset support for hi6220. Signed-off-by: Chen Feng Signed-off-by: Xia Qing Signed-off-by: Xinliang Liu --- drivers/reset/hisilicon/hi6220_reset.c | 122 +++-- 1 file changed, 86 insertions(+), 36 deletions(-) diff --git a

Re: [path v2 0/7] Add DRM driver for Hisilicon Hibmc

2016-05-29 Thread Xinliang Liu
Hi Rongrong, It seems that you haven't run the checkpatch script. Please run this script to check your patches before you send them. Like bellow: $ cd yourkerneldir $ ./scripts/checkpatch.pl --strict yourpatches Thanks, -xinliang On 29 May 2016 at 17:40, Rongrong Zou wrote: > This patch set add

Re: [path v2 7/7] drm/hisilicon/hibmc: Add maintainer for Hibmc DRM

2016-05-29 Thread Xinliang Liu
Maintained > +F: drivers/gpu/drm/hisilicon/hibmc Please add a "/" ad the end of this line. And move this part into DRM DRIVERS FOR HISILICON Thanks, -xinliang > + > DRM DRIVERS FOR HISILICON > M: Xinliang Liu > R: Xinwei Kong > -- > 1.9.1 >

Re: [PATCH v7 0/5] Add mipi dsi support for rk3288

2016-02-24 Thread Xinliang Liu
On 8 February 2016 at 18:12, Archit Taneja wrote: > Hi, > > On 01/06/2016 09:33 AM, Chris Zhong wrote: >> >> >> The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller >> IP. This series adds support for a Synopsys DesignWare MIPI DSI host >> controller DRM driver. >> >> The MIPI DSI

[PATCH] drm/cma-helper: Add multi buffer support for cma fbdev

2015-09-14 Thread Xinliang Liu
operated. It will need some time for Android device vendors to abondon legency fbdev. So multi buffer for fbdev is needed. Signed-off-by: Xinliang Liu --- drivers/gpu/drm/Kconfig | 8 drivers/gpu/drm/drm_fb_cma_helper.c | 8 +++- 2 files changed, 15 insertions(+), 1

[PATCH] drm/crtc: Add a helper func to get a registered crtc from its index

2015-08-24 Thread Xinliang Liu
(crtc); struct hisi_crtc_ops *ops = hcrtc->ops; int ret = 0; if (ops->enable_vblank) ret = ops->enable_vblank(hcrtc); return ret; } Signed-off-by: Xinliang Liu --- drivers/gpu/drm/drm_crtc.c | 25 + include/drm/drm_c