Re: [PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:52 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:45 AM, Yakir Yang <y...@rock-chips.com> wrote: Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR s

Re: [PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:51 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:44 AM, Yakir Yang <y...@rock-chips.com> wrote: Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp

[PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-09 Thread Yakir Yang
Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 3 ++- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 18 +- 2 files changed, 11 insertions(+), 10 del

[PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - Update commit message - Add DP_TIMEOUT_PSR_LOOP_MS

Re: [PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
On 09/08/2016 10:12 PM, Sean Paul wrote: On Wed, Sep 7, 2016 at 11:48 PM, Yakir Yang <y...@rock-chips.com> wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting.

[PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-07 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v2: - A bunch of good fixes from Sean drivers/gpu/drm/

[PATCH v2 1/2] drm/bridge: analogix_dp: Remove duplicated code v2

2016-09-07 Thread Yakir Yang
nstead of duplicating them. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Javier Martinez Canillas <jav...@osg.samsung.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Yakir Yang <y...@rock-chips.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Reviewed-by: Sean P

Re: [PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-06 Thread Yakir Yang
Sean, Thanks for your comments. On 09/07/2016 03:51 AM, Sean Paul wrote: On Fri, Aug 26, 2016 at 6:19 AM, Yakir Yang <y...@rock-chips.com> wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to

[PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-08-26 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 6 ++--- drive

Re: [PATCH v5 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-08-17 Thread Yakir Yang
Hello Archit, On 08/17/2016 01:41 PM, Archit Taneja wrote: Hi, On 07/24/2016 12:27 PM, Yakir Yang wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the hardware framebuffer in panel, this would make lots of sense to save the power consumption

Re: [PATCH v2] drm/bridge: analogix_dp: Ensure the panel is properly prepared/unprepared

2016-08-08 Thread Yakir Yang
accidentally turn the panel off at the wrong time. Signed-off-by: Sean Paul <seanp...@chromium.org> Reviewed-by: Yakir Yang <y...@rock-chips.com> And I also tested this patch on RK3399 Kevin board, panel works rightly, so: Tested-by: Yakir Yang <y...@rock-chips.com> Also add Archit i

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-08 Thread Yakir Yang
+ Archit Tomeu, Thanks for the update :-) But you have missed three tiny align problems, please see my inline notes, wish you could fix them. After that this patch looks good to me, so: Reviewed-by: Yakir Yang <y...@rock-chips.com> I guess this patch should go through Archit's drm_

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
gt; Cc: Mika Kahola <mika.kah...@intel.com> Cc: Yakir Yang <y...@rock-chips.com> Cc: Daniel Vetter <daniel.vet...@intel.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 390 +++-- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 39 +-- d

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Javier Martinez Canillas <jav...@osg.samsung.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Yakir Yang <y...@rock-chips.com> Cc: Daniel Vetter

Re: [PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

2016-08-03 Thread Yakir Yang
"efc9194 ASoC: hdmi-codec: callback function will be called with private data", the hdmi_codec_ops had some changes. Can you rebase your patch to the newest kernel? Thanks. On 2016年06月15日 21:28, Yakir Yang wrote: Using the common hdmi-codec driver to support hdmi audio function.

Re: [PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

2016-08-01 Thread Yakir Yang
Hi Mark & Heiko, Ping.. Thanks, - Yakir On 06/15/2016 09:28 PM, Yakir Yang wrote: Using the common hdmi-codec driver to support hdmi audio function. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/rockchip/inno_hd

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off

Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver

2016-07-31 Thread Yakir Yang
On 07/29/2016 04:38 PM, Tomeu Vizoso wrote: On 5 April 2016 at 04:06, Yakir Yang <y...@rock-chips.com> wrote: Hi Daniel, On 03/31/2016 06:15 PM, Daniel Vetter wrote: On Mon, Feb 15, 2016 at 07:08:05PM +0800, Yakir Yang wrote: Hi all, The Samsung Exynos eDP controller and Ro

Re: [PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-27 Thread Yakir Yang
Sean, Oops, sorry about miss your suggest :( On 07/22/2016 11:03 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:00 PM, Yakir Yang <y...@rock-chips.com> wrote: Sean, Thanks for your fast respond :-) But this patch is not the latest one, I have upgraded this to "v1.1" versio

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Doug, On 07/23/2016 12:04 PM, Doug Anderson wrote: Yakir, On Wed, Jul 13, 2016 at 9:15 PM, Yakir Yang <y...@rock-chips.com> wrote: +static void psr_set_state(struct psr_drv *psr, enum psr_state state) +{ + mutex_lock(>state_mutex); + + if (psr->st

[PATCH v5 1/4] drm/rockchip: vop: export line flag function

2016-07-24 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sea

[PATCH v5 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-24 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes in v5: - Add reviewed flag from Sean. Changes in v4.1: - Take use of existing edp_psr_vsc struct to swap HBx and DBx setting. (Se

[PATCH v5 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
the encoder registered callback to set the PSR state. Fb driver would call the flush interface in 'fb->dirty' callback, this helper function would force all PSR enabled encoders to exit from PSR for 3 seconds. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v5: - Only keep 'psr_l

[PATCH v5 0/4] Add PSR function support for Analogix/Rockchip DP

2016-07-24 Thread Yakir Yang
river. Changes in v2: - Introduce in v2, split VOP line flag changes out - introduce in v2, splite the common Analogix DP changes out - remove vblank notify out (Daniel) - create a psr_active() callback in vop data struct. Yakir Yang (4): drm/rockchip: vop: export line flag function drm/rockchip

[PATCH v5 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-24 Thread Yakir Yang
Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes in v5: - Add reviewed flag from Se

[PATCH v2 2/3] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v2: - s/Panle/Panel/ (Sean) - Move the drm_panel_ out of a conditional, and throw the return code away (Sean) - Add comments about why we need unprepare

[PATCH v2 3/3] drm/bridge: analogix_dp: remove the panel prepare/unprepare in suspend/resume

2016-07-21 Thread Yakir Yang
We already manager the panel power status in bridge_disable and connector->detect functions, then we don't need to manager the panel power status at suspend/resume in particular. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/bridge

[PATCH v2 1/3] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes in v2: - Add the reviewed tag from Sean. drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm

Re: [PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
Sean, On 07/21/2016 10:30 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:14 AM, Yakir Yang <y...@rock-chips.com> wrote: According to page 16 of Sharp LQ123P1JX31 datasheet, we need to add the missing delay timing. Panel prepare time should be t1 (0.5ms~10ms) plus t3 (0ms~100ms), and

[PATCH v1.1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v1.1: - unprepare the panel at the end of bridge->disable() function drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +++--- 1 file

[PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_

[PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..f178998 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drive

Re: [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

2016-07-18 Thread Yakir Yang
Thierry, On 07/08/2016 05:57 AM, Thierry Reding wrote: On Thu, Jul 07, 2016 at 11:55:23PM +0200, Thierry Reding wrote: On Sun, Jun 12, 2016 at 10:53:30AM +0800, Yakir Yang wrote: The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel connected using eDP interfaces. Signe

Re: [PATCH v4.1 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-15 Thread Yakir Yang
Sean, On 07/15/2016 09:13 PM, Sean Paul wrote: On Fri, Jul 15, 2016 at 06:55:17PM +0800, Yakir Yang wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the hardware framebuffer in panel, this would make lots of sense to save the power consumption

Re: [PATCH v4.1 1/4] drm/rockchip: vop: export line flag function

2016-07-15 Thread Yakir Yang
Sean, On 07/15/2016 09:04 PM, Sean Paul wrote: On Fri, Jul 15, 2016 at 6:55 AM, Yakir Yang <y...@rock-chips.com> wrote: VOP have integrated a hardware counter which indicate the exact display line that vop is scanning. And if we're interested in a specific line, we can set the line

[PATCH v4.1 1/4] drm/rockchip: vop: export line flag function

2016-07-15 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes i

[PATCH v4.1 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-15 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4.1: - Take use of existing edp_psr_vsc struct to swap HBx and DBx setting. (Sean) - Remove PSR_VID_CRC_FLUSH setting analogix_dp_enable_psr_crc(). - Add comment about PBx magic numbers.

Re: [PATCH v4 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 11:26 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:58PM +0800, Yakir Yang wrote: Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang <y...@r

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable

Re: [PATCH v4 1/4] drm/rockchip: vop: export line flag function

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 10:46 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:44PM +0800, Yakir Yang wrote: VOP have integrated a hardware counter which indicate the exact display line that vop is scanning. And if we're interested in a specific line, we can set the line number to vop line_flag

[PATCH v4 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-13 Thread Yakir Yang
Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4: - Return 'void' instead of 'int' in analogix_dp_psr_set(). (Sean) - Pull th

[PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-13 Thread Yakir Yang
driver would call the flush interface in 'fb->dirty' callback, this helper function would force all PSR enabled encoders to exit from PSR for 3 seconds. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4: - Tuck the global "psr_list" & "psr_list_mutex&quo

[PATCH v4 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-13 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4: - Downgrade the PSR version print message to debug level. (Sean) - Return 'void' instead of 'int' in analogix_dp_enable_sink_psr(). (Sean) - Delete the unused read dpcd oper

[PATCH v4 0/4] Add PSR function support for Analogix/Rockchip DP

2016-07-13 Thread Yakir Yang
common Analogix DP changes out - remove vblank notify out (Daniel) - create a psr_active() callback in vop data struct. Yakir Yang (4): drm/rockchip: vop: export line flag function drm/rockchip: add an common abstracted PSR driver drm/bridge: analogix_dp: add the PSR function support drm

[PATCH v4 1/4] drm/rockchip: vop: export line flag function

2016-07-13 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes

Re: [PATCH v1 5/6] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

2016-07-13 Thread Yakir Yang
Heiko, On 07/12/2016 10:27 PM, Heiko Stübner wrote: Hi Yakir, Am Montag, 11. Juli 2016, 19:05:49 schrieb Yakir Yang: For RK3399 HDMI, there is an external clock need for HDMI PHY, and it should keep the same clock rate with VOP DCLK. VPLL have supported the clock for HDMI PHY

Re: [PATCH v1 4/6] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2016-07-13 Thread Yakir Yang
Philipp, On 07/11/2016 07:51 PM, Philipp Zabel wrote: Am Montag, den 11.07.2016, 19:05 +0800 schrieb Yakir Yang: RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Philipp

Re: [PATCH v3 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-12 Thread Yakir Yang
Daniel, On 07/12/2016 08:38 PM, Daniel Vetter wrote: On Fri, Jul 01, 2016 at 02:00:00PM -0400, Sean Paul wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang <y...@rock-chips.com> wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_re

[PATCH v1 1/6] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always

2016-07-11 Thread Yakir Yang
s safe given sufficient testing. Signed-off-by: Douglas Anderson <diand...@chromium.org> Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v1 5/6] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

2016-07-11 Thread Yakir Yang
For RK3399 HDMI, there is an external clock need for HDMI PHY, and it should keep the same clock rate with VOP DCLK. VPLL have supported the clock for HDMI PHY, but there is no clock divider bewteen VPLL and HDMI PHY. So we need to set the VPLL rate manually in HDMI driver. Signed-off-by: Yakir

[PATCH v1 3/6] drm/rockchip: dw_hdmi: Use auto-generated tables

2016-07-11 Thread Yakir Yang
e been wrong in the old table. Signed-off-by: Douglas Anderson <diand...@chromium.org> Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Stéphane Marchesin <marc...@chromium.org> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 130 +++- 1 file

[PATCH v1 2/6] drm/rockchip: dw_hdmi: adjust cklvl & txlvl for RF/EMI

2016-07-11 Thread Yakir Yang
tage and lower data voltage, then we can keep RF/EMI satisfied and single-end & differen test passed. ck: lvl = 9, term=100, vlo = 2.65, vhi=3.12, vswing = 0.47 tx: lvl = 16, term=100, vlo = 2.75, vhi=3.15, vswing = 0.39 Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Do

[PATCH v1 4/6] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2016-07-11 Thread Yakir Yang
RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- .../devicetree/bindings/display/bridge/dw_hdmi.txt | 1 + .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 3 +- drivers/gpu/drm/

[PATCH v1 6/6] drm/rockchip: dw_hdmi: introduce the pclk for grf

2016-07-11 Thread Yakir Yang
For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- .../bindings/display/ro

[PATCH v1 0/6] Add RK3399 HDMI Support

2016-07-11 Thread Yakir Yang
Yakir Yang (4): drm/rockchip: dw_hdmi: adjust cklvl & txlvl for RF/EMI drm/rockchip: dw_hdmi: add RK3399 HDMI support drm/rockchip: dw_hdmi: introduce the VPLL clock setting drm/rockchip: dw_hdmi: introduce the pclk for grf .../devicetree/bindings/display/bridge/dw_hdmi.txt |

Re: [PATCH v3 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-07 Thread Yakir Yang
On 07/08/2016 10:26 AM, Yakir Yang wrote: Sean, Thanks for your review. On 07/02/2016 03:46 AM, Sean Paul wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang <y...@rock-chips.com> wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the ha

Re: [PATCH v3 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-07 Thread Yakir Yang
Sean, On 07/02/2016 04:05 AM, Sean Paul wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang <y...@rock-chips.com> wrote: Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Y

Re: [PATCH v3 1/4] drm/rockchip: vop: export line flag function

2016-07-07 Thread Yakir Yang
Sean, On 07/01/2016 11:32 PM, Sean Paul wrote: On Fri, Jul 1, 2016 at 11:30 AM, Sean Paul <seanp...@chromium.org> wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang <y...@rock-chips.com> wrote: VOP have integrated a hardware counter which indicate the exact display line that vop

Re: [PATCH v3 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-07 Thread Yakir Yang
Sean, Thanks for your review. On 07/02/2016 03:46 AM, Sean Paul wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang <y...@rock-chips.com> wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the hardware framebuffer in panel, this would make lots of

Re: [PATCH v3 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-07 Thread Yakir Yang
Sean, On 07/02/2016 02:00 AM, Sean Paul wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang <y...@rock-chips.com> wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_

Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

2016-07-07 Thread Yakir Yang
Doug, On 06/14/2016 01:00 AM, Doug Anderson wrote: Yakir, On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang <y...@rock-chips.com> wrote: The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel connected using eDP interfaces. Signed-off-by: Yakir Yang <y...@

[PATCH v3 1/4] drm/rockchip: vop: export line flag function

2016-07-01 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes

[PATCH v3 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-01 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - split analogix_dp_enable_psr(), make it more clearly analogix_dp_detect_sink_psr() analogix_dp_enable_sink_psr() - remove some nosie register setting comments Changes

[PATCH v3 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-01 Thread Yakir Yang
driver would call the flush interface in 'fb->dirty' callback, this helper function would force all PSR enabled encoders to exit from PSR for 3 seconds. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - split the psr flow into an common abstracted PSR driver - implemen

[PATCH v3 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-01 Thread Yakir Yang
Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - split the common psr logic into a seperate driver, make this to a simple s

[PATCH v3 0/4] Add PSR function support for Analogix/Rockchip DP

2016-07-01 Thread Yakir Yang
v2, split VOP line flag changes out - introduce in v2, splite the common Analogix DP changes out - remove vblank notify out (Daniel) - create a psr_active() callback in vop data struct. Yakir Yang (4): drm/rockchip: vop: export line flag function drm/rockchip: add an common abstracted PSR dri

Re: [PATCH v4 0/11] Misc fixup and add RK3399 eDP support to Analogix DP driver[Involving remittance information, please pay attention to the safety of property]

2016-06-30 Thread Yakir Yang
Sean, On 06/29/2016 10:01 PM, Sean Paul wrote: On Wed, Jun 29, 2016 at 5:14 AM, Yakir Yang <y...@rock-chips.com> wrote: RK3399 and RK3288 shared the same eDP IP controller, only some light difference with VOP configure and GRF configure. The whole set looks good to me. All patches

[PATCH v4 04/11] drm/rockchip: analogix_dp: add rk3399 eDP support

2016-06-29 Thread Yakir Yang
RK3399 and RK3288 shared the same eDP IP controller, only some light difference with VOP configure and GRF configure. Signed-off-by: Yakir Yang <y...@rock-chips.com> Acked-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Tomasz Figa <tomasz.f...@chromium.com> --- Changes

[PATCH v4 08/11] drm/rockchip: analogix_dp: update the comments about why need to hardcode VOP output mode

2016-06-29 Thread Yakir Yang
The hardware IC designed that VOP must output the RGB10 video format to eDP contoller, and if eDP panel only support RGB8, then eDP contoller should cut down the video data, not via VOP contoller, that's why we need to hardcode the VOP output mode to RGA10 here. Signed-off-by: Yakir Yang &l

[PATCH v4 11/11] dt-bindings: analogix_dp: rockchip: correct the wrong compatible name

2016-06-29 Thread Yakir Yang
ment for rockchip variant of analogix_dp"). Reported-by: Tomasz Figa <tf...@chromium.com> Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Douglas Anderson <diand...@chromium.org> Reviewed-by: Tomasz Figa <tomasz.f...@chromium.com> --- Changes in v4: - Add re

[PATCH v4 10/11] drm/rockchip: analogix_dp: introduce the pclk for grf

2016-06-29 Thread Yakir Yang
For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Douglas An

[PATCH v4 07/11] drm/rockchip: analogix_dp: correct the connector display color format and bpc

2016-06-29 Thread Yakir Yang
Rockchip VOP couldn't output YUV video format for eDP controller, so when driver detect connector support YUV video format, we need to hack it down to RGB888. Signed-off-by: Yakir Yang <y...@rock-chips.com> Acked-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Tomasz Fi

[PATCH v4 09/11] drm/bridge: analogix_dp: fix no drm hpd event when panel plug in

2016-06-29 Thread Yakir Yang
at just need to assign all hotplug enum with no-zero values. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> Reviewed-by: Stéphane Marchesin <marc...@chromium.org> Rev

[PATCH v4 05/11] drm/rockchip: analogix_dp: make panel detect to an optional action

2016-06-29 Thread Yakir Yang
Some boards don't need to declare a panel device node, like the display interface is DP monitors, so it's necessary to make the panel detect to an optional action. Signed-off-by: Yakir Yang <y...@rock-chips.com> Acked-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Tomasz Fi

[PATCH v4 06/11] drm/bridge: analogix_dp: passing the connector as an argument in .get_modes()

2016-06-29 Thread Yakir Yang
It's better to pass the connector to platform driver in .get_modes() callback, just like what the .get_modes() helper function designed. Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> Reviewed-by: Tomasz Figa <tomasz.f...@chromium.c

[PATCH v4 03/11] drm/bridge: analogix_dp: some rockchip chips need to flip REF_CLK bit setting

2016-06-29 Thread Yakir Yang
hack. Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Tomasz Figa <tomasz.f...@chromium.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes in v4: - Remove subdev_type number, and add 'is_rockchip(type)' helper function (Sean) - Add reviewe

[PATCH v4 01/11] drm/rockchip: analogix_dp: split the lcdc select setting into device data

2016-06-29 Thread Yakir Yang
eDP controller need to declare which vop provide the video source, and it's defined in GRF registers. But different chips have different GRF register address, so we need to create a device data to declare the GRF messages for each chips. Signed-off-by: Yakir Yang <y...@rock-chips.com>

[PATCH v4 02/11] drm/bridge: analogix_dp: correct the register bit define error in ANALOGIX_DP_PLL_REG_1

2016-06-29 Thread Yakir Yang
There're an register define error in ANALOGIX_DP_PLL_REG_1 which introduced by commit bcec20fd5ad6 ("drm: bridge: analogix/dp: add some rk3288 special registers setting"). The PHY PLL input clock source is selected by ANALOGIX_DP_PLL_REG_1 BIT 0, not BIT 1. Signed-off-by: Yakir Yang

[PATCH v4 0/11] Misc fixup and add RK3399 eDP support to Analogix DP driver

2016-06-29 Thread Yakir Yang
acked flag from Mark. - Add the reviewed flag from Tomasz. [https://chromium-review.googlesource.com/#/c/346853/12] - Add the acked flag from Mark. - Add reviewed flag from Stéphane. [https://chromium-review.googlesource.com/#/c/346319/15] - Add tested flag from Javier - Add this patch in v

Re: [PATCH v3 04/10] drm/bridge: analogix_dp: some rockchip chips need to flip REF_CLK bit setting

2016-06-29 Thread Yakir Yang
Sean, On 06/23/2016 09:27 PM, Sean Paul wrote: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: As vendor document indicate, when REF_CLK bit set 0, then DP phy's REF_CLK should switch to 24M source clock. But due to IC PHY layout mistaken, some chips need t

Re: [PATCH v3 03/10] drm/bridge: analogix_dp: correct the register bit define error in ANALOGIX_DP_PLL_REG_1

2016-06-29 Thread Yakir Yang
Sean, On 06/23/2016 10:33 PM, Sean Paul wrote: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: There're an register define error in ANALOGIX_DP_PLL_REG_1 which introduced by commit bcec20fd5ad6 ("drm: bridge: analogix/dp: add some rk3288 special regist

Re: [PATCH v3 02/10] drm/rockchip: analogix_dp: split the lcdc select setting into device data[Involving remittance information, please pay attention to the safety of property]

2016-06-29 Thread Yakir Yang
Heiko & Sean On 06/24/2016 12:16 AM, Heiko Stuebner wrote: Am Donnerstag, 23. Juni 2016, 10:32:53 schrieb Sean Paul: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: eDP controller need to declare which vop provide the video source, and it's defined in GRF

Re: [PATCH v3 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support

2016-06-29 Thread Yakir Yang
Sean, On 06/23/2016 09:48 PM, Sean Paul wrote: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: RK3399 and RK3288 shared the same eDP IP controller, only some light difference with VOP configure and GRF configure. Signed-off-by: Yakir Yang <y...@rock-chips.c

Re: [PATCH v3 06/10] drm/rockchip: analogix_dp: make panel detect to an optional action

2016-06-29 Thread Yakir Yang
Sean, On 06/23/2016 10:10 PM, Sean Paul wrote: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: Some boards don't need to declare a panel device node, like the display interface is DP monitors, so it's necessary to make the panel detect to an optional action.

Re: [PATCH v3 09/10] drm/rockchip: analogix_dp: update the comments about why need to hardcode VOP output mode

2016-06-29 Thread Yakir Yang
Sean, On 06/23/2016 10:22 PM, Sean Paul wrote: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: The hardware IC designed that VOP must output the RGB10 video format to eDP contoller, and if eDP panel only support RGB8, then eDP contoller should cut down the vide

Re: [PATCH v3 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc

2016-06-29 Thread Yakir Yang
Sean, On 06/23/2016 10:19 PM, Sean Paul wrote: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: Rockchip VOP couldn't output YUV video format for eDP controller, so when driver detect connector support YUV video format, we need to hack it down to RGB888. Sign

Re: [PATCH v3 10/10] drm/bridge: analogix_dp: fix no drm hpd event when panel plug in

2016-06-28 Thread Yakir Yang
Sean, On 06/23/2016 10:24 PM, Sean Paul wrote: On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <y...@rock-chips.com> wrote: The enum value of DP_IRQ_TYPE_HP_CABLE_IN is zero, but driver only send drm hp event when the irq_type and the enum value is true. if (irq_type & DP_IRQ_TYPE_H

Re: [PATCH v4.1 1/2] drm/rockchip: analogix_dp: introduce the pclk for grf

2016-06-28 Thread Yakir Yang
Doug, On 06/23/2016 01:16 PM, Doug Anderson wrote: Yakir, On Wed, Jun 22, 2016 at 6:58 PM, Yakir Yang <y...@rock-chips.com> wrote: For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, s

Re: [PATCH v4 2/2] dt-bindings: analogix_dp: rockchip: correct the wrong compatible name

2016-06-28 Thread Yakir Yang
Doug, On 06/23/2016 01:17 PM, Doug Anderson wrote: Hi, On Wed, Jun 22, 2016 at 6:47 PM, Yakir Yang <y...@rock-chips.com> wrote: The document about rockchip platform make a mistaken in available compatible name of "rk3288-edp", we should correct it to "rk3288

Re: [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel

2016-06-28 Thread Yakir Yang
Rob, On 06/29/2016 04:59 AM, Rob Herring wrote: On Tue, Jun 28, 2016 at 12:51:12PM +0800, Yakir Yang wrote: The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and 32 pins eDP interface. This module supports 1536x2048 mode. Signed-off-by: Yakir Yang <y...@rock-c

[PATCH v1 3/5] ARM: dts: rockchip: add eDP/panel display device nodes for rk3288-evb

2016-06-27 Thread Yakir Yang
The default eDP panel on RK3288 EVB board is LG LP079QX1-SP0V TFT LCD, we haven't declared the panel regulator in the 'panel-simple' device node here, so the specific board like ACT8846 / RK8080 need to support the panel power supply. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- ar

[PATCH v1 4/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with act8846 pmu

2016-06-27 Thread Yakir Yang
Panel regulator is controller by a normal GPIO, so we need to write a regulator-fixed node for it. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- arch/arm/boot/dts/rk3288-evb-act8846.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts

[PATCH v1 2/5] drm/panel: simple: Add support for LG LP079QX1-SP0V 1536x2048 panel

2016-06-27 Thread Yakir Yang
The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and 32 pins eDP interface. This module supports 1536x2048 mode. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/panel/panel-simple.c | 26 ++ 1 file changed, 26 insertions(+)

[PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel

2016-06-27 Thread Yakir Yang
The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and 32 pins eDP interface. This module supports 1536x2048 mode. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- .../devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt | 7 +++ 1 file changed, 7

[PATCH v1 5/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with rk808 pmu

2016-06-27 Thread Yakir Yang
Panel regulator is controller by a normal GPIO, so we need to write a regulator-fixed node for it. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- arch/arm/boot/dts/rk3288-evb-rk808.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/ar

[PATCH v1 0/5] Enable graphic support on RK3288 EVB boards

2016-06-27 Thread Yakir Yang
Hi Heiko, This series just want to enable the graphic support on RK3288 EVB boards, most of them are DTS changes, but still have one change about new eDP panel support. Thanks, - Yakir Yakir Yang (5): dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel drm/panel: simple: Add

[PATCH v4.1 1/2] drm/rockchip: analogix_dp: introduce the pclk for grf

2016-06-22 Thread Yakir Yang
For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Hi all, This is an ex

[PATCH v4 2/2] dt-bindings: analogix_dp: rockchip: correct the wrong compatible name

2016-06-22 Thread Yakir Yang
ment for rockchip variant of analogix_dp"). Reported-by: Tomasz Figa <tf...@chromium.com> Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Hi all, This is an external patch for analogix_dp misc cleanup thread [0] [0]: https://patchwork.kernel.org/patch/9175613/ BR, - Yakir Changes i

  1   2   3   4   5   6   7   8   >