RE: [EXT] [PATCH net-next 07/15] net: mvpp2: fix the computation of the RXQs

2019-02-28 Thread Yan Markman
OK-OK. The " It does fix PPv2.1 support, which was broken" is great reason! -Original Message- From: Antoine Tenart Sent: Thursday, February 28, 2019 5:51 PM To: Yan Markman Cc: Antoine Tenart ; da...@davemloft.net; li...@armlinux.org.uk; net...@vger.kernel.org; li

RE: [EXT] [PATCH net-next 07/15] net: mvpp2: fix the computation of the RXQs

2019-02-28 Thread Yan Markman
else is correct also for the MVPP2_SINGLE_RESOURCE_MODE, but new/patched isn't. Since this patch doesn't change any functionality (right now) but reduces the flexibility I do not see real reason to apply it. Regards Yan Markman -Original Message- From: Antoine Tenart Sent: Thur

RE: [EXT] [PATCH net-next 15/15] net: mvpp2: set the GMAC, XLG MAC, XPCS and MPCS in reset when a port is down

2019-02-28 Thread Yan Markman
Hi The eth-down/stop may concurrent with pre-scheduled stats_work. So it seems better to cancel stats_work first and then make resetS. Yan Markman -Original Message- From: Antoine Tenart Sent: Thursday, February 28, 2019 3:21 PM To: da...@davemloft.net; li...@armlinux.org.uk Cc

RE: [EXT] [PATCH net-next v2 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool

2018-03-28 Thread Yan Markman
Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To: net

RE: [EXT] [PATCH net-next v2 0/2] phylink: API changes

2018-03-28 Thread Yan Markman
Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To: net

RE: [EXT] [PATCH net-next v2 1/2] net: phy: phylink: Provide PHY interface to mac_link_{up,down}

2018-03-28 Thread Yan Markman
Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To: net

RE: [EXT] Re: [PATCH net-next] net: mvpp2: Use relaxed I/O in data path

2018-03-27 Thread Yan Markman
Thanks David We are aware and it is working properly Yan Markman -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Tuesday, March 27, 2018 8:16 PM To: maxime.chevall...@bootlin.com Cc: Yan Markman ; net...@vger.kernel.org; linux-kernel@vger.kernel.org

RE: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-21 Thread Yan Markman
check the correctnes of new "mvpp2_prs_entry pe" without memset(pe, 0, sizeof(pe)); in all procedures where pe=kzalloc() has been replaced Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Maxime Chevallier [mailto:maxime.chevall...@bootlin.com] Sent: Wednesd

RE: [EXT] Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation

2018-03-19 Thread Yan Markman
The DTS-patch for this board (in "old" format) is attached Yan Markman Tel. 05-44732819 -Original Message- From: Stefan Chulski Sent: Monday, March 19, 2018 2:58 PM To: Russell King - ARM Linux ; Antoine Tenart Cc: da...@davemloft.net; kis...@ti.com; gregory.clem...@b

RE: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds

2018-02-27 Thread Yan Markman
I will make this tomorrow. Thanks for attention! Best regards Yan Markman Tel. 05-44732819 -Original Message- From: Antoine Tenart [mailto:antoine.ten...@bootlin.com] Sent: Tuesday, February 27, 2018 7:14 PM To: David Miller Cc: antoine.ten...@bootlin.com; Yan Markman ; m

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-12-02 Thread Yan Markman
UP but FALSE on down netif_carrier_off(port->dev);//YANM BTW: It's seems your below patch should be present anyway. +++ b/drivers/net/phy/phylink.c @@ -798,6 +798,7 @@ void phylink_disconnect_phy(struct phylink *pl) + pl->phy_state.link = false; Thank you Best regards Yan Markman

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-30 Thread Yan Markman
essage- From: Russell King - ARM Linux [mailto:li...@armlinux.org.uk] Sent: Wednesday, November 29, 2017 11:21 PM To: Yan Markman Cc: Antoine Tenart ; and...@lunn.ch; f.faine...@gmail.com; da...@davemloft.net; gregory.clem...@free-electrons.com; thomas.petazz...@free-electrons.com; miquel.ray..

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-29 Thread Yan Markman
down the callback pl->ops->mac_link_down(ndev, pl->link_an_mode); would be called, but it isn't -Original Message- From: Russell King - ARM Linux [mailto:li...@armlinux.org.uk] Sent: Wednesday, November 29, 2017 9:59 PM To: Yan Markman Cc: Antoine Tenart ; an

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-29 Thread Yan Markman
re passing over full graceful down/reset state. The further ifconfig-up starts with old state parameters. Special cases not-tested but logic 2 test-cases are: remote side changes speed whilst link is Down or Disconnected. But local ifconfig-up starts with old speed. Best