[PATCH -next] fs: Fix kernel-doc comments to functions

2024-03-22 Thread Yang Li
This commit fix kernel-doc style comments with complete parameter descriptions for the lookup_file(),lookup_dir_entry() and lookup_file_dentry(). Signed-off-by: Yang Li --- fs/tracefs/event_inode.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/fs/tracefs

[PATCH -next] libnvdimm: Fix some kernel-doc comments

2023-02-19 Thread Yang Li
-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4118 Signed-off-by: Yang Li --- drivers/nvdimm/dimm_devs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c index 957f7c3d17ba..fc152e6016ca 100644

[PATCH -next] nvdimm: make security_show() static

2022-12-05 Thread Yang Li
-by: Yang Li --- drivers/nvdimm/dimm_devs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c index 17b56171c2c2..71fef964c5bc 100644 --- a/drivers/nvdimm/dimm_devs.c +++ b/drivers/nvdimm/dimm_devs.c @@ -349,7 +349,7 @@ static

[PATCH -next] nvdimm: Fix some kernel-doc comments

2022-12-05 Thread Yang Li
://bugzilla.openanolis.cn/show_bug.cgi?id=3361 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/nvdimm/dimm_devs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c index 1fc081dcf631..17b56171c2c2 100644

[PATCH -next] nvdimm/btt: Fix btt_init() kernel-doc comment

2021-12-30 Thread Yang Li
/nvdimm/btt.c:1584: warning: Excess function parameter 'maxlane' description in 'btt_init' Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/nvdimm/btt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index da3f007a1211

[PATCH] x86/platform/uv: Fix inconsistent indenting

2021-04-16 Thread Yang Li
Kernel test robot throws below warning -> smatch warnings: arch/x86/kernel/apic/x2apic_uv_x.c:111 early_get_pnodeid() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/x86/kernel/apic/x2apic_uv_x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH] ALSA: seq: oss: Fix inconsistent indenting

2021-04-16 Thread Yang Li
Kernel test robot throws below warning -> smatch warnings: sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: inconsistent indenting Fixed the inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Yang Li --- sound/core/seq/oss/seq_oss_event.c | 2 +- 1 file changed

[PATCH] ALSA: isa: Fix inconsistent indenting

2021-04-16 Thread Yang Li
Kernel test robot throws below warning -> smatch warnings: sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn: inconsistent indenting sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- so

[PATCH] drm/radeon/si: Fix inconsistent indenting

2021-04-15 Thread Yang Li
Kernel test robot throws below warning -> smatch warnings: drivers/gpu/drm/radeon/si.c:4514 si_vm_packet3_cp_dma_check() warn: inconsistent indenting Fixed the inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/radeon/si.c | 2 +- 1 file changed

[PATCH] ASoC: cs35l35: remove unused including

2021-04-14 Thread Yang Li
Fix the following versioncheck warning: ./sound/soc/codecs/cs35l35.c: 12 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- sound/soc/codecs/cs35l35.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index

[PATCH] usb: core: remove unused including

2021-04-14 Thread Yang Li
Fix the following versioncheck warning: ./drivers/usb/core/hcd.c: 14 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/usb/core/hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 3f03813..53bc93d

[PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Yang Li
Robot Signed-off-by: Yang Li --- tools/testing/selftests/bpf/progs/profiler.inc.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h index 4896fdf8..a33066c

[PATCH] Drivers: hv: vmbus: remove unused including

2021-04-13 Thread Yang Li
Fix the following versioncheck warning: ./drivers/hv/hv.c: 16 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/hv/hv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index f202ac7..2c3ae4d 100644 --- a/drivers/hv/hv.c

[PATCH] i2c: busses: remove unused including

2021-04-13 Thread Yang Li
Fix the following versioncheck warnings: ./drivers/i2c/busses/i2c-xgene-slimpro.c: 22 linux/version.h not needed. ./drivers/i2c/busses/i2c-brcmstb.c: 25 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/i2c/busses/i2c-brcmstb.c | 1 - drivers/i2c

[PATCH] rsi: remove unused including

2021-04-13 Thread Yang Li
Fix the following versioncheck warning: ./drivers/net/wireless/rsi/rsi_91x_ps.c: 19 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/rsi/rsi_91x_ps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_ps.c b

[PATCH v2] scsi: qlogicpti: remove unneeded semicolon

2021-04-12 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/scsi/qlogicpti.c:1153:3-4: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: --One patch per driver drivers/scsi/qlogicpti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2] scsi: pmcraid: remove unneeded semicolon

2021-04-12 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/scsi/pmcraid.c:5090:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: --One patch per driver drivers/scsi/pmcraid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi

[PATCH v2] scsi: ipr: remove unneeded semicolon

2021-04-12 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/scsi/ipr.h:1979:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: --One patch per driver drivers/scsi/ipr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ipr.h b

[PATCH v2] scsi: aha1542: remove unneeded semicolon

2021-04-12 Thread Yang Li
:671:2-3: Unneeded semicolon ./drivers/scsi/aha1542.c:690:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- Changes in v2: --One patch per driver drivers/scsi/aha1542.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[tip: x86/cleanups] x86/cacheinfo: Remove unneeded dead-store initialization

2021-04-07 Thread tip-bot2 for Yang Li
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: dda451f391eee5d68db3ca87fd8b2a42c8c2b507 Gitweb: https://git.kernel.org/tip/dda451f391eee5d68db3ca87fd8b2a42c8c2b507 Author:Yang Li AuthorDate:Wed, 31 Mar 2021 16:00:24 +08:00 Committer

[PATCH] media: uvc: remove unused including

2021-04-05 Thread Yang Li
Fix the following versioncheck warning: ./drivers/media/usb/uvc/uvc_driver.c: 19 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/media/usb/uvc/uvc_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers

[PATCH] um: remove unused including

2021-04-05 Thread Yang Li
Fix the following versioncheck warning: ./arch/um/drivers/vector_kern.c: 11 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/um/drivers/vector_kern.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers

[PATCH] x86/hyperv: remove unused including

2021-04-05 Thread Yang Li
Fix the following versioncheck warning: ./arch/x86/hyperv/hv_proc.c: 3 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/x86/hyperv/hv_proc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/hyperv/hv_proc.c b/arch/x86/hyperv/hv_proc.c index

[PATCH] csky: remove unused including

2021-04-05 Thread Yang Li
-by: Abaci Robot Signed-off-by: Yang Li --- arch/csky/include/asm/io.h | 1 - arch/csky/include/asm/uaccess.h | 1 - arch/csky/kernel/process.c | 1 - arch/csky/mm/dma-mapping.c | 1 - 4 files changed, 4 deletions(-) diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm

[PATCH] powerpc/pseries: remove unneeded semicolon

2021-04-05 Thread Yang Li
Eliminate the following coccicheck warning: ./arch/powerpc/platforms/pseries/lpar.c:1633:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/powerpc/platforms/pseries/lpar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms

[PATCH] rapidio/rio_cm: Remove an unused variable 'rc'

2021-04-02 Thread Yang Li
Fixes the following W=1 kernel build warning(s): drivers/rapidio/rio_cm.c:673:7: warning: variable ???rc??? set but not used Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/rapidio/rio_cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rapidio

[PATCH] HID: intel-ish-hid: Remove an unused variable 'ret'

2021-04-02 Thread Yang Li
Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ipc/pci-ish.c:264:6: warning: variable ???ret??? set but not used Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH] mmc: moxart: Remove unused variable 'dma_time' and 'pio_time'

2021-04-02 Thread Yang Li
Fixes the following W=1 kernel build warning(s): drivers/mmc/host/moxart-mmc.c:257:7: warning: variable ???dma_time??? set but not used drivers/mmc/host/moxart-mmc.c:395:7: warning: variable ???pio_time??? set but not used Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/mmc/host

[PATCH] coda: Remove various instances of an unused variable 'outp'

2021-04-02 Thread Yang Li
/upcall.c:456:20: warning: variable ‘outp’ set but not used fs/coda/upcall.c:574:20: warning: variable ‘outp’ set but not used Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/coda/upcall.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c index

[PATCH] KVM: x86: Fix potential memory access error

2021-03-31 Thread Yang Li
s_available Just use BIT instead. Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/x86/kvm/kvm_cache_regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/kvm_cache_regs.h b/arch/x86/kvm/kvm_cache_regs.h index 2e11da2..cfa45d88 100644 --- a/arch/x86/kvm/kv

[PATCH] rtlwifi: rtl8188ee: remove redundant assignment of variable rtlpriv->btcoexist.reg_bt_sco

2021-03-31 Thread Yang Li
e_bt_reg_init Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c index 861cc66..bf686

[PATCH] x86/kernel: remove unneeded dead-store initialization

2021-03-31 Thread Yang Li
Signed-off-by: Yang Li --- arch/x86/kernel/cpu/cacheinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c index 3ca9be4..d66af29 100644 --- a/arch/x86/kernel/cpu/cacheinfo.c +++ b/arch/x86/kernel/cpu/cacheinfo.c

[PATCH] x86/mce/dev-mcelog: Fix potential memory access error

2021-03-29 Thread Yang Li
nstead. Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/x86/kernel/cpu/mce/dev-mcelog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mce/dev-mcelog.c b/arch/x86/kernel/cpu/mce/dev-mcelog.c index 100fbee..fd7b1b4 100644 --- a/arch/x86/kernel/cp

[PATCH] misc: rtsx: check the value returned from a function for errors before being used

2021-03-24 Thread Yang Li
t; without checking return value. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/misc/cardreader/rtsx_pcr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/misc/cardreader/rtsx_pcr.c b/drivers/misc/cardreader/rtsx_pcr.c index 2733111..2cc37fd 100644 ---

[PATCH] genirq: Add missing IRQF_ONESHOT

2021-03-23 Thread Yang Li
fixed the following coccicheck: ./kernel/irq/manage.c:2193:8-28: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Reported-by: Abaci Robot Signed-off-by: Yang Li --- kernel/irq/manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq

[PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-23 Thread Yang Li
fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: -Modify the fourth parameter, not the first drivers/gpu/drm/omapdrm/dss

[PATCH] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-22 Thread Yang Li
fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Reported-by: Abaci Robot Signed-off-by: Yang Li

[PATCH] riscv: remove unneeded semicolon

2021-03-22 Thread Yang Li
Eliminate the following coccicheck warning: ./arch/riscv/mm/kasan_init.c:219:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/riscv/mm/kasan_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/mm/kasan_init.c b/arch/riscv/mm

[PATCH] drm/gma500: use NULL instead of using plain integer as pointer

2021-03-17 Thread Yang Li
This fixes the following sparse warnings: drivers/gpu/drm/gma500/psb_drv.c:303:56: warning: Using plain integer as NULL pointer Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH] EDAC: use NULL instead of using plain integer as pointer

2021-03-17 Thread Yang Li
:10: warning: Using plain integer as NULL pointer drivers/edac/sb_edac.c:680:10: warning: Using plain integer as NULL pointer Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/edac/sb_edac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/edac

[PATCH] um: replace if (cond) BUG() with BUG_ON()

2021-03-17 Thread Yang Li
Fix the following coccinelle reports: ./arch/um/kernel/mem.c:77:3-6: WARNING: Use BUG_ON instead of if condition followed by BUG. Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/um/kernel/mem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/um/kernel/mem.c

[PATCH] misc/sgi-xp: use NULL instead of using plain integer as pointer

2021-03-16 Thread Yang Li
This fixes the following sparse warnings: drivers/misc/sgi-xp/xpc_main.c:210:23: warning: Using plain integer as NULL pointer Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/misc/sgi-xp/xpc_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/sgi

[PATCH] bcache: use NULL instead of using plain integer as pointer

2021-03-16 Thread Yang Li
This fixes the following sparse warnings: drivers/md/bcache/features.c:22:16: warning: Using plain integer as NULL pointer Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/md/bcache/features.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bcache

[PATCH] perf tools: use true and false for bool variable

2021-03-15 Thread Yang Li
fixed the following coccicheck: ./tools/perf/util/jitdump.c:803:9-10: WARNING: return of 0/1 in function 'jit_has_pid' with return type bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- tools/perf/util/jitdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools

[PATCH] x86/pci: use true and false for bool variable

2021-03-15 Thread Yang Li
-shared.c:501:9-10: WARNING: return of 0/1 in function 'is_mmconf_reserved' with return type bool ./arch/x86/pci/mmconfig-shared.c:522:5-6: WARNING: return of 0/1 in function 'is_mmconf_reserved' with return type bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/x86/pci/mmconfig

[PATCH] powerpc/xive: use true and false for bool variable

2021-03-15 Thread Yang Li
fixed the following coccicheck: ./arch/powerpc/sysdev/xive/spapr.c:552:8-9: WARNING: return of 0/1 in function 'xive_spapr_match' with return type bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/powerpc/sysdev/xive/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] MIPS: generic: use true and false for bool variable

2021-03-15 Thread Yang Li
fixed the following coccicheck: ./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in function 'ocelot_detect' with return type bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/mips/generic/board-ocelot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH] ARM: OMAP2+: use true and false for bool variable

2021-03-15 Thread Yang Li
fixed the following coccicheck: ./arch/arm/mach-omap2/powerdomain.c:1205:9-10: WARNING: return of 0/1 in function 'pwrdm_can_ever_lose_context' with return type bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/arm/mach-omap2/powerdomain.c | 12 ++-- 1 file changed, 6

[PATCH] kconfig: use true and false for bool variable

2021-03-15 Thread Yang Li
fixed the following coccicheck: ./scripts/kconfig/confdata.c:36:9-10: WARNING: return of 0/1 in function 'is_dir' with return type bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts

[PATCH v2] char/mwave: turn tp3780I_Cleanup() into void function

2021-03-10 Thread Yang Li
This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./drivers/char/mwave/tp3780i.c:182:5-11: Unneeded variable: "retval". Return "0" on line 187 Reported-by: Abaci Robot Si

[PATCH] isdn: mISDN: remove unneeded variable 'ret'

2021-03-10 Thread Yang Li
Fix the following coccicheck warning: ./drivers/isdn/mISDN/dsp_core.c:956:6-9: Unneeded variable: "err". Return "0" on line 1001 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/isdn/mISDN/dsp_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] media: i2c: remove unneeded variable 'ret'

2021-03-10 Thread Yang Li
Fix the following coccicheck warning: ./drivers/media/i2c/ov8865.c:2527:5-8: Unneeded variable: "ret". Return "0" on line 2536 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/media/i2c/ov8865.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] microblaze: remove unneeded variable 'err'

2021-03-10 Thread Yang Li
Fix the following coccicheck warning: ./arch/microblaze/kernel/signal.c:60:14-17: Unneeded variable: "err". Return "0" on line 78 Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/microblaze/kernel/signal.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[PATCH] uml: remove unneeded variable 'ret'

2021-03-10 Thread Yang Li
Fix the following coccicheck warning: ./arch/um/drivers/hostaudio_kern.c:125:10-14: Unneeded variable: "mask". Return "0" on line 131 Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/um/drivers/hostaudio_kern.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[PATCH] char/mwave: turn tp3780I_InitializeBoardData() into void function

2021-03-10 Thread Yang Li
This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./drivers/char/mwave/tp3780i.c:182:5-11: Unneeded variable: "retval". Return "0" on line 187 Reported-by: Abaci Robot Si

[PATCH] btrfs: turn btrfs_destroy_delayed_refs() into void function

2021-03-09 Thread Yang Li
This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./fs/btrfs/disk-io.c:4522:5-8: Unneeded variable: "ret". Return "0" on line 4530 Reported-by: Abaci Robot Signed-off-by: Yang Li

[PATCH] dm: remove unneeded variable 'sz'

2021-03-09 Thread Yang Li
Fix the following coccicheck warning: ./drivers/md/dm-ps-service-time.c:85:10-12: Unneeded variable: "sz". Return "0" on line 105 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/md/dm-ps-service-time.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) dif

[PATCH] mmc: via-sdmmc: remove unneeded variable 'ret'

2021-03-08 Thread Yang Li
Fix the following coccicheck warning: ./drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". Return "0" on line 1295 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/mmc/host/via-sdmmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] scsi: 3w-sas: remove unneeded variable 'retval'

2021-03-08 Thread Yang Li
Fix the following coccicheck warning: ./drivers/scsi/3w-sas.c:866:5-11: Unneeded variable: "retval". Return "1" on line 898 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/3w-sas.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

[PATCH] io_uring: remove unneeded variable 'ret'

2021-03-08 Thread Yang Li
Fix the following coccicheck warning: ./fs/io_uring.c:8984:5-8: Unneeded variable: "ret". Return "0" on line 8998 Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/io_uring.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/io_uring.c b/fs/io_u

[PATCH] perf symbols: turn dso__fprintf_symbols_by_name into void function

2021-03-08 Thread Yang Li
This function always return '0' and no callers use the return value. So make it a void function. Reported-by: Abaci Robot Signed-off-by: Yang Li --- tools/perf/util/dso.h| 2 +- tools/perf/util/symbol_fprintf.c | 5 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH] sched/fair: Use true and false for bool variable

2021-03-08 Thread Yang Li
Fix the following coccicheck warning: ./kernel/sched/fair.c:9497:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] ASoC: bcm: add missing call to of_node_put()

2021-03-07 Thread Yang Li
Reported-by: Abaci Robot Signed-off-by: Yang Li --- sound/soc/bcm/cygnus-ssp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c index 6e634b4..aa16a23 100644 --- a/sound/soc/bcm/cygnus-ssp.c +++ b/sound/soc/bcm/cy

[PATCH] phy: hisilicon: add missing call to of_node_put()

2021-03-07 Thread Yang Li
d line 158. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c index 34a6a9a..c58115e 100644 --- a/d

[PATCH v2] usb: typec: tcpm: turn tcpm_ams_finish into void function

2021-03-07 Thread Yang Li
This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret". Return "0" on line 794 Reported-by: Abaci Robot Si

[PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function

2021-03-07 Thread Yang Li
This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret". Return "0" on line 794 Reported-by: Abaci Robot Si

[PATCH] gfs2: make function gfs2_make_fs_ro() to void type

2021-03-04 Thread Yang Li
It fixes the following warning detected by coccinelle: ./fs/gfs2/super.c:592:5-10: Unneeded variable: "error". Return "0" on line 628 Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/gfs2/ops_fstype.c | 4 +--- fs/gfs2/super.c | 9 +++-- fs/gfs2/super.h

[PATCH v2] ASoC: imx-hdmi: fix platform_no_drv_owner.cocci warnings

2021-03-04 Thread Yang Li
./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: -use imx-hdmi instead of hdmi-codec for Subject sound/soc/fsl/imx-hdmi.c

[PATCH] SoC: codecs: fix platform_no_drv_owner.cocci warnings

2021-03-03 Thread Yang Li
./sound/soc/codecs/lpass-rx-macro.c:3588:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Reported-by: Abaci Robot Signed-off-by: Yang Li --- sound/soc/codecs/lpass-rx-macro.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH] gfs2: Remove unneeded return variable

2021-03-02 Thread Yang Li
This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./fs/gfs2/super.c:592:5-10: Unneeded variable: "error". Return "0" on line 628 Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/gfs2/sup

[PATCH] of: property: Remove unneeded return variable

2021-03-02 Thread Yang Li
This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./drivers/of/property.c:1371:5-8: Unneeded variable: "ret". Return "0" on line 1388 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/of/p

[PATCH v2] crypto: sun8i-ce: use kfree_sensitive() instead of

2021-03-02 Thread Yang Li
/sun8i-ce/sun8i-ce-prng.c:42:16-17: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 41) ./drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c:161:8-9: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 109) Reported-by: Abaci Robot Signed-off-by: Yang Li

[PATCH] coda: switch to vmemdup_user()

2021-03-02 Thread Yang Li
Replace opencoded alloc and copy with vmemdup_user() fixed the following coccicheck: ./fs/coda/psdev.c:125:10-18: WARNING opportunity for vmemdup_user Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/coda/psdev.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff

[PATCH] btrfs: turn btrfs_destroy_all_ordered_extents() into void functions

2021-03-02 Thread Yang Li
These functions always return '0' and no callers use the return value. So make it a void function. It fixes the following warning detected by coccinelle: ./fs/btrfs/disk-io.c:4522:5-8: Unneeded variable: "ret". Return "0" on line 4530 Reported-by: Abaci Robot Signed-off-

[PATCH] xattr: switch to vmemdup_user()

2021-03-02 Thread Yang Li
Replace opencoded alloc and copy with vmemdup_user() fixed the following coccicheck: ./fs/xattr.c:561:11-19: WARNING opportunity for vmemdup_user Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/xattr.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs

[PATCH] crypto: sun8i-ce: rename kfree() to kfree_sensitive()

2021-03-01 Thread Yang Li
-ce-prng.c:42:16-17: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 41) ./drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c:161:8-9: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 109) Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers

[PATCH] driver core: Switch to using the new API kobj_to_dev()

2021-03-01 Thread Yang Li
fixed the following coccicheck: ./include/linux/device.h:590:46-47: WARNING opportunity for kobj_to_dev() Reported-by: Abaci Robot Signed-off-by: Yang Li --- include/linux/device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/device.h b/include/linux

[PATCH] scsi: scsi_transport_spi: Switch to using the new API kobj_to_dev()

2021-03-01 Thread Yang Li
fixed the following coccicheck: ./drivers/scsi/scsi_transport_spi.c:1471:61-62: WARNING opportunity for kobj_to_dev() Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/scsi_transport_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi

[PATCH] lightnvm: Switch to using the new API kobj_to_dev()

2021-03-01 Thread Yang Li
fixed the following coccicheck: ./drivers/nvme/host/lightnvm.c:1243:60-61: WARNING opportunity for kobj_to_dev() Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/nvme/host/lightnvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/lightnvm.c b

[PATCH] Input: cros_ec_keyb: Switch to using the new API kobj_to_dev()

2021-03-01 Thread Yang Li
fixed the following coccicheck: ./drivers/input/keyboard/cros_ec_keyb.c:647:60-61: WARNING opportunity for kobj_to_dev() Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/input/keyboard/cros_ec_keyb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input

[PATCH v2] regulator: add missing call to of_node_put()

2021-02-25 Thread Yang Li
Reported-by: Abaci Robot Signed-off-by: Yang Li --- Changes in v2: -add braces for if drivers/regulator/scmi-regulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c index 0e8b3ca..a917

[PATCH v2] pinctrl: ingenic: add missing call to of_node_put()

2021-02-25 Thread Yang Li
urn around line 2489. Reported-by: Abaci Robot Signed-off-by: Yang Li --- Changes in v2: -add braces for if drivers/pinctrl/pinctrl-ingenic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index f27461

[PATCH v2] media: exynos4-is: add missing call to of_node_put()

2021-02-25 Thread Yang Li
f_node_put() before return around line 492. Reported-by: Abaci Robot Signed-off-by: Yang Li --- Changes in v2: -add braces for if drivers/media/platform/exynos4-is/media-dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/dri

[PATCH v2] crypto/nx: add missing call to of_node_put()

2021-02-25 Thread Yang Li
Reported-by: Abaci Robot Signed-off-by: Yang Li --- Changes in v2: -add braces for if drivers/crypto/nx/nx-common-powernv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx-common-powernv.c b/drivers/crypto/nx/nx-common-powernv.c index 13c65de..446f

[PATCH] phy: ti: j721e-wiz: add missing call to of_node_put()

2021-02-25 Thread Yang Li
urn around line 795. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/phy/ti/phy-j721e-wiz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index c9cfafe..448d8d1 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/driv

[PATCH] pinctrl: ingenic: add missing call to of_node_put()

2021-02-25 Thread Yang Li
urn around line 2489. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/pinctrl/pinctrl-ingenic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index f274612..b7294a2 100644 --- a/drivers/pinctrl/pinctrl-ingen

[PATCH] powerpc: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-25 Thread Yang Li
be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/powerpc/kernel/setup_64.c| 6 +++--- arch/powerpc/platforms/powernv/memtrace.c | 4 ++-- arch/powerpc/xmon/xmon.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH] regulator: add missing call to of_node_put()

2021-02-25 Thread Yang Li
Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/regulator/scmi-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c index 0e8b3ca..a41bb06 100644 --- a/drivers/regulator/scmi-regulator.c +++ b/drivers

[PATCH] memory: tegra: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-25 Thread Yang Li
with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/memory/tegra/tegra124-emc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c index bee8d9f..874e1a0 100644 --- a/drivers

[PATCH] media: exynos4-is: add missing call to of_node_put()

2021-02-25 Thread Yang Li
f_node_put() before return around line 492. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/media/platform/exynos4-is/media-dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index 8e1e89

[PATCH] drm/amdgpu: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-25 Thread Yang Li
Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c index 0a25fec..52ef488 100644

[PATCH] direct-io: Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset()

2021-02-25 Thread Yang Li
Fix the following coccicheck warning: ./fs/direct-io.c:1155:7-23: WARNING: kmem_cache_zalloc should be used for dio, instead of kmem_cache_alloc/memset Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/direct-io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs

[PATCH] crypto/nx: add missing call to of_node_put()

2021-02-25 Thread Yang Li
Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/crypto/nx/nx-common-powernv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/nx/nx-common-powernv.c b/drivers/crypto/nx/nx-common-powernv.c index 13c65de..b43c457 100644 --- a/drivers/crypto/nx/nx-common-power

[PATCH] ARM: OMAP2+: add missing call to of_node_put()

2021-02-25 Thread Yang Li
Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/arm/mach-omap2/omap_hwmod.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 2310cd5..007e91e 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/

[PATCH] PM: AVS: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-24 Thread Yang Li
Fix the following coccicheck warning: ./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/soc/ti/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] Input: edt-ft5x06: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-24 Thread Yang Li
Fix the following coccicheck warning: ./drivers/input/touchscreen/edt-ft5x06.c:697:0-23: WARNING: debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/input/touchscreen/edt-ft5x06.c | 2 +- 1 file changed, 1 insertion

[PATCH] ocfs2: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-24 Thread Yang Li
Fix the following coccicheck warning: ./fs/ocfs2/blockcheck.c:232:0-23: WARNING: blockcheck_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/ocfs2/blockcheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[PATCH] remoteproc: pru: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-24 Thread Yang Li
Fix the following coccicheck warning: ./drivers/remoteproc/pru_rproc.c:247:0-23: WARNING: pru_rproc_debug_ss_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/remoteproc/pru_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] x86: platform: iosf_mbi: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-24 Thread Yang Li
Fix the following coccicheck warning: ./arch/x86/platform/intel/iosf_mbi.c:482:0-23: WARNING: iosf_mcr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/x86/platform/intel/iosf_mbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] mips: cavium: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-24 Thread Yang Li
Fix the following coccicheck warning: ./arch/mips/cavium-octeon/oct_ilm.c:65:0-23: WARNING: reset_statistics_ops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/mips/cavium-octeon/oct_ilm.c | 2 +- 1 file changed, 1 insertion(+), 1

  1   2   3   >