Re: [PATCH] [RESEND] x86/smpboot: avoid warning messages while hot-removing physical cpu

2018-02-07 Thread YASUAKI ISHIMATSU
lowing "Fixes:" tag in the description. Fixes: 30bb9811856f ("x86/topology: Avoid wasting 128k for package id array") Thanks, Yasuaki Ishimatsu On 02/05/2018 10:51 PM, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma <m.miz...@jp.fujitsu.com> > > When a p

Re: [PATCH] mm, meminit: Serially initialise deferred memory if trace_buf_size is specified

2017-11-15 Thread YASUAKI ISHIMATSU
still think 12M is large. But the latest Fujitsu server supports 448 CPUs. The issue may occur with trace_buf_size=10M on the system. Additionally the number of CPU in a server is increasing year by year. So the issue will occurs even if we don't specify large trace buffer. Thanks, Yasuaki Ishimatsu

Re: Allocation failure of ring buffer for trace

2017-11-14 Thread YASUAKI ISHIMATSU
[5.028681] node 6 initialised, 15982779 pages in 673ms [5.716102] node 7 initialised, 15987304 pages in 687ms [5.727855] smp: Bringing up secondary CPUs ... [5.745937] x86: Booting SMP configuration: Thanks, Yasuaki Ishimatsu On 11/14/2017 06:46 AM, Mel Gorman wrote: > On Mon, Nov

Re: Allocation failure of ring buffer for trace

2017-11-14 Thread YASUAKI ISHIMATSU
On 11/14/2017 10:53 AM, Mel Gorman wrote: > On Tue, Nov 14, 2017 at 10:39:19AM -0500, YASUAKI ISHIMATSU wrote: >> >> >> On 11/14/2017 06:46 AM, Mel Gorman wrote: >>> On Mon, Nov 13, 2017 at 12:48:36PM -0500, YASUAKI ISHIMATSU wrote: >>>> When using trac

Re: Allocation failure of ring buffer for trace

2017-11-14 Thread YASUAKI ISHIMATSU
On 11/14/2017 06:46 AM, Mel Gorman wrote: > On Mon, Nov 13, 2017 at 12:48:36PM -0500, YASUAKI ISHIMATSU wrote: >> When using trace_buf_size= boot option, memory allocation of ring buffer >> for trace fails as follows: >> >> [ ] x86: Booting SMP configurat

Allocation failure of ring buffer for trace

2017-11-13 Thread YASUAKI ISHIMATSU
o allocation failure occurs. Thanks, Yasuaki Ishimatsu

Re: system hung up when offlining CPUs

2017-10-16 Thread YASUAKI ISHIMATSU
t; smpboot_thread_fn => kthread => ret_from_fork <...>-1322 [187] d..1 1300.660985: irq_do_set_affinity: irq: 127 ret 2 mask: 186-187 eff: 186 <...>-1322 [187] d..1 1300.660993: => native_cpu_disable => take_cpu_down => multi_cpu_stop => cpu_sto

Re: system hung up when offlining CPUs

2017-10-10 Thread YASUAKI ISHIMATSU
Hi Thomas, Sorry for the late reply. I'll apply the patches and retest in this week. Please wait a while. Thanks, Yasuaki Ishimatsu On 10/04/2017 05:04 PM, Thomas Gleixner wrote: > On Tue, 3 Oct 2017, Thomas Gleixner wrote: >> Can you please apply the debug patch below. > > I

Re: system hung up when offlining CPUs

2017-10-02 Thread YASUAKI ISHIMATSU
On 09/16/2017 11:02 AM, Thomas Gleixner wrote: > On Sat, 16 Sep 2017, Thomas Gleixner wrote: >> On Thu, 14 Sep 2017, YASUAKI ISHIMATSU wrote: >>> Here are one irq's info of megasas: >>> >>> - Before offline CPU >>> /proc/irq/70/smp_affinity_list >

[PATCH 2/2] mm/memory_hotplug: define find_{smallest|biggest}_section_pfn as unsigned long

2017-09-15 Thread YASUAKI ISHIMATSU
bit value, the patch defines find_{smallest|biggest}_section_pfn() as unsigned long. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> --- mm/memory_hotplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c

[PATCH 1/2] mm/memory_hotplug: Change pfn_to_section_nr/section_nr_to_pfn macro to inline function

2017-09-15 Thread YASUAKI ISHIMATSU
and section_nr_to_pfn() does not calculate correct pfn. To make callers use proper arg, the patch changes the macros to inline functions. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> --- include/linux/mmzone.h | 10 -- mm/memory_hotplug.c| 2 +- 2 files changed, 9 inse

Re: system hung up when offlining CPUs

2017-09-14 Thread YASUAKI ISHIMATSU
On 09/13/2017 09:33 AM, Thomas Gleixner wrote: > On Wed, 13 Sep 2017, Kashyap Desai wrote: >>> On 09/12/2017 08:15 PM, YASUAKI ISHIMATSU wrote: >>>> + linux-scsi and maintainers of megasas > >>>>> In my server, IRQ#66-89 are sent to CPU#24-29. And if I

Re: [PATCH] mm/memory_hotplug: fix wrong casting for __remove_section()

2017-09-14 Thread YASUAKI ISHIMATSU
Hi Michal, On 09/13/2017 01:59 AM, Michal Hocko wrote: > On Tue 12-09-17 13:05:39, YASUAKI ISHIMATSU wrote: >> Hi Michal, >> >> Thanks you for reviewing my patch. >> >> On 09/12/2017 08:49 AM, Michal Hocko wrote: >>> On Fri 08-09-17 16:43:04, YASUAKI ISHI

Re: system hung up when offlining CPUs

2017-09-12 Thread YASUAKI ISHIMATSU
+ linux-scsi and maintainers of megasas When offlining CPU, I/O stops. Do you have any ideas? On 09/07/2017 04:23 PM, YASUAKI ISHIMATSU wrote: > Hi Mark and Christoph, > > Sorry for the late reply. I appreciated that you fixed the issue on kvm > environment. > But the iss

Re: [PATCH] mm/memory_hotplug: fix wrong casting for __remove_section()

2017-09-12 Thread YASUAKI ISHIMATSU
Hi Michal, Thanks you for reviewing my patch. On 09/12/2017 08:49 AM, Michal Hocko wrote: > On Fri 08-09-17 16:43:04, YASUAKI ISHIMATSU wrote: >> __remove_section() calls __remove_zone() to shrink zone and pgdat. >> But due to wrong castings, __remvoe_zone() cannot shrink zo

[PATCH] mm/memory_hotplug: fix wrong casting for __remove_section()

2017-09-08 Thread YASUAKI ISHIMATSU
. __remove_section() calculates start_pfn using section_nr_to_pfn() and scn_nr. section_nr_to_pfn() just shifts scn_nr by PFN_SECTION_SHIFT bit. But since scn_nr is defined as int, section_nr_to_pfn() always return 32 bit value. The patch fixes the wrong castings. Signed-off-by: Yasuaki Ishimatsu

Re: system hung up when offlining CPUs

2017-09-07 Thread YASUAKI ISHIMATSU
0 [...] R13: 7f0bd751f9c0 R14: 7f0bd751f700 R15: --- Thanks, Yasuaki Ishimatsu On 08/21/2017 09:37 AM, Marc Zyngier wrote: > On 21/08/17 14:18, Christoph Hellwig wrote: >> Can you try the patch below please? >> >> --- >> From d5f59cb7a62

Re: system hung up when offlining CPUs

2017-08-09 Thread YASUAKI ISHIMATSU
Hi Marc, On 08/09/2017 07:42 AM, Marc Zyngier wrote: > On Tue, 8 Aug 2017 15:25:35 -0400 > YASUAKI ISHIMATSU <yasu.isim...@gmail.com> wrote: > >> Hi Thomas, >> >> When offlining all CPUs except cpu0, system hung up with the following >> message. >

Re: [PATCH] x86/boot/KASLR: Extend movable_node option for KASLR

2017-08-09 Thread YASUAKI ISHIMATSU
ddress. Is this required by the current hot-plug memory code? >>>>>> >>>>> >>>>> Wow! So great, It seems this is required by the hot-plug memory code. >>>>> >>>>> yesterday, I tested the patch in Qemu with 4 node and e

system hung up when offlining CPUs

2017-08-08 Thread YASUAKI ISHIMATSU
/cpuhotplug: Handle managed IRQs on CPU hotplug Thanks, Yasuaki Ishimatsu

system hung up when offlining CPUs

2017-08-08 Thread YASUAKI ISHIMATSU
/cpuhotplug: Handle managed IRQs on CPU hotplug Thanks, Yasuaki Ishimatsu

Re: [PATCH] x86/boot/KASLR: Extend movable_node option for KASLR

2017-08-08 Thread YASUAKI ISHIMATSU
gt;>>>> But actually, we should have 4G normally. >>>> >>>> So do you have assumption on the order of immovable nodes and movable >>>> nodes? E.g above your example of nodes, immovable nodes have to be the >>>> lowest address. Is this required

Re: A udev rule to serve the change event of ACPI container?

2017-08-03 Thread YASUAKI ISHIMATSU
On 08/02/2017 01:49 AM, joeyli wrote: > Hi YASUAKI, > > On Tue, Aug 01, 2017 at 03:21:38PM -0400, YASUAKI ISHIMATSU wrote: >> Hi Joey, >> >> On 07/23/2017 05:18 AM, joeyli wrote: > [...snip] >>>>> >>>> >>>> At least Yas

Re: A udev rule to serve the change event of ACPI container?

2017-08-01 Thread YASUAKI ISHIMATSU
e I do not see how it >>> fits into the container and online/offline scenario. >>> >> >> At least Yasuaki raised similar behavior for container in 2013. >> It's similar to the DVD player case, user space application needs >> to do something then trigger children

4.12.0-rc6: kernel BUG at arch/x86/mm/init_64.c:128!

2017-06-29 Thread YASUAKI ISHIMATSU
mation, the issue does not occur if I just do memory hot-add. But if I hot add the memory after hot removing a memory, the issue occurs 100%. Thanks, Yasuaki Ishimatsu

Re: A udev rule to serve the change event of ACPI container?

2017-06-28 Thread YASUAKI ISHIMATSU
erspace is responsible for the whole container offlining. Thanks, Yasuaki Ishimatsu ` > > - After a couple of years, can we let the container hot-remove >process transparently? > - Except udev rule, does there have any other mechanism to trigger >auto offline/ejectio

Re: [PATCH v3 0/3] Handle memmap and mem kernel options in boot stage kaslr

2017-04-27 Thread YASUAKI ISHIMATSU
Kernel can't be randomized to be above the limit. I confirmed that mem= works correctly. Tested-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki Ishimatsu > > *) kernel-parameters.txt doesn't tell the updated behaviour of memmap=. > > This patchset tr

Re: [PATCH 2/9] mm, memory_hotplug: use node instead of zone in can_online_high_movable

2017-04-13 Thread YASUAKI ISHIMATSU
l change > > Signed-off-by: Michal Hocko <mho...@suse.com> > --- Reviewed-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki Ishimatsu > mm/memory_hotplug.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [PATCH 1/9] mm: remove return value from init_currently_empty_zone

2017-04-13 Thread YASUAKI ISHIMATSU
simplify all callers. > > This patch shouldn't have any visible effect > > Signed-off-by: Michal Hocko <mho...@suse.com> > --- Reviewed-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki Ishimatsu > include/linux/mmzone.h | 2 +- > mm/memory_hotplu

Re: WTH is going on with memory hotplug sysf interface

2017-03-14 Thread YASUAKI ISHIMATSU
On 03/13/2017 05:19 AM, Michal Hocko wrote: On Fri 10-03-17 12:39:27, Yasuaki Ishimatsu wrote: On 03/10/2017 08:58 AM, Michal Hocko wrote: [...] OK so I did with -m 2G,slots=4,maxmem=4G -numa node,mem=1G -numa node,mem=1G which generated [...] [0.00] ACPI: SRAT: Node 0 PXM 0 [mem

Re: WTH is going on with memory hotplug sysf interface

2017-03-10 Thread Yasuaki Ishimatsu
it seems to have made management of these zone structs simple. Thanks, Yasuaki Ishimatsu This would explain why onlining from the last block actually works but to me this sounds like a completely crappy behavior. All we need to guarantee AFAICS is that Normal and Movable zones do not overlap

Re: [Resend PATCH 2/2] mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next

2017-02-03 Thread Yasuaki Ishimatsu
TAB was replaced to white spaces. So please apply this one. --- From: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Date: Fri, 3 Feb 2017 15:18:03 -0500 Subject: [PATCH] mm/memory_hotplug: Remove unnecessary code from get_page_bootmem() The following patch is not applied correctly

Re: [Resend PATCH 2/2] mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next

2017-02-03 Thread Yasuaki Ishimatsu
Hi Andrew, Please apply the following patch into your tree because patch ("mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next") is not applied correctly. --- From: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Date: Fri, 3 Feb 2017

Re: [patch 0/3] perf/x86/intel: Fix RAPL and UNCORE hotplug issues

2017-02-01 Thread Yasuaki Ishimatsu
(+), 178 deletions(-) I tested physical CPU hot-add and remove with your patch-set. And I confirmed that the patch-set works good to me. Tested-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki Ishimatsu

Re: [PATCH] perf/x86/intel/rapl: Rename rapl_cpu_prepare() to rapl_cpu_starting()

2017-01-30 Thread Yasuaki Ishimatsu
On 01/30/2017 11:56 AM, Thomas Gleixner wrote: On Mon, 30 Jan 2017, Yasuaki Ishimatsu wrote: Hi Thomas, Do you have any idea to fix the issue? If you have the idea, please send me the patch. Yes, I have a patch, but need to do some tests and get changelogs written. Will keep you updated

Re: [PATCH] perf/x86/intel/rapl: Rename rapl_cpu_prepare() to rapl_cpu_starting()

2017-01-30 Thread Yasuaki Ishimatsu
Hi Thomas, Do you have any idea to fix the issue? If you have the idea, please send me the patch. Thanks, Yasuaki Ishimatsu On 01/24/2017 02:54 PM, Thomas Gleixner wrote: On Tue, 24 Jan 2017, Yasuaki Ishimatsu wrote: rapl_cpu_prepare() must be called after logical package id of CPU is set

Re: [PATCH] perf/x86/intel/rapl: Rename rapl_cpu_prepare() to rapl_cpu_starting()

2017-01-24 Thread Yasuaki Ishimatsu
Hi Thomas, Thank you for your review. I'm not familiar with the component. So I need your help to fix the issue. Thanks, Yasuaki Ishimatsu On 01/24/2017 02:54 PM, Thomas Gleixner wrote: On Tue, 24 Jan 2017, Yasuaki Ishimatsu wrote: rapl_cpu_prepare() must be called after logical package id

[PATCH] perf/x86/intel/rapl: Rename rapl_cpu_prepare() to rapl_cpu_starting()

2017-01-24 Thread Yasuaki Ishimatsu
() is called after topology_update_package_map(). Fixes: 9de8d686955b ("perf/x86/intel/rapl: Convert it to a per package facility") Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> CC: Thomas Gleixner <t...@linutronix.de> --- arch/x86/events/intel/rapl.c | 1

[PATCH v3] memory_hotplug: zone_can_shift() returns boolean value

2017-01-11 Thread Yasuaki Ishimatsu
of changing the memory zone from ZONE_NORMAL to ZONE_MOVABLE Fixes: df429ac03936 ("memory-hotplug: more general validation of zone during online") Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Reviewed-by: Reza Arbab <ar...@linux.vnet.ibm.com> --- f

Re: [PATCH v2] memory_hotplug: zone_can_shift() returns boolean value

2017-01-11 Thread Yasuaki Ishimatsu
Hi Andrew On 01/09/2017 06:27 PM, Andrew Morton wrote: On Tue, 13 Dec 2016 15:29:49 -0500 Yasuaki Ishimatsu <yasu.isim...@gmail.com> wrote: online_{kernel|movable} is used to change the memory zone to ZONE_{NORMAL|MOVABLE} and online the memory. To check that memory zone can be c

Re: [PATCH] thermal: core: move tz->device.groups cleanup to thermal_release

2017-01-05 Thread Yasuaki Ishimatsu
: Zhang Rui <rui.zh...@intel.com> Cc: Eduardo Valentin <edubez...@gmail.com> Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Jacob von Chorus <jacobvoncho...@cwphoto.ca> Tested-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki

Re: [PATCH] thermal: add thermal_zone_remove_device_groups()

2017-01-05 Thread Yasuaki Ishimatsu
On 01/03/2017 11:45 PM, Zhang Rui wrote: On Wed, 2017-01-04 at 12:35 +0800, Zhang Rui wrote: On Thu, 2016-12-15 at 16:47 -0500, Yasuaki Ishimatsu wrote: When offlining all cores on a CPU, the following system panic occurs: BUG: unable to handle kernel NULL pointer dereference at (null) IP

[Resend Patch 0/2] mm/memory_hotplug: fix hot remove bug

2016-12-21 Thread Yasuaki Ishimatsu
Here are two patches for memory hotplug: Yasuaki Ishimatsu (2): mm/sparse: use page_private() to get page->private value mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next arch/x86/mm/init_64.c | 2 +- mm/memory_hotplug.c | 5 +++-- mm

[Resend PATCH 2/2] mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next

2016-12-21 Thread Yasuaki Ishimatsu
y occurs. Until freeing the pages of page table allocated from bootmem allocator, the page->freelist is never used. So the patch sets magic number to page->freelist instead of page->lru.next. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> --- arch/x86/mm/init_64.c |

[Resend PATCH 1/2] mm/sparse: use page_private() to get page->private value

2016-12-21 Thread Yasuaki Ishimatsu
free_map_bootmem() uses page->private directly to set removing_section_nr argument. But to get page->private value, page_private() has been prepared. So free_map_bootmem() should use page_private() instead of page->private. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp

[Patch 0/2] mm/memory_hotplug: fix hot remove bug

2016-12-20 Thread Yasuaki Ishimatsu
Here are two patches for memory hotplug: Yasuaki Ishimatsu (2): mm/sparse: use page_private() to get page->private value mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next arch/x86/mm/init_64.c | 2 +- mm/memory_hotplug.c | 4 ++-- mm

[PATCH 1/2] mm/sparse: use page_private() to get page->private value

2016-12-20 Thread Yasuaki Ishimatsu
free_map_bootmem() uses page->private directly to set removing_section_nr argument. But to get page->private value, page_private() has been prepared. So free_map_bootmem() should use page_private() instead of page->private. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp

[PATCH 2/2] mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next

2016-12-20 Thread Yasuaki Ishimatsu
y occurs. Until freeing the pages of page table allocated from bootmem allocator, the page->freelist is never used. So the patch sets magic number to page->freelist instead of page->lru.next. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> --- arch/x86/mm/init_64.c |

Re: [PATCH] thermal: add thermal_zone_remove_device_groups()

2016-12-20 Thread Yasuaki Ishimatsu
On 12/19/2016 11:21 PM, Eduardo Valentin wrote: Hey Yasuaki San, On Thu, Dec 15, 2016 at 04:47:08PM -0500, Yasuaki Ishimatsu wrote: When offlining all cores on a CPU, the following system panic occurs: BUG: unable to handle kernel NULL pointer dereference at (null) IP: strlen+0x0/0x20 Call

[PATCH] thermal: add thermal_zone_remove_device_groups()

2016-12-15 Thread Yasuaki Ishimatsu
dds thermal_zone_remove_device_groups() to free tz->device.groups and set NULL pointer. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> CC: Zhang Rui <rui.zh...@intel.com> CC: Eduardo Valentin <edubez...@gmail.com> --- drivers/thermal/thermal_core.c | 3 ++- drivers/the

[PATCH v2] memory_hotplug: zone_can_shift() returns boolean value

2016-12-13 Thread Yasuaki Ishimatsu
not be onlined. The patch changes the return type of zone_can_shift() so that memory is not onlined when memory zone cannot be changed. Fixes: df429ac03936 ("memory-hotplug: more general validation of zone during online") Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.

Re: memory_hotplug: zone_can_shift() returns boolean value

2016-12-13 Thread Yasuaki Ishimatsu
Hi Reza, Thank you for your review. On 12/13/2016 10:54 AM, Reza Arbab wrote: On Mon, Dec 12, 2016 at 03:29:04PM -0500, Yasuaki Ishimatsu wrote: --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -410,15 +410,13 @@ static ssize_t show_valid_zones(struct device *dev, sprintf(buf

memory_hotplug: zone_can_shift() returns boolean value

2016-12-12 Thread Yasuaki Ishimatsu
not be onlined. The patch changes the return type of zone_can_shift() so that memory is not onlined when memory zone cannot be changed. Fixes: df429ac03936 ("memory-hotplug: more general validation of zone during online") Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.

Re: [PATCH] null_blk: Add notes to use LightNVM

2016-11-16 Thread Yasuaki Ishimatsu
Could you review the patch? On 10/27/2016 11:56 AM, Yasuaki Ishimatsu wrote: If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1 fails. But there are no messages and documents related to the failure. So the patch adds the notes to use LightNVM. Signed-off-by: Yasuaki

[PATCH] null_blk: Add notes to use LightNVM

2016-10-27 Thread Yasuaki Ishimatsu
If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1 fails. But there are no messages and documents related to the failure. So the patch adds the notes to use LightNVM. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Cc: Jens Axboe <ax...@

Re: [PATCH 3/3] memory-hotplug: use zone_can_shift() for sysfs valid_zones attribute

2016-05-13 Thread Yasuaki Ishimatsu
..@linux.vnet.ibm.com> > --- Looks good to me. Reviewd-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki Ishimatsu > drivers/base/memory.c | 28 +--- > 1 file changed, 17 insertions(+), 11 deletions(-) > > diff --git a/drivers/base/mem

Re: [PATCH 2/3] memory-hotplug: more general validation of zone during online

2016-05-13 Thread Yasuaki Ishimatsu
determination. > > Signed-off-by: Reza Arbab <ar...@linux.vnet.ibm.com> > --- Looks good to me. Reviewd-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki Ishimatsu > include/linux/memory_hotplug.h | 2 ++ > mm/memory_hotplug.c| 42 &

Re: [PATCH 2/3] memory-hotplug: more general validation of zone during online

2016-05-13 Thread Yasuaki Ishimatsu
On Wed, 11 May 2016 14:23:26 -0500 Reza Arbab <ar...@linux.vnet.ibm.com> wrote: > On Wed, May 11, 2016 at 08:17:41AM -0700, Yasuaki Ishimatsu wrote: > >On Tue, 10 May 2016 15:39:43 -0500 > >Reza Arbab <ar...@linux.vnet.ibm.com> wrote: > > > >> + if (idx

Re: [PATCH 2/3] memory-hotplug: more general validation of zone during online

2016-05-11 Thread Yasuaki Ishimatsu
On Tue, 10 May 2016 15:39:43 -0500 Reza Arbab <ar...@linux.vnet.ibm.com> wrote: > On Tue, May 10, 2016 at 11:08:56AM -0700, Yasuaki Ishimatsu wrote: > >On Mon, 9 May 2016 12:53:38 -0500 > >Reza Arbab <ar...@linux.vnet.ibm.com> wrote: > >> * If X is lower

Re: [PATCH 2/3] memory-hotplug: more general validation of zone during online

2016-05-10 Thread Yasuaki Ishimatsu
s uncotinuous. Then memory cannot be changed the zone by above the two conditions. So the conditions shouold be removed. Thanks, Yasuaki Ishimatsu > > Add zone_can_shift() to make this determination. > > Signed-off-by: Reza Arbab <ar...@linux.vnet.ibm.com> > --- > incl

Re: [PATCH 1/3] memory-hotplug: add move_pfn_range()

2016-05-10 Thread Yasuaki Ishimatsu
lt;ar...@linux.vnet.ibm.com> Looks good to me. Reviewed-by: Yasuaki Ishimatsu <isimatu.yasu...@jp.fujitsu.com> Thanks, Yasuaki Ishimatsu > --- > mm/memory_hotplug.c | 38 -- > 1 file changed, 28 insertions(+), 10 deletions(-) > > dif

Re: [PATCH v3 0/5] Make cpuid <-> nodeid mapping persistent.

2015-12-09 Thread Yasuaki Ishimatsu
-0x209fff] SRAT: Node 2 PXM 2 [mem 0x20a000-0x309fff] SRAT: Node 3 PXM 3 [mem 0x30a000-0x409fff] So when booting up the system with mem=0x20a000, Memory of Node 2 and 3 are ignored and the Nodes become memoryless node. Thanks, Yasuaki Ishimatsu On Thu, 19 Nov 2015 12:22:10 +0800

Re: [PATCH V8] mm: memory hot-add: hot-added memory can not be added to movable zone by default

2015-11-04 Thread Yasuaki Ishimatsu
t-added memory > > is after the end of the ZONE_NORMAL it will always return 1 > > and then the whole node will be added to ZONE_MOVABLE by default. > > If we want the node to be assigned to ZONE_NORMAL, > > we can do it as follows: > > "echo online_kernel > /sys/de

Re: [PATCH V8] mm: memory hot-add: hot-added memory can not be added to movable zone by default

2015-11-04 Thread Yasuaki Ishimatsu
d-off-by: Xiaofeng Yan <yanxiaof...@inspur.com> > Tested-by: Dongdong Fan <fa...@inspur.com> > Reviewed-by: <yasu.isim...@gmail.com> > Cc: Wang Nan <wangn...@huawei.com> > Cc: Dave Hansen <dave.han...@intel.com> > Cc: Yinghai Lu <ying...@kernel.org>

Re: [PATCH v2] memory-hotplug: Fix kernel warning during memory hotplug on ppc64

2015-11-03 Thread Yasuaki Ishimatsu
t;, > ATTR{state}="online" > > On any architecture that uses memory_probe_store to reserve memory, > this can interrupt the memory reservation process. This patch modifies > memory_probe_store to take the hotplug sysfs lock to prevent the online > of added memory before the

Re: [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-11-03 Thread Yasuaki Ishimatsu
E; > + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1); > + > + if (movable_node_is_enabled() > + && zone_end_pfn(pre_zone) <= start_pfn) > + return 1; if (movable_node_is_enabled() && (zone_end_pfn(pre_zone) <= start_p

Re: [PATCH V7] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-23 Thread Yasuaki Ishimatsu
stimil, > > The current kernel will add hot-added memory to ZONE_NORMAL by default. > If users use a udev rule as below: > > SUBSYSTEM=="memory", ACTION=="add", ATTR{state}=="offline", > ATTR{state}="online" > > it will online the memor

Re: [PATCH v2 0/7] Make cpuid <-> nodeid mapping persistent.

2015-10-23 Thread Yasuaki Ishimatsu
you fix workqueue directly? Thanks, Yasuaki Ishimatsu On Thu, 10 Sep 2015 12:27:42 +0800 Tang Chen <tangc...@cn.fujitsu.com> wrote: > The whole patch-set aims at solving this problem: > > [Problem] > > cpuid <-> nodeid mapping is firstly established at boot ti

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-16 Thread Yasuaki Ishimatsu
On Mon, 12 Oct 2015 09:37:17 +0800 Xishi Qiu <qiuxi...@huawei.com> wrote: > On 2015/10/9 23:41, Yasuaki Ishimatsu wrote: > > > > > On Thu, 8 Oct 2015 10:21:05 +0800 > > Xishi Qiu <qiuxi...@huawei.com> wrote: > > > >> If kernelcor

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread Yasuaki Ishimatsu
e can change the behavir of kernel by sysctl, user can create movable memory by only the following udev rule. SUBSYSTEM=="memory", ACTION=="add", ATTR{state}=="offline", ATTR{state}="online" Thanks, Yasuaki Ishimatsu > > And a sysctl interface is also u

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-09 Thread Yasuaki Ishimatsu
the kernelcore size is zero? I read the code but I could not find that you mention. Thanks, Yasuaki Ishimatsu > than totalpages, there is no ZONE_MOVABLE. We should fill the zone > with both kernel memory and movable memory. > > Signed-off-by: Xishi Qiu <qiuxi...@huawei.com

Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()

2015-10-01 Thread Yasuaki Ishimatsu
On Wed, 30 Sep 2015 17:33:42 +0800 Xishi Qiu <qiuxi...@huawei.com> wrote: > If user set "movablecore=xx" to a large number, corepages will overflow, > this patch fix the problem. > > Signed-off-by: Xishi Qiu <qiuxi...@huawei.com> > --- Looks good t

Re: [PATCH V4] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-09-11 Thread Yasuaki Ishimatsu
Hi Changsheng, Thank you for your comments. I'm on vacation. So After that, I'll repost the patch. Thanks, Yasuaki Ishimatsu On Sun, 6 Sep 2015 16:33:42 +0800 Changsheng Liu <liuchangsh...@inspur.com> wrote: > > > On 9/1/2015 23:37, Yasuaki Ishimatsu wrote: > > On Mon,

Re: [PATCH V4] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-09-01 Thread Yasuaki Ishimatsu
is added to normal zone defaultly, > the user will not offline the memory used by kernel. > > Reviewed-by: Andrew Morton <a...@linux-foundation.org> > Reviewed-by: Yasuaki Ishimatsu <yasu.isim...@gmail.com> > Reviewed-by: Vlastimil Babka <vba...@suse.cz> > Reviewed-by

Re: [PATCH V3] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-08-28 Thread Yasuaki Ishimatsu
()) + return 1; + if (zone_is_empty(movable_zone)) return 0; Your patch cannot prevent from creating ZONE_MOVABLE before/in ZONE_NORAML. Please check that start PFN of hot added memory is after ZONE_NORAML. Thanks, Yasuaki Ishimatsu -- 1.7.1

Re: [PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-25 Thread Yasuaki Ishimatsu
/in ZONE_NORMAL. You must prevent from creating ZONE_MOVABLE before/in ZONE_NORMAL. Thanks, Yasuaki Ishimatsu -- 1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majord...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email

Re: [PATCH] Memory hot added,The memory can not been added to movable zone

2015-08-24 Thread Yasuaki Ishimatsu
online_movable /sys/devices/system/memory/memoryXXX/state Thanks, Yasuaki Ishimatsu we checked the value of the file under some memory blocks as follows: cat /sys/devices/system/memory/ memory***/removable When memory being hot added we let the memory be added to movable zone

Re: [PATCH] perf/x86/intel/cqm: Move WARN_ONs from intel_cqm_cpu_prepare to cqm_pick_event_reader

2015-08-12 Thread Yasuaki Ishimatsu
Hi Matt, Thank you for the information. Your patch looks good to me. Thanks, Yasuaki Ishimatsu On Wed, 12 Aug 2015 12:00:25 +0100 Matt Fleming m...@codeblueprint.co.uk wrote: On Tue, 11 Aug, at 01:31:05PM, Yasuaki Ishimatsu wrote: When hot adding a CPU and onlining it, the following WARN_ON

[PATCH] perf/x86/intel/cqm: Move WARN_ONs from intel_cqm_cpu_prepare to cqm_pick_event_reader

2015-08-11 Thread Yasuaki Ishimatsu
is called after CPU_UP_PREPARE notification. So when onlining a hot added CPU, the WARN_ON() are always shown: To fix the issue, the patch moves WARN_ON()s from intel_cqm_cpu_prepare() to cqm_pick_event_reader() which is called at CPU_STARTING notification. Signed-off-by: Yasuaki Ishimatsu

Re: [PATCH 1/1] mem-hotplug: Handle node hole when initializing numa_meminfo.

2015-07-06 Thread Yasuaki Ishimatsu
On Fri, 3 Jul 2015 09:26:05 +0800 Tang Chen tangc...@cn.fujitsu.com wrote: On 07/02/2015 11:02 PM, Yasuaki Ishimatsu wrote: Hi Tang, On my box, if I run lscpu, the output looks like this: NUMA node0 CPU(s): 0-14,128-142 NUMA node1 CPU(s): 15-29,143-157 NUMA node2 CPU(s

Re: [PATCH 1/1] mem-hotplug: Handle node hole when initializing numa_meminfo.

2015-07-02 Thread Yasuaki Ishimatsu
, but they are online. According your description of patch, node 4 and 5 are mistakenly set to online. Why does lscpu show the above result? Thanks, Yasuaki Ishimatsu On Wed, 1 Jul 2015 15:55:30 +0800 Tang Chen tangc...@cn.fujitsu.com wrote: On 07/01/2015 02:25 PM, Xishi Qiu wrote: On 2015/7/1 11:16

Re: [PATCH] drivers/firmware/memmap.c: Fix kernel-doc format

2015-06-15 Thread Yasuaki Ishimatsu
On Fri, 12 Jun 2015 13:06:42 +0200 Michal Simek michal.si...@xilinx.com wrote: Fix kernel-doc format validation to be able to use kernel-doc script for checking it. Signed-off-by: Michal Simek michal.si...@xilinx.com --- Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com

Re: [PATCH] mm/memory_hotplug: set zone-wait_table to null after free it

2015-05-28 Thread Yasuaki Ishimatsu
Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- Hi Gu, The patch looks good to me. Reviewed by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Thanks, Yasuaki Ishimatsu mm/memory_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm

Re: [RFC PATCH V2 1/2] x86/cpu hotplug: make apicid -- cpuid mapping persistent

2015-05-14 Thread Yasuaki Ishimatsu
Hi Gu, Before 8 months, I posted the following patch to relate cpuid to apicid. https://lkml.org/lkml/2014/9/3/1120 Could you try this patch? Thanks, Yasuaki Ishimatsu On Thu, 14 May 2015 19:33:33 +0800 Gu Zheng guz.f...@cn.fujitsu.com wrote: Yasuaki Ishimatsu found that with node online

Re: [PATCH 1/2 V3] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-22 Thread Yasuaki Ishimatsu
On Wed, 22 Apr 2015 09:34:40 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/22 0:21, Yasuaki Ishimatsu wrote: On Tue, 21 Apr 2015 18:15:31 +0800 Xishi Qiu qiuxi...@huawei.com wrote: Hot remove nodeXX, then hot add nodeXX. If BIOS report cpu first, it will call

Re: [PATCH 1/2 V3] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-21 Thread Yasuaki Ishimatsu
Suggested-by: Yasuaki Ishimatsu yasu.isim...@gmail.com --- mm/memory_hotplug.c |3 +++ mm/page_alloc.c |8 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 457bde5..49d7c07 100644 --- a/mm/memory_hotplug.c

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-20 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 11:42:10 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 9:42, Gu Zheng wrote: Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Please ignore it... Thanks, Yasuaki Ishimatsu On Yasuaki Ishimatsu yasu.isim...@gmail.com wrote: When hot adding

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Thanks, Yasuaki Ishimatsu On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/18 4:05, Yasuaki

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 10:59:37 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 10:09, Gu Zheng wrote: Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: When hot adding memory and creating new node, the node is offline. And after calling

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 9:42, Gu Zheng wrote: Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-17 Thread Yasuaki Ishimatsu
is offline because node_set_online() is not called yet. So if applying your patches, the pgdat is not initialized in this case. Thanks, Yasuaki Ishimatsu On Fri, 17 Apr 2015 18:50:32 +0800 Xishi Qiu qiuxi...@huawei.com wrote: Hot remove nodeXX, then hot add nodeXX. If BIOS report cpu first, it will call

Re: [PATCH] x86/numa: kernel stack corruption fix

2015-04-07 Thread Yasuaki Ishimatsu
Hi Dave, On Tue, 7 Apr 2015 11:33:55 +0800 Dave Young dyo...@redhat.com wrote: On 04/06/15 at 07:26am, Yasuaki Ishimatsu wrote: Hi, On Fri, 3 Apr 2015 15:15:13 +0800 Dave Young dyo...@redhat.com wrote: Hi, On 04/02/15 at 12:36pm, Yasuaki Ishimatsu wrote: On Wed, 1

Re: [PATCH] x86/numa: kernel stack corruption fix

2015-04-06 Thread Yasuaki Ishimatsu
Hi, On Fri, 3 Apr 2015 15:15:13 +0800 Dave Young dyo...@redhat.com wrote: Hi, On 04/02/15 at 12:36pm, Yasuaki Ishimatsu wrote: On Wed, 1 Apr 2015 12:53:46 +0800 Dave Young dyo...@redhat.com wrote: I got below kernel panic during kdump test on Thinkpad T420 laptop

Re: [PATCH] x86/numa: kernel stack corruption fix

2015-04-02 Thread Yasuaki Ishimatsu
will set bit MAX_NUMNODES in nodemask bitmap thus stack corruption happen. Fixing this by adding a check, do not call node_set in case nid is MAX_NUMNODES. Signed-off-by: Dave Young dyo...@redhat.com --- Looks good to me. Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Thanks

Re: [PATCH] x86/numa: kernel stack corruption fix

2015-04-02 Thread Yasuaki Ishimatsu
by trim_snb_memory(). But if you use mem=0x4000, the system ram is limited within 0x4000. So the issue will occur. Thanks, Yasuaki Ishimatsu numa_clear_kernel_node_hotplug { ... for (i = 0; i numa_meminfo.nr_blks; i++) { struct numa_memblk *mb = numa_meminfo.blk[i

Re: [RFC PATCH 0/2 shit_A shit_B] workqueue: fix wq_numa bug

2015-01-15 Thread Yasuaki Ishimatsu
Hi Lai, Thanks you for posting the patch-set. I'll try your it next Monday. So, please wait a while. Thanks, Yasuaki Ishimatsu (2015/01/14 17:54), Lai Jiangshan wrote: Hi, All This patches are un-changloged, un-compiled, un-booted, un-tested, they are just shits, I even hope them un-sent

Re: [PATCH 0/5] workqueue: fix bug when numa mapping is changed

2014-12-17 Thread Yasuaki Ishimatsu
#ifndef cpu_to_node 82 static inline int cpu_to_node(int cpu) 83 { 84 return per_cpu(numa_node, cpu); 85 } 86 #endif 87 88 #ifndef set_numa_node Thanks, Yasuaki Ishimatsu (2014/12/15 10:34), Lai Jiangshan wrote: On 12/13/2014 01:13 AM, Yasuaki Ishimatsu

Re: [PATCH 0/5] workqueue: fix bug when numa mapping is changed

2014-12-12 Thread Yasuaki Ishimatsu
[ 890.156187] ---[ end trace 39abbfc9f93402f4 ]--- Thanks, Yasuaki Ishimatsu (2014/12/12 19:19), Lai Jiangshan wrote: Workqueue code has an assumption that the numa mapping is stable after system booted. It is incorrectly currently. Yasuaki Ishimatsu hit a allocation failure bug when the numa mapping

  1   2   3   4   5   6   7   >