[PATCH,v2] usb: hub: change CLEAR_FEATURE to SET_FEATURE
From: Yonglong Wu <yonglong...@mediatek.com> In USB20 specification, describes in chapter 9.4.5: The Remote Wakeup field can be modified by the SetFeature() and ClearFeature() requests using the DEVICE_REMOTE_WAKEUP feature selector. In USB30 specification, also describes in chapter 9.4.5: The Function Remote Wakeup field can be modified by the SetFeature() requests using the FUNCTION_SUSPEND feature selector. In chapter 9.4.9 Set Feature reference, it describes Function Remote Wake Enabled/Disabled at suspend options by SET_FEATURE. In USB30 specification only mentioned SetFeature(), so we need use SET_FEATURE replace CLEAR_FEATURE to disable USB30 function remote wakeup in suspend options. Signed-off-by: Yonglong Wu <yonglong...@mediatek.com> --- drivers/usb/core/hub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index bee1351..a6f5095 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3111,7 +3111,7 @@ static int usb_disable_remote_wakeup(struct usb_device *udev) USB_CTRL_SET_TIMEOUT); else return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), - USB_REQ_CLEAR_FEATURE, USB_RECIP_INTERFACE, + USB_REQ_SET_FEATURE, USB_RECIP_INTERFACE, USB_INTRF_FUNC_SUSPEND, 0, NULL, 0, USB_CTRL_SET_TIMEOUT); } -- 1.7.9.5
[PATCH,v2] usb: hub: change CLEAR_FEATURE to SET_FEATURE
From: Yonglong Wu In USB20 specification, describes in chapter 9.4.5: The Remote Wakeup field can be modified by the SetFeature() and ClearFeature() requests using the DEVICE_REMOTE_WAKEUP feature selector. In USB30 specification, also describes in chapter 9.4.5: The Function Remote Wakeup field can be modified by the SetFeature() requests using the FUNCTION_SUSPEND feature selector. In chapter 9.4.9 Set Feature reference, it describes Function Remote Wake Enabled/Disabled at suspend options by SET_FEATURE. In USB30 specification only mentioned SetFeature(), so we need use SET_FEATURE replace CLEAR_FEATURE to disable USB30 function remote wakeup in suspend options. Signed-off-by: Yonglong Wu --- drivers/usb/core/hub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index bee1351..a6f5095 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3111,7 +3111,7 @@ static int usb_disable_remote_wakeup(struct usb_device *udev) USB_CTRL_SET_TIMEOUT); else return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), - USB_REQ_CLEAR_FEATURE, USB_RECIP_INTERFACE, + USB_REQ_SET_FEATURE, USB_RECIP_INTERFACE, USB_INTRF_FUNC_SUSPEND, 0, NULL, 0, USB_CTRL_SET_TIMEOUT); } -- 1.7.9.5
[RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE
From: Yonglong Wu <yonglong...@mediatek.com> According to USB30 specification, the Function Remote Wakeup field can be modified by the SetFeature() requests. SetFeature() is recommended to use. Signed-off-by: Yonglong Wu <yonglong...@mediatek.com> --- drivers/usb/core/hub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index bee1351..a6f5095 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3111,7 +3111,7 @@ static int usb_disable_remote_wakeup(struct usb_device *udev) USB_CTRL_SET_TIMEOUT); else return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), - USB_REQ_CLEAR_FEATURE, USB_RECIP_INTERFACE, + USB_REQ_SET_FEATURE, USB_RECIP_INTERFACE, USB_INTRF_FUNC_SUSPEND, 0, NULL, 0, USB_CTRL_SET_TIMEOUT); } -- 1.7.9.5
[RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE
From: Yonglong Wu According to USB30 specification, the Function Remote Wakeup field can be modified by the SetFeature() requests. SetFeature() is recommended to use. Signed-off-by: Yonglong Wu --- drivers/usb/core/hub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index bee1351..a6f5095 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3111,7 +3111,7 @@ static int usb_disable_remote_wakeup(struct usb_device *udev) USB_CTRL_SET_TIMEOUT); else return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), - USB_REQ_CLEAR_FEATURE, USB_RECIP_INTERFACE, + USB_REQ_SET_FEATURE, USB_RECIP_INTERFACE, USB_INTRF_FUNC_SUSPEND, 0, NULL, 0, USB_CTRL_SET_TIMEOUT); } -- 1.7.9.5
[PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE
From: Yonglong Wu <yonglong...@mediatek.com> According to USB30 specification, the Function Remote Wakeup field can be modified by the SetFeature() requests. SetFeature() is recommended to use. Change-Id: Ie744b95f12d7d21d9519e77ed706c8cc33fa Signed-off-by: Yonglong Wu <yonglong...@mediatek.com> --- drivers/usb/core/hub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index bee1351..a6f5095 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3111,7 +3111,7 @@ static int usb_disable_remote_wakeup(struct usb_device *udev) USB_CTRL_SET_TIMEOUT); else return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), - USB_REQ_CLEAR_FEATURE, USB_RECIP_INTERFACE, + USB_REQ_SET_FEATURE, USB_RECIP_INTERFACE, USB_INTRF_FUNC_SUSPEND, 0, NULL, 0, USB_CTRL_SET_TIMEOUT); } -- 1.7.9.5
[PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE
From: Yonglong Wu According to USB30 specification, the Function Remote Wakeup field can be modified by the SetFeature() requests. SetFeature() is recommended to use. Change-Id: Ie744b95f12d7d21d9519e77ed706c8cc33fa Signed-off-by: Yonglong Wu --- drivers/usb/core/hub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index bee1351..a6f5095 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3111,7 +3111,7 @@ static int usb_disable_remote_wakeup(struct usb_device *udev) USB_CTRL_SET_TIMEOUT); else return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), - USB_REQ_CLEAR_FEATURE, USB_RECIP_INTERFACE, + USB_REQ_SET_FEATURE, USB_RECIP_INTERFACE, USB_INTRF_FUNC_SUSPEND, 0, NULL, 0, USB_CTRL_SET_TIMEOUT); } -- 1.7.9.5
