Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support

Hi Vinod, On 4/20/2021 6:11 AM, Vinod Koul wrote: On 03-04-21, 11:45, Tom Zanussi wrote: +config INTEL_IDXD_PERFMON + bool "Intel Data Accelerators performance monitor support" + depends on INTEL_IDXD + default y default y..? Will change to n. /* IDXD software

Re: [PATCH] tracing: fix double free

Hi Tom, On 9/7/2020 8:58 AM, t...@redhat.com wrote: From: Tom Rix clang static analyzer reports this problem trace_events_hist.c:3824:3: warning: Attempt to free released memory kfree(hist_data->attrs->var_defs.name[i]); In parse_var_defs() if there is a problem allocating

Re: [PATCH 0/7] selftsts/ftrace: Add requires list for each test case

Hi Masami, On 6/1/2020 9:42 AM, Masami Hiramatsu wrote: Hi, Here is a series for adding "requires:" list for simplifying and unifying requirement checks for each test case. This series also includes the description line fix and unresolved -> unsupported change ([1/7] and [2/7]). Currently, we

Re: [PATCH 4/7] selftests/ftrace: Convert required interface checks into requires list

Hi Masami, On 6/1/2020 9:42 AM, Masami Hiramatsu wrote: Convert the required tracefs interface checking code with requires: list. Signed-off-by: Masami Hiramatsu [ SNIP ] diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

Hi, On 5/7/2020 12:25 PM, Steven Rostedt wrote: On Fri, 8 May 2020 00:50:28 +0900 Masami Hiramatsu wrote: Yes, I need Tom's review for this change. As far as I can test, this fixes the test failure. If this isn't acceptable, we can use "alias echo=echo" for this test case. I still

Re: [PATCH v2] tracing: fix "gfp_t" format for synthetic events

On 10/17/2019 8:20 PM, Zhengjun Xing wrote: In the format of synthetic events, the "gfp_t" is shown as "signed:1", but in fact the "gfp_t" is "unsigned", should be shown as "signed:0". The issue can be reproduced by the following commands: echo 'memlatency u64 lat; unsigned int order; gfp_t

Re: No invalid histogram error

Hi Masami, On 6/20/2019 7:17 AM, Masami Hiramatsu wrote: Hi Tom, I'm trying to use histogram on a synthetic event, but faced an odd situation. There is a synthetic event, which has foo and bar. /sys/kernel/debug/tracing # cat synthetic_events testevent int foo; int bar And when I

Re: [PATCH -next] tracing: Make two symbols static

Hi YueHaibing, On 6/14/2019 10:32 AM, YueHaibing wrote: Fix sparse warnings: kernel/trace/trace.c:6927:24: warning: symbol 'get_tracing_log_err' was not declared. Should it be static? kernel/trace/trace.c:8196:15: warning: symbol 'trace_instance_dir' was not declared. Should it be static?