Fill fw version info into smem to be printed as part of
soc info.
Signed-off-by: Dikshita Agarwal
Reviewed-by: Stephen Boyd
---
drivers/media/platform/Kconfig | 2 +-
drivers/media/platform/qcom/venus/hfi_msgs.c | 20 ++--
2 files changed, 19 insertions(+), 3
Set the FW to run in low power for encoder
to accommodate more session without losing much on quality.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.h | 6 ++
drivers/media/platform/qcom/venus/helpers.c| 2 +
drivers/media/platform/qcom/venus
Fill fw version info into smem to be printed as part of
soc info.
Signed-off-by: Dikshita Agarwal
Reported-by: kernel test robot
change since v3:
added dependency on QCOM_SMEM (Stephen)
---
drivers/media/platform/Kconfig | 2 +-
drivers/media/platform/qcom/venus/hfi_msgs.c
Hi Bjorn,
Thanks for your review comments.
I have addressed all in the latest patch v3.
couldn't think of a shorter name for variables without losing the
readability so kept as it is.
Thanks,
Dikshita
On 2021-03-30 09:29, Bjorn Andersson wrote:
On Fri 26 Mar 01:33 CDT 2021, Dikshita Agarwal
Fill fw version info into smem to be printed as part of
soc info.
Signed-off-by: Dikshita Agarwal
changes since v2:
- adressed all review comments.
---
drivers/media/platform/qcom/venus/hfi_msgs.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git
Fill fw version info into smem to be printed as part of
soc info.
Signed-off-by: Dikshita Agarwal
Changes since v1:
adressed comments from stephen.
removed unwanted code.
---
drivers/media/platform/qcom/venus/hfi_msgs.c | 21 +++--
1 file changed, 19 insertions(+), 2
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
Reviewed-by: Hans Verkuil
---
.../userspace
Add support for below LTR controls in encoder:
- V4L2_CID_MPEG_VIDEO_LTR_COUNT
- V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
- V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.h | 2 ++
drivers/media/platform/qcom/venus/venc.c
This series add the encoder controls for long term reference (LTR)
and support for the same in venus driver.
Dikshita Agarwal (2):
media: v4l2-ctrl: add controls for long term reference.
venus: venc: Add support for Long Term Reference (LTR) controls
.../userspace-api/media/v4l/ext-ctrls
fill fw version info into smem to be printed as part of
soc info.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/hfi_msgs.c | 36 ++--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c
b
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
Reviewed-by: Hans Verkuil
---
.../userspace
This series add the encoder controls for long term reference (LTR)
and support for the same in venus driver.
Dikshita Agarwal (2):
media: v4l2-ctrl: add controls for long term reference.
venus: venc: Add support for Long Term Reference (LTR) controls
Changes since v8:
- Update 2/2 patch
Add support for below LTR controls in encoder:
- V4L2_CID_MPEG_VIDEO_LTR_COUNT
- V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
- V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 55 +-
1 file changed, 54
decoder VPP command buffer.
- Update VP9_NUM_FRAME_INFO_BUF to 32.
Signed-off-by: Dikshita Agarwal
---
.../media/platform/qcom/venus/hfi_plat_bufs_v6.c | 27 ++
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c
This series add the encoder controls for long term reference (LTR)
and support for the same in venus driver.
Dikshita Agarwal (2):
media: v4l2-ctrl: add controls for long term reference.
venus: venc: Add support for Long Term Reference (LTR) controls
Changes since v7:
- addressed comments
Add support for below LTR controls in encoder:
- V4L2_CID_MPEG_VIDEO_LTR_COUNT
- V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
- V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 49 +-
1 file changed, 48
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls
Hi Hans,
Thanks for your comments.
I Will update the documentation based on your suggestion in the next
patch.
Thanks,
Dikshita
On 2021-03-05 14:08, Hans Verkuil wrote:
Hi Dikshita,
On 03/03/2021 12:09, Dikshita Agarwal wrote:
Long Term Reference (LTR) frames are the frames
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls
This series add the encoder controls for long term reference (LTR)
and support for the same in venus driver.
Dikshita Agarwal (2):
media: v4l2-ctrl: add controls for long term reference.
venus: venc: Add support for Long Term Reference (LTR) controls
Changes since v6:
- removed references
Add support for below LTR controls in encoder:
- V4L2_CID_MPEG_VIDEO_LTR_COUNT
- V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
- V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 49 +-
1 file changed, 48
On 2021-02-01 16:50, Hans Verkuil wrote:
On 25/01/2021 06:51, Dikshita Agarwal wrote:
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable
On 2021-02-01 16:40, Hans Verkuil wrote:
On 25/01/2021 06:51, Dikshita Agarwal wrote:
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls
Add support for below LTR controls in encoder:
- V4L2_CID_MPEG_VIDEO_LTR_COUNT
- V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
- V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 49 +-
1 file changed, 48
This series add the encoder controls for long term reference (LTR)
and support for the same in venus driver.
Dikshita Agarwal (2):
media: v4l2-ctrl: add controls for long term reference.
venus: venc: Add support for Long Term Reference (LTR) controls
.../userspace-api/media/v4l/ext-ctrls
This series add the encoder controls for long term reference (LTR)
and support for the same in venus driver.
Dikshita Agarwal (2):
media: v4l2-ctrl: add controls for long term reference.
venus: venc: Add support for Long Term Reference (LTR) controls
.../userspace-api/media/v4l/ext-ctrls
Hi Hans,
On 2021-01-12 14:34, Hans Verkuil wrote:
On 04/01/2021 06:09, Dikshita Agarwal wrote:
Add support for below LTR controls in encoder:
- V4L2_CID_MPEG_VIDEO_LTR_COUNT
- V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
- V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
This patch does not add any Request API
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW
to support inband sequence header mode.
Signed-off-by: Dikshita Agarwal
Changes since v2:
- fixed Null pointer dereference (Stanimir, Fritz)
- added set property call at correct place.
---
drivers/media/platform/qcom/venus/venc.c
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW
to support inband sequence header mode.
Signed-off-by: Dikshita Agarwal
Changes since v2:
- fixed Null pointer dereference (Stanimir, Fritz)
- added set property call at correct place.
---
drivers/media/platform/qcom/venus/venc.c
This series adds base layer priority id control for encoder
and support for the same in venus driver.
Changes since v3:
- Rebased the changes on latest media tree.
- Addressed the comments.
- Added driver side implementation for new control.
Dikshita Agarwal (2):
media: v4l2-ctrl: Add base
Add support for base layer priority ID control in
encoder.
This is a preparation patch to support v6.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.h | 2 ++
drivers/media/platform/qcom/venus/venc_ctrls.c | 9 -
2 files changed, 10 insertions(+), 1
This control indicates the priority id to be applied
to base layer.
Signed-off-by: Dikshita Agarwal
---
Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +
drivers/media/v4l2-core/v4l2-ctrls.c | 1 +
include/uapi/linux/v4l2-controls.h
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls
Add support for below LTR controls in encoder:
- V4L2_CID_MPEG_VIDEO_LTR_COUNT
- V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
- V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 49 +-
1 file changed, 48
This series add the encoder controls for long term reference (LTR)
and support for the same in venus driver.
changes since v4:
- Rebased the changes on latest media tree
- Addressed the comments
- Added driver side implementation for new controls.
Dikshita Agarwal (2):
media: v4l2-ctrl: add
This series adds frame specific min/max qp controls for hevc and layer
wise bitrate control for h264.
Chnages since v2:
- Rebased the changes on latest media tree
- Added driver side implementation for new controls.
Dikshita Agarwal (3):
media: v4l2-ctrl: Add frame-specific min/max qp
- Adds min/max qp controls for B frame for h264.
- Adds min/max qp controls for I/P/B frames for hevc similar to h264.
- Update valid range of min/max qp for hevc to accommodate 10 bit.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst| 52
Add support for frame type specific min and max qp controls
for encoder.
This is a preparation patch to support v6.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.h | 18
drivers/media/platform/qcom/venus/venc.c | 21 +++--
drivers/media/platform
Adds bitrate control for all coding layers for h264
same as hevc.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 20
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
include/uapi/linux/v4l2-controls.h
HFI_PROPERTY_CONFIG_VENC_IDR_PERIOD is supported for only
H264 & HEVC codec. There is no need to set it for VP8 since
all key frames are treated as IDR frames for VP8.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc.c | 23 +--
1 file changed
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW
to support inband sequence header mode.
Signed-off-by: Dikshita Agarwal
Changes since v1:
- added codec check
- fixed the mask while initializing the control
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 15
Hi All,
Kindly ignore this patch.
https://patchwork.linuxtv.org/project/linux-media/list/?series=3790
replaces this.
Thanks,
Dikshita
On 2020-09-24 23:01, Dikshita Agarwal wrote:
update output format parameters when s_fmt is called on
capture port as recommended in encoder spec.
Signed-off
Add support to dump video FW region during FW crash
using devcoredump helpers.
Signed-off-by: Dikshita Agarwal
Reviewed-by: Stephen Boyd
Reviewed-by: Stanimir Varbanov
Major changes since v1:
- update the name of function (Stephen)
- store start address and size in resource structure during
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW
to support inband sequence header mode.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform
Add support to dump video FW region during FW crash
using devcoredump helpers.
Major changes since v1:
- update the name of function (Stephen)
- store start address and size in resource structure during
probe and reuse while dumping (Stephen, Stanimir)
Signed-off-by: Dikshita Agarwal
Reviewed
Hi Hans,
On 2020-12-02 19:18, Hans Verkuil wrote:
On 01/12/2020 09:13, Dikshita Agarwal wrote:
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls
On 2020-12-02 19:06, Hans Verkuil wrote:
On 18/11/2020 07:54, Dikshita Agarwal wrote:
Add support for frame type specific min and max qp controls
for encoder.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.h | 18 +
drivers/media/platform/qcom/venus
From: Dikshita Agarwal
Add support to dump video FW region during FW crash
using devcoredump helpers.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.c | 31
drivers/media/platform/qcom/venus/core.h | 2 ++
drivers/media
From: Dikshita Agarwal
Add support to dump video FW region during FW crash
using devcoredump helpers.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.c | 30
drivers/media/platform/qcom/venus/core.h | 2 ++
drivers/media
From: Dikshita Agarwal
Add support to dump video FW region during FW crash
using devcoredump helpers.
Signed-off-by: Dikshita Agarwal
Change-Id: Ic055579b99ffd10fe5c346f95c33aac6a97b21f2
---
drivers/media/platform/qcom/venus/core.c | 30
drivers/media/platform
Hi Stan,
On 2020-11-20 05:40, Stanimir Varbanov wrote:
Init the hfi session only once in queue_setup and also cover that
with inst->lock.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/venc.c | 98 ++--
1 file changed, 73 insertions(+), 25
Long Term Reference (LTR) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls
Add support to dump video FW region during FW crash
using devcoredump helpers.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.c | 47
1 file changed, 47 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers
This control indicates the priority id to be applied
to base layer.
Signed-off-by: Dikshita Agarwal
---
Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +
drivers/media/v4l2-core/v4l2-ctrls.c | 1 +
include/uapi/linux/v4l2-controls.h
- Adds min/max qp controls for B frame for h264.
- Adds min/max qp controls for I/P/B frames for hevc similar to h264.
- Update valid range of mim/max qp for hevc to accommodate 10 bit.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst| 52
Add support for frame type specific min and max qp controls
for encoder.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.h | 18 +
drivers/media/platform/qcom/venus/venc.c | 21 ---
drivers/media/platform/qcom/venus/venc_ctrls.c | 51
This series adds frame specific min/max qp controls for hevc and layer
wise bitrate control for h264.
Chnages since v2:
- addressed comments.
- added driver side implementation for new controls.
Dikshita Agarwal (3):
media: v4l2-ctrl: Add frame-specific min/max qp controls for hevc
media
Adds bitrate control for all coding layers for h264
same as hevc.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 20
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
include/uapi/linux/v4l2-controls.h
- return correct width and height for G_SELECTION
- update capture port wxh with rectangle wxh.
- add support for HFI_PROPERTY_PARAM_UNCOMPRESSED_PLANE_ACTUAL_INFO
to set stride info and chroma offset to FW.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/helpers.c
Hi Tomasz,
Proper handling of CROP is added with new patch
https://lkml.org/lkml/2020/11/3/811
Thanks,
Dikshita
On 2020-10-27 20:32, vgaro...@codeaurora.org wrote:
On 2020-10-23 04:38, Tomasz Figa wrote:
On Thu, Oct 22, 2020 at 6:37 AM wrote:
Hi Tomasz,
On 2020-10-13 19:09, Tomasz Figa
- return correct width and height for G_SELECTION
- update capture port wxh with rectangle wxh.
- add support for HFI_PROPERTY_PARAM_UNCOMPRESSED_PLANE_ACTUAL_INFO
to set stride info and chroma offset to FW.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/helpers.c
expect one more buffer to be queued
on src queue which needs to be handled by queueing an empty buffer
with EOS flag. Without EOS, we can't handle B frames.
Thanks,
Dikshita
On 2020-10-20 14:27, Alexandre Courbot wrote:
Hi Dikshita,
On Mon, Oct 19, 2020 at 11:29 PM Dikshita Agarwal
wrote:
Add
Add handling for below commands in encoder:
1. V4L2_ENC_CMD_STOP
2. V4L2_ENC_CMD_START
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.h | 9 +
drivers/media/platform/qcom/venus/venc.c | 64 +++-
2 files changed, 72 insertions(+), 1
This control indicates the priority id to be applied
to base layer.
Signed-off-by: Dikshita Agarwal
---
Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +
drivers/media/v4l2-core/v4l2-ctrls.c | 1 +
include/uapi/linux/v4l2-controls.h
LTR (Long Term Reference) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls
This control indicates the priority id to be applied
to base layer.
Signed-off-by: Dikshita Agarwal
---
Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +
drivers/media/v4l2-core/v4l2-ctrls.c | 1 +
include/uapi/linux/v4l2-controls.h
Dikshita Agarwal (1):
venus: venc: update output format based on capture format.
Stanimir Varbanov (1):
venus: venc: fix handlig of S_SELECTION and G_SELECTION
drivers/media/platform/qcom/venus/venc.c | 48 ++--
1 file changed, 27 insertions(+), 21 deletions
From: Stanimir Varbanov
- return correct width and height for G_SELECTION
- if requested rectangle wxh doesn't match with capture port wxh
adjust the rectangle to supported wxh.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc.c | 20
1 file
update output format parameters when s_fmt is called on
capture port as recommended in encoder spec.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/venc.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/media
Adds bitrate control for all coding layers for h264
same as hevc.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 20
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
include/uapi/linux/v4l2-controls.h
This series adds frame specific min/max qp controls for hevc and layer
wise bitrate control for h264.
Chnage since v1:
corrected email.
Dikshita Agarwal (2):
media: v4l2-ctrl: Add frame-specific min/max qp controls for hevc
media: v4l2-ctrl: Add layer wise bitrate controls for h264
- Adds min/max qp controls for B frame for h264.
- Adds min/max qp controls for I/P/B frames for hevc similar to h264.
- Update valid range of mim/max qp for hevc to accommodate 10 bit.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst| 54
This series adds frame specific min/max qp controls for hevc and layer
wise bitrate control for h264.
change since v1:
corrected email.
Dikshita Agarwal (2):
media: v4l2-ctrl: Add frame-specific min/max qp controls for hevc
media: v4l2-ctrl: Add layer wise bitrate controls for h264
Hi All,
Kindly ignore this patch series. Will be posting a new one.
Thanks,
Dikshita
On 2020-09-21 18:11, Dikshita Agarwal wrote:
This series adds frame specific min/max qp controls for hevc and
layer wise bitrate control for h264.
Dikshita Agarwal (2):
media: v4l2-ctrl: Add frame-specific
From: Dikshita Agarwal
- Adds min/max qp controls for B frame for h264.
- Adds min/max qp controls for I/P/B frames for hevc similar to h264.
- Update valid range of mim/max qp for hevc to accommodate 10 bit.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst
From: Dikshita Agarwal
Adds bitrate control for all coding layers for h264
same as hevc.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 20
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
include/uapi/linux
This series adds frame specific min/max qp controls for hevc and
layer wise bitrate control for h264.
Dikshita Agarwal (2):
media: v4l2-ctrl: Add frame-specific min/max qp controls for hevc
media: v4l2-ctrl: Add layer wise bitrate controls for h264
.../userspace-api/media/v4l/ext-ctrls
not getting updated properly through
__v4l2_ctrl_s_ctrl_compound().
Is there any issue when using volatile flag with compound
control?
Thanks,
Dikshita
On 2020-08-03 17:02, Hans Verkuil wrote:
On 16/06/2020 15:00, diksh...@codeaurora.org wrote:
Hi Nicolas, Hans,
Thanks for your
Hi Hans,
Thanks for your comments.
On 2020-08-25 15:34, Hans Verkuil wrote:
On 14/08/2020 07:29, Dikshita Agarwal wrote:
LTR (Long Term Reference) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames
LTR (Long Term Reference) frames are the frames that are encoded
sometime in the past and stored in the DPB buffer list to be used
as reference to encode future frames.
This change adds controls to enable this feature.
Signed-off-by: Dikshita Agarwal
---
.../userspace-api/media/v4l/ext-ctrls
On 2020-07-22 19:56, Hans Verkuil wrote:
On 20/07/2020 16:33, diksh...@codeaurora.org wrote:
On 2020-07-16 14:25, Hans Verkuil wrote:
On 16/06/2020 20:41, diksh...@codeaurora.org wrote:
Hi Hans, Nicolas,
Thanks for your comments.
On 2020-06-12 14:41, Hans Verkuil wrote:
Hi Dikshita
On 2020-07-16 14:25, Hans Verkuil wrote:
On 16/06/2020 20:41, diksh...@codeaurora.org wrote:
Hi Hans, Nicolas,
Thanks for your comments.
On 2020-06-12 14:41, Hans Verkuil wrote:
Hi Dikshita, Nicolas,
On 11/06/2020 16:22, Nicolas Dufresne wrote:
Le jeudi 11 juin 2020 à 15:55 +0530, Dikshita
From: Dikshita Agarwal
Move all data specific to platform into a separate file.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/Makefile | 3 +-
drivers/media/platform/qcom/venus/core.c | 20 ++-
drivers/media/platform/qcom/venus/core.h | 12
From: Dikshita Agarwal
Move all data specific to platform into a separate file.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/Makefile | 3 +-
drivers/media/platform/qcom/venus/core.c | 20 ++--
drivers/media/platform/qcom/venus/core.h | 12
Hi,
A gentle reminder for the review.
Thanks,
Dikshita
On 2020-06-17 00:11, diksh...@codeaurora.org wrote:
Hi Hans, Nicolas,
Thanks for your comments.
On 2020-06-12 14:41, Hans Verkuil wrote:
Hi Dikshita, Nicolas,
On 11/06/2020 16:22, Nicolas Dufresne wrote:
Le jeudi 11 juin 2020 à 15:55
Hi,
A gentle reminder for review.
Thanks,
Dikshita
On 2020-06-23 18:17, diksh...@codeaurora.org wrote:
Hi Hans,
On 2020-06-16 18:30, diksh...@codeaurora.org wrote:
Hi Nicolas, Hans,
Thanks for your comments and sorry for the delayed response.
On 2020-06-12 22:07, Nicolas Dufresne wrote
Hi Stanimir,
A gentle reminder for the review.
Thanks,
Dikshita
On 2020-06-09 17:24, Dikshita Agarwal wrote:
Right now we get buffer requirements from fw. The
call to get these requirements is a blocking call and takes
a lot of time. This change calculates all the buffer
requirement within
Hi Stanimir,
A gentle reminder for the review.
On 2020-05-29 12:37, Dikshita Agarwal wrote:
Move all data specific to platform into a separate file.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/Makefile | 3 +-
drivers/media/platform/qcom/venus/core.c
Hi Stanimir,
A gentle reminder for the review.
Thanks,
Dikshita
On 2020-05-29 12:48, Dikshita Agarwal wrote:
Add platform specific capabilities and use them
in place of firmware capabilities.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.c | 3
gt; > > >
> > > > On 2020-05-26 16:27, Hans Verkuil wrote:
> > > > > Hi Dikshita,
> > > > >
> > > > > My apologies for the delay, this was (mostly) due to various vacation
> > > > > days.
> > > > &g
Hi Yunfei Dong,
Thanks for the patch.
I believe there is one additional change required in
vb2_core_queue_init() to allow
ro request if the driver sets supports_ro_requests while queue_init.
thanks,
Dikshita
On 2020-06-22 07:22, Yunfei Dong wrote:
Add Read-only(Ro) request for capture queue
Hi Hans, Nicolas,
Thanks for your comments.
On 2020-06-12 14:41, Hans Verkuil wrote:
Hi Dikshita, Nicolas,
On 11/06/2020 16:22, Nicolas Dufresne wrote:
Le jeudi 11 juin 2020 à 15:55 +0530, Dikshita Agarwal a écrit :
LTR (Long Term Reference) frames are the frames that are encoded
sometime
sne a écrit :
> > Le jeudi 28 mai 2020 à 13:24 +0200, Hans Verkuil a écrit :
> > > On 28/05/2020 12:48, diksh...@codeaurora.org wrote:
> > > > Hi Hans,
> > > >
> > > > Thanks for the review.
> > > >
> > > > On 2020-05-26 16:2
s consists of bits [0, 15]. A total of N LSB bits of
this field are valid,
where N is the maximum number of LTRs supported. All the other bits are
invalid and should be rejected.
The LSB corresponds to the LTR index 0. Bit N-1 from the LSB corresponds
to the LTR index max LTR-1.
Dikshi
Add v4l2 controls for ltr
Signed-off-by: Dikshita Agarwal
---
drivers/media/v4l2-core/v4l2-ctrls.c | 6 ++
include/uapi/linux/v4l2-controls.h | 4
2 files changed, 10 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index
Right now we get buffer requirements from fw. The
call to get these requirements is a blocking call and takes
a lot of time. This change calculates all the buffer
requirement within driver and this removes the
necessity for get buffer requirements call.
Signed-off-by: Dikshita Agarwal
secure bitstream and extract them.
Apart from this, there are other metadata like "histogram" which is not
part of the bitstream
and generated by hardware
Thanks,
Dikshita
Add platform specific capabilities and use them
in place of firmware capabilities.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/core.c | 3 +
drivers/media/platform/qcom/venus/hfi_helper.h | 3 +-
drivers/media/platform/qcom/venus/hfi_parser.c
Move all data specific to platform into a separate file.
Signed-off-by: Dikshita Agarwal
---
drivers/media/platform/qcom/venus/Makefile | 3 +-
drivers/media/platform/qcom/venus/core.c | 20 ++---
drivers/media/platform/qcom/venus/core.h | 10
1 - 100 of 106 matches
Mail list logo
