Re: linux-next: build failure after merge of the drivers-x86 tree

2018-06-11 Thread dvhart



On June 11, 2018 6:23:10 PM PDT, Stephen Rothwell  wrote:
>Hi all,
>
>After merging the drivers-x86 tree, today's linux-next build (x86_64
>allmodconfig) failed like this:
>
>drivers/platform/x86/silead_dmi.c:84:21: error: variable
>'chuwi_vi10_data' has initializer but incomplete type
> static const struct ts_dmi_data chuwi_vi10_data = {
> ^~~
...
>Caused by commit
>
>2da502a0aea7 ("platform/x86: silead_dmi: Add touchscreen info for the
>Chuwi Vi10 tablet")
>
>I have reverted that commit for today.  More care please.

Grmbl. Thanks Stephen. I'll work with Andy tonight to get for-next back into 
good shape.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-06-01 Thread dvhart



On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell  wrote:
>Hi Andy,
>
>On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko
> wrote:
>>
>> Oops. What is the proposed fix for that? It seems we can't rebase
>> published branches.
>
>It's unfixable without a rebase, so you could instead consider it an
>opportunity to improve your processes for the future. :-)

Stephen, are the tests you use available publicly?

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-06-01 Thread dvhart



On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell  wrote:
>Hi Andy,
>
>On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko
> wrote:
>>
>> Oops. What is the proposed fix for that? It seems we can't rebase
>> published branches.
>
>It's unfixable without a rebase, so you could instead consider it an
>opportunity to improve your processes for the future. :-)

Yeah, in this case we have to do a rebase.

Andy, I've been wanting to look at using some simple bots and tags for this 
kind of thing. GitHub makes this really easy, might be time to move. We'll 
continue this offline.

For now, please rebase next to correct the error as this change is on top of 
any of my commits, we won't make things worse by you recommitting my commits.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


RE: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

2018-05-05 Thread dvhart
No, your fix is in next, but needs to go to Linus via the fixes branch. I have 
2 to send on to him. I am traveling and was planning to do it this weekend.

On May 4, 2018 8:27:00 PM GMT+02:00, mario.limoncie...@dell.com wrote:
>Darren,
>
>Is this with that fix of mine merged?  
>
>> -Original Message-
>> From: kbuild test robot [mailto:l...@intel.com]
>> Sent: Friday, May 4, 2018 1:24 PM
>> To: Limonciello, Mario
>> Cc: kbuild-...@01.org; linux-kernel@vger.kernel.org; Darren Hart
>(VMware)
>> Subject: drivers/platform/x86/dell-smbios-smm.c:99: undefined
>reference to
>> `dcdbas_smi_request'
>> 
>> Hi Mario,
>> 
>> FYI, the error/warning still remains.
>> 
>> tree:  
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>master
>> head:   625e2001e99e82ea3eb5b0370a428a4328b9166b
>> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-
>> smbios: Link all dell-smbios-* modules together
>> date:   8 weeks ago
>> config: x86_64-randconfig-s1-05050043 (attached as .config)
>> compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
>> reproduce:
>> git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
>> # save the attached .config to linux build tree
>> make ARCH=x86_64
>> 
>> All errors (new ones prefixed by >>):
>> 
>>drivers/platform/x86/dell-smbios-smm.o: In function
>`dell_smbios_smm_call':
>> >> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
>> `dcdbas_smi_request'
>> 
>> vim +99 drivers/platform/x86/dell-smbios-smm.c
>> 
>> 549b4930 Mario Limonciello 2017-11-01   84
>> 549b4930 Mario Limonciello 2017-11-01   85  int
>dell_smbios_smm_call(struct
>> calling_interface_buffer *input)
>> 549b4930 Mario Limonciello 2017-11-01   86  {
>> 549b4930 Mario Limonciello 2017-11-01   87   struct smi_cmd command;
>> 549b4930 Mario Limonciello 2017-11-01   88   size_t size;
>> 549b4930 Mario Limonciello 2017-11-01   89
>> 549b4930 Mario Limonciello 2017-11-01   90   size = sizeof(struct
>> calling_interface_buffer);
>> 549b4930 Mario Limonciello 2017-11-01   91   command.magic =
>> SMI_CMD_MAGIC;
>> 549b4930 Mario Limonciello 2017-11-01   92   command.command_address
>=
>> da_command_address;
>> 549b4930 Mario Limonciello 2017-11-01   93   command.command_code =
>> da_command_code;
>> 549b4930 Mario Limonciello 2017-11-01   94   command.ebx =
>> virt_to_phys(buffer);
>> 549b4930 Mario Limonciello 2017-11-01   95   command.ecx =
>0x42534931;
>> 549b4930 Mario Limonciello 2017-11-01   96
>> 549b4930 Mario Limonciello 2017-11-01   97   mutex_lock(&smm_mutex);
>> 549b4930 Mario Limonciello 2017-11-01   98   memcpy(buffer, input,
>size);
>> 549b4930 Mario Limonciello 2017-11-01  @99 
>   dcdbas_smi_request(&command);
>> 549b4930 Mario Limonciello 2017-11-01  100   memcpy(input, buffer,
>size);
>> 549b4930 Mario Limonciello 2017-11-01  101 
>   mutex_unlock(&smm_mutex);
>> 549b4930 Mario Limonciello 2017-11-01  102   return 0;
>> 549b4930 Mario Limonciello 2017-11-01  103  }
>> 549b4930 Mario Limonciello 2017-11-01  104
>> 
>> :: The code at line 99 was first introduced by commit
>> :: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86:
>dell-smbios:
>> Introduce dispatcher for SMM calls
>> 
>> :: TO: Mario Limonciello 
>> :: CC: Darren Hart (VMware) 
>> 
>> ---
>> 0-DAY kernel test infrastructureOpen Source
>Technology Center
>> https://lists.01.org/pipermail/kbuild-all   Intel
>Corporation

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Re: [PATCH] platform/x86: dell: avoid link error with modular ACPI_SMI

2018-03-15 Thread dvhart


On March 15, 2018 8:39:07 AM PDT, Arnd Bergmann  wrote:
>The new DELL_LAPTOP dependencies allowed one configuration that should
>not
>have been possible, with DELL_SMBIOS_WMI built-in, but ACPI_SMI as a
>module:


Hi Arnd, do you have the latest changes from me? The 
platform-drivers-x86-v4.16-7 PR to Linus yesterday has a fix for the ACPI_WMI 
dependency. Linus merged it yesterday.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


[RESEND][GIT PULL] platform-drivers-x86 for 4.2-1

2015-06-30 Thread dvhart
Hi Linus,

[resend after mangling Linus' email address]

Fairly routine update for platform-drivers-x86. Mostly fixes and cleanups, with
a significant refactoring of toshiba* drivers. Includes the addition of the
dell-rbtn driver.

Thanks,

Darren Hart
Intel Open Source Technology Center

The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031:

  Linux 4.1-rc1 (2015-04-26 17:59:10 -0700)

are available in the git repository at:

  git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git 
tags/platform-drivers-x86-v4.2-1

for you to fetch changes up to 5ee7041e5bc0fe8ba04a554dc2f9a18f709bc005:

  MAINTAINERS: Orphan x86 driver msi-wmi (2015-06-15 13:39:35 -0700)


platform-drivers-x86 got 4.2

asus-wmi: Fan control
dell*: Add Dell airplane mode switch driver
ideapad-laptop: Platform rfkill fixes, and regression fix
pvpanic: Handle missing _STA correctly
toshiba*: Rafactor bluetooth support, haps documentation, driver cleanup
other: Use acpi_video_unregister_backlight instead of acpi_video_unregister in
   serveral drivers.
   Orphan msi-wmi.


Anisse Astier (1):
  MAINTAINERS: Orphan x86 driver msi-wmi

Arnd Bergmann (1):
  ideapad: fix software rfkill setting

Azael Avalos (13):
  toshiba_acpi: Remove bluetooth rfkill code
  toshiba_bluetooth: Add a container struct named toshiba_bluetooth_dev
  toshiba_bluetooth: Add RFKill handler functions
  toshiba_bluetooth: Adapt *_enable, *_notify and *_resume functions to 
rfkill
  toshiba_bluetooth: Change BT status message to debug
  toshiba_acpi: Remove no longer needed hci_{read, write}2 functions
  toshiba_acpi: Rename hci_{read, write}1 functions
  toshiba_acpi: Comments cleanup
  toshiba_acpi: Remove TOS_FAILURE check from some functions
  toshiba_acpi: Bump driver version to 0.22
  toshiba_haps: Replace sscanf with kstrtoint
  toshiba_haps: Make use of DEVICE_ATTR_{RW, WO} macros
  Documentation/ABI: Add file describing the sysfs entries for toshiba_haps

Dmitry Tunin (1):
  ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked

Hans de Goede (3):
  apple_gmux: Use acpi_video_unregister_backlight instead of 
acpi_video_unregister
  asus-wmi: Use acpi_video_unregister_backlight instead of 
acpi_video_unregister
  samsung-laptop: Use acpi_video_unregister_backlight instead of 
acpi_video_unregister

Kast Bernd (1):
  asus-wmi: add fan control

Pali Rohár (3):
  dell-rbtn: Dell Airplane Mode Switch driver
  dell-rbtn: Export notifier for other kernel modules
  dell-laptop: Use dell-rbtn instead i8042 filter when possible

Radim Krčmář (1):
  pvpanic: handle missing _STA correctly

 .../ABI/testing/sysfs-driver-toshiba_haps  |  20 +
 MAINTAINERS|   8 +-
 drivers/platform/x86/Kconfig   |  18 +-
 drivers/platform/x86/Makefile  |   1 +
 drivers/platform/x86/apple-gmux.c  |   2 +-
 drivers/platform/x86/asus-wmi.c| 346 +++--
 drivers/platform/x86/dell-laptop.c |  94 -
 drivers/platform/x86/dell-rbtn.c   | 423 +
 drivers/platform/x86/dell-rbtn.h   |  24 ++
 drivers/platform/x86/ideapad-laptop.c  |  10 +-
 drivers/platform/x86/pvpanic.c |  10 +-
 drivers/platform/x86/samsung-laptop.c  |   4 +-
 drivers/platform/x86/toshiba_acpi.c| 246 +++-
 drivers/platform/x86/toshiba_bluetooth.c   | 174 +++--
 drivers/platform/x86/toshiba_haps.c|  32 +-
 15 files changed, 1122 insertions(+), 290 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-toshiba_haps
 create mode 100644 drivers/platform/x86/dell-rbtn.c
 create mode 100644 drivers/platform/x86/dell-rbtn.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[GIT PULL] platform-drivers-x86 for 4.2-1

2015-06-30 Thread dvhart
Hi Linus,

Fairly routine update for platform-drivers-x86. Mostly fixes and cleanups, with
a significant refactoring of toshiba* drivers. Includes the addition of the
dell-rbtn driver.

Thanks,

Darren Hart
Intel Open Source Technology Center

The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031:

  Linux 4.1-rc1 (2015-04-26 17:59:10 -0700)

are available in the git repository at:

  git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git 
tags/platform-drivers-x86-v4.2-1

for you to fetch changes up to 5ee7041e5bc0fe8ba04a554dc2f9a18f709bc005:

  MAINTAINERS: Orphan x86 driver msi-wmi (2015-06-15 13:39:35 -0700)


platform-drivers-x86 got 4.2

asus-wmi: Fan control
dell*: Add Dell airplane mode switch driver
ideapad-laptop: Platform rfkill fixes, and regression fix
pvpanic: Handle missing _STA correctly
toshiba*: Rafactor bluetooth support, haps documentation, driver cleanup
other: Use acpi_video_unregister_backlight instead of acpi_video_unregister in
   serveral drivers.
   Orphan msi-wmi.


Anisse Astier (1):
  MAINTAINERS: Orphan x86 driver msi-wmi

Arnd Bergmann (1):
  ideapad: fix software rfkill setting

Azael Avalos (13):
  toshiba_acpi: Remove bluetooth rfkill code
  toshiba_bluetooth: Add a container struct named toshiba_bluetooth_dev
  toshiba_bluetooth: Add RFKill handler functions
  toshiba_bluetooth: Adapt *_enable, *_notify and *_resume functions to 
rfkill
  toshiba_bluetooth: Change BT status message to debug
  toshiba_acpi: Remove no longer needed hci_{read, write}2 functions
  toshiba_acpi: Rename hci_{read, write}1 functions
  toshiba_acpi: Comments cleanup
  toshiba_acpi: Remove TOS_FAILURE check from some functions
  toshiba_acpi: Bump driver version to 0.22
  toshiba_haps: Replace sscanf with kstrtoint
  toshiba_haps: Make use of DEVICE_ATTR_{RW, WO} macros
  Documentation/ABI: Add file describing the sysfs entries for toshiba_haps

Dmitry Tunin (1):
  ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked

Hans de Goede (3):
  apple_gmux: Use acpi_video_unregister_backlight instead of 
acpi_video_unregister
  asus-wmi: Use acpi_video_unregister_backlight instead of 
acpi_video_unregister
  samsung-laptop: Use acpi_video_unregister_backlight instead of 
acpi_video_unregister

Kast Bernd (1):
  asus-wmi: add fan control

Pali Rohár (3):
  dell-rbtn: Dell Airplane Mode Switch driver
  dell-rbtn: Export notifier for other kernel modules
  dell-laptop: Use dell-rbtn instead i8042 filter when possible

Radim Krčmář (1):
  pvpanic: handle missing _STA correctly

 .../ABI/testing/sysfs-driver-toshiba_haps  |  20 +
 MAINTAINERS|   8 +-
 drivers/platform/x86/Kconfig   |  18 +-
 drivers/platform/x86/Makefile  |   1 +
 drivers/platform/x86/apple-gmux.c  |   2 +-
 drivers/platform/x86/asus-wmi.c| 346 +++--
 drivers/platform/x86/dell-laptop.c |  94 -
 drivers/platform/x86/dell-rbtn.c   | 423 +
 drivers/platform/x86/dell-rbtn.h   |  24 ++
 drivers/platform/x86/ideapad-laptop.c  |  10 +-
 drivers/platform/x86/pvpanic.c |  10 +-
 drivers/platform/x86/samsung-laptop.c  |   4 +-
 drivers/platform/x86/toshiba_acpi.c| 246 +++-
 drivers/platform/x86/toshiba_bluetooth.c   | 174 +++--
 drivers/platform/x86/toshiba_haps.c|  32 +-
 15 files changed, 1122 insertions(+), 290 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-toshiba_haps
 create mode 100644 drivers/platform/x86/dell-rbtn.c
 create mode 100644 drivers/platform/x86/dell-rbtn.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/