Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-15 Thread gre...@linuxfoundation.org
On Fri, Dec 15, 2023 at 05:32:50PM +, Verma, Vishal L wrote: > On Fri, 2023-12-15 at 09:15 -0800, Dan Williams wrote: > > Greg Kroah-Hartman wrote: > > > On Thu, Dec 14, 2023 at 10:25:27PM -0700, Vishal Verma wrote: > > > > Use the guard(device) macro to lock a 'struct device', and unlock it >

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-15 Thread gre...@linuxfoundation.org
On Fri, Dec 15, 2023 at 06:33:58AM +, Verma, Vishal L wrote: > On Fri, 2023-12-15 at 05:56 +, Matthew Wilcox wrote: > > On Thu, Dec 14, 2023 at 10:25:27PM -0700, Vishal Verma wrote: > > > @@ -294,13 +294,10 @@ static ssize_t available_size_show(struct device > > > *dev, > > >  

Re: [PATCH 5.4 v2 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-12 Thread gre...@linuxfoundation.org
On Mon, Apr 12, 2021 at 06:25:44PM +, Saeed Mirzamohammadi wrote: > Hi Greg, > > This patch fixes an issue with the IOMMU driver and it only applies to 5.4, > 4.19, and 4.14 stable kernels. May I know when this patch would be available > in the stable kernels? > > Subject: iommu/vt-d: Fix

Re: [PATCH 1/2] extcon: extcon-gpio: Log error if work-queue init fails

2021-03-25 Thread gre...@linuxfoundation.org
On Thu, Mar 25, 2021 at 04:52:12AM +, Vaittinen, Matti wrote: > > On Thu, 2021-03-25 at 09:49 +0900, Chanwoo Choi wrote: > > On 3/24/21 6:51 PM, Vaittinen, Matti wrote: > > > Hello Hans, Chanwoo, Greg, > > > > > > On Wed, 2021-03-24 at 10:25 +0100, Hans de Goede wrote: > > > > Hi, > > > > >

Re: [PATCH 5.10 113/290] net: dsa: implement a central TX reallocation procedure

2021-03-16 Thread gre...@linuxfoundation.org
On Tue, Mar 16, 2021 at 09:54:01AM -0400, Sasha Levin wrote: > On Tue, Mar 16, 2021 at 06:46:10AM +0100, gre...@linuxfoundation.org wrote: > > On Mon, Mar 15, 2021 at 07:56:02PM +, Vladimir Oltean wrote: > > > +Andrew, Vivien, > > > > > > On Mon, M

Re: [PATCH 5.10 113/290] net: dsa: implement a central TX reallocation procedure

2021-03-15 Thread gre...@linuxfoundation.org
On Mon, Mar 15, 2021 at 05:06:16PM -0400, Sasha Levin wrote: > On Mon, Mar 15, 2021 at 07:56:02PM +, Vladimir Oltean wrote: > > > Signed-off-by: Vladimir Oltean > > > Tested-by: Christian Eggers # For tail taggers only > > > Tested-by: Kurt Kanzenbach > > > Reviewed-by: Florian Fainelli >

Re: [PATCH 5.10 113/290] net: dsa: implement a central TX reallocation procedure

2021-03-15 Thread gre...@linuxfoundation.org
On Mon, Mar 15, 2021 at 07:56:02PM +, Vladimir Oltean wrote: > +Andrew, Vivien, > > On Mon, Mar 15, 2021 at 02:53:26PM +0100, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > From: Vladimir Oltean > > > > [ Upstream commit a

Re: [PATCH] e1000e: use proper #include guard name in hw.h

2021-03-02 Thread gre...@linuxfoundation.org
On Tue, Mar 02, 2021 at 01:37:59AM +, Nguyen, Anthony L wrote: > On Sat, 2021-02-27 at 10:58 +0100, Greg Kroah-Hartman wrote: > > The include guard for the e1000e and e1000 hw.h files are the same, > > so > > add the proper "E" term to the hw.h file for the e1000e driver. > > There's a patch

Re: [PATCH v10 01/20] dlb: add skeleton for DLB driver

2021-02-18 Thread gre...@linuxfoundation.org
On Thu, Feb 18, 2021 at 07:34:31AM +, Chen, Mike Ximing wrote: > > > > -Original Message- > > From: Mike Ximing Chen > > Sent: Wednesday, February 10, 2021 12:54 PM > > To: net...@vger.kernel.org > > Cc: da...@davemloft.net; k..

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-18 Thread gre...@linuxfoundation.org
On Wed, Feb 17, 2021 at 05:50:35PM -0700, Andreas Dilger wrote: > On Feb 17, 2021, at 1:08 AM, Amir Goldstein wrote: > > > > You are missing my point. > > Never mind which server. The server does not *need* to rely on > > vfs_copy_file_range() to copy files from XFS to ext4. > > The server is

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread gre...@linuxfoundation.org
On Tue, Feb 16, 2021 at 11:17:34AM +, Luis Henriques wrote: > Amir Goldstein writes: > > > On Mon, Feb 15, 2021 at 8:57 PM Trond Myklebust > > wrote: > >> > >> On Mon, 2021-02-15 at 19:24 +0200, Amir Goldstein wrote: > >> > On Mon, Feb 15, 2021 at 6:53 PM Trond Myklebust < > >> >

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-15 Thread gre...@linuxfoundation.org
On Mon, Feb 15, 2021 at 11:37:26AM +0100, Hans de Goede wrote: > Hi, > > On 2/15/21 8:22 AM, Vaittinen, Matti wrote: > > > > On Sat, 2021-02-13 at 16:59 +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 2/13/21 4:27 PM, Guenter Roeck wrote: > >>> On 2/13/21 7:03 AM, Hans de Goede wrote: > >>> [

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-13 Thread gre...@linuxfoundation.org
On Sat, Feb 13, 2021 at 12:26:59PM +, Vaittinen, Matti wrote: > > On Sat, 2021-02-13 at 13:16 +0100, Greg Kroah-Hartman wrote: > > On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote: > > > A few drivers which need a delayed work-queue must cancel work at > > > exit. > > > Some of

Re: [PATCH v4] staging: gdm724x: Fix DMA from stack

2021-02-11 Thread gre...@linuxfoundation.org
On Thu, Feb 11, 2021 at 01:28:41PM +, David Laight wrote: > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate hci_packet buffer > > using kmalloc. > > I wonder if the usb stack ought/could support a short bounce > buffer within the memory is already has to

Re: [PATCH 2/3] kbuild: clamp SUBLEVEL to 255

2021-02-08 Thread gre...@linuxfoundation.org
On Mon, Feb 08, 2021 at 01:48:06PM +, David Laight wrote: > From: Sasha Levin > > Sent: 06 February 2021 03:51 > > > > Right now if SUBLEVEL becomes larger than 255 it will overflow into the > > territory of PATCHLEVEL, causing havoc in userspace that tests for > > specific kernel version. >

Re: [PATCH 3/8] scsi: ufshpb: Add region's reads counter

2021-02-01 Thread gre...@linuxfoundation.org
On Mon, Feb 01, 2021 at 08:17:59AM +, Avri Altman wrote: > > > > On Mon, Feb 01, 2021 at 07:51:19AM +, Avri Altman wrote: > > > > > > > > On Mon, Feb 01, 2021 at 07:12:53AM +, Avri Altman wrote: > > > > > > > +#define WORK_PENDING 0 > > > > > > > +#define ACTIVATION_THRSHLD 4 /* 4 IOs

Re: [PATCH 3/8] scsi: ufshpb: Add region's reads counter

2021-02-01 Thread gre...@linuxfoundation.org
On Mon, Feb 01, 2021 at 07:51:19AM +, Avri Altman wrote: > > > > On Mon, Feb 01, 2021 at 07:12:53AM +, Avri Altman wrote: > > > > > +#define WORK_PENDING 0 > > > > > +#define ACTIVATION_THRSHLD 4 /* 4 IOs */ > > > > Rather than fixing it with macro, how about using sysfs and make it > > >

Re: [PATCH 3/8] scsi: ufshpb: Add region's reads counter

2021-01-31 Thread gre...@linuxfoundation.org
On Mon, Feb 01, 2021 at 07:12:53AM +, Avri Altman wrote: > > > +#define WORK_PENDING 0 > > > +#define ACTIVATION_THRSHLD 4 /* 4 IOs */ > > Rather than fixing it with macro, how about using sysfs and make it > > configurable? > Yes. > I will add a patch making all the logic configurable. > As

Re: [PATCH v3 00/12] add IRQF_NO_AUTOEN for request_irq

2021-01-27 Thread gre...@linuxfoundation.org
On Thu, Jan 21, 2021 at 09:38:28PM +, Song Bao Hua (Barry Song) wrote: > Hi Thomas, Greg, Dmitry, Marc, > Any further comment on this new API? It's not my subsystem, I'll let the irq maintainers handle it :) thanks, greg k-h

Re: [PATCH] rtsx: pci: fix device aspm state bug

2021-01-21 Thread gre...@linuxfoundation.org
On Thu, Jan 21, 2021 at 08:15:46AM +, 吳昊澄 Ricky wrote: > > -Original Message- > > From: gre...@linuxfoundation.org > > Sent: Thursday, January 21, 2021 4:07 PM > > To: 吳昊澄 Ricky > > Cc: a...@arndb.de; ricky...@realtek.corp-partner.google.com

Re: [PATCH] rtsx: pci: fix device aspm state bug

2021-01-21 Thread gre...@linuxfoundation.org
On Thu, Jan 21, 2021 at 07:33:03AM +, 吳昊澄 Ricky wrote: > Hi Greg kh, > > This patch to fix misc: rtsx bug for kernel 5.4 I do not understand what this means, sorry. Can you please explain it? greg k-h

Re: [PATCH v3] USB: serial: cp210x: Fix error 32 when hardware flow control is enabled.

2021-01-20 Thread gre...@linuxfoundation.org
On Thu, Jan 21, 2021 at 07:09:13AM +, Pho Tran wrote: > Fix error 32 returned by CP210X_SET_MHS when hardware flow control is enabled. > > The root cause of error 32 is that user application (CoolTerm, > linux-serial-test) > opened cp210x device with hardware flow control then attempt to

Re: [PATCH] USB: serial: cp210x: Fix error 32 when hardware flow control is enabled.

2021-01-19 Thread gre...@linuxfoundation.org
On Tue, Jan 19, 2021 at 09:43:13AM +, Pho Tran wrote: > Fix error 32 returned by CP210X_SET_MHS when hardware flow control is enabled. > > The root cause of error 32 is that user application (CoolTerm, > linux-serial-test) > opened cp210x device with hardware flow control then attempt to

Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

2021-01-11 Thread gre...@linuxfoundation.org
On Fri, Jan 08, 2021 at 06:22:24PM +0800, Baoquan He wrote: > On 01/08/21 at 10:07am, HAGIO KAZUHITO(萩尾 一仁) wrote: > > Hi Baoquan, > > > > -Original Message- > > > On 09/30/20 at 12:23pm, Alexander Egorenkov wrote: > > > > The offset of the field 'init_uts_ns.name' has changed > > > >

Re: [PATCH] USB: otg: Fix error 32 when enable hardware flow control.

2021-01-10 Thread gre...@linuxfoundation.org
On Mon, Jan 11, 2021 at 04:55:22AM +, Pho Tran wrote: > When hardware flow control is enabled, > don't allow host send MHS command to cp210x. > > Signed-off-by: Pho Tran Nit, you need a ' ' before the '<' character. And why didn't you send this to the maintainer of this file as described by

Re: [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect

2021-01-08 Thread gre...@linuxfoundation.org
On Fri, Jan 08, 2021 at 02:19:30AM +, Thinh Nguyen wrote: > Hi Wesley, > > Felipe Balbi wrote: > > Hi, > > > > Wesley Cheng writes: > >> +void composite_reset(struct usb_gadget *gadget) > >> +{ > >> + /* > >> + * Section 1.4.13 Standard Downstream Port of the USB battery charging > >> +

Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED

2021-01-07 Thread gre...@linuxfoundation.org
On Thu, Jan 07, 2021 at 07:32:07PM +0800, 李捷 wrote: > >From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 > From: Jie Li > Date: Mon, 7 Dec 2020 08:05:07 +0800 > Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to > IRQ_NOTCONNECTED Why is this in

Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED

2021-01-07 Thread gre...@linuxfoundation.org
On Thu, Jan 07, 2021 at 03:50:37PM +0800, 李捷 wrote: > From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 > From: Jie Li > Date: Mon, 7 Dec 2020 08:05:07 +0800 > Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to > IRQ_NOTCONNECTED > > Some devices

Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED

2021-01-06 Thread gre...@linuxfoundation.org
On Wed, Jan 06, 2021 at 07:48:51PM +0800, 李捷 wrote: > From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 > From: Jie Li > Date: Mon, 7 Dec 2020 08:05:07 +0800 > Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to > IRQ_NOTCONNECTED > > Some devices

Re: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

2020-12-14 Thread gre...@linuxfoundation.org
On Mon, Dec 14, 2020 at 11:49:56AM +, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:04 > > > > You can sum up the two lines, because the maximum line length of > > 100 columns is not exceeded. > > IIRC the 80 column limit is preferred. Not anymore,

Re: [PATCH] usb: cdns3: Fixes for sparse warnings

2020-12-14 Thread gre...@linuxfoundation.org
On Mon, Dec 14, 2020 at 11:26:22AM +, David Laight wrote: > From: Pawel Laszczak > > Sent: 14 December 2020 11:05 > > > > Patch fixes the following warnings: > ... > > cdns3-ep0.c:367: sparse: warning: restricted __le16 degrades to integer > ... > > diff --git a/drivers/usb/cdns3/cdns3-ep0.c

Re: [PATCH 16/22] xlink-ipc: Add xlink ipc driver

2020-12-11 Thread gre...@linuxfoundation.org
On Fri, Dec 11, 2020 at 11:33:02AM +, Kelly, Seamus wrote: > This e-mail and any attachments may contain confidential material for the sole > use of the intended recipient(s). Any review or distribution by others is > strictly prohibited. If you are not the intended recipient, please contact

Re: [PATCH v2 03/10] usb: cdns3: Moves reusable code to separate module

2020-11-10 Thread gre...@linuxfoundation.org
On Tue, Nov 10, 2020 at 11:21:22AM +, Peter Chen wrote: > On 20-11-10 09:20:54, Pawel Laszczak wrote: > > Hi, > > > > >> > > >> int cdns3_hw_role_switch(struct cdns3 *cdns); > > >> -int cdns3_init(struct cdns3 *cdns); > > >> -int cdns3_remove(struct cdns3 *cdns); > > >> +extern int

Re: Question: gadget: How to realize uvc and uac composite function?

2020-11-08 Thread gre...@linuxfoundation.org
On Mon, Nov 09, 2020 at 02:03:11AM +, Tim Li wrote: > This email and any attachments thereto may contain private, confidential, and > privileged material for the sole use of the intended recipient. Any review, > copying, or distribution of this email (or any attachments thereto) by others >

Re: Question: gadget: How to realize uvc and uac composite function?

2020-11-05 Thread gre...@linuxfoundation.org
On Fri, Nov 06, 2020 at 04:33:13AM +, Tim Li wrote: > This email and any attachments thereto may contain private, confidential, and > privileged material for the sole use of the intended recipient. Any review, > copying, or distribution of this email (or any attachments thereto) by others >

Re: [PATCH 1/2] misc: c2port: core: Make copying name from userspace more secure

2020-11-02 Thread gre...@linuxfoundation.org
On Mon, Nov 02, 2020 at 12:43:01PM +, Lee Jones wrote: > On Mon, 02 Nov 2020, gre...@linuxfoundation.org wrote: > > > On Mon, Nov 02, 2020 at 11:49:03AM +, Lee Jones wrote: > > > On Mon, 02 Nov 2020, David Laight wrote: > > > > > > > From: Lee Jo

Re: [PATCH 1/2] misc: c2port: core: Make copying name from userspace more secure

2020-11-02 Thread gre...@linuxfoundation.org
On Mon, Nov 02, 2020 at 11:49:03AM +, Lee Jones wrote: > On Mon, 02 Nov 2020, David Laight wrote: > > > From: Lee Jones > > > Sent: 02 November 2020 11:12 > > > > > > strncpy() may not provide a NUL terminator, which means that a 1-byte > > > leak would be possible *if* this was ever copied

Re: Re: (3) [PATCH v2] input: add 2 kind of switch

2020-10-30 Thread gre...@linuxfoundation.org
On Fri, Oct 30, 2020 at 08:59:18PM +0900, Jungrae Kim wrote: > > On Fri, Oct 30, 2020 at 08:28:12PM +0900, Jungrae Kim wrote: > > > > On Fri, Oct 30, 2020 at 01:39:16PM +0900, HyungJae Im wrote: > > > > > Hello, This is Hyungjae Im from Samsung Electronics. > > > > > Let me answer your questions

Re: (3) [PATCH v2] input: add 2 kind of switch

2020-10-30 Thread gre...@linuxfoundation.org
On Fri, Oct 30, 2020 at 08:28:12PM +0900, Jungrae Kim wrote: > > On Fri, Oct 30, 2020 at 01:39:16PM +0900, HyungJae Im wrote: > > > Hello, This is Hyungjae Im from Samsung Electronics. > > > Let me answer your questions inline. > > > > > > >On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im

Re: (2) [PATCH v2] input: add 2 kind of switch

2020-10-30 Thread gre...@linuxfoundation.org
On Fri, Oct 30, 2020 at 01:39:16PM +0900, HyungJae Im wrote: > Hello, This is Hyungjae Im from Samsung Electronics. > Let me answer your questions inline. > > >On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote: > >> From: "hj2.im"  > >> Date: Thu, 29 Oct 2020 22:11:24 +0900 > >> 

Re: [PATCH] Input: add switch event(SW_EXT_PEN_ATTACHED)

2020-10-30 Thread gre...@linuxfoundation.org
On Fri, Oct 30, 2020 at 03:27:40PM +0900, HyungJae Im wrote: > We need support to various accessories on the device, > some requiring switch does not exist in switch list. > So added switch for the following purpose. > > SW_EXT_PEN_ATTACHED is for the checking the external pen > attached or not

Re: [PATCH v2] input: add 2 kind of switch

2020-10-29 Thread gre...@linuxfoundation.org
On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote: > From: "hj2.im" > Date: Thu, 29 Oct 2020 22:11:24 +0900 > Subject: [PATCH v2] input: add 2 kind of switch Why is this in the body of that patch? > > We need support to various accessories on the device, > some switch does not exist

Re: [PATCH v2] input: add 2 kind of switch

2020-10-29 Thread gre...@linuxfoundation.org
On Thu, Oct 29, 2020 at 01:41:57PM +, Barnabás Pőcze wrote: > Hi > > > [...] > > diff --git a/include/linux/mod_devicetable.h > > b/include/linux/mod_devicetable.h > > index 5b08a473cdba..897f5a3e7721 100644 > > --- a/include/linux/mod_devicetable.h > > +++ b/include/linux/mod_devicetable.h

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-29 Thread gre...@linuxfoundation.org
On Thu, Oct 29, 2020 at 11:07:27AM +0100, Vincent Whitchurch wrote: > On Wed, Oct 28, 2020 at 04:50:36PM +0100, Arnd Bergmann wrote: > > I think we should try to do something on top of the PCIe endpoint subsystem > > to make it work across arbitrary combinations of host and device > >

Re: [PATCH char-misc-next 1/1] misc: mic: remove the MIC drivers

2020-10-28 Thread gre...@linuxfoundation.org
On Wed, Oct 28, 2020 at 05:22:01PM +, Dutt, Sudeep wrote: > On Wed, 2020-10-28 at 06:54 +0100, Greg Kroah-Hartman wrote: > > On Tue, Oct 27, 2020 at 08:14:15PM -0700, Sudeep Dutt wrote: > > > This patch removes the MIC drivers from the kernel tree > > > since the corresponding devices have

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-27 Thread gre...@linuxfoundation.org
on't need to allocate and reassign the used ring here and remove > > > the used_address_updated flag.Since RC has allocated the entire vring, > > > including the used ring. Simply add the corresponding offset can get > > > the used ring address. > > > > Some

Re: [PATCH] FROMLIST: input: add 2 kind of switch

2020-10-20 Thread gre...@linuxfoundation.org
On Wed, Oct 21, 2020 at 12:12:16PM +0900, HyungJae Im wrote: > >From ec9859ee01b7bc0e04255971e0fe97348847dab7 Mon Sep 17 00:00:00 2001 You sent this 3 times, why? And why is this in the body of the email, have you read the "how to send your first kernel patch" document at kernelnewbies.org? >

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread gre...@linuxfoundation.org
On Mon, Oct 19, 2020 at 03:50:32PM +0800, Xu Yilun wrote: > On Mon, Oct 19, 2020 at 03:46:23PM +0800, Wu, Hao wrote: > > > On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > > > > Add support for overriding the default matching of a

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread gre...@linuxfoundation.org
On Fri, Oct 16, 2020 at 02:33:15PM +, Catangiu, Adrian Costin wrote: > +config VMGENID > + tristate "Virtual Machine Generation ID driver" > + depends on ACPI > + default M Unless this is required to boot a machine, this should be removed. > + help > + This is a Virtual

Re: [PATCH V2 0/2] Add module autoloading support for vop and cosm driver

2020-10-13 Thread gre...@linuxfoundation.org
On Tue, Oct 13, 2020 at 08:52:01AM +, Sherry Sun wrote: > Gentle ping It's the merge window, sorry, this fell through the cracks before that happened. Please resubmit once 5.10-rc1 comes out. thanks, greg k-h

Re: LTS couple perf test and perf top fixes

2020-10-09 Thread gre...@linuxfoundation.org
On Fri, Oct 09, 2020 at 11:28:09AM +, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > Hi Greg, Sasha, > > Can you pick this to 5.4: > > commit dbd660e6b2884b864d2642d930a163d3bcebe4be > Author: Tommi Rantala > Date: Thu Apr 23 14:53:40 2020 +0300 > > perf test session topology: Fix

Re: [RFC] debugfs: protect against rmmod while files are open

2020-10-09 Thread gre...@linuxfoundation.org
On Fri, Oct 09, 2020 at 10:56:16AM +, David Laight wrote: > From: Johannes Berg > > Sent: 09 October 2020 11:48 > > > > On Fri, 2020-10-09 at 12:41 +0200, Johannes Berg wrote: > > > > > If the fops doesn't have a release method, we don't even need > > > to keep a reference to the real_fops,

Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

2020-10-06 Thread gre...@linuxfoundation.org
On Mon, Oct 05, 2020 at 11:19:02PM +, Harley A.W. Lorenzo wrote: > On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee > wrote: > > > find_tt() can return NULL or the error value in ERR_PTR() and > > dereferencing the return value without checking for the error can > > lead to a possible

Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

2020-09-16 Thread gre...@linuxfoundation.org
On Wed, Sep 16, 2020 at 08:32:26AM -0500, Bjorn Helgaas wrote: > > So is it ok to take this patch now, or does it need to be changed any? > > Yes, it's OK with me if you take this patch. > > The ASPM hardware feature is designed to work without any driver > support. It does need to be

Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

2020-09-16 Thread gre...@linuxfoundation.org
M > > > To: 吳昊澄 Ricky > > > Cc: a...@arndb.de; gre...@linuxfoundation.org; bhelg...@google.com; > > > ulf.hans...@linaro.org; rui_f...@realsil.com.cn; > > > linux-kernel@vger.kernel.org; > > > puranja...@gmail.com; linux-...@vger.kernel.org; > > > vailb

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread gre...@linuxfoundation.org
On Sun, Sep 06, 2020 at 08:38:20PM +0200, Pavel Machek wrote: > On Sun 2020-09-06 20:35:38, Christophe Leroy wrote: > > Hi, > > > > Le 06/09/2020 à 20:21, Pavel Machek a écrit : > > >Hi! > > > > > Christophe reported a major speedup due to avoiding the iov_iter > > overhead, so just add

Re: y2038 backport to v5.4

2020-08-17 Thread gre...@linuxfoundation.org
On Mon, Aug 17, 2020 at 03:00:24PM +, Roosen Henri wrote: > On Mon, 2020-08-17 at 16:35 +0200, gre...@linuxfoundation.org wrote: > > On Mon, Aug 17, 2020 at 02:15:16PM +, Roosen Henri wrote: > > > On Tue, 2020-06-09 at 16:18 +0200, Arnd Bergmann wrote: > > > &g

Re: y2038 backport to v5.4

2020-08-17 Thread gre...@linuxfoundation.org
On Mon, Aug 17, 2020 at 02:15:16PM +, Roosen Henri wrote: > On Tue, 2020-06-09 at 16:18 +0200, Arnd Bergmann wrote: > > On Tue, Jun 9, 2020 at 2:36 PM Roosen Henri < > > henri.roo...@ginzinger.com> wrote: > > > Hi Arnd, > > > > > > I hope you are well and could answer me a quick question. > >

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-07 Thread gre...@linuxfoundation.org
On Fri, Aug 07, 2020 at 09:06:50AM -0300, Jason Gunthorpe wrote: > On Thu, Aug 06, 2020 at 10:21:11PM +0200, Thomas Gleixner wrote: > > > Optionally? Please tell the hardware folks to make this mandatory. We > > have enough pain with non maskable MSI interrupts already so introducing > > yet

Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on Intel NUC boxes

2020-08-04 Thread gre...@linuxfoundation.org
On Tue, Aug 04, 2020 at 08:08:10AM +, 吳昊澄 Ricky wrote: > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, August 04, 2020 3:49 PM > > To: 吳昊澄 Ricky > > Cc: Chris Clayton; LKML; rdun...@infra

Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on Intel NUC boxes

2020-08-04 Thread gre...@linuxfoundation.org
On Tue, Aug 04, 2020 at 02:44:41AM +, 吳昊澄 Ricky wrote: > Hi Chris, > > rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, OC_POWER_DOWN); > This register operation saved power under 1mA, so if do not care the 1mA > power we can have a patch to remove it, make compatible with NUC6 > We tested

Re: 答复: [PATCH] USB:Fix kernel NULL pointer when unbind UHCI form vfio-pci

2020-07-23 Thread gre...@linuxfoundation.org
On Thu, Jul 23, 2020 at 08:36:25AM +, WeitaoWang-oc wrote: > > On Thu,23 July 2020 04:18:00 + Alex wrote: > > On Wed, 22 Jul 2020 19:57:48 +0800 > > WeitaoWangoc wrote: > > > > > drivers/usb/core/hcd-pci.c | 5 + > > > 1 file changed, 5 insertions(+) > > > > > > diff --git

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-20 Thread gre...@linuxfoundation.org
On Mon, Jul 20, 2020 at 06:50:10PM +, Atish Patra wrote: > On Mon, 2020-07-20 at 23:11 +0530, Naresh Kamboju wrote: > > RISC-V build breaks on stable-rc 5.7 branch. > > build failed with gcc-8, gcc-9 and gcc-9. > > > > Sorry for the compilation issue. > > mmap_read_lock was intrdouced in

Re: [PATCH RFC 0/5] Introduced new Cadence USBSSP DRD Driver.

2020-06-29 Thread gre...@linuxfoundation.org
On Mon, Jun 29, 2020 at 03:41:49AM +, Peter Chen wrote: > On 20-06-26 07:19:56, Pawel Laszczak wrote: > > Hi Felipe, > > > > > > > >Hi, > > > > > >Pawel Laszczak writes: > > >> This patch introduce new Cadence USBSS DRD driver to linux kernel. > > >> > > >> The Cadence USBSS DRD Controller

Re: [PATCH RFC 0/5] Introduced new Cadence USBSSP DRD Driver.

2020-06-29 Thread gre...@linuxfoundation.org
On Mon, Jun 29, 2020 at 11:20:00AM +, Pawel Laszczak wrote: > > >> > Hi Felipe, > >> > > >> > > > >> > >Hi, > >> > > > >> > >Pawel Laszczak writes: > >> > >> This patch introduce new Cadence USBSS DRD driver to linux kernel. > >> > >> > >> > >> The Cadence USBSS DRD Controller is a highly

Re: [PATCH v3 2/2] USB: serial: cp210x: Proper RTS control when buffers fill

2020-06-24 Thread gre...@linuxfoundation.org
On Wed, Jun 24, 2020 at 07:03:04AM +, Phu Luu wrote: > CP210x hardware disables auto-RTS but leaves auto-CTS when > in hardware flow control mode and UART on cp210x hardware > is disabled. This allows data to flow out, but new data > will not come into the port. When re-opening the port, if >

Re: Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

2020-06-23 Thread gre...@linuxfoundation.org
On Wed, Jun 24, 2020 at 04:11:21AM +, Phu Luu wrote: > Assign the .throttle and .unthrottle functions to be generic function > in the driver structure to prevent data loss that can otherwise occur > if the host does not enable USB throttling. > > Signed-off-by: Phu Luu An > Signed-off-by:

Re: [PATCH] USB: Serial: option: add a Longcheer device id

2020-06-16 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2020 at 07:55:10AM +, Gao, Nian wrote: > >From 9220e0828f70a34c968e32d34e13281a4ff54b08 Mon Sep 17 00:00:00 2001 > From: Gao Nian > Date: Tue, 16 Jun 2020 15:13:48 +0800 > Subject: [PATCH] USB: Serial: option: add a Longcheer device id > > Add a Longcheer device-id entry

Re: [PATCH] drivers: fix the hardware flow function of cp2102

2020-06-16 Thread gre...@linuxfoundation.org
On Tue, Jun 16, 2020 at 08:37:39AM +, Gao, Nian wrote: > >From 97278cc3d00d22e8fc1edecce1f08772823a50dd Mon Sep 17 00:00:00 2001 > From: Gao Nian > Date: Tue, 16 Jun 2020 16:29:42 +0800 > Subject: [PATCH] drivers: fix the hardware flow function of cp2102 Why is this all in the body of your

Re: [RFC PATCH 1/3] Documentation/x86: Add documentation for /proc/cpuinfo feature flags

2020-06-15 Thread gre...@linuxfoundation.org
On Mon, Jun 15, 2020 at 06:31:50PM +, Luck, Tony wrote: > > In general, this should say something along the lines that /proc/cpuinfo > > shows features which the kernel supports. > > > > "For a full list of CPUID flags which the CPU supports, use > > tools/arch/x86/tools/cpuid/cpuid" > > > >

Re: CMA enhancement - non-default areas in x86

2020-05-13 Thread gre...@linuxfoundation.org
On Wed, May 13, 2020 at 09:43:45AM +, Ravich, Leonid wrote: > > On Wed, May 13, 2020 at 08:29:16AM +, Ravich, Leonid wrote: > > > PCIe NTB > > > Documentation/driver-api/ntb.rst > > > > > 1) Basically PCI bridge between to root complex / PCI switches > > > 2) using out of OS memory is one

Re: CMA enhancement - non-default areas in x86

2020-05-13 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: CMA enhancement - non-default areas in x86

2020-05-13 Thread gre...@linuxfoundation.org
On Wed, May 13, 2020 at 07:00:12AM +, Idgar, Or wrote: > > For what type of device? > NTB (Non-Transparent Bridge). Very odd quoting style... Anyway, what exactly is a non-transparent bridge, and why doesn't your bios/uefi implementation properly reserve the memory for it so that the OS

Re: CMA enhancement - non-default areas in x86

2020-05-13 Thread gre...@linuxfoundation.org
On Wed, May 13, 2020 at 06:13:55AM +, Idgar, Or wrote: > Hi, > I'm working with Linux kernel on x86 and needed a way to allocate a very > large contiguous memory (around 20GB) for DMA operations. For what type of device? > I've found out that CMA is one of the major ways to do so, but our

Re: [PATCH 0/1] Add IMR driver for Keem Bay

2020-05-01 Thread gre...@linuxfoundation.org
On Fri, May 01, 2020 at 08:53:34AM +0100, Daniele Alessandrelli wrote: > On Fri, 2020-05-01 at 09:09 +0200, gre...@linuxfoundation.org wrote: > > On Thu, Apr 30, 2020 at 07:49:36PM +, Alessandrelli, Daniele > > wrote: > > > This e-mail and any attachments may conta

Re: [PATCH 0/1] Add IMR driver for Keem Bay

2020-05-01 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2020 at 07:49:36PM +, Alessandrelli, Daniele wrote: > This e-mail and any attachments may contain confidential material for the sole > use of the intended recipient(s). Any review or distribution by others is > strictly prohibited. If you are not the intended recipient, please

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > > > + * > > > + * Since the driver does not declare any device ids, you must allocate

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-28 Thread gre...@linuxfoundation.org
On Tue, Apr 28, 2020 at 03:47:42PM +, Stahl, Manuel wrote: > > > > > + return err; > > > + } > > > + pci_set_master(pdev); > > > + > > > + dev_info(>dev, "Legacy IRQ: %i", pdev->irq); > > > > Again, remove, be quiet :) > > Use dev_dbg() or remove completely? If it helps in

Re: [PATCH RESEND v2] staging: wfx: fix an undefined reference error when CONFIG_MMC=m

2019-10-14 Thread gre...@linuxfoundation.org
On Mon, Oct 14, 2019 at 10:06:25AM +, Jerome Pouiller wrote: > On Monday 14 October 2019 11:53:19 CEST Jérôme Pouiller wrote: > [...] > > Hello Zhong, > > > > Now, I see the problem. It happens when CONFIG_MMC=m and CONFIG_WFX=y > > (if CONFIG_WFX=m, it works). > > > > I think the easiest

Re: [PATCH v2] kheaders: making headers archive reproducible

2019-10-04 Thread gre...@linuxfoundation.org
On Fri, Oct 04, 2019 at 10:40:07AM +, Dmitry Goldin wrote: > From: Dmitry Goldin > > In commit 43d8ce9d65a5 ("Provide in-kernel headers to make > extending kernel easier") a new mechanism was introduced, for kernels > >=5.2, which embeds the kernel headers in the kernel image or a module >

Re: [PATCH] async: Let kfree() out of the critical area of the lock

2019-09-25 Thread gre...@linuxfoundation.org
On Wed, Sep 25, 2019 at 08:52:26PM +0800, Yunfeng Ye wrote: > It's not necessary to put kfree() in the critical area of the lock, so > let it out. > > Signed-off-by: Yunfeng Ye > --- > kernel/async.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/async.c

Re: [PATCH 4/4] dmaengine: Add debugfs entries for PTDMA information

2019-09-24 Thread gre...@linuxfoundation.org
On Tue, Sep 24, 2019 at 07:33:02AM +, Mehta, Sanju wrote: > +static const struct file_operations pt_debugfs_info_ops = { > + .owner = THIS_MODULE, > + .open = simple_open, > + .read = ptdma_debugfs_info_read, > + .write = NULL, > +}; > + > +static const struct file_operations

Re: [PATCH v3 4/7] serial: fsl_linflexuart: Be consistent with the name

2019-09-04 Thread gre...@linuxfoundation.org
On Fri, Aug 23, 2019 at 07:11:37PM +, Stefan-gabriel Mirea wrote: > For consistency reasons, spell the controller name as "LINFlexD" in > comments and documentation. > > Signed-off-by: Stefan-Gabriel Mirea > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- >

Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234

2019-08-06 Thread gre...@linuxfoundation.org
On Tue, Aug 06, 2019 at 05:11:17PM +, Stefan-gabriel Mirea wrote: > On 8/5/2019 6:31 PM, gre...@linuxfoundation.org wrote: > > On Fri, Aug 02, 2019 at 07:47:23PM +, Stefan-gabriel Mirea wrote: > >> > >> +/* Freescale Linflex UART */ > >> +#define PORT

Re: [PATCH 1/1] genirq: Properly pair kobject_del with kobject_add

2019-08-03 Thread gre...@linuxfoundation.org
On Fri, Aug 02, 2019 at 08:19:37PM +, Michael Kelley wrote: > From: gre...@linuxfoundation.org Sent: Thursday, > August 1, 2019 11:34 PM > > On Thu, Aug 01, 2019 at 11:53:53PM +, Michael Kelley wrote: > > > If alloc_descs fails before irq_sysfs_in

Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

2019-08-03 Thread gre...@linuxfoundation.org
On Sat, Aug 03, 2019 at 08:45:03AM +0800, Xin Long wrote: > On Fri, Aug 2, 2019 at 7:03 PM Rantala, Tommi T. (Nokia - FI/Espoo) > wrote: > > > > On Fri, 2019-08-02 at 09:28 +0200, gre...@linuxfoundation.org wrote: > > > On Thu, Aug 01, 2019 at 10:17:30AM +, Rantala,

Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

2019-08-02 Thread gre...@linuxfoundation.org
On Fri, Aug 02, 2019 at 11:03:15AM +, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > On Fri, 2019-08-02 at 09:28 +0200, gre...@linuxfoundation.org wrote: > > On Thu, Aug 01, 2019 at 10:17:30AM +, Rantala, Tommi T. (Nokia - > > FI/Espoo) wrote: > > > Hi, > >

Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

2019-08-02 Thread gre...@linuxfoundation.org
On Thu, Aug 01, 2019 at 10:17:30AM +, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > On Tue, 2019-07-02 at 10:02 +0200, Greg Kroah-Hartman wrote: > > From: Xin Long > > > > commit c3bcde026684c62d7a2b6f626dc7cf763833875c upstream. > > > > udp_tunnel(6)_xmit_skb() called by tipc_udp_xmit()

Re: [PATCH 1/1] genirq: Properly pair kobject_del with kobject_add

2019-08-02 Thread gre...@linuxfoundation.org
On Thu, Aug 01, 2019 at 11:53:53PM +, Michael Kelley wrote: > If alloc_descs fails before irq_sysfs_init has run, free_desc in the > cleanup path will call kobject_del even though the kobject has not > been added with kobject_add. Fix this by making the call to > kobject_del conditional on

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-07-22 Thread gre...@linuxfoundation.org
On Mon, Jul 22, 2019 at 01:56:45PM +0200, Pavel Machek wrote: > Hi! > > > > >> This patch introduce new Cadence USBSS DRD driver to linux kernel. > > > >> > > > >> The Cadence USBSS DRD Controller is a highly configurable IP Core which > > > >> can be instantiated as Dual-Role Device (DRD),

Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support

2019-07-15 Thread gre...@linuxfoundation.org
On Mon, Jul 15, 2019 at 05:34:47AM +, Andy Duan wrote: > Ping... It's the middle of the merge window, we can't do anything with any patches until after that. Please be patient. greg k-h

Re: [PATCH v3 0/3] kernel/notifier.c: avoid duplicate registration

2019-07-12 Thread gre...@linuxfoundation.org
On Fri, Jul 12, 2019 at 09:11:57PM +0800, Xiaoming Ni wrote: > On 2019/7/11 21:57, Vasily Averin wrote: > > On 7/11/19 4:55 AM, Nixiaoming wrote: > >> On Wed, July 10, 2019 1:49 PM Vasily Averin wrote: > >>> On 7/10/19 6:09 AM, Xiaoming Ni wrote: > Registering the same notifier to a hook

Re: [PATCH] Adjust analogix chip driver location

2019-06-26 Thread gre...@linuxfoundation.org
On Wed, Jun 26, 2019 at 10:44:38AM +, Xin Ji wrote: > Move analogix chip ANX78XX bridge driver into "analogix" directory. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/Kconfig | 10 - > drivers/gpu/drm/bridge/Makefile|3 +- >

Re: [PATCH] drivers/usb/host/imx21-hcd.c: fix divide-by-zero in func nonisoc_etd_done

2019-06-05 Thread gre...@linuxfoundation.org
On Wed, Jun 05, 2019 at 02:02:40AM +, Duyanlin wrote: > > If the function usb_maxpacket(urb->dev, urb->pipe, usb_pipeout(urb->pipe)) > returns 0, that will cause a illegal divide-by-zero operation, unexpected > results may occur. > It is best to ensure that the denominator is non-zero

Re: [PATCH 4.19 144/187] selftests/bpf: skip verifier tests for unsupported program types

2019-05-23 Thread gre...@linuxfoundation.org
On Thu, May 23, 2019 at 03:46:26PM +0200, Daniel Borkmann wrote: > On 05/23/2019 12:27 PM, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > > On Thu, 2019-04-04 at 10:48 +0200, Greg Kroah-Hartman wrote: > >> 4.19-stable review patch. If anyone has any objections, please let > >> me know. > >> > >>

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread gre...@linuxfoundation.org
On Thu, May 23, 2019 at 10:10:52AM +, TonyWWang-oc wrote: > Add x86 architecture support for new Zhaoxin processors. > Carve out initialization code needed by Zhaoxin processors into > a separate compilation unit. > > To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN > for

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread gre...@linuxfoundation.org
On Thu, May 23, 2019 at 10:10:52AM +, TonyWWang-oc wrote: > --- /dev/null > +++ b/arch/x86/kernel/cpu/zhaoxin.c > @@ -0,0 +1,178 @@ > +// SPDX-License-Identifier: GPL-2.0 Nice, but: > +/* > + * Zhaoxin Processor Support for Linux > + * > + * Copyright (c) 2019 Shanghai Zhaoxin Semiconductor

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread gre...@linuxfoundation.org
On Thu, May 23, 2019 at 10:10:52AM +, TonyWWang-oc wrote: > Add x86 architecture support for new Zhaoxin processors. > Carve out initialization code needed by Zhaoxin processors into > a separate compilation unit. > > To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN > for

Re: [PATCH 4.14 09/69] x86: vdso: Use $LD instead of $CC to link

2019-04-27 Thread gre...@linuxfoundation.org
On Fri, Apr 26, 2019 at 06:34:22AM -0700, Nathan Chancellor wrote: > On Fri, Apr 26, 2019 at 01:23:17PM +, Rantala, Tommi T. (Nokia - > FI/Espoo) wrote: > > On Fri, 2019-04-26 at 05:48 -0700, Nathan Chancellor wrote: > > > On Fri, Apr 26, 2019 at 11:41:30AM +, Rantala, Tommi T. (Nokia - >

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-25 Thread gre...@linuxfoundation.org
On Wed, Apr 24, 2019 at 01:34:55PM +0100, Jonathan Cameron wrote: > On Tue, 23 Apr 2019 06:38:44 + > "Ardelean, Alexandru" wrote: > > > On Mon, 2019-04-22 at 23:06 +0200, Greg KH wrote: > > > > > > > > > On Mon, Apr 22, 2019 at 11:32:56AM +0300, Alexandru Ardelean wrote: > > > > This

  1   2   3   4   5   6   7   8   >