counters.red_frames_count -
filter->stats.drops;
Thanks for the explanation.
What is filter->stats?
The rest of those counters seem related to the gate action.
How do you account for policing actions?
cheers,
jamal
On 2020-06-23 7:52 p.m., Po Liu wrote:
Hi Jamal,
My question: Is this any different from how stats are structured?
[..]
My question: Why cant you apply the same semantics for the counters?
Does your hardware have an indexed counter/stats table? If yes then you
Yes
they use the same counter.
cheers,
jamal
.
cheers,
jamal
On 2020-06-23 2:34 a.m., Po Liu wrote:
From: Po Liu
Hardware may own many entries for police flow. So that make one(or
multi) flow to be policed by one hardware entry. This patch add the
police action index provide to the driver side make it mapping the
driver hardware entry index
on
how your ATM CARD can be delivered to you.
Here is the contact of the security company below, contact them with
your receiving address and telephone number
Company name: Sure Security Services Company LTD
Manager Name: Mr. Tom Nelson
Email: sur...@contractor.net
Best Regards,
Mr. Bin Jamal
On 2019-02-07 2:45 a.m., Eli Cohen wrote:
This two patch series modifies TC actions identifiers to be more consistent and
also puts them in one place so new identifiers numbers can be chosen more
easily.
For the series:
Acked-by: Jamal Hadi Salim
cheers,
jamal
est built.
Works as advertised ;->
Tested-by: Jamal Hadi Salim
cheers,
jamal
ouble check.
cheers,
jamal
--- a/net-next/net/sched/cls_u32.c 2018-10-09 05:18:04.046642676 -0400
+++ b/net/sched/cls_u32.c 2018-10-09 05:29:51.965528032 -0400
@@ -391,6 +391,7 @@
RCU_INIT_POINTER(root_ht->next, tp_c->hlist);
rcu_assign_pointer(tp_c->hlist, root_h
ouble check.
cheers,
jamal
--- a/net-next/net/sched/cls_u32.c 2018-10-09 05:18:04.046642676 -0400
+++ b/net/sched/cls_u32.c 2018-10-09 05:29:51.965528032 -0400
@@ -391,6 +391,7 @@
RCU_INIT_POINTER(root_ht->next, tp_c->hlist);
rcu_assign_pointer(tp_c->hlist, root_h
all action idr spinlock usage with regular calls that do not
disable bh.
Signed-off-by: Vlad Buslov <vla...@mellanox.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
all action idr spinlock usage with regular calls that do not
disable bh.
Signed-off-by: Vlad Buslov
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 14/05/18 04:46 PM, Vlad Buslov wrote:
On Mon 14 May 2018 at 18:03, Jamal Hadi Salim <j...@mojatatu.com> wrote:
On 14/05/18 10:27 AM, Vlad Buslov wrote:
Hello Jamal,
I'm trying to run tdc, but keep getting following error even on clean
branch without my patches:
Vlad, not sure
On 14/05/18 04:46 PM, Vlad Buslov wrote:
On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote:
On 14/05/18 10:27 AM, Vlad Buslov wrote:
Hello Jamal,
I'm trying to run tdc, but keep getting following error even on clean
branch without my patches:
Vlad, not sure if you saw my email:
Apply
the tdc tests with these changes. This area has almost
good test coverage at this point. If you need help just ping me.
cheers,
jamal
the tdc tests with these changes. This area has almost
good test coverage at this point. If you need help just ping me.
cheers,
jamal
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
On 17-10-10 10:33 PM, Manish Kurup wrote:
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Signed-off-by: Manish Kurup
Acked-by: Jamal Hadi Salim
On 17-03-04 07:01 PM, Alexey Khoroshilov wrote:
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
On 17-03-04 07:01 PM, Alexey Khoroshilov wrote:
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
Acked-by: Jamal Hadi Salim
cheers,
jamal
stcase we can try?
cheers,
jamal
,
jamal
it, the union is a pragmatic approach.
cheers,
jamal
it, the union is a pragmatic approach.
cheers,
jamal
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote:
On 16-09-28 08:16 AM, David Miller wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Wed, 28 Sep 2016 08:09:28 -0400
On 16-09-28 08:07 AM, David Miller wrote:
Right, it would be legal for an existing user to have code that
expl
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote:
On 16-09-28 08:16 AM, David Miller wrote:
From: Jamal Hadi Salim
Date: Wed, 28 Sep 2016 08:09:28 -0400
On 16-09-28 08:07 AM, David Miller wrote:
Right, it would be legal for an existing user to have code that
explicitly initializes every member
On 16-09-28 08:16 AM, David Miller wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Wed, 28 Sep 2016 08:09:28 -0400
On 16-09-28 08:07 AM, David Miller wrote:
Right, it would be legal for an existing user to have code that
explicitly initializes every member of the structure, inc
On 16-09-28 08:16 AM, David Miller wrote:
From: Jamal Hadi Salim
Date: Wed, 28 Sep 2016 08:09:28 -0400
On 16-09-28 08:07 AM, David Miller wrote:
Right, it would be legal for an existing user to have code that
explicitly initializes every member of the structure, including 'pad'.
So we have
fields added as
"Not UAPI. Do not fsck fondle this".
cheers,
jamal
fields added as
"Not UAPI. Do not fsck fondle this".
cheers,
jamal
On 16-09-28 07:27 AM, Cyrill Gorcunov wrote:
On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote:
This structure is uapi, so anyone has complete rights to reference
@pad in the userspace programs. Sure it would be more clear to remove
the @pad completely, but if we choose so I
On 16-09-28 07:27 AM, Cyrill Gorcunov wrote:
On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote:
This structure is uapi, so anyone has complete rights to reference
@pad in the userspace programs. Sure it would be more clear to remove
the @pad completely, but if we choose so I
On 16-09-28 06:51 AM, Cyrill Gorcunov wrote:
On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote:
[..]
I dont know how compilation will fail but you may be right with note:
that is not how pads have been used in the past. They are supposed to
cosmetic annotation which indicates
On 16-09-28 06:51 AM, Cyrill Gorcunov wrote:
On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote:
[..]
I dont know how compilation will fail but you may be right with note:
that is not how pads have been used in the past. They are supposed to
cosmetic annotation which indicates
On 16-09-28 06:17 AM, Cyrill Gorcunov wrote:
On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote:
...
@@ -38,7 +38,10 @@ struct inet_diag_req_v2 {
__u8sdiag_family;
__u8sdiag_protocol;
__u8idiag_ext;
- __u8pad;
+ union
On 16-09-28 06:17 AM, Cyrill Gorcunov wrote:
On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote:
...
@@ -38,7 +38,10 @@ struct inet_diag_req_v2 {
__u8sdiag_family;
__u8sdiag_protocol;
__u8idiag_ext;
- __u8pad;
+ union
ke __raw_v4_lookup() are claiming it is
unsigned short instead of a u8?
cheers,
jamal
ice when things like __raw_v4_lookup() are claiming it is
unsigned short instead of a u8?
cheers,
jamal
net is better, although it is slightly large as a bug fix.
I am conflicted. There are a lot of changes in net-next at the moment;
adding this to -net seems like will definetely cause merge issues for
Dave.
Ok, Cong - patch attached and tested. Let me know what you think.
cheers,
jamal
diff --
net is better, although it is slightly large as a bug fix.
I am conflicted. There are a lot of changes in net-next at the moment;
adding this to -net seems like will definetely cause merge issues for
Dave.
Ok, Cong - patch attached and tested. Let me know what you think.
cheers,
jamal
diff --
(you said it in your earlier email and I thought about
that afterwards).
cheers,
jamal
ail and I thought about
that afterwards).
cheers,
jamal
-> module_put()
The same problem is actual for tcf_ife_cleanup() as well.
Huh? Both module_put() and kfree() should not sleep, right?
I dont think there is any sleeping there ;->
cheers,
jamal
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
index 6bbc518..e341bef 100
le_put()
The same problem is actual for tcf_ife_cleanup() as well.
Huh? Both module_put() and kfree() should not sleep, right?
I dont think there is any sleeping there ;->
cheers,
jamal
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
index 6bbc518..e341bef 100644
--- a/net/sched/act_ife.c
+++
On 16-06-15 07:52 AM, Jamal Hadi Salim wrote:
> On 16-06-15 04:38 AM, Jason Wang wrote:
>> We used to queue tx packets in sk_receive_queue, this is less
>> efficient since it requires spinlocks to synchronize between producer
>
> So this is more exercising the skb array
On 16-06-15 07:52 AM, Jamal Hadi Salim wrote:
> On 16-06-15 04:38 AM, Jason Wang wrote:
>> We used to queue tx packets in sk_receive_queue, this is less
>> efficient since it requires spinlocks to synchronize between producer
>
> So this is more exercising the skb array
l to see general performance numbers on user/kernel
crossing (i.e tun read/write).
If you have the cycles can you run such tests?
cheers,
jamal
l to see general performance numbers on user/kernel
crossing (i.e tun read/write).
If you have the cycles can you run such tests?
cheers,
jamal
death sentence after 1 week of
deliberation. You cant take it back after execution.
cheers,
jamal
death sentence after 1 week of
deliberation. You cant take it back after execution.
cheers,
jamal
always expected to be present.
I think a good test is old kernel with new iproute2. If the new field
is non-optional, it will fail (example iproute2 may try to print a value
that it expects but because old kernel doesnt understand it; it is
non-existent).
cheers,
jamal
c. i.e
by non-optional i mean always expected to be present.
I think a good test is old kernel with new iproute2. If the new field
is non-optional, it will fail (example iproute2 may try to print a value
that it expects but because old kernel doesnt understand it; it is
non-existent).
cheers,
jamal
Hi Emil,
On 03/05/15 10:04, Emil Medve wrote:
Hello Jamal,
On 03/05/2015 08:35 AM, Jamal Hadi Salim wrote:
Hi Emil,
No. All the kernel drivers/code we want to upstream is meant to stand on
its own and be used the "normal" Linux/Unix way
Ok, thanks - that was my only con
Hi Emil,
On 03/05/15 10:04, Emil Medve wrote:
Hello Jamal,
On 03/05/2015 08:35 AM, Jamal Hadi Salim wrote:
Hi Emil,
No. All the kernel drivers/code we want to upstream is meant to stand on
its own and be used the normal Linux/Unix way
Ok, thanks - that was my only concern.
Note
support for user-space based approach. I'm unsure where/when
we might publish that. Of course the SDK is always a place you can turn
to for all the code we have (in whatever state it might be)
the sdk is open source?
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe
support for your classifiers, queue schedulers etc? Is that a patch
on top of this or it is something that sits on user space?
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
are you planning to
add support for your classifiers, queue schedulers etc? Is that a patch
on top of this or it is something that sits on user space?
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
support for user-space based approach. I'm unsure where/when
we might publish that. Of course the SDK is always a place you can turn
to for all the code we have (in whatever state it might be)
the sdk is open source?
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe linux
This patch adds a static keyword to cl_lov_device_mutex_class variable
to suppress the warning of static declaration
Signed-off-by: Mohammad Jamal
---
drivers/staging/lustre/lustre/lov/lov_dev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre
This patch adds a static keyword to cl_lov_device_mutex_class variable
to suppress the warning of static declaration
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/lustre/lustre/lov/lov_dev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This patch adds a static keyword to variable portal_rotor to
suppress the sparse warning of static declaration
Signed-off-by: Mohammad Jamal
---
drivers/staging/lustre/lnet/lnet/lib-ptl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib
This patch adds a static keyword to variable portal_rotor to
suppress the sparse warning of static declaration
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-ptl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
This patch adds a static keyword to lprocfs_lmv_init_vars and
lprocfs_lmv_module_vars to suppress the sparse warnings about
static declaration
Signed-off-by: Mohammad Jamal
---
drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch removes the sparse warnings present in the lproc_lmv.c
Signed-off-by: Mohammad Jamal
---
drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lproc_lmv.c
b/drivers/staging/lustre
This patch removes the sparse warnings present in the lproc_lmv.c
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lproc_lmv.c
This patch adds a static keyword to lprocfs_lmv_init_vars and
lprocfs_lmv_module_vars to suppress the sparse warnings about
static declaration
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++--
1 file changed, 2 insertions
This patch replaces the shifting operations by BIT macro
Signed-off-by: Mohammad Jamal
---
drivers/net/ieee802154/cc2520.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index 665a3db..181b349 100644
This patch removes the warnings (space before , ) shown by
checkpatch.pl
Signed-off-by: Mohammad Jamal
---
drivers/net/ieee802154/cc2520.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index a43c8ac
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov
wrote:
> Hello.
>
> On 1/23/2015 12:26 PM, Mohammad Jamal wrote:
>
>> This patch solves the coding style issues such as space after ,
>
>
>s/after/before/?
>
>> and removes the blank lines
>
>
>
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram wrote:
> Hi Mohammad Jamal,
>
> On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal
> wrote:
>> This patch solves the coding style issue warning
>> by replacing the shifting operations by BIT macro
>>
>> Signed-off-by
This patch solves the coding style issue warning
by replacing the shifting operations by BIT macro
Signed-off-by: Mohammad Jamal
---
drivers/net/ieee802154/cc2520.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net
This patch solves the coding style issues such as space after ,
and removes the blank lines
Signed-off-by: Mohammad Jamal
---
drivers/net/ieee802154/cc2520.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154
This patch removes the warnings (space before , ) shown by
checkpatch.pl
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/net/ieee802154/cc2520.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net
This patch replaces the shifting operations by BIT macro
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/net/ieee802154/cc2520.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
This patch solves the coding style issues such as space after ,
and removes the blank lines
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/net/ieee802154/cc2520.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram varkabhad...@gmail.com wrote:
Hi Mohammad Jamal,
On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal
md.jamalmohiud...@gmail.com wrote:
This patch solves the coding style issue warning
by replacing the shifting operations by BIT macro
Signed-off
This patch solves the coding style issue warning
by replacing the shifting operations by BIT macro
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/net/ieee802154/cc2520.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ieee802154
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov
sergei.shtyl...@cogentembedded.com wrote:
Hello.
On 1/23/2015 12:26 PM, Mohammad Jamal wrote:
This patch solves the coding style issues such as space after ,
s/after/before/?
and removes the blank lines
Extra blank lines, you mean
On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet wrote:
> On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert wrote:
>
>> Hmm, this seems less readable to me. What is the effect of this patch?
>> Does the compiler even produce different assembly?
>
> No change at all in generated assembly, this looks
This patch optimizes __skb_push function
Signed-off-by: Mohammad Jamal
---
include/linux/skbuff.h |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 85ab7d7..9acffb2 100644
--- a/include/linux/skbuff.h
+++ b/include
On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet eduma...@google.com wrote:
On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert therb...@google.com wrote:
Hmm, this seems less readable to me. What is the effect of this patch?
Does the compiler even produce different assembly?
No change at all in
This patch optimizes __skb_push function
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
include/linux/skbuff.h |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 85ab7d7..9acffb2 100644
--- a/include/linux
Mohammad Jamal
>> wrote:
>>
>> > Fix the coding style issue by adding a blank line after declaration
>> >
>> > Signed-off-by: Mohammad Jamal
>>
>> Patch applied.
>
> This one looks bogus; it's adding a random newline within the
> dec
PM, Mohammad Jamal
md.jamalmohiud...@gmail.com wrote:
Fix the coding style issue by adding a blank line after declaration
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
Patch applied.
This one looks bogus; it's adding a random newline within the
declarations not after.
Johan
This patch solves the coding style issue by adding a space
before (
Signed-off-by: Mohammad Jamal
---
drivers/mmc/host/sdhci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1453cd1..910ee7b 100644
--- a/drivers
Fix the coding style issue by adding a blank line after declaration
Signed-off-by: Mohammad Jamal
---
drivers/gpio/gpio-dln2.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
index ce3c155..dbdb4de 100644
--- a/drivers/gpio/gpio-dln2.c
This patch solves the coding style issue by adding a space
before (
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/mmc/host/sdhci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1453cd1
Fix the coding style issue by adding a blank line after declaration
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/gpio/gpio-dln2.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
index ce3c155..dbdb4de 100644
This patch solves the space before , coding style issue found by
checkpatch in ade7759.c
Signed-off-by: Mohammad Jamal
---
drivers/staging/iio/meter/ade7759.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7759.c
b/drivers/staging/iio/meter
This patch solves the space before , error of the checkpatch.pl
Signed-off-by: Mohammad Jamal
---
drivers/staging/iio/adc/ad7192.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index f6526aa..6f8ce6c
This patch solves the space before , error of the checkpatch.pl
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/iio/adc/ad7192.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192
This patch solves the space before , coding style issue found by
checkpatch in ade7759.c
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/iio/meter/ade7759.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7759.c
b
This patch solves space prohibited before , warning in gdm_mux.c
Signed-off-by: Mohammad Jamal
---
drivers/staging/gdm724x/gdm_mux.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index b5b063a
Fix the coding style issue by adding blank line after declaration
Signed-off-by: Mohammad Jamal
---
.../clocking-wizard/clk-xlnx-clock-wizard.c|1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
b/drivers/staging/clocking
Fix the coding style issue by adding blank line after declaration
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
.../clocking-wizard/clk-xlnx-clock-wizard.c|1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
b
This patch solves space prohibited before , warning in gdm_mux.c
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/gdm724x/gdm_mux.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x
Patch solves the space before ( coding style issue of ssfdc.c
Signed-off-by: Mohammad Jamal
---
drivers/mtd/ssfdc.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index daf82ba..d4a922c 100644
--- a/drivers/mtd
Patch solves the space before ( coding style issue of ssfdc.c
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/mtd/ssfdc.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index daf82ba
This patch solves the blank line warning of checkpatch.pl
Signed-off-by: Mohammad Jamal
---
drivers/misc/ad525x_dpot-spi.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/misc/ad525x_dpot-spi.c b/drivers/misc/ad525x_dpot-spi.c
index 9da04ed..f4c82ea 100644
--- a/drivers/misc
This patch removes the break statements present after return
Signed-off-by: Mohammad Jamal
---
drivers/misc/ad525x_dpot.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
index 32f9072..15e8807 100644
--- a/drivers/misc
Added a blank line after declaration to fix the warning of checkpatch.pl
Signed-off-by: Mohammad Jamal
---
drivers/misc/ad525x_dpot.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
index a43053d..32f9072 100644
--- a/drivers/misc
1 - 100 of 323 matches
Mail list logo