Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-26 Thread Jamal Hadi Salim
+ counters.red_frames_count - filter->stats.drops; Thanks for the explanation. What is filter->stats? The rest of those counters seem related to the gate action. How do you account for policing actions? cheers, jamal

Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread Jamal Hadi Salim
On 2020-06-23 7:52 p.m., Po Liu wrote: Hi Jamal, My question: Is this any different from how stats are structured? [..] My question: Why cant you apply the same semantics for the counters? Does your hardware have an indexed counter/stats table? If yes then you Yes, That is the

Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Jamal Hadi Salim
x 5 infact they use the same counter. cheers, jamal

Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Jamal Hadi Salim
stats. cheers, jamal On 2020-06-23 2:34 a.m., Po Liu wrote: From: Po Liu Hardware may own many entries for police flow. So that make one(or multi) flow to be policed by one hardware entry. This patch add the police action index provide to the driver side make it mapping the driver hardware entry

CONGRATULATIONS

2019-09-07 Thread Bin Jamal
on how your ATM CARD can be delivered to you. Here is the contact of the security company below, contact them with your receiving address and telephone number Company name: Sure Security Services Company LTD Manager Name: Mr. Tom Nelson Email: sur...@contractor.net Best Regards, Mr. Bin Jamal

Re: [PATCH net-next 0/2] Change tc action identifiers to be more consistent

2019-02-07 Thread Jamal Hadi Salim
On 2019-02-07 2:45 a.m., Eli Cohen wrote: This two patch series modifies TC actions identifiers to be more consistent and also puts them in one place so new identifiers numbers can be chosen more easily. For the series: Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH/RFC] Make perf_event_open() propagate errors for use in bpf_perf_event_open()

2019-01-12 Thread Jamal Hadi Salim
mething? Probably ;-) Ah, its just test built. Works as advertised ;-> Tested-by: Jamal Hadi Salim cheers, jamal

Re: linux-next: manual merge of the net-next tree with the net tree

2018-10-09 Thread Jamal Hadi Salim
ase double check. cheers, jamal --- a/net-next/net/sched/cls_u32.c 2018-10-09 05:18:04.046642676 -0400 +++ b/net/sched/cls_u32.c 2018-10-09 05:29:51.965528032 -0400 @@ -391,6 +391,7 @@ RCU_INIT_POINTER(root_ht->next, tp_c->hlist); rcu_assign_pointer(tp_c->hlist, r

Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr

2018-05-22 Thread Jamal Hadi Salim
all action idr spinlock usage with regular calls that do not disable bh. Signed-off-by: Vlad Buslov Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Jamal Hadi Salim
On 14/05/18 04:46 PM, Vlad Buslov wrote: On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote: On 14/05/18 10:27 AM, Vlad Buslov wrote: Hello Jamal, I'm trying to run tdc, but keep getting following error even on clean branch without my patches: Vlad, not sure if you saw my email:

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-14 Thread Jamal Hadi Salim
Please run all the tdc tests with these changes. This area has almost good test coverage at this point. If you need help just ping me. cheers, jamal

Re: [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-10-11 Thread Jamal Hadi Salim
On 17-10-10 10:33 PM, Manish Kurup wrote: Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. Signed-off-by: Manish Kurup Acked-by: Jamal Hadi Salim

Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

2017-03-04 Thread Jamal Hadi Salim
On 17-03-04 07:01 PM, Alexey Khoroshilov wrote: Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH]net:sched:release lock before tcf_dump_walker() normal return to avoid deadlock

2016-12-06 Thread Jamal Hadi Salim
, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
about it, the union is a pragmatic approach. cheers, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote: On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member of the structure, including 'pad'.

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
ny new pad fields added as "Not UAPI. Do not fsck fondle this". cheers, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 07:27 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: This structure is uapi, so anyone has complete rights to reference @pad in the userspace programs. Sure it would be more clear to remove the @pad completely, but if we choose so I

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:51 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote: [..] I dont know how compilation will fail but you may be right with note: that is not how pads have been used in the past. They are supposed to cosmetic annotation which indicates

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:17 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote: ... @@ -38,7 +38,10 @@ struct inet_diag_req_v2 { __u8sdiag_family; __u8sdiag_protocol; __u8idiag_ext; - __u8pad; + union

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
Also I notice when things like __raw_v4_lookup() are claiming it is unsigned short instead of a u8? cheers, jamal

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-18 Thread Jamal Hadi Salim
is better, although it is slightly large as a bug fix. I am conflicted. There are a lot of changes in net-next at the moment; adding this to -net seems like will definetely cause merge issues for Dave. Ok, Cong - patch attached and tested. Let me know what you think. cheers, jamal diff --gi

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-17 Thread Jamal Hadi Salim
ail and I thought about that afterwards). cheers, jamal

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Jamal Hadi Salim
; module_put() The same problem is actual for tcf_ife_cleanup() as well. Huh? Both module_put() and kfree() should not sleep, right? I dont think there is any sleeping there ;-> cheers, jamal diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 6bbc518..e341bef 100644 --- a/net/sched/act

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-15 Thread Jamal Hadi Salim
On 16-06-15 07:52 AM, Jamal Hadi Salim wrote: > On 16-06-15 04:38 AM, Jason Wang wrote: >> We used to queue tx packets in sk_receive_queue, this is less >> efficient since it requires spinlocks to synchronize between producer > > So this is more exercising the skb array

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-15 Thread Jamal Hadi Salim
l to see general performance numbers on user/kernel crossing (i.e tun read/write). If you have the cycles can you run such tests? cheers, jamal

Re: Deleting child qdisc doesn't reset parent to default qdisc?

2016-04-15 Thread Jamal Hadi Salim
ng a jury issuing a death sentence after 1 week of deliberation. You cant take it back after execution. cheers, jamal

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-09 Thread Jamal Hadi Salim
always expected to be present. I think a good test is old kernel with new iproute2. If the new field is non-optional, it will fail (example iproute2 may try to print a value that it expects but because old kernel doesnt understand it; it is non-existent). cheers, jamal

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-06 Thread Jamal Hadi Salim
Hi Emil, On 03/05/15 10:04, Emil Medve wrote: Hello Jamal, On 03/05/2015 08:35 AM, Jamal Hadi Salim wrote: Hi Emil, No. All the kernel drivers/code we want to upstream is meant to stand on its own and be used the "normal" Linux/Unix way Ok, thanks - that was my only concern.

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-05 Thread Jamal Hadi Salim
have support for user-space based approach. I'm unsure where/when we might publish that. Of course the SDK is always a place you can turn to for all the code we have (in whatever state it might be) the sdk is open source? cheers, jamal -- To unsubscribe from this list: send the line "un

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-05 Thread Jamal Hadi Salim
o add support for your classifiers, queue schedulers etc? Is that a patch on top of this or it is something that sits on user space? cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

[PATCH] staging: lustre: lustre: lov: lov_dev: fix sparse warning of static declaration

2015-02-10 Thread Mohammad Jamal
This patch adds a static keyword to cl_lov_device_mutex_class variable to suppress the warning of static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lustre/lov/lov_dev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre

[PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration

2015-02-09 Thread Mohammad Jamal
This patch adds a static keyword to variable portal_rotor to suppress the sparse warning of static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lnet/lnet/lib-ptl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib

[PATCH] staging: lustre: lustre: lmv: fix sparse warnings about static declarations

2015-02-03 Thread Mohammad Jamal
This patch adds a static keyword to lprocfs_lmv_init_vars and lprocfs_lmv_module_vars to suppress the sparse warnings about static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] staging: lustre: lustre: lmv: fix sparse warnings related to static declarations

2015-02-03 Thread Mohammad Jamal
This patch removes the sparse warnings present in the lproc_lmv.c Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lmv/lproc_lmv.c b/drivers/staging/lustre

[PATCH bluetooth-next] ieee802154: cc2520: Replace shift operations by BIT macro

2015-01-23 Thread Mohammad Jamal
This patch replaces the shifting operations by BIT macro Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c index 665a3db..181b349 100644

[PATCH bluetooth-next] ieee802154: cc2520: Fix space before , coding style issue

2015-01-23 Thread Mohammad Jamal
This patch removes the warnings (space before , ) shown by checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c index a43c8ac

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov wrote: > Hello. > > On 1/23/2015 12:26 PM, Mohammad Jamal wrote: > >> This patch solves the coding style issues such as space after , > > >s/after/before/? > >> and removes the blank lines > > > Ex

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram wrote: > Hi Mohammad Jamal, > > On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal > wrote: >> This patch solves the coding style issue warning >> by replacing the shifting operations by BIT macro >> >> Signed-off-by

[PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Mohammad Jamal
This patch solves the coding style issue warning by replacing the shifting operations by BIT macro Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net

[PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Mohammad Jamal
This patch solves the coding style issues such as space after , and removes the blank lines Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154

Re: [PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Jamal Mohammad
On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet wrote: > On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert wrote: > >> Hmm, this seems less readable to me. What is the effect of this patch? >> Does the compiler even produce different assembly? > > No change at all in generated assembly, this looks not

[PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Mohammad Jamal
This patch optimizes __skb_push function Signed-off-by: Mohammad Jamal --- include/linux/skbuff.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 85ab7d7..9acffb2 100644 --- a/include/linux/skbuff.h +++ b/include

Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-15 Thread Jamal Mohammad
Mohammad Jamal >> wrote: >> >> > Fix the coding style issue by adding a blank line after declaration >> > >> > Signed-off-by: Mohammad Jamal >> >> Patch applied. > > This one looks bogus; it's adding a random newline within the > de

[PATCH] mmc: host: sdhci: Added a space before (

2015-01-13 Thread Mohammad Jamal
This patch solves the coding style issue by adding a space before ( Signed-off-by: Mohammad Jamal --- drivers/mmc/host/sdhci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1453cd1..910ee7b 100644 --- a/drivers

[PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-13 Thread Mohammad Jamal
Fix the coding style issue by adding a blank line after declaration Signed-off-by: Mohammad Jamal --- drivers/gpio/gpio-dln2.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c index ce3c155..dbdb4de 100644 --- a/drivers/gpio/gpio-dln2.c

[PATCH] staging : iio: meter: ade7759: fix space before , coding style issue

2014-12-21 Thread Mohammad Jamal
This patch solves the space before , coding style issue found by checkpatch in ade7759.c Signed-off-by: Mohammad Jamal --- drivers/staging/iio/meter/ade7759.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter

[PATCH] staging: iio: adc: ad7192: fix space before , coding style issue

2014-12-21 Thread Mohammad Jamal
This patch solves the space before , error of the checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/staging/iio/adc/ad7192.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c index f6526aa..6f8ce6c

[PATCH] Staging : gdm724x: Remove space before , in function arguments

2014-12-20 Thread Mohammad Jamal
This patch solves space prohibited before , warning in gdm_mux.c Signed-off-by: Mohammad Jamal --- drivers/staging/gdm724x/gdm_mux.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index b5b063a

[PATCH] Staging: clocking-wizard: Added a blank line after declaration

2014-12-20 Thread Mohammad Jamal
Fix the coding style issue by adding blank line after declaration Signed-off-by: Mohammad Jamal --- .../clocking-wizard/clk-xlnx-clock-wizard.c|1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking

[PATCH] mtd: ssfdc: Fix space before ( coding style

2014-12-19 Thread Mohammad Jamal
Patch solves the space before ( coding style issue of ssfdc.c Signed-off-by: Mohammad Jamal --- drivers/mtd/ssfdc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index daf82ba..d4a922c 100644 --- a/drivers/mtd

[PATCH] ad525x_dpot-spi: Added Blank lines after declarations

2014-12-17 Thread Mohammad Jamal
This patch solves the blank line warning of checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot-spi.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/misc/ad525x_dpot-spi.c b/drivers/misc/ad525x_dpot-spi.c index 9da04ed..f4c82ea 100644 --- a/drivers/misc

[PATCH 2/2] ad525x_dpot:Remove break after return

2014-12-17 Thread Mohammad Jamal
This patch removes the break statements present after return Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index 32f9072..15e8807 100644 --- a/drivers/misc

[PATCH 1/2] ad525x_dpot: Add a blank line after declaration

2014-12-17 Thread Mohammad Jamal
Added a blank line after declaration to fix the warning of checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index a43053d..32f9072 100644 --- a/drivers/misc

[PATCH 2/2] misc: ad52x_dpot: fix break is not useful after a goto or return coding style issue in ad525x_dpot.c

2014-12-16 Thread Mohammad Jamal
This is a patch to the ad525x_dpot.c that fixes up the break after return warning coding style issue found by the checkpatch.pl tool Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/misc/ad525x_dpot.c b/drivers

[PATCH 1/2] misc:ad525x_dpot: Fix missing blank after declaration coding style issue in ad525x_dpot.c

2014-12-16 Thread Mohammad Jamal
This is a patch to ad525x_dpot.c file that fixes up a missing blank line after declaration warning found by checkpatch.pl issue Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc

[PATCH] Staging: rtl8192u : fix space before , coding style issue in r8190_rtl8256.c

2014-12-16 Thread Mohammad Jamal
This is a patch to r8190_rtl8256.c file that fixes space before , warning found by checkpatch.pl tool Signed-off-by: Mohammad Jamal --- drivers/staging/rtl8192u/r8190_rtl8256.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b

Re: [PATCH v2 0/3] net: Add Keystone NetCP ethernet driver support

2014-09-10 Thread Jamal Hadi Salim
ou hide all the offload interfaces and over time add them (starting with L2 - NICs with L2 are common). cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [PATCH v2 0/3] net: Add Keystone NetCP ethernet driver support

2014-09-09 Thread Jamal Hadi Salim
ose other pieces are open? e.g how do i add an entry to the L2 switch? cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver

2014-08-19 Thread Jamal Hadi Salim
of the sub-modules but i suspect things like switching/bridging or ipsec etc could be sub-modules. If yes, have you thought about integrating these features into Linux proper instead? cheers, jamal + +static inline int netcp_process_one_rx_packet(struct netcp_intf *netcp) +{ + + /* Call e

Re: [RFC PATCH] xfrm: fix handling of XFRM policies mark and mask.

2013-02-06 Thread Jamal Hadi Salim
ted to know if the algorithm would take these kind of cases into account. Aha. I think this is pushing the envelope a little - are there good use cases for this? certainly you could insert with most exact mask first. No such check is made at the moment. cheers, jamal -- To unsubscribe from t

Re: [RFC PATCH] xfrm: fix handling of XFRM policies mark and mask.

2013-02-06 Thread Jamal Hadi Salim
mark=5 and the other has mark=3. cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH] xfrm: fix handling of XFRM policies mark and mask.

2013-02-06 Thread jamal
the mark=0. The runtime check will work then. cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

Re: [net V2] act_mirred: do not drop packets when fails to mirror it

2012-08-16 Thread Jamal Hadi Salim
> > To solve the issue, the patch does not drop packets when kernel fails to > mirror > it, and only drop the redirected packets. > > Signed-off-by: Jason Wang Signed-off-by: Jamal Hadi Salim cheers, jamal -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jamal Hadi Salim
tcfm_eaction != TCA_EGRESS_MIRROR) retval = TC_ACT_SHOT; else retval = m->tcf_action; } else { retval = m->tcf_action; } Or at least dont use TC_ACT_STOLEN. cheers, jamal -- To unsubscribe fro

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jamal Hadi Salim
On Wed, 2012-08-15 at 17:37 +0800, Jason Wang wrote: > We drop packet unconditionally when we fail to mirror it. This is not intended > in some cases. Hi Jason, Did you actually notice the behavior you described or were you going by the XXX comment I had in the code? cheers, jamal

Re: [PATCH 15/21] net sched: Pass the skb into change so it can access NETLINK_CB

2012-08-15 Thread Jamal Hadi Salim
rtnetlink skb into > the the classifier change routines as that is generally the more useful > parameter. > > Cc: Jamal Hadi Salim > Acked-by: Serge Hallyn > Signed-off-by: Eric W. Biederman Acked-by: Jamal Hadi Salim cheers, jamal -- To unsubscribe from this list: send th

Re: parallel networking

2007-10-08 Thread jamal
ome the norm. Yes, i keep forgetting that ;-> I need to train my brain to remember that. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info

Re: parallel networking

2007-10-08 Thread jamal
On Mon, 2007-08-10 at 14:11 -0700, David Miller wrote: > The problem is that the packet schedulers want global guarantees > on packet ordering, not flow centric ones. > > That is the issue Jamal is concerned about. indeed, thank you for giving it better wording. > The more I

Re: parallel networking (was Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock)

2007-10-08 Thread jamal
mit/receive run would see more performance improvements. > Or maybe skb affinity is a dumb idea. I wanted to get people thinking > on the bigger picture. Parallelization starts at the user process. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-11 Thread jamal
On Tue, 2007-11-09 at 10:18 +0800, Herbert Xu wrote: > Jamal, it's the police_lock that we need to make _bh. The > ingress_lock is already _bh because of the spin_lock_bh that > directly precedes it. > > Oh and I think the same thing applies for the other actions > too.

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-10 Thread jamal
an you test with this patch? cheers, jamal [NET_SCHED] make ingress qlock symmetric to egress Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- a/net/sched/sch_generic.c 2007/09/10 23:19:45 1.1 +++ b/net/sched/sch_generic.c 2007/09/10 23:52:45 @@ -42,12 +42,12 @@ void qdi

AW: [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup

2007-05-14 Thread Abdelkarim Jamal
Vielen Dank Herr Seidel fuer Ihr Feedback. Mit freundlichen Gruessen Jamal MarvellĀ® Semiconductor Germany GmbH - Dipl. -Ing. Karim Jamal Technical Support Engineer -- Phone: +49 (0) 7243502-330 Fax: +49 (0) 7243502-364

Re: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

2007-04-25 Thread jamal
egress multiqueues? BTW, is there any reason this is being cced to lkml? cheers, jamal PS:- I havent read the kernel patches (i am congested and about 1000 messages behind on netdev) and my opinions may be influenced by an approach i have in trying to help someone fixup a wireless driver with multiqueue s

Re: [RFC] Arp announce (for Xen)

2007-03-02 Thread jamal
s a large number of user-desires, and can be turned off if you want to do something complex. _Almost_ elegant Stephen;-> cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: [patch] net/xfrm: fix crash in ipsec audit logging

2006-12-26 Thread jamal
e call into the else from above if (!delete) maybe? Otherwise you have to add back the "if (delete)" check since that function could be used to either retrieve (which is not subject to an audit) or delete an xp. cheers, jamal - To unsubscribe from this list: send the line "unsubscrib

Re: [take28-resend_1->0 0/8] kevent: Generic event handling mechanism.

2006-12-21 Thread jamal
On Thu, 2006-21-12 at 17:46 +0300, Evgeniy Polyakov wrote: > On Thu, Dec 21, 2006 at 09:40:26AM -0500, jamal ([EMAIL PROTECTED]) wrote: > > > Things like sockets/pipes can only benefit from direct kevent usage > > > instead of ->poll() and wrappers. > > > >

Re: [take28-resend_1->0 0/8] kevent: Generic event handling mechanism.

2006-12-21 Thread jamal
r example in my app it defaults to epoll. > Things like sockets/pipes can only benefit from direct kevent usage > instead of ->poll() and wrappers. You should be able change it to use those schemes when it detects that the kernel supports them. cheers, jamal - To unsubscribe from this list: s

Re: [take28-resend_1->0 0/8] kevent: Generic event handling mechanism.

2006-12-21 Thread jamal
patched? Its site is currently down, but ok, I > will create a patch. > I promise in 2 weeks to migrate an app or two that i have that use libevent to your version if you have it by then. I will then test and give you my opinion. cheers, jamal - To unsubscribe from this list: send the

Re: [take28-resend_1->0 0/8] kevent: Generic event handling mechanism.

2006-12-21 Thread jamal
they dont have to agree with you i.e the conclusion could be a simple "agree to disagree". - There really oughta be a limit on how long people are allowed to be silent. After that IMO your code should just go in ... cheers, jamal - To unsubscribe from this list: send the line "un

Re: Network drivers that don't suspend on interface down

2006-12-21 Thread jamal
ociation to a on-demand ppp link seeing an outgoing packet. IMO, for this discussion to be meaningful, it would be useful to read Documentation/networking/operstates.txt And if you are keen you can then read RFC 2863... cheers, jamal - To unsubscribe from this list: send the line "unsubscribe

Re: ACPI/HT or Packet Scheduler BUG?

2005-04-16 Thread jamal
ase/usage of qdiscs. I have a feeling though that the patch went in due to dude-optimizing-loopback as pointed by Herbert. It could also be it was done because RCU-is-so-cool. I dont recall. Maybe worth reverting to the earlier scheme if it is going to continue to be problematic. cheers, jamal -

Re: ACPI/HT or Packet Scheduler BUG?

2005-04-15 Thread jamal
] [] neigh_timer_handler+0x13e/0x320 [4294692.342000] [] run_timer_softirq+0x130/0x490 [4294692.342000] [] __do_softirq+0x42/0xa0 [4294692.342000] [] do_softirq+0x51/0x60 - Is this the same issue? Can you describe how you create this issue; kernel version etc. cheers, jamal On Fri, 2005

Re: [Fwd: Re: connector is missing in 2.6.12-rc2-mm1]

2005-04-10 Thread jamal
On Sun, 2005-04-10 at 10:56, James Morris wrote: > On 10 Apr 2005, jamal wrote: > > > Thats what the original motivation for konnector was. To make it easy > > for joe dumbass. > > Who you really want writing kernel code :-) Ok, let me take that back then ;-> The valu

Re: [Fwd: Re: connector is missing in 2.6.12-rc2-mm1]

2005-04-10 Thread jamal
hat you want yet lets just pull this whole thing out IMO. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http:

Re: Netlink Connector / CBUS

2005-04-05 Thread jamal
and, oh yeah - wheres the documentation Evgeniy? ;-> cheers, jamal On Tue, 2005-04-05 at 06:44, jamal wrote: > To be fair to Evgeniy I am not against the Konnector idea. I think that > it is a useful feature to have an easy to use messaging between > kernel-kernel and kernel-userspa

Re: Netlink Connector / CBUS

2005-04-05 Thread jamal
the code - and i think the idea of this new thing hes tossing around called CBUS maybe pushing it. cheers, jamal On Tue, 2005-04-05 at 03:34, Evgeniy Polyakov wrote: > On Tue, 2005-04-05 at 01:10 -0400, Herbert Xu wrote: > >On Tue, Apr 05, 2005 at 11:03:16AM +0400, Evgeniy Polya

Re: [RFC/PATCH] network configs: disconnect network options from drivers

2005-03-31 Thread jamal
fore the Device Drivers menu, > renames it to "Networking options and protocols", & moves most > protocols to more logical places (IMHOOC). > About time someone brave did this. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set

2005-03-29 Thread jamal
> appropriate struct are themselves ifdef-ed. We are trying to kill appearance of any #ifdef CONFIG_NET_CLS_ACT in the classifiers. The patch you sent is correct except it will introduce an ifdef that we are trying to kill. The current workaround is to turn on CONFIG_NET_CLS_ACT in the kernel buil

Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set

2005-03-29 Thread jamal
This is being discussed on netdev at the moment. Thomas Graf is working on a patch. Thanks for the effort though. cheers, jamal On Tue, 2005-03-29 at 15:25, Neil Horman wrote: > Patch to fix build break that occurs when CONFIG_NET_CLS_ACT is not set. > > Signed-off-by: Neil Horma

Re: memory leak in net/sched/ipt.c?

2005-03-23 Thread jamal
Actually its well documented even on the man pages - so should have not even have bothered discussing it;-> Should get new brand of coffee. Apologies for unecessarily abused electrons - which means dont respond ;-> cheers, jamal On Wed, 2005-03-23 at 09:05, jamal wrote: > On Wed, 2005

Re: memory leak in net/sched/ipt.c?

2005-03-23 Thread jamal
ULL) works. Thanks for clarifying this. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: memory leak in net/sched/ipt.c?

2005-03-23 Thread jamal
hsets. > Yes, already Jan Engelhardt <[EMAIL PROTECTED]> has made that point - although he did not post to netdev!! ;-> So ignore my comment Herbert cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED

Re: memory leak in net/sched/ipt.c?

2005-03-23 Thread jamal
On Wed, 2005-03-23 at 07:55, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2005-03-23 07:40 > > Just a small correction to patchlet: > > The second kfree should check for existence of t. > > t is either valid or NULL so it's not a problem, unless you want &g

Re: memory leak in net/sched/ipt.c?

2005-03-23 Thread jamal
eone doesnt post to netdev;-> Just a small correction to patchlet: The second kfree should check for existence of t. cheers, jamal > Thanks, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] updated, ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header

2005-03-11 Thread jamal
Actually there is a case to be made for this to be part of the bridge code. A VLAN is a single collision domain which is mappable to a collission domain that is a bridge. infact the old VLAN code written by Lennert (and somebody else) had those two intermingled. cheers, jamal On Fri, 2005-03-11

Re: [Lse-tech] Re: A common layer for Accounting packages

2005-02-28 Thread jamal
On Mon, 2005-02-28 at 09:25, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2005-02-28 09:10 [..] > > To justify writting the new code, I am assuming someone has actually sat > > down and in the minimal stuck their finger in the air > > and said "yes, there is de

Re: [Lse-tech] Re: A common layer for Accounting packages

2005-02-28 Thread jamal
On Mon, 2005-02-28 at 08:53, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2005-02-28 08:40 > > > > netlink broadcast or a wrapper around it. > > Why even bother doing the check with netlink_has_listeners()? > > To implement the master enable/disable switch th

Re: [Lse-tech] Re: A common layer for Accounting packages

2005-02-28 Thread jamal
netlink broadcast or a wrapper around it. Why even bother doing the check with netlink_has_listeners()? cheers, jamal On Mon, 2005-02-28 at 08:20, Thomas Graf wrote: > > Havent seen the beginnings of this thread. But whatever you are trying > > to do seems to suggest some complex

  1   2   >