Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-26 Thread Jamal Hadi Salim
counters.red_frames_count - filter->stats.drops; Thanks for the explanation. What is filter->stats? The rest of those counters seem related to the gate action. How do you account for policing actions? cheers, jamal

Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread Jamal Hadi Salim
On 2020-06-23 7:52 p.m., Po Liu wrote: Hi Jamal, My question: Is this any different from how stats are structured? [..] My question: Why cant you apply the same semantics for the counters? Does your hardware have an indexed counter/stats table? If yes then you Yes

Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Jamal Hadi Salim
they use the same counter. cheers, jamal

Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Jamal Hadi Salim
. cheers, jamal On 2020-06-23 2:34 a.m., Po Liu wrote: From: Po Liu Hardware may own many entries for police flow. So that make one(or multi) flow to be policed by one hardware entry. This patch add the police action index provide to the driver side make it mapping the driver hardware entry index

CONGRATULATIONS

2019-09-07 Thread Bin Jamal
on how your ATM CARD can be delivered to you. Here is the contact of the security company below, contact them with your receiving address and telephone number Company name: Sure Security Services Company LTD Manager Name: Mr. Tom Nelson Email: sur...@contractor.net Best Regards, Mr. Bin Jamal

Re: [PATCH net-next 0/2] Change tc action identifiers to be more consistent

2019-02-07 Thread Jamal Hadi Salim
On 2019-02-07 2:45 a.m., Eli Cohen wrote: This two patch series modifies TC actions identifiers to be more consistent and also puts them in one place so new identifiers numbers can be chosen more easily. For the series: Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH/RFC] Make perf_event_open() propagate errors for use in bpf_perf_event_open()

2019-01-12 Thread Jamal Hadi Salim
est built. Works as advertised ;-> Tested-by: Jamal Hadi Salim cheers, jamal

Re: linux-next: manual merge of the net-next tree with the net tree

2018-10-09 Thread Jamal Hadi Salim
ouble check. cheers, jamal --- a/net-next/net/sched/cls_u32.c 2018-10-09 05:18:04.046642676 -0400 +++ b/net/sched/cls_u32.c 2018-10-09 05:29:51.965528032 -0400 @@ -391,6 +391,7 @@ RCU_INIT_POINTER(root_ht->next, tp_c->hlist); rcu_assign_pointer(tp_c->hlist, root_h

Re: linux-next: manual merge of the net-next tree with the net tree

2018-10-09 Thread Jamal Hadi Salim
ouble check. cheers, jamal --- a/net-next/net/sched/cls_u32.c 2018-10-09 05:18:04.046642676 -0400 +++ b/net/sched/cls_u32.c 2018-10-09 05:29:51.965528032 -0400 @@ -391,6 +391,7 @@ RCU_INIT_POINTER(root_ht->next, tp_c->hlist); rcu_assign_pointer(tp_c->hlist, root_h

Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr

2018-05-22 Thread Jamal Hadi Salim
all action idr spinlock usage with regular calls that do not disable bh. Signed-off-by: Vlad Buslov <vla...@mellanox.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr

2018-05-22 Thread Jamal Hadi Salim
all action idr spinlock usage with regular calls that do not disable bh. Signed-off-by: Vlad Buslov Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Jamal Hadi Salim
On 14/05/18 04:46 PM, Vlad Buslov wrote: On Mon 14 May 2018 at 18:03, Jamal Hadi Salim <j...@mojatatu.com> wrote: On 14/05/18 10:27 AM, Vlad Buslov wrote: Hello Jamal, I'm trying to run tdc, but keep getting following error even on clean branch without my patches: Vlad, not sure

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Jamal Hadi Salim
On 14/05/18 04:46 PM, Vlad Buslov wrote: On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote: On 14/05/18 10:27 AM, Vlad Buslov wrote: Hello Jamal, I'm trying to run tdc, but keep getting following error even on clean branch without my patches: Vlad, not sure if you saw my email: Apply

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-14 Thread Jamal Hadi Salim
the tdc tests with these changes. This area has almost good test coverage at this point. If you need help just ping me. cheers, jamal

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-14 Thread Jamal Hadi Salim
the tdc tests with these changes. This area has almost good test coverage at this point. If you need help just ping me. cheers, jamal

Re: [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-10-11 Thread Jamal Hadi Salim
Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-10-11 Thread Jamal Hadi Salim
On 17-10-10 10:33 PM, Manish Kurup wrote: Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. Signed-off-by: Manish Kurup Acked-by: Jamal Hadi Salim

Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

2017-03-04 Thread Jamal Hadi Salim
On 17-03-04 07:01 PM, Alexey Khoroshilov wrote: Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

2017-03-04 Thread Jamal Hadi Salim
On 17-03-04 07:01 PM, Alexey Khoroshilov wrote: Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH]net:sched:release lock before tcf_dump_walker() normal return to avoid deadlock

2016-12-06 Thread Jamal Hadi Salim
stcase we can try? cheers, jamal

Re: [PATCH]net:sched:release lock before tcf_dump_walker() normal return to avoid deadlock

2016-12-06 Thread Jamal Hadi Salim
, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
it, the union is a pragmatic approach. cheers, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
it, the union is a pragmatic approach. cheers, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote: On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that expl

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote: On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member of the structure, inc

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member of the structure, including 'pad'. So we have

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
fields added as "Not UAPI. Do not fsck fondle this". cheers, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
fields added as "Not UAPI. Do not fsck fondle this". cheers, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 07:27 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: This structure is uapi, so anyone has complete rights to reference @pad in the userspace programs. Sure it would be more clear to remove the @pad completely, but if we choose so I

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 07:27 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: This structure is uapi, so anyone has complete rights to reference @pad in the userspace programs. Sure it would be more clear to remove the @pad completely, but if we choose so I

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:51 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote: [..] I dont know how compilation will fail but you may be right with note: that is not how pads have been used in the past. They are supposed to cosmetic annotation which indicates

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:51 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote: [..] I dont know how compilation will fail but you may be right with note: that is not how pads have been used in the past. They are supposed to cosmetic annotation which indicates

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:17 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote: ... @@ -38,7 +38,10 @@ struct inet_diag_req_v2 { __u8sdiag_family; __u8sdiag_protocol; __u8idiag_ext; - __u8pad; + union

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:17 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote: ... @@ -38,7 +38,10 @@ struct inet_diag_req_v2 { __u8sdiag_family; __u8sdiag_protocol; __u8idiag_ext; - __u8pad; + union

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
ke __raw_v4_lookup() are claiming it is unsigned short instead of a u8? cheers, jamal

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
ice when things like __raw_v4_lookup() are claiming it is unsigned short instead of a u8? cheers, jamal

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-18 Thread Jamal Hadi Salim
net is better, although it is slightly large as a bug fix. I am conflicted. There are a lot of changes in net-next at the moment; adding this to -net seems like will definetely cause merge issues for Dave. Ok, Cong - patch attached and tested. Let me know what you think. cheers, jamal diff --

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-18 Thread Jamal Hadi Salim
net is better, although it is slightly large as a bug fix. I am conflicted. There are a lot of changes in net-next at the moment; adding this to -net seems like will definetely cause merge issues for Dave. Ok, Cong - patch attached and tested. Let me know what you think. cheers, jamal diff --

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-17 Thread Jamal Hadi Salim
(you said it in your earlier email and I thought about that afterwards). cheers, jamal

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-17 Thread Jamal Hadi Salim
ail and I thought about that afterwards). cheers, jamal

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Jamal Hadi Salim
-> module_put() The same problem is actual for tcf_ife_cleanup() as well. Huh? Both module_put() and kfree() should not sleep, right? I dont think there is any sleeping there ;-> cheers, jamal diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 6bbc518..e341bef 100

Re: [BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Jamal Hadi Salim
le_put() The same problem is actual for tcf_ife_cleanup() as well. Huh? Both module_put() and kfree() should not sleep, right? I dont think there is any sleeping there ;-> cheers, jamal diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 6bbc518..e341bef 100644 --- a/net/sched/act_ife.c +++

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-15 Thread Jamal Hadi Salim
On 16-06-15 07:52 AM, Jamal Hadi Salim wrote: > On 16-06-15 04:38 AM, Jason Wang wrote: >> We used to queue tx packets in sk_receive_queue, this is less >> efficient since it requires spinlocks to synchronize between producer > > So this is more exercising the skb array

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-15 Thread Jamal Hadi Salim
On 16-06-15 07:52 AM, Jamal Hadi Salim wrote: > On 16-06-15 04:38 AM, Jason Wang wrote: >> We used to queue tx packets in sk_receive_queue, this is less >> efficient since it requires spinlocks to synchronize between producer > > So this is more exercising the skb array

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-15 Thread Jamal Hadi Salim
l to see general performance numbers on user/kernel crossing (i.e tun read/write). If you have the cycles can you run such tests? cheers, jamal

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-15 Thread Jamal Hadi Salim
l to see general performance numbers on user/kernel crossing (i.e tun read/write). If you have the cycles can you run such tests? cheers, jamal

Re: Deleting child qdisc doesn't reset parent to default qdisc?

2016-04-15 Thread Jamal Hadi Salim
death sentence after 1 week of deliberation. You cant take it back after execution. cheers, jamal

Re: Deleting child qdisc doesn't reset parent to default qdisc?

2016-04-15 Thread Jamal Hadi Salim
death sentence after 1 week of deliberation. You cant take it back after execution. cheers, jamal

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-09 Thread Jamal Hadi Salim
always expected to be present. I think a good test is old kernel with new iproute2. If the new field is non-optional, it will fail (example iproute2 may try to print a value that it expects but because old kernel doesnt understand it; it is non-existent). cheers, jamal

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-09 Thread Jamal Hadi Salim
c. i.e by non-optional i mean always expected to be present. I think a good test is old kernel with new iproute2. If the new field is non-optional, it will fail (example iproute2 may try to print a value that it expects but because old kernel doesnt understand it; it is non-existent). cheers, jamal

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-06 Thread Jamal Hadi Salim
Hi Emil, On 03/05/15 10:04, Emil Medve wrote: Hello Jamal, On 03/05/2015 08:35 AM, Jamal Hadi Salim wrote: Hi Emil, No. All the kernel drivers/code we want to upstream is meant to stand on its own and be used the "normal" Linux/Unix way Ok, thanks - that was my only con

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-06 Thread Jamal Hadi Salim
Hi Emil, On 03/05/15 10:04, Emil Medve wrote: Hello Jamal, On 03/05/2015 08:35 AM, Jamal Hadi Salim wrote: Hi Emil, No. All the kernel drivers/code we want to upstream is meant to stand on its own and be used the normal Linux/Unix way Ok, thanks - that was my only concern. Note

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-05 Thread Jamal Hadi Salim
support for user-space based approach. I'm unsure where/when we might publish that. Of course the SDK is always a place you can turn to for all the code we have (in whatever state it might be) the sdk is open source? cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-05 Thread Jamal Hadi Salim
support for your classifiers, queue schedulers etc? Is that a patch on top of this or it is something that sits on user space? cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-05 Thread Jamal Hadi Salim
are you planning to add support for your classifiers, queue schedulers etc? Is that a patch on top of this or it is something that sits on user space? cheers, jamal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 0/7] Freescale DPAA FMan FLIB(s)

2015-03-05 Thread Jamal Hadi Salim
support for user-space based approach. I'm unsure where/when we might publish that. Of course the SDK is always a place you can turn to for all the code we have (in whatever state it might be) the sdk is open source? cheers, jamal -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH] staging: lustre: lustre: lov: lov_dev: fix sparse warning of static declaration

2015-02-10 Thread Mohammad Jamal
This patch adds a static keyword to cl_lov_device_mutex_class variable to suppress the warning of static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lustre/lov/lov_dev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre

[PATCH] staging: lustre: lustre: lov: lov_dev: fix sparse warning of static declaration

2015-02-10 Thread Mohammad Jamal
This patch adds a static keyword to cl_lov_device_mutex_class variable to suppress the warning of static declaration Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/staging/lustre/lustre/lov/lov_dev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration

2015-02-09 Thread Mohammad Jamal
This patch adds a static keyword to variable portal_rotor to suppress the sparse warning of static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lnet/lnet/lib-ptl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib

[PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration

2015-02-09 Thread Mohammad Jamal
This patch adds a static keyword to variable portal_rotor to suppress the sparse warning of static declaration Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/staging/lustre/lnet/lnet/lib-ptl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] staging: lustre: lustre: lmv: fix sparse warnings about static declarations

2015-02-03 Thread Mohammad Jamal
This patch adds a static keyword to lprocfs_lmv_init_vars and lprocfs_lmv_module_vars to suppress the sparse warnings about static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] staging: lustre: lustre: lmv: fix sparse warnings related to static declarations

2015-02-03 Thread Mohammad Jamal
This patch removes the sparse warnings present in the lproc_lmv.c Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lmv/lproc_lmv.c b/drivers/staging/lustre

[PATCH] staging: lustre: lustre: lmv: fix sparse warnings related to static declarations

2015-02-03 Thread Mohammad Jamal
This patch removes the sparse warnings present in the lproc_lmv.c Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lmv/lproc_lmv.c

[PATCH] staging: lustre: lustre: lmv: fix sparse warnings about static declarations

2015-02-03 Thread Mohammad Jamal
This patch adds a static keyword to lprocfs_lmv_init_vars and lprocfs_lmv_module_vars to suppress the sparse warnings about static declaration Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++-- 1 file changed, 2 insertions

[PATCH bluetooth-next] ieee802154: cc2520: Replace shift operations by BIT macro

2015-01-23 Thread Mohammad Jamal
This patch replaces the shifting operations by BIT macro Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c index 665a3db..181b349 100644

[PATCH bluetooth-next] ieee802154: cc2520: Fix space before , coding style issue

2015-01-23 Thread Mohammad Jamal
This patch removes the warnings (space before , ) shown by checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c index a43c8ac

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov wrote: > Hello. > > On 1/23/2015 12:26 PM, Mohammad Jamal wrote: > >> This patch solves the coding style issues such as space after , > > >s/after/before/? > >> and removes the blank lines > > >

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram wrote: > Hi Mohammad Jamal, > > On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal > wrote: >> This patch solves the coding style issue warning >> by replacing the shifting operations by BIT macro >> >> Signed-off-by

[PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Mohammad Jamal
This patch solves the coding style issue warning by replacing the shifting operations by BIT macro Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net

[PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Mohammad Jamal
This patch solves the coding style issues such as space after , and removes the blank lines Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154

[PATCH bluetooth-next] ieee802154: cc2520: Fix space before , coding style issue

2015-01-23 Thread Mohammad Jamal
This patch removes the warnings (space before , ) shown by checkpatch.pl Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/net/ieee802154/cc2520.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net

[PATCH bluetooth-next] ieee802154: cc2520: Replace shift operations by BIT macro

2015-01-23 Thread Mohammad Jamal
This patch replaces the shifting operations by BIT macro Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c

[PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Mohammad Jamal
This patch solves the coding style issues such as space after , and removes the blank lines Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/net/ieee802154/cc2520.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ieee802154/cc2520.c b

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram varkabhad...@gmail.com wrote: Hi Mohammad Jamal, On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal md.jamalmohiud...@gmail.com wrote: This patch solves the coding style issue warning by replacing the shifting operations by BIT macro Signed-off

[PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Mohammad Jamal
This patch solves the coding style issue warning by replacing the shifting operations by BIT macro Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ieee802154

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 1/23/2015 12:26 PM, Mohammad Jamal wrote: This patch solves the coding style issues such as space after , s/after/before/? and removes the blank lines Extra blank lines, you mean

Re: [PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Jamal Mohammad
On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet wrote: > On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert wrote: > >> Hmm, this seems less readable to me. What is the effect of this patch? >> Does the compiler even produce different assembly? > > No change at all in generated assembly, this looks

[PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Mohammad Jamal
This patch optimizes __skb_push function Signed-off-by: Mohammad Jamal --- include/linux/skbuff.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 85ab7d7..9acffb2 100644 --- a/include/linux/skbuff.h +++ b/include

Re: [PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Jamal Mohammad
On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet eduma...@google.com wrote: On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert therb...@google.com wrote: Hmm, this seems less readable to me. What is the effect of this patch? Does the compiler even produce different assembly? No change at all in

[PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Mohammad Jamal
This patch optimizes __skb_push function Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- include/linux/skbuff.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 85ab7d7..9acffb2 100644 --- a/include/linux

Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-15 Thread Jamal Mohammad
Mohammad Jamal >> wrote: >> >> > Fix the coding style issue by adding a blank line after declaration >> > >> > Signed-off-by: Mohammad Jamal >> >> Patch applied. > > This one looks bogus; it's adding a random newline within the > dec

Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-15 Thread Jamal Mohammad
PM, Mohammad Jamal md.jamalmohiud...@gmail.com wrote: Fix the coding style issue by adding a blank line after declaration Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com Patch applied. This one looks bogus; it's adding a random newline within the declarations not after. Johan

[PATCH] mmc: host: sdhci: Added a space before (

2015-01-13 Thread Mohammad Jamal
This patch solves the coding style issue by adding a space before ( Signed-off-by: Mohammad Jamal --- drivers/mmc/host/sdhci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1453cd1..910ee7b 100644 --- a/drivers

[PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-13 Thread Mohammad Jamal
Fix the coding style issue by adding a blank line after declaration Signed-off-by: Mohammad Jamal --- drivers/gpio/gpio-dln2.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c index ce3c155..dbdb4de 100644 --- a/drivers/gpio/gpio-dln2.c

[PATCH] mmc: host: sdhci: Added a space before (

2015-01-13 Thread Mohammad Jamal
This patch solves the coding style issue by adding a space before ( Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/mmc/host/sdhci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1453cd1

[PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-13 Thread Mohammad Jamal
Fix the coding style issue by adding a blank line after declaration Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/gpio/gpio-dln2.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c index ce3c155..dbdb4de 100644

[PATCH] staging : iio: meter: ade7759: fix space before , coding style issue

2014-12-21 Thread Mohammad Jamal
This patch solves the space before , coding style issue found by checkpatch in ade7759.c Signed-off-by: Mohammad Jamal --- drivers/staging/iio/meter/ade7759.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter

[PATCH] staging: iio: adc: ad7192: fix space before , coding style issue

2014-12-21 Thread Mohammad Jamal
This patch solves the space before , error of the checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/staging/iio/adc/ad7192.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c index f6526aa..6f8ce6c

[PATCH] staging: iio: adc: ad7192: fix space before , coding style issue

2014-12-21 Thread Mohammad Jamal
This patch solves the space before , error of the checkpatch.pl Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/staging/iio/adc/ad7192.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192

[PATCH] staging : iio: meter: ade7759: fix space before , coding style issue

2014-12-21 Thread Mohammad Jamal
This patch solves the space before , coding style issue found by checkpatch in ade7759.c Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/staging/iio/meter/ade7759.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/meter/ade7759.c b

[PATCH] Staging : gdm724x: Remove space before , in function arguments

2014-12-20 Thread Mohammad Jamal
This patch solves space prohibited before , warning in gdm_mux.c Signed-off-by: Mohammad Jamal --- drivers/staging/gdm724x/gdm_mux.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index b5b063a

[PATCH] Staging: clocking-wizard: Added a blank line after declaration

2014-12-20 Thread Mohammad Jamal
Fix the coding style issue by adding blank line after declaration Signed-off-by: Mohammad Jamal --- .../clocking-wizard/clk-xlnx-clock-wizard.c|1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking

[PATCH] Staging: clocking-wizard: Added a blank line after declaration

2014-12-20 Thread Mohammad Jamal
Fix the coding style issue by adding blank line after declaration Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- .../clocking-wizard/clk-xlnx-clock-wizard.c|1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b

[PATCH] Staging : gdm724x: Remove space before , in function arguments

2014-12-20 Thread Mohammad Jamal
This patch solves space prohibited before , warning in gdm_mux.c Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/staging/gdm724x/gdm_mux.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x

[PATCH] mtd: ssfdc: Fix space before ( coding style

2014-12-19 Thread Mohammad Jamal
Patch solves the space before ( coding style issue of ssfdc.c Signed-off-by: Mohammad Jamal --- drivers/mtd/ssfdc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index daf82ba..d4a922c 100644 --- a/drivers/mtd

[PATCH] mtd: ssfdc: Fix space before ( coding style

2014-12-19 Thread Mohammad Jamal
Patch solves the space before ( coding style issue of ssfdc.c Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- drivers/mtd/ssfdc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index daf82ba

[PATCH] ad525x_dpot-spi: Added Blank lines after declarations

2014-12-17 Thread Mohammad Jamal
This patch solves the blank line warning of checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot-spi.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/misc/ad525x_dpot-spi.c b/drivers/misc/ad525x_dpot-spi.c index 9da04ed..f4c82ea 100644 --- a/drivers/misc

[PATCH 2/2] ad525x_dpot:Remove break after return

2014-12-17 Thread Mohammad Jamal
This patch removes the break statements present after return Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index 32f9072..15e8807 100644 --- a/drivers/misc

[PATCH 1/2] ad525x_dpot: Add a blank line after declaration

2014-12-17 Thread Mohammad Jamal
Added a blank line after declaration to fix the warning of checkpatch.pl Signed-off-by: Mohammad Jamal --- drivers/misc/ad525x_dpot.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index a43053d..32f9072 100644 --- a/drivers/misc

  1   2   3   4   >