Re: [PATCH 0/2] kmod /usr support

2024-08-21 Thread Lucas De Marchi
On Tue, Dec 19, 2023 at 05:37:31PM GMT, Masahiro Yamada wrote: On Thu, Dec 7, 2023 at 3:37 AM Lucas De Marchi wrote: On Fri, Nov 10, 2023 at 01:13:53PM +0100, Michal Suchanek wrote: >Hello, > >This is resend of the last patch in the series that adds prefix support >to kernel mod

Re: [PATCH 0/2] kmod /usr support

2024-08-21 Thread Lucas De Marchi
On Wed, Aug 21, 2024 at 10:58:43AM GMT, Nathan Chancellor wrote: Did this conversation go anywhere? After the upgrade to kmod 33 in Arch no, it stalled, thanks for reminding me. I will follow up on it. Lucas De Marchi

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Lucas De Marchi
On Thu, Jul 25, 2024 at 04:39:40PM GMT, Steven Price wrote: On 25/07/2024 15:29, Lucas De Marchi wrote: On Thu, Jul 25, 2024 at 01:37:46PM GMT, Dragan Simic wrote: Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is supported on the associated platforms, while using

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Lucas De Marchi
softdep") could indeed be solved with a weakdep, so I'm not sure why you'd want to alias it as a "hard dep". Lucas De Marchi sugar, currently implemented as an alias for MODULE_WEAKDEP, so the actual hard module dependencies can be expressed properly, and possibly handled d

Re: [PATCH] lib/test_kmod: add missing MODULE_DESCRIPTION() macro

2024-06-14 Thread Lucas De Marchi
On Fri, May 31, 2024 at 05:23:09PM GMT, Jeff Johnson wrote: make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kmod.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson Reviewed-by: Lucas D

Re: Current status and possible improvements in CONFIG_MODULE_FORCE_UNLOAD

2024-06-14 Thread Lucas De Marchi
heir driver and start sending the issues to their side. Lucas De Marchi Regards Aditya

Re: [PATCH v3] module: create weak dependecies

2024-05-14 Thread Lucas De Marchi
new enough. If it isn't, depmod will have the same behavior as always (keeping backward compatibility) and the information for the 'weak' dependency will not be provided. Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Lucas De Marchi thanks Lucas De Marchi --- V2

Re: [PATCH v2] module: create weak dependecies

2024-05-09 Thread Lucas De Marchi
ux/module.h @@ -173,6 +173,11 @@ extern void cleanup_module(void); */ #define MODULE_SOFTDEP(_softdep) MODULE_INFO(softdep, _softdep) +/* Weak module dependencies. See man modprobe.d for details. Documentation/process/coding-style.rst section 8 says to balance the /* and */, but up to Luis what h

Re: [PATCH 0/2] kmod /usr support

2023-12-06 Thread Lucas De Marchi
applied, thanks Lucas De Marchi

Re: [PATCH] kmod: Add FIPS 202 SHA-3 support

2023-12-06 Thread Lucas De Marchi
case NID_sha3_512: + return PKEY_HASH_SHA3_512; with your other patch, libkmod: remove pkcs7 obj_to_hash_algo(), this hunk is not needed anymore. Do you want to send a new version of this patch? thanks Lucas De Marchi default: return -1; } -- 2.34.1

Re: [PATCH kmod] libkmod: remove pkcs7 obj_to_hash_algo()

2023-11-07 Thread Lucas De Marchi
openssl and kernel know about. For example SHA3 are being added for v6.7 and with this patch are automatically supported. Signed-off-by: Dimitri John Ledkov Applied, thanks Lucas De Marchi

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-10-17 Thread Lucas De Marchi
od/detect-loop$MODULE_DIRECTORY/4.4.4/kernel/mod-loop-j.ko"]="mod-loop-j.ko" + ["test-depmod/detect-loop$MODULE_DIRECTORY/4.4.4/kernel/mod-loop-k.ko"]="mod-loop-k.ko" + ["test-depmod/search-order-external-first$MODULE_DIRECTORY/4.4.4/foo/"]="mod-simple.ko" + ["test-depmod/search-order-external-first$MODULE_DIRECTORY/4.4.4/foobar/"]="mod-simple.ko" ["test-depmod/search-order-external-first/lib/modules/external/"]="mod-simple.ko" why didn't you change it here? - ["test-depmod/search-order-external-last/lib/modules/4.4.4/foo/"]="mod-simple.ko" - ["test-depmod/search-order-external-last/lib/modules/4.4.4/foobar/"]="mod-simple.ko" + ["test-depmod/search-order-external-last$MODULE_DIRECTORY/4.4.4/foo/"]="mod-simple.ko" + ["test-depmod/search-order-external-last$MODULE_DIRECTORY/4.4.4/foobar/"]="mod-simple.ko" ["test-depmod/search-order-external-last/lib/modules/external/"]="mod-simple.ko" and here... Otherwise looks good to me. Pushed the first 4 patches. thanks Lucas De Marchi

Re: [PATCH kmod v5 0/5] kmod /usr support

2023-10-17 Thread Lucas De Marchi
g the preferred solution? Lucas De Marchi

[ANNOUNCE] kmod 31

2023-09-29 Thread Lucas De Marchi
testsuite: fix override of `stat` on 32-bit architectures Lucas De Marchi (8): testsuite: Move setup-rootfs logic from Makefile to script testsuite: Handle different sysconfdir libkmod: Do not inititialize file->memory on open libkmod: Extract finit_module vs init

[ANNOUNCE] kmod 28

2021-01-07 Thread Lucas De Marchi
configure) - Bug fixes - Ignore ill-formed kernel command line, e.g. with "ivrs_acpihid[00:14.5]=AMD0020:0" option in it - Fix some memory leaks - Fix 0-length builtin.alias.bin: it needs at least the index header Shortlog is below: Lucas De Marchi (17):

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Lucas De Marchi
"ELK", reg_val); drivers/gpu/drm/i915/gem/i915_gem_stolen.c: * Whether ILK really reuses the ELK register for this is unclear. drivers/gpu/drm/i915/intel_pm.c: * Not 100% sure which way ELK should go here as the drivers/gpu/drm/i915/intel_pm.c: * assume ELK doesn&

Re: [PATCH] module: Add more error message for failed kernel module loading

2020-09-01 Thread Lucas De Marchi
On Tue, Sep 1, 2020 at 12:56 PM Prarit Bhargava wrote: > > > > On 9/1/20 2:50 PM, Lucas De Marchi wrote: > > On Sat, Aug 29, 2020 at 4:15 AM Qu Wenruo wrote: > >> > >> When kernel module loading failed, user space only get one of the > >> following e

Re: [PATCH] module: Add more error message for failed kernel module loading

2020-09-01 Thread Lucas De Marchi
modules: Add kernel parameter to blacklist modules as a way to overcome broken initrd generation afaics. Either kernel command line (using modprobe.blacklist) or /etc/modprobe.d options are honoured by libkmod and allow a sufficiently privileged user to bypass it. +Rusty, +Prarit: is there anything this module parameter is covering that I'm missing? For the changes here, Reviewed-by: Lucas De Marchi thanks Lucas De Marchi > goto free_copy; > } > > -- > 2.27.0 >

Re: [PATCH] depmod: create and use System.map.no_namespaces

2019-10-04 Thread Lucas De Marchi
> > [1] > https://lore.kernel.org/linux-modules/20191004094136.166621-1-maenn...@google.com/ > > Reported-by: Stefan Wahren > Fixes: 8651ec01daed ("module: add support for symbol namespaces.") > Cc: Masahiro Yamada > Cc: Lucas De Marchi > Cc: Jessica Yu

Re: [kmod][PATCH] module: fix error path in kmod_module_probe_insert_module()

2019-05-28 Thread Lucas De Marchi
re use cases"). If you look at the definition of 'enum kmod_probe' you will see that not all flags are returned as positive values - the only values that have this behavior are the ones related to blacklist. Could you rather patch the documentation? thanks Lucas De Marchi

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-16 Thread Lucas De Marchi
g, nothing we can do about that :) It's actually not a bug. For external modules it works pretty much as intended. See DEPMOD.D(5): the search directive tells what's the preference among the directories for modules with the same name. depmod respects that order and put the right one into your modules.dep. This allows to put external modules in a different dir and also to make backports of modules from recent to ancient kernels. These modules with the same name are usually the same module, with a different version. Of course what we have here and you are fixing is a different story. Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [PATCH v2] moduleparam: Save information about built-in modules in separate file

2019-04-18 Thread Lucas De Marchi
view. > > Since kbuild already produces "modules.order" and "modules.builtin" > files, why not just name it "modules.builtin.modinfo" to keep the I agree with modules.builtin.modinfo > names consistent with what is already there? It clearly conveys that > this file contains modinfo for builtin modules. > > I'll leave it up to Lucas to decide if the file format is OK for kmod. > With the modinfo dump, kmod could then decide what to do with the > information, append to modules.alias{,.bin}, etc. I think it's ok with the current format. It's simple enough. I would delay merging it until the userspace counterpart is implemented though. So to make sure we have everything we need. I can work on that in ~1 or 2 weeks. thanks Lucas De Marchi > > Also, I think this file needs to be documented in > Documentation/kbuild/kbuild.txt. > > Thanks, > > Jessica -- Lucas De Marchi

Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file

2019-03-28 Thread Lucas De Marchi
.modinfo ? > > It is much easier to create and it has almost the same format as the > modules. So I think it will be easier to parse in kmod. adding a modules.builtin.alias with the same format of modules.alias means during modprobe we would only need to load one more file to lookup aliases. That doesn't mean the kernel built system should do it though. The same way it's depmod job to create the modules.alias{,.bin}, we could leave this to depmod if it's in fact useful to split the information. I think your version is simple enough and we would get more information that would be useful for modinfo. It would indeed be nice to output something useful in "modinfo ext4". In kmod, I think we would create modules.builtin.modinfo{,.bin} and just add the aliases to modules.alias{,.bin}, This would keep the names consistent with what is already there. thanks Lucas De Marchi > > -- > Rgrds, legion >

Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file

2019-03-28 Thread Lucas De Marchi
imply because we don't have parameters for that module always annoyed me. Lucas De Marchi

[ANNOUNCE] kmod 26

2019-02-07 Thread Lucas De Marchi
p Jan Engelhardt (1): kmod: build: cure compiler warnings showing up externally Luca Bruno (1): libkmod-module: check for NULL before accessing pointers Lucas De Marchi (17): testsuite: raise arch image to 3GB man: depmod: remove deprecated -m option mkosi: all

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2019-01-29 Thread Lucas De Marchi
DPLL state left over by > broken SNB BIOSen") > > It seems this was cherry-picked incorrectly :-( while the cherry-pick was correct, the macro is different on drm-intel-fixes. IS_GEN(dev_priv, 6) needs to be converted to IS_GEN6(dev_priv).

Re: [PATCH 2/6] module: add support for symbol namespaces.

2018-07-25 Thread Lucas De Marchi
at would be easy and allow depmod to be backward compatible since we would do nothing if the symbol doesn't have the suffix. As for dependency on a new version, this seems trivial enough to be backported to previous releases used on distros so even if they are not rolling they would get a compat

[ANNOUNCE] kmod 25

2018-01-08 Thread Lucas De Marchi
d: add override test depmod: module_is_higher_priority: fix modname length calculation Lucas De Marchi (9): test-depmod: avoid warning when we don't have zlib build: add mkosi hooks build: use tool from configure testsuite: generalize mkosi support for other dis

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-09-08 Thread Lucas De Marchi
handle dependencies). For this particular case, not going through the modprobe helper would be a way to accomplish that since you wouldn't need the corresponding binfmt module to run modprobe. Udev handles module loading via libkmod , but the only way to trigger it is via the rules rather than via a request from kernel. Lucas De Marchi

Re: [PATCH] libkmod-elf: resolve CRC if module is built with MODULE_REL_CRCS

2017-07-19 Thread Lucas De Marchi
bind = ELF64_ST_BIND(info); > > - a[count].crc = crc; > + a[count].crc = kmod_elf_resolve_crc(elf, crc, shndx); > a[count].bind = kmod_symbol_bind_from_elf(bind); > a[count].symbol = itr; > slen = strlen(name); > -- LGTM. I'll give this a try and apply. Do you think it's possible to build an out-of-tree module with this option so we can add one to the testsuite? Lucas De Marchi

[ANNOUNCE] kmod 24

2017-02-23 Thread Lucas De Marchi
Shortlog is below Bartosz Golaszewski (1): module: fix a memory leak James Minor (1): libkmod: Fix handling of quotes in kernel command line Lucas De Marchi (15): libkmod: fix use of strcpy util: fix warning of equal values on logical OR testsuite: include stdio.h

[PATCH v4 0/4] i2c: designware: improve performance for transfers

2016-08-23 Thread Lucas De Marchi
- This is tested on BayTrail and CherryTrail, both of them returning true for "dynamically update TAR" José Roberto de Souza (1): i2c: designware: wait for disable/enable only if necessary Lucas De Marchi (3): i2c: designware: add common functions for locking i2c: designw

[PATCH v4 4/4] i2c: designware: do not disable adapter after transfer

2016-08-23 Thread Lucas De Marchi
s. Alternating register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De

[PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

2016-08-23 Thread Lucas De Marchi
conds time elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/

[PATCH v4 3/4] i2c: designware: detect when dynamic tar update is possible

2016-08-23 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/i2c/busses/i2c-designware-core.c | 44 drivers/i2c/busses/i2c

[PATCH v4 2/4] i2c: designware: add common functions for locking

2016-08-23 Thread Lucas De Marchi
These are used in 2 places and will be needed in more. Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c

[PATCH v3 3/3] i2c: designware: do not disable adapter after transfer

2016-07-28 Thread Lucas De Marchi
s. Alternating register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De

[PATCH v3 0/3] i2c: designware: improve performance for transfers

2016-07-28 Thread Lucas De Marchi
a (1): i2c: designware: wait for disable/enable only if necessary Lucas De Marchi (2): i2c: designware: detect when dynamic tar update is possible i2c: designware: do not disable adapter after transfer drivers/i2c/busses/i2c-designware-core.c | 103 +-- drivers/i2

[PATCH v3 1/3] i2c: designware: wait for disable/enable only if necessary

2016-07-28 Thread Lucas De Marchi
conds time elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/

[PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

2016-07-28 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/i2c/busses/i2c-designware-core.c | 37 ++-- drivers/i2c/busses/i2c

[ANNOUNCE] kmod 23

2016-07-19 Thread Lucas De Marchi
below Anton Blanchard (1): depmod: Ignore PowerPC64 ABIv2 .TOC. symbol Héctor Orón Martínez (1): kmod: compiling with old sed version (!ERE support) Josh Triplett (1): depmod: Don't insert comment in modules.devname if otherwise empty Lucas De Marchi (8): travis: worka

Re: [PATCH] modprobe: install default configuration

2016-06-14 Thread Lucas De Marchi
CC'ing lkml and Rusty to get opinions on this. On Sat, Apr 23, 2016 at 3:18 PM, Lubomir Rintel wrote: > On Wed, 2016-04-13 at 01:11 -0300, Lucas De Marchi wrote: >> On Tue, Mar 29, 2016 at 7:27 AM, Lubomir Rintel >> wrote: >> > >> > On Fri, 2016-03-04

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-04 Thread Lucas De Marchi
Hi Christian, On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert wrote: > Dear Lucas, > > On 22.04.2016 17:19, Lucas De Marchi wrote: >> CC'ing Christian. >> >> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi >> wrote: >>> Disabling the adapter af

Re: [RFT PATCH] iio: magn: Add support for BMM150 magnetometer

2016-04-27 Thread Lucas De Marchi
f it works for you. I don't have yet the BMM150 evaluation > board. It should be available in few weeks. > > I'll just leave this patch here in case anyone steps in to test it. It will take a while for my test board to arrive here, so expect delay on testing this. thanks Lucas De Marchi

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Lucas De Marchi
h bit 5 checked and send an update. Lucas De Marchi

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
CC'ing Christian. On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi wrote: > Disabling the adapter after each transfer is pretty bad for sensors and > other devices doing small transfers at a high rate. It slows down the > transfer rate a lot since each of them have to wait the

[PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
0us After: i2c-transfer-time -w -a 0x40 -x 6 -n 2 -- 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 num_transfers=2 transfer_time_avg=470.256050us Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 48 ---

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

2016-04-18 Thread Lucas De Marchi
t a package of LSM303D and L3GD20 that could reuse the drivers already present? Lucas De Marchi

[PATCH] i2c: designware: do not disable adapter after transfer

2016-03-31 Thread Lucas De Marchi
From: Lucas De Marchi Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. It was done in order to avoid the adapter to

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Lucas De Marchi
of the patch. I remember it being fixed in the last version (or at least I could not reproduce). I'll test again tomorrow with your script. Lucas De Marchi

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Lucas De Marchi
nother id? Other than that, I tested it on the MinnowBoard Max with a Drone Lure connected and it works fine. thanks Lucas De Marchi

Re: Duplicated module names

2016-01-29 Thread Lucas De Marchi
Hi! On Fri, Jan 29, 2016 at 3:54 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module,

Re: modinfo crc32 broken after fd44a98ae2eb

2016-01-28 Thread Lucas De Marchi
Hi! CC'ing Rusty and mailing lists On Thu, Jan 28, 2016 at 8:40 PM, Samson Yeung wrote: > > On 01/28/2016 11:21 AM, Lucas De Marchi wrote: >> >> Hi Samson, >> >> On Wed, Jan 27, 2016 at 5:32 PM, Samson Yeung >> wrote: >>> >>> Hi

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

2016-01-26 Thread Lucas De Marchi
ODULE_DEVICE_TABLE(i2c, ads1015_id); > + > +static struct i2c_driver ads1015_driver = { > + .driver = { > + .name = ADS1015_DRV_NAME, same here, otherwise we will have an i2c:ads1015 alias Lucas De Marchi

[ANNOUNCE] kmod 22

2015-11-17 Thread Lucas De Marchi
ython requirements modprobe: Update error message when path is missing Change default log level depmod: Remove unprinted debug messages depmod: Don't fall back to uname on bad version Lucas De Marchi (4): Add README.md file with build details libkmod-module: fix retu

Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access

2015-10-30 Thread Lucas De Marchi
s 78e1c89 pinctrl: baytrail: Use raw_spinlock for locking The ones to Cherryview could be sent too but I couldn't test them. Leaving the patch below for reference. thanks Lucas De Marchi > drivers/pinctrl/intel/pinctrl-baytrail.c | 21 - > 1 file changed, 16 insert

Re: [PATCH] spi: Force the registration of the spidev devices

2015-07-14 Thread Lucas De Marchi
buses created more than 20+ years ago. (Unfortunately) They are still used today for all kind of sensors. Boards like RPi, beaglebone, minnowboard expose the pins so we can actually talk to those sensors, plugging in anyone we'd like to. For some of them for example there are IIO drivers

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-23 Thread Lucas De Marchi
On Tue, Jun 23, 2015 at 1:45 PM, wrote: > Hello, > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16: >> Mika Westerberg wrote on 10.06. >> 2015 09:07:22: >> > On Tue, Jun 09, 2015 at 03:29:01PM -0300, Lucas De Marchi wrote: >> > > Hi Mika,

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-12 Thread Lucas De Marchi
f (!i_dev->pm_runtime_disabled) >> - i2c_dw_init(i_dev); >> + i2c_dw_enable(i_dev); > > This will not work if the device power gets removed (for example being > put to D3cold) as it looses context. Do you mean we should keep the i2c_dw_init() here?

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-11 Thread Lucas De Marchi
k with older versions of the > hardware? Mika, do you have any memories about this? I'm not sure if it's a hw bug or if it's just an oversight from previous versions of this driver. So adding a quirk with correct versions will be difficult IMO. We've been only testing this wi

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-09 Thread Lucas De Marchi
controller keeps its state >> between disable/enable. Change the target address is also allowed. >> >> So, this patch replaces the initialization on module resume with a >> simple enable, and removes the (non required anymore) enables and >> disables. >> &

[ANNOUNCE] kmod 21

2015-06-08 Thread Lucas De Marchi
used by "make check". No changes to the tests are needed and all of them can run fine. Shortlog: Lucas De Marchi (12): build: use dolt build: sync dolt with upstream util: use UINT64_MAX build: cache modules from playground tools: Hide

Re: [PATCH kmod 3/3] tools: display features together with version information

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:17 AM, Andreas Mohr wrote: > Hi, > > On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.mar...@gmail.com wrote: >> From: Lucas De Marchi >> diff --git a/tools/kmod.c b/tools/kmod.c >> index c9d2cc8..28217df 100644 >> --- a/tools/kmod.c &

Re: [PATCH kmod 0/3] Add feature list together with version

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:25 AM, Andreas Mohr wrote: > Hi, > > On Sun, Jun 07, 2015 at 03:27:26AM -0300, lucas.de.mar...@gmail.com wrote: >> From: Lucas De Marchi >> >> Sample output: >> >> $ ./tools/kmod --version >> kmod version 20 >> +XZ +

[PATCH] i2c: designware: use enable on resume instead initialization

2015-06-08 Thread lucas . de . marchi
removes the (non required anymore) enables and disables. Signed-off-by: Fabio Mello Signed-off-by: Lucas De Marchi --- These pictures explain a little more the consequence of letting the enable+disable in the code: http://pub.politreco.com/paste/TEK0011-before.jpg http

[PATCH kmod 0/3] Add feature list together with version

2015-06-06 Thread lucas . de . marchi
From: Lucas De Marchi Sample output: $ ./tools/kmod --version kmod version 20 +XZ +ZLIB -EXPERIMENTAL Lucas De Marchi (3): build: add function to build string of features build: add relevant features to KMOD_FEATURES in config.h tools: display features together with version information

[PATCH kmod 2/3] build: add relevant features to KMOD_FEATURES in config.h

2015-06-06 Thread lucas . de . marchi
From: Lucas De Marchi Not all the features (i.e. those available in --enable-* or --with-*) are really relevant to the final user. Create a KMOD_FEATURES definition in config.h containing these features. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b

[PATCH kmod 1/3] build: add function to build string of features

2015-06-06 Thread lucas . de . marchi
From: Lucas De Marchi Add a CC_FEATURE_APPEND function that we can use to append the features that are enabled/disabled. This will generate a single string in the form "+FEATURE1 +FEATURE2 -FEATURE3". --- m4/features.m4 | 48 1 file c

[PATCH kmod 3/3] tools: display features together with version information

2015-06-06 Thread lucas . de . marchi
From: Lucas De Marchi --- tools/depmod.c | 1 + tools/insmod.c | 1 + tools/kmod.c | 1 + tools/modinfo.c | 1 + tools/modprobe.c | 1 + tools/rmmod.c| 1 + 6 files changed, 6 insertions(+) diff --git a/tools/depmod.c b/tools/depmod.c index 231b9ab..2a08b6e 100644 --- a/tools

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-06 Thread Lucas De Marchi
On Thu, Jun 4, 2015 at 5:22 PM, Rusty Russell wrote: > Lucas De Marchi writes: >>> + gzip and xz (but doesn't by default, at least as of version 18!). >> >> This is pretty much misleading. There's no such a default option. It's >> like sayin

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Lucas De Marchi
On Wed, Jun 3, 2015 at 10:30 PM, Rusty Russell wrote: > Lucas De Marchi writes: >> On Mon, Jun 1, 2015 at 3:26 AM, Rusty Russell wrote: >>> Andreas Mohr writes: >>>> Hi, >>>> >>>> I just had a not so nice experience >>>> when f

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Lucas De Marchi
On Wed, Jun 3, 2015 at 2:36 PM, Kay Sievers wrote: > On Wed, Jun 3, 2015 at 7:30 PM, Lucas De Marchi > wrote: >> On Mon, Jun 1, 2015 at 3:26 AM, Rusty Russell wrote: >>> Andreas Mohr writes: >>>> Hi, >>>> >>>> I just had a not so nic

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Lucas De Marchi
uired > in the help text though. kmod supports gz since the first version and xz since version 3. So both of them can be safely fall into "it's supported since the beginning of kmod IMO". Regarding the "default configuration", there's no such thing. Each distribut

Re: modules out of tree issue

2015-04-16 Thread Lucas De Marchi
f. I compile out-of-tree modules just fine. See https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/tree/testsuite/module-playground/Makefile for an example. > Any ideas? > > I'm not sure is this the right group, sorry. You probably should CC lkml as well. Doing it now. -- L

Re: How to get instance for kallsyms_address or kallsyms_num_syms?

2015-04-09 Thread Lucas De Marchi
Hi Buddy, This question is more for lkml than linux-modules. I'm CC'ing it. -- Lucas De Marchi On Tue, Apr 7, 2015 at 6:48 AM, Buddy wrote: > HI: > I want to get information for kernel symbol,so I use array of > kallsyms_address > and value of kallsyms_num_syms.But w

[PATCH] kdbus: fix header guard name

2015-03-17 Thread lucas . de . marchi
From: Lucas De Marchi UAPI headers have a _UAPI_ as prefix, which is removed during headers_install. If it's put as a suffix it will not be removed and will be the only header with UAPI in the header guard macro. Signed-off-by: Lucas De Marchi Reviewed-by: David Herrmann --- include

[PATCH] kdbus: fix header guard name

2015-03-16 Thread lucas . de . marchi
From: Lucas De Marchi UAPI headers have a _UAPI_ as prefix, which is removed during headers_install. If it's put as a suffix it will not be removed and will be the only header with UAPI in the header guard macro. Signed-off-by: Lucas De Marchi --- include/uapi/linux/kdbus.h | 4 ++-- 1

Re: [PATCH] checkpatch: Add optional --codespell dictionary to find more typos

2015-03-05 Thread Lucas De Marchi
is codespell dictionary I'm not a perl guru, but couldn't we have a single option like --codespell / --codespell=FILE ? Other than that, Acked-By: Lucas De Marchi -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: timerfd waking up before timer really expires

2015-03-04 Thread Lucas De Marchi
On Wed, Mar 4, 2015 at 5:06 AM, Clemens Ladisch wrote: > Lucas De Marchi wrote: >> I was debugging my application and noticed that a timerfd event was being >> triggered *before* the timer expires. >> >> I reduced the scope of the program to test a single timerfd and m

timerfd waking up before timer really expires

2015-03-03 Thread Lucas De Marchi
e elapsed values shorter than the configured interval. Tracing for wakeup events with ftrace[1] I also get the same results... the time difference between 2 wakeup events for ~30% of events are shorter the configured interval. I'm currently running with kernel version 3.18.6. Is there anythin

[ANNOUNCE] kmod 20

2015-03-01 Thread Lucas De Marchi
ld: make sure to test for -Wflag instead of -Wno-flag Harish Jenny K N (1): Fix race while loading modules Lucas De Marchi (78): NEWS: Fix typos README: move mailing list information to top build-sys: Don't add libkmod subdirectory to include path build-sys: Don'

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-28 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 12:35 PM, Harish Jenny Kandiga Nagaraj wrote: > > On Thursday 19 February 2015 07:32 PM, Harish Jenny Kandiga Nagaraj wrote: >> On Thursday 19 February 2015 06:13 PM, Lucas De Marchi wrote: >>> On Thu, Feb 19, 2015 at 10:32 AM, Harish Jenny Kandiga Na

Re: Differences between builtins and modules

2015-02-28 Thread Lucas De Marchi
On Wed, Feb 25, 2015 at 8:53 AM, Michal Marek wrote: > On Tue, Feb 24, 2015 at 10:02:55PM -0300, Lucas De Marchi wrote: >> On Mon, Feb 23, 2015 at 12:51 PM, Michal Marek wrote: >> > On 2015-02-23 15:30, Lucas De Marchi wrote: >> >> My questions are: >> >&g

Re: Differences between builtins and modules

2015-02-24 Thread Lucas De Marchi
On Tue, Feb 24, 2015 at 8:42 AM, Harish Jenny Kandiga Nagaraj wrote: > > On Monday 23 February 2015 09:21 PM, Michal Marek wrote: >> On 2015-02-23 15:30, Lucas De Marchi wrote: > Can we add some flag like > KMOD_PROBE_FORCE_DIRECTORY_CHECK = 0x00040, > and pass it to kmod_mo

Re: Differences between builtins and modules

2015-02-24 Thread Lucas De Marchi
On Mon, Feb 23, 2015 at 12:51 PM, Michal Marek wrote: > On 2015-02-23 15:30, Lucas De Marchi wrote: >> This could be particularly bad if in a kernel version an option was >> tristate and in a new version it changed to boolean. I'm not sure if >> this is common to happe

Differences between builtins and modules

2015-02-23 Thread Lucas De Marchi
ules" in the builtin index? 2) should we actually check /sys/module/ to report a module as builtin or just stop doing that and rely solely in the index? Initially I'd like to do the opposite, but given the race in deciding this I'm favoring the index. thanks -- Lucas De Marchi --

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-19 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 10:32 AM, Harish Jenny Kandiga Nagaraj wrote: > > On Thursday 19 February 2015 04:00 PM, Lucas De Marchi wrote: >> On Thu, Feb 19, 2015 at 3:49 AM, Harish Jenny Kandiga Nagaraj >> wrote: >>>> Harrish, in your patch if you just change the &q

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-19 Thread Lucas De Marchi
add the necessary checks for the builtin index. Otherwise I can take a look on this until the end of this week. -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 12:25 AM, greg KH wrote: > On Wed, Feb 18, 2015 at 11:19:14PM -0200, Lucas De Marchi wrote: >> On Wed, Feb 18, 2015 at 8:40 PM, Rusty Russell wrote: >> > Lucas De Marchi writes: >> >> On Wed, Feb 18, 2015 at 2:07 AM, Rusty Russell &

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 12:25 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> On Wed, Feb 18, 2015 at 8:40 PM, Rusty Russell wrote: >>> Lucas De Marchi writes: >>>> On Wed, Feb 18, 2015 at 2:07 AM, Rusty Russell >>>> wrote: >>>> Yea

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Wed, Feb 18, 2015 at 8:40 PM, Rusty Russell wrote: > Lucas De Marchi writes: >> On Wed, Feb 18, 2015 at 2:07 AM, Rusty Russell wrote: >> Yeah, I just thought (an wanted that) the attributes were being >> created first and then hooked up in the sysfs tree under >>

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Wed, Feb 18, 2015 at 2:07 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> On Tue, Feb 17, 2015 at 10:56 AM, Harish Jenny K N >> wrote: >>> usecase: two sd cards are being mounted in parallel at same time on >>> dual core. example modules which are getti

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-17 Thread Lucas De Marchi
usty, was there any changes in this area in the kernel recently? Or is the creation of /sys/module/ and /sys/module//initstate not atomic? See patch below. -- Lucas De Marchi > > Experiments done to prove the issue in kmod. > Added sleep in kernel module.c at the place of creatio

[ANNOUNCE] kmod 19

2014-11-16 Thread Lucas De Marchi
7;s less boilerplate code for each test. Shortlog is below: Cristian Rodríguez (1): Add missing O_CLOEXEC in kmod_module_get_size() Holger Obermaier (1): libkmod-index.c: Fix error message Lucas De Marchi (35): Update TODO Move macro.h to shared directory

Re: [PATCH 0/3] Implement /proc/built-in file similar to /proc/modules

2014-09-16 Thread Lucas De Marchi
e nodes are created by init even if the module itself is not loaded. The right module will be loaded when the node is first accessed. And that includes the "loop" module you mention. $ kmod static-nodes | grep -A3 loop Module: loop Device node: /dev/loop-control Ty

Re: [RFC PATCH 0/2] kmod: Support lockup option to make module un-removable

2014-09-01 Thread Lucas De Marchi
ed up :) > > Anyway, this is not needed if the lockup option is dropped > from the series. I send this for testing. Ok. I'm not sure it's clear... I'm waiting for feedback on the kernel patches in order to proceed with any review here. I'm not really convinced we want this

Re: [RFC PATCH 4/5] module: Lock up a module when loading with a LOCLUP flag

2014-08-25 Thread Lucas De Marchi
since I'm CC'ing linux-modules. -- Lucas De Marchi > > Signed-off-by: Masami Hiramatsu > --- > include/linux/module.h |6 ++ > include/uapi/linux/module.h |1 + > kernel/module.c | 28 > 3 files chang

[ANNOUNCE] kmod 18

2014-06-14 Thread Lucas De Marchi
fails. Close /sys/module/$NAME directory if opening /proc/module fails. Lucas De Marchi (17): Update .travis.yml Add strndupa to missing.h Make sure there's NUL byte at the end of strndupa testsuite: Add module playground dir Add gitignore to module playground de

Re: [PATCH] module: remove warning about waiting module removal.

2014-04-24 Thread Lucas De Marchi
you think it'd be still good to patch kmod on distros, so at least modprobe -r uses O_NONBLOCK? Or having this patch in kernel is sufficient? -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] fix printk output

2014-04-23 Thread Lucas De Marchi
ht thing. > > In fact, kmod's modprobe *never* used the O_NONBLOCK > (ie. KMOD_REMOVE_NOWAIT) flag, until it was finally enforced in > > commit 7ab8804448377fb6b8854f2dd288608db01bb43b > Author: Lucas De Marchi > Date: Fri Sep 20 01:30:07 201

  1   2   >