On 2020/12/11 4:46, Saeed Mahameed wrote:
On Thu, 2020-12-10 at 20:24 +0800, tanhuazhong wrote:
On 2020/12/10 13:40, Saeed Mahameed wrote:
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
From: Jian Shen
For some new device, it supports forwarding packet to queues
of specified TC
On 2020/12/11 4:24, Saeed Mahameed wrote:
On Thu, 2020-12-10 at 20:27 +0800, tanhuazhong wrote:
On 2020/12/10 12:50, Saeed Mahameed wrote:
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
From: Jian Shen
Currently, the HNS3 driver only supports offload for tc number
and prio_tc
On 2020/12/10 12:50, Saeed Mahameed wrote:
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
From: Jian Shen
Currently, the HNS3 driver only supports offload for tc number
and prio_tc. This patch adds support for other qopts, including
queues count and offset for each tc.
When enable
On 2020/12/10 13:40, Saeed Mahameed wrote:
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
From: Jian Shen
For some new device, it supports forwarding packet to queues
of specified TC when flow director rule hit. So extend the
command handle to support it.
...
static int
On 2020/12/5 10:22, Jakub Kicinski wrote:
On Thu, 3 Dec 2020 20:18:56 +0800 Huazhong Tan wrote:
tranmist
Please spell check the commit messages and comments.
will fix spelling mistakes, thanks
.
On 2020/12/5 10:24, Jakub Kicinski wrote:
On Thu, 3 Dec 2020 20:18:55 +0800 Huazhong Tan wrote:
@@ -224,6 +224,7 @@ static int hclge_map_unmap_ring_to_vf_vector(struct
hclge_vport *vport, bool en,
static int hclge_set_vf_promisc_mode(struct hclge_vport *vport,
On 2020/11/28 4:52, Jakub Kicinski wrote:
On Fri, 27 Nov 2020 16:47:16 +0800 Huazhong Tan wrote:
In some cases (for example ip fragment), hardware will
calculate the checksum of whole packet in RX, and setup
the HNS3_RXD_L2_CSUM_B flag in the descriptor, so add
support to utilize this
On 2020/11/28 4:53, Jakub Kicinski wrote:
On Fri, 27 Nov 2020 16:47:20 +0800 Huazhong Tan wrote:
Since TX hardware checksum and RX completion checksum have been
supported now, so add related information in hns3_dbg_bd_info().
Signed-off-by: Huazhong Tan
On 2020/11/20 23:25, Andrew Lunn wrote:
@@ -310,6 +334,13 @@ int ethnl_set_coalesce(struct sk_buff *skb, struct
genl_info *info)
ret = dev->ethtool_ops->set_coalesce(dev, );
if (ret < 0)
goto out_ops;
+
+ if (ops->set_ext_coalesce) {
+ ret
On 2020/11/21 5:22, Michal Kubecek wrote:
On Fri, Nov 20, 2020 at 02:39:38PM +0100, Andrew Lunn wrote:
On Fri, Nov 20, 2020 at 08:23:22AM +0100, Michal Kubecek wrote:
On Fri, Nov 20, 2020 at 10:59:59AM +0800, tanhuazhong wrote:
On 2020/11/20 6:02, Michal Kubecek wrote:
We could use
On 2020/11/20 6:02, Michal Kubecek wrote:
On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote:
On 2020/11/19 12:15, Andrew Lunn wrote:
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 9ca87bc..afd8de2 100644
--- a/include/uapi/linux/ethtool.h
+++ b
On 2020/11/20 6:02, Michal Kubecek wrote:
On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote:
On 2020/11/19 12:15, Andrew Lunn wrote:
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 9ca87bc..afd8de2 100644
--- a/include/uapi/linux/ethtool.h
+++ b
On 2020/11/19 12:15, Andrew Lunn wrote:
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 9ca87bc..afd8de2 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -433,6 +433,7 @@ struct ethtool_modinfo {
*a TX interrupt, when the
On 2020/11/15 2:54, Jakub Kicinski wrote:
On Thu, 12 Nov 2020 11:33:14 +0800 Huazhong Tan wrote:
Add a control private flag in ethtool for enable/disable
DIM feature.
Signed-off-by: Huazhong Tan
Please work on a common ethtool API for the configuration instead of
using private flags.
On 2020/11/12 0:15, Jakub Kicinski wrote:
On Wed, 11 Nov 2020 11:16:37 +0800 tanhuazhong wrote:
On 2020/11/11 9:28, Jakub Kicinski wrote:
On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote:
Since user may need to check the current configuration of the
interrupt coalesce, so add debugfs
On 2020/11/11 9:28, Jakub Kicinski wrote:
On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote:
Since user may need to check the current configuration of the
interrupt coalesce, so add debugfs support for query this info,
which includes DIM profile, coalesce configuration of both software
On 2020/11/11 9:25, Jakub Kicinski wrote:
On Mon, 9 Nov 2020 11:22:37 +0800 Huazhong Tan wrote:
For device whose version is above V3(include V3), the GL can
select EQ or CQ mode, so adds support for it.
In CQ mode, the coalesced timer will restart upon new completion,
while in EQ mode, the
On 2020/11/11 9:20, Jakub Kicinski wrote:
On Mon, 9 Nov 2020 11:22:33 +0800 Huazhong Tan wrote:
Add dynamic interrupt moderation support for the HNS3 driver.
Signed-off-by: Huazhong Tan
I'm slightly confused here. What does the adaptive moderation do in
your driver/device if you still
On 2020/11/11 9:13, Jakub Kicinski wrote:
On Mon, 9 Nov 2020 11:22:29 +0800 Huazhong Tan wrote:
+ if (rx_vector->tx_group.coal.ql_enable)
Is this supposed to be rx_group, not tx?
yes, will fix it.
thanks.
+
On 2020/11/8 1:47, Jakub Kicinski wrote:
On Sat, 7 Nov 2020 14:31:20 +0800 Huazhong Tan wrote:
+static void hns3_update_cqe_mode(struct net_device *netdev, bool enable, bool
is_tx)
Wrap this to 80 characters, please.
Will fix it.
Thanks
.
On 2020/11/8 1:46, Jakub Kicinski wrote:
On Sat, 7 Nov 2020 14:31:12 +0800 Huazhong Tan wrote:
For device whose version is above V3(include V3), the GL
configuration can set as 1us unit, so adds support for
configuring this field.
Signed-off-by: Huazhong Tan
Doesn't build.
On 2020/9/7 23:35, Willem de Bruijn wrote:
On Mon, Sep 7, 2020 at 3:38 PM tanhuazhong wrote:
On 2020/9/7 17:22, Willem de Bruijn wrote:
On Sun, Sep 6, 2020 at 8:42 PM Jakub Kicinski wrote:
On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote:
There are two updates relates to UDP GSO
On 2020/9/7 17:22, Willem de Bruijn wrote:
On Sun, Sep 6, 2020 at 8:42 PM Jakub Kicinski wrote:
On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote:
There are two updates relates to UDP GSO.
#1 adds a new GSO type for UDPv6
#2 adds check for UDP GSO when csum is disable in
On 2020/9/3 6:43, David Miller wrote:
From: Huazhong Tan
Date: Wed, 2 Sep 2020 20:15:11 +0800
In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled
separately, for example, checksum offload, so add new GSO type
SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands
for
On 2020/9/2 22:33, Willem de Bruijn wrote:
On Wed, Sep 2, 2020 at 2:18 PM Huazhong Tan wrote:
In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled
separately, for example, checksum offload, so add new GSO type
SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands
for
On 2020/5/29 2:42, Markus Elfring wrote:
Add a mutex destroy call in hclge_init_ae_dev() when fails.
How do you think about a wording variant like the following?
Change description:
The function “mutex_init” was called before a call of
the function “hclge_pci_init”.
But the
Sorry, please ignore this patchset, will resend it later.
On 2020/5/28 20:45, Huazhong Tan wrote:
This patchset includes some updates for the HNS3 ethernet driver.
#1 adds a missing mutex destroy.
#2&3 refactor two function, make them more readable and maintainable.
#4&5 fix unsuitable type of
On 2020/5/22 17:35, tanhuazhong wrote:
On 2020/5/22 5:37, David Miller wrote:
From: Jakub Kicinski
Date: Thu, 21 May 2020 12:17:07 -0700
On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote:
This patchset adds two new VLAN feature.
[patch 1] adds a new dynamic VLAN mode.
[patch 2
On 2020/5/23 1:39, Jakub Kicinski wrote:
On Fri, 22 May 2020 10:49:42 +0800 Huazhong Tan wrote:
From: Guangbin Huang
This patch adds support for VF to query the mapping of ring and
vector.
Signed-off-by: Guangbin Huang
Signed-off-by: Huazhong Tan
Hi, Jakub.
Could you explain a
On 2020/5/22 5:37, David Miller wrote:
From: Jakub Kicinski
Date: Thu, 21 May 2020 12:17:07 -0700
On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote:
This patchset adds two new VLAN feature.
[patch 1] adds a new dynamic VLAN mode.
[patch 2] adds support for 'QoS' field to PVID.
On 2020/5/21 9:36, Jakub Kicinski wrote:
On Thu, 21 May 2020 09:33:14 +0800 tanhuazhong wrote:
On 2020/5/21 5:06, Jakub Kicinski wrote:
On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote:
From: GuoJia Liao
There is a scenario which needs vNICs enable the VLAN filter
in access port
On 2020/5/21 5:06, Jakub Kicinski wrote:
On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote:
From: GuoJia Liao
There is a scenario which needs vNICs enable the VLAN filter
in access port, while disable the VLAN filter in trunk port.
Access port and trunk port can switch according to the
On 2020/5/13 21:12, Andrew Lunn wrote:
On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote:
From: Yufeng Mo
PHY loopback is already supported by genphy driver. This patch
adds the set_loopback interface to RTL8211F PHY driver, so the PHY
selftest can run properly on it.
On 2020/5/13 21:12, Andrew Lunn wrote:
On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote:
From: Yufeng Mo
PHY loopback is already supported by genphy driver. This patch
adds the set_loopback interface to RTL8211F PHY driver, so the PHY
selftest can run properly on it.
On 2020/5/10 4:48, Jakub Kicinski wrote:
On Sat, 9 May 2020 17:27:39 +0800 Huazhong Tan wrote:
This patch provides a new interface for the client to query
whether CMDQ is ready to work.
Signed-off-by: Huazhong Tan
diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
On 2020/4/29 2:49, Jakub Kicinski wrote:
On Tue, 28 Apr 2020 19:58:25 +0800 Huazhong Tan wrote:
From: Yonglong Liu
This patch adds support for reading the optical module eeprom
info via "ethtool -m".
Signed-off-by: Yonglong Liu
Signed-off-by: Huazhong Tan
diff --git
On 2019/10/17 23:47, Jakub Kicinski wrote:
On Thu, 17 Oct 2019 11:27:09 +0800, tanhuazhong wrote:
On 2019/10/17 1:50, David Miller wrote:
From: Jakub Kicinski
Date: Wed, 16 Oct 2019 10:19:43 -0700
On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
This patch-set includes some
On 2019/10/17 1:50, David Miller wrote:
From: Jakub Kicinski
Date: Wed, 16 Oct 2019 10:19:43 -0700
On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
This patch-set includes some bugfixes and code optimizations
for the HNS3 ethernet controller driver.
The code LGTM, mostly, but it
On 2019/10/17 1:50, David Miller wrote:
From: Jakub Kicinski
Date: Wed, 16 Oct 2019 10:19:43 -0700
On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
This patch-set includes some bugfixes and code optimizations
for the HNS3 ethernet controller driver.
The code LGTM, mostly, but it
On 2019/10/17 1:19, Jakub Kicinski wrote:
On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
This patch-set includes some bugfixes and code optimizations
for the HNS3 ethernet controller driver.
The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
should be a separate
On 2019/10/17 1:18, Jakub Kicinski wrote:
On Wed, 16 Oct 2019 15:17:10 +0800, Huazhong Tan wrote:
From: Yunsheng Lin
Currently, napi_alloc_skb() is used to allocate skb for fraglist
when the head skb is not enough to hold the remaining data, and
the remaining data is added to the frags
On 2019/10/17 1:10, Jakub Kicinski wrote:
On Wed, 16 Oct 2019 15:17:07 +0800, Huazhong Tan wrote:
From: Yunsheng Lin
There are a few places that need to access the netdev of a ring
through ring->tqp->handle->kinfo.netdev, and ring->tqp is a struct
which both in enet and hclge modules, it
Hi, Michal
On 2019/9/12 14:23, Michal Kubecek wrote:
On Wed, Sep 11, 2019 at 10:40:33AM +0800, Huazhong Tan wrote:
From: Guangbin Huang
This patch adds ethtool_ops.set_channels support for HNS3 VF driver,
and updates related TQP information and RSS information, to support
modification of VF
On 2019/9/11 18:16, Sergei Shtylyov wrote:
Hello!
On 11.09.2019 5:40, Huazhong Tan wrote:
From: Guangbin Huang
For hardware doesn't support use specified speed and duplex
Can't pasre that. "For hardware that does not support using", perhaps?
Yes, thanks. Will check the grammar
On 2019/9/11 1:25, David Miller wrote:
From: Huazhong Tan
Date: Tue, 10 Sep 2019 16:58:22 +0800
+ /* Set to user value, no larger than max_rss_size. */
+ if (kinfo->req_rss_size != kinfo->rss_size && kinfo->req_rss_size &&
+ kinfo->req_rss_size <= max_rss_size) {
+
On 2019/9/5 18:12, Sergei Shtylyov wrote:
On 04.09.2019 17:06, Huazhong Tan wrote:
From: Peng Li
HNS3 driver can only unregister client which included in
hnae3_client_list.
This patch adds the client node validity judgment.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
On 2019/7/28 10:03, David Miller wrote:
From: Huazhong Tan
Date: Sat, 27 Jul 2019 13:46:08 +0800
From: Yonglong Liu
Some times just see the eth interface have been down/up via
dmesg, but can not know why the eth down. So adds some debug
messages to identify the cause for this.
Sorry, please ignore this patchset. Will resend it later:)
On 2019/7/26 11:24, Huazhong Tan wrote:
This patch-set includes code optimizations, bugfixes and features for
the HNS3 ethernet controller driver.
[patch 1/11] checks reset status before setting channel.
[patch 2/11] adds a NULL
On 2019/7/26 5:32, Saeed Mahameed wrote:
On Thu, 2019-07-25 at 10:34 +0800, tanhuazhong wrote:
On 2019/7/25 2:34, Saeed Mahameed wrote:
On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote:
From: Yufeng Mo
This patch modifies firmware version display format in
hclge(vf)_cmd_init
On 2019/7/25 2:34, Saeed Mahameed wrote:
On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote:
From: Yufeng Mo
This patch modifies firmware version display format in
hclge(vf)_cmd_init() and hns3_get_drvinfo(). Also, adds
some optimizations for firmware version display format.
On 2019/7/25 2:28, Saeed Mahameed wrote:
On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote:
From: Yonglong Liu
The num_msi_left means the vector numbers of NIC, but if the
PF supported RoCE, it contains the vector numbers of NIC and
RoCE(Not expected).
This may cause interrupts lost
On 2019/6/26 23:59, David Miller wrote:
From: tanhuazhong
Date: Wed, 26 Jun 2019 15:44:05 +0800
Hi, david, has this patchset merged into net-next, why I cannot see it
after pulling net-next? Or is there some problem about this patchset I
have missed?
Sorry, I forgot to push it out from
On 2019/6/22 21:53, David Miller wrote:
From: Huazhong Tan
Date: Thu, 20 Jun 2019 16:52:34 +0800
This patch-set includes code optimizations and bugfixes for
the HNS3 ethernet controller driver.
[patch 1/11] fixes a selftest issue when doing autoneg.
[patch 2/11 - 3-11] adds two code
On 2019/6/7 1:36, David Miller wrote:
From: Huazhong Tan
Date: Thu, 6 Jun 2019 16:20:56 +0800
+static int hclge_log_rocee_axi_error(struct hclge_dev *hdev)
+{
...
+ ret = hclge_cmd_send(>hw, [0], 3);
+ if (ret) {
+ dev_err(dev, "failed(%d) to query ROCEE AXI
On 2019/6/1 8:18, David Miller wrote:
From: David Miller
Date: Fri, 31 May 2019 17:15:29 -0700 (PDT)
From: Huazhong Tan
Date: Fri, 31 May 2019 16:54:46 +0800
This patch-set includes code optimizations and bugfixes for the HNS3
ethernet controller driver.
[patch 1/12] removes the
Sorry, please ignore this patchset. I will send V2 to fix something else.
On 2019/4/24 11:21, Huazhong Tan wrote:
This patch-set includes code optimizations and bugfixes for the HNS3
ethernet controller driver.
[patch 1/12 - 3/12] fixes some bugs about the IO path
[patch 4/12 - 6/12] includes
On 2019/3/4 13:15, David Miller wrote:
From: Huazhong Tan
Date: Sat, 2 Mar 2019 16:49:30 +0800
From: Jian Shen
HW can not guarantee complete write desc->rx.size, even though
HNS3_RXD_VLD_B has been set. Driver needs to add rmb() instruction
to make sure desc->rx.size is always valid.
On 2019/2/27 10:23, Stephen Rothwell wrote:
Hi,
On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong wrote:
It is my mistake, so sorry about this. There is a redundant "net: hns3:
" in the fixes tag.
How could I fix it?
Since Dave doesn't rebase his tree, there is no
Hi Stephen & David,
It is my mistake, so sorry about this. There is a redundant "net: hns3:
" in the fixes tag.
How could I fix it?
Thanks.
On 2019/2/25 16:00, Stephen Rothwell wrote:
Hi all,
In commit
a638b1d8cc87 ("net: hns3: fix get VF RSS issue")
Fixes tag
Fixes: 374ad291762a
-Original Message-
From: Eric Dumazet [mailto:eric.duma...@gmail.com]
Sent: Wednesday, January 23, 2019 2:39 AM
To: tanhuazhong ; da...@davemloft.net
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; huangdaode
; Zhuangyuzeng (Yisen) ;
Salil Mehta ; Linuxarm ; shenjian
(K
60 matches
Mail list logo