Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

On Mon, Feb 8, 2021 at 1:55 PM Balbir Singh wrote: > > On Fri, Feb 05, 2021 at 10:43:02AM +0800, Weiping Zhang wrote: > > On Fri, Feb 5, 2021 at 8:08 AM Balbir Singh wrote: > > > > > > On Thu, Feb 04, 2021 at 10:37:20PM +0800, Weiping Zhang wrote: > > >

Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

On Fri, Feb 5, 2021 at 8:08 AM Balbir Singh wrote: > > On Thu, Feb 04, 2021 at 10:37:20PM +0800, Weiping Zhang wrote: > > On Thu, Feb 4, 2021 at 6:20 PM Balbir Singh wrote: > > > > > > On Sun, Jan 31, 2021 at 05:16:47PM +0800, Weiping Zhang wrote: > > > &

Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

On Thu, Feb 4, 2021 at 6:20 PM Balbir Singh wrote: > > On Sun, Jan 31, 2021 at 05:16:47PM +0800, Weiping Zhang wrote: > > On Wed, Jan 27, 2021 at 7:13 PM Balbir Singh wrote: > > > > > > On Fri, Jan 22, 2021 at 10:07:50PM +0800, Weiping Zhang wro

Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

On Wed, Jan 27, 2021 at 7:13 PM Balbir Singh wrote: > > On Fri, Jan 22, 2021 at 10:07:50PM +0800, Weiping Zhang wrote: > > Hello Balbir Singh, > > > > Could you help review this patch, thanks > > > > On Mon, Dec 28, 2020 at 10:10 PM Weiping Zhang wrote: >

Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

Hello Balbir Singh, Could you help review this patch, thanks On Mon, Dec 28, 2020 at 10:10 PM Weiping Zhang wrote: > > Hi David, > > Could you help review this patch ? > > thanks > > On Fri, Dec 18, 2020 at 1:24 AM Weiping Zhang > wrote: > > > > If a

Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

Hi David, Could you help review this patch ? thanks On Fri, Dec 18, 2020 at 1:24 AM Weiping Zhang wrote: > > If a program needs monitor lots of process's status, it needs two > syscalls for every process. The first one is telling kernel which > pid/tgid should be monitored by se

[RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

/taskstats to reduce two syscalls to one ioctl. The user just set the target pid/tgid to the struct taskstats.ac_pid, then kernel will collect statistics for that pid/tgid. Signed-off-by: Weiping Zhang --- Changes since v1: * use /proc/taskstats instead of /dev/taskstats include/uapi/linux

[PATCH] taskstats: add ioctl to fetch pid/tgid status

/taskstats to reduce two syscalls to one ioctl. The user just set the target pid/tgid to the struct taskstats.ac_pid, then kernel will collect statistics for that pid/tgid. Signed-off-by: Weiping Zhang --- kernel/taskstats.c | 71 +- 1 file changed, 70

Re: [RFC PATCH] proc: add support detach proccess's autogroup

On Thu, Jul 2, 2020 at 6:21 PM Weiping Zhang wrote: > > On Thu, Jul 2, 2020 at 4:18 PM Peter Zijlstra wrote: > > > > On Thu, Jul 02, 2020 at 01:20:43PM +0800, Weiping Zhang wrote: > > > Since setid will create a autogroup for that process, there is no > &g

Re: [RFC PATCH] proc: add support detach proccess's autogroup

On Thu, Jul 2, 2020 at 4:18 PM Peter Zijlstra wrote: > > On Thu, Jul 02, 2020 at 01:20:43PM +0800, Weiping Zhang wrote: > > Since setid will create a autogroup for that process, there is no > > way to detach a process from that autogroup, this patch add a new interface >

[RFC PATCH] proc: add support detach proccess's autogroup

Since setid will create a autogroup for that process, there is no way to detach a process from that autogroup, this patch add a new interface to detach a process from its autogroup. You can write anything to /proc//autogroup_detach to do that. Signed-off-by: Weiping Zhang --- fs/proc/base.c

[PATCH RFC] Documentation/scheduler/sched-stats.txt: correct jiffies to ns

The unit of run_daly and rq_cpu_time is ns instead of jiffies. Signed-off-by: Weiping Zhang --- Documentation/scheduler/sched-stats.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/scheduler/sched-stats.txt b/Documentation/scheduler/sched-stats.txt

[PATCH RFC] Documentation/scheduler/sched-stats.txt: correct jiffies to ns

The unit of run_daly and rq_cpu_time is ns instead of jiffies. Signed-off-by: Weiping Zhang --- Documentation/scheduler/sched-stats.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/scheduler/sched-stats.txt b/Documentation/scheduler/sched-stats.txt

[tip:perf/core] perf cgroup: Simplify arguments when tracking multiple events

Commit-ID: 25f72f9ed88d5be86c92432fc779e2725e3506cd Gitweb: https://git.kernel.org/tip/25f72f9ed88d5be86c92432fc779e2725e3506cd Author: weiping zhang <zhangweip...@didichuxing.com> AuthorDate: Mon, 29 Jan 2018 23:48:09 +0800 Committer: Arnaldo Carvalho de Melo <a...@r

[tip:perf/core] perf cgroup: Simplify arguments when tracking multiple events

Commit-ID: 25f72f9ed88d5be86c92432fc779e2725e3506cd Gitweb: https://git.kernel.org/tip/25f72f9ed88d5be86c92432fc779e2725e3506cd Author: weiping zhang AuthorDate: Mon, 29 Jan 2018 23:48:09 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 22 Feb 2018 10:02:27 -0300 perf cgroup

Re: [PATCH v2] perf cgroup: simplify arguments if track multiple events for a cgroup

2018-01-31 17:22 GMT+08:00 Jiri Olsa <jo...@redhat.com>: > On Mon, Jan 29, 2018 at 11:48:09PM +0800, weiping zhang wrote: >> if use -G with one cgroup and -e with multiple events, only the first >> event has correct cgroup setting, all events from the second will track

Re: [PATCH v2] perf cgroup: simplify arguments if track multiple events for a cgroup

2018-01-31 17:22 GMT+08:00 Jiri Olsa : > On Mon, Jan 29, 2018 at 11:48:09PM +0800, weiping zhang wrote: >> if use -G with one cgroup and -e with multiple events, only the first >> event has correct cgroup setting, all events from the second will track >> system-wide event

[PATCH v2] perf cgroup: simplify arguments if track multiple events for a cgroup

1.001007226 7,506 cache-misses after: 1.000834097cyclestest 1.000834097cache-misses test Signed-off-by: weiping zhang <zhangweip...@didichuxing.com> --- tools/perf/Documentation/perf-record.txt | 3 ++- tool

[PATCH v2] perf cgroup: simplify arguments if track multiple events for a cgroup

1.001007226 7,506 cache-misses after: 1.000834097cyclestest 1.000834097cache-misses test Signed-off-by: weiping zhang --- tools/perf/Documentation/perf-record.txt | 3 ++- tools/perf/Documentation/perf-stat.txt | 3

Re: [RFC PATCH] perf cgroup: simplify arguments if track multiple events for a cgroup

2018-01-29 18:39 GMT+08:00 Jiri Olsa <jo...@redhat.com>: > On Sun, Jan 28, 2018 at 01:31:48PM +0800, weiping zhang wrote: >> if use -G with one cgroup and -e with multiple events, only the first >> event has correct cgroup setting, all events from the second will track

Re: [RFC PATCH] perf cgroup: simplify arguments if track multiple events for a cgroup

2018-01-29 18:39 GMT+08:00 Jiri Olsa : > On Sun, Jan 28, 2018 at 01:31:48PM +0800, weiping zhang wrote: >> if use -G with one cgroup and -e with multiple events, only the first >> event has correct cgroup setting, all events from the second will track >> system-wide event

[RFC PATCH] perf cgroup: simplify arguments if track multiple events for a cgroup

1.001007226 7,506 cache-misses after: 1.000834097cyclestest 1.000834097cache-misses test Signed-off-by: weiping zhang <zhangweip...@didichuxing.com> --- tools/perf/util/cgroup.c | 17 -

[RFC PATCH] perf cgroup: simplify arguments if track multiple events for a cgroup

1.001007226 7,506 cache-misses after: 1.000834097cyclestest 1.000834097cache-misses test Signed-off-by: weiping zhang --- tools/perf/util/cgroup.c | 17 - 1 file changed, 16 insertions(+), 1

Re: [PATCH] perf cgroup: fix cgroup for multiple events

please discard this patch, may the right way to use cgroup with multiple events like following: perf stat -e cycles -e cache-misses -a -I 1000 -G test,test 2018-01-25 23:00 GMT+08:00 weiping zhang <zhangweip...@didichuxing.com>: > if use -G and with multiple events, only the first

Re: [PATCH] perf cgroup: fix cgroup for multiple events

please discard this patch, may the right way to use cgroup with multiple events like following: perf stat -e cycles -e cache-misses -a -I 1000 -G test,test 2018-01-25 23:00 GMT+08:00 weiping zhang : > if use -G and with multiple events, only the first event has > correct cgroup settin

[PATCH] perf cgroup: fix cgroup for multiple events

test 1.001007226 7,506 cache-misses after: 1.000834097cyclestest 1.000834097cache-misses test Signed-off-by: weiping zhang <zhangweip...@didichuxing.com> --- tools/perf/util/cgroup.c | 3 ++- 1 file chan

[PATCH] perf cgroup: fix cgroup for multiple events

test 1.001007226 7,506 cache-misses after: 1.000834097cyclestest 1.000834097cache-misses test Signed-off-by: weiping zhang --- tools/perf/util/cgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

On Fri, Dec 22, 2017 at 08:04:23AM -0600, Bruno Wolff III wrote: > On Fri, Dec 22, 2017 at 21:20:10 +0800, > weiping zhang <zwp10...@gmail.com> wrote: > >2017-12-22 12:53 GMT+08:00 Bruno Wolff III <br...@wolff.to>: > >>On Thu, Dec 21, 2017 at 17:16:03 -0600, >

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

On Fri, Dec 22, 2017 at 08:04:23AM -0600, Bruno Wolff III wrote: > On Fri, Dec 22, 2017 at 21:20:10 +0800, > weiping zhang wrote: > >2017-12-22 12:53 GMT+08:00 Bruno Wolff III : > >>On Thu, Dec 21, 2017 at 17:16:03 -0600, > >> Bruno Wolff III wrote: > >>

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

On Fri, Dec 22, 2017 at 08:04:23AM -0600, Bruno Wolff III wrote: > On Fri, Dec 22, 2017 at 21:20:10 +0800, > weiping zhang <zwp10...@gmail.com> wrote: > >2017-12-22 12:53 GMT+08:00 Bruno Wolff III <br...@wolff.to>: > >>On Thu, Dec 21, 2017 at 17:16:03 -0600, >

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

On Fri, Dec 22, 2017 at 08:04:23AM -0600, Bruno Wolff III wrote: > On Fri, Dec 22, 2017 at 21:20:10 +0800, > weiping zhang wrote: > >2017-12-22 12:53 GMT+08:00 Bruno Wolff III : > >>On Thu, Dec 21, 2017 at 17:16:03 -0600, > >> Bruno Wolff III wrote: > >>

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-22 12:53 GMT+08:00 Bruno Wolff III : > On Thu, Dec 21, 2017 at 17:16:03 -0600, > Bruno Wolff III wrote: >> >> >> Enforcing mode alone isn't enough as I tested that one one machine at home >> and it didn't trigger the problem. I'll try another machine late

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-22 12:53 GMT+08:00 Bruno Wolff III : > On Thu, Dec 21, 2017 at 17:16:03 -0600, > Bruno Wolff III wrote: >> >> >> Enforcing mode alone isn't enough as I tested that one one machine at home >> and it didn't trigger the problem. I'll try another machine late tonight. > > > I got the problem

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-22 1:02 GMT+08:00 Jens Axboe <ax...@kernel.dk>: > On 12/21/17 9:42 AM, Bruno Wolff III wrote: >> On Thu, Dec 21, 2017 at 23:48:19 +0800, >> weiping zhang <zwp10...@gmail.com> wrote: >>>> output you want. I never saw it for any kernels I compi

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-22 1:02 GMT+08:00 Jens Axboe : > On 12/21/17 9:42 AM, Bruno Wolff III wrote: >> On Thu, Dec 21, 2017 at 23:48:19 +0800, >> weiping zhang wrote: >>>> output you want. I never saw it for any kernels I compiled myself. Only >>>> when >&

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-21 23:36 GMT+08:00 Bruno Wolff III <br...@wolff.to>: > On Thu, Dec 21, 2017 at 23:31:40 +0800, > weiping zhang <zwp10...@gmail.com> wrote: >> >> does every time boot fail can trigger WANRING in device_add_disk ? > > > Not that I see. But the messag

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-21 23:36 GMT+08:00 Bruno Wolff III : > On Thu, Dec 21, 2017 at 23:31:40 +0800, > weiping zhang wrote: >> >> does every time boot fail can trigger WANRING in device_add_disk ? > > > Not that I see. But the message could scroll off the screen. The boot gets >

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-21 23:18 GMT+08:00 Bruno Wolff III <br...@wolff.to>: > On Thu, Dec 21, 2017 at 22:01:33 +0800, > weiping zhang <zwp10...@gmail.com> wrote: >> >> Hi, >> how do you do bisect ?build all kernel commit one by one ? >> as you did before: >> htt

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-21 23:18 GMT+08:00 Bruno Wolff III : > On Thu, Dec 21, 2017 at 22:01:33 +0800, > weiping zhang wrote: >> >> Hi, >> how do you do bisect ?build all kernel commit one by one ? >> as you did before: >> https://bugzilla.redhat.com/show_bug.cgi?id=1520982 &

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-21 21:00 GMT+08:00 Bruno Wolff III : > After today, I won't have physical access to the problem machine until > January 2nd. So if you guys have any testing suggestions I need them soon if > they are to get done before my vacation. > I do plan to try booting to level 1 to

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-21 21:00 GMT+08:00 Bruno Wolff III : > After today, I won't have physical access to the problem machine until > January 2nd. So if you guys have any testing suggestions I need them soon if > they are to get done before my vacation. > I do plan to try booting to level 1 to see if I can get

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-17 0:32 GMT+08:00 Bruno Wolff III : > On Fri, Dec 15, 2017 at 13:51:22 -0600, > Bruno Wolff III wrote: >> >> >> I do not know what is different. Do you have any ideas? Most likely I >> won't be able to test any more kernels until Monday (unless I can use

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-17 0:32 GMT+08:00 Bruno Wolff III : > On Fri, Dec 15, 2017 at 13:51:22 -0600, > Bruno Wolff III wrote: >> >> >> I do not know what is different. Do you have any ideas? Most likely I >> won't be able to test any more kernels until Monday (unless I can use most >> of my most recent build

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-15 19:10 GMT+08:00 Bruno Wolff III <br...@wolff.to>: > On Fri, Dec 15, 2017 at 10:04:32 +0800, > weiping zhang <zwp10...@gmail.com> wrote: >> >> I just want to know WARN_ON WHAT in device_add_disk, >> if bdi_register_owner return error code, it

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-15 19:10 GMT+08:00 Bruno Wolff III : > On Fri, Dec 15, 2017 at 10:04:32 +0800, > weiping zhang wrote: >> >> I just want to know WARN_ON WHAT in device_add_disk, >> if bdi_register_owner return error code, it may fail at any step of >> following: > > &g

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-15 9:44 GMT+08:00 Bruno Wolff III <br...@wolff.to>: > On Fri, Dec 15, 2017 at 09:22:21 +0800, > weiping zhang <zwp10...@gmail.com> wrote: >> >> >> Thanks your testing, but I cann't find WARN_ON in device_add_disk from >> this boot1.log, cou

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-15 9:44 GMT+08:00 Bruno Wolff III : > On Fri, Dec 15, 2017 at 09:22:21 +0800, > weiping zhang wrote: >> >> >> Thanks your testing, but I cann't find WARN_ON in device_add_disk from >> this boot1.log, could you help reproduce that issue? And does this issue &

Re: [PATCHv2] virtio_mmio: fix devm cleanup

; > > [3.810220] ret_from_fork+0x10/0x18 >> > > >> > > To fix this, we can simply rip out the explicit cleanup that the devm >> > > infrastructure will do for us when our probe function returns an error >> > > code, or when our remove function returns. &g

Re: [PATCHv2] virtio_mmio: fix devm cleanup

> >> > > To fix this, we can simply rip out the explicit cleanup that the devm >> > > infrastructure will do for us when our probe function returns an error >> > > code, or when our remove function returns. >> > > >> > > We only need

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-14 23:41 GMT+08:00 Bruno Wolff III <br...@wolff.to>: > On Thu, Dec 14, 2017 at 18:09:27 +0800, > weiping zhang <zhangweip...@didichuxing.com> wrote: >> >> >> It seems something wrong with bdi debugfs register, could you help >> test the fo

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

2017-12-14 23:41 GMT+08:00 Bruno Wolff III : > On Thu, Dec 14, 2017 at 18:09:27 +0800, > weiping zhang wrote: >> >> >> It seems something wrong with bdi debugfs register, could you help >> test the forllowing debug patch, I add some debug log, no function >>

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

the forllowing debug patch, I add some debug log, no function change, thanks. >From d2728c07589e8b83115a51e0c629451bff7308db Mon Sep 17 00:00:00 2001 From: weiping zhang <zhangweip...@didichuxing.com> Date: Thu, 14 Dec 2017 17:56:22 +0800 Subject: [PATCH] bdi debugfs Signed-off-by: weiping z

Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register")

, I add some debug log, no function change, thanks. >From d2728c07589e8b83115a51e0c629451bff7308db Mon Sep 17 00:00:00 2001 From: weiping zhang Date: Thu, 14 Dec 2017 17:56:22 +0800 Subject: [PATCH] bdi debugfs Signed-off-by: weiping zhang --- mm/backing-dev.c | 28

Re: [PATCHv2] virtio_mmio: fix devm cleanup

2017-12-12 22:45 GMT+08:00 Mark Rutland <mark.rutl...@arm.com>: > On Tue, Dec 12, 2017 at 10:26:24PM +0800, weiping zhang wrote: >> 2017-12-12 21:45 GMT+08:00 Mark Rutland <mark.rutl...@arm.com>: >> Hi Mark, > > Hi, > >> thanks your patch, I dig into the

Re: [PATCHv2] virtio_mmio: fix devm cleanup

2017-12-12 22:45 GMT+08:00 Mark Rutland : > On Tue, Dec 12, 2017 at 10:26:24PM +0800, weiping zhang wrote: >> 2017-12-12 21:45 GMT+08:00 Mark Rutland : >> Hi Mark, > > Hi, > >> thanks your patch, I dig into these three devm_xxx funciton, >> all of them represe

Re: [PATCHv2] virtio_mmio: fix devm cleanup

o ensure that we call put_device() if a call to > register_virtio_device() fails in the probe path. > > Signed-off-by: Mark Rutland <mark.rutl...@arm.com> > Fixes: 7eb781b1bbb7136f ("virtio_mmio: add cleanup for virtio_mmio_probe") > Fixes: 25f32223bce5c580 ("

Re: [PATCHv2] virtio_mmio: fix devm cleanup

ce() if a call to > register_virtio_device() fails in the probe path. > > Signed-off-by: Mark Rutland > Fixes: 7eb781b1bbb7136f ("virtio_mmio: add cleanup for virtio_mmio_probe") > Fixes: 25f32223bce5c580 ("virtio_mmio: add cleanup for vi