Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-02 Thread Patrick McHardy
Herbert Xu wrote: Patrick McHardy <[EMAIL PROTECTED]> wrote: Thanks. I'm not sure either, it would require two concurrent requests to be processed, but AFAICS oidentd only uses a single netlink socket. Perhaps multiple running instances or something else using the inet_diag interface?

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-02 Thread Patrick McHardy
Herbert Xu wrote: Patrick McHardy [EMAIL PROTECTED] wrote: Thanks. I'm not sure either, it would require two concurrent requests to be processed, but AFAICS oidentd only uses a single netlink socket. Perhaps multiple running instances or something else using the inet_diag interface?

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Herbert Xu
Patrick McHardy <[EMAIL PROTECTED]> wrote: > > Thanks. I'm not sure either, it would require two concurrent requests > to be processed, but AFAICS oidentd only uses a single netlink socket. > Perhaps multiple running instances or something else using the inet_diag > interface? Since identd

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Patrick McHardy
Athanasius wrote: On Sat, Sep 01, 2007 at 06:38:23PM +0200, Patrick McHardy wrote: You might be able to trigger it without this patch by running "while true; do ss -tn; done" while doing ident queries, but just running the while loop a couple of times in parallel doesn't seem to trigger it

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Athanasius
On Sat, Sep 01, 2007 at 06:38:23PM +0200, Patrick McHardy wrote: > Athanasius wrote: > > I'll compile up a new kernel, likely 2.6.22.6, plus this patch, and > >reboot to it tonight. I still don't know *exactly* how to trigger the > >bug on demand though, it's not reocurred since I posted the bug

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Patrick McHardy
Athanasius wrote: I'll compile up a new kernel, likely 2.6.22.6, plus this patch, and reboot to it tonight. I still don't know *exactly* how to trigger the bug on demand though, it's not reocurred since I posted the bug report (but had happened about a week before as well). Thanks. I'm not

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Patrick McHardy
Athanasius wrote: I'll compile up a new kernel, likely 2.6.22.6, plus this patch, and reboot to it tonight. I still don't know *exactly* how to trigger the bug on demand though, it's not reocurred since I posted the bug report (but had happened about a week before as well). Thanks. I'm not

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Athanasius
On Sat, Sep 01, 2007 at 06:38:23PM +0200, Patrick McHardy wrote: Athanasius wrote: I'll compile up a new kernel, likely 2.6.22.6, plus this patch, and reboot to it tonight. I still don't know *exactly* how to trigger the bug on demand though, it's not reocurred since I posted the bug report

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Patrick McHardy
Athanasius wrote: On Sat, Sep 01, 2007 at 06:38:23PM +0200, Patrick McHardy wrote: You might be able to trigger it without this patch by running while true; do ss -tn; done while doing ident queries, but just running the while loop a couple of times in parallel doesn't seem to trigger it here.

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-01 Thread Herbert Xu
Patrick McHardy [EMAIL PROTECTED] wrote: Thanks. I'm not sure either, it would require two concurrent requests to be processed, but AFAICS oidentd only uses a single netlink socket. Perhaps multiple running instances or something else using the inet_diag interface? Since identd serves

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-08-31 Thread Athanasius
On Fri, Aug 31, 2007 at 01:05:04PM +0200, Patrick McHardy wrote: > Seems to be a bug introduced by the netlink_run_queue conversion, > since there is no locking and netlink_run_queue doesn't check > for NULL results from skb_dequeue, it might pass NULL to > netlink_rcv_skb, which crashes. > >

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-08-31 Thread Athanasius
On Fri, Aug 31, 2007 at 01:05:04PM +0200, Patrick McHardy wrote: Seems to be a bug introduced by the netlink_run_queue conversion, since there is no locking and netlink_run_queue doesn't check for NULL results from skb_dequeue, it might pass NULL to netlink_rcv_skb, which crashes. Does this