Re: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
* Elliott, Robert (Server Storage) wrote: > > -Original Message- > > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > > Dan Williams > > Sent: Friday, April 17, 2015 8:35 PM > > To: linux-nvd...@lists.01.org > > Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem > > > ... > > create mode 100644 drivers/block/nd/acpi.c > > create mode 100644 drivers/block/nd/blk.c > > create mode 100644 drivers/block/nd/bus.c > > create mode 100644 drivers/block/nd/core.c > ... > > The kernel already has lots of files with these names: > 5 acpi.c > 10 bus.c > 66 core.c > > I often use ctags like this: > vim -t core.c > but that doesn’t immediately work with common filenames - it > presents a list of all 66 files to choose from. > > Also, blk.c is a name one might expect to see in the block/ > directory (e.g., next to blk.h). > > An nd_ prefix on all the filenames would help. It's really stupid to duplicate information that is present in the pathname. To type: vim -t nd/core.c should be the same as: vim -t nd_core.c Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
On Wed, Apr 22, 2015 at 12:06 PM, Elliott, Robert (Server Storage) wrote: >> -Original Message- >> From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of >> Dan Williams >> Sent: Friday, April 17, 2015 8:35 PM >> To: linux-nvd...@lists.01.org >> Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem >> > ... >> create mode 100644 drivers/block/nd/acpi.c >> create mode 100644 drivers/block/nd/blk.c >> create mode 100644 drivers/block/nd/bus.c >> create mode 100644 drivers/block/nd/core.c > ... > > The kernel already has lots of files with these names: > 5 acpi.c > 10 bus.c > 66 core.c > > I often use ctags like this: > vim -t core.c > but that doesn’t immediately work with common filenames - it > presents a list of all 66 files to choose from. > > Also, blk.c is a name one might expect to see in the block/ > directory (e.g., next to blk.h). > > An nd_ prefix on all the filenames would help. > I picked up the "don't duplicate the directory name in the source file name" approach from a review comment from Linus on a SCSI driver a long time back (iirc). I'm not motivated to stop that practice now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Dan Williams > Sent: Friday, April 17, 2015 8:35 PM > To: linux-nvd...@lists.01.org > Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem > ... > create mode 100644 drivers/block/nd/acpi.c > create mode 100644 drivers/block/nd/blk.c > create mode 100644 drivers/block/nd/bus.c > create mode 100644 drivers/block/nd/core.c ... The kernel already has lots of files with these names: 5 acpi.c 10 bus.c 66 core.c I often use ctags like this: vim -t core.c but that doesn’t immediately work with common filenames - it presents a list of all 66 files to choose from. Also, blk.c is a name one might expect to see in the block/ directory (e.g., next to blk.h). An nd_ prefix on all the filenames would help. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
-Original Message- From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of Dan Williams Sent: Friday, April 17, 2015 8:35 PM To: linux-nvd...@lists.01.org Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem ... create mode 100644 drivers/block/nd/acpi.c create mode 100644 drivers/block/nd/blk.c create mode 100644 drivers/block/nd/bus.c create mode 100644 drivers/block/nd/core.c ... The kernel already has lots of files with these names: 5 acpi.c 10 bus.c 66 core.c I often use ctags like this: vim -t core.c but that doesn’t immediately work with common filenames - it presents a list of all 66 files to choose from. Also, blk.c is a name one might expect to see in the block/ directory (e.g., next to blk.h). An nd_ prefix on all the filenames would help. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
On Wed, Apr 22, 2015 at 12:06 PM, Elliott, Robert (Server Storage) elli...@hp.com wrote: -Original Message- From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of Dan Williams Sent: Friday, April 17, 2015 8:35 PM To: linux-nvd...@lists.01.org Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem ... create mode 100644 drivers/block/nd/acpi.c create mode 100644 drivers/block/nd/blk.c create mode 100644 drivers/block/nd/bus.c create mode 100644 drivers/block/nd/core.c ... The kernel already has lots of files with these names: 5 acpi.c 10 bus.c 66 core.c I often use ctags like this: vim -t core.c but that doesn’t immediately work with common filenames - it presents a list of all 66 files to choose from. Also, blk.c is a name one might expect to see in the block/ directory (e.g., next to blk.h). An nd_ prefix on all the filenames would help. I picked up the don't duplicate the directory name in the source file name approach from a review comment from Linus on a SCSI driver a long time back (iirc). I'm not motivated to stop that practice now. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
* Elliott, Robert (Server Storage) elli...@hp.com wrote: -Original Message- From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of Dan Williams Sent: Friday, April 17, 2015 8:35 PM To: linux-nvd...@lists.01.org Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem ... create mode 100644 drivers/block/nd/acpi.c create mode 100644 drivers/block/nd/blk.c create mode 100644 drivers/block/nd/bus.c create mode 100644 drivers/block/nd/core.c ... The kernel already has lots of files with these names: 5 acpi.c 10 bus.c 66 core.c I often use ctags like this: vim -t core.c but that doesn’t immediately work with common filenames - it presents a list of all 66 files to choose from. Also, blk.c is a name one might expect to see in the block/ directory (e.g., next to blk.h). An nd_ prefix on all the filenames would help. It's really stupid to duplicate information that is present in the pathname. To type: vim -t nd/core.c should be the same as: vim -t nd_core.c Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/