Re: [Outreachy kernel] [PATCH] staging: rtl8712: Fixed 'tabstop' coding style warning

2018-03-01 Thread Julia Lawall


On Fri, 2 Mar 2018, Arushi Singhal wrote:

> Replace a mix of tabs and spaces indentation by tabs only.
>
> Fixed checkpatch warning "Statements should start on a tabstop" in
> rtl8712 module.

There is no need to say "in rtl8712 module".  That is apparent from the
subject line and the diffstat just below.

>
> Signed-off-by: Arushi Singhal 

Acked-by: Julia Lawall 


> ---
>  drivers/staging/rtl8712/drv_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h 
> b/drivers/staging/rtl8712/drv_types.h
> index ae79047..ede99e9 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -161,7 +161,7 @@ struct _adapter {
>   u8  EepromAddressSize;
>   u8  hw_init_completed;
>   struct task_struct *cmdThread;
> -  pid_t evtThread;
> + pid_t evtThread;
>   struct task_struct *xmitThread;
>   pid_t recvThread;
>   uint (*dvobj_init)(struct _adapter *adapter);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups 
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To post to this group, send email to outreachy-ker...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20180302024749.GA16440%40seema-Inspiron-15-3567.
> For more options, visit https://groups.google.com/d/optout.
>


Re: [Outreachy kernel] [PATCH] staging: rtl8712: Fixed 'tabstop' coding style warning

2018-03-01 Thread Julia Lawall


On Fri, 2 Mar 2018, Arushi Singhal wrote:

> Replace a mix of tabs and spaces indentation by tabs only.
>
> Fixed checkpatch warning "Statements should start on a tabstop" in
> rtl8712 module.

There is no need to say "in rtl8712 module".  That is apparent from the
subject line and the diffstat just below.

>
> Signed-off-by: Arushi Singhal 

Acked-by: Julia Lawall 


> ---
>  drivers/staging/rtl8712/drv_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h 
> b/drivers/staging/rtl8712/drv_types.h
> index ae79047..ede99e9 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -161,7 +161,7 @@ struct _adapter {
>   u8  EepromAddressSize;
>   u8  hw_init_completed;
>   struct task_struct *cmdThread;
> -  pid_t evtThread;
> + pid_t evtThread;
>   struct task_struct *xmitThread;
>   pid_t recvThread;
>   uint (*dvobj_init)(struct _adapter *adapter);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups 
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To post to this group, send email to outreachy-ker...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20180302024749.GA16440%40seema-Inspiron-15-3567.
> For more options, visit https://groups.google.com/d/optout.
>