Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress return logic

[Julia Lawall]

On Sun, 19 Feb 2017, simran singhal wrote:

> gre...@linuxfoundation.org,de...@driverdev.osuosl.org,linux-kernel@vger.kernel.org,outreachy-ker...@googlegroups.com
> Bcc:
> Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic
> Reply-To:

This didn't come out well.

>
> Simplify function returns by merging assignment and return into
> one command line.
> Found with Coccinelle
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
>  e;
> -return ret;
>
> Signed-off-by: simran singhal 
> ---
>
>  v2:
>-Removed assignment
>
>  drivers/staging/vt6655/card.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index e0c9281..9a8999f 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -918,9 +918,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, 
> u64 qwTSF2)
>
>   qwTSF2 += (u64)wRxBcnTSFOffst;
>
> - qwTSFOffset = qwTSF1 - qwTSF2;
> -
> - return qwTSFOffset;
> + return qwTSF1 - qwTSF2;

It's not just the assignment that can go.  All mentions of the variable
are useless, ie the declaration too.

julia

>  }
>
>  /*
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups 
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To post to this group, send email to outreachy-ker...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20170218210740.GA14258%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress return logic

[Julia Lawall]

On Sun, 19 Feb 2017, simran singhal wrote:

> gre...@linuxfoundation.org,de...@driverdev.osuosl.org,linux-kernel@vger.kernel.org,outreachy-ker...@googlegroups.com
> Bcc:
> Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic
> Reply-To:

This didn't come out well.

>
> Simplify function returns by merging assignment and return into
> one command line.
> Found with Coccinelle
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
>  e;
> -return ret;
>
> Signed-off-by: simran singhal 
> ---
>
>  v2:
>-Removed assignment
>
>  drivers/staging/vt6655/card.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index e0c9281..9a8999f 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -918,9 +918,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, 
> u64 qwTSF2)
>
>   qwTSF2 += (u64)wRxBcnTSFOffst;
>
> - qwTSFOffset = qwTSF1 - qwTSF2;
> -
> - return qwTSFOffset;
> + return qwTSF1 - qwTSF2;

It's not just the assignment that can go.  All mentions of the variable
are useless, ie the declaration too.

julia

>  }
>
>  /*
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups 
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To post to this group, send email to outreachy-ker...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20170218210740.GA14258%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>