Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

[Shawn Guo]

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only
> module inside PU power domain, and PU power
> is supplied by LDO_SOC.
> 
> Signed-off-by: Anson Huang 

Applied, thanks.

Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

[Shawn Guo]

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only
> module inside PU power domain, and PU power
> is supplied by LDO_SOC.
> 
> Signed-off-by: Anson Huang 

Applied, thanks.

RE: [PATCH] ARM: dts: imx6sx: add pu power domain support

[Anson Huang]

-Original Message-
From: Dong Aisheng [mailto:donga...@gmail.com] 
Sent: 2018年1月25日 23:30
To: Anson Huang <anson.hu...@nxp.com>
Cc: shawn...@kernel.org; ker...@pengutronix.de; Fabio Estevam 
<fabio.este...@nxp.com>; robh...@kernel.org; A.s. Dong <aisheng.d...@nxp.com>; 
mark.rutl...@arm.com; li...@armlinux.org.uk; dl-linux-imx <linux-...@nxp.com>; 
linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org; 
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only module inside PU power 
> domain, and PU power is supplied by LDO_SOC.
> 
> Signed-off-by: Anson Huang <anson.hu...@nxp.com>
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi 
> b/arch/arm/boot/dts/imx6sx.dtsi index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
>< IMX6SX_CLK_GPU>,
>< IMX6SX_CLK_GPU>;
>   clock-names = "bus", "core", "shader";
> + power-domains = <_pu>;
>   };
>  
>   dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
>   #address-cells = <1>;
>   #size-cells = <0>;
>  
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <_soc>;

I wonder we may not need this as it's a non-stop domain just like we did for 
arm domain, right?

Otherwise, the patch looks fine to me.

Acked-by: Dong Aisheng <aisheng.d...@nxp.com>

No, this domain can be power gated, there is an internal power gate in GPC, 
just the input
power can NOT be disabled. So there might be some leakage in this domain, but 
power still
can be saved a lot if internal power gate is off.

Anson.

Regards
Dong Aisheng

> + clocks = < IMX6SX_CLK_GPU>;
> + };
> +
>   pd_pci: power-domain@3 {
>   reg = <3>;
>   #power-domain-cells = <0>;
> --
> 2.7.4
> 

RE: [PATCH] ARM: dts: imx6sx: add pu power domain support

[Anson Huang]

-Original Message-
From: Dong Aisheng [mailto:donga...@gmail.com] 
Sent: 2018年1月25日 23:30
To: Anson Huang 
Cc: shawn...@kernel.org; ker...@pengutronix.de; Fabio Estevam 
; robh...@kernel.org; A.s. Dong ; 
mark.rutl...@arm.com; li...@armlinux.org.uk; dl-linux-imx ; 
linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org; 
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only module inside PU power 
> domain, and PU power is supplied by LDO_SOC.
> 
> Signed-off-by: Anson Huang 
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi 
> b/arch/arm/boot/dts/imx6sx.dtsi index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
>< IMX6SX_CLK_GPU>,
>< IMX6SX_CLK_GPU>;
>   clock-names = "bus", "core", "shader";
> + power-domains = <_pu>;
>   };
>  
>   dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
>   #address-cells = <1>;
>   #size-cells = <0>;
>  
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <_soc>;

I wonder we may not need this as it's a non-stop domain just like we did for 
arm domain, right?

Otherwise, the patch looks fine to me.

Acked-by: Dong Aisheng 

No, this domain can be power gated, there is an internal power gate in GPC, 
just the input
power can NOT be disabled. So there might be some leakage in this domain, but 
power still
can be saved a lot if internal power gate is off.

Anson.

Regards
Dong Aisheng

> + clocks = < IMX6SX_CLK_GPU>;
> + };
> +
>   pd_pci: power-domain@3 {
>   reg = <3>;
>   #power-domain-cells = <0>;
> --
> 2.7.4
> 

Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

[Dong Aisheng]

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only
> module inside PU power domain, and PU power
> is supplied by LDO_SOC.
> 
> Signed-off-by: Anson Huang 
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
>< IMX6SX_CLK_GPU>,
>< IMX6SX_CLK_GPU>;
>   clock-names = "bus", "core", "shader";
> + power-domains = <_pu>;
>   };
>  
>   dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
>   #address-cells = <1>;
>   #size-cells = <0>;
>  
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <_soc>;

I wonder we may not need this as it's a non-stop domain
just like we did for arm domain, right?

Otherwise, the patch looks fine to me.

Acked-by: Dong Aisheng 

Regards
Dong Aisheng

> + clocks = < IMX6SX_CLK_GPU>;
> + };
> +
>   pd_pci: power-domain@3 {
>   reg = <3>;
>   #power-domain-cells = <0>;
> -- 
> 2.7.4
> 

Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

[Dong Aisheng]

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only
> module inside PU power domain, and PU power
> is supplied by LDO_SOC.
> 
> Signed-off-by: Anson Huang 
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
>< IMX6SX_CLK_GPU>,
>< IMX6SX_CLK_GPU>;
>   clock-names = "bus", "core", "shader";
> + power-domains = <_pu>;
>   };
>  
>   dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
>   #address-cells = <1>;
>   #size-cells = <0>;
>  
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <_soc>;

I wonder we may not need this as it's a non-stop domain
just like we did for arm domain, right?

Otherwise, the patch looks fine to me.

Acked-by: Dong Aisheng 

Regards
Dong Aisheng

> + clocks = < IMX6SX_CLK_GPU>;
> + };
> +
>   pd_pci: power-domain@3 {
>   reg = <3>;
>   #power-domain-cells = <0>;
> -- 
> 2.7.4
> 

[PATCH] ARM: dts: imx6sx: add pu power domain support

[Anson Huang]

Add PU power domain support, GPU is the only
module inside PU power domain, and PU power
is supplied by LDO_SOC.

Signed-off-by: Anson Huang 
---
 arch/arm/boot/dts/imx6sx.dtsi | 8 
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index fd78793..42ef4c6 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -188,6 +188,7 @@
 < IMX6SX_CLK_GPU>,
 < IMX6SX_CLK_GPU>;
clock-names = "bus", "core", "shader";
+   power-domains = <_pu>;
};
 
dma_apbh: dma-apbh@1804000 {
@@ -767,6 +768,13 @@
#address-cells = <1>;
#size-cells = <0>;
 
+   pd_pu: power-domain@1 {
+   reg = <1>;
+   #power-domain-cells = <0>;
+   power-supply = <_soc>;
+   clocks = < IMX6SX_CLK_GPU>;
+   };
+
pd_pci: power-domain@3 {
reg = <3>;
#power-domain-cells = <0>;
-- 
2.7.4

[PATCH] ARM: dts: imx6sx: add pu power domain support

[Anson Huang]

Add PU power domain support, GPU is the only
module inside PU power domain, and PU power
is supplied by LDO_SOC.

Signed-off-by: Anson Huang 
---
 arch/arm/boot/dts/imx6sx.dtsi | 8 
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index fd78793..42ef4c6 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -188,6 +188,7 @@
 < IMX6SX_CLK_GPU>,
 < IMX6SX_CLK_GPU>;
clock-names = "bus", "core", "shader";
+   power-domains = <_pu>;
};
 
dma_apbh: dma-apbh@1804000 {
@@ -767,6 +768,13 @@
#address-cells = <1>;
#size-cells = <0>;
 
+   pd_pu: power-domain@1 {
+   reg = <1>;
+   #power-domain-cells = <0>;
+   power-supply = <_soc>;
+   clocks = < IMX6SX_CLK_GPU>;
+   };
+
pd_pci: power-domain@3 {
reg = <3>;
#power-domain-cells = <0>;
-- 
2.7.4