Re: [PATCH] ASoC: amd: Rectifying Unbalanced pm_runtime_enable! issue
On Tue, 30 Jun 2020 14:52:38 +0530, Ravulapati Vishnu vardhan rao wrote: > When snd_pci_acp3x driver loads we see: > > WARNING kernel:snd_pci_acp3x :04:00.5: Unbalanced pm_runtime_enable! > at boot time. > same can be observed in /var/log/messages/. > > Modifying pm runtime sequence for fixing unbalanced pm issue. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: amd: Rectifying Unbalanced pm_runtime_enable! issue commit: ad922ca199b38974dbe392e2faeba3aadf461ac2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
[PATCH] ASoC: amd: Rectifying Unbalanced pm_runtime_enable! issue
When snd_pci_acp3x driver loads we see: WARNING kernel:snd_pci_acp3x :04:00.5: Unbalanced pm_runtime_enable! at boot time. same can be observed in /var/log/messages/. Modifying pm runtime sequence for fixing unbalanced pm issue. Signed-off-by: Ravulapati Vishnu vardhan rao --- sound/soc/amd/raven/pci-acp3x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c index f25ce50f1a90..ebf4388b6262 100644 --- a/sound/soc/amd/raven/pci-acp3x.c +++ b/sound/soc/amd/raven/pci-acp3x.c @@ -232,9 +232,7 @@ static int snd_acp3x_probe(struct pci_dev *pci, } pm_runtime_set_autosuspend_delay(>dev, 2000); pm_runtime_use_autosuspend(>dev); - pm_runtime_set_active(>dev); pm_runtime_put_noidle(>dev); - pm_runtime_enable(>dev); pm_runtime_allow(>dev); return 0; @@ -303,7 +301,7 @@ static void snd_acp3x_remove(struct pci_dev *pci) ret = acp3x_deinit(adata->acp3x_base); if (ret) dev_err(>dev, "ACP de-init failed\n"); - pm_runtime_disable(>dev); + pm_runtime_forbid(>dev); pm_runtime_get_noresume(>dev); pci_disable_msi(pci); pci_release_regions(pci); -- 2.17.1
