Re: [PATCH] PCI/P2PDMA: Fix NULL check in pci_p2pmem_publish()

2018-10-17 Thread Bjorn Helgaas
On Wed, Oct 17, 2018 at 10:05:10AM -0600, Logan Gunthorpe wrote: > We should only assign 'p2pmem_published' if 'pdev->p2pdma' is not NULL. > The extra check on 'publish' makes no sense. > > Signed-off-by: Logan Gunthorpe > Reported-by: Dan Carpenter > Cc: Bjorn Helgaas > Cc: Christoph Hellwig

Re: [PATCH] PCI/P2PDMA: Fix NULL check in pci_p2pmem_publish()

2018-10-17 Thread Bjorn Helgaas
On Wed, Oct 17, 2018 at 10:05:10AM -0600, Logan Gunthorpe wrote: > We should only assign 'p2pmem_published' if 'pdev->p2pdma' is not NULL. > The extra check on 'publish' makes no sense. > > Signed-off-by: Logan Gunthorpe > Reported-by: Dan Carpenter > Cc: Bjorn Helgaas > Cc: Christoph Hellwig

[PATCH] PCI/P2PDMA: Fix NULL check in pci_p2pmem_publish()

2018-10-17 Thread Logan Gunthorpe
We should only assign 'p2pmem_published' if 'pdev->p2pdma' is not NULL. The extra check on 'publish' makes no sense. Signed-off-by: Logan Gunthorpe Reported-by: Dan Carpenter Cc: Bjorn Helgaas Cc: Christoph Hellwig --- drivers/pci/p2pdma.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH] PCI/P2PDMA: Fix NULL check in pci_p2pmem_publish()

2018-10-17 Thread Logan Gunthorpe
We should only assign 'p2pmem_published' if 'pdev->p2pdma' is not NULL. The extra check on 'publish' makes no sense. Signed-off-by: Logan Gunthorpe Reported-by: Dan Carpenter Cc: Bjorn Helgaas Cc: Christoph Hellwig --- drivers/pci/p2pdma.c | 6 ++ 1 file changed, 2 insertions(+), 4