Re: [PATCH] arch/h8300: fix kernel/dma.c build warning
On Sun, Jul 22, 2018 at 10:24:58AM -0700, Randy Dunlap wrote: > On 07/22/2018 02:25 AM, Geert Uytterhoeven wrote: > > CC hexagon > > > > hexagon != H8/300 != SuperH > > argh. Thanks. > > > On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: > >> > >> From: Randy Dunlap > >> > >> Fix build warning in arch/hexagon/kernel/dma.c by casting a void * > >> to unsigned long to match the function parameter type. > >> > >> ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': > >> ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of > >> 'gen_pool_add' makes integer from pointer without a cast [enabled by > >> default] > >> ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but > >> argument is of type 'void *' > >> > >> Signed-off-by: Randy Dunlap > >> Cc: Yoshinori Sato > >> Cc: Rich Felker > >> Cc: linux...@vger.kernel.org > >> --- > >> arch/hexagon/kernel/dma.c |2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> Thanks all the same! For Hexagon: Acked-by: Richard Kuo -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH] arch/h8300: fix kernel/dma.c build warning
On Sun, Jul 22, 2018 at 10:24:58AM -0700, Randy Dunlap wrote: > On 07/22/2018 02:25 AM, Geert Uytterhoeven wrote: > > CC hexagon > > > > hexagon != H8/300 != SuperH > > argh. Thanks. > > > On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: > >> > >> From: Randy Dunlap > >> > >> Fix build warning in arch/hexagon/kernel/dma.c by casting a void * > >> to unsigned long to match the function parameter type. > >> > >> ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': > >> ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of > >> 'gen_pool_add' makes integer from pointer without a cast [enabled by > >> default] > >> ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but > >> argument is of type 'void *' > >> > >> Signed-off-by: Randy Dunlap > >> Cc: Yoshinori Sato > >> Cc: Rich Felker > >> Cc: linux...@vger.kernel.org > >> --- > >> arch/hexagon/kernel/dma.c |2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> Thanks all the same! For Hexagon: Acked-by: Richard Kuo -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH] arch/h8300: fix kernel/dma.c build warning
On 07/22/2018 02:25 AM, Geert Uytterhoeven wrote: > CC hexagon > > hexagon != H8/300 != SuperH argh. Thanks. > On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: >> >> From: Randy Dunlap >> >> Fix build warning in arch/hexagon/kernel/dma.c by casting a void * >> to unsigned long to match the function parameter type. >> >> ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': >> ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of >> 'gen_pool_add' makes integer from pointer without a cast [enabled by default] >> ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but >> argument is of type 'void *' >> >> Signed-off-by: Randy Dunlap >> Cc: Yoshinori Sato >> Cc: Rich Felker >> Cc: linux...@vger.kernel.org >> --- >> arch/hexagon/kernel/dma.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c >> +++ linux-next-20180717/arch/hexagon/kernel/dma.c >> @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev, >> panic("Can't create %s() memory pool!", __func__); >> else >> gen_pool_add(coherent_pool, >> - pfn_to_virt(max_low_pfn), >> + (unsigned long)pfn_to_virt(max_low_pfn), >> hexagon_coherent_pool_size, -1); >> } >> > > Gr{oetje,eeting}s, > > Geert > -- ~Randy
Re: [PATCH] arch/h8300: fix kernel/dma.c build warning
On 07/22/2018 02:25 AM, Geert Uytterhoeven wrote: > CC hexagon > > hexagon != H8/300 != SuperH argh. Thanks. > On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: >> >> From: Randy Dunlap >> >> Fix build warning in arch/hexagon/kernel/dma.c by casting a void * >> to unsigned long to match the function parameter type. >> >> ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': >> ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of >> 'gen_pool_add' makes integer from pointer without a cast [enabled by default] >> ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but >> argument is of type 'void *' >> >> Signed-off-by: Randy Dunlap >> Cc: Yoshinori Sato >> Cc: Rich Felker >> Cc: linux...@vger.kernel.org >> --- >> arch/hexagon/kernel/dma.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c >> +++ linux-next-20180717/arch/hexagon/kernel/dma.c >> @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev, >> panic("Can't create %s() memory pool!", __func__); >> else >> gen_pool_add(coherent_pool, >> - pfn_to_virt(max_low_pfn), >> + (unsigned long)pfn_to_virt(max_low_pfn), >> hexagon_coherent_pool_size, -1); >> } >> > > Gr{oetje,eeting}s, > > Geert > -- ~Randy
Re: [PATCH] arch/h8300: fix kernel/dma.c build warning
CC hexagon hexagon != H8/300 != SuperH On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: > > From: Randy Dunlap > > Fix build warning in arch/hexagon/kernel/dma.c by casting a void * > to unsigned long to match the function parameter type. > > ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': > ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of > 'gen_pool_add' makes integer from pointer without a cast [enabled by default] > ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but > argument is of type 'void *' > > Signed-off-by: Randy Dunlap > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: linux...@vger.kernel.org > --- > arch/hexagon/kernel/dma.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c > +++ linux-next-20180717/arch/hexagon/kernel/dma.c > @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev, > panic("Can't create %s() memory pool!", __func__); > else > gen_pool_add(coherent_pool, > - pfn_to_virt(max_low_pfn), > + (unsigned long)pfn_to_virt(max_low_pfn), > hexagon_coherent_pool_size, -1); > } > Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] arch/h8300: fix kernel/dma.c build warning
CC hexagon hexagon != H8/300 != SuperH On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: > > From: Randy Dunlap > > Fix build warning in arch/hexagon/kernel/dma.c by casting a void * > to unsigned long to match the function parameter type. > > ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': > ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of > 'gen_pool_add' makes integer from pointer without a cast [enabled by default] > ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but > argument is of type 'void *' > > Signed-off-by: Randy Dunlap > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: linux...@vger.kernel.org > --- > arch/hexagon/kernel/dma.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c > +++ linux-next-20180717/arch/hexagon/kernel/dma.c > @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev, > panic("Can't create %s() memory pool!", __func__); > else > gen_pool_add(coherent_pool, > - pfn_to_virt(max_low_pfn), > + (unsigned long)pfn_to_virt(max_low_pfn), > hexagon_coherent_pool_size, -1); > } > Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
[PATCH] arch/h8300: fix kernel/dma.c build warning
From: Randy Dunlap Fix build warning in arch/hexagon/kernel/dma.c by casting a void * to unsigned long to match the function parameter type. ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of 'gen_pool_add' makes integer from pointer without a cast [enabled by default] ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but argument is of type 'void *' Signed-off-by: Randy Dunlap Cc: Yoshinori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org --- arch/hexagon/kernel/dma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c +++ linux-next-20180717/arch/hexagon/kernel/dma.c @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev, panic("Can't create %s() memory pool!", __func__); else gen_pool_add(coherent_pool, - pfn_to_virt(max_low_pfn), + (unsigned long)pfn_to_virt(max_low_pfn), hexagon_coherent_pool_size, -1); }
[PATCH] arch/h8300: fix kernel/dma.c build warning
From: Randy Dunlap Fix build warning in arch/hexagon/kernel/dma.c by casting a void * to unsigned long to match the function parameter type. ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of 'gen_pool_add' makes integer from pointer without a cast [enabled by default] ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but argument is of type 'void *' Signed-off-by: Randy Dunlap Cc: Yoshinori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org --- arch/hexagon/kernel/dma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c +++ linux-next-20180717/arch/hexagon/kernel/dma.c @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev, panic("Can't create %s() memory pool!", __func__); else gen_pool_add(coherent_pool, - pfn_to_virt(max_low_pfn), + (unsigned long)pfn_to_virt(max_low_pfn), hexagon_coherent_pool_size, -1); }