Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-05 Thread Chen Gang
On 3/5/15 19:40, Kalle Valo wrote: > Rafał Miłecki writes: > >> Kalle, I guess the recent discussion and work on this problem could be >> confusing, so let me try to sum it up it a bit. >> >> First of all, please note there are 3 awaiting bcma patches that >> should be applied independently of wh

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-05 Thread Kalle Valo
Rafał Miłecki writes: > Kalle, I guess the recent discussion and work on this problem could be > confusing, so let me try to sum it up it a bit. > > First of all, please note there are 3 awaiting bcma patches that > should be applied independently of what we decide to do with this > patch. They a

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 3 March 2015 at 22:16, Chen Gang wrote: > bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, > or will cause building break for allmodconfig under c6x: > > CC [M] drivers/bcma/driver_pcie2.o > drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up': > drivers/

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Michael Büsch
On Wed, 4 Mar 2015 14:36:10 +0100 Rafał Miłecki wrote: > Any other opinions? I think this is the only way to go. In ssb we always had optional pcicore driver, as far as I remember, so we should have the same in bcma, too. The old WRT54G kernel used to compile just fine with SSB and without any P

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 4 March 2015 at 17:38, Michael Büsch wrote: > On Wed, 4 Mar 2015 14:36:10 +0100 > Rafał Miłecki wrote: > >> Any other opinions? > > I think this is the only way to go. > In ssb we always had optional pcicore driver, as far as I remember, > so we should have the same in bcma, too. > The old WRT

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 4 March 2015 at 13:08, Rafał Miłecki wrote: > On 4 March 2015 at 07:19, Rafał Miłecki wrote: >> On 3 March 2015 at 22:16, Chen Gang wrote: >>> bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, >>> or will cause building break for allmodconfig under c6x: >>> >>> CC [M]

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 4 March 2015 at 07:19, Rafał Miłecki wrote: > On 3 March 2015 at 22:16, Chen Gang wrote: >> bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, >> or will cause building break for allmodconfig under c6x: >> >> CC [M] drivers/bcma/driver_pcie2.o >> drivers/bcma/driver_

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-03 Thread Chen Gang
Sorry for my carelessness, I deleted the original reply mail to me (may also deleted another mails to me, too). The hotmail is not stable, I am just struggling with it (it can not work well with linux-kernel@vger.kernel.org). Could you forward your original reply to me again? Thanks. On 3/4/15

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-03 Thread Rafał Miłecki
On 3 March 2015 at 22:16, Chen Gang wrote: > bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, > or will cause building break for allmodconfig under c6x: > > CC [M] drivers/bcma/driver_pcie2.o > drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up': > drivers/

[PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-03 Thread Chen Gang
bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, or will cause building break for allmodconfig under c6x: CC [M] drivers/bcma/driver_pcie2.o drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up': drivers/bcma/driver_pcie2.c:196:8: error: implicit declaration