Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-07-14 Thread Greg Kroah-Hartman 
On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
> Fix checkpatch.pl "space required before the open parenthesis '('" errors
> 
> Signed-off-by: Greg Donald 
> ---
>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 
> ++
>  1 file changed, 44 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
> b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index c2588f8..df20979 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -66,7 +66,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
>   pHTInfo->bRegBW40MHz = 1;
>  
>   // CCK rate support in 40MHz channel
> - if(pHTInfo->bRegBW40MHz)
> + if (pHTInfo->bRegBW40MHz)
>   pHTInfo->bRegSuppCCK = 1;
>   else
>   pHTInfo->bRegSuppCCK = true;
> @@ -82,7 +82,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
>  
>   // MIMO Power Save
>   pHTInfo->SelfMimoPs = 3;// 0: Static Mimo Ps, 1: Dynamic Mimo Ps, 3: No 
> Limitation, 2: Reserved(Set to 3 automatically.)
> - if(pHTInfo->SelfMimoPs == 2)
> + if (pHTInfo->SelfMimoPs == 2)
>   pHTInfo->SelfMimoPs = 3;
>   // 8190 only. Assign rate operation mode to firmware
>   ieee->bTxDisableRateFallBack = 0;
> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>   static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
> 11n EWC definition, 2007.07.17, by Emily
>   PHT_CAPABILITY_ELE  pCapELE;
>  
> - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
> - {
> + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {

Like others have pointed out, this is something different than what you
are saying you are doing, please break this up into different patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix space required before the open parenthesis '(' errors

2015-07-14 Thread Greg Kroah-Hartman 
On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
 Fix checkpatch.pl space required before the open parenthesis '(' errors
 
 Signed-off-by: Greg Donald gdon...@gmail.com
 ---
  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 
 ++
  1 file changed, 44 insertions(+), 53 deletions(-)
 
 diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
 b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 index c2588f8..df20979 100644
 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 @@ -66,7 +66,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
   pHTInfo-bRegBW40MHz = 1;
  
   // CCK rate support in 40MHz channel
 - if(pHTInfo-bRegBW40MHz)
 + if (pHTInfo-bRegBW40MHz)
   pHTInfo-bRegSuppCCK = 1;
   else
   pHTInfo-bRegSuppCCK = true;
 @@ -82,7 +82,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
  
   // MIMO Power Save
   pHTInfo-SelfMimoPs = 3;// 0: Static Mimo Ps, 1: Dynamic Mimo Ps, 3: No 
 Limitation, 2: Reserved(Set to 3 automatically.)
 - if(pHTInfo-SelfMimoPs == 2)
 + if (pHTInfo-SelfMimoPs == 2)
   pHTInfo-SelfMimoPs = 3;
   // 8190 only. Assign rate operation mode to firmware
   ieee-bTxDisableRateFallBack = 0;
 @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
   static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
 11n EWC definition, 2007.07.17, by Emily
   PHT_CAPABILITY_ELE  pCapELE;
  
 - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
 - {
 + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {

Like others have pointed out, this is something different than what you
are saying you are doing, please break this up into different patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-23 Thread Greg Donald 
On Tue, Jun 23, 2015 at 3:01 AM, Dan Carpenter  wrote:
> Actually, Greg complains about these all the time.

All I know is he's yet to turn away a single one of my patches.

> And here is a useless URL that you can look at:  http://slashdot.org
> I'm sure it supports my argument.
>
> But seriously, he does complain about these.

I've fixed more than one error on the same line many times.  My
useless URL supports that fact quite well.

And I'll be perfectly happy to send 5 separate patches for 5
individual errors, all for the same line of code, if that's what will
make you and Sudip stop complaining.. just as soon as you fix
checkpatch.pl to know an existing error from a new one.


-- 
Greg Donald
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-23 Thread Dan Carpenter 
On Mon, Jun 22, 2015 at 06:25:11AM -0500, Greg Donald wrote:
> Umm.. you have to fix more than one error if there's more than one
> error on or very near the same line you are already fixing, else
> checkpatch.pl complains that your patch has errors.  Not to mention
> Greg KH has never complained:
> 
> http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?qt=grep=gdonald
> 

Actually, Greg complains about these all the time.

And here is a useless URL that you can look at:  http://slashdot.org
I'm sure it supports my argument.

But seriously, he does complain about these.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix space required before the open parenthesis '(' errors

2015-06-23 Thread Dan Carpenter 
On Mon, Jun 22, 2015 at 06:25:11AM -0500, Greg Donald wrote:
 Umm.. you have to fix more than one error if there's more than one
 error on or very near the same line you are already fixing, else
 checkpatch.pl complains that your patch has errors.  Not to mention
 Greg KH has never complained:
 
 http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?qt=grepq=gdonald
 

Actually, Greg complains about these all the time.

And here is a useless URL that you can look at:  http://slashdot.org
I'm sure it supports my argument.

But seriously, he does complain about these.

regards,
dan carpenter

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix space required before the open parenthesis '(' errors

2015-06-23 Thread Greg Donald 
On Tue, Jun 23, 2015 at 3:01 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
 Actually, Greg complains about these all the time.

All I know is he's yet to turn away a single one of my patches.

 And here is a useless URL that you can look at:  http://slashdot.org
 I'm sure it supports my argument.

 But seriously, he does complain about these.

I've fixed more than one error on the same line many times.  My
useless URL supports that fact quite well.

And I'll be perfectly happy to send 5 separate patches for 5
individual errors, all for the same line of code, if that's what will
make you and Sudip stop complaining.. just as soon as you fix
checkpatch.pl to know an existing error from a new one.


-- 
Greg Donald
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-22 Thread Greg Donald 
Umm.. you have to fix more than one error if there's more than one
error on or very near the same line you are already fixing, else
checkpatch.pl complains that your patch has errors.  Not to mention
Greg KH has never complained:

http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?qt=grep=gdonald



On Mon, Jun 22, 2015 at 6:10 AM, Sudip Mukherjee
 wrote:
> On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
>> Fix checkpatch.pl "space required before the open parenthesis '('" errors
>>
>> Signed-off-by: Greg Donald 
>> ---
>>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 
>> ++
>>  1 file changed, 44 insertions(+), 53 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
>> b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
>> index c2588f8..df20979 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
>> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> 
>> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>>   static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
>> 11n EWC definition, 2007.07.17, by Emily
>>   PHT_CAPABILITY_ELE  pCapELE;
>>
>> - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
>> - {
>> + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
>   ^^^
> this becomes a different kind of change than what is mentioned in your
> commit message.
> You are also adding space after ',' later in your patch.
> please do only one kind of change in one patch.
>
> regards
> sudip



-- 
Greg Donald
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-22 Thread Sudip Mukherjee 
On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
> Fix checkpatch.pl "space required before the open parenthesis '('" errors
> 
> Signed-off-by: Greg Donald 
> ---
>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 
> ++
>  1 file changed, 44 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
> b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index c2588f8..df20979 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>   static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
> 11n EWC definition, 2007.07.17, by Emily
>   PHT_CAPABILITY_ELE  pCapELE;
>  
> - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
> - {
> + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
  ^^^
this becomes a different kind of change than what is mentioned in your
commit message.
You are also adding space after ',' later in your patch.
please do only one kind of change in one patch.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix space required before the open parenthesis '(' errors

2015-06-22 Thread Greg Donald 
Umm.. you have to fix more than one error if there's more than one
error on or very near the same line you are already fixing, else
checkpatch.pl complains that your patch has errors.  Not to mention
Greg KH has never complained:

http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?qt=grepq=gdonald



On Mon, Jun 22, 2015 at 6:10 AM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
 On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
 Fix checkpatch.pl space required before the open parenthesis '(' errors

 Signed-off-by: Greg Donald gdon...@gmail.com
 ---
  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 
 ++
  1 file changed, 44 insertions(+), 53 deletions(-)

 diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
 b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 index c2588f8..df20979 100644
 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 snip
 @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
   static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
 11n EWC definition, 2007.07.17, by Emily
   PHT_CAPABILITY_ELE  pCapELE;

 - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
 - {
 + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
   ^^^
 this becomes a different kind of change than what is mentioned in your
 commit message.
 You are also adding space after ',' later in your patch.
 please do only one kind of change in one patch.

 regards
 sudip



-- 
Greg Donald
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: staging: rtl8192u: Fix space required before the open parenthesis '(' errors

2015-06-22 Thread Sudip Mukherjee 
On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
 Fix checkpatch.pl space required before the open parenthesis '(' errors
 
 Signed-off-by: Greg Donald gdon...@gmail.com
 ---
  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 
 ++
  1 file changed, 44 insertions(+), 53 deletions(-)
 
 diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
 b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 index c2588f8..df20979 100644
 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
 +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
snip
 @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
   static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
 11n EWC definition, 2007.07.17, by Emily
   PHT_CAPABILITY_ELE  pCapELE;
  
 - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
 - {
 + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
  ^^^
this becomes a different kind of change than what is mentioned in your
commit message.
You are also adding space after ',' later in your patch.
please do only one kind of change in one patch.

regards
sudip
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-20 Thread Greg Donald 
Fix checkpatch.pl "space required before the open parenthesis '('" errors

Signed-off-by: Greg Donald 
---
 .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 ++
 1 file changed, 44 insertions(+), 53 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index c2588f8..df20979 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -66,7 +66,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
pHTInfo->bRegBW40MHz = 1;
 
// CCK rate support in 40MHz channel
-   if(pHTInfo->bRegBW40MHz)
+   if (pHTInfo->bRegBW40MHz)
pHTInfo->bRegSuppCCK = 1;
else
pHTInfo->bRegSuppCCK = true;
@@ -82,7 +82,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
 
// MIMO Power Save
pHTInfo->SelfMimoPs = 3;// 0: Static Mimo Ps, 1: Dynamic Mimo Ps, 3: No 
Limitation, 2: Reserved(Set to 3 automatically.)
-   if(pHTInfo->SelfMimoPs == 2)
+   if (pHTInfo->SelfMimoPs == 2)
pHTInfo->SelfMimoPs = 3;
// 8190 only. Assign rate operation mode to firmware
ieee->bTxDisableRateFallBack = 0;
@@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
11n EWC definition, 2007.07.17, by Emily
PHT_CAPABILITY_ELE  pCapELE;
 
-   if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
-   {
+   if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
//EWC IE
IEEE80211_DEBUG(IEEE80211_DL_HT, "EWC IE in %s()\n", __func__);
pCapELE = (PHT_CAPABILITY_ELE)([4]);
@@ -164,8 +163,7 @@ void HTDebugHTInfo(u8 *InfoIE, u8 *TitleString)
static u8   EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34};  // For 
11n EWC definition, 2007.07.17, by Emily
PHT_INFORMATION_ELE pHTInfoEle;
 
-   if(!memcmp(InfoIE, EWC11NHTInfo, sizeof(EWC11NHTInfo)))
-   {
+   if (!memcmp(InfoIE, EWC11NHTInfo, sizeof(EWC11NHTInfo))) {
// Not EWC IE
IEEE80211_DEBUG(IEEE80211_DL_HT, "EWC IE in %s()\n", __func__);
pHTInfoEle = (PHT_INFORMATION_ELE)([4]);
@@ -361,7 +359,7 @@ bool IsHTHalfNmodeAPs(struct ieee80211_device *ieee)
(memcmp(net->bssid, NETGEAR834Bv2_BROADCOM, 3)==0) ||
(net->broadcom_cap_exist))
  retValue = true;
-   else if(net->bssht.bdRT2RTAggregation)
+   else if (net->bssht.bdRT2RTAggregation)
retValue = true;
else
retValue = false;
@@ -382,23 +380,23 @@ static void HTIOTPeerDetermine(struct ieee80211_device 
*ieee)
struct ieee80211_network *net = >current_network;
if(net->bssht.bdRT2RTAggregation)
pHTInfo->IOTPeer = HT_IOT_PEER_REALTEK;
-   else if(net->broadcom_cap_exist)
+   else if (net->broadcom_cap_exist)
pHTInfo->IOTPeer = HT_IOT_PEER_BROADCOM;
-   else if((memcmp(net->bssid, UNKNOWN_BORADCOM, 3)==0) ||
+   else if ((memcmp(net->bssid, UNKNOWN_BORADCOM, 3) == 0) ||
(memcmp(net->bssid, 
LINKSYSWRT330_LINKSYSWRT300_BROADCOM, 3)==0)||
(memcmp(net->bssid, 
LINKSYSWRT350_LINKSYSWRT150_BROADCOM, 3)==0)||
(memcmp(net->bssid, NETGEAR834Bv2_BROADCOM, 3)==0) )
pHTInfo->IOTPeer = HT_IOT_PEER_BROADCOM;
-   else if((memcmp(net->bssid, BELKINF5D8233V1_RALINK, 3)==0) ||
+   else if ((memcmp(net->bssid, BELKINF5D8233V1_RALINK, 3) == 0) ||
(memcmp(net->bssid, BELKINF5D82334V3_RALINK, 3)==0) ||
(memcmp(net->bssid, PCI_RALINK, 3)==0) ||
(memcmp(net->bssid, EDIMAX_RALINK, 3)==0) ||
(memcmp(net->bssid, AIRLINK_RALINK, 3)==0) ||
 net->ralink_cap_exist)
pHTInfo->IOTPeer = HT_IOT_PEER_RALINK;
-   else if(net->atheros_cap_exist)
+   else if (net->atheros_cap_exist)
pHTInfo->IOTPeer = HT_IOT_PEER_ATHEROS;
-   else if(memcmp(net->bssid, CISCO_BROADCOM, 3)==0)
+   else if (memcmp(net->bssid, CISCO_BROADCOM, 3) == 0)
pHTInfo->IOTPeer = HT_IOT_PEER_CISCO;
else
pHTInfo->IOTPeer = HT_IOT_PEER_UNKNOWN;
@@ -555,8 +553,7 @@ void HTConstructCapabilityElement(struct ieee80211_device 
*ieee, u8 *posHTCap, u
return;
}
memset(posHTCap, 0, *len);
-   if(pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC)
-   {
+   if (pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC) {
u8  EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
11n EWC definition, 2007.07.17, by Emily
memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));

[PATCH] drivers: staging: rtl8192u: Fix space required before the open parenthesis '(' errors

2015-06-20 Thread Greg Donald 
Fix checkpatch.pl space required before the open parenthesis '(' errors

Signed-off-by: Greg Donald gdon...@gmail.com
---
 .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 ++
 1 file changed, 44 insertions(+), 53 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index c2588f8..df20979 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -66,7 +66,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
pHTInfo-bRegBW40MHz = 1;
 
// CCK rate support in 40MHz channel
-   if(pHTInfo-bRegBW40MHz)
+   if (pHTInfo-bRegBW40MHz)
pHTInfo-bRegSuppCCK = 1;
else
pHTInfo-bRegSuppCCK = true;
@@ -82,7 +82,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
 
// MIMO Power Save
pHTInfo-SelfMimoPs = 3;// 0: Static Mimo Ps, 1: Dynamic Mimo Ps, 3: No 
Limitation, 2: Reserved(Set to 3 automatically.)
-   if(pHTInfo-SelfMimoPs == 2)
+   if (pHTInfo-SelfMimoPs == 2)
pHTInfo-SelfMimoPs = 3;
// 8190 only. Assign rate operation mode to firmware
ieee-bTxDisableRateFallBack = 0;
@@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
static u8   EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
11n EWC definition, 2007.07.17, by Emily
PHT_CAPABILITY_ELE  pCapELE;
 
-   if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
-   {
+   if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
//EWC IE
IEEE80211_DEBUG(IEEE80211_DL_HT, EWC IE in %s()\n, __func__);
pCapELE = (PHT_CAPABILITY_ELE)(CapIE[4]);
@@ -164,8 +163,7 @@ void HTDebugHTInfo(u8 *InfoIE, u8 *TitleString)
static u8   EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34};  // For 
11n EWC definition, 2007.07.17, by Emily
PHT_INFORMATION_ELE pHTInfoEle;
 
-   if(!memcmp(InfoIE, EWC11NHTInfo, sizeof(EWC11NHTInfo)))
-   {
+   if (!memcmp(InfoIE, EWC11NHTInfo, sizeof(EWC11NHTInfo))) {
// Not EWC IE
IEEE80211_DEBUG(IEEE80211_DL_HT, EWC IE in %s()\n, __func__);
pHTInfoEle = (PHT_INFORMATION_ELE)(InfoIE[4]);
@@ -361,7 +359,7 @@ bool IsHTHalfNmodeAPs(struct ieee80211_device *ieee)
(memcmp(net-bssid, NETGEAR834Bv2_BROADCOM, 3)==0) ||
(net-broadcom_cap_exist))
  retValue = true;
-   else if(net-bssht.bdRT2RTAggregation)
+   else if (net-bssht.bdRT2RTAggregation)
retValue = true;
else
retValue = false;
@@ -382,23 +380,23 @@ static void HTIOTPeerDetermine(struct ieee80211_device 
*ieee)
struct ieee80211_network *net = ieee-current_network;
if(net-bssht.bdRT2RTAggregation)
pHTInfo-IOTPeer = HT_IOT_PEER_REALTEK;
-   else if(net-broadcom_cap_exist)
+   else if (net-broadcom_cap_exist)
pHTInfo-IOTPeer = HT_IOT_PEER_BROADCOM;
-   else if((memcmp(net-bssid, UNKNOWN_BORADCOM, 3)==0) ||
+   else if ((memcmp(net-bssid, UNKNOWN_BORADCOM, 3) == 0) ||
(memcmp(net-bssid, 
LINKSYSWRT330_LINKSYSWRT300_BROADCOM, 3)==0)||
(memcmp(net-bssid, 
LINKSYSWRT350_LINKSYSWRT150_BROADCOM, 3)==0)||
(memcmp(net-bssid, NETGEAR834Bv2_BROADCOM, 3)==0) )
pHTInfo-IOTPeer = HT_IOT_PEER_BROADCOM;
-   else if((memcmp(net-bssid, BELKINF5D8233V1_RALINK, 3)==0) ||
+   else if ((memcmp(net-bssid, BELKINF5D8233V1_RALINK, 3) == 0) ||
(memcmp(net-bssid, BELKINF5D82334V3_RALINK, 3)==0) ||
(memcmp(net-bssid, PCI_RALINK, 3)==0) ||
(memcmp(net-bssid, EDIMAX_RALINK, 3)==0) ||
(memcmp(net-bssid, AIRLINK_RALINK, 3)==0) ||
 net-ralink_cap_exist)
pHTInfo-IOTPeer = HT_IOT_PEER_RALINK;
-   else if(net-atheros_cap_exist)
+   else if (net-atheros_cap_exist)
pHTInfo-IOTPeer = HT_IOT_PEER_ATHEROS;
-   else if(memcmp(net-bssid, CISCO_BROADCOM, 3)==0)
+   else if (memcmp(net-bssid, CISCO_BROADCOM, 3) == 0)
pHTInfo-IOTPeer = HT_IOT_PEER_CISCO;
else
pHTInfo-IOTPeer = HT_IOT_PEER_UNKNOWN;
@@ -555,8 +553,7 @@ void HTConstructCapabilityElement(struct ieee80211_device 
*ieee, u8 *posHTCap, u
return;
}
memset(posHTCap, 0, *len);
-   if(pHT-ePeerHTSpecVer == HT_SPEC_VER_EWC)
-   {
+   if (pHT-ePeerHTSpecVer == HT_SPEC_VER_EWC) {
u8  EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};   // For 
11n EWC definition, 2007.07.17, by Emily
memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));