Re: [PATCH] dt-bindings: remove 'interrupt-parent' from bindings
On Mon, Jul 23, 2018 at 5:20 PM Vladimir Zapolskiy wrote: > > Hi Rob, > > On 07/24/2018 01:13 AM, Rob Herring wrote: > > 'interrupt-parent' is often documented as part of define bindings, but > > it is really outside the scope of a device binding. It's never required > > in a given node as it is often inherited from a parent node. Or it can > > be implicit if a parent node is an 'interrupt-controller' node. So > > remove it from all the binding files. > > > > Cc: Mark Rutland > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > [snip] > > > diff --git > > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > > > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > index 38211f344dc8..0bfb3ba55f4c 100644 > > --- > > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > +++ > > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > @@ -14,8 +14,6 @@ Required properties: > >Reset value is IRQ_TYPE_LEVEL_LOW. > > > > Optional properties: > > -- interrupt-parent: empty for MIC interrupt controller, link to parent > > - MIC interrupt controller for SIC1 and SIC2 > > - interrupts: empty for MIC interrupt controller, cascaded MIC > >hardware interrupts for SIC1 and SIC2 > > > > I would rather ask you to keep the property here, it is optional in sense that > its presence distinguishes MIC and SIC types of interrupt controllers. Sure, no problem. Hopefully I remember on the next round of wack-a-mole. Rob
Re: [PATCH] dt-bindings: remove 'interrupt-parent' from bindings
On Mon, Jul 23, 2018 at 5:20 PM Vladimir Zapolskiy wrote: > > Hi Rob, > > On 07/24/2018 01:13 AM, Rob Herring wrote: > > 'interrupt-parent' is often documented as part of define bindings, but > > it is really outside the scope of a device binding. It's never required > > in a given node as it is often inherited from a parent node. Or it can > > be implicit if a parent node is an 'interrupt-controller' node. So > > remove it from all the binding files. > > > > Cc: Mark Rutland > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > [snip] > > > diff --git > > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > > > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > index 38211f344dc8..0bfb3ba55f4c 100644 > > --- > > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > +++ > > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > > @@ -14,8 +14,6 @@ Required properties: > >Reset value is IRQ_TYPE_LEVEL_LOW. > > > > Optional properties: > > -- interrupt-parent: empty for MIC interrupt controller, link to parent > > - MIC interrupt controller for SIC1 and SIC2 > > - interrupts: empty for MIC interrupt controller, cascaded MIC > >hardware interrupts for SIC1 and SIC2 > > > > I would rather ask you to keep the property here, it is optional in sense that > its presence distinguishes MIC and SIC types of interrupt controllers. Sure, no problem. Hopefully I remember on the next round of wack-a-mole. Rob
Re: [PATCH] dt-bindings: remove 'interrupt-parent' from bindings
Hi Rob, On 07/24/2018 01:13 AM, Rob Herring wrote: > 'interrupt-parent' is often documented as part of define bindings, but > it is really outside the scope of a device binding. It's never required > in a given node as it is often inherited from a parent node. Or it can > be implicit if a parent node is an 'interrupt-controller' node. So > remove it from all the binding files. > > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- [snip] > diff --git > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > index 38211f344dc8..0bfb3ba55f4c 100644 > --- > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > +++ > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > @@ -14,8 +14,6 @@ Required properties: >Reset value is IRQ_TYPE_LEVEL_LOW. > > Optional properties: > -- interrupt-parent: empty for MIC interrupt controller, link to parent > - MIC interrupt controller for SIC1 and SIC2 > - interrupts: empty for MIC interrupt controller, cascaded MIC >hardware interrupts for SIC1 and SIC2 > I would rather ask you to keep the property here, it is optional in sense that its presence distinguishes MIC and SIC types of interrupt controllers. -- Best wishes, Vladimir
Re: [PATCH] dt-bindings: remove 'interrupt-parent' from bindings
Hi Rob, On 07/24/2018 01:13 AM, Rob Herring wrote: > 'interrupt-parent' is often documented as part of define bindings, but > it is really outside the scope of a device binding. It's never required > in a given node as it is often inherited from a parent node. Or it can > be implicit if a parent node is an 'interrupt-controller' node. So > remove it from all the binding files. > > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- [snip] > diff --git > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > index 38211f344dc8..0bfb3ba55f4c 100644 > --- > a/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > +++ > b/Documentation/devicetree/bindings/interrupt-controller/nxp,lpc3220-mic.txt > @@ -14,8 +14,6 @@ Required properties: >Reset value is IRQ_TYPE_LEVEL_LOW. > > Optional properties: > -- interrupt-parent: empty for MIC interrupt controller, link to parent > - MIC interrupt controller for SIC1 and SIC2 > - interrupts: empty for MIC interrupt controller, cascaded MIC >hardware interrupts for SIC1 and SIC2 > I would rather ask you to keep the property here, it is optional in sense that its presence distinguishes MIC and SIC types of interrupt controllers. -- Best wishes, Vladimir
