Re: [PATCH] fbdev: geocode: remove unneeded NULL check
On Sun, 01 Feb 2015 06:05:04 +0100 deloptes wrote: > Tomi Valkeinen wrote: > > > On 06/01/15 14:45, Sudip Mukherjee wrote: > >> the check for info is not required as we are checking it immediately > >> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM > >> if it is NULL. > >> > >> Signed-off-by: Sudip Mukherjee > >> --- > >> Hi Tomi, > >> This patch is similar to my last patch which you have already queued > >> for 3.20. if you can revert that then i can send you a single patch > >> with all these three changes together. > > > > No need for that, two separate patches is fine. So queued for 3.20. > > > > Tomi > > Hi sorry for off topic question, but how do you run 3.20 on geode ? > I was not able to boot anything since 2.27 as initrd (I guess udev ) > corrupts (I guess memory something) and boot hangs. > One suggested to bisect but no one explained how. > I would be glad to get some hint on how to run kernel with udev support on > geode (means >= 2.27) Tinycore has certainly been reported to run on Geode boxes as of 3.x kernel series. It might be worth trying a tinycore build on the device just to see how far it gets on your hardware. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fbdev: geocode: remove unneeded NULL check
Tomi Valkeinen wrote: > On 06/01/15 14:45, Sudip Mukherjee wrote: >> the check for info is not required as we are checking it immediately >> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM >> if it is NULL. >> >> Signed-off-by: Sudip Mukherjee >> --- >> Hi Tomi, >> This patch is similar to my last patch which you have already queued >> for 3.20. if you can revert that then i can send you a single patch >> with all these three changes together. > > No need for that, two separate patches is fine. So queued for 3.20. > > Tomi Hi sorry for off topic question, but how do you run 3.20 on geode ? I was not able to boot anything since 2.27 as initrd (I guess udev ) corrupts (I guess memory something) and boot hangs. One suggested to bisect but no one explained how. I would be glad to get some hint on how to run kernel with udev support on geode (means >= 2.27) thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fbdev: geocode: remove unneeded NULL check
Tomi Valkeinen wrote: On 06/01/15 14:45, Sudip Mukherjee wrote: the check for info is not required as we are checking it immediately after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM if it is NULL. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- Hi Tomi, This patch is similar to my last patch which you have already queued for 3.20. if you can revert that then i can send you a single patch with all these three changes together. No need for that, two separate patches is fine. So queued for 3.20. Tomi Hi sorry for off topic question, but how do you run 3.20 on geode ? I was not able to boot anything since 2.27 as initrd (I guess udev ) corrupts (I guess memory something) and boot hangs. One suggested to bisect but no one explained how. I would be glad to get some hint on how to run kernel with udev support on geode (means = 2.27) thanks -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fbdev: geocode: remove unneeded NULL check
On Sun, 01 Feb 2015 06:05:04 +0100 deloptes delop...@yahoo.com wrote: Tomi Valkeinen wrote: On 06/01/15 14:45, Sudip Mukherjee wrote: the check for info is not required as we are checking it immediately after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM if it is NULL. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- Hi Tomi, This patch is similar to my last patch which you have already queued for 3.20. if you can revert that then i can send you a single patch with all these three changes together. No need for that, two separate patches is fine. So queued for 3.20. Tomi Hi sorry for off topic question, but how do you run 3.20 on geode ? I was not able to boot anything since 2.27 as initrd (I guess udev ) corrupts (I guess memory something) and boot hangs. One suggested to bisect but no one explained how. I would be glad to get some hint on how to run kernel with udev support on geode (means = 2.27) Tinycore has certainly been reported to run on Geode boxes as of 3.x kernel series. It might be worth trying a tinycore build on the device just to see how far it gets on your hardware. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fbdev: geocode: remove unneeded NULL check
On 06/01/15 14:45, Sudip Mukherjee wrote: > the check for info is not required as we are checking it immediately > after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM > if it is NULL. > > Signed-off-by: Sudip Mukherjee > --- > Hi Tomi, > This patch is similar to my last patch which you have already queued > for 3.20. if you can revert that then i can send you a single patch > with all these three changes together. No need for that, two separate patches is fine. So queued for 3.20. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCH] fbdev: geocode: remove unneeded NULL check
On 06/01/15 14:45, Sudip Mukherjee wrote: the check for info is not required as we are checking it immediately after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM if it is NULL. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- Hi Tomi, This patch is similar to my last patch which you have already queued for 3.20. if you can revert that then i can send you a single patch with all these three changes together. No need for that, two separate patches is fine. So queued for 3.20. Tomi signature.asc Description: OpenPGP digital signature
[PATCH] fbdev: geocode: remove unneeded NULL check
the check for info is not required as we are checking it immediately
after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
if it is NULL.
Signed-off-by: Sudip Mukherjee
---
Hi Tomi,
This patch is similar to my last patch which you have already queued
for 3.20. if you can revert that then i can send you a single patch
with all these three changes together.
drivers/video/fbdev/geode/gxfb_core.c | 6 ++
drivers/video/fbdev/geode/lxfb_core.c | 6 ++
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/video/fbdev/geode/gxfb_core.c
b/drivers/video/fbdev/geode/gxfb_core.c
index 1790f14..124d7c7 100644
--- a/drivers/video/fbdev/geode/gxfb_core.c
+++ b/drivers/video/fbdev/geode/gxfb_core.c
@@ -444,10 +444,8 @@ static int gxfb_probe(struct pci_dev *pdev, const struct
pci_device_id *id)
pci_release_region(pdev, 1);
}
- if (info) {
- fb_dealloc_cmap(>cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(>cmap);
+ framebuffer_release(info);
return ret;
}
diff --git a/drivers/video/fbdev/geode/lxfb_core.c
b/drivers/video/fbdev/geode/lxfb_core.c
index 9e1d19d..138da6c 100644
--- a/drivers/video/fbdev/geode/lxfb_core.c
+++ b/drivers/video/fbdev/geode/lxfb_core.c
@@ -577,10 +577,8 @@ err:
pci_release_region(pdev, 3);
}
- if (info) {
- fb_dealloc_cmap(>cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(>cmap);
+ framebuffer_release(info);
return ret;
}
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fbdev: geocode: remove unneeded NULL check
the check for info is not required as we are checking it immediately
after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
if it is NULL.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Hi Tomi,
This patch is similar to my last patch which you have already queued
for 3.20. if you can revert that then i can send you a single patch
with all these three changes together.
drivers/video/fbdev/geode/gxfb_core.c | 6 ++
drivers/video/fbdev/geode/lxfb_core.c | 6 ++
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/video/fbdev/geode/gxfb_core.c
b/drivers/video/fbdev/geode/gxfb_core.c
index 1790f14..124d7c7 100644
--- a/drivers/video/fbdev/geode/gxfb_core.c
+++ b/drivers/video/fbdev/geode/gxfb_core.c
@@ -444,10 +444,8 @@ static int gxfb_probe(struct pci_dev *pdev, const struct
pci_device_id *id)
pci_release_region(pdev, 1);
}
- if (info) {
- fb_dealloc_cmap(info-cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(info-cmap);
+ framebuffer_release(info);
return ret;
}
diff --git a/drivers/video/fbdev/geode/lxfb_core.c
b/drivers/video/fbdev/geode/lxfb_core.c
index 9e1d19d..138da6c 100644
--- a/drivers/video/fbdev/geode/lxfb_core.c
+++ b/drivers/video/fbdev/geode/lxfb_core.c
@@ -577,10 +577,8 @@ err:
pci_release_region(pdev, 3);
}
- if (info) {
- fb_dealloc_cmap(info-cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(info-cmap);
+ framebuffer_release(info);
return ret;
}
--
1.8.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fbdev: geocode: remove unneeded NULL check
On 31/12/14 08:55, Sudip Mukherjee wrote:
> the check for info is not required as we are checking it immediately
> after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/video/fbdev/geode/gx1fb_core.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/geode/gx1fb_core.c
> b/drivers/video/fbdev/geode/gx1fb_core.c
> index 2794ba1..9bee874 100644
> --- a/drivers/video/fbdev/geode/gx1fb_core.c
> +++ b/drivers/video/fbdev/geode/gx1fb_core.c
> @@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const
> struct pci_device_id *id)
> release_mem_region(gx1_gx_base() + 0x8300, 0x100);
> }
>
> - if (info) {
> - fb_dealloc_cmap(>cmap);
> - framebuffer_release(info);
> - }
> + fb_dealloc_cmap(>cmap);
> + framebuffer_release(info);
>
> return ret;
> }
>
Thanks, queued for 3.20.
Tomi
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] fbdev: geocode: remove unneeded NULL check
On 31/12/14 08:55, Sudip Mukherjee wrote:
the check for info is not required as we are checking it immediately
after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/video/fbdev/geode/gx1fb_core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/geode/gx1fb_core.c
b/drivers/video/fbdev/geode/gx1fb_core.c
index 2794ba1..9bee874 100644
--- a/drivers/video/fbdev/geode/gx1fb_core.c
+++ b/drivers/video/fbdev/geode/gx1fb_core.c
@@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const
struct pci_device_id *id)
release_mem_region(gx1_gx_base() + 0x8300, 0x100);
}
- if (info) {
- fb_dealloc_cmap(info-cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(info-cmap);
+ framebuffer_release(info);
return ret;
}
Thanks, queued for 3.20.
Tomi
signature.asc
Description: OpenPGP digital signature
[PATCH] fbdev: geocode: remove unneeded NULL check
the check for info is not required as we are checking it immediately
after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/video/fbdev/geode/gx1fb_core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/geode/gx1fb_core.c
b/drivers/video/fbdev/geode/gx1fb_core.c
index 2794ba1..9bee874 100644
--- a/drivers/video/fbdev/geode/gx1fb_core.c
+++ b/drivers/video/fbdev/geode/gx1fb_core.c
@@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct
pci_device_id *id)
release_mem_region(gx1_gx_base() + 0x8300, 0x100);
}
- if (info) {
- fb_dealloc_cmap(>cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(>cmap);
+ framebuffer_release(info);
return ret;
}
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fbdev: geocode: remove unneeded NULL check
the check for info is not required as we are checking it immediately
after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/video/fbdev/geode/gx1fb_core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/geode/gx1fb_core.c
b/drivers/video/fbdev/geode/gx1fb_core.c
index 2794ba1..9bee874 100644
--- a/drivers/video/fbdev/geode/gx1fb_core.c
+++ b/drivers/video/fbdev/geode/gx1fb_core.c
@@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct
pci_device_id *id)
release_mem_region(gx1_gx_base() + 0x8300, 0x100);
}
- if (info) {
- fb_dealloc_cmap(info-cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(info-cmap);
+ framebuffer_release(info);
return ret;
}
--
1.8.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
