Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Using for_each_set_bit() to simplify the code. > > spatch with a semantic match is used to found this. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Wei Yongjun Applied with Eric's and Haojian's ACKs. Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Tue, Sep 18, 2012 at 1:56 PM, Haojian Zhuang wrote: > On Tue, Sep 18, 2012 at 1:43 PM, Eric Miao wrote: >> On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij >> wrote: >>> On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun wrote: >>> From: Wei Yongjun Using for_each_set_bit() to simplify the code. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun >>> >>> PXA maintainers: does this look OK? >> >> I seem to have Acked this already in another mail, if that got lost, here >> it is: >> >> Acked-by: Eric Miao >> > The another mail thread is for irq, not gpio. I'll apply it today. :) Thanks Haojian! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Tue, Sep 18, 2012 at 1:56 PM, Haojian Zhuang haojian.zhu...@gmail.com wrote: On Tue, Sep 18, 2012 at 1:43 PM, Eric Miao eric.y.m...@gmail.com wrote: On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using for_each_set_bit() to simplify the code. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn PXA maintainers: does this look OK? I seem to have Acked this already in another mail, if that got lost, here it is: Acked-by: Eric Miao eric.y.m...@gmail.com The another mail thread is for irq, not gpio. I'll apply it today. :) Thanks Haojian! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using for_each_set_bit() to simplify the code. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Applied with Eric's and Haojian's ACKs. Thanks! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Tue, Sep 18, 2012 at 1:43 PM, Eric Miao wrote: > On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij > wrote: >> On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun wrote: >> >>> From: Wei Yongjun >>> >>> Using for_each_set_bit() to simplify the code. >>> >>> spatch with a semantic match is used to found this. >>> (http://coccinelle.lip6.fr/) >>> >>> Signed-off-by: Wei Yongjun >> >> PXA maintainers: does this look OK? > > I seem to have Acked this already in another mail, if that got lost, here > it is: > > Acked-by: Eric Miao > The another mail thread is for irq, not gpio. I'll apply it today. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij wrote: > On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun wrote: > >> From: Wei Yongjun >> >> Using for_each_set_bit() to simplify the code. >> >> spatch with a semantic match is used to found this. >> (http://coccinelle.lip6.fr/) >> >> Signed-off-by: Wei Yongjun > > PXA maintainers: does this look OK? I seem to have Acked this already in another mail, if that got lost, here it is: Acked-by: Eric Miao > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij wrote: > On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun wrote: > >> From: Wei Yongjun >> >> Using for_each_set_bit() to simplify the code. >> >> spatch with a semantic match is used to found this. >> (http://coccinelle.lip6.fr/) >> >> Signed-off-by: Wei Yongjun > > PXA maintainers: does this look OK? > > Yours, > Linus Walleij It seems good. Acked-by: Haojian Zhuang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Using for_each_set_bit() to simplify the code. > > spatch with a semantic match is used to found this. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Wei Yongjun PXA maintainers: does this look OK? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using for_each_set_bit() to simplify the code. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn PXA maintainers: does this look OK? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using for_each_set_bit() to simplify the code. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn PXA maintainers: does this look OK? Yours, Linus Walleij It seems good. Acked-by: Haojian Zhuang haojian.zhu...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using for_each_set_bit() to simplify the code. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn PXA maintainers: does this look OK? I seem to have Acked this already in another mail, if that got lost, here it is: Acked-by: Eric Miao eric.y.m...@gmail.com Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: pxa: using for_each_set_bit to simplify the code
On Tue, Sep 18, 2012 at 1:43 PM, Eric Miao eric.y.m...@gmail.com wrote: On Mon, Sep 17, 2012 at 6:56 PM, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Sep 14, 2012 at 4:36 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using for_each_set_bit() to simplify the code. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn PXA maintainers: does this look OK? I seem to have Acked this already in another mail, if that got lost, here it is: Acked-by: Eric Miao eric.y.m...@gmail.com The another mail thread is for irq, not gpio. I'll apply it today. :) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] gpio: pxa: using for_each_set_bit to simplify the code
From: Wei Yongjun
Using for_each_set_bit() to simplify the code.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun
---
drivers/gpio/gpio-pxa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 9cac88a..a9e1a74 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -413,12 +413,10 @@ static void pxa_gpio_demux_handler(unsigned int irq,
struct irq_desc *desc)
gedr = gedr & c->irq_mask;
writel_relaxed(gedr, c->regbase + GEDR_OFFSET);
- n = find_first_bit(, BITS_PER_LONG);
- while (n < BITS_PER_LONG) {
+ for_each_set_bit(n, , BITS_PER_LONG) {
loop = 1;
generic_handle_irq(gpio_to_irq(gpio_base + n));
- n = find_next_bit(, BITS_PER_LONG, n + 1);
}
}
} while (loop);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] gpio: pxa: using for_each_set_bit to simplify the code
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Using for_each_set_bit() to simplify the code.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/gpio/gpio-pxa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 9cac88a..a9e1a74 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -413,12 +413,10 @@ static void pxa_gpio_demux_handler(unsigned int irq,
struct irq_desc *desc)
gedr = gedr c-irq_mask;
writel_relaxed(gedr, c-regbase + GEDR_OFFSET);
- n = find_first_bit(gedr, BITS_PER_LONG);
- while (n BITS_PER_LONG) {
+ for_each_set_bit(n, gedr, BITS_PER_LONG) {
loop = 1;
generic_handle_irq(gpio_to_irq(gpio_base + n));
- n = find_next_bit(gedr, BITS_PER_LONG, n + 1);
}
}
} while (loop);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
