[PATCH] hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
From: Joe Perches
Date: Thu, 26 Mar 2015 20:47:10 -0700
Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.
Signed-off-by: Joe Perches
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org # v2.6.36+
---
fs/hpfs/super.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
Index: linux-4.1/fs/hpfs/super.c
===
--- linux-4.1.orig/fs/hpfs/super.c 2015-06-22 21:28:15.0 +0200
+++ linux-4.1/fs/hpfs/super.c 2015-06-22 21:28:25.0 +0200
@@ -53,17 +53,20 @@ static void unmark_dirty(struct super_bl
}
/* Filesystem error... */
-static char err_buf[1024];
-
void hpfs_error(struct super_block *s, const char *fmt, ...)
{
+ struct va_format vaf;
va_list args;
va_start(args, fmt);
- vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+ vaf.fmt = fmt;
+ vaf.va =
+
+ pr_err("filesystem error: %pV", );
+
va_end(args);
- pr_err("filesystem error: %s", err_buf);
if (!hpfs_sb(s)->sb_was_error) {
if (hpfs_sb(s)->sb_err == 2) {
pr_cont("; crashing the system because you wanted
it\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
From: Joe Perches j...@perches.com
Date: Thu, 26 Mar 2015 20:47:10 -0700
Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.
Signed-off-by: Joe Perches j...@perches.com
Signed-off-by: Mikulas Patocka miku...@twibright.com
Cc: sta...@vger.kernel.org # v2.6.36+
---
fs/hpfs/super.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
Index: linux-4.1/fs/hpfs/super.c
===
--- linux-4.1.orig/fs/hpfs/super.c 2015-06-22 21:28:15.0 +0200
+++ linux-4.1/fs/hpfs/super.c 2015-06-22 21:28:25.0 +0200
@@ -53,17 +53,20 @@ static void unmark_dirty(struct super_bl
}
/* Filesystem error... */
-static char err_buf[1024];
-
void hpfs_error(struct super_block *s, const char *fmt, ...)
{
+ struct va_format vaf;
va_list args;
va_start(args, fmt);
- vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+ vaf.fmt = fmt;
+ vaf.va = args;
+
+ pr_err(filesystem error: %pV, vaf);
+
va_end(args);
- pr_err(filesystem error: %s, err_buf);
if (!hpfs_sb(s)-sb_was_error) {
if (hpfs_sb(s)-sb_err == 2) {
pr_cont(; crashing the system because you wanted
it\n);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.
Signed-off-by: Joe Perches
---
fs/hpfs/super.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 7cd00d3..f445d15 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -52,17 +52,20 @@ static void unmark_dirty(struct super_block *s)
}
/* Filesystem error... */
-static char err_buf[1024];
-
void hpfs_error(struct super_block *s, const char *fmt, ...)
{
+ struct va_format vaf;
va_list args;
va_start(args, fmt);
- vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+ vaf.fmt = fmt;
+ vaf.va =
+
+ pr_err("filesystem error: %pV", );
+
va_end(args);
- pr_err("filesystem error: %s", err_buf);
if (!hpfs_sb(s)->sb_was_error) {
if (hpfs_sb(s)->sb_err == 2) {
pr_cont("; crashing the system because you wanted
it\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.
Signed-off-by: Joe Perches j...@perches.com
---
fs/hpfs/super.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 7cd00d3..f445d15 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -52,17 +52,20 @@ static void unmark_dirty(struct super_block *s)
}
/* Filesystem error... */
-static char err_buf[1024];
-
void hpfs_error(struct super_block *s, const char *fmt, ...)
{
+ struct va_format vaf;
va_list args;
va_start(args, fmt);
- vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+ vaf.fmt = fmt;
+ vaf.va = args;
+
+ pr_err(filesystem error: %pV, vaf);
+
va_end(args);
- pr_err(filesystem error: %s, err_buf);
if (!hpfs_sb(s)-sb_was_error) {
if (hpfs_sb(s)-sb_err == 2) {
pr_cont(; crashing the system because you wanted
it\n);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
