Re: [PATCH] leds: Convert to using %pOFn instead of device_node.name
Hi Rob, Thank you for the patch. On 08/28/2018 03:52 AM, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Sakari Ailus > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: linux-l...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/leds/leds-as3645a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c > index f883616d9e60..98a69b1a43f9 100644 > --- a/drivers/leds/leds-as3645a.c > +++ b/drivers/leds/leds-as3645a.c > @@ -529,7 +529,7 @@ static int as3645a_parse_node(struct as3645a *flash, > strlcpy(names->flash, name, sizeof(names->flash)); > else > snprintf(names->flash, sizeof(names->flash), > - "%s:flash", node->name); > + "%pOFn:flash", node); > > rval = of_property_read_u32(flash->flash_node, "flash-timeout-us", > >flash_timeout_us); > @@ -573,7 +573,7 @@ static int as3645a_parse_node(struct as3645a *flash, > strlcpy(names->indicator, name, sizeof(names->indicator)); > else > snprintf(names->indicator, sizeof(names->indicator), > - "%s:indicator", node->name); > + "%pOFn:indicator", node); > > rval = of_property_read_u32(flash->indicator_node, "led-max-microamp", > >indicator_max_ua); > Applied. -- Best regards, Jacek Anaszewski
Re: [PATCH] leds: Convert to using %pOFn instead of device_node.name
Hi Rob, Thank you for the patch. On 08/28/2018 03:52 AM, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Sakari Ailus > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: linux-l...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/leds/leds-as3645a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c > index f883616d9e60..98a69b1a43f9 100644 > --- a/drivers/leds/leds-as3645a.c > +++ b/drivers/leds/leds-as3645a.c > @@ -529,7 +529,7 @@ static int as3645a_parse_node(struct as3645a *flash, > strlcpy(names->flash, name, sizeof(names->flash)); > else > snprintf(names->flash, sizeof(names->flash), > - "%s:flash", node->name); > + "%pOFn:flash", node); > > rval = of_property_read_u32(flash->flash_node, "flash-timeout-us", > >flash_timeout_us); > @@ -573,7 +573,7 @@ static int as3645a_parse_node(struct as3645a *flash, > strlcpy(names->indicator, name, sizeof(names->indicator)); > else > snprintf(names->indicator, sizeof(names->indicator), > - "%s:indicator", node->name); > + "%pOFn:indicator", node); > > rval = of_property_read_u32(flash->indicator_node, "led-max-microamp", > >indicator_max_ua); > Applied. -- Best regards, Jacek Anaszewski
Re: [PATCH] leds: Convert to using %pOFn instead of device_node.name
On Mon 2018-08-27 20:52:26, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Sakari Ailus > Cc: Jacek Anaszewski Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Re: [PATCH] leds: Convert to using %pOFn instead of device_node.name
On Mon 2018-08-27 20:52:26, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Sakari Ailus > Cc: Jacek Anaszewski Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Re: [PATCH] leds: Convert to using %pOFn instead of device_node.name
On Mon, Aug 27, 2018 at 08:52:26PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Sakari Ailus > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: linux-l...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi
Re: [PATCH] leds: Convert to using %pOFn instead of device_node.name
On Mon, Aug 27, 2018 at 08:52:26PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Sakari Ailus > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: linux-l...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi
[PATCH] leds: Convert to using %pOFn instead of device_node.name
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Sakari Ailus Cc: Jacek Anaszewski Cc: Pavel Machek Cc: linux-l...@vger.kernel.org Signed-off-by: Rob Herring --- drivers/leds/leds-as3645a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c index f883616d9e60..98a69b1a43f9 100644 --- a/drivers/leds/leds-as3645a.c +++ b/drivers/leds/leds-as3645a.c @@ -529,7 +529,7 @@ static int as3645a_parse_node(struct as3645a *flash, strlcpy(names->flash, name, sizeof(names->flash)); else snprintf(names->flash, sizeof(names->flash), -"%s:flash", node->name); +"%pOFn:flash", node); rval = of_property_read_u32(flash->flash_node, "flash-timeout-us", >flash_timeout_us); @@ -573,7 +573,7 @@ static int as3645a_parse_node(struct as3645a *flash, strlcpy(names->indicator, name, sizeof(names->indicator)); else snprintf(names->indicator, sizeof(names->indicator), -"%s:indicator", node->name); +"%pOFn:indicator", node); rval = of_property_read_u32(flash->indicator_node, "led-max-microamp", >indicator_max_ua); -- 2.17.1
[PATCH] leds: Convert to using %pOFn instead of device_node.name
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Sakari Ailus Cc: Jacek Anaszewski Cc: Pavel Machek Cc: linux-l...@vger.kernel.org Signed-off-by: Rob Herring --- drivers/leds/leds-as3645a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c index f883616d9e60..98a69b1a43f9 100644 --- a/drivers/leds/leds-as3645a.c +++ b/drivers/leds/leds-as3645a.c @@ -529,7 +529,7 @@ static int as3645a_parse_node(struct as3645a *flash, strlcpy(names->flash, name, sizeof(names->flash)); else snprintf(names->flash, sizeof(names->flash), -"%s:flash", node->name); +"%pOFn:flash", node); rval = of_property_read_u32(flash->flash_node, "flash-timeout-us", >flash_timeout_us); @@ -573,7 +573,7 @@ static int as3645a_parse_node(struct as3645a *flash, strlcpy(names->indicator, name, sizeof(names->indicator)); else snprintf(names->indicator, sizeof(names->indicator), -"%s:indicator", node->name); +"%pOFn:indicator", node); rval = of_property_read_u32(flash->indicator_node, "led-max-microamp", >indicator_max_ua); -- 2.17.1
