Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-29 Thread Andy Shevchenko
On Fri, Jun 29, 2018 at 6:30 PM, David Laight  wrote:
> From: YueHaibing
>> Sent: 29 June 2018 04:45
>>
>> On 2018/6/29 11:35, Randy Dunlap wrote:
>> > On 06/28/2018 08:33 PM, YueHaibing wrote:
>> >> Signed-off-by: YueHaibing 
>> >> ---
>> >>  lib/string.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > Hi,
>> >
>> > This isn't a typo.  "iff" means "if and only if".
>>
>> ok, my poor english, thank you.
>
> It's not really english, but a shorthand used by mathematicians.

I remember I did a very same mistake (and sent a patch!).

Perhaps better to fully spell it to avoid "once per 3 years" activity?

-- 
With Best Regards,
Andy Shevchenko


Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-29 Thread Andy Shevchenko
On Fri, Jun 29, 2018 at 6:30 PM, David Laight  wrote:
> From: YueHaibing
>> Sent: 29 June 2018 04:45
>>
>> On 2018/6/29 11:35, Randy Dunlap wrote:
>> > On 06/28/2018 08:33 PM, YueHaibing wrote:
>> >> Signed-off-by: YueHaibing 
>> >> ---
>> >>  lib/string.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > Hi,
>> >
>> > This isn't a typo.  "iff" means "if and only if".
>>
>> ok, my poor english, thank you.
>
> It's not really english, but a shorthand used by mathematicians.

I remember I did a very same mistake (and sent a patch!).

Perhaps better to fully spell it to avoid "once per 3 years" activity?

-- 
With Best Regards,
Andy Shevchenko


RE: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-29 Thread David Laight
From: YueHaibing
> Sent: 29 June 2018 04:45
> 
> On 2018/6/29 11:35, Randy Dunlap wrote:
> > On 06/28/2018 08:33 PM, YueHaibing wrote:
> >> Signed-off-by: YueHaibing 
> >> ---
> >>  lib/string.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hi,
> >
> > This isn't a typo.  "iff" means "if and only if".
> 
> ok, my poor english, thank you.

It's not really english, but a shorthand used by mathematicians.

David



RE: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-29 Thread David Laight
From: YueHaibing
> Sent: 29 June 2018 04:45
> 
> On 2018/6/29 11:35, Randy Dunlap wrote:
> > On 06/28/2018 08:33 PM, YueHaibing wrote:
> >> Signed-off-by: YueHaibing 
> >> ---
> >>  lib/string.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hi,
> >
> > This isn't a typo.  "iff" means "if and only if".
> 
> ok, my poor english, thank you.

It's not really english, but a shorthand used by mathematicians.

David



Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-28 Thread YueHaibing



On 2018/6/29 11:35, Randy Dunlap wrote:
> On 06/28/2018 08:33 PM, YueHaibing wrote:
>> Signed-off-by: YueHaibing 
>> ---
>>  lib/string.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi,
> 
> This isn't a typo.  "iff" means "if and only if".

ok, my poor english, thank you.

> 
>> diff --git a/lib/string.c b/lib/string.c
>> index 2c0900a..23ed944 100644
>> --- a/lib/string.c
>> +++ b/lib/string.c
>> @@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
>>   * @s1: one string
>>   * @s2: another string
>>   *
>> - * This routine returns true iff two strings are equal, treating both
>> + * This routine returns true if two strings are equal, treating both
>>   * NUL and newline-then-NUL as equivalent string terminations.  It's
>>   * geared for use with sysfs input strings, which generally terminate
>>   * with newlines but are compared against values without newlines.
>>
> 
> 



Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-28 Thread YueHaibing



On 2018/6/29 11:35, Randy Dunlap wrote:
> On 06/28/2018 08:33 PM, YueHaibing wrote:
>> Signed-off-by: YueHaibing 
>> ---
>>  lib/string.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi,
> 
> This isn't a typo.  "iff" means "if and only if".

ok, my poor english, thank you.

> 
>> diff --git a/lib/string.c b/lib/string.c
>> index 2c0900a..23ed944 100644
>> --- a/lib/string.c
>> +++ b/lib/string.c
>> @@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
>>   * @s1: one string
>>   * @s2: another string
>>   *
>> - * This routine returns true iff two strings are equal, treating both
>> + * This routine returns true if two strings are equal, treating both
>>   * NUL and newline-then-NUL as equivalent string terminations.  It's
>>   * geared for use with sysfs input strings, which generally terminate
>>   * with newlines but are compared against values without newlines.
>>
> 
> 



Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-28 Thread Randy Dunlap
On 06/28/2018 08:33 PM, YueHaibing wrote:
> Signed-off-by: YueHaibing 
> ---
>  lib/string.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

This isn't a typo.  "iff" means "if and only if".

> diff --git a/lib/string.c b/lib/string.c
> index 2c0900a..23ed944 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
>   * @s1: one string
>   * @s2: another string
>   *
> - * This routine returns true iff two strings are equal, treating both
> + * This routine returns true if two strings are equal, treating both
>   * NUL and newline-then-NUL as equivalent string terminations.  It's
>   * geared for use with sysfs input strings, which generally terminate
>   * with newlines but are compared against values without newlines.
> 


-- 
~Randy


Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-28 Thread Randy Dunlap
On 06/28/2018 08:33 PM, YueHaibing wrote:
> Signed-off-by: YueHaibing 
> ---
>  lib/string.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

This isn't a typo.  "iff" means "if and only if".

> diff --git a/lib/string.c b/lib/string.c
> index 2c0900a..23ed944 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
>   * @s1: one string
>   * @s2: another string
>   *
> - * This routine returns true iff two strings are equal, treating both
> + * This routine returns true if two strings are equal, treating both
>   * NUL and newline-then-NUL as equivalent string terminations.  It's
>   * geared for use with sysfs input strings, which generally terminate
>   * with newlines but are compared against values without newlines.
> 


-- 
~Randy


[PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-28 Thread YueHaibing
Signed-off-by: YueHaibing 
---
 lib/string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/string.c b/lib/string.c
index 2c0900a..23ed944 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
  * @s1: one string
  * @s2: another string
  *
- * This routine returns true iff two strings are equal, treating both
+ * This routine returns true if two strings are equal, treating both
  * NUL and newline-then-NUL as equivalent string terminations.  It's
  * geared for use with sysfs input strings, which generally terminate
  * with newlines but are compared against values without newlines.
-- 
2.7.0




[PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-28 Thread YueHaibing
Signed-off-by: YueHaibing 
---
 lib/string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/string.c b/lib/string.c
index 2c0900a..23ed944 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
  * @s1: one string
  * @s2: another string
  *
- * This routine returns true iff two strings are equal, treating both
+ * This routine returns true if two strings are equal, treating both
  * NUL and newline-then-NUL as equivalent string terminations.  It's
  * geared for use with sysfs input strings, which generally terminate
  * with newlines but are compared against values without newlines.
-- 
2.7.0