Re: [PATCH] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-08-17 Thread Tetsuo Handa
Ganapathi, how do you want to fix this bug? On 2020/07/29 3:45, Brian Norris wrote: >> syzbot is reporting that del_timer_sync() is called from >> mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without >> checking timer_setup() from mwifiex_usb_tx_init() was called [1]. >> Since

Re: [PATCH] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-07-28 Thread Brian Norris
Hi, On Mon, Jul 27, 2020 at 6:45 PM Tetsuo Handa wrote: > > syzbot is reporting that del_timer_sync() is called from > mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without > checking timer_setup() from mwifiex_usb_tx_init() was called [1]. > Since mwifiex_usb_prepare_tx_aggr_skb()

Re: [PATCH] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 4:46 AM Tetsuo Handa wrote: > > syzbot is reporting that del_timer_sync() is called from > mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without > checking timer_setup() from mwifiex_usb_tx_init() was called [1]. > Since mwifiex_usb_prepare_tx_aggr_skb() is

[PATCH] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-07-27 Thread Tetsuo Handa
syzbot is reporting that del_timer_sync() is called from mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without checking timer_setup() from mwifiex_usb_tx_init() was called [1]. Since mwifiex_usb_prepare_tx_aggr_skb() is calling del_timer() if is_hold_timer_set == true, use the same