Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled
On 09/03/13 15:31, Rob Herring wrote: > On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build warnings when CONFIG_OF is not enabled: > > It would be nice to know what arch/config you see this on. i386 and x86_64. > >> include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside >> parameter list [enabled by default] >> include/linux/of_irq.h:82:7: warning: its scope is only this definition or >> declaration, which is probably not what you want [enabled by default] >> include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside >> parameter list [enabled by default] >> >> Signed-off-by: Randy Dunlap >> Cc: Grant Likely >> Cc: Rob Herring >> Cc: devicet...@vger.kernel.org >> --- >> include/linux/of_irq.h |2 ++ >> 1 file changed, 2 insertions(+) >> >> --- linux-next-20130830.orig/include/linux/of_irq.h >> +++ linux-next-20130830/include/linux/of_irq.h >> @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_ >> #endif /* CONFIG_OF_IRQ */ >> >> #else /* !CONFIG_OF */ >> +struct device_node; > > Can you move this outside of the ifdefs to minimize the amount of ifdef'ed > code. I'm build testing that change now, but it seems odd to have it there in 2 ways when CONFIG_OF is enabled: struct device_node; #if defined(CONFIG_OF) #include will resend the patch shortly. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled
On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build warnings when CONFIG_OF is not enabled: It would be nice to know what arch/config you see this on. > include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside > parameter list [enabled by default] > include/linux/of_irq.h:82:7: warning: its scope is only this definition or > declaration, which is probably not what you want [enabled by default] > include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside > parameter list [enabled by default] > > Signed-off-by: Randy Dunlap > Cc: Grant Likely > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > --- > include/linux/of_irq.h |2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20130830.orig/include/linux/of_irq.h > +++ linux-next-20130830/include/linux/of_irq.h > @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_ > #endif /* CONFIG_OF_IRQ */ > > #else /* !CONFIG_OF */ > +struct device_node; Can you move this outside of the ifdefs to minimize the amount of ifdef'ed code. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled
On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap rdun...@infradead.org wrote: From: Randy Dunlap rdun...@infradead.org Fix build warnings when CONFIG_OF is not enabled: It would be nice to know what arch/config you see this on. include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default] include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default] Signed-off-by: Randy Dunlap rdun...@infradead.org Cc: Grant Likely grant.lik...@linaro.org Cc: Rob Herring rob.herr...@calxeda.com Cc: devicet...@vger.kernel.org --- include/linux/of_irq.h |2 ++ 1 file changed, 2 insertions(+) --- linux-next-20130830.orig/include/linux/of_irq.h +++ linux-next-20130830/include/linux/of_irq.h @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_ #endif /* CONFIG_OF_IRQ */ #else /* !CONFIG_OF */ +struct device_node; Can you move this outside of the ifdefs to minimize the amount of ifdef'ed code. Rob -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled
On 09/03/13 15:31, Rob Herring wrote: On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap rdun...@infradead.org wrote: From: Randy Dunlap rdun...@infradead.org Fix build warnings when CONFIG_OF is not enabled: It would be nice to know what arch/config you see this on. i386 and x86_64. include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default] include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default] Signed-off-by: Randy Dunlap rdun...@infradead.org Cc: Grant Likely grant.lik...@linaro.org Cc: Rob Herring rob.herr...@calxeda.com Cc: devicet...@vger.kernel.org --- include/linux/of_irq.h |2 ++ 1 file changed, 2 insertions(+) --- linux-next-20130830.orig/include/linux/of_irq.h +++ linux-next-20130830/include/linux/of_irq.h @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_ #endif /* CONFIG_OF_IRQ */ #else /* !CONFIG_OF */ +struct device_node; Can you move this outside of the ifdefs to minimize the amount of ifdef'ed code. I'm build testing that change now, but it seems odd to have it there in 2 ways when CONFIG_OF is enabled: struct device_node; #if defined(CONFIG_OF) #include linux/of.h will resend the patch shortly. -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled
From: Randy Dunlap
Fix build warnings when CONFIG_OF is not enabled:
include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside
parameter list [enabled by default]
include/linux/of_irq.h:82:7: warning: its scope is only this definition or
declaration, which is probably not what you want [enabled by default]
include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside
parameter list [enabled by default]
Signed-off-by: Randy Dunlap
Cc: Grant Likely
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
---
include/linux/of_irq.h |2 ++
1 file changed, 2 insertions(+)
--- linux-next-20130830.orig/include/linux/of_irq.h
+++ linux-next-20130830/include/linux/of_irq.h
@@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_
#endif /* CONFIG_OF_IRQ */
#else /* !CONFIG_OF */
+struct device_node;
+
static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
int index)
{
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled
From: Randy Dunlap rdun...@infradead.org
Fix build warnings when CONFIG_OF is not enabled:
include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside
parameter list [enabled by default]
include/linux/of_irq.h:82:7: warning: its scope is only this definition or
declaration, which is probably not what you want [enabled by default]
include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside
parameter list [enabled by default]
Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Grant Likely grant.lik...@linaro.org
Cc: Rob Herring rob.herr...@calxeda.com
Cc: devicet...@vger.kernel.org
---
include/linux/of_irq.h |2 ++
1 file changed, 2 insertions(+)
--- linux-next-20130830.orig/include/linux/of_irq.h
+++ linux-next-20130830/include/linux/of_irq.h
@@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_
#endif /* CONFIG_OF_IRQ */
#else /* !CONFIG_OF */
+struct device_node;
+
static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
int index)
{
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
